[GitHub] weex-bot commented on issue #1992: [jsfm] fix: judge if event is not defined
weex-bot commented on issue #1992: [jsfm] fix: judge if event is not defined URL: https://github.com/apache/incubator-weex/pull/1992#issuecomment-451072149 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wqyfavor opened a new pull request #1994: [iOS] Add display link task and report vdom, component count to apm b…
wqyfavor opened a new pull request #1994: [iOS] Add display link task and report vdom, component count to apm b… URL: https://github.com/apache/incubator-weex/pull/1994 …y task avoiding too much invocations. Hide header of WXDisplayLinkManager. First of all, thank you for your contribution! Please makes sure that these checkboxes are checked before submitting your PR, thank you! CheckList: **if** *isBugFix* **:** * [ ] Make sure that you add at least one unit test for the bug which you had fixed. **elif** *isNewFeature* **:** * [ ] Update API docs for the component. * [ ] Update/Add demo to demonstrate new feature. * [ ] Update test scripts for the feature. * [ ] Add unit tests for the feature. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alwaysfight opened a new pull request #1999: merge code to master
alwaysfight opened a new pull request #1999: merge code to master URL: https://github.com/apache/incubator-weex/pull/1999 First of all, thank you for your contribution! Please makes sure that these checkboxes are checked before submitting your PR, thank you! CheckList: **if** *isBugFix* **:** * [ ] Make sure that you add at least one unit test for the bug which you had fixed. **elif** *isNewFeature* **:** * [ ] Update API docs for the component. * [ ] Update/Add demo to demonstrate new feature. * [ ] Update test scripts for the feature. * [ ] Add unit tests for the feature. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #2001: * [Android] try to fix threadpool rejectException when ShutDown
weex-bot edited a comment on issue #2001: * [Android] try to fix threadpool rejectException when ShutDown URL: https://github.com/apache/incubator-weex/pull/2001#issuecomment-451128328 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zshshr closed pull request #1990: [iOS] Remove old tracing system.
zshshr closed pull request #1990: [iOS] Remove old tracing system.
URL: https://github.com/apache/incubator-weex/pull/1990
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ios/sdk/WeexSDK.xcodeproj/project.pbxproj
b/ios/sdk/WeexSDK.xcodeproj/project.pbxproj
index 23841ed0e4..d7c4e24a45 100644
--- a/ios/sdk/WeexSDK.xcodeproj/project.pbxproj
+++ b/ios/sdk/WeexSDK.xcodeproj/project.pbxproj
@@ -745,8 +745,6 @@
C401945E1E344E8300D19C31 /* WXFloatCompareTests.m in Sources */
= {isa = PBXBuildFile; fileRef = C401945D1E344E8300D19C31 /*
WXFloatCompareTests.m */; };
C41E1A971DC1FD15009C7F90 /* WXDatePickerManager.h in Headers */
= {isa = PBXBuildFile; fileRef = C41E1A951DC1FD15009C7F90 /*
WXDatePickerManager.h */; };
C41E1A981DC1FD15009C7F90 /* WXDatePickerManager.m in Sources */
= {isa = PBXBuildFile; fileRef = C41E1A961DC1FD15009C7F90 /*
WXDatePickerManager.m */; };
- C42E8F9B1F39DF07001EBE9D /* WXTracingProtocol.h in Headers */ =
{isa = PBXBuildFile; fileRef = C42E8F991F39DF07001EBE9D /* WXTracingProtocol.h
*/; settings = {ATTRIBUTES = (Public, ); }; };
- C42E8FAA1F3C7AA1001EBE9D /* WXTracingProtocol.h in Headers */ =
{isa = PBXBuildFile; fileRef = C42E8F991F39DF07001EBE9D /* WXTracingProtocol.h
*/; settings = {ATTRIBUTES = (Public, ); }; };
C42E8FAB1F3C7C09001EBE9D /* WXExtendCallNativeProtocol.h in
Headers */ = {isa = PBXBuildFile; fileRef = C4424E591F24DA3D009F52E2 /*
WXExtendCallNativeProtocol.h */; settings = {ATTRIBUTES = (Public, ); }; };
C42E8FAC1F3C7C3B001EBE9D /* WXExtendCallNativeManager.m in
Sources */ = {isa = PBXBuildFile; fileRef = C47B78CD1F2998EE001D3B0C /*
WXExtendCallNativeManager.m */; };
C42E8FAD1F3C7C3F001EBE9D /* WXExtendCallNativeManager.h in
Headers */ = {isa = PBXBuildFile; fileRef = C47B78CC1F2998EE001D3B0C /*
WXExtendCallNativeManager.h */; };
@@ -768,8 +766,6 @@
C4D872261E5DDF7500E39BC1 /* WXBoxShadow.m in Sources */ = {isa
= PBXBuildFile; fileRef = C4D872241E5DDF7500E39BC1 /* WXBoxShadow.m */; };
C4E375371E5FCBD3009B2D9C /* WXComponent+BoxShadow.m in Sources
*/ = {isa = PBXBuildFile; fileRef = C4E375351E5FCBD3009B2D9C /*
WXComponent+BoxShadow.m */; };
C4E375381E5FCBD3009B2D9C /* WXComponent+BoxShadow.h in Headers
*/ = {isa = PBXBuildFile; fileRef = C4E375361E5FCBD3009B2D9C /*
WXComponent+BoxShadow.h */; };
- C4E97D331F1EF46D00ABC314 /* WXTracingManager.h in Headers */ =
{isa = PBXBuildFile; fileRef = C4E97D311F1EF46D00ABC314 /* WXTracingManager.h
*/; settings = {ATTRIBUTES = (Public, ); }; };
- C4E97D341F1EF46D00ABC314 /* WXTracingManager.m in Sources */ =
{isa = PBXBuildFile; fileRef = C4E97D321F1EF46D00ABC314 /* WXTracingManager.m
*/; };
C4F0127D1E1502A6003378D0 /* WXWebSocketHandler.h in Headers */
= {isa = PBXBuildFile; fileRef = C4F012761E1502A6003378D0 /*
WXWebSocketHandler.h */; settings = {ATTRIBUTES = (Public, ); }; };
C4F012821E1502E9003378D0 /* WXWebSocketModule.h in Headers */ =
{isa = PBXBuildFile; fileRef = C4F012801E1502E9003378D0 /* WXWebSocketModule.h
*/; };
C4F012831E1502E9003378D0 /* WXWebSocketModule.m in Sources */ =
{isa = PBXBuildFile; fileRef = C4F012811E1502E9003378D0 /* WXWebSocketModule.m
*/; };
@@ -1047,8 +1043,6 @@
DCE2CF9D1F46D4370021BDC4 /* WXVoiceOverModule.m in Sources */ =
{isa = PBXBuildFile; fileRef = DCE2CF981F46D4220021BDC4 /* WXVoiceOverModule.m
*/; };
DCE7F1EF20AD358A00D471E7 /* WXPageEventNotifyEvent.h in Headers
*/ = {isa = PBXBuildFile; fileRef = DCE7F1EE20AD358A00D471E7 /*
WXPageEventNotifyEvent.h */; settings = {ATTRIBUTES = (Public, ); }; };
DCE7F1F020AD358A00D471E7 /* WXPageEventNotifyEvent.h in Headers
*/ = {isa = PBXBuildFile; fileRef = DCE7F1EE20AD358A00D471E7 /*
WXPageEventNotifyEvent.h */; settings = {ATTRIBUTES = (Public, ); }; };
- DCEA54621F2B7DB4000ECB23 /* WXTracingManager.h in Headers */ =
{isa = PBXBuildFile; fileRef = C4E97D311F1EF46D00ABC314 /* WXTracingManager.h
*/; settings = {ATTRIBUTES = (Public, ); }; };
- DCEA54631F2B7DBA000ECB23 /* WXTracingManager.m in Sources */ =
{isa = PBXBuildFile; fileRef = C4E97D321F1EF46D00ABC314 /* WXTracingManager.m
*/; };
DCF087611DCAE161005CD6EB /* WXInvocationConfig.h in Headers */
= {isa = PBXBuildFile; fileRef = DCF0875F1DCAE161005CD6EB /*
WXInvocationConfig.h */; };
DCF087621DCAE161005CD6EB /* WXInvocationConfig.m in Sources */
= {isa = PBXBuildFile; fileRef = DCF087601DCAE161005CD6EB /*
WXInvocationConfig.m */; };
[GitHub] imyzf opened a new pull request #1992: [jsfm] fix: judge if event is not defined
imyzf opened a new pull request #1992: [jsfm] fix: judge if event is not defined URL: https://github.com/apache/incubator-weex/pull/1992 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wqyfavor closed pull request #1996: [core] delete child node when delete parent node
wqyfavor closed pull request #1996: [core] delete child node when delete parent
node
URL: https://github.com/apache/incubator-weex/pull/1996
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/weex_core/Source/core/data_render/vnode/vnode.cc
b/weex_core/Source/core/data_render/vnode/vnode.cc
index 4524cc17d5..322e65db91 100644
--- a/weex_core/Source/core/data_render/vnode/vnode.cc
+++ b/weex_core/Source/core/data_render/vnode/vnode.cc
@@ -53,13 +53,13 @@ VNode::~VNode() {
delete events_;
events_ = nullptr;
}
-// for (auto it = child_list_.begin(); it != child_list_.end(); it++) {
-//VNode * = *it;
-//if (reference != nullptr) {
-// delete reference;
-// *it = nullptr;
-//}
-// }
+ for (auto it = child_list_.begin(); it != child_list_.end(); it++) {
+VNode * = *it;
+if (reference != nullptr) {
+ delete reference;
+ *it = nullptr;
+}
+ }
}
void VNode::OnEvent(const std::string , const std::string args,
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] weex-bot edited a comment on issue #1996: [core] delete child node when delete parent node
weex-bot edited a comment on issue #1996: [core] delete child node when delete parent node URL: https://github.com/apache/incubator-weex/pull/1996#issuecomment-451091766 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1997: [iOS] Remove old tracing system. Adapt for playground.
weex-bot edited a comment on issue #1997: [iOS] Remove old tracing system. Adapt for playground. URL: https://github.com/apache/incubator-weex/pull/1997#issuecomment-451096993 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zshshr closed pull request #1997: [iOS] Remove old tracing system. Adapt for playground.
zshshr closed pull request #1997: [iOS] Remove old tracing system. Adapt for playground. URL: https://github.com/apache/incubator-weex/pull/1997 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/WeexSDK.podspec b/WeexSDK.podspec index f0ae7627d1..2f47a803fb 100644 --- a/WeexSDK.podspec +++ b/WeexSDK.podspec @@ -78,7 +78,6 @@ Pod::Spec.new do |s| 'ios/sdk/WeexSDK/Sources/Monitor/WXMonitor.h', 'ios/sdk/WeexSDK/Sources/Monitor/WXExceptionUtils.h', 'ios/sdk/WeexSDK/Sources/Monitor/WXAnalyzerCenter.h', - 'ios/sdk/WeexSDK/Sources/Manager/WXTracingManager.h', 'ios/sdk/WeexSDK/Sources/Manager/WXSDKManager.h', 'ios/sdk/WeexSDK/Sources/Manager/WXBridgeManager.h', 'ios/sdk/WeexSDK/Sources/Manager/WXComponentManager.h', @@ -115,4 +114,4 @@ Pod::Spec.new do |s| s.libraries = 'c++' -end \ No newline at end of file +end diff --git a/ios/playground/Podfile b/ios/playground/Podfile index 67a828175b..8a4debb984 100644 --- a/ios/playground/Podfile +++ b/ios/playground/Podfile @@ -4,7 +4,7 @@ platform :ios, '8.0' def common pod 'WeexSDK', :path=>'../../' -pod 'WXDevtool','0.16.3' +pod 'WXDevtool','0.20.0' pod 'SDWebImage', '3.7.5' pod 'SocketRocket', '0.4.2' pod 'ATSDK-Weex', '0.0.1',:configurations => ['Debug'] diff --git a/ios/playground/WeexDemo/WXDemoViewController.m b/ios/playground/WeexDemo/WXDemoViewController.m index 02959719aa..69fb33d618 100644 --- a/ios/playground/WeexDemo/WXDemoViewController.m +++ b/ios/playground/WeexDemo/WXDemoViewController.m @@ -27,7 +27,6 @@ #import "DemoDefine.h" #import "WXPrerenderManager.h" #import "WXMonitor.h" -#import "WXTracingManager.h" @interface WXDemoViewController () @property (nonatomic, strong) WXSDKInstance *instance; This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aixiaoxiang removed a comment on issue #1287: [WEEX-475] fix Weex list component in the Android without scroll bars
aixiaoxiang removed a comment on issue #1287: [WEEX-475] fix Weex list component in the Android without scroll bars URL: https://github.com/apache/incubator-weex/pull/1287#issuecomment-451123155 @YorkShen 在安卓上不是想禁用滚动条，而是设置了showScrollbar=true，也不显示滚动条. 在安卓上list怎么设置都不显示滚动条 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aixiaoxiang commented on issue #1287: [WEEX-475] fix Weex list component in the Android without scroll bars
aixiaoxiang commented on issue #1287: [WEEX-475] fix Weex list component in the Android without scroll bars URL: https://github.com/apache/incubator-weex/pull/1287#issuecomment-451123155 @YorkShen 在安卓上不是想禁用滚动条，而是设置了showScrollbar=true，也不显示滚动条. 在安卓上list怎么设置都不显示滚动条 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aixiaoxiang commented on issue #1287: [WEEX-475] fix Weex list component in the Android without scroll bars
aixiaoxiang commented on issue #1287: [WEEX-475] fix Weex list component in the Android without scroll bars URL: https://github.com/apache/incubator-weex/pull/1287#issuecomment-451123152 @YorkShen 在安卓上不是想禁用滚动条，而是设置了showScrollbar=true，也不显示滚动条. 在安卓上list怎么设置都不显示滚动条 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #2001: * [Android] try to fix threadpool rejectException when ShutDown
weex-bot commented on issue #2001: * [Android] try to fix threadpool rejectException when ShutDown URL: https://github.com/apache/incubator-weex/pull/2001#issuecomment-451128328 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #2001: * [Android] try to fix threadpool rejectException when ShutDown
weex-bot edited a comment on issue #2001: * [Android] try to fix threadpool rejectException when ShutDown URL: https://github.com/apache/incubator-weex/pull/2001#issuecomment-451128328 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jianhan-he opened a new pull request #1991: merge release/20181220 to master
jianhan-he opened a new pull request #1991: merge release/20181220 to master URL: https://github.com/apache/incubator-weex/pull/1991 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 closed pull request #1992: [jsfm] fix: judge if event is not defined
Hanks10100 closed pull request #1992: [jsfm] fix: judge if event is not defined
URL: https://github.com/apache/incubator-weex/pull/1992
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/runtime/bridge/receiver.js b/runtime/bridge/receiver.js
index 22b29f2bac..c24cfffce8 100644
--- a/runtime/bridge/receiver.js
+++ b/runtime/bridge/receiver.js
@@ -23,7 +23,7 @@ function fireEvent (document, nodeId, type, event,
domChanges, params) {
const el = document.getRef(nodeId)
if (el) {
return document.fireEvent(el, type, event, domChanges, params)
- } else {
+ } else if (event) {
event._nodeId = nodeId
return document.fireEvent(document.getRef('_documentElement'), type,
event, domChanges, params)
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wqyfavor closed pull request #1991: merge release/20181220 to master
wqyfavor closed pull request #1991: merge release/20181220 to master
URL: https://github.com/apache/incubator-weex/pull/1991
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
b/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
index 6f55eb43f5..1470df71db 100644
--- a/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
+++ b/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
@@ -700,9 +700,8 @@ - (void)destroyInstance:(NSString *)instance
WXPerformBlockOnComponentThread(^{
[WXCoreBridge destroyDataRenderInstance:instance];
});
-} else {
-[self callJSMethod:@"destroyInstance" args:@[instance]];
}
+[self callJSMethod:@"destroyInstance" args:@[instance]];
}
- (void)forceGarbageCollection
diff --git a/weex_core/Source/core/data_render/vnode/vcomponent.cc
b/weex_core/Source/core/data_render/vnode/vcomponent.cc
index c4243dc059..2532cd30cd 100644
--- a/weex_core/Source/core/data_render/vnode/vcomponent.cc
+++ b/weex_core/Source/core/data_render/vnode/vcomponent.cc
@@ -45,7 +45,11 @@ VComponent::VComponent(ExecState *exec_state, int
template_id,
root_vnode_(nullptr),
exec_state_(exec_state) {}
-VComponent::~VComponent() {}
+VComponent::~VComponent() {
+ if (listener_ && !has_moved_) {
+listener_->OnDestroyed(this);
+ }
+}
static bool Equals(Value a, Value b) {
if (a.type != b.type) {
diff --git a/weex_core/Source/core/data_render/vnode/vnode.cc
b/weex_core/Source/core/data_render/vnode/vnode.cc
index 219ca1cb75..4524cc17d5 100644
--- a/weex_core/Source/core/data_render/vnode/vnode.cc
+++ b/weex_core/Source/core/data_render/vnode/vnode.cc
@@ -132,6 +132,7 @@ void VNode::AddChild(VNode *child) {
void VNode::InsertChild(VNode *child, int index) {
if (!child) return;
child->parent_ = this;
+ child->component_ = component_;
if (index < child_list_.size()) {
child_list_.insert(child_list_.begin() + index, child);
} else {
diff --git a/weex_core/Source/core/data_render/vnode/vnode.h
b/weex_core/Source/core/data_render/vnode/vnode.h
index 8cda5e5015..573915c645 100644
--- a/weex_core/Source/core/data_render/vnode/vnode.h
+++ b/weex_core/Source/core/data_render/vnode/vnode.h
@@ -112,8 +112,11 @@ class VNode {
inline bool HasChildren() { return !child_list_.empty(); }
- inline void set_component(VComponent* c) {
+ void set_component(VComponent* c) {
component_ = c;
+for (auto child : child_list_) {
+ child->set_component(c);
+}
}
inline VComponent* component() {
diff --git a/weex_core/Source/core/data_render/vnode/vnode_render_manager.cc
b/weex_core/Source/core/data_render/vnode/vnode_render_manager.cc
index 5875fee382..e85aed8b0b 100644
--- a/weex_core/Source/core/data_render/vnode/vnode_render_manager.cc
+++ b/weex_core/Source/core/data_render/vnode/vnode_render_manager.cc
@@ -451,7 +451,7 @@ void VNodeRenderManager::FireEvent(const std::string
_id, const std::string
{
// First way to fire event from VNode::OnEvent
auto vnode = iter->second->context()->GetVNode(ref);
-if (vnode) {
+if (vnode && vnode->event_params_map()) {
auto hit_test = vnode->event_params_map()->find(event);
if (hit_test != vnode->event_params_map()->end()) {
// If vnode has eat event, return.
@@ -463,7 +463,6 @@ void VNodeRenderManager::FireEvent(const std::string
_id, const std::string
// Second way to fire event from call vm func
auto vnode = node->second->FindNode(ref);
-if (vnode == nullptr)
if (!vnode) {
break;
}
@@ -868,24 +867,26 @@ void CompareAndApplyEvents1(const std::string& page_id,
VNode* old_node,
VNode* new_node) {
std::map old_events = *old_node->events();
std::map new_events = *new_node->events();
+ std::map remove_events;
+ std::map add_events;
for (auto it = old_events.cbegin(); it != old_events.cend(); it++) {
auto pos = new_events.find(it->first);
-if (pos != new_events.end()) {
- new_events.erase(pos);
+if (pos == new_events.end()) {
+ remove_events.insert(*it);
}
}
for (auto it = new_events.cbegin(); it != new_events.cend(); it++) {
auto pos = old_events.find(it->first);
-if (pos != old_events.end()) {
- old_events.erase(pos);
+if (pos == old_events.end()) {
+ add_events.insert(*it);
}
}
- for (auto it = old_events.cbegin(); it != old_events.cend(); it++) {
+ for (auto it = remove_events.cbegin(); it != remove_events.cend(); it++) {
RenderManager::GetInstance()->RemoveEvent(
page_id, new_node->render_object_ref(),
[GitHub] weex-bot commented on issue #1997: [iOS] Remove old tracing system. Adapt for playground.
weex-bot commented on issue #1997: [iOS] Remove old tracing system. Adapt for playground. URL: https://github.com/apache/incubator-weex/pull/1997#issuecomment-451096993 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1997: [iOS] Remove old tracing system. Adapt for playground.
weex-bot edited a comment on issue #1997: [iOS] Remove old tracing system. Adapt for playground. URL: https://github.com/apache/incubator-weex/pull/1997#issuecomment-451096993 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1999: merge code to master
weex-bot commented on issue #1999: merge code to master URL: https://github.com/apache/incubator-weex/pull/1999#issuecomment-451126779 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1999: merge code to master
weex-bot edited a comment on issue #1999: merge code to master URL: https://github.com/apache/incubator-weex/pull/1999#issuecomment-451126779 Fails :no_entry_sign: Code file ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm does not have the copyright header. Warnings :warning: No Changelog changes! :warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/list/template/jni/NativeRenderObjectUtils.java without metion it in commit message. You'd better add '@notdanger' in your commit log. Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #2000: * [Android] feature :send performane info to js delay 8s
weex-bot edited a comment on issue #2000: * [Android] feature :send performane info to js delay 8s URL: https://github.com/apache/incubator-weex/pull/2000#issuecomment-451127820 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1990: [iOS] Remove old tracing system.
weex-bot commented on issue #1990: [iOS] Remove old tracing system. URL: https://github.com/apache/incubator-weex/pull/1990#issuecomment-451062395 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1990: [iOS] Remove old tracing system.
weex-bot edited a comment on issue #1990: [iOS] Remove old tracing system. URL: https://github.com/apache/incubator-weex/pull/1990#issuecomment-451062395 Fails :no_entry_sign: Code file ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm does not have the copyright header. Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1992: [jsfm] fix: judge if event is not defined
weex-bot edited a comment on issue #1992: [jsfm] fix: judge if event is not defined URL: https://github.com/apache/incubator-weex/pull/1992#issuecomment-451072149 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1994: [iOS] Add display link task and report vdom, component count to apm b…
weex-bot edited a comment on issue #1994: [iOS] Add display link task and report vdom, component count to apm b… URL: https://github.com/apache/incubator-weex/pull/1994#issuecomment-451082534 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1996: [core] delete child node when delete parent node
weex-bot commented on issue #1996: [core] delete child node when delete parent node URL: https://github.com/apache/incubator-weex/pull/1996#issuecomment-451091766 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wqyfavor opened a new pull request #1997: [iOS] Remove old tracing system. Adapt for playground.
wqyfavor opened a new pull request #1997: [iOS] Remove old tracing system. Adapt for playground. URL: https://github.com/apache/incubator-weex/pull/1997 First of all, thank you for your contribution! Please makes sure that these checkboxes are checked before submitting your PR, thank you! CheckList: **if** *isBugFix* **:** * [ ] Make sure that you add at least one unit test for the bug which you had fixed. **elif** *isNewFeature* **:** * [ ] Update API docs for the component. * [ ] Update/Add demo to demonstrate new feature. * [ ] Update test scripts for the feature. * [ ] Add unit tests for the feature. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1994: [iOS] Add display link task and report vdom, component count to apm b…
weex-bot edited a comment on issue #1994: [iOS] Add display link task and report vdom, component count to apm b… URL: https://github.com/apache/incubator-weex/pull/1994#issuecomment-451082534 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1994: [iOS] Add display link task and report vdom, component count to apm b…
weex-bot commented on issue #1994: [iOS] Add display link task and report vdom, component count to apm b… URL: https://github.com/apache/incubator-weex/pull/1994#issuecomment-451082534 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1998: merge code to master from merge_code_refine branch
weex-bot commented on issue #1998: merge code to master from merge_code_refine branch URL: https://github.com/apache/incubator-weex/pull/1998#issuecomment-451121239 Fails :no_entry_sign: Code file ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm does not have the copyright header. Warnings :warning: No Changelog changes! :warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/list/template/jni/NativeRenderObjectUtils.java without metion it in commit message. You'd better add '@notdanger' in your commit log. Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1998: merge code to master from merge_code_refine branch
weex-bot edited a comment on issue #1998: merge code to master from merge_code_refine branch URL: https://github.com/apache/incubator-weex/pull/1998#issuecomment-451121239 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1998: merge code to master from merge_code_refine branch
weex-bot edited a comment on issue #1998: merge code to master from merge_code_refine branch URL: https://github.com/apache/incubator-weex/pull/1998#issuecomment-451121239 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lucky-chen opened a new pull request #2000: * [Android] feature :send performane info to js delay 8s
lucky-chen opened a new pull request #2000: * [Android] feature :send performane info to js delay 8s URL: https://github.com/apache/incubator-weex/pull/2000 send performane info to js delay 8s This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1991: merge release/20181220 to master
weex-bot commented on issue #1991: merge release/20181220 to master URL: https://github.com/apache/incubator-weex/pull/1991#issuecomment-451068643 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1991: merge release/20181220 to master
weex-bot edited a comment on issue #1991: merge release/20181220 to master URL: https://github.com/apache/incubator-weex/pull/1991#issuecomment-451068643 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1991: merge release/20181220 to master
weex-bot edited a comment on issue #1991: merge release/20181220 to master URL: https://github.com/apache/incubator-weex/pull/1991#issuecomment-451068643 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ypc2896 opened a new issue #1993: Weex 0.20.0 Android端 textarea 标签不会根据rows属性自适应高度
ypc2896 opened a new issue #1993: Weex 0.20.0 Android端 textarea 标签不会根据rows属性自适应高度 URL: https://github.com/apache/incubator-weex/issues/1993 0.18.0 textarea会根据rows自适应高度，升级为0.20.0以后，rows设置以后，textarea的高度只有一行半大小, 需要手动设置textarea 的高度 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jianhan-he opened a new pull request #1996: [core] delete child node when delete parent node
jianhan-he opened a new pull request #1996: [core] delete child node when delete parent node URL: https://github.com/apache/incubator-weex/pull/1996 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zshshr opened a new pull request #1998: merge code to master from merge_code_refine branch
zshshr opened a new pull request #1998: merge code to master from merge_code_refine branch URL: https://github.com/apache/incubator-weex/pull/1998 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zshshr closed pull request #1994: [iOS] Add display link task and report vdom, component count to apm b…
zshshr closed pull request #1994: [iOS] Add display link task and report vdom,
component count to apm b…
URL: https://github.com/apache/incubator-weex/pull/1994
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ios/sdk/WeexSDK.xcodeproj/project.pbxproj
b/ios/sdk/WeexSDK.xcodeproj/project.pbxproj
index d7c4e24a45..ba8efa81a8 100644
--- a/ios/sdk/WeexSDK.xcodeproj/project.pbxproj
+++ b/ios/sdk/WeexSDK.xcodeproj/project.pbxproj
@@ -90,9 +90,9 @@
4505D12C219B216D0083A1A2 /* class_window.cc in Sources */ =
{isa = PBXBuildFile; fileRef = 98399A8321916A9700D83CCE /* class_window.cc */;
};
4505D12D219B21760083A1A2 /* class_window.h in Headers */ = {isa
= PBXBuildFile; fileRef = 98399A8521916A9700D83CCE /* class_window.h */; };
4505D12E219B22630083A1A2 /* op_code.cc in Sources */ = {isa =
PBXBuildFile; fileRef = 98399A8A21916A9800D83CCE /* op_code.cc */; };
- 4532670A213FC84A00DAA620 /* WXDisplayLinkManager.h in Headers
*/ = {isa = PBXBuildFile; fileRef = 45326708213FC84900DAA620 /*
WXDisplayLinkManager.h */; settings = {ATTRIBUTES = (Public, ); }; };
+ 4532670A213FC84A00DAA620 /* WXDisplayLinkManager.h in Headers
*/ = {isa = PBXBuildFile; fileRef = 45326708213FC84900DAA620 /*
WXDisplayLinkManager.h */; };
4532670B213FC84A00DAA620 /* WXDisplayLinkManager.m in Sources
*/ = {isa = PBXBuildFile; fileRef = 45326709213FC84900DAA620 /*
WXDisplayLinkManager.m */; };
- 4532670C213FCF2300DAA620 /* WXDisplayLinkManager.h in Headers
*/ = {isa = PBXBuildFile; fileRef = 45326708213FC84900DAA620 /*
WXDisplayLinkManager.h */; settings = {ATTRIBUTES = (Public, ); }; };
+ 4532670C213FCF2300DAA620 /* WXDisplayLinkManager.h in Headers
*/ = {isa = PBXBuildFile; fileRef = 45326708213FC84900DAA620 /*
WXDisplayLinkManager.h */; };
4532670D213FCFB400DAA620 /* WXDisplayLinkManager.m in Sources
*/ = {isa = PBXBuildFile; fileRef = 45326709213FC84900DAA620 /*
WXDisplayLinkManager.m */; };
453267142140E38900DAA620 /* vcomponent.h in Headers */ = {isa =
PBXBuildFile; fileRef = 453267122140E38900DAA620 /* vcomponent.h */; };
453267152140E38900DAA620 /* vcomponent.cc in Sources */ = {isa
= PBXBuildFile; fileRef = 453267132140E38900DAA620 /* vcomponent.cc */; };
@@ -2750,7 +2750,6 @@
buildActionMask = 2147483647;
files = (
7715EB6221A69DD9001F1108 /* WXRichText.h in
Headers */,
- 4532670A213FC84A00DAA620 /*
WXDisplayLinkManager.h in Headers */,
B8D66C1B21255730003960BD /* style.h in Headers
*/,
B8D66C2321255730003960BD /* layout.h in Headers
*/,
B8D66C2521255730003960BD /* flex_enum.h in
Headers */,
@@ -2811,6 +2810,7 @@
B8D66C3121255730003960BD /*
render_action_appendtree_createfinish.h in Headers */,
B8F2C6EE2133A83C00635B37 /* class.h in Headers
*/,
B8D66C7F21255730003960BD /*
render_scroller_factory.h in Headers */,
+ 4532670A213FC84A00DAA620 /*
WXDisplayLinkManager.h in Headers */,
74A4BA5B1CABBBD000195969 /* WXDebugTool.h in
Headers */,
2A837AB41CD9DE9200AEDF03 /*
WXLoadingIndicator.h in Headers */,
45E0B4C121CB7B82005D1B3B /* WXConvertUtility.h
in Headers */,
@@ -3043,7 +3043,6 @@
buildActionMask = 2147483647;
files = (
7715EB6321A69DD9001F1108 /* WXRichText.h in
Headers */,
- 4532670C213FCF2300DAA620 /*
WXDisplayLinkManager.h in Headers */,
B8D66C1C21255730003960BD /* style.h in Headers
*/,
B8D66C2421255730003960BD /* layout.h in Headers
*/,
B8D66C2621255730003960BD /* flex_enum.h in
Headers */,
@@ -3103,6 +3102,7 @@
DCA445AC1EFA574A00D0CFA8 /* WXNetworkProtocol.h
in Headers */,
DCA445C31EFA57DC00D0CFA8 /*
WXAppMonitorProtocol.h in Headers */,
B8D66BC42125572F003960BD /*
vnode_render_context.h in Headers */,
+ 4532670C213FCF2300DAA620 /*
WXDisplayLinkManager.h in Headers */,
DCA445AF1EFA575D00D0CFA8 /* WXModuleProtocol.h
in Headers */,
4547FD102153932A00E79971 /*
js_common_function.h in
[GitHub] lucky-chen opened a new pull request #2001: * [Android] try to fix threadpool rejectException when ShutDown
lucky-chen opened a new pull request #2001: * [Android] try to fix threadpool rejectException when ShutDown URL: https://github.com/apache/incubator-weex/pull/2001 try to fix threadpool rejectException when ShutDown This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1999: merge code to master
weex-bot edited a comment on issue #1999: merge code to master URL: https://github.com/apache/incubator-weex/pull/1999#issuecomment-451126779 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #2000: * [Android] feature :send performane info to js delay 8s
weex-bot edited a comment on issue #2000: * [Android] feature :send performane info to js delay 8s URL: https://github.com/apache/incubator-weex/pull/2000#issuecomment-451127820 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #2000: * [Android] feature :send performane info to js delay 8s
weex-bot commented on issue #2000: * [Android] feature :send performane info to js delay 8s URL: https://github.com/apache/incubator-weex/pull/2000#issuecomment-451127820 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] metooweb commented on issue #1976: 有计划支持v-show吗
metooweb commented on issue #1976: 有计划支持v-show吗 URL: https://github.com/apache/incubator-weex/issues/1976#issuecomment-451725201 加上key就好了 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] fred-ye opened a new pull request #2007: [Bug Fixing] avoid crash when getFlatUIContext() return null
fred-ye opened a new pull request #2007: [Bug Fixing] avoid crash when getFlatUIContext() return null URL: https://github.com/apache/incubator-weex/pull/2007 First of all, thank you for your contribution! Please makes sure that these checkboxes are checked before submitting your PR, thank you! CheckList: **if** *isBugFix* **:** * [ ] Make sure that you add at least one unit test for the bug which you had fixed. **elif** *isNewFeature* **:** * [ ] Update API docs for the component. * [ ] Update/Add demo to demonstrate new feature. * [ ] Update test scripts for the feature. * [ ] Add unit tests for the feature. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #2007: [Bug Fixing] avoid crash when getFlatUIContext() return null
weex-bot edited a comment on issue #2007: [Bug Fixing] avoid crash when getFlatUIContext() return null URL: https://github.com/apache/incubator-weex/pull/2007#issuecomment-451795657 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #2007: [Bug Fixing] avoid crash when getFlatUIContext() return null
weex-bot edited a comment on issue #2007: [Bug Fixing] avoid crash when getFlatUIContext() return null URL: https://github.com/apache/incubator-weex/pull/2007#issuecomment-451795657 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #2007: [Bug Fixing] avoid crash when getFlatUIContext() return null
weex-bot edited a comment on issue #2007: [Bug Fixing] avoid crash when getFlatUIContext() return null URL: https://github.com/apache/incubator-weex/pull/2007#issuecomment-451795657 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #2007: [Bug Fixing] avoid crash when getFlatUIContext() return null
weex-bot edited a comment on issue #2007: [Bug Fixing] avoid crash when getFlatUIContext() return null URL: https://github.com/apache/incubator-weex/pull/2007#issuecomment-451795657 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] YorkShen closed pull request #1300: [WEEX-482][Android] Added support for multi-value headers(WXStreamModule)
YorkShen closed pull request #1300: [WEEX-482][Android] Added support for
multi-value headers(WXStreamModule)
URL: https://github.com/apache/incubator-weex/pull/1300
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/android/sdk/src/main/java/com/taobao/weex/http/WXStreamModule.java
b/android/sdk/src/main/java/com/taobao/weex/http/WXStreamModule.java
index d58f30ef6d..51369174b8 100644
--- a/android/sdk/src/main/java/com/taobao/weex/http/WXStreamModule.java
+++ b/android/sdk/src/main/java/com/taobao/weex/http/WXStreamModule.java
@@ -324,8 +324,12 @@ public void onHeadersReceived(int
statusCode,Map> headers) {
Iterator>> it =
headers.entrySet().iterator();
while (it.hasNext()) {
Map.Entry> entry = it.next();
- if (entry.getValue().size() > 0) {
+ if (entry.getValue().size() == 0) {
+continue;
+ } else if (entry.getValue().size() == 1)
simpleHeaders.put(entry.getKey() == null ? "_" : entry.getKey(),
entry.getValue().get(0));
+ else {
+simpleHeaders.put(entry.getKey() == null ? "_" : entry.getKey(),
entry.getValue().toString());
}
}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] weex-bot commented on issue #2007: [Bug Fixing] avoid crash when getFlatUIContext() return null
weex-bot commented on issue #2007: [Bug Fixing] avoid crash when getFlatUIContext() return null URL: https://github.com/apache/incubator-weex/pull/2007#issuecomment-451795657 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #2007: [Bug Fixing] avoid crash when getFlatUIContext() return null
weex-bot edited a comment on issue #2007: [Bug Fixing] avoid crash when getFlatUIContext() return null URL: https://github.com/apache/incubator-weex/pull/2007#issuecomment-451795657 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] YorkShen closed pull request #1975: [Weex][android] feat: add bindingx weex plugin
YorkShen closed pull request #1975: [Weex][android] feat: add bindingx weex
plugin
URL: https://github.com/apache/incubator-weex/pull/1975
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/android/playground/app/build.gradle
b/android/playground/app/build.gradle
index b59c758963..e5b78323e2 100755
--- a/android/playground/app/build.gradle
+++ b/android/playground/app/build.gradle
@@ -118,6 +118,10 @@ dependencies {
compile 'com.android.support.test.espresso:espresso-idling-resource:2.2.2'
compile 'com.taobao.android:weex_inspector:0.18.10'
//compile project(":weex_inspector")
+
+// Bind actions to effects. See https://alibaba.github.io/bindingx/
+compile 'com.alibaba.android:bindingx-core:1.1.1.2@aar'
+compile 'com.alibaba.android:bindingx_weex_plugin:1.1.1@aar'
}
if(file('../../license/LICENSE').exists()){
diff --git
a/android/playground/app/src/main/java/com/alibaba/weex/WXApplication.java
b/android/playground/app/src/main/java/com/alibaba/weex/WXApplication.java
index 99a883fe89..e45138322f 100644
--- a/android/playground/app/src/main/java/com/alibaba/weex/WXApplication.java
+++ b/android/playground/app/src/main/java/com/alibaba/weex/WXApplication.java
@@ -22,6 +22,7 @@
import android.app.Application;
import android.os.Bundle;
+import com.alibaba.android.bindingx.plugin.weex.BindingX;
import com.alibaba.weex.commons.adapter.DefaultWebSocketAdapterFactory;
import com.alibaba.weex.commons.adapter.ImageAdapter;
import com.alibaba.weex.commons.adapter.JSExceptionAdapter;
@@ -30,7 +31,6 @@
import com.alibaba.weex.extend.adapter.DefaultAccessibilityRoleAdapter;
import com.alibaba.weex.extend.adapter.InterceptWXHttpAdapter;
import com.alibaba.weex.extend.adapter.WXAnalyzerDemoListener;
-import com.alibaba.weex.extend.component.RichText;
import com.alibaba.weex.extend.component.WXComponentSyncTest;
import com.alibaba.weex.extend.component.WXMask;
import com.alibaba.weex.extend.component.WXParallax;
@@ -104,6 +104,7 @@ public void onCreate() {
WXSDKEngine.registerModule("wsonTest", WXWsonTestModule.class);
+ BindingX.register();
/**
* override default image tag
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] YorkShen closed pull request #2007: [Bug Fixing] avoid crash when getFlatUIContext() return null
YorkShen closed pull request #2007: [Bug Fixing] avoid crash when
getFlatUIContext() return null
URL: https://github.com/apache/incubator-weex/pull/2007
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXDiv.java
b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXDiv.java
index 8af5a10630..c4fbbab64f 100644
--- a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXDiv.java
+++ b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXDiv.java
@@ -69,8 +69,11 @@ protected WXFrameLayout initComponentHostView(@NonNull
Context context) {
@Override
public boolean promoteToView(boolean checkAncestor) {
-return !intendToBeFlatContainer() ||
+if (null != getInstance().getFlatUIContext()) {
+ return !intendToBeFlatContainer() ||
getInstance().getFlatUIContext().promoteToView(this,
checkAncestor, WXDiv.class);
+}
+return false;
}
/**
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] YorkShen edited a comment on issue #2039: make android support anti-aliased image
YorkShen edited a comment on issue #2039: make android support anti-aliased image URL: https://github.com/apache/incubator-weex/pull/2039#issuecomment-454773311 I reproduce the problem on my Android 9 phone, but it works well on my Android 6 phone, it seems like to a bug in Android system. Anyway, I suggest you add the following code snippet in the [following line](https://github.com/YorkShen/incubator-weex/blob/2f8caedb147b13182647a1dab473ba9cb31e54e4/android/sdk/src/main/java/com/taobao/weex/utils/ImageDrawable.java#L51): ``` imageDrawable.getPaint().setFilterBitmap(true); ``` It works as expected on my Android 9 phone. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] YorkShen edited a comment on issue #2039: make android support anti-aliased image
YorkShen edited a comment on issue #2039: make android support anti-aliased image URL: https://github.com/apache/incubator-weex/pull/2039#issuecomment-454773311 I reproduce the problem on my Android 9 phone, but it works well on my Android 6 phone, it seems like to a bug in Android system. Anyway, I suggest you add the following code snippet in the [corresponding line](https://github.com/YorkShen/incubator-weex/blob/2f8caedb147b13182647a1dab473ba9cb31e54e4/android/sdk/src/main/java/com/taobao/weex/utils/ImageDrawable.java#L51): ``` imageDrawable.getPaint().setFilterBitmap(true); ``` It works as expected on my Android 9 phone. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] YorkShen commented on issue #2039: make android support anti-aliased image
YorkShen commented on issue #2039: make android support anti-aliased image URL: https://github.com/apache/incubator-weex/pull/2039#issuecomment-454773311 I reproduce the problem on my Android 9 phone, but it works well on my Android 6 phone, it seems like to a bug in Android system. Anyway, I suggest you add the following code snippet in the [following line]:(https://github.com/YorkShen/incubator-weex/blob/2f8caedb147b13182647a1dab473ba9cb31e54e4/android/sdk/src/main/java/com/taobao/weex/utils/ImageDrawable.java#L51) ``` imageDrawable.getPaint().setFilterBitmap(true); ``` It works as expected on my Android 9 phone. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] YorkShen edited a comment on issue #2039: make android support anti-aliased image
YorkShen edited a comment on issue #2039: make android support anti-aliased image URL: https://github.com/apache/incubator-weex/pull/2039#issuecomment-454773311 I reproduce the problem on my Android 9 phone, but it works well on my Android 6 phone, it seems like to a bug in Android system. Anyway, I suggest you add the following code snippet in the [following line](https://github.com/YorkShen/incubator-weex/blob/2f8caedb147b13182647a1dab473ba9cb31e54e4/android/sdk/src/main/java/com/taobao/weex/utils/ImageDrawable.java#L51) ``` imageDrawable.getPaint().setFilterBitmap(true); ``` It works as expected on my Android 9 phone. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] karma-sun opened a new issue #2049: AndroidX support
karma-sun opened a new issue #2049: AndroidX support URL: https://github.com/apache/incubator-weex/issues/2049 I want to integrate the latest weex SDK into my app, But my app is using AndroidX Libraries while weex SDK is still using Android Support Libraries. I think weex should upgrade to use AndroidX This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] YorkShen closed issue #2049: AndroidX support
YorkShen closed issue #2049: AndroidX support URL: https://github.com/apache/incubator-weex/issues/2049 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] YorkShen commented on issue #2049: AndroidX support
YorkShen commented on issue #2049: AndroidX support URL: https://github.com/apache/incubator-weex/issues/2049#issuecomment-455022235 As support library in AndroidX has been moved to a new library, which is a break change for all the weex user of Android. So the supporting for Android have to wait for a while. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AntiMoron opened a new issue #2055: getComponentRect什么时候出个同步版本
AntiMoron opened a new issue #2055: getComponentRect什么时候出个同步版本
URL: https://github.com/apache/incubator-weex/issues/2055
现在的方式都是
```javascript
const dom = weex.requireModule('dom');
dom.getComponentRect(ref, ({size}) => {
blabla
});
```
实际这个和前端DOM的设计没对齐.在做三端兼容的代码时候体验就不是很好,尤其是多个DOM宽度计算相互依赖的情况下，又要判断DOM有没有又要异步看看结果异步拿到没。正常前端是：
```javascript
[sw, sh] = [dom.scrollWidth, dom.scrollHeight];
```
期待能在结果返回上在同一个call/cc里，如下这样最好：
```javascript
const dom = weex.requireModule('dom');
const domInfo = dom.getComponentRectSync(ref);
// domInfo.size.blabla...
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] xiaoshi943 opened a new issue #2056: [android] 0.19+ 小米4、5，红米note4上，首次加载本地jsbundle渲染不出来，第二次加载或者加载线上又是正常的
xiaoshi943 opened a new issue #2056: [android] 0.19+ 小米4、5，红米note4上，首次加载本地jsbundle渲染不出来，第二次加载或者加载线上又是正常的 URL: https://github.com/apache/incubator-weex/issues/2056 - [ ] Review the documentation: https://weex.apache.org/index.html - [ ] Search for existing issues: https://github.com/apache/incubator-weex/issues - [ ] Use the latest Weex release: https://github.com/apache/incubator-weex/releases ## Describe the bug A clear and concise description of what the bug is. ## To Reproduce Steps to reproduce the behavior. Include a MCVE using http://dotwe.org/vue , crash stacktrace or share your app project. Please follow the guidelines for providing a MCVE: https://stackoverflow.com/help/mcve ## Environment * Device: [e.g. iPhone6] * OS: [e.g. iOS8.1] * Version [e.g. 22] * Build from source [e.g. yes/no] ## Expected behavior A clear and concise description of what you expected to happen. ## Screenshots If applicable, add screenshots to help explain your problem. ## Additional context Add any other context about the problem here. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] YorkShen commented on a change in pull request #2039: make android support anti-aliased image
YorkShen commented on a change in pull request #2039: make android support
anti-aliased image
URL: https://github.com/apache/incubator-weex/pull/2039#discussion_r248522156
##
File path: android/sdk/src/main/java/com/taobao/weex/utils/ImageDrawable.java
##
@@ -132,6 +132,9 @@ protected void onDraw(Shape shape, Canvas canvas, Paint
paint) {
if (Build.VERSION.SDK_INT == Build.VERSION_CODES.LOLLIPOP) {
// fix api 21 PaintDrawable crash
paint.setAntiAlias(false);
+} else {
+ // make android support anti-aliased image
+ paint.setFlags(Paint.ANTI_ALIAS_FLAG|Paint.FILTER_BITMAP_FLAG);
Review comment:
Please add `imageDrawable.getPaint().setFilterBitmap(true);` when creating
`ImageDrawable`, no need to invoke setFlags during `draw()`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] hjmmc commented on issue #2039: make android support anti-aliased image
hjmmc commented on issue #2039: make android support anti-aliased image URL: https://github.com/apache/incubator-weex/pull/2039#issuecomment-455023060 > I reproduce the problem on my Android 9 phone, but it works well on my Android 6 phone, it seems like to a bug in Android system. > > Anyway, I suggest you add the following code snippet in the [corresponding line](https://github.com/YorkShen/incubator-weex/blob/2f8caedb147b13182647a1dab473ba9cb31e54e4/android/sdk/src/main/java/com/taobao/weex/utils/ImageDrawable.java#L51): > > ``` > imageDrawable.getPaint().setFilterBitmap(true); > ``` > It works as expected on my Android 9 phone. okay This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #2039: make android support anti-aliased image
weex-bot edited a comment on issue #2039: make android support anti-aliased image URL: https://github.com/apache/incubator-weex/pull/2039#issuecomment-453378854 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] liushengyi commented on issue #2055: getComponentRect什么时候出个同步版本
liushengyi commented on issue #2055: getComponentRect什么时候出个同步版本 URL: https://github.com/apache/incubator-weex/issues/2055#issuecomment-455038154 bindingx 的api getComputedStyle 是同步的，应该可以满足你的需求。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] liushengyi edited a comment on issue #2055: getComponentRect什么时候出个同步版本
liushengyi edited a comment on issue #2055: getComponentRect什么时候出个同步版本 URL: https://github.com/apache/incubator-weex/issues/2055#issuecomment-455038154 bindingx 的api getComputedStyle 是同步的，应该可以满足你的需求。 https://alibaba.github.io/bindingx/guide/cn_api_api This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AntiMoron commented on issue #2053: weex await/async
AntiMoron commented on issue #2053: weex await/async URL: https://github.com/apache/incubator-weex/issues/2053#issuecomment-455033369 这个跟weex没关系，只要你用了es6的环境就能用, 你好好看看你的babel配置, 是不是babel-plugin, babel-env没配置明白 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaoshi943 commented on issue #2056: [android] sdk 0.19+ 在小米4、5，红米note4上，首次加载本地jsbundle渲染不出来，第二次加载或者加载线上又是正常的
xiaoshi943 commented on issue #2056: [android] sdk 0.19+ 在小米4、5，红米note4上，首次加载本地jsbundle渲染不出来，第二次加载或者加载线上又是正常的 URL: https://github.com/apache/incubator-weex/issues/2056#issuecomment-455033633 [android] sdk 0.19+ 在小米4、5，红米note4上，首次加载本地jsbundle渲染不出来，第二次加载或者加载线上又是正常的 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] otakuXv opened a new issue #2057: indicator需要支持样式自定义
otakuXv opened a new issue #2057: indicator需要支持样式自定义 URL: https://github.com/apache/incubator-weex/issues/2057 目前indicator的选中状态样式只支持item-selected-color,包括为选中状态支持item-color。 期望样式可以支持自定义 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] YorkShen commented on issue #1954: WXSDKInstance类有必要暴露IWXRenderListener和IWXStatisticsListener两个属性
YorkShen commented on issue #1954: WXSDKInstance类有必要暴露IWXRenderListener和IWXStatisticsListener两个属性 URL: https://github.com/apache/incubator-weex/issues/1954#issuecomment-455060525 > 比如我需要在render错误的时候统一将错误信息提交到服务器，如果没有暴露此监听则需要打开原文件然后在onException的时候添加上报代码 * 如果Render出错 *如网络错误、JS执行错误*，sdk底层一定会调用 `RenderListener.onException`。你是在什么场景下，遇到Render出错，且`RenderListener.onException`没有被调用 * 这个接口没有暴露是为了避免weex的Native端使用者错误的调用RenderListener的生命周期函数，如`onException`，导致生命周期被错误的触发。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AntiMoron commented on issue #2057: indicator需要支持样式自定义
AntiMoron commented on issue #2057: indicator需要支持样式自定义 URL: https://github.com/apache/incubator-weex/issues/2057#issuecomment-455060462 你这个issue感觉提问太笼统，什么是indicator？ 是你们自己写的组件吗？ 那这个应该跟组件作者去讲不是weex框架本身。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chenzefeng09 commented on issue #2054: 希望能支持图表插件
chenzefeng09 commented on issue #2054: 希望能支持图表插件 URL: https://github.com/apache/incubator-weex/issues/2054#issuecomment-455089541 买 http://weex.io/zh/community/biz-component-map.html This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wangguanquan commented on issue #1954: WXSDKInstance类有必要暴露IWXRenderListener和IWXStatisticsListener两个属性
wangguanquan commented on issue #1954:
WXSDKInstance类有必要暴露IWXRenderListener和IWXStatisticsListener两个属性
URL: https://github.com/apache/incubator-weex/issues/1954#issuecomment-455091967
>你是在什么场景下，遇到Render出错，且RenderListener.onException没有被调用
可能是我没有描述清楚，并不是sdk底层没有触发`RenderListener#onException`，是我想在已有项目中添加Render出错时的逻辑。
比如我们线上项目在Render错误时显示一个默认画面，我现在需要在Render错误时显示默认错误并上报错误信息到服务器供开发人员及时修复。
我不想改现有工程代码，想直接通过Application#registerActivityLifecycleCallbacks注册并在onActivityResumed方法中统一通过WXSDKInstance#getRenderListener获得原有的监听，然后再写一个包装类，并在onException方法里实现上报的功能。
伪代码如下：
```
@Override public void onActivityResumed(Activity activity) {
if (activity instanceof IWXRenderListener) {
// FIXME 在这里获得监听
final IWXRenderListener listener = wxsdkInstance.getWXRenderListener();
wxsdkInstance.registerRenderListener(new
WXRenderListenerWrapper(listener));
}
//Render wrapper
public class WXRenderListenerWrapper implements IWXRenderListener {
private IWXRenderListener listener;
public WXRenderListenerWrapper (IWXRenderListener listener) {
this.listener = listener;
}
...
@Override public void onException(WXSDKInstance instance, String
errCode, String msg) {
// 执行原有逻辑显示默认画面
if (listener != null) {
listener.onException(instance, errCode, msg);
}
// Track weex render error.
JSONObject payload = new JSONObject();
payload.put("className", instance.getContext().getClass().getName());
payload.put("errCode", errCode);
payload.put("message", msg);
// 上报详细信息到服务器通知开发者
Tracker.track("WEEX_RENDER_ERROR", payload);
}
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] chenzefeng09 commented on issue #2054: 希望能支持图表插件
chenzefeng09 commented on issue #2054: 希望能支持图表插件 URL: https://github.com/apache/incubator-weex/issues/2054#issuecomment-455101654 > > 买 > > http://weex.io/zh/community/biz-component-map.html > > 多少钱 哈哈，我也不知道 gcanvas+g2-mobile是可以实现画图表的，网上可以搜到一些文章，但中间还是有很多坑要踩。 如果你的app之前有图表功能可以封装一下给weex用。 不过以上两种都需要动不少native的代码。如果是在纯weex生态里开发，想通过插件的方式集成的话，我目前知道的就是买服务了 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leonWenAYG opened a new issue #2058: Android WXImage组件在可见状态和隐藏状态会自动刷新
leonWenAYG opened a new issue #2058: Android WXImage组件在可见状态和隐藏状态会自动刷新
URL: https://github.com/apache/incubator-weex/issues/2058
## Describe the bug
Android
WXImage组件在加载完图片后，如果进入下一个界面，再退回来，WXImage组件在可见状态和隐藏状态切换时会刷新图片，在恢复可见状态时，会触发
autoRecoverImage()方法来重新加载图片，这样浪费资源而且还体验不好，我看到这个方法里有一句
if(mAutoRecycle) {
setSrc(mSrc);
}
而 WXImage的方法中 有一个setProperty(String key, Object param) 方法，可以设置该属性
mAutoRecycle = WXUtils.getBoolean(param, mAutoRecycle);
所以我想知道，如何调用setProperty方法，来设置我的weex image不自动刷新图片
## Environment
* Device: 华为p20
* OS: Android 8.1
* Version 0.19.0
* Build from source yes
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] leonWenAYG commented on issue #2058: Android WXImage组件在可见状态和隐藏状态会自动刷新
leonWenAYG commented on issue #2058: Android WXImage组件在可见状态和隐藏状态会自动刷新 URL: https://github.com/apache/incubator-weex/issues/2058#issuecomment-455084827 真的有用，不错不错 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] YorkShen merged pull request #2039: make android support anti-aliased image
YorkShen merged pull request #2039: make android support anti-aliased image URL: https://github.com/apache/incubator-weex/pull/2039 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chenzefeng09 commented on issue #2054: 希望能支持图表插件
chenzefeng09 commented on issue #2054: 希望能支持图表插件 URL: https://github.com/apache/incubator-weex/issues/2054#issuecomment-455103230 看看这个能不能给你些灵感 https://github.com/alibaba/GCanvas/issues/46 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AntiMoron commented on issue #2055: getComponentRect什么时候出个同步版本
AntiMoron commented on issue #2055: getComponentRect什么时候出个同步版本 URL: https://github.com/apache/incubator-weex/issues/2055#issuecomment-455060097 @liushengyi 那个不成，  返回里面文档没说width和height, 而且这个接口的意义和DOM里的不同。 bindingx里的那个是为了给表达式绑定触发的动画效果如scaleX translateX做获取用的接口。 DOM则是为了拿到信息。而且weex官网只字没提bindingX，一个库使用难易度不是靠外部辅助库能糊上的。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chenzefeng09 commented on issue #2053: weex await/async
chenzefeng09 commented on issue #2053: weex await/async URL: https://github.com/apache/incubator-weex/issues/2053#issuecomment-455090452 https://weex.emas-poc.com/solution/problem-summary.html#%E5%8D%81%E4%BA%8C%E3%80%81weex%E5%A6%82%E4%BD%95%E4%BD%BF%E7%94%A8async-await This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ibutterfly commented on issue #2054: 希望能支持图表插件
ibutterfly commented on issue #2054: 希望能支持图表插件 URL: https://github.com/apache/incubator-weex/issues/2054#issuecomment-455091663 > 买 > http://weex.io/zh/community/biz-component-map.html 多少钱 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] YorkShen edited a comment on issue #2039: make android support anti-aliased image
YorkShen edited a comment on issue #2039: make android support anti-aliased image URL: https://github.com/apache/incubator-weex/pull/2039#issuecomment-454773311 I reproduce the problem on my Android 9 phone, but it works well on my Android 6 phone, it seems like a bug in Android system. Anyway, I suggest you add the following code snippet in the [corresponding line](https://github.com/YorkShen/incubator-weex/blob/2f8caedb147b13182647a1dab473ba9cb31e54e4/android/sdk/src/main/java/com/taobao/weex/utils/ImageDrawable.java#L51): ``` imageDrawable.getPaint().setFilterBitmap(true); ``` It works as expected on my Android 9 phone. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AntiMoron commented on issue #2035: 想请教关于解决WeexSDK deadlock的思路
AntiMoron commented on issue #2035: 想请教关于解决WeexSDK deadlock的思路 URL: https://github.com/apache/incubator-weex/issues/2035#issuecomment-455061496 原意是加了一个远程配置，实验性测试在非主线程removeInstance能性能效果。你这样只是把配置项改为不生效强制在主线程removeInstance了。死锁详情还要从整体机制判断 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] liuruizhe728 commented on issue #1637: 组件自动滚动到可视区域了
liuruizhe728 commented on issue #1637: 组件自动滚动到可视区域了 URL: https://github.com/apache/incubator-weex/issues/1637#issuecomment-455122337 先将webview高度设置为1，pageFinish时再重新设置页面高度可解决此问题 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #2059: [iOS] Fix bridge method with BOOL argument on 32bit devices.
weex-bot commented on issue #2059: [iOS] Fix bridge method with BOOL argument on 32bit devices. URL: https://github.com/apache/incubator-weex/pull/2059#issuecomment-455130249 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #2059: [iOS] Fix bridge method with BOOL argument on 32bit devices.
weex-bot edited a comment on issue #2059: [iOS] Fix bridge method with BOOL argument on 32bit devices. URL: https://github.com/apache/incubator-weex/pull/2059#issuecomment-455130249 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ligui-iOS commented on issue #2060: [WXBridgeManager] invokeRegisterComponents: framework.js uninitialized.
ligui-iOS commented on issue #2060: [WXBridgeManager] invokeRegisterComponents: framework.js uninitialized. URL: https://github.com/apache/incubator-weex/issues/2060#issuecomment-455132488 weex-version 2.0.1 手动集成的包 SDK从GitHub上下的最新的 解压缩apk文件有 armeabi-v7a的包 但还是报invokeRegisterComponents: framework.js uninitialized. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ligui-iOS opened a new issue #2060: [WXBridgeManager] invokeRegisterComponents: framework.js uninitialized.
ligui-iOS opened a new issue #2060: [WXBridgeManager] invokeRegisterComponents: framework.js uninitialized. URL: https://github.com/apache/incubator-weex/issues/2060 - [ ] Review the documentation: https://weex.apache.org/index.html - [ ] Search for existing issues: https://github.com/apache/incubator-weex/issues - [ ] Use the latest Weex release: https://github.com/apache/incubator-weex/releases ## Describe the bug A clear and concise description of what the bug is. ## To Reproduce Steps to reproduce the behavior. Include a MCVE using http://dotwe.org/vue , crash stacktrace or share your app project. Please follow the guidelines for providing a MCVE: https://stackoverflow.com/help/mcve ## Environment * Device: [e.g. iPhone6] * OS: [e.g. iOS8.1] * Version [e.g. 22] * Build from source [e.g. yes/no] ## Expected behavior A clear and concise description of what you expected to happen. ## Screenshots If applicable, add screenshots to help explain your problem. ## Additional context Add any other context about the problem here. weex-version 2.0.1 has armeabi-v7a package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wqyfavor opened a new pull request #2059: [iOS] Fix bridge method with BOOL argument on 32bit devices.
wqyfavor opened a new pull request #2059: [iOS] Fix bridge method with BOOL argument on 32bit devices. URL: https://github.com/apache/incubator-weex/pull/2059 First of all, thank you for your contribution! Please makes sure that these checkboxes are checked before submitting your PR, thank you! CheckList: **if** *isBugFix* **:** * [ ] Make sure that you add at least one unit test for the bug which you had fixed. **elif** *isNewFeature* **:** * [ ] Update API docs for the component. * [ ] Update/Add demo to demonstrate new feature. * [ ] Update test scripts for the feature. * [ ] Add unit tests for the feature. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cxfeng1 merged pull request #2059: [iOS] Fix bridge method with BOOL argument on 32bit devices.
cxfeng1 merged pull request #2059: [iOS] Fix bridge method with BOOL argument on 32bit devices. URL: https://github.com/apache/incubator-weex/pull/2059 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] YorkShen merged pull request #2043: * [Android] Fix problem of ConcurrentModificaiton
YorkShen merged pull request #2043: * [Android] Fix problem of ConcurrentModificaiton URL: https://github.com/apache/incubator-weex/pull/2043 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #2059: [iOS] Fix bridge method with BOOL argument on 32bit devices.
weex-bot edited a comment on issue #2059: [iOS] Fix bridge method with BOOL argument on 32bit devices. URL: https://github.com/apache/incubator-weex/pull/2059#issuecomment-455130249 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] liushengyi commented on issue #2055: getComponentRect什么时候出个同步版本
liushengyi commented on issue #2055: getComponentRect什么时候出个同步版本 URL: https://github.com/apache/incubator-weex/issues/2055#issuecomment-455753545 @AntiMoron 这个只是bingingx的文档写的不完善，实际使用是有 width height信息的。至于weex库怎么样，这里不作评价。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] liushengyi commented on issue #2055: getComponentRect什么时候出个同步版本
liushengyi commented on issue #2055: getComponentRect什么时候出个同步版本
URL: https://github.com/apache/incubator-weex/issues/2055#issuecomment-455753813
@JSMethod(uiThread = false)
public Map getComputedStyle(@Nullable String ref) {
//.
Map map = new HashMap<>();
map.put("width",
resolutionTranslator.nativeToWeb(component.getLayoutWidth()));
map.put("height",
resolutionTranslator.nativeToWeb(component.getLayoutHeight()));
//.
这个是 bindingx 对应android接口实现。
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wangguanquan commented on issue #1954: WXSDKInstance类有必要暴露IWXRenderListener和IWXStatisticsListener两个属性
wangguanquan commented on issue #1954: WXSDKInstance类有必要暴露IWXRenderListener和IWXStatisticsListener两个属性 URL: https://github.com/apache/incubator-weex/issues/1954#issuecomment-455766414 对于修改点来说区别不大，都是加相同逻辑。对于某些应用场景还是比较有用的，比如我们android项目都引用一个common module，我的应用场景就是修改common module在此处添加勾子，对于业务开发部门是无感的，他们仅需升级公共模块的版本，对于非业务功能他们并不需要关心。 我了解你们未暴露此监听的出发点，也赞同你们的顾虑。 目前我们通过反射解决，仅进入画面时反射一次并不会影响速度。  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
