[jira] [Commented] (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2011-08-12 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084146#comment-13084146
 ] 

Karl Wright commented on CONNECTORS-92:
---

We now have a maven build system, in addition to ant, that was contributed 
elsewhere, so I'm closing this ticket.


> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: ManifoldCF
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
>Assignee: Karl Wright
> Fix For: ManifoldCF 0.3
>
> Attachments: Screen shot 2010-08-23 at 16.31.07.png, 
> maven-poms-including-start-jar.patch, 
> maven-poms-problem-starting-jetty-and-derby.patch, maven-start-jar.patch, 
> move-to-maven-acf-framework.patch, patch-connectors.zip
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2011-04-02 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015008#comment-13015008
 ] 

Karl Wright commented on CONNECTORS-92:
---

This issue has stalled.  The work done so far has created a reasonable 
directory structure with a pom.xml everywhere it needs to be.  However, beyond 
that, nothing more has happened.

It might be worth researching ant with ivy at this point, since that would be a 
natural extension of the current built system, rather than trying to go the 
maven route entirely.


> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: ManifoldCF
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
>Assignee: Karl Wright
> Attachments: Screen shot 2010-08-23 at 16.31.07.png, 
> maven-poms-including-start-jar.patch, 
> maven-poms-problem-starting-jetty-and-derby.patch, maven-start-jar.patch, 
> move-to-maven-acf-framework.patch, patch-connectors.zip
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-09-09 Thread Jettro Coenradie (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907908#action_12907908
 ] 

Jettro Coenradie commented on CONNECTORS-92:


I think maven is not the right tool at the moment due to the libraries that are 
used that are not available in any repository, the way the sample is started. 
The dependencies that seem to be copied to each project. I am spending a lot of 
time on creating an assembly, but that is not really the part where maven 
shines. 

> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
>Assignee: Karl Wright
> Attachments: maven-poms-including-start-jar.patch, 
> maven-poms-problem-starting-jetty-and-derby.patch, maven-start-jar.patch, 
> move-to-maven-acf-framework.patch, patch-connectors.zip, Screen shot 
> 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-09-08 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907392#action_12907392
 ] 

Karl Wright commented on CONNECTORS-92:
---

Jettro,

Please go ahead and submit everything you have.  I'd also like to know what you 
believe the stumbling blocks to be.  Thanks for all your work on this so far.


> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
>Assignee: Karl Wright
> Attachments: maven-poms-including-start-jar.patch, 
> maven-poms-problem-starting-jetty-and-derby.patch, 
> move-to-maven-acf-framework.patch, Screen shot 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-09-08 Thread Jettro Coenradie (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907358#action_12907358
 ] 

Jettro Coenradie commented on CONNECTORS-92:


I worked on it tonight but I decided to stop. This path is not leading in a 
direction that I would like. To make most out of maven I would like to change 
more than you would be willing to right now. I cannot blame you, because you 
have something working right now. Maybe someone else wants to step in and 
finish what I have done. I can submit another patch with the stuff I have right 
now. 

> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
>Assignee: Karl Wright
> Attachments: maven-poms-including-start-jar.patch, 
> maven-poms-problem-starting-jetty-and-derby.patch, 
> move-to-maven-acf-framework.patch, Screen shot 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-09-07 Thread Jettro Coenradie (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906778#action_12906778
 ] 

Jettro Coenradie commented on CONNECTORS-92:


No, time is my enemy at the moment

> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
>Assignee: Karl Wright
> Attachments: maven-poms-including-start-jar.patch, 
> maven-poms-problem-starting-jetty-and-derby.patch, 
> move-to-maven-acf-framework.patch, Screen shot 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-09-07 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906773#action_12906773
 ] 

Karl Wright commented on CONNECTORS-92:
---

Has there been any further progress on this issue?


> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
>Assignee: Karl Wright
> Attachments: maven-poms-including-start-jar.patch, 
> maven-poms-problem-starting-jetty-and-derby.patch, 
> move-to-maven-acf-framework.patch, Screen shot 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-31 Thread Jettro Coenradie (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904561#action_12904561
 ] 

Jettro Coenradie commented on CONNECTORS-92:


As for the start.jar I do not see a problem. I think I am almost there. THe 
classpath already contains the lib part, so I only need to add the dependencies 
to the jetty runner project. As for the example code, I do not mind to keep 
using and to create the example. I only wanted to have maven to make it easier 
to setup my development environment and to do the dependency management.

I'll try to come up with an improve pom for the start.jar, if that is not 
enough please let me know.

> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
>Assignee: Karl Wright
> Attachments: maven-poms-including-start-jar.patch, 
> maven-poms-problem-starting-jetty-and-derby.patch, 
> move-to-maven-acf-framework.patch, Screen shot 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-31 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904558#action_12904558
 ] 

Karl Wright commented on CONNECTORS-92:
---

I've thought about start.jar some more.  I think it is essential that maven 
produce a jar that is functionally identical to the start.jar produced by the 
ant build, including the relative paths for all the classpath entries.  Maven 
may be unable to directly produce the modules/dist/example output directory in 
the same way, but that's a different problem.  I don't think there's going to 
be room in the world for two entirely distinct ways of running the example, and 
I want to avoid that - for documentation reasons, if for none other.

The other reason for wanting the example setup to be identical is because the 
example organizational assumptions are partly baked into the jetty-runner code 
at this time.  Those could in part be passed in as command-line arguments, but 
that would make running the example considerably harder, so I'd like to avoid 
that if possible.



> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
>Assignee: Karl Wright
> Attachments: maven-poms-including-start-jar.patch, 
> maven-poms-problem-starting-jetty-and-derby.patch, 
> move-to-maven-acf-framework.patch, Screen shot 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-30 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904324#action_12904324
 ] 

Karl Wright commented on CONNECTORS-92:
---

Another way you can determine what's supposed to be a dependency is to look at 
the start.jar produced by the ant build:



Note that commons-httpclient-acf.jar is our own version of commons-httpclient, 
and must therefore NOT be an external dependency.


> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
>Assignee: Karl Wright
> Attachments: maven-poms-including-start-jar.patch, 
> maven-poms-problem-starting-jetty-and-derby.patch, 
> move-to-maven-acf-framework.patch, Screen shot 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-30 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904312#action_12904312
 ] 

Karl Wright commented on CONNECTORS-92:
---

I noticed that jetty-runner/pom.xml does not seem to have anything specifying 
external jars in a classpath.  Therefore, I believe that the produced start.jar 
will not properly function.  Have you tried this in practice yet?  You will 
want to include the derby jars, and probably most of the jars specified on the 
maven dependency page.  Be aware that that page is somewhat out of date, and 
(for instance) the tomcat jars are not needed unless you actually try to 
compile the jsp's.

https://cwiki.apache.org/confluence/display/CONNECTORS/Maven+Dependencies



> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
>Assignee: Karl Wright
> Attachments: maven-poms-including-start-jar.patch, 
> maven-poms-problem-starting-jetty-and-derby.patch, 
> move-to-maven-acf-framework.patch, Screen shot 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-30 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904301#action_12904301
 ] 

Karl Wright commented on CONNECTORS-92:
---

Committed those additions.  r990908.


> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: maven-poms-including-start-jar.patch, 
> maven-poms-problem-starting-jetty-and-derby.patch, 
> move-to-maven-acf-framework.patch, Screen shot 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-30 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904219#action_12904219
 ] 

Karl Wright commented on CONNECTORS-92:
---

bq. I am still thinking about why this is so hard. Would be nice to have 
something like a servlet or filter that initializes everything that you do in 
your special runner now.

The issues have to do with these facts:

- Embedded derby is single-process.  You cannot run more than one process 
against a given database at a given time.
- ACF supports both single-process and multi-process models, but IF you're 
going to use single-process, you need to have a main class that starts up all 
the threads that would otherwise be different processes.  That's what 
jetty-runner does, in part.

So, obviously, something like jetty-runner needs to exist if you are going to 
use derby.  I don't think maven magic will suffice to replace the code that 
does that.

Furthermore, I think trying to get maven to do this for us is overkill.  I'm 
open to suggestions, but I still don't think you need to solve this problem in 
order to have ACF be built effectively by maven.

What I think we need to build at the framework level are all the jars and wars 
(which it looks like you have pretty well specified), PLUS a start.jar (which I 
didn't see anywhere - did I miss it?).  Then your example execution will not be 
a "jetty instance" per se, but will simply fire off the equivalent of  "java 
-jar start.jar".  I can't believe there isn't a maven plugin for that.  This, 
of course, must happen at the modules level, because no connectors will be 
available at the framework level.


> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: maven-poms-problem-starting-jetty-and-derby.patch, 
> move-to-maven-acf-framework.patch, Screen shot 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-30 Thread Jettro Coenradie (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904214#action_12904214
 ] 

Jettro Coenradie commented on CONNECTORS-92:


I am afraid the crawler-ui is not done yet. I think we are missing libraries. 
What I was trying to do is make it run and see what I was missing. But the way 
I understand it now, I must choose another path to make it run. This seemed the 
most easy thing to do. I am still thinking about why this is so hard. Would be 
nice to have something like a servlet or filter that initializes everything 
that you do in your special runner now. But if you spend a lot of time getting 
it right, it must not be the easiest thing to do.

I will come with a better patch, hope to be able to build something that I can 
actually test using the sample.

> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: maven-poms-problem-starting-jetty-and-derby.patch, 
> move-to-maven-acf-framework.patch, Screen shot 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-30 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904212#action_12904212
 ] 

Karl Wright commented on CONNECTORS-92:
---

I take that back for crawler-ui/pom.xml.  This seems to be trying to set up a 
running version of the framework plus a couple of connectors.  I don't think 
that's the right place for that logic; I'd prefer it just did a straight build 
of the crawler-ui web application.   The example runner, if we do one under 
maven, really belongs at the "modules" level.

Will you be submitting a patch that pares down crawler-ui/pom.xml, or shall I 
just edit the current artifact accordingly?


> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: maven-poms-problem-starting-jetty-and-derby.patch, 
> move-to-maven-acf-framework.patch, Screen shot 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-30 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904209#action_12904209
 ] 

Karl Wright commented on CONNECTORS-92:
---

I've had a cursory glance at the pom files and they all look reasonable.  I'm 
going to play around with this a bit locally to see how it behaves, and then if 
all seems OK I am happy to commit those.


> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: maven-poms-problem-starting-jetty-and-derby.patch, 
> move-to-maven-acf-framework.patch, Screen shot 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-30 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904205#action_12904205
 ] 

Karl Wright commented on CONNECTORS-92:
---

Jettro,

If you are using maven to start jetty directly, it will not work.  You are 
missing the jetty runner, which only starts jetty at the end of a number of 
steps, including creating the database properly and setting up the schema and 
registering the connectors.  Then, the crawler itself is started as a separate 
thread.

It took me many weeks to get everything to work properly using jetty.  Changing 
all this stuff around does not seem either warranted or useful at this time.  I 
strongly recommend that you concentrate on using maven to actually build the 
software, and not try to re-engineer the example right now.


> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: maven-poms-problem-starting-jetty-and-derby.patch, 
> move-to-maven-acf-framework.patch, Screen shot 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-27 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903477#action_12903477
 ] 

Karl Wright commented on CONNECTORS-92:
---

No, the directories ending in -service produce wars.  Those ending in -servlet 
produce a jar.


> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: move-to-maven-acf-framework.patch, Screen shot 
> 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-27 Thread Jettro Coenradie (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903476#action_12903476
 ] 

Jettro Coenradie commented on CONNECTORS-92:


Oke, thats fine. But is the projects *-servlet a war? is that the web project?

> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: move-to-maven-acf-framework.patch, Screen shot 
> 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-27 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903463#action_12903463
 ] 

Karl Wright commented on CONNECTORS-92:
---

bq. Wouldn't it be better to rename the *-servlet into something like war or 
web. There will probably be more things in there than a servlet. 

No, really, there's just the servlet.
All that I did was break the authority service into a separate web application 
and jar file.  Both of these were built before under the heading of 
"authority-service", but since we're getting rigorous, I separated out the 
targets.  Did the same thing for the api - there's now a servlet, and a 
service, one yields a jar, the other a war (which includes the jar).



> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: move-to-maven-acf-framework.patch, Screen shot 
> 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-27 Thread Jettro Coenradie (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903462#action_12903462
 ] 

Jettro Coenradie commented on CONNECTORS-92:


Wouldn't it be better to rename the *-servlet into something like war or web. 
There will probably be more things in there than a servlet.

> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: move-to-maven-acf-framework.patch, Screen shot 
> 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-27 Thread Jettro Coenradie (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903460#action_12903460
 ] 

Jettro Coenradie commented on CONNECTORS-92:


I see you have created two modules for the api-service. Is there a good reason 
for that? The servlet is not within the web project. In my original idea I 
created two modules, but maybe you have a good reason to create two?

> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: move-to-maven-acf-framework.patch, Screen shot 
> 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-27 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903465#action_12903465
 ] 

Karl Wright commented on CONNECTORS-92:
---

I should also clarify that, to me, "servlet" is not just a single class in any 
case, but a body of functionality responsible for fielding web requests.  So I 
think the "servlet" label is quite accurate.  Others, of course, doubtless have 
different definitions. ;-)


> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: move-to-maven-acf-framework.patch, Screen shot 
> 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-27 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903368#action_12903368
 ] 

Karl Wright commented on CONNECTORS-92:
---

Connectors reorg also committed.  r990100.


> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: move-to-maven-acf-framework.patch, Screen shot 
> 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-27 Thread Jettro Coenradie (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903363#action_12903363
 ] 

Jettro Coenradie commented on CONNECTORS-92:


I did a quick check and it seems to be fine. If you commit the connector 
changes as well I'll try to commit a patch for both tonight.

> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: move-to-maven-acf-framework.patch, Screen shot 
> 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-27 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903356#action_12903356
 ] 

Karl Wright commented on CONNECTORS-92:
---

I am now ready to commit the connectors reorganization also, once I hear back.


> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: move-to-maven-acf-framework.patch, Screen shot 
> 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-26 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903151#action_12903151
 ] 

Karl Wright commented on CONNECTORS-92:
---

I rearranged the framework part of the tree to what I believe will satisfy 
maven.  The rest of the tree I will cover in a subsequent check-in, provided I 
got this part right.  Can you verify that the current tree is correct, and can 
you upload a new maven patch based on the new tree?


> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: move-to-maven-acf-framework.patch, Screen shot 
> 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-26 Thread Robert Muir (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902838#action_12902838
 ] 

Robert Muir commented on CONNECTORS-92:
---

I am the last person to comment about maven, but i noticed tika has a maven 
build that builds a large single jar that contains
all classes from dependencies

Perhaps it would be a useful example if you want to do this 'jar coalescing'

> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: move-to-maven-acf-framework.patch, Screen shot 
> 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-26 Thread Jettro Coenradie (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902834#action_12902834
 ] 

Jettro Coenradie commented on CONNECTORS-92:


Very cool

> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: move-to-maven-acf-framework.patch, Screen shot 
> 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-26 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902827#action_12902827
 ] 

Karl Wright commented on CONNECTORS-92:
---

I am ok with postponing any jar coalescing until later.  All I'd hoped to do 
was to make fewer jars, but that's not necessary for now.

I notice you did not supply a build.xml change with the patch.  I will need to 
supply the necessary hierarchy reorganizations and the build.xml changes before 
you will be able to post anything like a complete patch.  My goal is going to 
be to maintain the current build in a working fashion, at least until it is 
clear that maven can meet all the requirements that are covered by the ant 
build, and that is not clear yet.  I will work on the reorganization tonight, 
and commit the changes when I believe they are correct and have been verified 
as working.  Then, please comment as to whether you feel they are adequate for 
your needs.


> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: move-to-maven-acf-framework.patch, Screen shot 
> 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-26 Thread Jettro Coenradie (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902814#action_12902814
 ] 

Jettro Coenradie commented on CONNECTORS-92:


Sorry, but why is it easier to have one src for the complete framework. To my 
opinion the source code becomes a lot easier to understand if you make it 
explicit what the different modules are.  Besides that, maven just does not 
work that way. It is also a lot harder when depending on these parts. The way I 
see it, we have already three different war files. The other jars are shared 
between the three war files. This way it becomes clear what deliverables there 
are without looking at the code. Just he directory structure is enough. It is 
also very easy to just compile/package one component. Step into the right 
directory and execute mvn clean install and you are done.

I can imagine that the scripts and ant files become a little more complicated 
to change, but I think it is worth the effort to get a cleaner project layout.

I did not have a good look at the Jetty runner yet. But I see it is a class 
with a very large main method. With maven it is not hard to make an executable 
jar file. Together with the assembly plugin and an overlay of the original 
crawler this should not be to hard to create.

The integration tests can be put in one project to store them all, but you can 
also place the integration tests into the project that it is actually testing. 
Maven has a lifecycle phase for integration tests. Not sure that for instance 
the FileSystems tests are actually doing. What to they need to run? I see they 
have a requirement for multiple war files. So it seems logical to me to put 
them in a separate module. Give them dependencies on the framework modules and 
run them of you are executing the integration-test phase of maven.

The environment related projects can be executed like they are executed now 
using ant. We can for instance create one maven module on top of them that 
executes these builds together with the package phase of maven. We could also 
provide a profile that the build is only executed if you explicitly tell it to.

I hope this makes sense to you. Sometime it is hard to explain for me because I 
am so used to using maven nowadays that I might overlook something why others 
think it is hard to use.

> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: move-to-maven-acf-framework.patch, Screen shot 
> 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-26 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902805#action_12902805
 ] 

Karl Wright commented on CONNECTORS-92:
---

It looks to me like you adopted the one-jar-per-maven-script approach, with no 
coalescing of jars, but instead introducing /src/main under each of the 
subtargets within framework.  I'd really like instead to make our job easier by 
at least combining the framework main jars together into one target first, 
along the lines I described above.  I'd also like to get a sense of the overall 
picture before proceeding, so can we discuss what individual maven targets 
there are that you are proposing, and what each of them is, before we undertake 
any changes of this kind?  The individual connector ones are obvious, but I'm 
concerned about stuff like the integration tests and the quick-start jetty 
package.  How do you cover those in a maven build?









> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: move-to-maven-acf-framework.patch, Screen shot 
> 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-24 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901811#action_12901811
 ] 

Karl Wright commented on CONNECTORS-92:
---

bq. Web projects are no problem at all. You can even have dependencies between 
webproject. Althought I would try to make dependencies on jars only.

The question is, who would *want* to depend on any individual ACF war files?  
If there's a need, then fine, but I don't see one here.  The only use case I 
can come up with for anybody depending on ACF is on the main framework jars, 
which could be consolidated into one jar quite readily.  I would therefore 
propose breaking up modules/framework into two pieces: 
"modules/framework-core", and "modules/framework", or some such.  
"framework-core" would contain what's currently in framework/core, 
framework/ui-core, framework/agents, and framework/pull-agent, and would have 
both an ant build and a maven build that wraps it.  "framework" would contain 
"crawler-ui", "api', "authorityservice", and the jetty stuff, and would have a 
straight ant build and an ant-with-ivy build wrapping that.  Each connector 
would have an ant build and a wrapping ant-ivy build also.

Thoughts?


> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: Screen shot 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-24 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901797#action_12901797
 ] 

Karl Wright commented on CONNECTORS-92:
---

It further occurs to me that the only *jars* you will ever need to depend on in 
ACF are the ones that you'd build connectors against.  So, now I'm getting 
glimmers of a possible combined maven/ivy build where we have only one maven 
target, which is basically the jars acf-core, acf-core-ui, acf-agents, and 
acf-pull-agent, and where every other module in ACF is built using ivy to pull 
down dependencies that are needed.  Of course, this would presume you wanted to 
build connectors independently of building ACF itself, which I could go either 
way on at the moment...




> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: Screen shot 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-24 Thread Jettro Coenradie (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901795#action_12901795
 ] 

Jettro Coenradie commented on CONNECTORS-92:


I'll try to come up with something tonight. Today I am at a customer so I 
cannot spend to much time.

Web projects are no problem at all. You can even have dependencies between 
webproject. Althought I would try to make dependencies on jars only.

I'll come up with a directory structure and the components based on the 
deliverables or the targets.


> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: Screen shot 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-24 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901793#action_12901793
 ] 

Karl Wright commented on CONNECTORS-92:
---

It occurs to me that maybe ACF is better suited to work with ivy, since that is 
specifically designed to deal with input dependencies, and does have a rigid 
notion of targets.


> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: Screen shot 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-24 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901792#action_12901792
 ] 

Karl Wright commented on CONNECTORS-92:
---

Planning things out in the wiki is not a bad idea at all.  This ticket is also 
a reasonable forum.

I think the first step is to agree on the individual maven deliverables/targets.

The one-jar-per-maven-package restriction is going to dictate significant 
changes, because the way things are jar'd right now that would require either 
the breakup of the "framework" module into multiple components, OR the 
consolidation of the entire framework into a single jar.  But the fact is that 
framework is NOT just a bunch of jars, it's also 3 war files.  Those are as 
much a necessary part of the framework as are the jars.  Is there a maven model 
for war files, too?  I understand maven was primarily conceived as a way of 
handling jar dependencies, which may make it less suitable for dealing with ACF 
than we'd hoped.  When I originally was thinking about maven, I worried more 
about the input dependencies than the targets.  It seems we need to understand 
the targets.  Can you make a proposal as to what maven targets you think we 
should have, and what they should include?




> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: Screen shot 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-24 Thread Jettro Coenradie (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901786#action_12901786
 ] 

Jettro Coenradie commented on CONNECTORS-92:


- Compiling C with maven : I have no experience with that
- Multiple jars: I know people have done it. I would not do it however. Create 
a pom and structure for each module. Group the module by using a parent pom and 
a directory structure.
- I agree that each connector should be a component on its own, with its own 
pom. 
- The fact that jetty has a dependency on the framework is no problem at all. 
We can just create an internal dependency and release them together if 
necessary.

What is the next best step? Come up with a directory structure that is 
synchronized with our ideas of the different components?

I can change the image, but we can also do something on the wiki or on the 
description of this issue.

> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: Screen shot 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-24 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901777#action_12901777
 ] 

Karl Wright commented on CONNECTORS-92:
---

bq. As a response to the remark from Karl
(1) Breaking up modules and putting pieces of that all over the place
I do not think they are all over the place, maybe I am thinking wrong about the 
modules part, but for me modules is not really clear. At the moment we have 
documentation, modules and tests. I suggest a slightly more separated mode 
with: documentation, integration-tests, framework, connectors and environment. 
The only change is to move some stuff from modules into a new part environment 
en move the other parts of modules one level up.

Each thing under modules is something you'd want to build separately, which is 
why I chose the arrangement in the first place.  If I were deploying these on a 
debian system, each would be its own package.  That is, each connector would 
necessarily be its own package, as would mod-authz-annotate, and 
java-environment.  Indeed, java-environment was originally a debian package 
that was part of the LCF software grant and has not been modified even to 
build, because it in effect represented a Debian java deployment framework 
rather than actual code.  Same thing with postgres-config, except that was for 
postgresql configuration under Debian.  Furthermore, mod-authz-annotate is C, 
and probably cannot be built under maven (or do I have that wrong?)

Therefore, for a maven build we should plan on building the following as 
SEPARATE maven deliverables/targets:
- (1) Each connector
- (2) The framework
If there is a way to build C stuff under maven, then this too should be a maven 
deliverable/target:
- (3) mod-authz-annotate
These should exist in the tree but be ignored for now, since they are not 
applicable to maven at all:
- (4) java-environment
- (5) postgres-config

bq. (2) Taking jetty-runner out of framework
I do not think that Jetty is part of your framework, you create war files and 
give the option for an easy start using Jetty. But maybe I am wrong.

I set the jetty example and runner up so that they do not have explicit 
dependencies on any individual connectors, and thus they're built as part of 
the framework, which they DO have a dependency on.  A case could be made for 
having these be separated into their own module-level component, in which case 
they'd also be their own maven deliverable.

bq. (3) Introducing a "src" directory under each of the framework components
At the moment when running ant. You get a lot of folders of which it is not 
always easy to understand whether they are original source folders or not. That 
is why maven comes with a clear separation of src, generated-source and target 
for other generated content. To my opinion this makes it easier to see what is 
under version control and what is not.

Check the maven page for more explanation.
http://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html

I will read the page.  It seems to me that we'd need to agree what the maven 
deliverables would be before we can decide where the "src" directory goes.  If 
the framework is a component all by itself (and I think it should be), then 
naturally the structure would be "modules/framework/src/..." instead.  Does 
maven allow multiple jars in a deliverable?  That would be a necessary 
condition.

bq. (4) Moving the tests so far away from the code they are related to
I am not sure if I was clear enough on this. In the original code base a test 
folder is available next to modules. For unit tests I would keep them as close 
as possible to the source code. Therefore we have the src/main and src/test in 
the same module. The integration tests are another beast. Usually a lot of 
environmental setup needs to be done, they take longer, and you might want to 
store them in a different folder so you can run them all at once. Another 
option would be to add them next to the unit tests in a different folder 
[src/main, src/test/ and src/integration-test] or use a different naming 
scheme. **Test.java and **IntegrationTest.java That way you can folder them out 
as well and use the maven lifecycle to decide whether to run unit test or both 
unit and integration tests.

As of right now, there are three kinds of tests in the system: Unit tests 
(which are checked in in the module they are to test), integration unit tests 
(which are checked in at the "modules" level), and full integration tests that 
are a legacy of the LCF code grant (which are checked in in the "tests" 
directory above the modules level).  The full integration tests are not 
executed but were meant to furnish the rudiments of a test plan,as well as 
useful bits for manipulating repositories themselves during test processes, and 
thus must be considered "reference material" at this time.  The 

[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-24 Thread Jettro Coenradie (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901769#action_12901769
 ] 

Jettro Coenradie commented on CONNECTORS-92:


As a response to the remark from Karl
(1) Breaking up modules and putting pieces of that all over the place
I do not think they are all over the place, maybe I am thinking wrong about the 
modules part, but for me modules is not really clear. At the moment we have 
documentation, modules and tests. I suggest a slightly more separated mode 
with: documentation, integration-tests, framework, connectors and environment. 
The only change is to move some stuff from modules into a new part environment 
en move the other parts of modules one level up.

(2) Taking jetty-runner out of framework
I do not think that Jetty is part of your framework, you create war files and 
give the option for an easy start using Jetty. But maybe I am wrong.

(3) Introducing a "src" directory under each of the framework components
At the moment when running ant. You get a lot of folders of which it is not 
always easy to understand whether they are original source folders or not. That 
is why maven comes with a clear separation of src, generated-source and target 
for other generated content. To my opinion this makes it easier to see what is 
under version control and what is not.

Check the maven page for more explanation.
http://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html

(4) Moving the tests so far away from the code they are related to
I am not sure if I was clear enough on this. In the original code base a test 
folder is available next to modules. For unit tests I would keep them as close 
as possible to the source code. Therefore we have the src/main and src/test in 
the same module. The integration tests are another beast. Usually a lot of 
environmental setup needs to be done, they take longer, and you might want to 
store them in a different folder so you can run them all at once. Another 
option would be to add them next to the unit tests in a different folder 
[src/main, src/test/ and src/integration-test] or use a different naming 
scheme. **Test.java and **IntegrationTest.java That way you can folder them out 
as well and use the maven lifecycle to decide whether to run unit test or both 
unit and integration tests.

As for the part where we need ant to make certain deliveries, we can still do 
that. Than you have two options, or run the ant command to make these 
deliverables yourself, or add them to the package lifecycle stage of maven. It 
is not hard to call ant from maven. You could even create the mother of all ant 
build file that calls maven to build the framework and the conenctors.

> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: Screen shot 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-23 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901436#action_12901436
 ] 

Karl Wright commented on CONNECTORS-92:
---

Re: build preferences

Continuing to have an ant build is actually pretty important for some modes of 
delivery.  I'm specifically thinking of debian and Ubuntu packaging here.  
Maven does not work well with these packaging schemes because it's too 
all-encompassing.  We therefore need a way of doing builds locally, without 
pulling things down from a mirror.

My original thought was that we'd have multiple layers - ant  being the most 
basic, with a maven wrapper available to pull down what the ant build needed, 
and have the maven build call ant underneath.  I don't know how realistic that 
is, but it does solve all the problems if it can be done that way.


> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: Screen shot 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (CONNECTORS-92) Move from ant to maven or other build system with decent library management

2010-08-23 Thread Karl Wright (JIRA)

[ 
https://issues.apache.org/jira/browse/CONNECTORS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901432#action_12901432
 ] 

Karl Wright commented on CONNECTORS-92:
---

This proposed change has a number of features I don't  understand the reasons 
for:

(1) Breaking up modules and putting pieces of that all over the place
(2) Taking jetty-runner out of framework
(3) Introducing a "src" directory under each of the framework components
(4) Moving the tests so far away from the code they are related to

Can you describe your logic for this reorganization?


> Move from ant to maven or other build system with decent library management
> ---
>
> Key: CONNECTORS-92
> URL: https://issues.apache.org/jira/browse/CONNECTORS-92
> Project: Apache Connectors Framework
>  Issue Type: Wish
>  Components: Build
>Reporter: Jettro Coenradie
> Attachments: Screen shot 2010-08-23 at 16.31.07.png
>
>
> I am looking at the current project structure. If we want to make another 
> build tool available I think we need to change the directory structure. I 
> tried to place a suggestion in an image. Can you please have a look at it. If 
> we agree that this is a good way to go, than I will continue to work on a 
> patch. Which might be a bit hard with all these changing directories, but 
> I'll do my best to at least get an idea whether it would be working.
> So I have three questions:
> - Do you want to move to maven or put maven next to ant?
> - Do you prefer another build mechanism [ant with ivy, gradle, maven3]
> - Do you have an idea about the amount of scripts that need to be changed if 
> we change the project structure
> The image of a possible project layout (that is based on the maven standards) 
> is attached to the issue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.