Re: RFR 8132097: Stream.generate should use a covariant Supplier as parameter

[Martin Buchholz]

Looks good to me!

On Tue, Nov 8, 2016 at 4:43 PM, Paul Sandoz  wrote:

> Hi
>
> Please review this compatible fix to Stream.generate to accept a covariant
> Supplier.
>
> Paul.
>
> diff -r 3e3ca9800322 src/java.base/share/classes/
> java/util/stream/Stream.java
> --- a/src/java.base/share/classes/java/util/stream/Stream.java  Tue Nov
> 08 15:37:20 2016 -0800
> +++ b/src/java.base/share/classes/java/util/stream/Stream.java  Tue Nov
> 08 16:36:51 2016 -0800
> @@ -1327,7 +1327,7 @@
>   * @param s the {@code Supplier} of generated elements
>   * @return a new infinite sequential unordered {@code Stream}
>   */
> -public static Stream generate(Supplier s) {
> +public static Stream generate(Supplier s) {
>  Objects.requireNonNull(s);
>  return StreamSupport.stream(
>  new 
> StreamSpliterators.InfiniteSupplyingSpliterator.OfRef<>(Long.MAX_VALUE,
> s), false);
> diff -r 3e3ca9800322 src/java.base/share/classes/java/util/stream/
> StreamSpliterators.java
> --- a/src/java.base/share/classes/java/util/stream/StreamSpliterators.java
> Tue Nov 08 15:37:20 2016 -0800
> +++ b/src/java.base/share/classes/java/util/stream/StreamSpliterators.java
> Tue Nov 08 16:36:51 2016 -0800
> @@ -1346,9 +1346,9 @@
>  }
>
>  static final class OfRef extends InfiniteSupplyingSpliterator
> {
> -final Supplier s;
> +final Supplier s;
>
> -OfRef(long size, Supplier s) {
> +OfRef(long size, Supplier s) {
>  super(size);
>  this.s = s;
>  }
>

Re: RFR 8132097: Stream.generate should use a covariant Supplier as parameter

[Remi Forax]

Good for me !

Remi 

On November 9, 2016 1:43:52 AM GMT+01:00, Paul Sandoz  
wrote:
>Hi
>
>Please review this compatible fix to Stream.generate to accept a
>covariant Supplier.
>
>Paul.
>
>diff -r 3e3ca9800322
>src/java.base/share/classes/java/util/stream/Stream.java
>--- a/src/java.base/share/classes/java/util/stream/Stream.java Tue Nov
>08 15:37:20 2016 -0800
>+++ b/src/java.base/share/classes/java/util/stream/Stream.java Tue Nov
>08 16:36:51 2016 -0800
>@@ -1327,7 +1327,7 @@
>  * @param s the {@code Supplier} of generated elements
>  * @return a new infinite sequential unordered {@code Stream}
>  */
>-public static Stream generate(Supplier s) {
>+public static Stream generate(Supplier s) {
> Objects.requireNonNull(s);
> return StreamSupport.stream(
>new
>StreamSpliterators.InfiniteSupplyingSpliterator.OfRef<>(Long.MAX_VALUE,
>s), false);
>diff -r 3e3ca9800322
>src/java.base/share/classes/java/util/stream/StreamSpliterators.java
>---
>a/src/java.base/share/classes/java/util/stream/StreamSpliterators.java Tue
>Nov 08 15:37:20 2016 -0800
>+++
>b/src/java.base/share/classes/java/util/stream/StreamSpliterators.java Tue
>Nov 08 16:36:51 2016 -0800
>@@ -1346,9 +1346,9 @@
> }
>
>  static final class OfRef extends InfiniteSupplyingSpliterator {
>-final Supplier s;
>+final Supplier s;
>
>-OfRef(long size, Supplier s) {
>+OfRef(long size, Supplier s) {
> super(size);
> this.s = s;
> }

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

RFR 8132097: Stream.generate should use a covariant Supplier as parameter

[Paul Sandoz]

Hi

Please review this compatible fix to Stream.generate to accept a covariant 
Supplier.

Paul.

diff -r 3e3ca9800322 src/java.base/share/classes/java/util/stream/Stream.java
--- a/src/java.base/share/classes/java/util/stream/Stream.java  Tue Nov 08 
15:37:20 2016 -0800
+++ b/src/java.base/share/classes/java/util/stream/Stream.java  Tue Nov 08 
16:36:51 2016 -0800
@@ -1327,7 +1327,7 @@
  * @param s the {@code Supplier} of generated elements
  * @return a new infinite sequential unordered {@code Stream}
  */
-public static Stream generate(Supplier s) {
+public static Stream generate(Supplier s) {
 Objects.requireNonNull(s);
 return StreamSupport.stream(
 new 
StreamSpliterators.InfiniteSupplyingSpliterator.OfRef<>(Long.MAX_VALUE, s), 
false);
diff -r 3e3ca9800322 
src/java.base/share/classes/java/util/stream/StreamSpliterators.java
--- a/src/java.base/share/classes/java/util/stream/StreamSpliterators.java  
Tue Nov 08 15:37:20 2016 -0800
+++ b/src/java.base/share/classes/java/util/stream/StreamSpliterators.java  
Tue Nov 08 16:36:51 2016 -0800
@@ -1346,9 +1346,9 @@
 }

 static final class OfRef extends InfiniteSupplyingSpliterator {
-final Supplier s;
+final Supplier s;

-OfRef(long size, Supplier s) {
+OfRef(long size, Supplier s) {
 super(size);
 this.s = s;
 }