Re: [Patch] cygcheck: Unset show_error and print_failed in some places.

[Bas van Gompel]

Op Mon, 15 Nov 2004 23:20:27 -0500 schreef Christopher Faylor
in <[EMAIL PROTECTED]>:
:  On Tue, Nov 16, 2004 at 04:59:25AM +0100, Bas van Gompel wrote:
: > 2004-11-16  Bas van Gompel  <[EMAIL PROTECTED]>
: >
: > * cygcheck.cc (find_on_path): Clear show_error and/or print_failed
: > parameters to display_error.
: > (rva_to_offset): Ditto.
: > (dll_info): Ditto.
: > (track_down): Ditto.
:
:   Ok.  Please check in.

Done.

:  Thanks.

Thank you.


L8r,

Buzz.
-- 
  ) |  | ---/ ---/  Yes, this | This message consists of true | I do not
--  |  |   //   really is |   and false bits entirely.| mail for
  ) |  |  //a 72 by 4 +---+ any1 but
--  \--| /--- /---  .sigfile. |   |perl -pe "s.u(z)\1.as."| me. 4^re

Re: [Patch] cygcheck: Unset show_error and print_failed in some places.

[Christopher Faylor]

On Tue, Nov 16, 2004 at 04:59:25AM +0100, Bas van Gompel wrote:
>2004-11-16  Bas van Gompel  <[EMAIL PROTECTED]>
>
>   * cygcheck.cc (find_on_path): Clear show_error and/or print_failed
>   parameters to display_error.
>   (rva_to_offset): Ditto.
>   (dll_info): Ditto.
>   (track_down): Ditto.

Ok.  Please check in.

Thanks.

cgf

[Patch] cygcheck: Unset show_error and print_failed in some places.

[Bas van Gompel]

Hi,

More trivia, I'd say.

This sets print_failed to false in places where printing "failed"
makes no sense. In some of those places show_error is also cleared.


ChangeLog-entry.

2004-11-16  Bas van Gompel  <[EMAIL PROTECTED]>

* cygcheck.cc (find_on_path): Clear show_error and/or print_failed
parameters to display_error.
(rva_to_offset): Ditto.
(dll_info): Ditto.
(track_down): Ditto.


--- src/winsup/utils/cygcheck.cc11 Nov 2004 01:56:02 -  1.62
+++ src/winsup/utils/cygcheck.cc16 Nov 2004 02:52:08 -
@@ -190,13 +190,13 @@ find_on_path (char *file, char *default_
 
   if (!file)
 {
-  display_error ("find_on_path: NULL pointer for file");
+  display_error ("find_on_path: NULL pointer for file", false, false);
   return 0;
 }
 
   if (default_extension == NULL)
 {
-  display_error ("find_on_path: NULL pointer for default_extension");
+  display_error ("find_on_path: NULL pointer for default_extension", 
false, false);
   return 0;
 }
 
@@ -305,7 +305,7 @@ rva_to_offset (int rva, char *sections, 
 
   if (sections == NULL)
 {
-  display_error ("rva_to_offset: NULL passed for sections");
+  display_error ("rva_to_offset: NULL passed for sections", true, false);
   return 0;
 }
 
@@ -437,7 +437,7 @@ dll_info (const char *path, HANDLE fh, i
 
   if (path == NULL)
 {
-  display_error ("dll_info: NULL passed for path");
+  display_error ("dll_info: NULL passed for path", true, false);
   return;
 }
 
@@ -542,13 +542,13 @@ track_down (char *file, char *suffix, in
 {
   if (file == NULL)
 {
-  display_error ("track_down: NULL passed for file");
+  display_error ("track_down: NULL passed for file", true, false);
   return;
 }
 
   if (suffix == NULL)
 {
-  display_error ("track_down: NULL passed for suffix");
+  display_error ("track_down: NULL passed for suffix", false, false);
   return;
 }
 


L8r,

Buzz.
-- 
  ) |  | ---/ ---/  Yes, this | This message consists of true | I do not
--  |  |   //   really is |   and false bits entirely.| mail for
  ) |  |  //a 72 by 4 +---+ any1 but
--  \--| /--- /---  .sigfile. |   |perl -pe "s.u(z)\1.as."| me. 4^re