Re: [patch] installer ufs initrd support (how to create a ufs filesystem as a normal user?)

2009-07-13 Thread Luca Favatella
On 07/07/2009, Luca Favatella  wrote:
> On 07/07/2009, Thorsten Glaser  wrote:
>> Luca Favatella dixit:
>>
>>>This patch adds ufs initrd support.
>>
>> 4.2FFS, UFS2, or both?
>
> In the attached second version of the patch, I explicated UFS2.
>
> UFS1 works too, but I chose to introduce only UFS2.
> (I'll use UFS2 in kfreebsd-i386 commit in next days/weeks.
> I think it is not good to add a feature and not use it.)
> See http://svn.debian.org/viewsvn/d-i?view=rev&revision=59261

Committed in svn trunk.

Cheers,
Luca Favatella


-- 
To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Re: [patch] netcfg get_all_ifs()

2009-07-13 Thread Otavio Salvador
Hello Luca,

On Mon, Jul 13, 2009 at 11:02 AM, Luca Favatella wrote:
>> Solved in the attached version 2 of the patch.
>
> I'm not committing this to trunk because could affect d-i on Linux
> (not in my test).
>
> Should I commit this?

Yes, please do; I'll upload netcfg later today so we can figure if
someone find a any regression with it.

-- 
Otavio Salvador  O.S. Systems
E-mail: ota...@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br


-- 
To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Re: [patch] netcfg get_all_ifs()

2009-07-13 Thread Luca Favatella
On 13/07/2009, Otavio Salvador  wrote:
> Hello Luca,

Hello Otavio.

>
> On Mon, Jul 13, 2009 at 11:02 AM, Luca Favatella
> wrote:
>>> Solved in the attached version 2 of the patch.
>>
>> I'm not committing this to trunk because could affect d-i on Linux
>> (not in my test).
>>
>> Should I commit this?
>
> Yes, please do; I'll upload netcfg later today so we can figure if
> someone find a any regression with it.

Done.

Thanks,
Luca Favatella


-- 
To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Re: [patch] netcfg get_all_ifs()

2009-07-13 Thread Luca Favatella
On 06/07/2009, Luca Favatella  wrote:
> On 06/07/2009, Frans Pop  wrote:
>> On Monday 06 July 2009, Luca Favatella wrote:
>>> This patch substitutes Linux-specific code in get_all_ifs() using
>>> getifaddrs().
>>
>> -if (!strcmp(ibuf, "lo"))/* ignore the loopback */
>> [...]
>> +if (!strncmp(ibuf, "lo", 2))/* ignore the loopback */
>>
>> Please do not include random changes that are unrelated to what you
>> document in the changelog in the patch. This _does_ change functionality,
>> even if in practice it will not make a difference.
>>
>> The old code would not match on an (unlikely) interface named "loop", the
>> new code will.
>>
>> Cheers,
>> FJP
>
> Solved in the attached version 2 of the patch.

I'm not committing this to trunk because could affect d-i on Linux
(not in my test).

Should I commit this?


Cheers,
Luca Favatella


-- 
To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Re: [patch] libdebian-installer poll()

2009-07-13 Thread Luca Favatella
On 09/07/2009, Luca Favatella  wrote:
> On 09/07/2009, Colin Watson  wrote:
[...]
>> While // is a valid comment syntax in C99, it wasn't in earlier versions
>> of C, and I believe that /* ... */ is still preferred in libd-i.
>
> Fixed in the attached version 2 of the patch.

Committed in svn trunk.


Cheers,
Luca Favatella


-- 
To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org