Bug#518307: gitosis spits junk out on package upgrades
Hi again!
* Daniel Baumann dan...@debian.org [2009-03-06 10:26:36 CET]:
Gerfried Fuchs wrote:
The package installation scripts should avoid producing output which
is unnecessary for the user to see
i consider it necessary, ymmv.
In the hope that you would like a patch I produced the following:
#v+
diff -u gitosis-0.2+20080825/debian/gitosis.postinst
gitosis-0.2+20080825/debian/gitosis.postinst
--- gitosis-0.2+20080825/debian/gitosis.postinst
+++ gitosis-0.2+20080825/debian/gitosis.postinst
@@ -30,7 +30,9 @@
then
adduser --system --home ${_DIRECTORY} --shell /bin/sh
--disabled-password --no-create-home --gecos 'git repository hosting' --group
${_USERNAME}
else
- echo gitosis user (${_USERNAME}) already exists, doing
nothing.
+ if [ -n $DEBUG ] ; then
+ echo gitosis user (${_USERNAME}) already
exists, doing nothing.
+ fi
fi
if [ ! -d ${_DIRECTORY} ]
@@ -56,14 +58,18 @@
fi
fi
else
- echo
- echo gitosis directory (${_DIRECTORY}) already exists,
doing nothing.
- echo Make sure the directory is recursively owned by
the correct user account (${_USERNAME}).
+ if [ $DEBUG ]; then
+ echo
+ echo gitosis directory (${_DIRECTORY}) already
exists, doing nothing.
+ echo Make sure the directory is recursively
owned by the correct user account (${_USERNAME}).
+ fi
fi
- echo
- echo Please read /usr/share/doc/gitosis/README.Debian
- echo for information about how to use gitosis.
+ if [ $DEBUG ]; then
+ echo
+ echo Please read /usr/share/doc/gitosis/README.Debian
+ echo for information about how to use gitosis.
+ fi
;;
abort-upgrade|abort-remove|abort-deconfigure)
diff -u gitosis-0.2+20080825/debian/changelog
gitosis-0.2+20080825/debian/changelog
--- gitosis-0.2+20080825/debian/changelog
+++ gitosis-0.2+20080825/debian/changelog
@@ -1,3 +1,10 @@
+gitosis (0.2+20080825-15.1) unstable; urgency=low
+
+ [ Gerfried Fuchs ]
+ * Check for $DEBUG when sending out debug informations (closes: #518307)
+
+ -- Gerfried Fuchs rho...@debian.at Wed, 26 Aug 2009 21:24:23 +0200
+
gitosis (0.2+20080825-15) unstable; urgency=low
* Using correct rfc-2822 date formats in changelog.
#v-
The approach with using the DEBUG environment variable is used by quite
some packages. I did some investigations on this and this is the most
used variable, some packages use to use package specific debugging
variables in their scripts.
Thanks in advance for considering including it,
Rhonda
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#518307: gitosis spits junk out on package upgrades
severity 518307 normal thanks * Daniel Baumann dan...@debian.org [2009-03-05 20:10:02 CET]: retitle 518307 too verbose postinst severity 518307 wishlist tags 518307 +wontfix I would be more than interested in the reasoning behind this. The README.Debian file is a file that is in a lot of packages and the de-facto standard documentation file for people to read up specific informations about a package. I have no idea why it is needed to have it mentioned in the package installation output, at all. Also, no other package doesn't create a user/group when it's already there - this might make sense for debug runs but not for a regular installation/upgrade of a package. So pretty please, be a bit more verbose on why you disagree with this bugreport. Let me also cite policy 3.9. for you: #v+ 3.9. Maintainer Scripts --- The package installation scripts should avoid producing output which is unnecessary for the user to see #v- So I would really be interested in why you think this should request doesn't apply here. If you prefer I can produce a patch for you to ease your job. Thanks in advance, Rhonda -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#518307: gitosis spits junk out on package upgrades
Gerfried Fuchs wrote: The package installation scripts should avoid producing output which is unnecessary for the user to see i consider it necessary, ymmv. -- Address:Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist Email: daniel.baum...@panthera-systems.net Internet: http://people.panthera-systems.net/~daniel-baumann/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#518307: gitosis spits junk out on package upgrades
* Daniel Baumann dan...@debian.org [2009-03-06 10:24:24 CET]: # don't play bts ping-pong, thanks Well, if you don't lie out your reasoning why you disagree with policy here, I can just think that you forgot about that part. it's a wish of yours and not a bug in the acutal meaning, read policy 3.9, thanks. I did, and I even cited it to you. Can you now please explain to me why you disagree with the should in exactly that paragraph? For convenience, I cite the mentioned policy part again: #v+ 3.9. Maintainer Scripts --- The package installation scripts should avoid producing output which is unnecessary for the user to see and should rely on `dpkg' to stave off boredom on the part of a user installing many packages. This means, amongst other things, using the `--quiet' option on `install-info'. #v- Please enlighten me why you think that this doesn't hold for the messages your postinst spits out and why you think this shouldn't get fixed. Thanks, Rhonda -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#518307: gitosis spits junk out on package upgrades
Gerfried Fuchs wrote: Well, if you don't lie out your reasoning why you disagree with policy here, I can just think that you forgot about that part. i wrote i consider it necessary, ymmv. it's a wish of yours and not a bug in the acutal meaning, read policy 3.9, thanks. I did, and I even cited it to you. for the records, you may also want to consider that #23 was my first reply, and #33 my second as the bts did send me first the control output of yours, and second the actual mail which came a few minutes later. Can you now please explain to me why you disagree with the should in exactly that paragraph? For convenience, I cite the mentioned policy part again: i already did, see #33 and, for your convenience, my citation of it above. -- Address:Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist Email: daniel.baum...@panthera-systems.net Internet: http://people.panthera-systems.net/~daniel-baumann/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#518307: gitosis spits junk out on package upgrades
* Daniel Baumann dan...@debian.org [2009-03-06 10:54:02 CET]: Gerfried Fuchs wrote: Well, if you don't lie out your reasoning why you disagree with policy here, I can just think that you forgot about that part. i wrote i consider it necessary, ymmv. ... in a later mail that I only saw after I replied to that one. And still that isn't really a reasoning, sorry. it's a wish of yours and not a bug in the acutal meaning, read policy 3.9, thanks. I did, and I even cited it to you. for the records, you may also want to consider that #23 was my first reply, Yes, to which I replied. and #33 my second as the bts did send me first the control output of yours, and second the actual mail which came a few minutes later. Same here, so please consider similar time-based reasons that you want me to consider for you. :) Can you now please explain to me why you disagree with the should in exactly that paragraph? For convenience, I cite the mentioned policy part again: i already did, see #33 and, for your convenience, my citation of it above. No, you didn't. You said you consider it necessary but didn't mention why so which would make it possible for others to understand why you work against policy recommendations here. Thanks, Rhonda -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#518307: gitosis spits junk out on package upgrades
Package: gitosis Version: 0.2+20080825-10 Severity: normal Hi! It would be more than convenient if gitosis wouldn't run in debug mode when upgrading packages. Things like gitosis user (gitosis) is already existing, doing nothing. and gitosis directory (/srv/gitosis) is already existing, doing nothing. aren't really doing nothing, it's doing echo to the screen of the user for things that wouldn't have to be there. But most notably: Please read /usr/share/doc/gitosis/README.Debian for information about how to use gitosis. This is a message that has nothing to do in the output of a postinst script, especially not on upgrades. Pretty please turn off this debug informations, they don't need to be presented to the users in that stage. Thanks. Rhonda -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
