Bug#597820: linux-image-2.6.32-5-amd64: 2.6.32 doesn't support the f71889fg sensor chip
On Mon, Oct 04, 2010 at 09:44:28AM +0200, Mike Hommey wrote: On Mon, Oct 04, 2010 at 09:29:20AM +0200, Mike Hommey wrote: Right, it seems that I forgot a single break-statement (causing the driver to fall through to the undetected part). Attached patch has this fixed and should work properly. I may have fucked up, but it looks like it doesn't work either. Same behaviour as before. :( I'm trying another build. I did fuck up, and it just works fine. I used watchdog-test and kill -STOP it, and the machine rebooted within a few seconds, as expected. Should I file a new bug for the watchdog support or will you just not apply these patches for squeeze? Thanks, Mike -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101014131542.ga10...@glandium.org
Bug#597820: linux-image-2.6.32-5-amd64: 2.6.32 doesn't support the f71889fg sensor chip
On Sun, Oct 03, 2010 at 02:02:32PM +0200, Giel van Schijndel wrote: On Sun, Oct 03, 2010 at 09:14:44AM +0200, Mike Hommey wrote: On Sun, Oct 03, 2010 at 01:14:24AM +0200, Giel van Schijndel wrote: On Sat, Oct 02, 2010 at 08:42:19PM +0100, Ben Hutchings wrote: On Tue, 2010-09-28 at 10:36 +0200, Mike Hommey wrote: I would also be interested in the watchdog support for the same chip, That patch does *not* add watchdog support for the Fintek F71889FG chip, it *only* adds support for the F71808E and the F71882FG. Oops. Additionally a patch for the F71862FG is currently pending review and inclusion. That being said, this driver should be fairly easy to expand to include support for the F71889FG chip (AFAIK only pin-configuration should be added, which probably is just a datasheet-reading exercise). Adding support however would be something I'd suggest doing across the LKML *first*, then (optionally) backport it later. However, the last patch (729d273aa7c86eb1406ade4eadf249cff188bf9a) doesn't look right; surely it should be using the new request_muxed_region() macro too? IIRC that patch was submitted and applied *before* 8b6d043, hence request_muxed_region() wasn't available and thus not used. The patch to make use of request_muxed_region() [1] has been acked [2] but not yet applied yet, I've just sent out a poke-mail (CC-ed to this bug) with the request for it to be committed. [1] 1280669455-31283-1-git-send-email...@mortis.eu AFAICS, this id refers to the patch that ended in 96cb4eb019ce3185ec0d946a74b5a2202f5067c9. I can't find that commit in Torvald's tree. Who's the author and what's the first line of the commit message? commit 96cb4eb019ce3185ec0d946a74b5a2202f5067c9 Author: Giel van Schijndel m...@mortis.eu Date: Sun Aug 1 15:30:55 2010 +0200 watchdog: f71808e_wdt: new watchdog driver for Fintek F71808E and F71882FG In Linus' tree. $ git describe --contains 96cb4eb019ce3185ec0d946a74b5a2202f5067c9 v2.6.36-rc1~290^2~2 The one you are referring to must be http://marc.info/?l=lm-sensorsm=127219192018988w=2 Actually I'm referring to this patch (updated/rebased version of the one you're referring to): http://marc.info/?l=linux-kernelm=128066949410960w=2 PS marc.info allows direct searching on Message-ID like so: http://marc.info/?i=$message_id e.g.: http://marc.info/?i=1280669455-31283-1-git-send-email...@mortis.eu Interestingly, I found this with your message-id: https://patchwork.kernel.org/patch/116315/ Mike -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101004064033.ga4...@glandium.org
Bug#597820: linux-image-2.6.32-5-amd64: 2.6.32 doesn't support the f71889fg sensor chip
On Sun, Oct 03, 2010 at 02:47:11PM +0200, Giel van Schijndel wrote: On Sun, Oct 03, 2010 at 11:21:42AM +0200, Mike Hommey wrote: On Sun, Oct 03, 2010 at 01:33:23AM +0200, Giel van Schijndel wrote: On Sun, Oct 03, 2010 at 01:14:24AM +0200, Giel van Schijndel wrote: On Sat, Oct 02, 2010 at 08:42:19PM +0100, Ben Hutchings wrote: On Tue, 2010-09-28 at 10:36 +0200, Mike Hommey wrote: I would also be interested in the watchdog support for the same chip, That patch does *not* add watchdog support for the Fintek F71889FG chip, it *only* adds support for the F71808E and the F71882FG. Additionally a patch for the F71862FG is currently pending review and inclusion. That being said, this driver should be fairly easy to expand to include support for the F71889FG chip (AFAIK only pin-configuration should be added, which probably is just a datasheet-reading exercise). Adding support however would be something I'd suggest doing across the LKML *first*, then (optionally) backport it later. Heck I gave it a try and attached you'll find a patch to add F71889FG support to the current f71808e_wdt watchdog driver. The reason I haven't send this to the LKML before however, is that I don't have any system with that chip to test it, so please do test it and tell me the results. I gave a try to your patch, on top of the other ones. For the kernel team, please note that some of the patches don't apply cleanly on 2.6.32, because of some changes in context (mostly coding-style changes) that apparently happened between 2.6.32 and the various patches landing. I manually edited the patches to make them apply properly, please ping me if you want the modified versions. The configs also need to be modified to include CONFIG_F71808E_WDT=m. For the patches cherry-picking 729d273a, 8b6d043 and 96cb4eb (in that order) will do. 8b6d043 will probably cause a merge-conflict, just ditch IORESOURCE_WINDOW and you should be able to finish that cherry-pick. Exactly. I also had to edit the hwmon: f71882fg: use a muxed resource lock for the Super I/O port because of style changes. Still for the kernel team, applying the release_mutex_region patch makes the ABI check script barf with the following changes: __devm_release_regionmodule: vmlinux, version: 0x969a2a91 - 0x70191467, export: EXPORT_SYMBOL __devm_request_regionmodule: vmlinux, version: 0x51144912 - 0x9e7acb57, export: EXPORT_SYMBOL For Giel, it appears the watchdog driver doesn't entirely work: It loads fine: f71808e_wdt: Found f71889fg watchdog chip, revision 21 But watchdog-test (as from Documentation/watchdog/src/watchdog-test.c) doesn't work and outputs: Watchdog device not enabled. stracing it shows this: open(/dev/watchdog, O_WRONLY) = -1 ENODEV (No such device) Right, it seems that I forgot a single break-statement (causing the driver to fall through to the undetected part). Attached patch has this fixed and should work properly. I may have fucked up, but it looks like it doesn't work either. Same behaviour as before. :( I'm trying another build. Mike -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101004072920.ga5...@glandium.org
Bug#597820: linux-image-2.6.32-5-amd64: 2.6.32 doesn't support the f71889fg sensor chip
On Mon, Oct 04, 2010 at 08:40:33 +0200, Mike Hommey wrote: On Sun, Oct 03, 2010 at 14:02:32 +0200, Giel van Schijndel wrote: On Sun, Oct 03, 2010 at 09:14:44 +0200, Mike Hommey wrote: On Sun, Oct 03, 2010 at 01:14:24AM +0200, Giel van Schijndel wrote: [1] 1280669455-31283-1-git-send-email...@mortis.eu AFAICS, this id refers to the patch that ended in 96cb4eb019ce3185ec0d946a74b5a2202f5067c9. I can't find that commit in Torvald's tree. Who's the author and what's the first line of the commit message? .. snip .. In Linus' tree. $ git describe --contains 96cb4eb019ce3185ec0d946a74b5a2202f5067c9 v2.6.36-rc1~290^2~2 Right, looking at my shell's history I see I accidentily copied the dot following the SHA-1 hash. Removing it solved that problem. And yes that patch is part of the same series as the one eventually adding the watchdog driver. That patch is now applied in the hwmon branch of Guenter Roeck's staging tree with hash cadb86570c41fe52a0ea741f1f9775e3412f0167. http://git.kernel.org/?p=linux/kernel/git/groeck/staging.git;a=summary The one you are referring to must be http://marc.info/?l=lm-sensorsm=127219192018988w=2 Actually I'm referring to this patch (updated/rebased version of the one you're referring to): http://marc.info/?l=linux-kernelm=128066949410960w=2 PS marc.info allows direct searching on Message-ID like so: http://marc.info/?i=$message_id e.g.: http://marc.info/?i=1280669455-31283-1-git-send-email...@mortis.eu Interestingly, I found this with your message-id: https://patchwork.kernel.org/patch/116315/ That Message-ID isn't the same, note the ...-31283-2-git-... part instead of the ...-31283-1-git-... part given in my Message-ID. That patch is the second in the same patch series. This patch is the correct one: https://patchwork.kernel.org/patch/116314/ -- Met vriendelijke groet, With kind regards, Giel van Schijndel -- A clever person solves a problem. A wise person avoids it. -- Albert Einstein signature.asc Description: Digital signature
Bug#597820: linux-image-2.6.32-5-amd64: 2.6.32 doesn't support the f71889fg sensor chip
On Mon, Oct 04, 2010 at 09:29:20AM +0200, Mike Hommey wrote: Right, it seems that I forgot a single break-statement (causing the driver to fall through to the undetected part). Attached patch has this fixed and should work properly. I may have fucked up, but it looks like it doesn't work either. Same behaviour as before. :( I'm trying another build. I did fuck up, and it just works fine. I used watchdog-test and kill -STOP it, and the machine rebooted within a few seconds, as expected. Thanks Mike -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101004074428.ga5...@glandium.org
Bug#597820: linux-image-2.6.32-5-amd64: 2.6.32 doesn't support the f71889fg sensor chip
On Sun, Oct 03, 2010 at 01:14:24AM +0200, Giel van Schijndel wrote: On Sat, Oct 02, 2010 at 08:42:19PM +0100, Ben Hutchings wrote: On Tue, 2010-09-28 at 10:36 +0200, Mike Hommey wrote: On Thu, Sep 23, 2010 at 12:36:04PM +0200, Mike Hommey wrote: Package: linux-2.6 Version: 2.6.32-23 Severity: wishlist Tags: squeeze I installed a fresh squeeze on a new PC with a MSI P55M-GD45 motherboard that uses a f71889fg sensor chip. Unfortunately, while lm-sensors' sensor-detect is able to find the chip and suggest a kernel module, the module doesn't load because it lacks support for the chip. The support was added somewhen between 2.6.32 and 2.6.33, and was added by commit 7669896f. I hear that you add support for hardware when the backport is simple, this one is pretty trivial. For other reasons, I already switched to 2.6.35 on that machine, so it's not a problem for me anymore, but the motherboard is already quite old, so other people may have similar problems with a fresh squeeze. I would also be interested in the watchdog support for the same chip, That patch does *not* add watchdog support for the Fintek F71889FG chip, it *only* adds support for the F71808E and the F71882FG. Oops. Additionally a patch for the F71862FG is currently pending review and inclusion. That being said, this driver should be fairly easy to expand to include support for the F71889FG chip (AFAIK only pin-configuration should be added, which probably is just a datasheet-reading exercise). Adding support however would be something I'd suggest doing across the LKML *first*, then (optionally) backport it later. coming in 96cb4eb019ce3185ec0d946a74b5a2202f5067c9. AFAICT, it requires 8b6d043b7ee2d1b819dc833d677ea2aead71a0c0 and possibly 729d273aa7c86eb1406ade4eadf249cff188bf9a. I'm not sure how intrusive these could be considered. They seem a bit intrusive but probably safe. I would consider 729d273 to be safe. 8b6d043 is a bit more complex, though it should only affect I/O resources acquired with the newly introduced flag IORESOURCE_MUXED, it thus shouldn't affect pre-existing code. However, the last patch (729d273aa7c86eb1406ade4eadf249cff188bf9a) doesn't look right; surely it should be using the new request_muxed_region() macro too? IIRC that patch was submitted and applied *before* 8b6d043, hence request_muxed_region() wasn't available and thus not used. The patch to make use of request_muxed_region() [1] has been acked [2] but not yet applied yet, I've just sent out a poke-mail (CC-ed to this bug) with the request for it to be committed. [1] 1280669455-31283-1-git-send-email...@mortis.eu AFAICS, this id refers to the patch that ended in 96cb4eb019ce3185ec0d946a74b5a2202f5067c9. The one you are referring to must be http://marc.info/?l=lm-sensorsm=127219192018988w=2 I will give a try to your patch for the F71889FG watchdog, thanks. Mike -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101003071444.ga4...@glandium.org
Bug#597820: linux-image-2.6.32-5-amd64: 2.6.32 doesn't support the f71889fg sensor chip
On Sun, Oct 03, 2010 at 01:33:23AM +0200, Giel van Schijndel wrote: On Sun, Oct 03, 2010 at 01:14:24AM +0200, Giel van Schijndel wrote: On Sat, Oct 02, 2010 at 08:42:19PM +0100, Ben Hutchings wrote: On Tue, 2010-09-28 at 10:36 +0200, Mike Hommey wrote: I would also be interested in the watchdog support for the same chip, That patch does *not* add watchdog support for the Fintek F71889FG chip, it *only* adds support for the F71808E and the F71882FG. Additionally a patch for the F71862FG is currently pending review and inclusion. That being said, this driver should be fairly easy to expand to include support for the F71889FG chip (AFAIK only pin-configuration should be added, which probably is just a datasheet-reading exercise). Adding support however would be something I'd suggest doing across the LKML *first*, then (optionally) backport it later. Heck I gave it a try and attached you'll find a patch to add F71889FG support to the current f71808e_wdt watchdog driver. The reason I haven't send this to the LKML before however, is that I don't have any system with that chip to test it, so please do test it and tell me the results. I gave a try to your patch, on top of the other ones. For the kernel team, please note that some of the patches don't apply cleanly on 2.6.32, because of some changes in context (mostly coding-style changes) that apparently happened between 2.6.32 and the various patches landing. I manually edited the patches to make them apply properly, please ping me if you want the modified versions. The configs also need to be modified to include CONFIG_F71808E_WDT=m. Still for the kernel team, applying the release_mutex_region patch makes the ABI check script barf with the following changes: __devm_release_regionmodule: vmlinux, version: 0x969a2a91 - 0x70191467, export: EXPORT_SYMBOL __devm_request_regionmodule: vmlinux, version: 0x51144912 - 0x9e7acb57, export: EXPORT_SYMBOL For Giel, it appears the watchdog driver doesn't entirely work: It loads fine: f71808e_wdt: Found f71889fg watchdog chip, revision 21 But watchdog-test (as from Documentation/watchdog/src/watchdog-test.c) doesn't work and outputs: Watchdog device not enabled. stracing it shows this: open(/dev/watchdog, O_WRONLY) = -1 ENODEV (No such device) Please tell me if you need more feedback. Thanks, Mike -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101003092142.ga6...@glandium.org
Bug#597820: linux-image-2.6.32-5-amd64: 2.6.32 doesn't support the f71889fg sensor chip
On Sun, Oct 03, 2010 at 09:14:44AM +0200, Mike Hommey wrote: On Sun, Oct 03, 2010 at 01:14:24AM +0200, Giel van Schijndel wrote: On Sat, Oct 02, 2010 at 08:42:19PM +0100, Ben Hutchings wrote: On Tue, 2010-09-28 at 10:36 +0200, Mike Hommey wrote: I would also be interested in the watchdog support for the same chip, That patch does *not* add watchdog support for the Fintek F71889FG chip, it *only* adds support for the F71808E and the F71882FG. Oops. Additionally a patch for the F71862FG is currently pending review and inclusion. That being said, this driver should be fairly easy to expand to include support for the F71889FG chip (AFAIK only pin-configuration should be added, which probably is just a datasheet-reading exercise). Adding support however would be something I'd suggest doing across the LKML *first*, then (optionally) backport it later. However, the last patch (729d273aa7c86eb1406ade4eadf249cff188bf9a) doesn't look right; surely it should be using the new request_muxed_region() macro too? IIRC that patch was submitted and applied *before* 8b6d043, hence request_muxed_region() wasn't available and thus not used. The patch to make use of request_muxed_region() [1] has been acked [2] but not yet applied yet, I've just sent out a poke-mail (CC-ed to this bug) with the request for it to be committed. [1] 1280669455-31283-1-git-send-email...@mortis.eu AFAICS, this id refers to the patch that ended in 96cb4eb019ce3185ec0d946a74b5a2202f5067c9. I can't find that commit in Torvald's tree. Who's the author and what's the first line of the commit message? The one you are referring to must be http://marc.info/?l=lm-sensorsm=127219192018988w=2 Actually I'm referring to this patch (updated/rebased version of the one you're referring to): http://marc.info/?l=linux-kernelm=128066949410960w=2 PS marc.info allows direct searching on Message-ID like so: http://marc.info/?i=$message_id e.g.: http://marc.info/?i=1280669455-31283-1-git-send-email...@mortis.eu -- Met vriendelijke groet, With kind regards, Giel van Schijndel -- The required techniques of effective reasoning are pretty formal, but as long as programming is done by people that don't master them, the software crisis will remain with us and will be considered an incurable disease. And you know what incurable diseases do: they invite the quacks and charlatans in, who in this case take the form of Software Engineering gurus. -- Edsger Dijkstra signature.asc Description: Digital signature
Bug#597820: linux-image-2.6.32-5-amd64: 2.6.32 doesn't support the f71889fg sensor chip
On Sun, Oct 03, 2010 at 11:21:42AM +0200, Mike Hommey wrote: On Sun, Oct 03, 2010 at 01:33:23AM +0200, Giel van Schijndel wrote: On Sun, Oct 03, 2010 at 01:14:24AM +0200, Giel van Schijndel wrote: On Sat, Oct 02, 2010 at 08:42:19PM +0100, Ben Hutchings wrote: On Tue, 2010-09-28 at 10:36 +0200, Mike Hommey wrote: I would also be interested in the watchdog support for the same chip, That patch does *not* add watchdog support for the Fintek F71889FG chip, it *only* adds support for the F71808E and the F71882FG. Additionally a patch for the F71862FG is currently pending review and inclusion. That being said, this driver should be fairly easy to expand to include support for the F71889FG chip (AFAIK only pin-configuration should be added, which probably is just a datasheet-reading exercise). Adding support however would be something I'd suggest doing across the LKML *first*, then (optionally) backport it later. Heck I gave it a try and attached you'll find a patch to add F71889FG support to the current f71808e_wdt watchdog driver. The reason I haven't send this to the LKML before however, is that I don't have any system with that chip to test it, so please do test it and tell me the results. I gave a try to your patch, on top of the other ones. For the kernel team, please note that some of the patches don't apply cleanly on 2.6.32, because of some changes in context (mostly coding-style changes) that apparently happened between 2.6.32 and the various patches landing. I manually edited the patches to make them apply properly, please ping me if you want the modified versions. The configs also need to be modified to include CONFIG_F71808E_WDT=m. For the patches cherry-picking 729d273a, 8b6d043 and 96cb4eb (in that order) will do. 8b6d043 will probably cause a merge-conflict, just ditch IORESOURCE_WINDOW and you should be able to finish that cherry-pick. Still for the kernel team, applying the release_mutex_region patch makes the ABI check script barf with the following changes: __devm_release_regionmodule: vmlinux, version: 0x969a2a91 - 0x70191467, export: EXPORT_SYMBOL __devm_request_regionmodule: vmlinux, version: 0x51144912 - 0x9e7acb57, export: EXPORT_SYMBOL For Giel, it appears the watchdog driver doesn't entirely work: It loads fine: f71808e_wdt: Found f71889fg watchdog chip, revision 21 But watchdog-test (as from Documentation/watchdog/src/watchdog-test.c) doesn't work and outputs: Watchdog device not enabled. stracing it shows this: open(/dev/watchdog, O_WRONLY) = -1 ENODEV (No such device) Right, it seems that I forgot a single break-statement (causing the driver to fall through to the undetected part). Attached patch has this fixed and should work properly. -- Giel -- When all you have is a hammer, everything starts to look like a nail. -- Abraham Maslow From c8d5d90e182739da8e5f4ff9ff0163ddde9c66cd Mon Sep 17 00:00:00 2001 From: Giel van Schijndel m...@mortis.eu Date: Sun, 3 Oct 2010 01:29:17 +0200 Subject: [PATCH] watchdog: f71808e_wdt: add support for the F71889FG --- drivers/watchdog/f71808e_wdt.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/drivers/watchdog/f71808e_wdt.c b/drivers/watchdog/f71808e_wdt.c index 7e5c266..65e5796 100644 --- a/drivers/watchdog/f71808e_wdt.c +++ b/drivers/watchdog/f71808e_wdt.c @@ -308,6 +308,12 @@ static int watchdog_start(void) superio_set_bit(watchdog.sioaddr, 0x29, 1); break; + case f71889fg: + /* set pin 40 to WDTRST# */ + superio_outb(watchdog.sioaddr, 0x2b, +superio_inb(watchdog.sioaddr, 0x2b) 0xcf); + break; + default: /* * 'default' label to shut up the compiler and catch @@ -708,8 +714,10 @@ static int __init f71808e_find(int sioaddr) case SIO_F71882_ID: watchdog.type = f71882fg; break; - case SIO_F71862_ID: case SIO_F71889_ID: + watchdog.type = f71889fg; + break; + case SIO_F71862_ID: /* These have a watchdog, though it isn't implemented (yet). */ err = -ENOSYS; goto exit; -- 1.6.4.4 signature.asc Description: Digital signature
Bug#597820: linux-image-2.6.32-5-amd64: 2.6.32 doesn't support the f71889fg sensor chip
On Tue, 2010-09-28 at 10:36 +0200, Mike Hommey wrote: On Thu, Sep 23, 2010 at 12:36:04PM +0200, Mike Hommey wrote: Package: linux-2.6 Version: 2.6.32-23 Severity: wishlist Tags: squeeze I installed a fresh squeeze on a new PC with a MSI P55M-GD45 motherboard that uses a f71889fg sensor chip. Unfortunately, while lm-sensors' sensor-detect is able to find the chip and suggest a kernel module, the module doesn't load because it lacks support for the chip. The support was added somewhen between 2.6.32 and 2.6.33, and was added by commit 7669896f. I hear that you add support for hardware when the backport is simple, this one is pretty trivial. For other reasons, I already switched to 2.6.35 on that machine, so it's not a problem for me anymore, but the motherboard is already quite old, so other people may have similar problems with a fresh squeeze. I would also be interested in the watchdog support for the same chip, coming in 96cb4eb019ce3185ec0d946a74b5a2202f5067c9. AFAICT, it requires 8b6d043b7ee2d1b819dc833d677ea2aead71a0c0 and possibly 729d273aa7c86eb1406ade4eadf249cff188bf9a. I'm not sure how intrusive these could be considered. They seem a bit intrusive but probably safe. However, the last patch (729d273aa7c86eb1406ade4eadf249cff188bf9a) doesn't look right; surely it should be using the new request_muxed_region() macro too? Ben. -- Ben Hutchings Once a job is fouled up, anything done to improve it makes it worse. signature.asc Description: This is a digitally signed message part
Bug#597820: linux-image-2.6.32-5-amd64: 2.6.32 doesn't support the f71889fg sensor chip
On Sat, Oct 02, 2010 at 08:42:19PM +0100, Ben Hutchings wrote: On Tue, 2010-09-28 at 10:36 +0200, Mike Hommey wrote: On Thu, Sep 23, 2010 at 12:36:04PM +0200, Mike Hommey wrote: Package: linux-2.6 Version: 2.6.32-23 Severity: wishlist Tags: squeeze I installed a fresh squeeze on a new PC with a MSI P55M-GD45 motherboard that uses a f71889fg sensor chip. Unfortunately, while lm-sensors' sensor-detect is able to find the chip and suggest a kernel module, the module doesn't load because it lacks support for the chip. The support was added somewhen between 2.6.32 and 2.6.33, and was added by commit 7669896f. I hear that you add support for hardware when the backport is simple, this one is pretty trivial. For other reasons, I already switched to 2.6.35 on that machine, so it's not a problem for me anymore, but the motherboard is already quite old, so other people may have similar problems with a fresh squeeze. I would also be interested in the watchdog support for the same chip, That patch does *not* add watchdog support for the Fintek F71889FG chip, it *only* adds support for the F71808E and the F71882FG. Additionally a patch for the F71862FG is currently pending review and inclusion. That being said, this driver should be fairly easy to expand to include support for the F71889FG chip (AFAIK only pin-configuration should be added, which probably is just a datasheet-reading exercise). Adding support however would be something I'd suggest doing across the LKML *first*, then (optionally) backport it later. coming in 96cb4eb019ce3185ec0d946a74b5a2202f5067c9. AFAICT, it requires 8b6d043b7ee2d1b819dc833d677ea2aead71a0c0 and possibly 729d273aa7c86eb1406ade4eadf249cff188bf9a. I'm not sure how intrusive these could be considered. They seem a bit intrusive but probably safe. I would consider 729d273 to be safe. 8b6d043 is a bit more complex, though it should only affect I/O resources acquired with the newly introduced flag IORESOURCE_MUXED, it thus shouldn't affect pre-existing code. However, the last patch (729d273aa7c86eb1406ade4eadf249cff188bf9a) doesn't look right; surely it should be using the new request_muxed_region() macro too? IIRC that patch was submitted and applied *before* 8b6d043, hence request_muxed_region() wasn't available and thus not used. The patch to make use of request_muxed_region() [1] has been acked [2] but not yet applied yet, I've just sent out a poke-mail (CC-ed to this bug) with the request for it to be committed. [1] 1280669455-31283-1-git-send-email...@mortis.eu [2] 4c59514a.7090...@redhat.com -- Met vriendelijke groet, With kind regards, Giel van Schijndel -- Nine people can't make a baby in a month. -- Fred Brooks signature.asc Description: Digital signature
Bug#597820: linux-image-2.6.32-5-amd64: 2.6.32 doesn't support the f71889fg sensor chip
On Sun, Oct 03, 2010 at 01:14:24AM +0200, Giel van Schijndel wrote: On Sat, Oct 02, 2010 at 08:42:19PM +0100, Ben Hutchings wrote: On Tue, 2010-09-28 at 10:36 +0200, Mike Hommey wrote: I would also be interested in the watchdog support for the same chip, That patch does *not* add watchdog support for the Fintek F71889FG chip, it *only* adds support for the F71808E and the F71882FG. Additionally a patch for the F71862FG is currently pending review and inclusion. That being said, this driver should be fairly easy to expand to include support for the F71889FG chip (AFAIK only pin-configuration should be added, which probably is just a datasheet-reading exercise). Adding support however would be something I'd suggest doing across the LKML *first*, then (optionally) backport it later. Heck I gave it a try and attached you'll find a patch to add F71889FG support to the current f71808e_wdt watchdog driver. The reason I haven't send this to the LKML before however, is that I don't have any system with that chip to test it, so please do test it and tell me the results. -- Met vriendelijke groet, With kind regards, Giel van Schijndel -- It would seem that perfection is attained not when no more can be added, but when no more can be removed. -- Antoine de Saint Exupéry From 842fb8626d06a1aa4fc8565f2040b3d8e99e8a9d Mon Sep 17 00:00:00 2001 From: Giel van Schijndel m...@mortis.eu Date: Sun, 3 Oct 2010 01:29:17 +0200 Subject: [PATCH] watchdog: f71808e_wdt: add support for the F71889FG --- drivers/watchdog/f71808e_wdt.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/drivers/watchdog/f71808e_wdt.c b/drivers/watchdog/f71808e_wdt.c index 7e5c266..2753eee 100644 --- a/drivers/watchdog/f71808e_wdt.c +++ b/drivers/watchdog/f71808e_wdt.c @@ -308,6 +308,11 @@ static int watchdog_start(void) superio_set_bit(watchdog.sioaddr, 0x29, 1); break; + case f71889fg: + /* set pin 40 to WDTRST# */ + superio_outb(watchdog.sioaddr, 0x2b, +superio_inb(watchdog.sioaddr, 0x2b) 0xcf); + default: /* * 'default' label to shut up the compiler and catch @@ -708,8 +713,10 @@ static int __init f71808e_find(int sioaddr) case SIO_F71882_ID: watchdog.type = f71882fg; break; - case SIO_F71862_ID: case SIO_F71889_ID: + watchdog.type = f71889fg; + break; + case SIO_F71862_ID: /* These have a watchdog, though it isn't implemented (yet). */ err = -ENOSYS; goto exit; -- 1.6.4.4 signature.asc Description: Digital signature
Bug#597820: linux-image-2.6.32-5-amd64: 2.6.32 doesn't support the f71889fg sensor chip
On Thu, Sep 23, 2010 at 12:36:04PM +0200, Mike Hommey wrote: Package: linux-2.6 Version: 2.6.32-23 Severity: wishlist Tags: squeeze I installed a fresh squeeze on a new PC with a MSI P55M-GD45 motherboard that uses a f71889fg sensor chip. Unfortunately, while lm-sensors' sensor-detect is able to find the chip and suggest a kernel module, the module doesn't load because it lacks support for the chip. The support was added somewhen between 2.6.32 and 2.6.33, and was added by commit 7669896f. I hear that you add support for hardware when the backport is simple, this one is pretty trivial. For other reasons, I already switched to 2.6.35 on that machine, so it's not a problem for me anymore, but the motherboard is already quite old, so other people may have similar problems with a fresh squeeze. I would also be interested in the watchdog support for the same chip, coming in 96cb4eb019ce3185ec0d946a74b5a2202f5067c9. AFAICT, it requires 8b6d043b7ee2d1b819dc833d677ea2aead71a0c0 and possibly 729d273aa7c86eb1406ade4eadf249cff188bf9a. I'm not sure how intrusive these could be considered. Mike -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20100928083618.ga23...@glandium.org
Bug#597820: linux-image-2.6.32-5-amd64: 2.6.32 doesn't support the f71889fg sensor chip
Package: linux-2.6 Version: 2.6.32-23 Severity: wishlist Tags: squeeze I installed a fresh squeeze on a new PC with a MSI P55M-GD45 motherboard that uses a f71889fg sensor chip. Unfortunately, while lm-sensors' sensor-detect is able to find the chip and suggest a kernel module, the module doesn't load because it lacks support for the chip. The support was added somewhen between 2.6.32 and 2.6.33, and was added by commit 7669896f. I hear that you add support for hardware when the backport is simple, this one is pretty trivial. For other reasons, I already switched to 2.6.35 on that machine, so it's not a problem for me anymore, but the motherboard is already quite old, so other people may have similar problems with a fresh squeeze. Cheers, Mike -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20100923103604.24446.69703.report...@jigen.glandium.org
