Bug#886326: stretch-pu: package zssh/1.5c.debian.1-3.2+deb9u1

[Adrian Bunk]

On Sat, Feb 10, 2018 at 07:20:51PM +0800, Boyuan Yang wrote:
>...
> As described in
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=769366#61 , Current
> version
> of zssh in Debian Stretch (on amd64 architecture, versioned
> 1.5c.debian.1-3.2+b4) suffers from
> RC bug #769366. I had little idea why this happened because a
> no-change rebuild on Debian
> Stretch would make zssh fully functional.
>...
> How does a rebuild solve it? I have no idea currently: It Just Works™.
> I could have digged into
> the problem but the time to be spent would not be efficient when a
> simple rebuild solves it.
> 
> I think those described above should make a stretch-pu for zssh reasonable.

What actually fixed zssh in 1.5c.debian.1-4 is the following:
  * Bump debhelper compat to v10.

After looking at the #388036 fix I tried v9 instead,
and as expected this gave me a broken package,

An actual fix would be something like:

diff -Nru zssh-1.5c.debian.1/debian/control zssh-1.5c.debian.1/debian/control
--- zssh-1.5c.debian.1/debian/control   2014-07-21 11:30:52.0 +0300
+++ zssh-1.5c.debian.1/debian/control   2018-03-12 22:33:59.0 +0200
@@ -2,7 +2,7 @@
 Section: net
 Priority: optional
 Maintainer: Ben Wong 
-Build-Depends: cdbs, debhelper (>= 5), autotools-dev, libncurses5-dev, 
libreadline-dev, autoconf, quilt
+Build-Depends: cdbs, debhelper (>= 5), autotools-dev, libncurses5-dev, 
libreadline-dev, autoconf, quilt, dh-autoreconf
 Standards-Version: 3.7.2
 
 Package: zssh
diff -Nru zssh-1.5c.debian.1/debian/rules zssh-1.5c.debian.1/debian/rules
--- zssh-1.5c.debian.1/debian/rules 2014-07-21 11:27:39.0 +0300
+++ zssh-1.5c.debian.1/debian/rules 2018-03-12 22:08:24.0 +0200
@@ -2,6 +2,7 @@
 
 include /usr/share/cdbs/1/rules/debhelper.mk
 include /usr/share/cdbs/1/class/autotools.mk
+include /usr/share/cdbs/1/rules/autoreconf.mk
 include /usr/share/cdbs/1/rules/patchsys-quilt.mk
 
 DEB_INSTALL_DOCS_ALL += FAQ


> Regards,
> Boyuan Yang

cu
Adrian

-- 

   "Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
   "Only a promise," Lao Er said.
   Pearl S. Buck - Dragon Seed

Bug#886326: stretch-pu: package zssh/1.5c.debian.1-3.2+deb9u1

[Boyuan Yang]

2018-02-10 19:20 GMT+08:00 Boyuan Yang <073p...@gmail.com>:
> 2018-02-10 19:08 GMT+08:00 Julien Cristau :
>> Control: tag -1 moreinfo
>>
>> On Thu, Jan  4, 2018 at 21:51:12 +0800, Boyuan Yang wrote:
>>
>>> After adoption of package zssh, I'm looking to fix the RC bug #769366 in 
>>> Debian Stretch.
>>> A simple rebuild solved the problem, thus requesting a pre-approval from 
>>> the release team.
>>>
>> What is the issue and how does a rebuild solve it?
>>
>> Thanks,
>> Julien
>
> The issue: zssh on Debian Stretch (at least on amd64 architecture)
> will not start at all and the
> symptom is the same as what happened in Debian Bug #769366.
>
> As described in
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=769366#61 , Current
> version
> of zssh in Debian Stretch (on amd64 architecture, versioned
> 1.5c.debian.1-3.2+b4) suffers from
> RC bug #769366. I had little idea why this happened because a
> no-change rebuild on Debian
> Stretch would make zssh fully functional. I tried gdb but the result
> was not helpful.
>
> The previous packager said he once solved this problem in a previous
> upload so the problem
> might have been introduced in one of the latter binNMUs.
>
> How does a rebuild solve it? I have no idea currently: It Just Works™.
> I could have digged into
> the problem but the time to be spent would not be efficient when a
> simple rebuild solves it.
>
> I think those described above should make a stretch-pu for zssh reasonable.
>
> --
> Regards,
> Boyuan Yang

Hi Julien,

A gentle ping on this bug -- wondering if you (or the Release Team) is
going to accept
this solution or not. After all Debian 9.4 is coming and I'd like to
see this fix included
in the next point release.

--
Thanks,
Boyuan Yang

Bug#886326: stretch-pu: package zssh/1.5c.debian.1-3.2+deb9u1

[Boyuan Yang]

2018-02-10 19:08 GMT+08:00 Julien Cristau :
> Control: tag -1 moreinfo
>
> On Thu, Jan  4, 2018 at 21:51:12 +0800, Boyuan Yang wrote:
>
>> After adoption of package zssh, I'm looking to fix the RC bug #769366 in 
>> Debian Stretch.
>> A simple rebuild solved the problem, thus requesting a pre-approval from the 
>> release team.
>>
> What is the issue and how does a rebuild solve it?
>
> Thanks,
> Julien

The issue: zssh on Debian Stretch (at least on amd64 architecture)
will not start at all and the
symptom is the same as what happened in Debian Bug #769366.

As described in
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=769366#61 , Current
version
of zssh in Debian Stretch (on amd64 architecture, versioned
1.5c.debian.1-3.2+b4) suffers from
RC bug #769366. I had little idea why this happened because a
no-change rebuild on Debian
Stretch would make zssh fully functional. I tried gdb but the result
was not helpful.

The previous packager said he once solved this problem in a previous
upload so the problem
might have been introduced in one of the latter binNMUs.

How does a rebuild solve it? I have no idea currently: It Just Works™.
I could have digged into
the problem but the time to be spent would not be efficient when a
simple rebuild solves it.

I think those described above should make a stretch-pu for zssh reasonable.

--
Regards,
Boyuan Yang

Processed: Re: Bug#886326: stretch-pu: package zssh/1.5c.debian.1-3.2+deb9u1

[Debian Bug Tracking System]

Processing control commands:

> tag -1 moreinfo
Bug #886326 [release.debian.org] stretch-pu: package 
zssh/1.5c.debian.1-3.2+deb9u1
Added tag(s) moreinfo.

-- 
886326: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886326
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#886326: stretch-pu: package zssh/1.5c.debian.1-3.2+deb9u1

[Julien Cristau]

Control: tag -1 moreinfo

On Thu, Jan  4, 2018 at 21:51:12 +0800, Boyuan Yang wrote:

> After adoption of package zssh, I'm looking to fix the RC bug #769366 in 
> Debian Stretch.
> A simple rebuild solved the problem, thus requesting a pre-approval from the 
> release team.
> 
What is the issue and how does a rebuild solve it?

Thanks,
Julien

Bug#886326: stretch-pu: package zssh/1.5c.debian.1-3.2+deb9u1

[Boyuan Yang]

Previous mail seems to have put the source debdiff inside HTML part, resending 
source debdiff here:

diff -Nru zssh-1.5c.debian.1/debian/changelog zssh-1.5c.debian.1/debian/
changelog 
--- zssh-1.5c.debian.1/debian/changelog 2014-07-21 16:27:39.0 +0800 
+++ zssh-1.5c.debian.1/debian/changelog 2018-01-04 21:22:17.0 +0800 
@@ -1,3 +1,11 @@ 
+zssh (1.5c.debian.1-3.2+deb9u1) stretch; urgency=medium 
+ 
+  * Rebuild the package to make zssh work again. 
+(Closes: #769366) 
+  * d/control: Update maintainer information. 
+ 
+ -- Boyuan Yang <073p...@gmail.com>  Thu, 04 Jan 2018 21:22:17 +0800 
+ 
zssh (1.5c.debian.1-3.2) unstable; urgency=medium 
 
  * Non-maintainer upload. 
diff -Nru zssh-1.5c.debian.1/debian/control zssh-1.5c.debian.1/debian/control 
--- zssh-1.5c.debian.1/debian/control   2014-07-21 16:30:52.0 +0800 
+++ zssh-1.5c.debian.1/debian/control   2018-01-04 21:22:15.0 +0800 
@@ -1,7 +1,8 @@ 
Source: zssh 
Section: net 
Priority: optional 
-Maintainer: Ben Wong  
+Maintainer: Debian Deepin Packaging Team  
+Uploaders: Boyuan Yang <073p...@gmail.com> 
Build-Depends: cdbs, debhelper (>= 5), autotools-dev, libncurses5-dev, 
libreadline-dev, autoconf, quilt 
Standards-Version: 3.7.2

Regards,
Boyuan Yangdiff -Nru zssh-1.5c.debian.1/debian/changelog zssh-1.5c.debian.1/debian/changelog
--- zssh-1.5c.debian.1/debian/changelog	2014-07-21 16:27:39.0 +0800
+++ zssh-1.5c.debian.1/debian/changelog	2018-01-04 21:22:17.0 +0800
@@ -1,3 +1,11 @@
+zssh (1.5c.debian.1-3.2+deb9u1) stretch; urgency=medium
+
+  * Rebuild the package to make zssh work again.
+(Closes: #769366)
+  * d/control: Update maintainer information.
+
+ -- Boyuan Yang <073p...@gmail.com>  Thu, 04 Jan 2018 21:22:17 +0800
+
 zssh (1.5c.debian.1-3.2) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru zssh-1.5c.debian.1/debian/control zssh-1.5c.debian.1/debian/control
--- zssh-1.5c.debian.1/debian/control	2014-07-21 16:30:52.0 +0800
+++ zssh-1.5c.debian.1/debian/control	2018-01-04 21:22:15.0 +0800
@@ -1,7 +1,8 @@
 Source: zssh
 Section: net
 Priority: optional
-Maintainer: Ben Wong 
+Maintainer: Debian Deepin Packaging Team 
+Uploaders: Boyuan Yang <073p...@gmail.com>
 Build-Depends: cdbs, debhelper (>= 5), autotools-dev, libncurses5-dev, libreadline-dev, autoconf, quilt
 Standards-Version: 3.7.2
 


signature.asc
Description: This is a digitally signed message part.

Bug#886326: stretch-pu: package zssh/1.5c.debian.1-3.2+deb9u1

[Boyuan Yang]

Package: release.debian.org
Severity: normal
Tags: stretch
User: release.debian@packages.debian.org
Usertags: pu

After adoption of package zssh, I'm looking to fix the RC bug #769366 in Debian 
Stretch.
A simple rebuild solved the problem, thus requesting a pre-approval from the 
release team.

...or if the p-u mechanism is not the optimal solution, will it be possible
to do a direct binNMU for Stretch?

Anyway, for a stretch-pu, its source debdiff is posted here:

diff -Nru zssh-1.5c.debian.1/debian/changelog 
zssh-1.5c.debian.1/debian/changelog 

Regards,
Boyuan Yang




signature.asc
Description: This is a digitally signed message part.