[GitHub] activemq-artemis issue #2113: [ARTEMIS-1890] Any-word wildcard fix
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/2113 I see it's already merged. This is an enhancement not a bug. But, +1 on the change and it landing in 2.7.0 there's a clear use case for it. I think the important thing here is review the documentation, as both interpretations from @michaelandrepearce and @jostbg are reasonable. ---
Re: Regular and intermittent interrupt/resume between broker and client connector
Thanks Art. Some good feedback. The guaranteed delivery is important, so I'm going to need to implement an extension to support local storage of unsent messages so they can be redelivered when a resume has been detected. -- Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
[GitHub] activemq-artemis issue #2117: NO-JIRA update release instruction with git-re...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2117 @gemmellr you're a good person to review this :) ---
[GitHub] activemq-artemis pull request #2118: STOMP work
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2118 STOMP work Work for ARTEMIS-1896 and ARTEMIS-1897. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1896 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2118.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2118 commit 953c38a99d526e1cefe3c7c20689ab98467e4c6b Author: Justin Bertram Date: 2018-05-31T15:20:09Z ARTEMIS-1896 centralize authn failure logging Authentication failures are currently only logged for CORE clients. This change puts the logging in a central location which all protocols use for authentication so that authentication failures are logged for all protocols. commit 98288e91a91bf899679bbca885e62cc54c1f54d9 Author: Justin Bertram Date: 2018-06-01T13:42:22Z NO-JIRA allow enabling security at runtime commit c9b335e99eb505f41ee4e8345917476b259828bb Author: Justin Bertram Date: 2018-06-01T13:42:47Z ARTEMIS-1897 use core session for STOMP authn ---
[GitHub] activemq-artemis issue #2118: STOMP work
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2118 @jbertram is this suitable for 2.6.x ---
[GitHub] activemq-artemis issue #2118: STOMP work
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2118 Probably not. I'd leave it for 2.7.0. ---
[GitHub] activemq-artemis issue #2117: NO-JIRA update release instruction with git-re...
Github user gemmellr commented on the issue: https://github.com/apache/activemq-artemis/pull/2117 Looks good. Minor nit that I prefer numbered list entries don't all have "1." as the deliminator since it makes the raw file more awkward to read, but I also don't care so much as to request you change it back. ---
[GitHub] activemq-artemis pull request #2119: Artemis 1902
GitHub user mtaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/2119 Artemis 1902 You can merge this pull request into a Git repository by running: $ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-1902 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2119.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2119 commit e64986fcc0f05e6ed10816ca5e0718766e4dba46 Author: Martyn Taylor Date: 2018-06-01T15:33:18Z ARTEMIS-1902 Add AMQP redistributor stop test commit 711ec25c6daff8ed7649d36c44821893147ec155 Author: Martyn Taylor Date: 2018-06-01T16:04:50Z ARTEMIS-1902 Ensure ServerConsumer close done once Calling close multiple times on ServerConsumer can result in multiple notifications being routed around the cluster. This causes cluster topology info to become skewed. Which affects a number of components such as message redistribution, metrics and can eventually cause OOM should multiple queues be redistributing at the same time. ---
[GitHub] activemq-artemis pull request #2120: ARTEMIS-1892 allow whitespace in accept...
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2120 ARTEMIS-1892 allow whitespace in acceptor and connector URIs You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1892 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2120.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2120 commit b3f9f51b1d507b4dea2894aeef78fd515c0fcf4e Author: Justin Bertram Date: 2018-06-01T17:26:12Z ARTEMIS-1892 allow whitespace in acceptor and connector URIs ---
[GitHub] activemq-artemis issue #2119: Artemis 1902
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2119 @mtaylor I know I have in the past asked to separate test and fix.. but I went back on that.. as it's easier to cherry-pick.. and the gitreport would make a better correlation. You ok if we squash fix and test together on a single commit? ---
Re: [VOTE] Apache ActiveMQ Artemis 2.6.1
Actually.. -1 I will respin.. the main reason I pushed this release was for the AMQP & Clustering issue, and the security issue raised by Michael. It happens that there's still an issue with AMQP & Clustering, and Martyn fixed it here: https://github.com/apache/activemq-artemis/pull/2119 I see no point on having this release... so i will respin it on monday. Sorry about the hassle! On Thu, May 31, 2018 at 9:43 PM, Clebert Suconic wrote: > I would like to propose an Apache ActiveMQ Artemis 2.6.1 release. > > > This is a micro release, with bug fixes only. > > I would like to highlight two important fixes as part of this release: > > [ARTEMIS-1568] Expired Messages were not transversing clustering > redistribution. > (this could affect other queues beyond the Expiry as well) > > [ARTEMIS-1872]Check for queue exists before creating shared queue > > > The full JIRA report is here: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12343356 > > > The git commit report is here: > http://activemq.apache.org/artemis/commit-report-2.6.1.html > > (notice this report is not indexed on the website yet, I will add a > link and update the report if needed once the release is approved) > > > > Source and binary distributions can be found here: > https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis/2.6.1 > > > The Maven repository is here: > https://repository.apache.org/content/repositories/orgapacheactivemq-1161 > > > In case you want to give it a try with the maven repo on examples: > http://activemq.apache.org/artemis/docs/latest/hacking-guide/validating-releases.html > > The source tag: > https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;a=tag;h=refs/tags/2.6.1 > > > I will update the website after the vote has passed. > > > [ ] +1 approve the release as Apache Artemis 2.4.0 > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > Here's my +1 > > > > -- > Clebert Suconic -- Clebert Suconic
[CANCEL]: [VOTE] Apache ActiveMQ Artemis 2.6.1
Cancelling, For the reason I explained earlier. On Fri, Jun 1, 2018 at 1:31 PM, Clebert Suconic wrote: > Actually.. -1 > > > I will respin.. the main reason I pushed this release was for the AMQP > & Clustering issue, and the security issue raised by Michael. > It happens that there's still an issue with AMQP & Clustering, and > Martyn fixed it here: > > https://github.com/apache/activemq-artemis/pull/2119 > > > I see no point on having this release... so i will respin it on > monday. Sorry about the hassle! > > On Thu, May 31, 2018 at 9:43 PM, Clebert Suconic > wrote: >> I would like to propose an Apache ActiveMQ Artemis 2.6.1 release. >> >> >> This is a micro release, with bug fixes only. >> >> I would like to highlight two important fixes as part of this release: >> >> [ARTEMIS-1568] Expired Messages were not transversing clustering >> redistribution. >> (this could affect other queues beyond the Expiry as well) >> >> [ARTEMIS-1872]Check for queue exists before creating shared queue >> >> >> The full JIRA report is here: >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12343356 >> >> >> The git commit report is here: >> http://activemq.apache.org/artemis/commit-report-2.6.1.html >> >> (notice this report is not indexed on the website yet, I will add a >> link and update the report if needed once the release is approved) >> >> >> >> Source and binary distributions can be found here: >> https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis/2.6.1 >> >> >> The Maven repository is here: >> https://repository.apache.org/content/repositories/orgapacheactivemq-1161 >> >> >> In case you want to give it a try with the maven repo on examples: >> http://activemq.apache.org/artemis/docs/latest/hacking-guide/validating-releases.html >> >> The source tag: >> https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;a=tag;h=refs/tags/2.6.1 >> >> >> I will update the website after the vote has passed. >> >> >> [ ] +1 approve the release as Apache Artemis 2.4.0 >> [ ] +0 no opinion >> [ ] -1 disapprove (and reason why) >> >> Here's my +1 >> >> >> >> -- >> Clebert Suconic > > > > -- > Clebert Suconic -- Clebert Suconic
[GitHub] activemq-artemis pull request #2119: Artemis 1902
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2119#discussion_r192514909
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/QueueInfo.java
---
@@ -107,7 +108,11 @@ public void incrementConsumers() {
}
public void decrementConsumers() {
- numberOfConsumers--;
+ if (numberOfConsumers > 0) {
--- End diff --
This isnt being atomically updated so still possible two decrements at the
same time can cause the number to go negative incorrectly.
To avoid this ideally should syncronize any update to the field or make
changes to the field using an atomic updater
---
