Re: Make drain MAX_STATUS_WAIT configurable
+1 On Sep 5, 2017 1:07 PM, "Joshua Cohen" wrote: > echoing my +1 from Slack here. > > On Tue, Sep 5, 2017 at 2:05 PM, Erb, Stephan > wrote: > > > +1 > > > > On 05.09.17, 19:17, "David McLaughlin" wrote: > > > > +1 > > > > On Tue, Sep 5, 2017 at 10:09 AM, Mauricio Garavaglia < > > mauriciogaravag...@gmail.com> wrote: > > > > > Hi folks, > > > > > > The aurora-admin drain command currently has a hardcoded limit of 5 > > minutes > > > waiting for a node to be drained, after that timeout it fails. > > > > > > This doesn't work very well when tasks are expected be in killing > > state for > > > more than that, for example, if the scheduler > > transient_task_state_timeout > > > was > > > adjusted. > > > > > > Any objection on making this 5 minutes MAX_STATUS_WAIT in > > aurora-admin > > > drain configurable? > > > > > > https://github.com/apache/aurora/blob/master/src/main/ > > > python/apache/aurora/admin/host_maintenance.py#L40 > > > > > > Thanks, > > > > > > Mauricio > > > > > > > > > >
Re: Make drain MAX_STATUS_WAIT configurable
echoing my +1 from Slack here. On Tue, Sep 5, 2017 at 2:05 PM, Erb, Stephan wrote: > +1 > > On 05.09.17, 19:17, "David McLaughlin" wrote: > > +1 > > On Tue, Sep 5, 2017 at 10:09 AM, Mauricio Garavaglia < > mauriciogaravag...@gmail.com> wrote: > > > Hi folks, > > > > The aurora-admin drain command currently has a hardcoded limit of 5 > minutes > > waiting for a node to be drained, after that timeout it fails. > > > > This doesn't work very well when tasks are expected be in killing > state for > > more than that, for example, if the scheduler > transient_task_state_timeout > > was > > adjusted. > > > > Any objection on making this 5 minutes MAX_STATUS_WAIT in > aurora-admin > > drain configurable? > > > > https://github.com/apache/aurora/blob/master/src/main/ > > python/apache/aurora/admin/host_maintenance.py#L40 > > > > Thanks, > > > > Mauricio > > > > >
Re: Make drain MAX_STATUS_WAIT configurable
+1 On 05.09.17, 19:17, "David McLaughlin" wrote: +1 On Tue, Sep 5, 2017 at 10:09 AM, Mauricio Garavaglia < mauriciogaravag...@gmail.com> wrote: > Hi folks, > > The aurora-admin drain command currently has a hardcoded limit of 5 minutes > waiting for a node to be drained, after that timeout it fails. > > This doesn't work very well when tasks are expected be in killing state for > more than that, for example, if the scheduler transient_task_state_timeout > was > adjusted. > > Any objection on making this 5 minutes MAX_STATUS_WAIT in aurora-admin > drain configurable? > > https://github.com/apache/aurora/blob/master/src/main/ > python/apache/aurora/admin/host_maintenance.py#L40 > > Thanks, > > Mauricio >
Re: Make drain MAX_STATUS_WAIT configurable
+1 On Tue, Sep 5, 2017 at 10:09 AM, Mauricio Garavaglia < mauriciogaravag...@gmail.com> wrote: > Hi folks, > > The aurora-admin drain command currently has a hardcoded limit of 5 minutes > waiting for a node to be drained, after that timeout it fails. > > This doesn't work very well when tasks are expected be in killing state for > more than that, for example, if the scheduler transient_task_state_timeout > was > adjusted. > > Any objection on making this 5 minutes MAX_STATUS_WAIT in aurora-admin > drain configurable? > > https://github.com/apache/aurora/blob/master/src/main/ > python/apache/aurora/admin/host_maintenance.py#L40 > > Thanks, > > Mauricio >
Make drain MAX_STATUS_WAIT configurable
Hi folks, The aurora-admin drain command currently has a hardcoded limit of 5 minutes waiting for a node to be drained, after that timeout it fails. This doesn't work very well when tasks are expected be in killing state for more than that, for example, if the scheduler transient_task_state_timeout was adjusted. Any objection on making this 5 minutes MAX_STATUS_WAIT in aurora-admin drain configurable? https://github.com/apache/aurora/blob/master/src/main/python/apache/aurora/admin/host_maintenance.py#L40 Thanks, Mauricio