[jira] [Commented] (AVRO-1900) build.sh test fails for dev-tools.jar
[
https://issues.apache.org/jira/browse/AVRO-1900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487815#comment-15487815
]
ASF GitHub Bot commented on AVRO-1900:
--
Github user rdblue closed the pull request at:
https://github.com/apache/avro/pull/122
> build.sh test fails for dev-tools.jar
> -
>
> Key: AVRO-1900
> URL: https://issues.apache.org/jira/browse/AVRO-1900
> Project: Avro
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Suraj Acharya
>Assignee: Suraj Acharya
> Labels: build
> Attachments: AVRO-1900.patch
>
>
> When i ran {{./build.sh test}} in the docker container I was getting an error
> mentioning dev-tools.jar was not present.
> When I looked further into it I realized that {{build.sh}} never actually
> builds dev-tools.jar.
> I added a line in the test option to first {{mvn install}} on the dev-tools
> folder.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AVRO-1900) build.sh test fails for dev-tools.jar
[
https://issues.apache.org/jira/browse/AVRO-1900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487810#comment-15487810
]
ASF subversion and git services commented on AVRO-1900:
---
Commit 33d495840c896b693b7f37b5ec786ac1acacd3b4 in avro's branch
refs/heads/master from [~rdblue]
[ https://git-wip-us.apache.org/repos/asf?p=avro.git;h=33d4958 ]
AVRO-1900: Remove dev-tools to fix Java build.
The dev-tools module has to be built before working in lang/java. This
breaks the build.sh script and is a confusing failure for new Java
contributors. This commit fixes the problem by moving the checkstyle
config back into the lang/java/pom.xml. It is applied to all Java
modules under lang/java.
> build.sh test fails for dev-tools.jar
> -
>
> Key: AVRO-1900
> URL: https://issues.apache.org/jira/browse/AVRO-1900
> Project: Avro
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Suraj Acharya
>Assignee: Suraj Acharya
> Labels: build
> Attachments: AVRO-1900.patch
>
>
> When i ran {{./build.sh test}} in the docker container I was getting an error
> mentioning dev-tools.jar was not present.
> When I looked further into it I realized that {{build.sh}} never actually
> builds dev-tools.jar.
> I added a line in the test option to first {{mvn install}} on the dev-tools
> folder.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AVRO-1900) build.sh test fails for dev-tools.jar
[
https://issues.apache.org/jira/browse/AVRO-1900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15480653#comment-15480653
]
Ryan Blue commented on AVRO-1900:
-
I posted a fix that moves checkstyle into the lang/java build:
https://github.com/apache/avro/pull/122
> build.sh test fails for dev-tools.jar
> -
>
> Key: AVRO-1900
> URL: https://issues.apache.org/jira/browse/AVRO-1900
> Project: Avro
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Suraj Acharya
>Assignee: Suraj Acharya
> Labels: build
> Attachments: AVRO-1900.patch
>
>
> When i ran {{./build.sh test}} in the docker container I was getting an error
> mentioning dev-tools.jar was not present.
> When I looked further into it I realized that {{build.sh}} never actually
> builds dev-tools.jar.
> I added a line in the test option to first {{mvn install}} on the dev-tools
> folder.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AVRO-1900) build.sh test fails for dev-tools.jar
[
https://issues.apache.org/jira/browse/AVRO-1900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15480642#comment-15480642
]
Ryan Blue commented on AVRO-1900:
-
I think the right way to fix this is to get rid of dev-tools. I flagged this on
AVRO-1838, but didn't know that it would mess up the build script or wouldn't
have committed it at the time. That issue was primarily about improving our
checkstyle config anyway. Moving this back into lang/java/ will fix the problem
so we don't need to document it for new Java devs while fixing the build.
> build.sh test fails for dev-tools.jar
> -
>
> Key: AVRO-1900
> URL: https://issues.apache.org/jira/browse/AVRO-1900
> Project: Avro
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Suraj Acharya
>Assignee: Suraj Acharya
> Labels: build
> Attachments: AVRO-1900.patch
>
>
> When i ran {{./build.sh test}} in the docker container I was getting an error
> mentioning dev-tools.jar was not present.
> When I looked further into it I realized that {{build.sh}} never actually
> builds dev-tools.jar.
> I added a line in the test option to first {{mvn install}} on the dev-tools
> folder.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AVRO-1900) build.sh test fails for dev-tools.jar
[
https://issues.apache.org/jira/browse/AVRO-1900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434088#comment-15434088
]
Suraj Acharya commented on AVRO-1900:
-
[~busbey] I havent seen the need for it.
> build.sh test fails for dev-tools.jar
> -
>
> Key: AVRO-1900
> URL: https://issues.apache.org/jira/browse/AVRO-1900
> Project: Avro
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Suraj Acharya
>Assignee: Suraj Acharya
> Labels: build
> Attachments: AVRO-1900.patch
>
>
> When i ran {{./build.sh test}} in the docker container I was getting an error
> mentioning dev-tools.jar was not present.
> When I looked further into it I realized that {{build.sh}} never actually
> builds dev-tools.jar.
> I added a line in the test option to first {{mvn install}} on the dev-tools
> folder.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AVRO-1900) build.sh test fails for dev-tools.jar
[
https://issues.apache.org/jira/browse/AVRO-1900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15433348#comment-15433348
]
Sean Busbey commented on AVRO-1900:
---
I think we also need to change how {{./build.sh dist}} works, but I haven't
confirmed yet.
> build.sh test fails for dev-tools.jar
> -
>
> Key: AVRO-1900
> URL: https://issues.apache.org/jira/browse/AVRO-1900
> Project: Avro
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Suraj Acharya
>Assignee: Suraj Acharya
> Labels: build
> Attachments: AVRO-1900.patch
>
>
> When i ran {{./build.sh test}} in the docker container I was getting an error
> mentioning dev-tools.jar was not present.
> When I looked further into it I realized that {{build.sh}} never actually
> builds dev-tools.jar.
> I added a line in the test option to first {{mvn install}} on the dev-tools
> folder.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
