[GitHub] [cloudstack-primate] utchoang commented on issue #146: [WIP] Feature/vm wizard
utchoang commented on issue #146: [WIP] Feature/vm wizard URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-588020152 The requirements for this task are: * Keep the wizard in a pop-over * Add support for both basic and advanced, ideally we would prefer the similar kind of layout/steps like in the old UI's wizard I think the new UI already meets these demands: 1. The wizard is a popup ![image](https://user-images.githubusercontent.com/13766648/74799889-6f452b00-5304-11ea-87ff-1dc47020152b.png) 2. There's support info for both Basic and Advanced when it is selected. The layout is in form of steps. ![image](https://user-images.githubusercontent.com/13766648/74799911-7c621a00-5304-11ea-8388-1e36ce26cddc.png) Could you please explain what I should change? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #146: [WIP] Feature/vm wizard
utchoang commented on issue #146: [WIP] Feature/vm wizard URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-588012307 @rhtyd I completed fixes. Please review again This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #146: [WIP] Feature/vm wizard
utchoang commented on issue #146: [WIP] Feature/vm wizard URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-587321963 @rhtyd cc @svenvogel As from https://github.com/apache/cloudstack-primate/pull/7, the template/iso is filtered by osType, which causes incorrect pagination. To solve it, I intend to change the filter from osType to filter/show by featured/community/shared etc. Please let me know what you think. ![image](https://user-images.githubusercontent.com/13766648/74713926-1b7f0700-525c-11ea-92ed-44e5dcfa950a.png) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #146: [WIP] Feature/vm wizard
utchoang commented on issue #146: [WIP] Feature/vm wizard URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-586838027 @rhtyd Yes, I did merge the last master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #146: [WIP] Feature/vm wizard
utchoang commented on issue #146: [WIP] Feature/vm wizard URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-586836867 @rhtyd cc @svenvogel Yes. Please review it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #146: [WIP] Feature/vm wizard
utchoang commented on issue #146: [WIP] Feature/vm wizard URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-586797368 @rhtyd cc @svenvogel I have finished fixing the issues. Please review and give me your comment. ![image](https://user-images.githubusercontent.com/13766648/74620413-acc28080-516b-11ea-88ac-7c074ac69b86.png) ![image](https://user-images.githubusercontent.com/13766648/74620485-e2676980-516b-11ea-8373-7f70a6d0a8f8.png) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #146: [WIP] Feature/vm wizard
utchoang commented on issue #146: [WIP] Feature/vm wizard URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-585575380 Regarding to "Format Info card for vm config summary" with the image below, I still have no idea of what should be done. Could you please explain? ![1](https://user-images.githubusercontent.com/13766648/74408048-f22e3780-4e65-11ea-99a0-a6bafbacc77c.png) ![2](https://user-images.githubusercontent.com/13766648/74408050-f35f6480-4e65-11ea-98fb-160e832691a9.png) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #146: [WIP] Feature/vm wizard
utchoang commented on issue #146: [WIP] Feature/vm wizard URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-585026483 @rhtyd cc @svenvogel I have changed the following. Please let me know your comments. ![1](https://user-images.githubusercontent.com/13766648/74303589-00f4eb80-4d8d-11ea-935c-639164490de2.png) ![2](https://user-images.githubusercontent.com/13766648/74303594-02261880-4d8d-11ea-98c1-3412c039b689.png) ![3](https://user-images.githubusercontent.com/13766648/74303595-02beaf00-4d8d-11ea-8066-8706ee66b1a9.png) ![4](https://user-images.githubusercontent.com/13766648/74303597-03574580-4d8d-11ea-9a70-9033c1108f80.png) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #146: [WIP] Feature/vm wizard
utchoang commented on issue #146: [WIP] Feature/vm wizard URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-584551049 @rhtyd cc @svenvogel Add pod, cluster and host in step Basic Setup ![2020-02-11_16-48-25](https://user-images.githubusercontent.com/13766648/74225793-f899a380-4ced-11ea-8290-4be762c3ab09.png) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #146: [WIP] Feature/vm wizard
utchoang commented on issue #146: [WIP] Feature/vm wizard URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-584467673 @rhtyd cc @svenvogel This is my new design of the layout collapse mode to steps mode. Please review and let me know your comments. ![2020-02-11_10-25-28](https://user-images.githubusercontent.com/13766648/74209816-f28acf00-4cbb-11ea-9569-5fe1bf0f2443.png) ![2020-02-11_10-27-50](https://user-images.githubusercontent.com/13766648/74209817-f4549280-4cbb-11ea-87cd-3de158644c76.png) ![2020-02-11_10-28-38](https://user-images.githubusercontent.com/13766648/74209818-f4ed2900-4cbb-11ea-9866-c73440a42504.png) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #146: [WIP] Feature/vm wizard
utchoang commented on issue #146: [WIP] Feature/vm wizard URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-583989693 @rhtyd cc @svenvogel There is error 503 found in http://acs.shapeblue.com:8080/client/. Please check This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #146: [WIP] Feature/vm wizard
utchoang commented on issue #146: [WIP] Feature/vm wizard URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-582765698 @rhtyd I think I will add a Help button for creating new network while avoiding content switch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #146: [WIP] Feature/vm wizard
utchoang commented on issue #146: [WIP] Feature/vm wizard URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-582299819 @rhtyd thank you. I will add a Help button for creating new network while avoiding content switch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services