[jira] [Created] (RAT-184) Add DEPENDENCIES file to the default ignored list

2014-11-01 Thread Karl Heinz Marbaise (JIRA)
Karl Heinz Marbaise created RAT-184:
---

 Summary: Add DEPENDENCIES file to the default ignored list
 Key: RAT-184
 URL: https://issues.apache.org/jira/browse/RAT-184
 Project: Apache Rat
  Issue Type: Improvement
  Components: maven
Affects Versions: 0.11
Reporter: Karl Heinz Marbaise
Priority: Minor


Based on the usage of apache-rat-plugin it happens that after creating the 
release via the Maven Release Process a file {{DEPENDENCIES}} is added into the 
resulting {{sources.zip}}. Unfortunately the file is not on the default ignored 
list which results in a release which can't be built from the official release 
area.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (RAT-187) Add 'SAR', 'HAR', 'WSR' as archives which should be ignored.

2014-11-04 Thread Karl Heinz Marbaise (JIRA)
Karl Heinz Marbaise created RAT-187:
---

 Summary: Add 'SAR', 'HAR', 'WSR' as archives which should be 
ignored.
 Key: RAT-187
 URL: https://issues.apache.org/jira/browse/RAT-187
 Project: Apache Rat
  Issue Type: Improvement
  Components: antlib
Affects Versions: 0.12
Reporter: Karl Heinz Marbaise
Priority: Minor


It would good to ignore HAR (Hibernate Archive), SAR (Service Archive), WSR 
(Web Service Archive).




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (RAT-187) Add 'SAR', 'HAR', 'WSR' as archives which should be ignored.

2014-11-04 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise updated RAT-187:

Attachment: RAT-187.patch

Added patch for this issue.

 Add 'SAR', 'HAR', 'WSR' as archives which should be ignored.
 

 Key: RAT-187
 URL: https://issues.apache.org/jira/browse/RAT-187
 Project: Apache Rat
  Issue Type: Improvement
  Components: antlib
Affects Versions: 0.12
Reporter: Karl Heinz Marbaise
Priority: Minor
 Attachments: RAT-187.patch


 It would good to ignore HAR (Hibernate Archive), SAR (Service Archive), WSR 
 (Web Service Archive).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (RAT-192) Fixing typo in

2015-02-07 Thread Karl Heinz Marbaise (JIRA)
Karl Heinz Marbaise created RAT-192:
---

 Summary: Fixing typo in 
 Key: RAT-192
 URL: https://issues.apache.org/jira/browse/RAT-192
 Project: Apache Rat
  Issue Type: Improvement
Affects Versions: 0.12
Reporter: Karl Heinz Marbaise
Priority: Trivial
 Fix For: 0.12


Typo in javadoc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (RAT-191) Upgrade to apache parent version 16

2015-02-07 Thread Karl Heinz Marbaise (JIRA)
Karl Heinz Marbaise created RAT-191:
---

 Summary: Upgrade to apache parent version 16
 Key: RAT-191
 URL: https://issues.apache.org/jira/browse/RAT-191
 Project: Apache Rat
  Issue Type: Improvement
Affects Versions: 0.12
Reporter: Karl Heinz Marbaise
Priority: Minor
 Fix For: 0.12


Currently the whole RAT projects is based on org.apache:apache:14 which can be 
updated to verson 16.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (RAT-191) Upgrade to apache parent version 16

2015-02-07 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise updated RAT-191:

Attachment: RAT-191.patch

Added the appropriate patch file.
Based on r1658053
Checked with Maven 3.0.5, 3.1.1, 3.2.5 without any issue.

 Upgrade to apache parent version 16
 ---

 Key: RAT-191
 URL: https://issues.apache.org/jira/browse/RAT-191
 Project: Apache Rat
  Issue Type: Improvement
Affects Versions: 0.12
Reporter: Karl Heinz Marbaise
Priority: Minor
 Fix For: 0.12

 Attachments: RAT-191.patch


 Currently the whole RAT projects is based on org.apache:apache:14 which can 
 be updated to verson 16.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (RAT-192) Fixing typo in

2015-02-07 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise updated RAT-192:

Attachment: RAT-192.patch

Attached patch for typo.

 Fixing typo in 
 ---

 Key: RAT-192
 URL: https://issues.apache.org/jira/browse/RAT-192
 Project: Apache Rat
  Issue Type: Improvement
Affects Versions: 0.12
Reporter: Karl Heinz Marbaise
Priority: Trivial
 Fix For: 0.12

 Attachments: RAT-192.patch


 Typo in javadoc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (RAT-193) Take advantage of inheritance from ASF parent version 16

2015-02-07 Thread Karl Heinz Marbaise (JIRA)
Karl Heinz Marbaise created RAT-193:
---

 Summary: Take advantage of inheritance from ASF parent version 16
 Key: RAT-193
 URL: https://issues.apache.org/jira/browse/RAT-193
 Project: Apache Rat
  Issue Type: Improvement
Affects Versions: 0.12
Reporter: Karl Heinz Marbaise
Priority: Minor
 Fix For: 0.12


Take into account the properties which are inherited from parent. Use the 
defaults of the plugins instead of explicitly defining them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (RAT-192) Fixing typo in javadoc

2015-02-07 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise updated RAT-192:

Summary: Fixing typo in javadoc  (was: Fixing typo in )

 Fixing typo in javadoc
 --

 Key: RAT-192
 URL: https://issues.apache.org/jira/browse/RAT-192
 Project: Apache Rat
  Issue Type: Improvement
Affects Versions: 0.12
Reporter: Karl Heinz Marbaise
Priority: Trivial
 Fix For: 0.12

 Attachments: RAT-192.patch


 Typo in javadoc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (RAT-193) Take advantage of inheritance from ASF parent version 16

2015-02-07 Thread Karl Heinz Marbaise (JIRA)

[ 
https://issues.apache.org/jira/browse/RAT-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310761#comment-14310761
 ] 

Karl Heinz Marbaise commented on RAT-193:
-

If plugins are updated nothing happens cause the plugins are defined via 
pluginManagement in the parent. But keep it as you prefer.

 Take advantage of inheritance from ASF parent version 16
 

 Key: RAT-193
 URL: https://issues.apache.org/jira/browse/RAT-193
 Project: Apache Rat
  Issue Type: Improvement
Affects Versions: 0.12
Reporter: Karl Heinz Marbaise
Priority: Minor
 Fix For: 0.12

 Attachments: RAT-193.patch


 Take into account the properties which are inherited from parent. Use the 
 defaults of the plugins instead of explicitly defining them. Use the plugin 
 versions which are defined in the parent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (RAT-196) Let the parent do it's work and define only things which are really needed.

2015-03-12 Thread Karl Heinz Marbaise (JIRA)

[ 
https://issues.apache.org/jira/browse/RAT-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14359295#comment-14359295
 ] 

Karl Heinz Marbaise edited comment on RAT-196 at 3/12/15 8:09 PM:
--

Attached patch to improve the pom files. Created against current trunk.


was (Author: khmarbaise):
Attached patch to improve the pom files. Created against 
[r1666284|http://svn.apache.org/r1666284]

 Let the parent do it's work and define only things which are really needed.
 ---

 Key: RAT-196
 URL: https://issues.apache.org/jira/browse/RAT-196
 Project: Apache Rat
  Issue Type: Improvement
  Components: maven
Affects Versions: 0.12
Reporter: Karl Heinz Marbaise
Priority: Critical
 Fix For: 0.12

 Attachments: RAT-196.patch


 Currently there are defined many things which are already defined by 
 inheritance through the header this makes the pom files larger than they need 
 to be.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (RAT-196) Let the parent do it's work and define only things which are really needed.

2015-03-12 Thread Karl Heinz Marbaise (JIRA)

[ 
https://issues.apache.org/jira/browse/RAT-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14359295#comment-14359295
 ] 

Karl Heinz Marbaise edited comment on RAT-196 at 3/12/15 8:08 PM:
--

Attached patch to improve the pom files. Created against 
[r1666284|http://svn.apache.org/r1666284]


was (Author: khmarbaise):
Attached patch to improve the pom files.

 Let the parent do it's work and define only things which are really needed.
 ---

 Key: RAT-196
 URL: https://issues.apache.org/jira/browse/RAT-196
 Project: Apache Rat
  Issue Type: Improvement
  Components: maven
Affects Versions: 0.12
Reporter: Karl Heinz Marbaise
Priority: Critical
 Fix For: 0.12

 Attachments: RAT-196.patch


 Currently there are defined many things which are already defined by 
 inheritance through the header this makes the pom files larger than they need 
 to be.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (RAT-196) Let the parent do it's work and define only things which are really needed.

2015-03-12 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise updated RAT-196:

Attachment: RAT-196.patch

Attached patch to improve the pom files.

 Let the parent do it's work and define only things which are really needed.
 ---

 Key: RAT-196
 URL: https://issues.apache.org/jira/browse/RAT-196
 Project: Apache Rat
  Issue Type: Improvement
  Components: maven
Affects Versions: 0.12
Reporter: Karl Heinz Marbaise
Priority: Critical
 Fix For: 0.12

 Attachments: RAT-196.patch


 Currently there are defined many things which are already defined by 
 inheritance through the header this makes the pom files larger than they need 
 to be.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (RAT-196) Let the parent do it's work and define only things which are really needed.

2015-03-12 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise updated RAT-196:

Description: Currently there are defined many things which are already 
defined by inheritance through the parent this makes the pom files larger than 
they need to be.  (was: Currently there are defined many things which are 
already defined by inheritance through the header this makes the pom files 
larger than they need to be.)

 Let the parent do it's work and define only things which are really needed.
 ---

 Key: RAT-196
 URL: https://issues.apache.org/jira/browse/RAT-196
 Project: Apache Rat
  Issue Type: Improvement
  Components: maven
Affects Versions: 0.12
Reporter: Karl Heinz Marbaise
Priority: Critical
 Fix For: 0.12

 Attachments: RAT-196.patch


 Currently there are defined many things which are already defined by 
 inheritance through the parent this makes the pom files larger than they need 
 to be.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (RAT-197) Exclude the new .mvn/ folder from rat checked

2015-03-25 Thread Karl Heinz Marbaise (JIRA)
Karl Heinz Marbaise created RAT-197:
---

 Summary: Exclude the new .mvn/ folder from rat checked
 Key: RAT-197
 URL: https://issues.apache.org/jira/browse/RAT-197
 Project: Apache Rat
  Issue Type: Improvement
Reporter: Karl Heinz Marbaise
 Fix For: 0.12


Starting with Maven 3.3.1 a new folder .mvn has been introduced which contains 
extensions.xml, jvm.config and maven.config. The jvm.config and maven.config do 
not support any kind of comment.
So best would be to exclude those folder completely from rat checks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (RAT-197) Exclude the new .mvn/ folder from rat checked

2015-03-25 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise updated RAT-197:

Attachment: RAT-197.patch

 Exclude the new .mvn/ folder from rat checked
 -

 Key: RAT-197
 URL: https://issues.apache.org/jira/browse/RAT-197
 Project: Apache Rat
  Issue Type: Improvement
Reporter: Karl Heinz Marbaise
 Fix For: 0.12

 Attachments: RAT-197.patch


 Starting with Maven 3.3.1 a new folder .mvn has been introduced which 
 contains extensions.xml, jvm.config and maven.config. The jvm.config and 
 maven.config do not support any kind of comment.
 So best would be to exclude those folder completely from rat checks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (RAT-198) Upgrade plexus-utils to 3.0.20

2015-03-25 Thread Karl Heinz Marbaise (JIRA)
Karl Heinz Marbaise created RAT-198:
---

 Summary: Upgrade plexus-utils to 3.0.20
 Key: RAT-198
 URL: https://issues.apache.org/jira/browse/RAT-198
 Project: Apache Rat
  Issue Type: Improvement
  Components: maven
Affects Versions: 0.12
Reporter: Karl Heinz Marbaise
Priority: Minor
 Fix For: 0.12






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (RAT-198) Upgrade plexus-utils to 3.0.20

2015-03-26 Thread Karl Heinz Marbaise (JIRA)

[ 
https://issues.apache.org/jira/browse/RAT-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14381762#comment-14381762
 ] 

Karl Heinz Marbaise commented on RAT-198:
-

Absolutely no relationship.

 Upgrade plexus-utils to 3.0.20
 --

 Key: RAT-198
 URL: https://issues.apache.org/jira/browse/RAT-198
 Project: Apache Rat
  Issue Type: Improvement
  Components: maven
Affects Versions: 0.12
Reporter: Karl Heinz Marbaise
Priority: Minor
 Fix For: 0.12

 Attachments: RAT-198.patch






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (RAT-197) Exclude the new .mvn/ folder from rat checked

2015-03-26 Thread Karl Heinz Marbaise (JIRA)

[ 
https://issues.apache.org/jira/browse/RAT-197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14381763#comment-14381763
 ] 

Karl Heinz Marbaise commented on RAT-197:
-

The plexus component has no relationship to this, cause .mvn folder is 
identified by the mvn/mvn.cmd script and must be cause the jvm parameters 
couldn't be set there.

 Exclude the new .mvn/ folder from rat checked
 -

 Key: RAT-197
 URL: https://issues.apache.org/jira/browse/RAT-197
 Project: Apache Rat
  Issue Type: Improvement
Reporter: Karl Heinz Marbaise
 Fix For: 0.12

 Attachments: RAT-197.patch


 Starting with Maven 3.3.1 a new folder .mvn has been introduced which 
 contains extensions.xml, jvm.config and maven.config. The jvm.config and 
 maven.config do not support any kind of comment.
 So best would be to exclude those folder completely from rat checks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (RAT-199) Support for m2e in Eclipse

2015-03-27 Thread Karl Heinz Marbaise (JIRA)

[ 
https://issues.apache.org/jira/browse/RAT-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14384510#comment-14384510
 ] 

Karl Heinz Marbaise commented on RAT-199:
-

No no...The mapping file can be put into 
{{src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml}} and will be 
packaged with  plugin and use the plexus build api:

{code}
dependency
groupIdorg.sonatype.plexus/groupId
artifactIdplexus-build-api/artifactId
version0.0.7/version
/dependency
{code}
And of course it's needed to do some things within the code...add supplemental 
steps to trigger Eclipse...

 Support for m2e in Eclipse
 --

 Key: RAT-199
 URL: https://issues.apache.org/jira/browse/RAT-199
 Project: Apache Rat
  Issue Type: Improvement
  Components: maven
Affects Versions: 0.12
Reporter: Karl Heinz Marbaise
Priority: Minor

 I would like to see support for m2e in Eclipse.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (RAT-199) Support for m2e in Eclipse

2015-03-27 Thread Karl Heinz Marbaise (JIRA)

[ 
https://issues.apache.org/jira/browse/RAT-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14384477#comment-14384477
 ] 

Karl Heinz Marbaise commented on RAT-199:
-

May be i wasn't clear enough...I would like create support in Eclipse to 
prevent messages about not being covered by life cycle and some handling of 
this within the maven-rat-plugin..the simplest step of this is to provide a 
life cycle mapper for Eclipse:
{code}
?xml version=1.0 encoding=UTF-8?
lifecycleMappingMetadata
  pluginExecutions
pluginExecution
  pluginExecutionFilter
goals
  goalcheck/goal
/goals
  /pluginExecutionFilter
  action
execute
  runOnIncrementaltrue/runOnIncremental
  runOnConfigurationtrue/runOnConfiguration
/execute
  /action
/pluginExecution
  /pluginExecutions
/lifecycleMappingMetadata
{code}
But i know that's not enough...


 Support for m2e in Eclipse
 --

 Key: RAT-199
 URL: https://issues.apache.org/jira/browse/RAT-199
 Project: Apache Rat
  Issue Type: Improvement
  Components: maven
Affects Versions: 0.12
Reporter: Karl Heinz Marbaise
Priority: Minor

 I would like to see support for m2e in Eclipse.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (RAT-199) Support for m2e in Eclipse

2015-03-27 Thread Karl Heinz Marbaise (JIRA)
Karl Heinz Marbaise created RAT-199:
---

 Summary: Support for m2e in Eclipse
 Key: RAT-199
 URL: https://issues.apache.org/jira/browse/RAT-199
 Project: Apache Rat
  Issue Type: Improvement
  Components: maven
Affects Versions: 0.12
Reporter: Karl Heinz Marbaise
Priority: Minor


I would like to see support for m2e in Eclipse.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (RAT-217) maven-compiler-plugin configuration can be simplified

2016-08-30 Thread Karl Heinz Marbaise (JIRA)
Karl Heinz Marbaise created RAT-217:
---

 Summary: maven-compiler-plugin configuration can be simplified
 Key: RAT-217
 URL: https://issues.apache.org/jira/browse/RAT-217
 Project: Apache Rat
  Issue Type: Improvement
Affects Versions: 0.13
Reporter: Karl Heinz Marbaise
Priority: Trivial
 Fix For: 0.13


The source/target is already defined by using {{maven.compiler.source}}, 
{{maven.compiler.target}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (RAT-217) maven-compiler-plugin configuration can be simplified

2016-08-30 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed RAT-217.
---
Resolution: Fixed

Done in [r1758478|https://svn.apache.org/r1758478]

> maven-compiler-plugin configuration can be simplified
> -
>
> Key: RAT-217
> URL: https://issues.apache.org/jira/browse/RAT-217
> Project: Apache Rat
>  Issue Type: Improvement
>Affects Versions: 0.13
>Reporter: Karl Heinz Marbaise
>Priority: Trivial
> Fix For: 0.13
>
>
> The source/target is already defined by using {{maven.compiler.source}}, 
> {{maven.compiler.target}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (RAT-217) maven-compiler-plugin configuration can be simplified

2016-08-30 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise reopened RAT-217:
-
  Assignee: Karl Heinz Marbaise

> maven-compiler-plugin configuration can be simplified
> -
>
> Key: RAT-217
> URL: https://issues.apache.org/jira/browse/RAT-217
> Project: Apache Rat
>  Issue Type: Improvement
>Affects Versions: 0.13
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Trivial
> Fix For: 0.13
>
>
> The source/target is already defined by using {{maven.compiler.source}}, 
> {{maven.compiler.target}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (RAT-217) maven-compiler-plugin configuration can be simplified

2016-08-30 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed RAT-217.
---
Resolution: Fixed

> maven-compiler-plugin configuration can be simplified
> -
>
> Key: RAT-217
> URL: https://issues.apache.org/jira/browse/RAT-217
> Project: Apache Rat
>  Issue Type: Improvement
>Affects Versions: 0.13
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Trivial
> Fix For: 0.13
>
>
> The source/target is already defined by using {{maven.compiler.source}}, 
> {{maven.compiler.target}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (RAT-218) Fixing wrong License Header

2016-08-30 Thread Karl Heinz Marbaise (JIRA)
Karl Heinz Marbaise created RAT-218:
---

 Summary: Fixing wrong License Header
 Key: RAT-218
 URL: https://issues.apache.org/jira/browse/RAT-218
 Project: Apache Rat
  Issue Type: Improvement
  Components: maven
Affects Versions: 0.13
Reporter: Karl Heinz Marbaise
Assignee: Karl Heinz Marbaise
Priority: Minor
 Fix For: 0.13


The license header in 
{{apache-rat-plugin/src/main/java/org/apache/rat/mp/AbstractRatMojo.java}} is 
wrong.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (RAT-220) JDK version 1.6

2016-09-10 Thread Karl Heinz Marbaise (JIRA)
Karl Heinz Marbaise created RAT-220:
---

 Summary: JDK version 1.6
 Key: RAT-220
 URL: https://issues.apache.org/jira/browse/RAT-220
 Project: Apache Rat
  Issue Type: Improvement
Reporter: Karl Heinz Marbaise


Currently the RAT project defines as Java compatibility 1.5 but Tentacles 
defines 1.6 and Whiskers as well 1.6 so it would be a good idea to go to 1.6 as 
minimumIf someone needs to work with 1.5 toolchain can be used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (RAT-219) RAT project uses groupId: org.apache.rat instead of org.apache.creadur.rat

2016-09-09 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise updated RAT-219:

Affects Version/s: 0.13

> RAT project uses groupId: org.apache.rat instead of org.apache.creadur.rat
> --
>
> Key: RAT-219
> URL: https://issues.apache.org/jira/browse/RAT-219
> Project: Apache Rat
>  Issue Type: Improvement
>Affects Versions: 0.13
>Reporter: Karl Heinz Marbaise
>Priority: Critical
>
> This should be done before 1.0.0 to make it consistent with the other 
> projects (Whiskers/Tentacles).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (RAT-219) RAT project uses groupId: org.apache.rat instead of org.apache.creadur.rat

2016-09-09 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise updated RAT-219:

Fix Version/s: 0.13

> RAT project uses groupId: org.apache.rat instead of org.apache.creadur.rat
> --
>
> Key: RAT-219
> URL: https://issues.apache.org/jira/browse/RAT-219
> Project: Apache Rat
>  Issue Type: Improvement
>Affects Versions: 0.12
>Reporter: Karl Heinz Marbaise
>Priority: Critical
> Fix For: 0.13
>
>
> This should be done before 1.0.0 to make it consistent with the other 
> projects (Whiskers/Tentacles).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (RAT-219) RAT project uses groupId: org.apache.rat instead of org.apache.creadur.rat

2016-09-09 Thread Karl Heinz Marbaise (JIRA)
Karl Heinz Marbaise created RAT-219:
---

 Summary: RAT project uses groupId: org.apache.rat instead of 
org.apache.creadur.rat
 Key: RAT-219
 URL: https://issues.apache.org/jira/browse/RAT-219
 Project: Apache Rat
  Issue Type: Improvement
Reporter: Karl Heinz Marbaise
Priority: Minor


This should be done before 1.0.0 to make it consistent with the other projects 
(Whiskers/Tentacles).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (RAT-219) RAT project uses groupId: org.apache.rat instead of org.apache.creadur.rat

2016-09-10 Thread Karl Heinz Marbaise (JIRA)

[ 
https://issues.apache.org/jira/browse/RAT-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15480223#comment-15480223
 ] 

Karl Heinz Marbaise commented on RAT-219:
-

Yes that's what I had in mind...cause it is something which is usable for all 
Whiskers, RAT and Tentacles...

> RAT project uses groupId: org.apache.rat instead of org.apache.creadur.rat
> --
>
> Key: RAT-219
> URL: https://issues.apache.org/jira/browse/RAT-219
> Project: Apache Rat
>  Issue Type: Improvement
>Affects Versions: 0.12
>Reporter: Karl Heinz Marbaise
>Priority: Critical
> Fix For: 0.13
>
>
> This should be done before 1.0.0 to make it consistent with the other 
> projects (Whiskers/Tentacles).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (RAT-220) JDK version 1.6

2016-09-11 Thread Karl Heinz Marbaise (JIRA)

[ 
https://issues.apache.org/jira/browse/RAT-220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15481517#comment-15481517
 ] 

Karl Heinz Marbaise commented on RAT-220:
-

It's just a clear consistent line. May be it bothers at moment no one..

> JDK version 1.6
> ---
>
> Key: RAT-220
> URL: https://issues.apache.org/jira/browse/RAT-220
> Project: Apache Rat
>  Issue Type: Improvement
>Reporter: Karl Heinz Marbaise
>Assignee: Jochen Wiedmann
>
> Currently the RAT project defines as Java compatibility 1.5 but Tentacles 
> defines 1.6 and Whiskers as well 1.6 so it would be a good idea to go to 1.6 
> as minimumIf someone needs to work with 1.5 toolchain can be used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (RAT-220) JDK version 1.6

2016-09-11 Thread Karl Heinz Marbaise (JIRA)

[ 
https://issues.apache.org/jira/browse/RAT-220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15481409#comment-15481409
 ] 

Karl Heinz Marbaise commented on RAT-220:
-

My point was to be consistent over the projects RAT, Tentacles, Whiskers...but 
if we go to 1.7 for all of them I'm fine with it.

> JDK version 1.6
> ---
>
> Key: RAT-220
> URL: https://issues.apache.org/jira/browse/RAT-220
> Project: Apache Rat
>  Issue Type: Improvement
>Reporter: Karl Heinz Marbaise
>Assignee: Jochen Wiedmann
>
> Currently the RAT project defines as Java compatibility 1.5 but Tentacles 
> defines 1.6 and Whiskers as well 1.6 so it would be a good idea to go to 1.6 
> as minimumIf someone needs to work with 1.5 toolchain can be used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (RAT-220) JDK version 1.6

2016-09-11 Thread Karl Heinz Marbaise (JIRA)

[ 
https://issues.apache.org/jira/browse/RAT-220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15481395#comment-15481395
 ] 

Karl Heinz Marbaise commented on RAT-220:
-

Where is written that Maven is at 1.8 ? Maven 3.3+ is Java 1.7 see here: 
http://maven.apache.org/docs/history.html

> JDK version 1.6
> ---
>
> Key: RAT-220
> URL: https://issues.apache.org/jira/browse/RAT-220
> Project: Apache Rat
>  Issue Type: Improvement
>Reporter: Karl Heinz Marbaise
>Assignee: Jochen Wiedmann
>
> Currently the RAT project defines as Java compatibility 1.5 but Tentacles 
> defines 1.6 and Whiskers as well 1.6 so it would be a good idea to go to 1.6 
> as minimumIf someone needs to work with 1.5 toolchain can be used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (RAT-225) Maven RAT excludes do not work under windows

2016-12-18 Thread Karl Heinz Marbaise (JIRA)

[ 
https://issues.apache.org/jira/browse/RAT-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15758921#comment-15758921
 ] 

Karl Heinz Marbaise edited comment on RAT-225 at 12/18/16 2:38 PM:
---

First I can say there is no relationship to Windows. It will fail also on Mac 
and Linux (not tested).

The problem is simply if you call the goal directly via: {{mvn 
apache-rat:check}} without the life cycle the execution with the id 
{{default-cli}} will be used to configure the appropriate plugin. In this case 
the plugin is configured in the reporting area which means only for running 
{{mvn site}} but not for running out of the life cycle. 

This problem can be simply solved by moving the configuration in a 
{{pluginManagement}} area which will result in a working execution.
I have attached a patch to this issue which solves the configuration issue in 
commons...




was (Author: khmarbaise):
First I can say there is no relationship to Windows. It will fail also on Mac 
and Linux (not tested).

The problem is simply if you call the goal directly via: `mvn apache-rat:check` 
without the life cycle the execution with the id `default-cli` will be used to 
configure the appropriate plugin. In this case the plugin is configured in the 
reporting area which means only for running `mvn site` but not for running out 
of the life cycle. 

This problem can be simply solved by moving the configuration in a 
`pluginManagement` area which will result in a working execution.
I have attached a patch to this issue which solves the configuration issue in 
commons...



> Maven RAT excludes do not work under windows
> 
>
> Key: RAT-225
> URL: https://issues.apache.org/jira/browse/RAT-225
> Project: Apache Rat
>  Issue Type: Bug
>  Components: maven
>Affects Versions: 0.12
> Environment: windows 10
>Reporter: Pascal Schumacher
> Attachments: apache-rat.patch
>
>
> {code}mvn apache-rat:check{code} fails for projects like commons-lang and 
> commons-compress.
> Commons lang uses this plugin configuration:
> {code}
> org.apache.rat
> apache-rat-plugin
> 
>   
> site-content/**
> src/site/resources/.htaccess
> src/site/resources/download_lang.cgi
> 
> src/site/resources/release-notes/RELEASE-NOTES-*.txt
> src/test/resources/lang-708-input.txt
>   
> 
> {code}
> see https://github.com/apache/commons-lang/blob/master/pom.xml#L733
> {code}mvn apache-rat:check{code} fails and rat.txt contains:
> {code}!? src/site/resources/.htaccess
> !? src/site/resources/release-notes/RELEASE-NOTES-1.0.1.txt{code}
> I guess this is because I'm using Windows.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (RAT-225) Maven RAT excludes do not work under windows

2016-12-18 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise updated RAT-225:

Attachment: apache-rat.patch

> Maven RAT excludes do not work under windows
> 
>
> Key: RAT-225
> URL: https://issues.apache.org/jira/browse/RAT-225
> Project: Apache Rat
>  Issue Type: Bug
>  Components: maven
>Affects Versions: 0.12
> Environment: windows 10
>Reporter: Pascal Schumacher
> Attachments: apache-rat.patch
>
>
> {code}mvn apache-rat:check{code} fails for projects like commons-lang and 
> commons-compress.
> Commons lang uses this plugin configuration:
> {code}
> org.apache.rat
> apache-rat-plugin
> 
>   
> site-content/**
> src/site/resources/.htaccess
> src/site/resources/download_lang.cgi
> 
> src/site/resources/release-notes/RELEASE-NOTES-*.txt
> src/test/resources/lang-708-input.txt
>   
> 
> {code}
> see https://github.com/apache/commons-lang/blob/master/pom.xml#L733
> {code}mvn apache-rat:check{code} fails and rat.txt contains:
> {code}!? src/site/resources/.htaccess
> !? src/site/resources/release-notes/RELEASE-NOTES-1.0.1.txt{code}
> I guess this is because I'm using Windows.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (RAT-225) Maven RAT excludes do not work under windows

2016-12-18 Thread Karl Heinz Marbaise (JIRA)

[ 
https://issues.apache.org/jira/browse/RAT-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15758941#comment-15758941
 ] 

Karl Heinz Marbaise commented on RAT-225:
-

No problem. I can try to move the issue to the commons-lang project ?

> Maven RAT excludes do not work under windows
> 
>
> Key: RAT-225
> URL: https://issues.apache.org/jira/browse/RAT-225
> Project: Apache Rat
>  Issue Type: Bug
>  Components: maven
>Affects Versions: 0.12
> Environment: windows 10
>Reporter: Pascal Schumacher
> Attachments: apache-rat.patch
>
>
> {code}mvn apache-rat:check{code} fails for projects like commons-lang and 
> commons-compress.
> Commons lang uses this plugin configuration:
> {code}
> org.apache.rat
> apache-rat-plugin
> 
>   
> site-content/**
> src/site/resources/.htaccess
> src/site/resources/download_lang.cgi
> 
> src/site/resources/release-notes/RELEASE-NOTES-*.txt
> src/test/resources/lang-708-input.txt
>   
> 
> {code}
> see https://github.com/apache/commons-lang/blob/master/pom.xml#L733
> {code}mvn apache-rat:check{code} fails and rat.txt contains:
> {code}!? src/site/resources/.htaccess
> !? src/site/resources/release-notes/RELEASE-NOTES-1.0.1.txt{code}
> I guess this is because I'm using Windows.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (RAT-232) Removed prerequisites from pom use maven-enforcer instead

2017-03-17 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise updated RAT-232:

Summary: Removed prerequisites from pom use maven-enforcer instead  (was: 
Removed prerequisites from pom use maven-enforcer instead for non maven-plugin 
projects.)

> Removed prerequisites from pom use maven-enforcer instead
> -
>
> Key: RAT-232
> URL: https://issues.apache.org/jira/browse/RAT-232
> Project: Apache Rat
>  Issue Type: Improvement
>Affects Versions: 0.13
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 0.13
>
>
> Based on a change in [Maven 
> 3.5.0-alpha-1|https://issues.apache.org/jira/browse/MNG-6092] all non 
> maven-plugin projects which are using 
> {code:xml}
> 
> ..
> 
> {code}
> will produce a WARNING during a build. Better to force using a particular 
> maven version using maven-enforcer-plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (RAT-228) Test failures in antunit does not break the maven build / ANT does not seem to recognize additional licenses

2017-03-17 Thread Karl Heinz Marbaise (JIRA)

[ 
https://issues.apache.org/jira/browse/RAT-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930638#comment-15930638
 ] 

Karl Heinz Marbaise commented on RAT-228:
-

The culprit lines are the following {{report-normal-operation.xml}}:
{code:xml}
  

  
  
  


  

  
{code}
In particular the following:
{{failonerror="false" errorproperty="antunit.failed"}} which make ant to ignore 
the test failures...


> Test failures in antunit does not break the maven build / ANT does not seem 
> to recognize additional licenses
> 
>
> Key: RAT-228
> URL: https://issues.apache.org/jira/browse/RAT-228
> Project: Apache Rat
>  Issue Type: Bug
>  Components: antlib
>Affects Versions: 0.12
>Reporter: Philipp Ottlinger
> Fix For: 0.13
>
>
> When I was working on RAT-226 I realized that there's a test failure within 
> the apache-rat-tasks submodule:
> {code}
> cd apache-rat-tasks
> mvn clean test
> [INFO] --- maven-antrun-plugin:1.7:run (default) @ apache-rat-tasks ---
> [INFO] Executing tasks
> main:
> allTests:
> [au:antunit] Build File: 
> /home/user/ws/rat-trunk/apache-rat-tasks/src/test/resources/antunit/report-bad-configurations.xml
> [au:antunit] Tests run: 10, Failures: 0, Errors: 0, Time elapsed: 0,291 sec
> [au:antunit] Target: testNoStylesheet took 0,003 sec
> [au:antunit] Target: testNoResources took 0,001 sec
> [au:antunit] Target: testSubstringMatcherRequiresFamilyName took 0,087 sec
> [au:antunit] Target: testFullTextMatcherRequiresFamilyName took 0,024 sec
> [au:antunit] Target: testUnusedStylesheet took 0,042 sec
> [au:antunit] Target: testFullTextMatcherRequiresText took 0,019 sec
> [au:antunit] Target: testSubstringMatcherRequiresFamilyCategory took 0,023 sec
> [au:antunit] Target: testSubstringMatcherRequiresPattern took 0,026 sec
> [au:antunit] Target: testNoLicenseMatchers took 0,001 sec
> [au:antunit] Target: testFullTextMatcherRequiresFamilyCategory took 0,016 sec
> [mkdir] Created dir: 
> /home/user/ws/rat-trunk/apache-rat-tasks/target/testoutput/dest
> allTests:
> [au:antunit] Build File: 
> /home/user/ws/rat-trunk/apache-rat-tasks/src/test/resources/antunit/report-normal-operation.xml
> [au:antunit] Tests run: 11, Failures: 0, Errors: 6, Time elapsed: 1,293 sec
> [au:antunit] Target: testFullTextMatcherNotApprovedSentToFile  caused an ERROR
> [au:antunit]  at line 209, column 55
> [au:antunit]  Message: The following error occurred while executing this line:
> [au:antunit] 
> /home/user/ws/rat-trunk/apache-rat-tasks/src/test/resources/antunit/report-normal-operation.xml:282:
>  expected report to contain '!YASL1 
> /home/user/ws/rat-trunk/apache-rat-tasks/src/test/resources/antunit/report-normal-operation.xml'
>  but was '
> [au:antunit] *
> [au:antunit] Summary
> [au:antunit] ---
> [au:antunit] Generated at: 2017-02-06T23:12:54+01:00
> [au:antunit] 
> [au:antunit] Notes: 0
> [au:antunit] Binaries: 0
> [au:antunit] Archives: 0
> [au:antunit] Standards: 1
> [au:antunit] 
> [au:antunit] Apache Licensed: 0
> [au:antunit] Generated Documents: 0
> [au:antunit] 
> [au:antunit] JavaDocs are generated, thus a license header is optional.
> [au:antunit] Generated files do not require license headers.
> [au:antunit] 
> [au:antunit] 1 Unknown Licenses
> [au:antunit] 
> [au:antunit] *
> [au:antunit] 
> [au:antunit] Files with unapproved licenses:
> [au:antunit] 
> [au:antunit]   
> /home/user/ws/rat-trunk/apache-rat-tasks/src/test/resources/antunit/report-normal-operation.xml
> [au:antunit] 
> [au:antunit] *
> [au:antunit] 
> [au:antunit] *
> [au:antunit]   Files with Apache License headers will be marked AL
> [au:antunit]   Binary files (which do not require any license headers) will 
> be marked B
> [au:antunit]   Compressed archives will be marked A
> [au:antunit]   Notices, licenses etc. will be marked N
> [au:antunit]  !? 
> /home/user/ws/rat-trunk/apache-rat-tasks/src/test/resources/antunit/report-normal-operation.xml
> [au:antunit]  
> [au:antunit] *
> [au:antunit] 
> [au:antunit]  Printing headers for text files without a valid license 
> header...
> [au:antunit]  
> [au:antunit] =
> [au:antunit] == File: 
> /home/user/ws/rat-trunk/apache-rat-tasks/src/test/resources/antunit/report-normal-operation.xml
> [au:antunit] =
> [au:antunit] 
> [au:antunit] 
> [au:antunit] 
> [au:antunit]  [au:antunit] default="allTests"
> 

[jira] [Closed] (RAT-232) Removed prerequisites from pom use maven-enforcer instead

2017-03-17 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed RAT-232.
---
Resolution: Fixed

Fixed in [r1787483|https://svn.apache.org/r1787483]

> Removed prerequisites from pom use maven-enforcer instead
> -
>
> Key: RAT-232
> URL: https://issues.apache.org/jira/browse/RAT-232
> Project: Apache Rat
>  Issue Type: Improvement
>Affects Versions: 0.13
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 0.13
>
>
> Based on a change in [Maven 
> 3.5.0-alpha-1|https://issues.apache.org/jira/browse/MNG-6092] all non 
> maven-plugin projects which are using 
> {code:xml}
> 
> ..
> 
> {code}
> will produce a WARNING during a build. Better to force using a particular 
> maven version using maven-enforcer-plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (RAT-227) Change all links in maven-generated site to https for security reasons

2017-03-17 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed RAT-227.
---
Resolution: Fixed

Fixed in [r1787474|https://svn.apache.org/r1787474]
I hope I catched all ;-)

> Change all links in maven-generated site to https for security reasons
> --
>
> Key: RAT-227
> URL: https://issues.apache.org/jira/browse/RAT-227
> Project: Apache Rat
>  Issue Type: Improvement
>  Components: site
>Affects Versions: 0.12
>Reporter: Philipp Ottlinger
>Assignee: Karl Heinz Marbaise
> Fix For: 0.13
>
>
> The site contains many http links including the link to the source 
> repository. Change all to https.
> Do the same with all links in pom.xml since they are extracted during site 
> generation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Assigned] (RAT-227) Change all links in maven-generated site to https for security reasons

2017-03-17 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise reassigned RAT-227:
---

Assignee: Karl Heinz Marbaise

> Change all links in maven-generated site to https for security reasons
> --
>
> Key: RAT-227
> URL: https://issues.apache.org/jira/browse/RAT-227
> Project: Apache Rat
>  Issue Type: Improvement
>  Components: site
>Affects Versions: 0.12
>Reporter: Philipp Ottlinger
>Assignee: Karl Heinz Marbaise
> Fix For: 0.13
>
>
> The site contains many http links including the link to the source 
> repository. Change all to https.
> Do the same with all links in pom.xml since they are extracted during site 
> generation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (RAT-232) Removed prerequisites from pom use maven-enforcer instead for non maven-plugin projects.

2017-03-17 Thread Karl Heinz Marbaise (JIRA)
Karl Heinz Marbaise created RAT-232:
---

 Summary: Removed prerequisites from pom use maven-enforcer instead 
for non maven-plugin projects.
 Key: RAT-232
 URL: https://issues.apache.org/jira/browse/RAT-232
 Project: Apache Rat
  Issue Type: Improvement
Affects Versions: 0.13
Reporter: Karl Heinz Marbaise
Assignee: Karl Heinz Marbaise
Priority: Minor
 Fix For: 0.13


Based on a change in [Maven 
3.5.0-alpha-1|https://issues.apache.org/jira/browse/MNG-6092] all non 
maven-plugin projects which are using 
{code:xml}

..

{code}
will produce a WARNING during a build. Better to force using a particular maven 
version using maven-enforcer-plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (RAT-228) Test failures in antunit does not break the maven build / ANT does not seem to recognize additional licenses

2017-03-18 Thread Karl Heinz Marbaise (JIRA)

[ 
https://issues.apache.org/jira/browse/RAT-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931198#comment-15931198
 ] 

Karl Heinz Marbaise commented on RAT-228:
-

So after more diving into this I have identified one of the following Ant Test:
{code:xml}
  

  
  
License Family Name: Yet Another Software License (YASL) 1.0
  



  
{code}
which expects to have the text {{!YASL1 }} in the resulting report...which 
seemed to be not the case:
{code}
[au:antunit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0.124 sec
[au:antunit] Target: testFullTextMatcherNotApprovedSentToFile  caused an ERROR
[au:antunit]at line 208, column 55
[au:antunit]Message: The following error occurred while executing this line:
[au:antunit]  
../apache-rat/apache-rat-tasks/src/test/resources/antunit/report-normal-operation.xml:283:
 expected report to contain
  '!YASL1 
../apache-rat/apache-rat-tasks/src/test/resources/antunit/report-normal-operation.xml'
 but was '
[au:antunit] *
[au:antunit] Summary
[au:antunit] ---
[au:antunit] Generated at: 2017-03-18T11:55:24+01:00
[au:antunit] 
[au:antunit] Notes: 0
[au:antunit] Binaries: 0
[au:antunit] Archives: 0
[au:antunit] Standards: 1
[au:antunit] 
[au:antunit] Apache Licensed: 0
[au:antunit] Generated Documents: 0
[au:antunit] 
[au:antunit] JavaDocs are generated, thus a license header is optional.
[au:antunit] Generated files do not require license headers.
[au:antunit] 
[au:antunit] 1 Unknown Licenses
[au:antunit] 
[au:antunit] *
[au:antunit] 
[au:antunit] Files with unapproved licenses:
[au:antunit] 
[au:antunit]   
../apache-rat/apache-rat-tasks/src/test/resources/antunit/report-normal-operation.xml
[au:antunit] 
[au:antunit] *
[au:antunit] 
[au:antunit] *
[au:antunit]   Files with Apache License headers will be marked AL
[au:antunit]   Binary files (which do not require any license headers) will be 
marked B
[au:antunit]   Compressed archives will be marked A
[au:antunit]   Notices, licenses etc. will be marked N
[au:antunit]  !? 
../apache-rat/apache-rat-tasks/src/test/resources/antunit/report-normal-operation.xml
{code}
Which makes me think this test must be changed to expect {{!?}} contained 
in the report...


> Test failures in antunit does not break the maven build / ANT does not seem 
> to recognize additional licenses
> 
>
> Key: RAT-228
> URL: https://issues.apache.org/jira/browse/RAT-228
> Project: Apache Rat
>  Issue Type: Bug
>  Components: antlib
>Affects Versions: 0.12
>Reporter: Philipp Ottlinger
> Fix For: 0.13
>
>
> When I was working on RAT-226 I realized that there's a test failure within 
> the apache-rat-tasks submodule:
> {code}
> cd apache-rat-tasks
> mvn clean test
> [INFO] --- maven-antrun-plugin:1.7:run (default) @ apache-rat-tasks ---
> [INFO] Executing tasks
> main:
> allTests:
> [au:antunit] Build File: 
> /home/user/ws/rat-trunk/apache-rat-tasks/src/test/resources/antunit/report-bad-configurations.xml
> [au:antunit] Tests run: 10, Failures: 0, Errors: 0, Time elapsed: 0,291 sec
> [au:antunit] Target: testNoStylesheet took 0,003 sec
> [au:antunit] Target: testNoResources took 0,001 sec
> [au:antunit] Target: testSubstringMatcherRequiresFamilyName took 0,087 sec
> [au:antunit] Target: testFullTextMatcherRequiresFamilyName took 0,024 sec
> [au:antunit] Target: testUnusedStylesheet took 0,042 sec
> [au:antunit] Target: testFullTextMatcherRequiresText took 0,019 sec
> [au:antunit] Target: testSubstringMatcherRequiresFamilyCategory took 0,023 sec
> [au:antunit] Target: testSubstringMatcherRequiresPattern took 0,026 sec
> [au:antunit] Target: testNoLicenseMatchers took 0,001 sec
> [au:antunit] Target: testFullTextMatcherRequiresFamilyCategory took 0,016 sec
> [mkdir] Created dir: 
> /home/user/ws/rat-trunk/apache-rat-tasks/target/testoutput/dest
> allTests:
> [au:antunit] Build File: 
> /home/user/ws/rat-trunk/apache-rat-tasks/src/test/resources/antunit/report-normal-operation.xml
> [au:antunit] Tests run: 11, Failures: 0, Errors: 6, Time elapsed: 1,293 sec
> [au:antunit] Target: testFullTextMatcherNotApprovedSentToFile  caused an ERROR
> [au:antunit]  at line 209, column 55
> [au:antunit]  Message: The following error occurred while executing this line:
> [au:antunit] 
> /home/user/ws/rat-trunk/apache-rat-tasks/src/test/resources/antunit/report-normal-operation.xml:282:
>  expected report to contain '!YASL1 
> /home/user/ws/rat-trunk/apache-rat-tasks/src/test/resources/antunit/report-normal-operation.xml'
>  but was '
> 

[jira] [Updated] (RAT-230) Short Apache header is not accepted by maven-rat-plugin

2017-03-17 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise updated RAT-230:

Fix Version/s: 0.13

> Short Apache header is not accepted by maven-rat-plugin
> ---
>
> Key: RAT-230
> URL: https://issues.apache.org/jira/browse/RAT-230
> Project: Apache Rat
>  Issue Type: Bug
>  Components: maven
>Affects Versions: 0.12
>Reporter: Maxim Solodovnik
> Fix For: 0.13
>
>
> Short Apache header, available here:
> https://www.apache.org/legal/src-headers.html#is-a-short-form-of-the-source-header-available
> is not accepted by maven-rat-plugin :(
> to test:
> create build.properties with following contents
> {code}
> #Licensed to the Apache Software Foundation (ASF) under one or more 
> contributor license agreements; and to You under the Apache License, Version 
> 2.0.
> buildnumber=AAA
> {code}
> run build
> File is listed as Unapproved



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (RAT-230) Short Apache header is not accepted by rat-maven-plugin

2017-03-17 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise updated RAT-230:

Summary: Short Apache header is not accepted by rat-maven-plugin  (was: 
Short Apache header is not accepted by maven-rat-plugin)

> Short Apache header is not accepted by rat-maven-plugin
> ---
>
> Key: RAT-230
> URL: https://issues.apache.org/jira/browse/RAT-230
> Project: Apache Rat
>  Issue Type: Bug
>  Components: maven
>Affects Versions: 0.12
>Reporter: Maxim Solodovnik
> Fix For: 0.13
>
>
> Short Apache header, available here:
> https://www.apache.org/legal/src-headers.html#is-a-short-form-of-the-source-header-available
> is not accepted by maven-rat-plugin :(
> to test:
> create build.properties with following contents
> {code}
> #Licensed to the Apache Software Foundation (ASF) under one or more 
> contributor license agreements; and to You under the Apache License, Version 
> 2.0.
> buildnumber=AAA
> {code}
> run build
> File is listed as Unapproved



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (RAT-230) Short Apache header is not accepted by apache-rat-plugin

2017-03-17 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed RAT-230.
---
Resolution: Fixed

Fixed in [r1787361|https://svn.apache.org/r1787361]

> Short Apache header is not accepted by apache-rat-plugin
> 
>
> Key: RAT-230
> URL: https://issues.apache.org/jira/browse/RAT-230
> Project: Apache Rat
>  Issue Type: Bug
>  Components: maven
>Affects Versions: 0.12
>Reporter: Maxim Solodovnik
>Assignee: Karl Heinz Marbaise
> Fix For: 0.13
>
>
> Short Apache header, available here:
> https://www.apache.org/legal/src-headers.html#is-a-short-form-of-the-source-header-available
> is not accepted by maven-rat-plugin :(
> to test:
> create build.properties with following contents
> {code}
> #Licensed to the Apache Software Foundation (ASF) under one or more 
> contributor license agreements; and to You under the Apache License, Version 
> 2.0.
> buildnumber=AAA
> {code}
> run build
> File is listed as Unapproved



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Assigned] (RAT-230) Short Apache header is not accepted by apache-rat-plugin

2017-03-17 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise reassigned RAT-230:
---

Assignee: Karl Heinz Marbaise

> Short Apache header is not accepted by apache-rat-plugin
> 
>
> Key: RAT-230
> URL: https://issues.apache.org/jira/browse/RAT-230
> Project: Apache Rat
>  Issue Type: Bug
>  Components: maven
>Affects Versions: 0.12
>Reporter: Maxim Solodovnik
>Assignee: Karl Heinz Marbaise
> Fix For: 0.13
>
>
> Short Apache header, available here:
> https://www.apache.org/legal/src-headers.html#is-a-short-form-of-the-source-header-available
> is not accepted by maven-rat-plugin :(
> to test:
> create build.properties with following contents
> {code}
> #Licensed to the Apache Software Foundation (ASF) under one or more 
> contributor license agreements; and to You under the Apache License, Version 
> 2.0.
> buildnumber=AAA
> {code}
> run build
> File is listed as Unapproved



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (RAT-230) Short Apache header is not accepted by apache-rat-plugin

2017-03-17 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise updated RAT-230:

Summary: Short Apache header is not accepted by apache-rat-plugin  (was: 
Short Apache header is not accepted by rat-maven-plugin)

> Short Apache header is not accepted by apache-rat-plugin
> 
>
> Key: RAT-230
> URL: https://issues.apache.org/jira/browse/RAT-230
> Project: Apache Rat
>  Issue Type: Bug
>  Components: maven
>Affects Versions: 0.12
>Reporter: Maxim Solodovnik
> Fix For: 0.13
>
>
> Short Apache header, available here:
> https://www.apache.org/legal/src-headers.html#is-a-short-form-of-the-source-header-available
> is not accepted by maven-rat-plugin :(
> to test:
> create build.properties with following contents
> {code}
> #Licensed to the Apache Software Foundation (ASF) under one or more 
> contributor license agreements; and to You under the Apache License, Version 
> 2.0.
> buildnumber=AAA
> {code}
> run build
> File is listed as Unapproved



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (RAT-229) Mp3 files are not treated as binary

2017-03-09 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed RAT-229.
---
Resolution: Fixed

Fixed in [r1786209|https://svn.apache.org/r1786209]

> Mp3 files are not treated as binary
> ---
>
> Key: RAT-229
> URL: https://issues.apache.org/jira/browse/RAT-229
> Project: Apache Rat
>  Issue Type: Bug
>Affects Versions: 0.12
>Reporter: Maxim Solodovnik
>Assignee: Karl Heinz Marbaise
> Fix For: 0.13
>
> Attachments: rat.txt
>
>
> Mp3 file are not treated as binary and being printed as apache incompatible 
> to the report



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Assigned] (RAT-229) Mp3 files are not treated as binary

2017-03-09 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise reassigned RAT-229:
---

Assignee: Karl Heinz Marbaise

> Mp3 files are not treated as binary
> ---
>
> Key: RAT-229
> URL: https://issues.apache.org/jira/browse/RAT-229
> Project: Apache Rat
>  Issue Type: Bug
>Affects Versions: 0.12
>Reporter: Maxim Solodovnik
>Assignee: Karl Heinz Marbaise
> Fix For: 0.13
>
> Attachments: rat.txt
>
>
> Mp3 file are not treated as binary and being printed as apache incompatible 
> to the report



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (RAT-229) Mp3 files are not treated as binary

2017-03-09 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise updated RAT-229:

Fix Version/s: 0.13

> Mp3 files are not treated as binary
> ---
>
> Key: RAT-229
> URL: https://issues.apache.org/jira/browse/RAT-229
> Project: Apache Rat
>  Issue Type: Bug
>Affects Versions: 0.12
>Reporter: Maxim Solodovnik
> Fix For: 0.13
>
> Attachments: rat.txt
>
>
> Mp3 file are not treated as binary and being printed as apache incompatible 
> to the report



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)