Re: [data] dto and isNew
I wrote a response to the users list but not sure it came through. It kinda
belongs in this thread so here it goes.
So I ran into issues with the DTO mapper api and voiced my concerns in irc.
I saw this discussion and now I am trying the solution present in the
current SNAPSHOT. However I have one comment / question:
What if my Entity has a relationship to another Entity?
Like this:
public class User extends BaseAuditEntity {
@Column
private String name;
@Column
@ManyToOne
@JoinColumn(name="group_id")
private Group group;
This means my userDTO may come with a GroupDTO and how do I map that
relationship? Or to explain by code please fill in the question marks below
;) or if you feel my implementation is weird then I would gladly accept
comments on that too. But the way I see it I need to @Inject the
GroupMapper, use the EntityManager to find the Group then call
groupMapper.toEntity and then I think to myself that the API is worse now
because before I could call groupMapper.toEntity with only a dto argument.
At that point you had to use the entitymanager anyways to find "yourself"
and that feels clean compared to find your entities you form relationships
with.
@Override
protected User toEntity(final User user, final UserDTO userDTO) {
MapperUtil.toAuditEntity(user, userDTO);
user.setName(userDTO.getName());
user.setEmail(userDTO.getEmail());
user.setLocale(userDTO.getLocale());
user.setGroup(*?*);
return user;
}
Cheers / Karl
On 17 May 2014 16:40, Romain Manni-Bucau wrote:
> Yep, missed it.
>
> Works for me. Maybe the name should be closer to other methods,
> mapKey? But whatever you choose as name this solution works :).
>
>
> Romain Manni-Bucau
> Twitter: @rmannibucau
> Blog: http://rmannibucau.wordpress.com/
> LinkedIn: http://fr.linkedin.com/in/rmannibucau
> Github: https://github.com/rmannibucau
>
>
> 2014-05-17 15:54 GMT+02:00 Thomas Hug :
> > It's the PK, not the Entity ;) In SimpleQueryInOutMapperBase, it could be
> > something like
> >
> > @Inject
> > private QueryInvocationContext context;
> >
> > protected abstract Object getPrimaryKey(Dto dto);
> >
> > protected E findEntity(Object pk)
> > {
> > return (E) context.getEntityManager().find(context.getEntityClass(),
> > pk);
> > }
> >
> > @Override
> > public Object mapParameter(final Object parameter)
> > {
> > Object pk = getPrimaryKey((Dto) parameter);
> > if (pk != null)
> > {
> > E entity = findEntity(pk);
> > return toEntity(entity, (Dto) parameter);
> > }
> > return toEntity(newEntity(), (Dto) parameter);
> > }
> >
> >
> > On Sat, May 17, 2014 at 1:57 PM, Romain Manni-Bucau
> > wrote:
> >
> >> would work while return is and not Object ;)
> >>
> >>
> >> Romain Manni-Bucau
> >> Twitter: @rmannibucau
> >> Blog: http://rmannibucau.wordpress.com/
> >> LinkedIn: http://fr.linkedin.com/in/rmannibucau
> >> Github: https://github.com/rmannibucau
> >>
> >>
> >> 2014-05-17 11:47 GMT+02:00 Thomas Hug :
> >> > Or a protected abstract Object getPrimaryKey(Dto dto). We can get the
> EM
> >> > over an injected QueryInvocationContext.
> >> >
> >> >
> >> > On Thu, May 15, 2014 at 9:06 PM, Romain Manni-Bucau
> >> > wrote:
> >> >
> >> >> I think a protected findEntity(id) in the mapper can be enough.
> >> >>
> >> >>
> >> >> Romain Manni-Bucau
> >> >> Twitter: @rmannibucau
> >> >> Blog: http://rmannibucau.wordpress.com/
> >> >> LinkedIn: http://fr.linkedin.com/in/rmannibucau
> >> >> Github: https://github.com/rmannibucau
> >> >>
> >> >>
> >> >> 2014-05-07 22:29 GMT+02:00 Thomas Hug :
> >> >> > Hi Romain,
> >> >> > See your point. But if we only get the DTO - with what would we
> call
> >> the
> >> >> > find? Could even be that the PK is a DTO or encoded / encrypted and
> >> needs
> >> >> > to go through the mapper first. Maybe we can provide some
> convenience
> >> >> > methods in the base mapper?
> >> >> >
> >> >> >
> >> >> > On Tue, May 6, 2014 at 7:41 PM, Romain Manni-Bucau <
> >> >> rmannibu...@gmail.com>wrote:
> >> >> >
> >> >> >> Hi guys,
> >> >> >>
> >> >> >> DTO feature is awesome but doesn't work in update mode since isNew
> >> >> >> doesn't use a managed entity.
> >> >> >>
> >> >> >> When using a mapper we should call find and pass it to the mapper
> (or
> >> >> >> create a new unmanaged entity if not found). So mapper signature
> >> >> >> should be Entity toEntity(Entity, DTO) no?
> >> >> >>
> >> >> >> Otherwise users need to do the find in the mapper...almost
> eveytime.
> >> >> >>
> >> >> >> wdyt?
> >> >> >>
> >> >> >>
> >> >> >> Romain Manni-Bucau
> >> >> >> Twitter: @rmannibucau
> >> >> >> Blog: http://rmannibucau.wordpress.com/
> >> >> >> LinkedIn: http://fr.linkedin.com/in/rmannibucau
> >> >> >> Github: https://github.com/rmannibucau
> >> >> >>
> >> >>
> >>
>
[jira] [Resolved] (DELTASPIKE-610) re-visit DataSourceConfig
[ https://issues.apache.org/jira/browse/DELTASPIKE-610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Struberg resolved DELTASPIKE-610. -- Resolution: Fixed I removed it. It does of course also work with other JPA providers as well, but there are better ways to do this most of the time. > re-visit DataSourceConfig > - > > Key: DELTASPIKE-610 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-610 > Project: DeltaSpike > Issue Type: Task > Components: JPA-Module >Affects Versions: 0.7 >Reporter: Gerhard Petracek >Assignee: Mark Struberg >Priority: Blocker > Fix For: 1.0.0 > > > if DataSourceConfig is still just compatible with openjpa, we have to drop it. > (blocker, because we have to do it before v1) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (DELTASPIKE-642) Better structure for Core documentation
Thomas Andraschko created DELTASPIKE-642: Summary: Better structure for Core documentation Key: DELTASPIKE-642 URL: https://issues.apache.org/jira/browse/DELTASPIKE-642 Project: DeltaSpike Issue Type: Task Components: Core, Documentation Reporter: Thomas Andraschko Currently we have this as root nodes below "Core - API" Exception Control Exception Handling - Usage Eventing into the exception handling framework Exception handlers Exception Chain Processing Handler ordinal APIs for exception information and flow control I would group it to "Exception Handling" below "Core - API" -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (DELTASPIKE-641) Document prevent double submit feature
Thomas Andraschko created DELTASPIKE-641: Summary: Document prevent double submit feature Key: DELTASPIKE-641 URL: https://issues.apache.org/jira/browse/DELTASPIKE-641 Project: DeltaSpike Issue Type: Task Components: Documentation, JSF-Module Reporter: Thomas Andraschko -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (DELTASPIKE-640) Document Scopes in Core module
Thomas Andraschko created DELTASPIKE-640: Summary: Document Scopes in Core module Key: DELTASPIKE-640 URL: https://issues.apache.org/jira/browse/DELTASPIKE-640 Project: DeltaSpike Issue Type: Task Components: Core, Documentation Reporter: Thomas Andraschko The API for all scopes is available in the Core API and we currently only have implementions for JSF. We should document this, all scopes and maybe give some hints how to implement it for other technologies. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (DELTASPIKE-627) Distinguish saves and updates
[
https://issues.apache.org/jira/browse/DELTASPIKE-627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Hug resolved DELTASPIKE-627.
---
Resolution: Fixed
Javadoc of save updated. The distinction can be made using
EntityManagerDelegate.
> Distinguish saves and updates
> -
>
> Key: DELTASPIKE-627
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-627
> Project: DeltaSpike
> Issue Type: Bug
> Components: Data-Module
>Affects Versions: 0.7
>Reporter: Harald Wellmann
>Assignee: Thomas Hug
>
> JPA {{EntityManager}} has distinct {{persist()}} and {{merge()}} methods, and
> there's a reason for that.
> DeltaSpike {{EntityRepository}} hides both behind a {{save()}} method which
> loses information and does not always do the right thing.
> Example:
> Take an entity with a user-defined ID of type String, e.g.
> {code}
> @Entity
> public class Language {
> @Id
> private String id;
> private String name;
> }
> {code}
> Using {{EntityManager.persist()}}, we get an {{EntityExistsException}}:
> {code}
> em.persist(new Language("de", "Deutsch"));
> em.persist(new Language("de", "Doitsch"));
> {code}
> Using {{EntityRepository.save()}}, the first entity is silently overwritten
> by the second one.
> {code}
> repository.save(new Language("de", "Deutsch"));
> repository.save(new Language("de", "Doitsch"));
> {code}
> Goals:
> * Clarify semantics of save() in the Javadoc.
> * Add a create() method with persist() semantics.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Resolved] (DELTASPIKE-639) Fix Criteria API count methods signatures
[ https://issues.apache.org/jira/browse/DELTASPIKE-639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Hug resolved DELTASPIKE-639. --- Resolution: Fixed API updated. > Fix Criteria API count methods signatures > - > > Key: DELTASPIKE-639 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-639 > Project: DeltaSpike > Issue Type: Bug > Components: Data-Module >Affects Versions: 0.7 >Reporter: Thomas Hug >Assignee: Thomas Hug > Fix For: 1.0.0 > > > The method signatures for the count should: > - Return a QuerySelection > - Take a SingularAttribute as parameter -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (DELTASPIKE-639) Fix Criteria API count methods signatures
Thomas Hug created DELTASPIKE-639: - Summary: Fix Criteria API count methods signatures Key: DELTASPIKE-639 URL: https://issues.apache.org/jira/browse/DELTASPIKE-639 Project: DeltaSpike Issue Type: Bug Components: Data-Module Affects Versions: 0.7 Reporter: Thomas Hug Assignee: Thomas Hug Fix For: 1.0.0 The method signatures for the count should: - Return a QuerySelection - Take a SingularAttribute as parameter -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: Data Module - Criteria Support
Hi Radu, Thanks for paying attention! You're right, doesn't really make sense. Additionally, the result type can also be narrowed down to a QuerySelection. I'll create a JIRA ticket for it. Cheers, Thomas On Thu, Jun 12, 2014 at 4:53 PM, Radu Creanga wrote: > Hi @all, > > I am just trying out the data module and it seems that the > CriteriaSupport#count() method is too restrictive on the attribute > parameter type. The current declaration is: > > QuerySelection count(SingularAttribute > attribute); > > while it should probably be: > > QuerySelection count(SingularAttribute > attribute); > > That's because when using the Criteria API alone, there is no such > restriction to the attribute type. Could this be an oversight? > > Best regards, > Radu >
[jira] [Resolved] (DELTASPIKE-634) Add documentation for Deactivatable
[ https://issues.apache.org/jira/browse/DELTASPIKE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael Benevides resolved DELTASPIKE-634. - Resolution: Fixed published: http://deltaspike.apache.org/core.html#deactivatable > Add documentation for Deactivatable > --- > > Key: DELTASPIKE-634 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-634 > Project: DeltaSpike > Issue Type: Task > Components: Core, Documentation >Reporter: Thomas Andraschko >Assignee: Rafael Benevides > > There is currently no docu available for how to disable our deactivatable > artifacts -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (DELTASPIKE-227) documentation for minimal type-safe messages
[ https://issues.apache.org/jira/browse/DELTASPIKE-227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael Benevides resolved DELTASPIKE-227. - Resolution: Fixed Published: http://deltaspike.apache.org/jsf.html#integration-with-deltaspike-type-safe-messages > documentation for minimal type-safe messages > > > Key: DELTASPIKE-227 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-227 > Project: DeltaSpike > Issue Type: Sub-task > Components: I18n-Module >Reporter: Gerhard Petracek >Assignee: Rafael Benevides > Fix For: 1.0.0 > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (DELTASPIKE-634) Add documentation for Deactivatable
[ https://issues.apache.org/jira/browse/DELTASPIKE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029444#comment-14029444 ] Rafael Benevides commented on DELTASPIKE-634: - Commit: r1602236 > Add documentation for Deactivatable > --- > > Key: DELTASPIKE-634 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-634 > Project: DeltaSpike > Issue Type: Task > Components: Core, Documentation >Reporter: Thomas Andraschko >Assignee: Rafael Benevides > > There is currently no docu available for how to disable our deactivatable > artifacts -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (DELTASPIKE-227) documentation for minimal type-safe messages
[ https://issues.apache.org/jira/browse/DELTASPIKE-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029447#comment-14029447 ] Rafael Benevides commented on DELTASPIKE-227: - Commit r1602237 > documentation for minimal type-safe messages > > > Key: DELTASPIKE-227 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-227 > Project: DeltaSpike > Issue Type: Sub-task > Components: I18n-Module >Reporter: Gerhard Petracek >Assignee: Rafael Benevides > Fix For: 1.0.0 > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (DELTASPIKE-634) Add documentation for Deactivatable
[ https://issues.apache.org/jira/browse/DELTASPIKE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029434#comment-14029434 ] Rafael Benevides commented on DELTASPIKE-634: - We have some draft here: http://deltaspike.apache.org/spi.html#deactivatable But I just added an example on the Core page. I'll publish in some minutes. > Add documentation for Deactivatable > --- > > Key: DELTASPIKE-634 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-634 > Project: DeltaSpike > Issue Type: Task > Components: Core, Documentation >Reporter: Thomas Andraschko >Assignee: Rafael Benevides > > There is currently no docu available for how to disable our deactivatable > artifacts -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Reopened] (DELTASPIKE-227) documentation for minimal type-safe messages
[ https://issues.apache.org/jira/browse/DELTASPIKE-227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael Benevides reopened DELTASPIKE-227: - rbenevides: @"...//Overrided JSF messages..." that's one aspect - the 2nd one is that this configured bundle gets reused by ds - so you don't have to use the naming convention nor @MessageContextConfig > documentation for minimal type-safe messages > > > Key: DELTASPIKE-227 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-227 > Project: DeltaSpike > Issue Type: Sub-task > Components: I18n-Module >Reporter: Gerhard Petracek >Assignee: Rafael Benevides > Fix For: 1.0.0 > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (DELTASPIKE-227) documentation for minimal type-safe messages
[ https://issues.apache.org/jira/browse/DELTASPIKE-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029400#comment-14029400 ] Rafael Benevides edited comment on DELTASPIKE-227 at 6/12/14 4:55 PM: -- rbenevides: @"...//Overrided JSF messages..." that's one aspect - the 2nd one is that this configured bundle gets reused by ds - so you don't have to use the naming convention nor @MessageContextConfig + if there is a config for supported locales it will be checked as well + fallback to the configured default locale... was (Author: rafabene): rbenevides: @"...//Overrided JSF messages..." that's one aspect - the 2nd one is that this configured bundle gets reused by ds - so you don't have to use the naming convention nor @MessageContextConfig > documentation for minimal type-safe messages > > > Key: DELTASPIKE-227 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-227 > Project: DeltaSpike > Issue Type: Sub-task > Components: I18n-Module >Reporter: Gerhard Petracek >Assignee: Rafael Benevides > Fix For: 1.0.0 > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (DELTASPIKE-227) documentation for minimal type-safe messages
[ https://issues.apache.org/jira/browse/DELTASPIKE-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029223#comment-14029223 ] Rafael Benevides commented on DELTASPIKE-227: - Fixed: Commit r1602186 Published: http://deltaspike.apache.org/jsf.html#integration-with-deltaspike-type-safe-messages > documentation for minimal type-safe messages > > > Key: DELTASPIKE-227 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-227 > Project: DeltaSpike > Issue Type: Sub-task > Components: I18n-Module >Reporter: Gerhard Petracek >Assignee: Rafael Benevides > Fix For: 1.0.0 > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (DELTASPIKE-227) documentation for minimal type-safe messages
[ https://issues.apache.org/jira/browse/DELTASPIKE-227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael Benevides resolved DELTASPIKE-227. - Resolution: Fixed > documentation for minimal type-safe messages > > > Key: DELTASPIKE-227 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-227 > Project: DeltaSpike > Issue Type: Sub-task > Components: I18n-Module >Reporter: Gerhard Petracek >Assignee: Rafael Benevides > Fix For: 1.0.0 > > -- This message was sent by Atlassian JIRA (v6.2#6252)
Data Module - Criteria Support
Hi @all, I am just trying out the data module and it seems that the CriteriaSupport#count() method is too restrictive on the attribute parameter type. The current declaration is: QuerySelection count(SingularAttribute attribute); while it should probably be: QuerySelection count(SingularAttribute attribute); That's because when using the Criteria API alone, there is no such restriction to the attribute type. Could this be an oversight? Best regards, Radu
Re: [VOTE] logo-shape
+1 for #1/#2 (same shape IMO) Matt On Jun 11, 2014 11:55 AM, "Gerhard Petracek" wrote: > hi @ all, > > this first vote is just about the basic shape/style and >not< the color. > > i've uploaded the candidates provided by jim at [1]. > please send a +1 for one (or two) logo shape/s. > (there will be a 2nd vote about the color afterwards.) > > regards, > gerhard > > [1] http://s.apache.org/DS_LOGO1_VOTE1 >
[jira] [Updated] (DELTASPIKE-634) Add documentation for Deactivatable
[ https://issues.apache.org/jira/browse/DELTASPIKE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek updated DELTASPIKE-634: Assignee: Rafael Benevides > Add documentation for Deactivatable > --- > > Key: DELTASPIKE-634 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-634 > Project: DeltaSpike > Issue Type: Task > Components: Core, Documentation >Reporter: Thomas Andraschko >Assignee: Rafael Benevides > > There is currently no docu available for how to disable our deactivatable > artifacts -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (DELTASPIKE-637) duplicated handling of AccessDeniedException
[ https://issues.apache.org/jira/browse/DELTASPIKE-637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek reassigned DELTASPIKE-637: --- Assignee: Gerhard Petracek > duplicated handling of AccessDeniedException > > > Key: DELTASPIKE-637 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-637 > Project: DeltaSpike > Issue Type: Bug > Components: JSF-Module >Affects Versions: 1.0.0 >Reporter: Gerhard Petracek >Assignee: Gerhard Petracek >Priority: Minor > Fix For: 1.0.1 > > Attachments: DELTASPIKE-637.patch > > > BridgeExceptionHandlerWrapper fires ExceptionToCatchEvent for > AccessDeniedException again. however, we can't just filter it since it's > currently the only approach to use handlers if the violation was detected by > an AccessDecisionVoter configured via view-configs. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (DELTASPIKE-637) duplicated handling of AccessDeniedException
[ https://issues.apache.org/jira/browse/DELTASPIKE-637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek updated DELTASPIKE-637: Attachment: DELTASPIKE-637.patch > duplicated handling of AccessDeniedException > > > Key: DELTASPIKE-637 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-637 > Project: DeltaSpike > Issue Type: Bug > Components: JSF-Module >Affects Versions: 1.0.0 >Reporter: Gerhard Petracek >Priority: Minor > Fix For: 1.0.1 > > Attachments: DELTASPIKE-637.patch > > > BridgeExceptionHandlerWrapper fires ExceptionToCatchEvent for > AccessDeniedException again. however, we can't just filter it since it's > currently the only approach to use handlers if the violation was detected by > an AccessDecisionVoter configured via view-configs. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (DELTASPIKE-637) duplicated handling of AccessDeniedException
[ https://issues.apache.org/jira/browse/DELTASPIKE-637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek updated DELTASPIKE-637: Fix Version/s: (was: 1.0.2) 1.0.1 > duplicated handling of AccessDeniedException > > > Key: DELTASPIKE-637 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-637 > Project: DeltaSpike > Issue Type: Bug > Components: JSF-Module >Affects Versions: 1.0.0 >Reporter: Gerhard Petracek >Assignee: Gerhard Petracek >Priority: Minor > Fix For: 1.0.1 > > Attachments: DELTASPIKE-637.patch > > > BridgeExceptionHandlerWrapper fires ExceptionToCatchEvent for > AccessDeniedException again. however, we can't just filter it since it's > currently the only approach to use handlers if the violation was detected by > an AccessDecisionVoter configured via view-configs. -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: [VOTE] logo-shape
+1 for #5 Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-06-12 11:37 GMT+02:00 Antoine Sabot-Durand : > +1 for #1 > +1 for #5 > > Antoine > > Le 11 juin 2014 à 18:51, Gerhard Petracek a écrit : > > > hi @ all, > > > > this first vote is just about the basic shape/style and >not< the color. > > > > i've uploaded the candidates provided by jim at [1]. > > please send a +1 for one (or two) logo shape/s. > > (there will be a 2nd vote about the color afterwards.) > > > > regards, > > gerhard > > > > [1] http://s.apache.org/DS_LOGO1_VOTE1 > >
Re: [VOTE] logo-shape
+1 for #1 +1 for #5 Antoine Le 11 juin 2014 à 18:51, Gerhard Petracek a écrit : > hi @ all, > > this first vote is just about the basic shape/style and >not< the color. > > i've uploaded the candidates provided by jim at [1]. > please send a +1 for one (or two) logo shape/s. > (there will be a 2nd vote about the color afterwards.) > > regards, > gerhard > > [1] http://s.apache.org/DS_LOGO1_VOTE1 signature.asc Description: Message signed with OpenPGP using GPGMail
Re: [VOTE] logo-shape
+1 for #3 Dev Khadka Synergy Tech Software Pvt. Ltd. e-Mail: dev.kha...@syntechnepal.com Office: 977-1-5009087, 5526297 Mobile: +9779841358015 On 06/11/2014 10:36 PM, Gerhard Petracek wrote: hi @ all, this first vote is just about the basic shape/style and >not< the color. i've uploaded the candidates provided by jim at [1]. please send a +1 for one (or two) logo shape/s. (there will be a 2nd vote about the color afterwards.) regards, gerhard [1] http://s.apache.org/DS_LOGO1_VOTE1
[jira] [Updated] (DELTASPIKE-636) @Secures should trigger the ds-exception-handler
[ https://issues.apache.org/jira/browse/DELTASPIKE-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek updated DELTASPIKE-636: Attachment: (was: DELTASPIKE-636_2.patch) > @Secures should trigger the ds-exception-handler > > > Key: DELTASPIKE-636 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-636 > Project: DeltaSpike > Issue Type: Improvement > Components: Security-Module >Affects Versions: 0.7 >Reporter: Pedro Igor >Assignee: Gerhard Petracek >Priority: Minor > Fix For: 1.0.0 > > Attachments: AccessDeniedExceptionHandling.patch, > DELTASPIKE-636.patch, DELTASPIKE-636_4.patch > > > When using @Secures, if a validation fails the AccessDeniedException is > thrown without letting the application to handle it properly. This ends up > printing the stack trace on the logs. > Ideally, users should be able to handle this exception before propagating it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (DELTASPIKE-636) @Secures should trigger the ds-exception-handler
[ https://issues.apache.org/jira/browse/DELTASPIKE-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek updated DELTASPIKE-636: Attachment: (was: DELTASPIKE-636_3.patch) > @Secures should trigger the ds-exception-handler > > > Key: DELTASPIKE-636 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-636 > Project: DeltaSpike > Issue Type: Improvement > Components: Security-Module >Affects Versions: 0.7 >Reporter: Pedro Igor >Assignee: Gerhard Petracek >Priority: Minor > Fix For: 1.0.0 > > Attachments: AccessDeniedExceptionHandling.patch, > DELTASPIKE-636.patch, DELTASPIKE-636_4.patch > > > When using @Secures, if a validation fails the AccessDeniedException is > thrown without letting the application to handle it properly. This ends up > printing the stack trace on the logs. > Ideally, users should be able to handle this exception before propagating it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (DELTASPIKE-636) @Secures should trigger the ds-exception-handler
[ https://issues.apache.org/jira/browse/DELTASPIKE-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek resolved DELTASPIKE-636. - Resolution: Fixed > @Secures should trigger the ds-exception-handler > > > Key: DELTASPIKE-636 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-636 > Project: DeltaSpike > Issue Type: Improvement > Components: Security-Module >Affects Versions: 0.7 >Reporter: Pedro Igor >Assignee: Gerhard Petracek >Priority: Minor > Fix For: 1.0.0 > > Attachments: AccessDeniedExceptionHandling.patch, > DELTASPIKE-636.patch, DELTASPIKE-636_4.patch > > > When using @Secures, if a validation fails the AccessDeniedException is > thrown without letting the application to handle it properly. This ends up > printing the stack trace on the logs. > Ideally, users should be able to handle this exception before propagating it. -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: [VOTE] logo-shape
+1 on #3 and #12 On Thu, Jun 12, 2014 at 7:34 AM, Nicklas Karlsson wrote: > #12, #2 (most options look a bit like aiming for the letter "A" and #13 > reminds a bit of the german SS-logo) ;-) > > > On Thu, Jun 12, 2014 at 5:11 AM, Shane Bryzak wrote: > > > +1 for #1 > > > > > > On 06/12/2014 12:51 AM, Gerhard Petracek wrote: > > > >> hi @ all, > >> > >> this first vote is just about the basic shape/style and >not< the color. > >> > >> i've uploaded the candidates provided by jim at [1]. > >> please send a +1 for one (or two) logo shape/s. > >> (there will be a 2nd vote about the color afterwards.) > >> > >> regards, > >> gerhard > >> > >> [1] http://s.apache.org/DS_LOGO1_VOTE1 > >> > >> > > > > > -- > Nicklas Karlsson, +358 40 5062266 > Vaakunatie 10 as 7, 20780 Kaarina >
