Re: [dpdk-dev v1] crypto/openssl: EVP_PKEY routine update in rsa op
05/07/2022 12:43, Ji, Kai: > From: Thomas Monjalon > > 30/06/2022 12:38, Kai Ji: > > > EVP_PKEY function need to be called twice for rsa sign and verify > > > operations. This patch also remove the OPENSSL_API_COMPAT as all the > > > deprecated APIs are avoid if 3.0 lib is present. > > > > I prefer not pulling this patch for now because it is not clear. > > > > 1/ What is fixed exactly? All RSA sign and verify were broken? > No, this patch fix the 3.0 EVP API in RSA sign and verify routine, original > openssl 1.x rsa sign and verify routines are untouched. > The original patch set for Openssl 3.0 EVP API is here: > http://patchwork.dpdk.org/project/dpdk/patch/20220621154214.78176-3-kai...@intel.com/ > > > > 2/ Do you mean OpenSSL 3 is required? > No, this branch code will be only executed when Openssl 3.0 lib is detected > on the host. OK, please could you reword the commit message so I can apply it to the commit? Thanks
RE: [dpdk-dev v1] crypto/openssl: EVP_PKEY routine update in rsa op
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Monday, July 4, 2022 8:45 PM > To: Ji, Kai > Cc: dev@dpdk.org; gak...@marvell.com > Subject: Re: [dpdk-dev v1] crypto/openssl: EVP_PKEY routine update in rsa > op > > 30/06/2022 12:38, Kai Ji: > > EVP_PKEY function need to be called twice for rsa sign and verify > > operations. This patch also remove the OPENSSL_API_COMPAT as all the > > deprecated APIs are avoid if 3.0 lib is present. > > I prefer not pulling this patch for now because it is not clear. > > 1/ What is fixed exactly? All RSA sign and verify were broken? No, this patch fix the 3.0 EVP API in RSA sign and verify routine, original openssl 1.x rsa sign and verify routines are untouched. The original patch set for Openssl 3.0 EVP API is here: http://patchwork.dpdk.org/project/dpdk/patch/20220621154214.78176-3-kai...@intel.com/ > 2/ Do you mean OpenSSL 3 is required? No, this branch code will be only executed when Openssl 3.0 lib is detected on the host. > >
Re: [dpdk-dev v1] crypto/openssl: EVP_PKEY routine update in rsa op
30/06/2022 12:38, Kai Ji: > EVP_PKEY function need to be called twice for rsa sign and verify > operations. This patch also remove the OPENSSL_API_COMPAT as all > the deprecated APIs are avoid if 3.0 lib is present. I prefer not pulling this patch for now because it is not clear. 1/ What is fixed exactly? All RSA sign and verify were broken? 2/ Do you mean OpenSSL 3 is required?
