Re: [dpdk-dev] [PATCH] MAINTAINERS: resign from vhost/virtio maintainer
12/02/2018 10:54, Maxime Coquelin: > Hi Yuanhan, > > On 02/12/2018 10:44 AM, Yuanhan Liu wrote: > > On Mon, Feb 12, 2018 at 04:51:58PM +0800, Yuanhan Liu wrote: > >> I was doing terrible reviews jobs recently, and to not hold back > >> the vhost/virtio development, it's better for me to resign. > > I would not put this in the commit message, because even you had less > time to review vhost/virtio patches recently, you have done a great work > on maintaining virtio and vhost generally, we owe you a lot of thanks > for this. +1, thank you Yuanhan for the great work on vhost/virtio Unfortunately, we must accept this "patch". Applied
Re: [dpdk-dev] [PATCH] MAINTAINERS: resign from vhost/virtio maintainer
On 2/12/2018 5:54 PM, Maxime Coquelin wrote: Hi Yuanhan, On 02/12/2018 10:44 AM, Yuanhan Liu wrote: On Mon, Feb 12, 2018 at 04:51:58PM +0800, Yuanhan Liu wrote: I was doing terrible reviews jobs recently, and to not hold back the vhost/virtio development, it's better for me to resign. I would not put this in the commit message, because even you had less time to review vhost/virtio patches recently, you have done a great work on maintaining virtio and vhost generally, we owe you a lot of thanks for this. +1, yuanhan, you have done so great work; I'm one of the witnesses :-) Then here it is. One thing I forgot to mention is, not surprisingly, I will also resign from the committer role on the next-virtio tree. I propose myself for the committer role, I have already some experience as Kernel maintainer for some ARM SoCs. Acked-by: Jianfeng Tan Thank you for taking this role! Thanks, Jianfeng Cheers, Maxime --yliu Signed-off-by: Yuanhan Liu --- MAINTAINERS | 3 --- 1 file changed, 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4f1f33b..f12d83d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -557,7 +557,6 @@ F: doc/guides/nics/vmxnet3.rst F: doc/guides/nics/features/vmxnet3.ini Vhost-user -M: Yuanhan Liu M: Maxime Coquelin T: git://dpdk.org/next/dpdk-next-virtio F: lib/librte_vhost/ @@ -569,14 +568,12 @@ F: doc/guides/sample_app_ug/vhost_scsi.rst Vhost PMD M: Tetsuya Mukawa -M: Yuanhan Liu M: Maxime Coquelin T: git://dpdk.org/next/dpdk-next-virtio F: drivers/net/vhost/ F: doc/guides/nics/features/vhost.ini Virtio PMD -M: Yuanhan Liu M: Maxime Coquelin M: Tiwei Bie T: git://dpdk.org/next/dpdk-next-virtio -- 2.7.4
Re: [dpdk-dev] [PATCH] MAINTAINERS: resign from vhost/virtio maintainer
On Mon, Feb 12, 2018 at 10:54:08AM +0100, Maxime Coquelin wrote: > Hi Yuanhan, > > On 02/12/2018 10:44 AM, Yuanhan Liu wrote: > >On Mon, Feb 12, 2018 at 04:51:58PM +0800, Yuanhan Liu wrote: > >>I was doing terrible reviews jobs recently, and to not hold back > >>the vhost/virtio development, it's better for me to resign. > > I would not put this in the commit message, because even you had less > time to review vhost/virtio patches recently, you have done a great work > on maintaining virtio and vhost generally, we owe you a lot of thanks > for this. Thank you! > >>Then here it is. > > > >One thing I forgot to mention is, not surprisingly, I will also resign > >from the committer role on the next-virtio tree. > > I propose myself for the committer role, I have already some experience as > Kernel maintainer for some ARM SoCs. Thank you again for volunteering youself to take care of it. I think you have proved that well since you joined DPDK community :) So Acked-by: Yuanhan Liu Also Cc'ed the teckboard, per ask from Thomas. --yliu > > Cheers, > Maxime > > > --yliu > >> > >>Signed-off-by: Yuanhan Liu > >>--- > >> MAINTAINERS | 3 --- > >> 1 file changed, 3 deletions(-) > >> > >>diff --git a/MAINTAINERS b/MAINTAINERS > >>index 4f1f33b..f12d83d 100644 > >>--- a/MAINTAINERS > >>+++ b/MAINTAINERS > >>@@ -557,7 +557,6 @@ F: doc/guides/nics/vmxnet3.rst > >> F: doc/guides/nics/features/vmxnet3.ini > >> Vhost-user > >>-M: Yuanhan Liu > >> M: Maxime Coquelin > >> T: git://dpdk.org/next/dpdk-next-virtio > >> F: lib/librte_vhost/ > >>@@ -569,14 +568,12 @@ F: doc/guides/sample_app_ug/vhost_scsi.rst > >> Vhost PMD > >> M: Tetsuya Mukawa > >>-M: Yuanhan Liu > >> M: Maxime Coquelin > >> T: git://dpdk.org/next/dpdk-next-virtio > >> F: drivers/net/vhost/ > >> F: doc/guides/nics/features/vhost.ini > >> Virtio PMD > >>-M: Yuanhan Liu > >> M: Maxime Coquelin > >> M: Tiwei Bie > >> T: git://dpdk.org/next/dpdk-next-virtio > >>-- > >>2.7.4
Re: [dpdk-dev] [PATCH] MAINTAINERS: resign from vhost/virtio maintainer
Hi Yuanhan, On 02/12/2018 10:44 AM, Yuanhan Liu wrote: On Mon, Feb 12, 2018 at 04:51:58PM +0800, Yuanhan Liu wrote: I was doing terrible reviews jobs recently, and to not hold back the vhost/virtio development, it's better for me to resign. I would not put this in the commit message, because even you had less time to review vhost/virtio patches recently, you have done a great work on maintaining virtio and vhost generally, we owe you a lot of thanks for this. Then here it is. One thing I forgot to mention is, not surprisingly, I will also resign from the committer role on the next-virtio tree. I propose myself for the committer role, I have already some experience as Kernel maintainer for some ARM SoCs. Cheers, Maxime --yliu Signed-off-by: Yuanhan Liu --- MAINTAINERS | 3 --- 1 file changed, 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4f1f33b..f12d83d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -557,7 +557,6 @@ F: doc/guides/nics/vmxnet3.rst F: doc/guides/nics/features/vmxnet3.ini Vhost-user -M: Yuanhan Liu M: Maxime Coquelin T: git://dpdk.org/next/dpdk-next-virtio F: lib/librte_vhost/ @@ -569,14 +568,12 @@ F: doc/guides/sample_app_ug/vhost_scsi.rst Vhost PMD M: Tetsuya Mukawa -M: Yuanhan Liu M: Maxime Coquelin T: git://dpdk.org/next/dpdk-next-virtio F: drivers/net/vhost/ F: doc/guides/nics/features/vhost.ini Virtio PMD -M: Yuanhan Liu M: Maxime Coquelin M: Tiwei Bie T: git://dpdk.org/next/dpdk-next-virtio -- 2.7.4
Re: [dpdk-dev] [PATCH] MAINTAINERS: resign from vhost/virtio maintainer
On Mon, Feb 12, 2018 at 04:51:58PM +0800, Yuanhan Liu wrote: > I was doing terrible reviews jobs recently, and to not hold back > the vhost/virtio development, it's better for me to resign. > > Then here it is. One thing I forgot to mention is, not surprisingly, I will also resign from the committer role on the next-virtio tree. --yliu > > Signed-off-by: Yuanhan Liu > --- > MAINTAINERS | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 4f1f33b..f12d83d 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -557,7 +557,6 @@ F: doc/guides/nics/vmxnet3.rst > F: doc/guides/nics/features/vmxnet3.ini > > Vhost-user > -M: Yuanhan Liu > M: Maxime Coquelin > T: git://dpdk.org/next/dpdk-next-virtio > F: lib/librte_vhost/ > @@ -569,14 +568,12 @@ F: doc/guides/sample_app_ug/vhost_scsi.rst > > Vhost PMD > M: Tetsuya Mukawa > -M: Yuanhan Liu > M: Maxime Coquelin > T: git://dpdk.org/next/dpdk-next-virtio > F: drivers/net/vhost/ > F: doc/guides/nics/features/vhost.ini > > Virtio PMD > -M: Yuanhan Liu > M: Maxime Coquelin > M: Tiwei Bie > T: git://dpdk.org/next/dpdk-next-virtio > -- > 2.7.4
