[GitHub] drill pull request #965: DRILL-5811 reduced repeated log messages further.

[vrozov]

Github user vrozov commented on a diff in the pull request:

https://github.com/apache/drill/pull/965#discussion_r14359
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/schedule/BlockMapBuilder.java
 ---
@@ -104,12 +104,16 @@ public BlockMapReader(FileStatus status, boolean 
blockify) {
 @Override
 protected List runInner() throws Exception {
   final List work = Lists.newArrayList();
+
+  final Set noDrillbitHosts = logger.isDebugEnabled() ? 
Sets.newHashSet() : null;
--- End diff --

Consider moving `noDillbitHosts` to `BlockMapBuilder` class (use 
`Sets.newConcurrentHashSet()` in this case) as it does not seem to belong to 
`BlockMapReader`. With such change, other changes are not necessary and likely 
this will allow reducing repeated log messages even further. Drop `` 
from `Sets.newHashSet()`.


---

[GitHub] drill pull request #965: DRILL-5811 reduced repeated log messages further.

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/965


---

[GitHub] drill pull request #965: DRILL-5811 reduced repeated log messages further.

[ilooner]

GitHub user ilooner opened a pull request:

https://github.com/apache/drill/pull/965

DRILL-5811 reduced repeated log messages further.

This reduces the number of messages printed for blocks that are on nodes on 
which there is no drillbit running. Now the number of messages printed is equal 
to the number of nodes on which there are blocks that don't have drillbits. For 
example if there are 6 data nodes and only 2 of those nodes have drill bits, 
then exactly 4 messages will be printed. This time around I have tested this on 
my own physical cluster.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ilooner/drill DRILL-5811

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/965.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #965


commit 872b330199c177e8b7ab847412a1187322547135
Author: Timothy Farkas 
Date:   2017-09-28T19:56:18Z

DRILL-5811 reduced repeated log messages further.




---