Re: svn commit: r980317 - /geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
Hi, Jarek:
What is the difference between the old one and the new one ? While I did
it in the past, I just feel that there is no need to create an extra
HashSet.
2010/7/29 ga...@apache.org
Author: gawor
Date: Thu Jul 29 05:54:33 2010
New Revision: 980317
URL: http://svn.apache.org/viewvc?rev=980317view=rev
Log:
restore old code which seems to work better
Modified:
geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
Modified:
geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
URL:
http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java?rev=980317r1=980316r2=980317view=diff
==
---
geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
(original)
+++
geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
Thu Jul 29 05:54:33 2010
@@ -76,21 +76,20 @@ public class URLPattern {
if (type == EXACT) {
return pattern;
} else {
-//HashSetString bucket = new HashSetString();
+HashSetString bucket = new HashSetString();
StringBuilder result = new StringBuilder(pattern);
+
// Collect a set of qualifying patterns, depending on the type
of this pattern.
for (URLPattern p : patterns) {
if (type.check(this, p)) {
-//bucket.add(p.pattern);
-result.append(':');
-result.append(p.pattern);
+bucket.add(p.pattern);
}
}
// append the set of qualifying patterns
-/*for (String aBucket : bucket) {
+for (String aBucket : bucket) {
result.append(':');
result.append(aBucket);
-}*/
+}
return result.toString();
}
}
--
Ivan
[jira] Created: (GERONIMO-5481) Add test cases for jsp 2.2 new features into the testsuite.
Add test cases for jsp 2.2 new features into the testsuite. --- Key: GERONIMO-5481 URL: https://issues.apache.org/jira/browse/GERONIMO-5481 Project: Geronimo Issue Type: Task Security Level: public (Regular issues) Components: testsuite Affects Versions: 3.0 Reporter: Guang Zhe Wang Fix For: 3.0 Attachments: jsp2.2-testsuite.patch The new feature tested in this patch includes: configuration element default-content-type and error-on-undeclared-namespace under jsp-property-group in the web.xml. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-5481) Add test cases for jsp 2.2 new features into the testsuite.
[ https://issues.apache.org/jira/browse/GERONIMO-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guang Zhe Wang updated GERONIMO-5481: - Attachment: jsp2.2-testsuite.patch Add test cases for jsp 2.2 new features into the testsuite. --- Key: GERONIMO-5481 URL: https://issues.apache.org/jira/browse/GERONIMO-5481 Project: Geronimo Issue Type: Task Security Level: public(Regular issues) Components: testsuite Affects Versions: 3.0 Reporter: Guang Zhe Wang Fix For: 3.0 Attachments: jsp2.2-testsuite.patch The new feature tested in this patch includes: configuration element default-content-type and error-on-undeclared-namespace under jsp-property-group in the web.xml. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-5482) Add test cases for el 2.2 new features into the testsuite.
[ https://issues.apache.org/jira/browse/GERONIMO-5482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guang Zhe Wang updated GERONIMO-5482: - Component/s: testsuite Add test cases for el 2.2 new features into the testsuite. -- Key: GERONIMO-5482 URL: https://issues.apache.org/jira/browse/GERONIMO-5482 Project: Geronimo Issue Type: Task Security Level: public(Regular issues) Components: testsuite Affects Versions: 3.0 Reporter: Guang Zhe Wang Fix For: 3.0 Attachments: el2.2-testsuite.patch The new feature of EL 2.2 tested in this patch is method invocation with parameters. It runs incorrectly in the tomcat-assembly when the parameter is integer which has been reported in JIRA: GERONIMO-5479. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (GERONIMO-5482) Add test cases for el 2.2 new features into the testsuite.
Add test cases for el 2.2 new features into the testsuite. -- Key: GERONIMO-5482 URL: https://issues.apache.org/jira/browse/GERONIMO-5482 Project: Geronimo Issue Type: Task Security Level: public (Regular issues) Affects Versions: 3.0 Reporter: Guang Zhe Wang Fix For: 3.0 Attachments: el2.2-testsuite.patch The new feature of EL 2.2 tested in this patch is method invocation with parameters. It runs incorrectly in the tomcat-assembly when the parameter is integer which has been reported in JIRA: GERONIMO-5479. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-5482) Add test cases for el 2.2 new features into the testsuite.
[ https://issues.apache.org/jira/browse/GERONIMO-5482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guang Zhe Wang updated GERONIMO-5482: - Attachment: el2.2-testsuite.patch Add test cases for el 2.2 new features into the testsuite. -- Key: GERONIMO-5482 URL: https://issues.apache.org/jira/browse/GERONIMO-5482 Project: Geronimo Issue Type: Task Security Level: public(Regular issues) Components: testsuite Affects Versions: 3.0 Reporter: Guang Zhe Wang Fix For: 3.0 Attachments: el2.2-testsuite.patch The new feature of EL 2.2 tested in this patch is method invocation with parameters. It runs incorrectly in the tomcat-assembly when the parameter is integer which has been reported in JIRA: GERONIMO-5479. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-5453) Add testing about Servlet-3.0's new secuirty features into Testsuite
[ https://issues.apache.org/jira/browse/GERONIMO-5453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12893534#action_12893534 ] Forrest Xia commented on GERONIMO-5453: --- Committed revision 980331 to trunk. thanks LiWenQin! Add testing about Servlet-3.0's new secuirty features into Testsuite Key: GERONIMO-5453 URL: https://issues.apache.org/jira/browse/GERONIMO-5453 Project: Geronimo Issue Type: Task Security Level: public(Regular issues) Components: testsuite Affects Versions: 3.0 Reporter: LiWenQin Assignee: Forrest Xia Priority: Minor Fix For: 3.0 Attachments: GERONIMO-5453.patch, servlet3.0-security-test-modifyTestng.patch, servlet3.0-security-test.patch Add tests into web-testsuite, which makes testing Servlet 3.0's new security features automatically. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (GERONIMO-5483) jetty needs to give jasper the merged metadata complete web.xml
jetty needs to give jasper the merged metadata complete web.xml --- Key: GERONIMO-5483 URL: https://issues.apache.org/jira/browse/GERONIMO-5483 Project: Geronimo Issue Type: Bug Security Level: public (Regular issues) Components: javaee6, Jetty Affects Versions: 3.0 Reporter: David Jencks Assignee: David Jencks Fix For: 3.0 jasper needs a web.xml to check the version for a few settings like enabling el. If there isn't one in the war, we can feed the complete one we construct to jasper as a servlet context attribute. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-5481) Add test cases for jsp 2.2 new features into the testsuite.
[ https://issues.apache.org/jira/browse/GERONIMO-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guang Zhe Wang updated GERONIMO-5481: - Description: The new feature tested in this patch includes: configuration element default-content-type and error-on-undeclared-namespace under jsp-property-group in the web.xml. The default-content-type works incorrectly on tomcat-assembly which has been been reported in JIRA: GERONIMO-5478. was: The new feature tested in this patch includes: configuration element default-content-type and error-on-undeclared-namespace under jsp-property-group in the web.xml. Add test cases for jsp 2.2 new features into the testsuite. --- Key: GERONIMO-5481 URL: https://issues.apache.org/jira/browse/GERONIMO-5481 Project: Geronimo Issue Type: Task Security Level: public(Regular issues) Components: testsuite Affects Versions: 3.0 Reporter: Guang Zhe Wang Fix For: 3.0 Attachments: jsp2.2-testsuite.patch The new feature tested in this patch includes: configuration element default-content-type and error-on-undeclared-namespace under jsp-property-group in the web.xml. The default-content-type works incorrectly on tomcat-assembly which has been been reported in JIRA: GERONIMO-5478. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r980317 - /geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
I'm not sure it would make a difference to the effect of the permission you end
up with, but the code with the hashset eliminates duplicates. I think you can
have duplicates in the everything leftover permission (IIRC
/:path1:path2:path3:) if some paths have different permissions for
different http methods. I don't have an example and haven't looked at more
than this much of the code so I could easily be wrong.
thanks
david jencks
On Jul 28, 2010, at 11:12 PM, Ivan wrote:
Hi, Jarek:
What is the difference between the old one and the new one ? While I did
it in the past, I just feel that there is no need to create an extra HashSet.
2010/7/29 ga...@apache.org
Author: gawor
Date: Thu Jul 29 05:54:33 2010
New Revision: 980317
URL: http://svn.apache.org/viewvc?rev=980317view=rev
Log:
restore old code which seems to work better
Modified:
geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
Modified:
geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
URL:
http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java?rev=980317r1=980316r2=980317view=diff
==
---
geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
(original)
+++
geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
Thu Jul 29 05:54:33 2010
@@ -76,21 +76,20 @@ public class URLPattern {
if (type == EXACT) {
return pattern;
} else {
-//HashSetString bucket = new HashSetString();
+HashSetString bucket = new HashSetString();
StringBuilder result = new StringBuilder(pattern);
+
// Collect a set of qualifying patterns, depending on the type of
this pattern.
for (URLPattern p : patterns) {
if (type.check(this, p)) {
-//bucket.add(p.pattern);
-result.append(':');
-result.append(p.pattern);
+bucket.add(p.pattern);
}
}
// append the set of qualifying patterns
-/*for (String aBucket : bucket) {
+for (String aBucket : bucket) {
result.append(':');
result.append(aBucket);
-}*/
+}
return result.toString();
}
}
--
Ivan
[jira] Assigned: (GERONIMO-5480) Web security does not work on Equinox
[ https://issues.apache.org/jira/browse/GERONIMO-5480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jencks reassigned GERONIMO-5480: -- Assignee: David Jencks Web security does not work on Equinox - Key: GERONIMO-5480 URL: https://issues.apache.org/jira/browse/GERONIMO-5480 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Affects Versions: 3.0-M1 Reporter: Jarek Gawor Assignee: David Jencks Fix For: 3.0 Authentication is not requested when running secure web applications on Geronimo on Equinox. That is, things behave as the user is already authenticated. This can be easily observed with the admin console or security-testsuite. Authentication works as expected on Felix. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r980317 - /geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
Yes, I have considered this while I did the changes, the URLPattern
overrides the equal and hashCode methods, so the result of them are totally
depending on the String field pattern in the class, also each
getQualifiedPattern invocation, a HashSet is passed in. So I am thinking
that the initial patterns have already been filtered. There should be no
duplicate items. Please correct me if I miss anything :-)
I found Jarek opened a JIRA for the web security issue with Equonix
platform, is it caused by this change ?
2010/7/29 David Jencks david_jen...@yahoo.com
I'm not sure it would make a difference to the effect of the permission you
end up with, but the code with the hashset eliminates duplicates. I think
you can have duplicates in the everything leftover permission (IIRC
/:path1:path2:path3:) if some paths have different permissions for
different http methods. I don't have an example and haven't looked at more
than this much of the code so I could easily be wrong.
thanks
david jencks
On Jul 28, 2010, at 11:12 PM, Ivan wrote:
Hi, Jarek:
What is the difference between the old one and the new one ? While I
did it in the past, I just feel that there is no need to create an extra
HashSet.
2010/7/29 ga...@apache.org
Author: gawor
Date: Thu Jul 29 05:54:33 2010
New Revision: 980317
URL: http://svn.apache.org/viewvc?rev=980317view=rev
Log:
restore old code which seems to work better
Modified:
geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
Modified:
geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
URL:
http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java?rev=980317r1=980316r2=980317view=diff
==
---
geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
(original)
+++
geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
Thu Jul 29 05:54:33 2010
@@ -76,21 +76,20 @@ public class URLPattern {
if (type == EXACT) {
return pattern;
} else {
-//HashSetString bucket = new HashSetString();
+HashSetString bucket = new HashSetString();
StringBuilder result = new StringBuilder(pattern);
+
// Collect a set of qualifying patterns, depending on the type
of this pattern.
for (URLPattern p : patterns) {
if (type.check(this, p)) {
-//bucket.add(p.pattern);
-result.append(':');
-result.append(p.pattern);
+bucket.add(p.pattern);
}
}
// append the set of qualifying patterns
-/*for (String aBucket : bucket) {
+for (String aBucket : bucket) {
result.append(':');
result.append(aBucket);
-}*/
+}
return result.toString();
}
}
--
Ivan
--
Ivan
Re: svn commit: r980317 - /geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
On Jul 29, 2010, at 12:06 AM, Ivan wrote:
Yes, I have considered this while I did the changes, the URLPattern overrides
the equal and hashCode methods, so the result of them are totally depending
on the String field pattern in the class, also each getQualifiedPattern
invocation, a HashSet is passed in. So I am thinking that the initial
patterns have already been filtered. There should be no duplicate items.
Please correct me if I miss anything :-)
that sounds reasonable to me maybe Jarek found something we're missing.
I found Jarek opened a JIRA for the web security issue with Equonix platform,
is it caused by this change ?
No, that seems to be because equinox assigns a lot of permissions by default to
a bundle, so it's a bit hard to restrict what users can do. I thought I'd see
if we can prevent equinox from assigning so many permissions. Do you have a
better idea?
thanks
david jencks
2010/7/29 David Jencks david_jen...@yahoo.com
I'm not sure it would make a difference to the effect of the permission you
end up with, but the code with the hashset eliminates duplicates. I think
you can have duplicates in the everything leftover permission (IIRC
/:path1:path2:path3:) if some paths have different permissions for
different http methods. I don't have an example and haven't looked at more
than this much of the code so I could easily be wrong.
thanks
david jencks
On Jul 28, 2010, at 11:12 PM, Ivan wrote:
Hi, Jarek:
What is the difference between the old one and the new one ? While I did
it in the past, I just feel that there is no need to create an extra HashSet.
2010/7/29 ga...@apache.org
Author: gawor
Date: Thu Jul 29 05:54:33 2010
New Revision: 980317
URL: http://svn.apache.org/viewvc?rev=980317view=rev
Log:
restore old code which seems to work better
Modified:
geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
Modified:
geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
URL:
http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java?rev=980317r1=980316r2=980317view=diff
==
---
geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
(original)
+++
geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
Thu Jul 29 05:54:33 2010
@@ -76,21 +76,20 @@ public class URLPattern {
if (type == EXACT) {
return pattern;
} else {
-//HashSetString bucket = new HashSetString();
+HashSetString bucket = new HashSetString();
StringBuilder result = new StringBuilder(pattern);
+
// Collect a set of qualifying patterns, depending on the type
of this pattern.
for (URLPattern p : patterns) {
if (type.check(this, p)) {
-//bucket.add(p.pattern);
-result.append(':');
-result.append(p.pattern);
+bucket.add(p.pattern);
}
}
// append the set of qualifying patterns
-/*for (String aBucket : bucket) {
+for (String aBucket : bucket) {
result.append(':');
result.append(aBucket);
-}*/
+}
return result.toString();
}
}
--
Ivan
--
Ivan
[jira] Created: (GERONIMO-5484) Create a document for JavaEE 6 sample application - EJBTimer
Create a document for JavaEE 6 sample application - EJBTimer - Key: GERONIMO-5484 URL: https://issues.apache.org/jira/browse/GERONIMO-5484 Project: Geronimo Issue Type: Wish Security Level: public (Regular issues) Components: documentation Affects Versions: 3.0-M1 Reporter: Chi Runhua Assignee: Chi Runhua Priority: Minor The document should be as followed: # Application overview # Application content # Application implementation # Get the source code # Build the application # Deploy the application # Test the application -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (GERONIMO-5485) Create a document for JavaEE 6 sample application - singletonejb
Create a document for JavaEE 6 sample application - singletonejb Key: GERONIMO-5485 URL: https://issues.apache.org/jira/browse/GERONIMO-5485 Project: Geronimo Issue Type: Task Security Level: public (Regular issues) Components: documentation Affects Versions: 3.0-M1 Reporter: Chi Runhua The document should be as followed: # Application overview # Application content # Application implementation # Get the source code # Build the application # Deploy the application # Test the application -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (GERONIMO-5482) Add test cases for el 2.2 new features into the testsuite.
[ https://issues.apache.org/jira/browse/GERONIMO-5482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Forrest Xia reassigned GERONIMO-5482: - Assignee: Forrest Xia Add test cases for el 2.2 new features into the testsuite. -- Key: GERONIMO-5482 URL: https://issues.apache.org/jira/browse/GERONIMO-5482 Project: Geronimo Issue Type: Task Security Level: public(Regular issues) Components: testsuite Affects Versions: 3.0 Reporter: Guang Zhe Wang Assignee: Forrest Xia Fix For: 3.0 Attachments: el2.2-testsuite.patch The new feature of EL 2.2 tested in this patch is method invocation with parameters. It runs incorrectly in the tomcat-assembly when the parameter is integer which has been reported in JIRA: GERONIMO-5479. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-5481) Add test cases for jsp 2.2 new features into the testsuite.
[ https://issues.apache.org/jira/browse/GERONIMO-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guang Zhe Wang updated GERONIMO-5481: - Attachment: (was: jsp2.2-testsuite.patch) Add test cases for jsp 2.2 new features into the testsuite. --- Key: GERONIMO-5481 URL: https://issues.apache.org/jira/browse/GERONIMO-5481 Project: Geronimo Issue Type: Task Security Level: public(Regular issues) Components: testsuite Affects Versions: 3.0 Reporter: Guang Zhe Wang Fix For: 3.0 The new feature tested in this patch includes: configuration element default-content-type and error-on-undeclared-namespace under jsp-property-group in the web.xml. The default-content-type works incorrectly on tomcat-assembly which has been been reported in JIRA: GERONIMO-5478. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-5478) JSP 2.2 new configuration element default-content-type under jsp-property-group works incorrectly on tomcat-assembly server.
[ https://issues.apache.org/jira/browse/GERONIMO-5478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guang Zhe Wang updated GERONIMO-5478: - Attachment: (was: jsp2.2-testsuite.patch) JSP 2.2 new configuration element default-content-type under jsp-property-group works incorrectly on tomcat-assembly server. - Key: GERONIMO-5478 URL: https://issues.apache.org/jira/browse/GERONIMO-5478 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: Tomcat Affects Versions: 3.0 Reporter: Guang Zhe Wang Fix For: 3.0 default-content-type is said to specify the default response contentType if the page directive does not include a contentType attribute in the JSP 2.2 spec documentation. So does it mean if the page directive have included a contentType attribute, the configuration in default-content-type will take no effect? In jetty-assembly, it does like this. But in tomcat-assembly, it sends out an exception: org.apache.jasper.JasperException: /defaultCtype/page1.jsp(17,1) Page directive: illegal to have multiple occurrences of contentType with different values (old: text/xml, new: text/html) org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorHandler.java:40) org.apache.jasper.compiler.ErrorDispatcher.dispatch(ErrorDispatcher.java:407) org.apache.jasper.compiler.ErrorDispatcher.jspError(ErrorDispatcher.java:236) org.apache.jasper.compiler.Validator$DirectiveVisitor.visit(Validator.java:133) org.apache.jasper.compiler.Node$PageDirective.accept(Node.java:590) org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2376) org.apache.jasper.compiler.Node$Visitor.visitBody(Node.java:2428) org.apache.jasper.compiler.Node$Visitor.visit(Node.java:2434) org.apache.jasper.compiler.Node$Root.accept(Node.java:475) org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2376) org.apache.jasper.compiler.Validator.validateDirectives(Validator.java:1733) org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:195) org.apache.jasper.compiler.Compiler.compile(Compiler.java:360) org.apache.jasper.compiler.Compiler.compile(Compiler.java:340) org.apache.jasper.compiler.Compiler.compile(Compiler.java:327) org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:594) org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:315) org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:320) org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265) javax.servlet.http.HttpServlet.service(HttpServlet.java:668) I patched the test case I use and uploaded it. You can apply it on trunk. And then build and deploy it on tomcat-assembly to see the result. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMO-5482) Add test cases for el 2.2 new features into the testsuite.
[ https://issues.apache.org/jira/browse/GERONIMO-5482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Forrest Xia resolved GERONIMO-5482. --- Resolution: Fixed Committed this patch to trunk at revision 980368, thanks Guang Zhe for this test case. Add test cases for el 2.2 new features into the testsuite. -- Key: GERONIMO-5482 URL: https://issues.apache.org/jira/browse/GERONIMO-5482 Project: Geronimo Issue Type: Task Security Level: public(Regular issues) Components: testsuite Affects Versions: 3.0 Reporter: Guang Zhe Wang Assignee: Forrest Xia Fix For: 3.0 Attachments: el2.2-testsuite.patch The new feature of EL 2.2 tested in this patch is method invocation with parameters. It runs incorrectly in the tomcat-assembly when the parameter is integer which has been reported in JIRA: GERONIMO-5479. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-5481) Add test cases for jsp 2.2 new features into the testsuite.
[ https://issues.apache.org/jira/browse/GERONIMO-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guang Zhe Wang updated GERONIMO-5481: - Attachment: jsp2.2-testsuite.patch Add test cases for jsp 2.2 new features into the testsuite. --- Key: GERONIMO-5481 URL: https://issues.apache.org/jira/browse/GERONIMO-5481 Project: Geronimo Issue Type: Task Security Level: public(Regular issues) Components: testsuite Affects Versions: 3.0 Reporter: Guang Zhe Wang Fix For: 3.0 Attachments: jsp2.2-testsuite.patch The new feature tested in this patch includes: configuration element default-content-type and error-on-undeclared-namespace under jsp-property-group in the web.xml. The default-content-type works incorrectly on tomcat-assembly which has been been reported in JIRA: GERONIMO-5478. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMO-5481) Add test cases for jsp 2.2 new features into the testsuite.
[ https://issues.apache.org/jira/browse/GERONIMO-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Forrest Xia resolved GERONIMO-5481. --- Resolution: Fixed Committed this patch to trunk at revision 980371, thanks Guang Zhe! Add test cases for jsp 2.2 new features into the testsuite. --- Key: GERONIMO-5481 URL: https://issues.apache.org/jira/browse/GERONIMO-5481 Project: Geronimo Issue Type: Task Security Level: public(Regular issues) Components: testsuite Affects Versions: 3.0 Reporter: Guang Zhe Wang Assignee: Forrest Xia Fix For: 3.0 Attachments: jsp2.2-testsuite.patch The new feature tested in this patch includes: configuration element default-content-type and error-on-undeclared-namespace under jsp-property-group in the web.xml. The default-content-type works incorrectly on tomcat-assembly which has been been reported in JIRA: GERONIMO-5478. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (GERONIMO-5481) Add test cases for jsp 2.2 new features into the testsuite.
[ https://issues.apache.org/jira/browse/GERONIMO-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Forrest Xia reassigned GERONIMO-5481: - Assignee: Forrest Xia Add test cases for jsp 2.2 new features into the testsuite. --- Key: GERONIMO-5481 URL: https://issues.apache.org/jira/browse/GERONIMO-5481 Project: Geronimo Issue Type: Task Security Level: public(Regular issues) Components: testsuite Affects Versions: 3.0 Reporter: Guang Zhe Wang Assignee: Forrest Xia Fix For: 3.0 Attachments: jsp2.2-testsuite.patch The new feature tested in this patch includes: configuration element default-content-type and error-on-undeclared-namespace under jsp-property-group in the web.xml. The default-content-type works incorrectly on tomcat-assembly which has been been reported in JIRA: GERONIMO-5478. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-5478) JSP 2.2 new configuration element default-content-type under jsp-property-group works incorrectly on tomcat-assembly server.
[ https://issues.apache.org/jira/browse/GERONIMO-5478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guang Zhe Wang updated GERONIMO-5478: - Patch Info: (was: [Patch Available]) Description: default-content-type is said to specify the default response contentType if the page directive does not include a contentType attribute in the JSP 2.2 spec documentation. So does it mean if the page directive have included a contentType attribute, the configuration in default-content-type will take no effect? In jetty-assembly, it does like this. But in tomcat-assembly, it sends out an exception: org.apache.jasper.JasperException: /defaultCtype/page1.jsp(17,1) Page directive: illegal to have multiple occurrences of contentType with different values (old: text/xml, new: text/html) org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorHandler.java:40) org.apache.jasper.compiler.ErrorDispatcher.dispatch(ErrorDispatcher.java:407) org.apache.jasper.compiler.ErrorDispatcher.jspError(ErrorDispatcher.java:236) org.apache.jasper.compiler.Validator$DirectiveVisitor.visit(Validator.java:133) org.apache.jasper.compiler.Node$PageDirective.accept(Node.java:590) org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2376) org.apache.jasper.compiler.Node$Visitor.visitBody(Node.java:2428) org.apache.jasper.compiler.Node$Visitor.visit(Node.java:2434) org.apache.jasper.compiler.Node$Root.accept(Node.java:475) org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2376) org.apache.jasper.compiler.Validator.validateDirectives(Validator.java:1733) org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:195) org.apache.jasper.compiler.Compiler.compile(Compiler.java:360) org.apache.jasper.compiler.Compiler.compile(Compiler.java:340) org.apache.jasper.compiler.Compiler.compile(Compiler.java:327) org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:594) org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:315) org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:320) org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265) javax.servlet.http.HttpServlet.service(HttpServlet.java:668) The testsuite I wrote has been committed at revision 980371 which is under testsuite/javaee6-testsuite/jsp2.2-test. was: default-content-type is said to specify the default response contentType if the page directive does not include a contentType attribute in the JSP 2.2 spec documentation. So does it mean if the page directive have included a contentType attribute, the configuration in default-content-type will take no effect? In jetty-assembly, it does like this. But in tomcat-assembly, it sends out an exception: org.apache.jasper.JasperException: /defaultCtype/page1.jsp(17,1) Page directive: illegal to have multiple occurrences of contentType with different values (old: text/xml, new: text/html) org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorHandler.java:40) org.apache.jasper.compiler.ErrorDispatcher.dispatch(ErrorDispatcher.java:407) org.apache.jasper.compiler.ErrorDispatcher.jspError(ErrorDispatcher.java:236) org.apache.jasper.compiler.Validator$DirectiveVisitor.visit(Validator.java:133) org.apache.jasper.compiler.Node$PageDirective.accept(Node.java:590) org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2376) org.apache.jasper.compiler.Node$Visitor.visitBody(Node.java:2428) org.apache.jasper.compiler.Node$Visitor.visit(Node.java:2434) org.apache.jasper.compiler.Node$Root.accept(Node.java:475) org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2376) org.apache.jasper.compiler.Validator.validateDirectives(Validator.java:1733) org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:195) org.apache.jasper.compiler.Compiler.compile(Compiler.java:360) org.apache.jasper.compiler.Compiler.compile(Compiler.java:340) org.apache.jasper.compiler.Compiler.compile(Compiler.java:327) org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:594) org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:315) org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:320) org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265) javax.servlet.http.HttpServlet.service(HttpServlet.java:668) I patched the test case I use and uploaded it. You can apply it on trunk. And then build and deploy it on tomcat-assembly to see the result. JSP 2.2 new configuration element default-content-type under jsp-property-group works incorrectly on tomcat-assembly server.
[BUILD] trunk: Failed for Revision: 980341
Geronimo Revision: 980341 built with tests included See the full build-0300.log file at http://people.apache.org/builds/geronimo/server/binaries/trunk/20100729/build-0300.log Download the binaries from http://people.apache.org/builds/geronimo/server/binaries/trunk/20100729 [INFO] BUILD SUCCESSFUL [INFO] [INFO] Total time: 41 minutes 28 seconds [INFO] Finished at: Thu Jul 29 03:53:10 EDT 2010 [INFO] Final Memory: 518M/989M [INFO] TESTSUITE RESULTS (Failures only) = Assembly: tomcat = See full test results and logs at http://people.apache.org/builds/geronimo/server/binaries/trunk/20100729/logs-0300-tomcat/ Running TestSuite Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 28.876 sec FAILURE! Running TestSuite Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.457 sec FAILURE! -- Running TestSuite Tests run: 22, Failures: 14, Errors: 0, Skipped: 0, Time elapsed: 8.303 sec FAILURE! Assembly: jetty = See full test results and logs at http://people.apache.org/builds/geronimo/server/binaries/trunk/20100729/logs-0300-jetty/ Running TestSuite Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 22.941 sec FAILURE! Running TestSuite Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.676 sec FAILURE! -- Running TestSuite Tests run: 22, Failures: 14, Errors: 0, Skipped: 0, Time elapsed: 8.427 sec FAILURE! Samples: trunk = Log: http://people.apache.org/builds/geronimo/server/binaries/trunk/20100729/samples-0300.log Build status: FAILED
[jira] Updated: (GERONIMO-5479) EL 2.2 new feature: method invocation with parameters works incorrectly when the parameter is Integer.
[
https://issues.apache.org/jira/browse/GERONIMO-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guang Zhe Wang updated GERONIMO-5479:
-
Environment: OS: Windows XP SP3, JDK: sun-jdk-1.6.0_18
Description:
I create a simple JSF app to test this new feature. You can check it out from
trunk: testsuite/javaee6-testsuite/el2.2-test which has been committed at
revision 980368.
In the managed bean User class, I defined a method:
public int calYear(int x) {
return (age + x);
}
and in the page I call it with #{user.calYear(5)}, in both tomcat and jetty
assemblies an error occurs:
java.lang.NoSuchMethodException:
org.apache.geronimo.testsuite.el22.app.User.calYear(java.lang.Long) which
implies that the container recognizes 5 as Long.
The error stack:
javax.faces.FacesException: java.lang.NoSuchMethodException:
org.apache.geronimo.testsuite.el22.app.User.calYear(java.lang.Long)
at
org.apache.myfaces.shared_impl.context.ExceptionHandlerImpl.wrap(ExceptionHandlerImpl.java:241)
at
org.apache.myfaces.shared_impl.context.ExceptionHandlerImpl.handle(ExceptionHandlerImpl.java:156)
at
org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:222)
at javax.faces.webapp.FacesServlet.service(FacesServlet.java:191)
at
org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:532)
at
org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:456)
at
org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:230)
at
org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:966)
at
org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:391)
at
org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)
at
org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:902)
at
org.apache.geronimo.jetty8.handler.GeronimoWebAppContext.doScope(GeronimoWebAppContext.java:125)
at
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:117)
at
org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:245)
at
org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:126)
at
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:113)
at org.eclipse.jetty.server.Server.handle(Server.java:338)
at
org.eclipse.jetty.server.HttpConnection.handleRequest(HttpConnection.java:568)
at
org.eclipse.jetty.server.HttpConnection$RequestHandler.content(HttpConnection.java:1010)
at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:775)
at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:228)
at
org.eclipse.jetty.server.HttpConnection.handle(HttpConnection.java:403)
at
org.eclipse.jetty.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:474)
at org.apache.geronimo.pool.ThreadPool$1.run(ThreadPool.java:214)
at
org.apache.geronimo.pool.ThreadPool$ContextClassLoaderRunnable.run(ThreadPool.java:344)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown
Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)
Caused by: java.lang.NoSuchMethodException:
org.apache.geronimo.testsuite.el22.app.User.calYear(java.lang.Long)
at java.lang.Class.getMethod(Unknown Source)
at javax.el.BeanELResolver.invoke(BeanELResolver.java:394)
at javax.el.CompositeELResolver.invoke(CompositeELResolver.java:228)
at org.apache.el.parser.AstValue.getValue(AstValue.java:158)
at
org.apache.el.ValueExpressionImpl.getValue(ValueExpressionImpl.java:192)
at
org.apache.myfaces.view.facelets.el.TagValueExpression.getValue(TagValueExpression.java:84)
at
javax.faces.component._DeltaStateHelper.eval(_DeltaStateHelper.java:243)
at javax.faces.component.UIOutput.getValue(UIOutput.java:71)
at
org.apache.myfaces.shared_impl.renderkit.RendererUtils.getValue(RendererUtils.java:349)
at
org.apache.myfaces.shared_impl.renderkit.RendererUtils.getStringValue(RendererUtils.java:301)
at
org.apache.myfaces.shared_impl.renderkit.html.HtmlTextRendererBase.renderOutput(HtmlTextRendererBase.java:81)
at
org.apache.myfaces.shared_impl.renderkit.html.HtmlTextRendererBase.encodeEnd(HtmlTextRendererBase.java:68)
at
javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:486)
at javax.faces.component.UIComponent.encodeAll(UIComponent.java:618)
at javax.faces.component.UIComponent.encodeAll(UIComponent.java:614)
at javax.faces.component.UIComponent.encodeAll(UIComponent.java:614)
at
Compilation error in OpenEJB :: Builder
I am getting a compilation failure in OpenEJB Builder module. Anyone else seeing this error? I am at svn rev 980390. Error message given below... [ERROR] BUILD FAILURE [INFO] [INFO] Compilation failure C:\G\server\trunk\plugins\openejb\geronimo-openejb-builder\src\main\java\org\apache\geronimo\openejb\deployment\EjbRefBuilder.java:[128,30] build(org.apache.openejb.jee.JndiConsumer,java.lang.String,java.lang.String) in org.apache.openejb.config.JndiEncInfoBuilder cannot be applied to (org.apache.openejb.jee.JndiConsumer,java.lang.String,java.lang.String,org.apache.openejb.assembler.classic.JndiEncInfo,org.apache.openejb.assembler.classic.JndiEncInfo) -- Vamsi
Re: [VOTE] External tomcat-parent-6.0.29.0
+1 Was able to build the tag and the jars looked like they have the required License/Notice files. -Donald On 7/23/10 7:28 AM, Delos wrote: This voting is for mavenized tomcat 6.0.29. Following what we did to tomcat 6.0.20, we are using a forked copy of tomcat derived from the tomcat 6.0.29 release, built with maven, with maven dependencies, etc etc. Besides, we also applied some patches which haven't been included in tomcat 6.0.29. Based on tomcat 6.0.29 tag, I also applied another couple of patches: GERONIMO-3451 'Restricted listeners property file not found' error logged during Tomcat server startup GERONIMO-4685 Include patches for revision #790742 Staging repo: https://repository.apache.org/content/repositories/orgapachegeronimo-028/ svn tag at: http://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-6.0.29.0/ [ ] +1 go for it [ ] 0 [ ] -1 whoa, hold on a minute Vote open 72 hours thanks a lot! -- Best Regards, Delos
[jira] Updated: (GERONIMO-5481) Add test cases for jsp 2.2 new features into the testsuite.
[ https://issues.apache.org/jira/browse/GERONIMO-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wang Guang Zhe updated GERONIMO-5481: - Description: The new feature tested in this patch includes: configuration element default-content-type and error-on-undeclared-namespace under jsp-property-group in the web.xml. The default-content-type works incorrectly on tomcat-assembly which has been reported in JIRA: GERONIMO-5478. was: The new feature tested in this patch includes: configuration element default-content-type and error-on-undeclared-namespace under jsp-property-group in the web.xml. The default-content-type works incorrectly on tomcat-assembly which has been been reported in JIRA: GERONIMO-5478. Add test cases for jsp 2.2 new features into the testsuite. --- Key: GERONIMO-5481 URL: https://issues.apache.org/jira/browse/GERONIMO-5481 Project: Geronimo Issue Type: Task Security Level: public(Regular issues) Components: testsuite Affects Versions: 3.0 Reporter: Wang Guang Zhe Assignee: Forrest Xia Fix For: 3.0 Attachments: jsp2.2-testsuite.patch The new feature tested in this patch includes: configuration element default-content-type and error-on-undeclared-namespace under jsp-property-group in the web.xml. The default-content-type works incorrectly on tomcat-assembly which has been reported in JIRA: GERONIMO-5478. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r980317 - /geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
The end result with the old code was that less Permission objects were
created which made things easier to debug and it's a bit better from
performance point of view.
Jarek
On Thu, Jul 29, 2010 at 3:06 AM, Ivan xhh...@gmail.com wrote:
Yes, I have considered this while I did the changes, the URLPattern
overrides the equal and hashCode methods, so the result of them are totally
depending on the String field pattern in the class, also each
getQualifiedPattern invocation, a HashSet is passed in. So I am thinking
that the initial patterns have already been filtered. There should be no
duplicate items. Please correct me if I miss anything :-)
I found Jarek opened a JIRA for the web security issue with Equonix
platform, is it caused by this change ?
2010/7/29 David Jencks david_jen...@yahoo.com
I'm not sure it would make a difference to the effect of the permission
you end up with, but the code with the hashset eliminates duplicates. I
think you can have duplicates in the everything leftover permission (IIRC
/:path1:path2:path3:) if some paths have different permissions for
different http methods. I don't have an example and haven't looked at more
than this much of the code so I could easily be wrong.
thanks
david jencks
On Jul 28, 2010, at 11:12 PM, Ivan wrote:
Hi, Jarek:
What is the difference between the old one and the new one ? While I
did it in the past, I just feel that there is no need to create an extra
HashSet.
2010/7/29 ga...@apache.org
Author: gawor
Date: Thu Jul 29 05:54:33 2010
New Revision: 980317
URL: http://svn.apache.org/viewvc?rev=980317view=rev
Log:
restore old code which seems to work better
Modified:
geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
Modified:
geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
URL:
http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java?rev=980317r1=980316r2=980317view=diff
==
---
geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
(original)
+++
geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
Thu Jul 29 05:54:33 2010
@@ -76,21 +76,20 @@ public class URLPattern {
if (type == EXACT) {
return pattern;
} else {
- //HashSetString bucket = new HashSetString();
+ HashSetString bucket = new HashSetString();
StringBuilder result = new StringBuilder(pattern);
+
// Collect a set of qualifying patterns, depending on the
type of this pattern.
for (URLPattern p : patterns) {
if (type.check(this, p)) {
- //bucket.add(p.pattern);
- result.append(':');
- result.append(p.pattern);
+ bucket.add(p.pattern);
}
}
// append the set of qualifying patterns
- /*for (String aBucket : bucket) {
+ for (String aBucket : bucket) {
result.append(':');
result.append(aBucket);
- }*/
+ }
return result.toString();
}
}
--
Ivan
--
Ivan
[BUILD] trunk: Failed for Revision: 980434
Geronimo Revision: 980434 built with tests included See the full build-0900.log file at http://people.apache.org/builds/geronimo/server/binaries/trunk/20100729/build-0900.log Download the binaries from http://people.apache.org/builds/geronimo/server/binaries/trunk/20100729 [INFO] BUILD SUCCESSFUL [INFO] [INFO] Total time: 41 minutes 28 seconds [INFO] Finished at: Thu Jul 29 09:46:24 EDT 2010 [INFO] Final Memory: 492M/997M [INFO] TESTSUITE RESULTS (Failures only) = Assembly: tomcat = See full test results and logs at http://people.apache.org/builds/geronimo/server/binaries/trunk/20100729/logs-0900-tomcat/ Running TestSuite Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 23.754 sec FAILURE! Running TestSuite Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.433 sec FAILURE! -- Running TestSuite Tests run: 22, Failures: 14, Errors: 0, Skipped: 0, Time elapsed: 7.464 sec FAILURE! Assembly: jetty = See full test results and logs at http://people.apache.org/builds/geronimo/server/binaries/trunk/20100729/logs-0900-jetty/ Running TestSuite Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 22.579 sec FAILURE! Running TestSuite Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.446 sec FAILURE! -- Running TestSuite Tests run: 22, Failures: 14, Errors: 0, Skipped: 0, Time elapsed: 8.498 sec FAILURE! Samples: trunk = Log: http://people.apache.org/builds/geronimo/server/binaries/trunk/20100729/samples-0900.log Build status: FAILED
[jira] Commented: (GERONIMO-5480) Web security does not work on Equinox
[ https://issues.apache.org/jira/browse/GERONIMO-5480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12893651#action_12893651 ] Jarek Gawor commented on GERONIMO-5480: --- Just to provide some more background on this issue. On Felix each bundle gets a ProtectionDomain with the default permissions. On Equinox each bundle gets a ProtectionDomain with default permissions + AllPermissions. The ContextManager class (in geronimo-security bundle) sets up a default Subject (EMPTY). That subject gets the protection domain of the geronimo-security bundle. During web authentication the different Web*Permissions are checked against the default subject. Since the subject on Equinox contains AllPermissions all permission requests are granted and that's why the user is never prompted for username/password info. Web security does not work on Equinox - Key: GERONIMO-5480 URL: https://issues.apache.org/jira/browse/GERONIMO-5480 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Affects Versions: 3.0-M1 Reporter: Jarek Gawor Assignee: David Jencks Fix For: 3.0 Authentication is not requested when running secure web applications on Geronimo on Equinox. That is, things behave as the user is already authenticated. This can be easily observed with the admin console or security-testsuite. Authentication works as expected on Felix. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[BUILD] branches/2.2: Failed for Revision: 980139
Geronimo Revision: 980139 built with tests included See the full build-1400.log file at http://people.apache.org/builds/geronimo/server/binaries/2.2/20100728/build-1400.log Download the binaries from http://people.apache.org/builds/geronimo/server/binaries/2.2/20100728 [INFO] BUILD SUCCESSFUL [INFO] [INFO] Total time: 55 minutes 37 seconds [INFO] Finished at: Wed Jul 28 14:59:47 EDT 2010 [INFO] Final Memory: 335M/1013M [INFO] TESTSUITE RESULTS (Failures only) = Assembly: tomcat = See full test results and logs at http://people.apache.org/builds/geronimo/server/binaries/2.2/20100728/logs-1400-tomcat/ [INFO] Running TestSuite [INFO] Tests run: 118, Failures: 1, Errors: 0, Skipped: 117, Time elapsed: 23.852 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 38, Failures: 1, Errors: 0, Skipped: 37, Time elapsed: 21.572 sec FAILURE! -- [INFO] Running TestSuite [INFO] Tests run: 3, Failures: 1, Errors: 0, Skipped: 2, Time elapsed: 21.079 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 4, Failures: 1, Errors: 0, Skipped: 3, Time elapsed: 21.088 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 4, Failures: 1, Errors: 0, Skipped: 3, Time elapsed: 21.059 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 9, Failures: 1, Errors: 0, Skipped: 8, Time elapsed: 21.206 sec FAILURE! -- [INFO] Running TestSuite [INFO] Tests run: 3, Failures: 1, Errors: 0, Skipped: 2, Time elapsed: 21.037 sec FAILURE! -- [INFO] Running TestSuite [INFO] Tests run: 11, Failures: 1, Errors: 0, Skipped: 10, Time elapsed: 21.215 sec FAILURE! Assembly: jetty = See full test results and logs at http://people.apache.org/builds/geronimo/server/binaries/2.2/20100728/logs-1400-jetty/ [INFO] Running TestSuite [INFO] Tests run: 118, Failures: 1, Errors: 0, Skipped: 117, Time elapsed: 22.38 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 38, Failures: 1, Errors: 0, Skipped: 37, Time elapsed: 21.453 sec FAILURE! -- [INFO] Running TestSuite [INFO] Tests run: 3, Failures: 1, Errors: 0, Skipped: 2, Time elapsed: 21.075 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 4, Failures: 1, Errors: 0, Skipped: 3, Time elapsed: 21.09 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 4, Failures: 1, Errors: 0, Skipped: 3, Time elapsed: 21.218 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 9, Failures: 1, Errors: 0, Skipped: 8, Time elapsed: 21.246 sec FAILURE! -- [INFO] Running TestSuite [INFO] Tests run: 3, Failures: 1, Errors: 0, Skipped: 2, Time elapsed: 21.092 sec FAILURE! -- [INFO] Running TestSuite [INFO] Tests run: 11, Failures: 1, Errors: 0, Skipped: 10, Time elapsed: 21.154 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 38, Failures: 1, Errors: 0, Skipped: 37, Time elapsed: 21.53 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 6, Failures: 1, Errors: 0, Skipped: 5, Time elapsed: 21.062 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 3, Failures: 1, Errors: 0, Skipped: 2, Time elapsed: 21.04 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 3, Failures: 1, Errors: 0, Skipped: 2, Time elapsed: 21.13 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 3, Failures: 1, Errors: 0, Skipped: 2, Time elapsed: 21.048 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 5, Failures: 1, Errors: 0, Skipped: 4, Time elapsed: 21.13 sec FAILURE! Samples: branches/2.2 = Log: http://people.apache.org/builds/geronimo/server/binaries/2.2/20100728/samples-1400.log Build status: FAILED
[BUILD] trunk: Failed for Revision: 980542
Geronimo Revision: 980542 built with tests included See the full build-1500.log file at http://people.apache.org/builds/geronimo/server/binaries/trunk/20100729/build-1500.log Download the binaries from http://people.apache.org/builds/geronimo/server/binaries/trunk/20100729 [INFO] BUILD SUCCESSFUL [INFO] [INFO] Total time: 36 minutes 46 seconds [INFO] Finished at: Thu Jul 29 15:41:44 EDT 2010 [INFO] Final Memory: 497M/996M [INFO] TESTSUITE RESULTS (Failures only) = Assembly: tomcat = See full test results and logs at http://people.apache.org/builds/geronimo/server/binaries/trunk/20100729/logs-1500-tomcat/ Running TestSuite Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 23.047 sec FAILURE! Running TestSuite Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.414 sec FAILURE! -- Running TestSuite Tests run: 22, Failures: 14, Errors: 0, Skipped: 0, Time elapsed: 7.924 sec FAILURE! Assembly: jetty = See full test results and logs at http://people.apache.org/builds/geronimo/server/binaries/trunk/20100729/logs-1500-jetty/ Running TestSuite Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 21.855 sec FAILURE! Running TestSuite Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.46 sec FAILURE! -- Running TestSuite Tests run: 22, Failures: 14, Errors: 0, Skipped: 0, Time elapsed: 7.795 sec FAILURE! [org.apache.geronimo.mavenplugins.geronimo.ServerProxy] : Connecting to: service:jmx:rmi://localhost/jndi/rmi://localhost:1099/JMXConnector [org.apache.geronimo.mavenplugins.geronimo.ServerProxy] : Connection failure; ignoring: java.io.IOException: Failed to retrieve RMIServer stub: javax.naming.ServiceUnavailableException [Root exception is java.rmi.ConnectException: Connection refused to host: localhost; nested exception is: java.net.ConnectException: Connection refused] [org.apache.geronimo.mavenplugins.geronimo.ServerProxy] : Connecting to: service:jmx:rmi://localhost/jndi/rmi://localhost:1099/JMXConnector [org.apache.geronimo.mavenplugins.geronimo.ServerProxy] : Connection failure; ignoring: java.io.IOException: Failed to retrieve RMIServer stub: javax.naming.ServiceUnavailableException [Root exception is java.rmi.ConnectException: Connection refused to host: localhost; nested exception is: java.net.ConnectException: Connection refused] [org.apache.geronimo.mavenplugins.geronimo.ServerProxy] : Connecting to: service:jmx:rmi://localhost/jndi/rmi://localhost:1099/JMXConnector [org.apache.geronimo.mavenplugins.geronimo.ServerProxy] : Connection failure; ignoring: java.io.IOException: Failed to retrieve RMIServer stub: javax.naming.ServiceUnavailableException [Root exception is java.rmi.ConnectException: Connection refused to host: localhost; nested exception is: java.net.ConnectException: Connection refused] [org.apache.geronimo.mavenplugins.geronimo.ServerProxy] : Connecting to: service:jmx:rmi://localhost/jndi/rmi://localhost:1099/JMXConnector [org.apache.geronimo.mavenplugins.geronimo.ServerProxy] : Connection failure; ignoring: java.io.IOException: Failed to retrieve RMIServer stub: javax.naming.ServiceUnavailableException [Root exception is java.rmi.ConnectException: Connection refused to host: localhost; nested exception is: java.net.ConnectException: Connection refused] [org.apache.geronimo.mavenplugins.geronimo.ServerProxy] : Connecting to: service:jmx:rmi://localhost/jndi/rmi://localhost:1099/JMXConnector [org.apache.geronimo.mavenplugins.geronimo.ServerProxy] : Connection failure; ignoring: java.io.IOException: Failed to retrieve RMIServer stub: javax.naming.ServiceUnavailableException [Root exception is java.rmi.ConnectException: Connection refused to host: localhost; nested exception is: java.net.ConnectException: Connection refused] [org.apache.geronimo.mavenplugins.geronimo.ServerProxy] : Connecting to: service:jmx:rmi://localhost/jndi/rmi://localhost:1099/JMXConnector [org.apache.geronimo.mavenplugins.geronimo.ServerProxy] : Connection failure; ignoring: java.io.IOException: Failed to retrieve RMIServer stub: javax.naming.ServiceUnavailableException [Root exception is java.rmi.ConnectException: Connection refused to host: localhost; nested exception is: java.net.ConnectException: Connection refused] [org.apache.geronimo.mavenplugins.geronimo.ServerProxy] : Connecting to: service:jmx:rmi://localhost/jndi/rmi://localhost:1099/JMXConnector [org.apache.geronimo.mavenplugins.geronimo.ServerProxy] : Connection failure; ignoring: java.io.IOException: Failed to retrieve RMIServer stub: javax.naming.ServiceUnavailableException [Root exception is java.rmi.ConnectException: Connection refused to host
[jira] Commented: (GERONIMO-5480) Web security does not work on Equinox
[ https://issues.apache.org/jira/browse/GERONIMO-5480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12893823#action_12893823 ] Jarek Gawor commented on GERONIMO-5480: --- Btw, as far as I can tell the PermissionAdmin/ConditionalPermissionAdmin services on Equinox add AllPermissions to every bundle. These services are not present on Felix. Web security does not work on Equinox - Key: GERONIMO-5480 URL: https://issues.apache.org/jira/browse/GERONIMO-5480 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Affects Versions: 3.0-M1 Reporter: Jarek Gawor Assignee: David Jencks Fix For: 3.0 Authentication is not requested when running secure web applications on Geronimo on Equinox. That is, things behave as the user is already authenticated. This can be easily observed with the admin console or security-testsuite. Authentication works as expected on Felix. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r980317 - /geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
Could you please show me any details for it ? I would like to get this
lesson learn. Thanks !
2010/7/29 Jarek Gawor jga...@gmail.com
The end result with the old code was that less Permission objects were
created which made things easier to debug and it's a bit better from
performance point of view.
Jarek
On Thu, Jul 29, 2010 at 3:06 AM, Ivan xhh...@gmail.com wrote:
Yes, I have considered this while I did the changes, the URLPattern
overrides the equal and hashCode methods, so the result of them are
totally
depending on the String field pattern in the class, also each
getQualifiedPattern invocation, a HashSet is passed in. So I am thinking
that the initial patterns have already been filtered. There should be no
duplicate items. Please correct me if I miss anything :-)
I found Jarek opened a JIRA for the web security issue with Equonix
platform, is it caused by this change ?
2010/7/29 David Jencks david_jen...@yahoo.com
I'm not sure it would make a difference to the effect of the permission
you end up with, but the code with the hashset eliminates duplicates. I
think you can have duplicates in the everything leftover permission
(IIRC
/:path1:path2:path3:) if some paths have different permissions
for
different http methods. I don't have an example and haven't looked at
more
than this much of the code so I could easily be wrong.
thanks
david jencks
On Jul 28, 2010, at 11:12 PM, Ivan wrote:
Hi, Jarek:
What is the difference between the old one and the new one ? While I
did it in the past, I just feel that there is no need to create an extra
HashSet.
2010/7/29 ga...@apache.org
Author: gawor
Date: Thu Jul 29 05:54:33 2010
New Revision: 980317
URL: http://svn.apache.org/viewvc?rev=980317view=rev
Log:
restore old code which seems to work better
Modified:
geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
Modified:
geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
URL:
http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java?rev=980317r1=980316r2=980317view=diff
==
---
geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
(original)
+++
geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java
Thu Jul 29 05:54:33 2010
@@ -76,21 +76,20 @@ public class URLPattern {
if (type == EXACT) {
return pattern;
} else {
-//HashSetString bucket = new HashSetString();
+HashSetString bucket = new HashSetString();
StringBuilder result = new StringBuilder(pattern);
+
// Collect a set of qualifying patterns, depending on the
type of this pattern.
for (URLPattern p : patterns) {
if (type.check(this, p)) {
-//bucket.add(p.pattern);
-result.append(':');
-result.append(p.pattern);
+bucket.add(p.pattern);
}
}
// append the set of qualifying patterns
-/*for (String aBucket : bucket) {
+for (String aBucket : bucket) {
result.append(':');
result.append(aBucket);
-}*/
+}
return result.toString();
}
}
--
Ivan
--
Ivan
--
Ivan
[jira] Updated: (GERONIMO-5259) Annoying access denied security exceptions for oenwebbeans while java2 security is enabled.
[ https://issues.apache.org/jira/browse/GERONIMO-5259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YING WANG updated GERONIMO-5259: Attachment: AnnotationLiteral.path2 Please help review. anonymous class is used to avoid TCK complains. Annoying access denied security exceptions for oenwebbeans while java2 security is enabled. - Key: GERONIMO-5259 URL: https://issues.apache.org/jira/browse/GERONIMO-5259 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: specs Affects Versions: 3.0 Reporter: YING WANG Assignee: Donald Woods Priority: Minor Fix For: 3.0-M1 Attachments: 5259.patch, AnnotationLiteral.java, AnnotationLiteral.path2 Hello neighbors, I am from the openwebbean project. while I am fixing owb-312 (https://issues.apache.org/jira/browse/OWB-312), I found some of AccessControlExceptions are fired fom javax.enterprise.util.AnnotationLiteral in jcdi api. Fixing the issue in OWB will be nasty since it is referenced all over the owb code. Could we add doPrivileged block around Class.setAccess() and getDeclaredMethods calls in this class? Thanks in advnace. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [VOTE] External tomcat-parent-6.0.29.0
Thanks, Donald! 2010/7/29 Donald Woods dwo...@apache.org +1 Was able to build the tag and the jars looked like they have the required License/Notice files. -Donald On 7/23/10 7:28 AM, Delos wrote: This voting is for mavenized tomcat 6.0.29. Following what we did to tomcat 6.0.20, we are using a forked copy of tomcat derived from the tomcat 6.0.29 release, built with maven, with maven dependencies, etc etc. Besides, we also applied some patches which haven't been included in tomcat 6.0.29. Based on tomcat 6.0.29 tag, I also applied another couple of patches: GERONIMO-3451 'Restricted listeners property file not found' error logged during Tomcat server startup GERONIMO-4685 Include patches for revision #790742 Staging repo: https://repository.apache.org/content/repositories/orgapachegeronimo-028/ svn tag at: http://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-6.0.29.0/ [ ] +1 go for it [ ] 0 [ ] -1 whoa, hold on a minute Vote open 72 hours thanks a lot! -- Best Regards, Delos -- Best Regards, Delos
Re: [VOTE] maven-plugins 1.1 for Geronimo Eclipse Plugins
We need to release the maven plugin to fix JIRA GERONIMODEVTOOLS-658https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-658. Could PMC members take a look at this? 2010/7/29 Delos dait...@gmail.com my own +1. Is there anyone can take a look at this? 2010/7/27 Delos dait...@gmail.com Hi all, Hope you're not surprised at this voting. Actually, I have discussed it with Kevan and Donald. As part of GEP, maven-eclipsepde-plugin helps to convert eclipse plugins to maven dependencies and add them into artifact dependency list.But now, we have to update the plugin to accommodate new requirements. See more details here https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-658 I will prompt the new plugins once it passes the voting. https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-658 Staging repo: https://repository.apache.org/content/repositories/orgapachegeronimo-030/ svn tag at: http://svn.apache.org/repos/asf/geronimo/devtools/maven-plugins/tags/1.1/ [ ] +1 go for it [ ] 0 [ ] -1 whoa, hold on a minute -- Best Regards, Delos -- Best Regards, Delos -- Best Regards, Delos
[BUILD] trunk: Failed for Revision: 980625
Geronimo Revision: 980625 built with tests included
See the full build-2100.log file at
http://people.apache.org/builds/geronimo/server/binaries/trunk/20100729/build-2100.log
Download the binaries from
http://people.apache.org/builds/geronimo/server/binaries/trunk/20100729
[INFO] BUILD SUCCESSFUL
[INFO]
[INFO] Total time: 41 minutes 7 seconds
[INFO] Finished at: Thu Jul 29 21:45:39 EDT 2010
[INFO] Final Memory: 448M/1013M
[INFO]
TESTSUITE RESULTS (Failures only)
=
Assembly: tomcat
=
See full test results and logs at
http://people.apache.org/builds/geronimo/server/binaries/trunk/20100729/logs-2100-tomcat/
Downloading:
http://maven.rtp.raleigh.ibm.com/nexus-proxy//org/apache/maven/surefire/surefire-booter/2.5/surefire-booter-2.5.jar
262K downloaded (plexus-utils-1.5.9.jar)
313K downloaded (surefire-booter-2.5.jar)
Downloading:
file:///home/geronimo/.m2/jtidy.repository/org/apache/maven/surefire/surefire-api/2.5/surefire-api-2.5.jar
[INFO] Unable to find resource 'org.apache.maven.surefire:surefire-api:jar:2.5'
in repository local (file:///home/geronimo/.m2/jtidy.repository)
Downloading:
http://maven.rtp.raleigh.ibm.com/nexus-proxy//org/apache/maven/surefire/surefire-api/2.5/surefire-api-2.5.jar
557K downloaded (surefire-api-2.5.jar)
[WARNING] DEPRECATED [systemProperties]: Use systemPropertyVariables instead.
[INFO] [failsafe:integration-test {execution: integration-test}]
Downloading:
http://maven.rtp.raleigh.ibm.com/nexus-proxy//org/apache/maven/surefire/surefire-testng/2.5/surefire-testng-2.5.pom
2K downloaded (surefire-testng-2.5.pom)
Downloading:
http://maven.rtp.raleigh.ibm.com/nexus-proxy//org/apache/maven/surefire/surefire-providers/2.5/surefire-providers-2.5.pom
1K downloaded (surefire-providers-2.5.pom)
Downloading:
http://maven.rtp.raleigh.ibm.com/nexus-proxy//org/apache/maven/surefire/surefire-testng/2.5/surefire-testng-2.5.jar
26K downloaded (surefire-testng-2.5.jar)
[INFO] Failsafe report directory:
/home/geronimo/geronimo/trunk/testsuite/commands-testsuite/deploy/target/failsafe-reports
---
T E S T S
---
Running TestSuite
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 125.409 sec
Results :
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] [ianal:verify-legal-files {execution: default}]
[WARNING] Skipping verification of legal files in artifacts:
[WARNING] org.apache.geronimo.testsuite:deploy:jar:3.0-SNAPSHOT
[INFO] [geronimo:stop-server {execution: stop-geronimo}]
[org.apache.geronimo.mavenplugins.geronimo.ServerProxy] : Initialized with URL:
service:jmx:rmi://localhost/jndi/rmi://localhost:1099/JMXConnector,
environment: {jmx.remote.credentials=[Ljava.lang.String;@1dfb840}
[org.apache.geronimo.mavenplugins.geronimo.ServerProxy] : Connecting to:
service:jmx:rmi://localhost/jndi/rmi://localhost:1099/JMXConnector
[org.apache.geronimo.mavenplugins.geronimo.ServerProxy] : Connected
[INFO] Stopping Geronimo server...
[org.apache.geronimo.mavenplugins.geronimo.ServerProxy] : Failed to close
JMXConnector:java.rmi.ConnectException: Connection refused to host:
9.42.75.229; nested exception is:
java.net.ConnectException: Connection refused
[INFO] [install:install {execution: default-install}]
[INFO] Installing
/home/geronimo/geronimo/trunk/testsuite/commands-testsuite/deploy/target/deploy-3.0-SNAPSHOT.jar
to
/home/geronimo/.m2/repository/org/apache/geronimo/testsuite/deploy/3.0-SNAPSHOT/deploy-3.0-SNAPSHOT.jar
[INFO] [failsafe:verify {execution: verify}]
[INFO] Failsafe report directory:
/home/geronimo/geronimo/trunk/testsuite/commands-testsuite/deploy/target/failsafe-reports
[INFO]
[INFO] Building Geronimo TestSuite :: Commands Testsuite :: Shutdown
[INFO]task-segment: [install]
[INFO]
[INFO] [genesis:validate-configuration {execution: default}]
[INFO] [geronimo-property:set-property {execution: set-property}]
[INFO] [enforcer:enforce {execution: default}]
[INFO] [remote-resources:process {execution: default}]
[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory
/home/geronimo/geronimo/trunk/testsuite/commands-testsuite/shutdown/src/main/resources
[INFO] skip non existing resourceDirectory
/home/geronimo/geronimo/trunk/testsuite/commands-testsuite/shutdown/src/main/filtered-resources
[INFO] Copying 3 resources
[INFO] [compiler:compile {execution: default-compile}]
[INFO] No sources to compile
[INFO] [resources:testResources {execution: default-testResources
[BUILD] branches/2.2: Failed for Revision: 980522
Geronimo Revision: 980522 built with tests included See the full build-1400.log file at http://people.apache.org/builds/geronimo/server/binaries/2.2/20100729/build-1400.log Download the binaries from http://people.apache.org/builds/geronimo/server/binaries/2.2/20100729 [INFO] BUILD SUCCESSFUL [INFO] [INFO] Total time: 403 minutes 51 seconds [INFO] Finished at: Thu Jul 29 20:51:28 EDT 2010 [INFO] Final Memory: 326M/957M [INFO] TESTSUITE RESULTS (Failures only) = Assembly: tomcat = See full test results and logs at http://people.apache.org/builds/geronimo/server/binaries/2.2/20100729/logs-1400-tomcat/ [INFO] Running TestSuite [INFO] Tests run: 118, Failures: 1, Errors: 0, Skipped: 117, Time elapsed: 23.62 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 38, Failures: 1, Errors: 0, Skipped: 37, Time elapsed: 21.549 sec FAILURE! -- [INFO] Running TestSuite [INFO] Tests run: 3, Failures: 1, Errors: 0, Skipped: 2, Time elapsed: 21.07 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 4, Failures: 1, Errors: 0, Skipped: 3, Time elapsed: 21.133 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 4, Failures: 1, Errors: 0, Skipped: 3, Time elapsed: 21.101 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 9, Failures: 1, Errors: 0, Skipped: 8, Time elapsed: 21.199 sec FAILURE! -- [INFO] Running TestSuite [INFO] Tests run: 3, Failures: 1, Errors: 0, Skipped: 2, Time elapsed: 21.074 sec FAILURE! -- [INFO] Running TestSuite [INFO] Tests run: 11, Failures: 1, Errors: 0, Skipped: 10, Time elapsed: 21.17 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 38, Failures: 1, Errors: 0, Skipped: 37, Time elapsed: 21.596 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 6, Failures: 1, Errors: 0, Skipped: 5, Time elapsed: 21.073 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 3, Failures: 1, Errors: 0, Skipped: 2, Time elapsed: 21.052 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 3, Failures: 1, Errors: 0, Skipped: 2, Time elapsed: 21.13 sec FAILURE! -- [INFO] Running TestSuite [INFO] Tests run: 3, Failures: 1, Errors: 0, Skipped: 2, Time elapsed: 21.053 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 5, Failures: 1, Errors: 0, Skipped: 4, Time elapsed: 21.049 sec FAILURE! Assembly: jetty = See full test results and logs at http://people.apache.org/builds/geronimo/server/binaries/2.2/20100729/logs-1400-jetty/ [INFO] Running TestSuite [INFO] Tests run: 118, Failures: 1, Errors: 0, Skipped: 117, Time elapsed: 22.461 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 38, Failures: 1, Errors: 0, Skipped: 37, Time elapsed: 21.454 sec FAILURE! -- [INFO] Running TestSuite [INFO] Tests run: 3, Failures: 1, Errors: 0, Skipped: 2, Time elapsed: 21.128 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 4, Failures: 1, Errors: 0, Skipped: 3, Time elapsed: 21.106 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 4, Failures: 1, Errors: 0, Skipped: 3, Time elapsed: 21.058 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 9, Failures: 1, Errors: 0, Skipped: 8, Time elapsed: 21.164 sec FAILURE! -- [INFO] Running TestSuite [INFO] Tests run: 3, Failures: 1, Errors: 0, Skipped: 2, Time elapsed: 21.059 sec FAILURE! -- [INFO] Running TestSuite [INFO] Tests run: 11, Failures: 1, Errors: 0, Skipped: 10, Time elapsed: 21.175 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 38, Failures: 1, Errors: 0, Skipped: 37, Time elapsed: 21.715 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 6, Failures: 1, Errors: 0, Skipped: 5, Time elapsed: 21.076 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 3, Failures: 1, Errors: 0, Skipped: 2, Time elapsed: 21.063 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 3, Failures: 1, Errors: 0, Skipped: 2, Time elapsed: 21.065 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 3, Failures: 1, Errors: 0, Skipped: 2, Time elapsed: 21.041 sec FAILURE! [INFO] Running TestSuite [INFO] Tests run: 5, Failures: 1, Errors: 0, Skipped: 4, Time elapsed: 21.029 sec FAILURE! Samples: branches/2.2 = Log: http://people.apache.org/builds/geronimo/server/binaries/2.2/20100729/samples-1400.log Build status: OK
Re: [VOTE] External tomcat-parent-6.0.29.0
All tomcat related TCK passed. Here is my +1 On Fri, Jul 30, 2010 at 10:16 AM, Delos dait...@gmail.com wrote: Thanks, Donald! 2010/7/29 Donald Woods dwo...@apache.org +1 Was able to build the tag and the jars looked like they have the required License/Notice files. -Donald On 7/23/10 7:28 AM, Delos wrote: This voting is for mavenized tomcat 6.0.29. Following what we did to tomcat 6.0.20, we are using a forked copy of tomcat derived from the tomcat 6.0.29 release, built with maven, with maven dependencies, etc etc. Besides, we also applied some patches which haven't been included in tomcat 6.0.29. Based on tomcat 6.0.29 tag, I also applied another couple of patches: GERONIMO-3451 'Restricted listeners property file not found' error logged during Tomcat server startup GERONIMO-4685 Include patches for revision #790742 Staging repo: https://repository.apache.org/content/repositories/orgapachegeronimo-028/ svn tag at: http://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-6.0.29.0/ [ ] +1 go for it [ ] 0 [ ] -1 whoa, hold on a minute Vote open 72 hours thanks a lot! -- Best Regards, Delos -- Best Regards, Delos -- Shawn
Re: [VOTE] External tomcat-parent-6.0.29.0
+1 2010/7/30 Shawn Jiang genspr...@gmail.com All tomcat related TCK passed. Here is my +1 On Fri, Jul 30, 2010 at 10:16 AM, Delos dait...@gmail.com wrote: Thanks, Donald! 2010/7/29 Donald Woods dwo...@apache.org +1 Was able to build the tag and the jars looked like they have the required License/Notice files. -Donald On 7/23/10 7:28 AM, Delos wrote: This voting is for mavenized tomcat 6.0.29. Following what we did to tomcat 6.0.20, we are using a forked copy of tomcat derived from the tomcat 6.0.29 release, built with maven, with maven dependencies, etc etc. Besides, we also applied some patches which haven't been included in tomcat 6.0.29. Based on tomcat 6.0.29 tag, I also applied another couple of patches: GERONIMO-3451 'Restricted listeners property file not found' error logged during Tomcat server startup GERONIMO-4685 Include patches for revision #790742 Staging repo: https://repository.apache.org/content/repositories/orgapachegeronimo-028/ svn tag at: http://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-6.0.29.0/ [ ] +1 go for it [ ] 0 [ ] -1 whoa, hold on a minute Vote open 72 hours thanks a lot! -- Best Regards, Delos -- Best Regards, Delos -- Shawn -- Ivan
[jira] Created: (GERONIMO-5486) Add testsuite for Interceptors 1.1 in Java EE 6
Add testsuite for Interceptors 1.1 in Java EE 6 --- Key: GERONIMO-5486 URL: https://issues.apache.org/jira/browse/GERONIMO-5486 Project: Geronimo Issue Type: Task Security Level: public (Regular issues) Components: testsuite Affects Versions: 3.0 Reporter: LiWenQin Fix For: 3.0 This testsuite will demonstrate Interceptor 1.1 feature in Java EE 5. It tests: Interceptor can modify the parameters of Bean before methods in bean are invoked. The invoking sequence of Interceptors. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [VOTE] External tomcat-parent-6.0.29.0
build successfully and signature/checksum looks good. +1 -Rex 2010/7/23 Delos dait...@gmail.com This voting is for mavenized tomcat 6.0.29. Following what we did to tomcat 6.0.20, we are using a forked copy of tomcat derived from the tomcat 6.0.29 release, built with maven, with maven dependencies, etc etc. Besides, we also applied some patches which haven't been included in tomcat 6.0.29. Based on tomcat 6.0.29 tag, I also applied another couple of patches: GERONIMO-3451 'Restricted listeners property file not found' error logged during Tomcat server startup GERONIMO-4685 Include patches for revision #790742 Staging repo: https://repository.apache.org/content/repositories/orgapachegeronimo-028/ svn tag at: http://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-6.0.29.0/ [ ] +1 go for it [ ] 0 [ ] -1 whoa, hold on a minute Vote open 72 hours thanks a lot! -- Best Regards, Delos -- Lei Wang (Rex) rwonly AT apache.org
