[jira] Commented: (SM-630) org.apache.servicemix.jbi.messaging.JcaFlowTransactionTest
[ https://issues.apache.org/activemq/browse/SM-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40383 ] Oleg Zhurakousky commented on SM-630: - Quick comment The scenarios within this test seem to be following what's described here: http://incubator.apache.org/servicemix/transactions.html Each test is encapsulated in the try/catch block with fail(. . .) call which never gets executed (and it shouldn't). If there is any other problems I can't seem to replicate it other then a potential issue with clustered send/receives, but they all part of the bigger issue where there is not enough time (especially on the good hardware) for Demand Forwarding Bridge to setup. > org.apache.servicemix.jbi.messaging.JcaFlowTransactionTest > -- > > Key: SM-630 > URL: https://issues.apache.org/activemq/browse/SM-630 > Project: ServiceMix > Issue Type: Sub-task > Components: servicemix-core >Affects Versions: incubation >Reporter: Fritz Oconer > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SM-627) Failed unit test (servicemix-core) : org.apache.servicemix.jbi.nmr.flow.jca.JCAFlowTest
[ https://issues.apache.org/activemq/browse/SM-627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Zhurakousky updated SM-627: Attachment: JCAFlowTest_patch.txt The same solution as JMSFlowTest (see discussion there). Make sure that JMSFlowTest patches are applied first since there is a new Helper class thus making this page a compile dependency. > Failed unit test (servicemix-core) : > org.apache.servicemix.jbi.nmr.flow.jca.JCAFlowTest > --- > > Key: SM-627 > URL: https://issues.apache.org/activemq/browse/SM-627 > Project: ServiceMix > Issue Type: Sub-task > Components: servicemix-core >Affects Versions: 3.0 >Reporter: Fritz Oconer > Fix For: 3.2 > > Attachments: JCAFlowTest_patch.txt > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SM-628) org.apache.servicemix.jbi.nmr.flow.jms.JMSFlowTest
[ https://issues.apache.org/activemq/browse/SM-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40366 ] Oleg Zhurakousky commented on SM-628: - Guillaume Go ahead and commit if you like. I just tested it with JCAFlowTest and it works good so I'll be submitting a patch for that shortly, but it has to be after you apply this patch otherwise the code will not compile without having ClusterFlowTestHelper. As to the note I made in the previous comment it would not work unless we start changing more things around since the wait method takes the amount of messages as input paramener and as I said before I would not know that in the clustered flows. So I would keep it the way it is. Let me know if you plan to commit so I know when to submit the JCA and other patches. > org.apache.servicemix.jbi.nmr.flow.jms.JMSFlowTest > -- > > Key: SM-628 > URL: https://issues.apache.org/activemq/browse/SM-628 > Project: ServiceMix > Issue Type: Sub-task > Components: servicemix-core >Affects Versions: 3.0 >Reporter: Fritz Oconer > Fix For: 3.2 > > Attachments: SMTestCasesPatches.zip > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SM-628) org.apache.servicemix.jbi.nmr.flow.jms.JMSFlowTest
[ https://issues.apache.org/activemq/browse/SM-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40365 ] Oleg Zhurakousky commented on SM-628: - Cool, but don't commit yet. I just edited my previous comment with a little NOTE (there is something I can reuse from MessageList. . . you made me think. . .), so I want to change that. Also, let me look at other similar test to make sure that the approach is the same. I will provide another comment here when I am done. As for Jira/Resolve. May be you right Resolve or Close if not accepted could always be reopened. But it would eliminate double work if it is accepted sine the only time you would have to go back if you had to reopen it (you would not have to go back and close something that you agree already). > org.apache.servicemix.jbi.nmr.flow.jms.JMSFlowTest > -- > > Key: SM-628 > URL: https://issues.apache.org/activemq/browse/SM-628 > Project: ServiceMix > Issue Type: Sub-task > Components: servicemix-core >Affects Versions: 3.0 >Reporter: Fritz Oconer > Fix For: 3.2 > > Attachments: SMTestCasesPatches.zip > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SM-628) org.apache.servicemix.jbi.nmr.flow.jms.JMSFlowTest
[ https://issues.apache.org/activemq/browse/SM-628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Zhurakousky updated SM-628: Attachment: SMTestCasesPatches.zip Patches for JMSFlowTest > org.apache.servicemix.jbi.nmr.flow.jms.JMSFlowTest > -- > > Key: SM-628 > URL: https://issues.apache.org/activemq/browse/SM-628 > Project: ServiceMix > Issue Type: Sub-task > Components: servicemix-core >Affects Versions: 3.0 >Reporter: Fritz Oconer > Fix For: 3.2 > > Attachments: SMTestCasesPatches.zip > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
