[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes
alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#discussion_r266680620 ## File path: gora-pig/src/test/java/org/apache/gora/pig/GoraStorageTest.java-disabled ## @@ -0,0 +1,352 @@ +package org.apache.gora.pig; Review comment: > Were you able to try the same with HBase 2 upgrade? Hi! No. I will try, though. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes
alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#discussion_r266256724 ## File path: gora-pig/src/test/examples/README.md ## @@ -0,0 +1,46 @@ + Review comment: The Gora-Pig example README.txt renamed to README.md and updated to include steps. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes
alfonsonishikawa commented on a change in pull request #135: Goraexplorer
needed changes
URL: https://github.com/apache/gora/pull/135#discussion_r266256105
##
File path: gora-pig/src/test/examples/example.pig
##
@@ -0,0 +1,4 @@
+set job.name 'GoraStorage test' ;
+register gora/*.jar ;
+webpage = LOAD '.' using
org.apache.gora.pig.GoraStorage('java.lang.String','admin.WebPage','baseUrl,status,content')
;
+dump webpage;
Review comment:
Deleted `webpage.jar` and updated README.md to describe the steps to execute
an example.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes
alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#discussion_r266256014 ## File path: gora-core/src/examples/java/org/apache/gora/examples/generated/package-info.java ## @@ -1,20 +0,0 @@ -/** Review comment: Now the package-info.java files are moved to the parent directory temporarily at `compile-examples.sh` before deleting the generated classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes
alfonsonishikawa commented on a change in pull request #135: Goraexplorer
needed changes
URL: https://github.com/apache/gora/pull/135#discussion_r266255944
##
File path: conf/log4j.properties
##
@@ -24,7 +24,7 @@ log4j.threshhold=ALL
log4j.rootLogger=${gora.root.logger}
#special logging requirements for some commandline tools
-log4j.logger.org.apache.gora.compiler.GoraCompiler=INFO,console
+log4j.logger.org.apache.gora.compiler.GoraCompiler=INFO
Review comment:
Logs in console about compiled files appeared twice because the root,logger
is already configured to log to console.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes
alfonsonishikawa commented on a change in pull request #135: Goraexplorer
needed changes
URL: https://github.com/apache/gora/pull/135#discussion_r266249623
##
File path: gora-core/src/main/java/org/apache/gora/store/DataStoreFactory.java
##
@@ -412,7 +484,7 @@ public static String getMappingFile(Properties properties,
DataStore store
return mappingFilename;
}
- private static String getDefaultDataStore(Properties properties) {
+ public static String getDefaultDataStore(Properties properties) {
Review comment:
Sadly the MetadataAnalyzer (to retrieve native information from the backend)
depends on the name of the DataStore.
I acknowledge I went into a rush about implementing the feature, so any
suggestions about are welcomed :)
I see you found out why by yourself!
(https://github.com/apache/gora/pull/135/files/2974126a934bddc526830182b402767c0f1eefd0?file-filters%5B%5D=.java=true#diff-d9701987f6844457a897d30a5786e5a4)
:D
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes
alfonsonishikawa commented on a change in pull request #135: Goraexplorer
needed changes
URL: https://github.com/apache/gora/pull/135#discussion_r222506186
##
File path:
gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm
##
@@ -180,6 +180,11 @@ public class ${this.mangle($schema.getName())}#if
($schema.isError()) extends or
return new #if
($schema.getNamespace())$schema.getNamespace().#end${this.mangle($schema.getName())}.Builder(other);
}
+ @Override
Review comment:
A clone method. I used it
[here](https://bitbucket.org/alfonsonishikawa/goraexplorer/src/12f226408e7f9686aa6b5975692edf270b94182e/src/main/java/com/nishilua/goraexplorer/tables/TableEntityServiceImpl.java#lines-121)
because `get()` reuses the instance.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes
alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#discussion_r265370854 ## File path: gora-core/src/examples/java/org/apache/gora/examples/generated/package-info.java ## @@ -1,20 +0,0 @@ -/** Review comment: It seems that compile-examples.sh just deletes generated/* to regenerate the classes. I will update bin/compile-examples.sh to just delete .java files This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
