[jira] [Commented] (HIVE-2477) Use name of original expression for name of CAST output
[ https://issues.apache.org/jira/browse/HIVE-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547864#comment-13547864 ] Hudson commented on HIVE-2477: -- Integrated in Hive-trunk-hadoop2 #54 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/54/]) HIVE-2477 Use name of original expression for name of CAST output (Navis via namit) (Revision 1418012) Result = ABORTED namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1418012 Files : * /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java * /hive/trunk/ql/src/test/queries/clientpositive/alias_casted_column.q * /hive/trunk/ql/src/test/results/clientpositive/alias_casted_column.q.out > Use name of original expression for name of CAST output > --- > > Key: HIVE-2477 > URL: https://issues.apache.org/jira/browse/HIVE-2477 > Project: Hive > Issue Type: Improvement > Components: Query Processor >Reporter: Adam Kramer >Assignee: Navis >Priority: Minor > Fix For: 0.11.0 > > Attachments: HIVE-2477.1.patch.txt, hive.2477.4.patch, > HIVE-2477.D7161.1.patch, HIVE-2477.D7161.2.patch > > > CAST(foo AS INT) > should, by default, consider itself a column named foo if > unspecified/unaliased. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2477) Use name of original expression for name of CAST output
[ https://issues.apache.org/jira/browse/HIVE-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526185#comment-13526185 ] Hudson commented on HIVE-2477: -- Integrated in Hive-trunk-h0.21 #1839 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1839/]) HIVE-2477 Use name of original expression for name of CAST output (Navis via namit) (Revision 1418012) Result = FAILURE namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1418012 Files : * /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java * /hive/trunk/ql/src/test/queries/clientpositive/alias_casted_column.q * /hive/trunk/ql/src/test/results/clientpositive/alias_casted_column.q.out > Use name of original expression for name of CAST output > --- > > Key: HIVE-2477 > URL: https://issues.apache.org/jira/browse/HIVE-2477 > Project: Hive > Issue Type: Improvement >Reporter: Adam Kramer >Assignee: Navis >Priority: Minor > Attachments: HIVE-2477.1.patch.txt, hive.2477.4.patch, > HIVE-2477.D7161.1.patch, HIVE-2477.D7161.2.patch > > > CAST(foo AS INT) > should, by default, consider itself a column named foo if > unspecified/unaliased. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2477) Use name of original expression for name of CAST output
[ https://issues.apache.org/jira/browse/HIVE-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511353#comment-13511353 ] Namit Jain commented on HIVE-2477: -- +1 > Use name of original expression for name of CAST output > --- > > Key: HIVE-2477 > URL: https://issues.apache.org/jira/browse/HIVE-2477 > Project: Hive > Issue Type: Improvement >Reporter: Adam Kramer >Assignee: Navis >Priority: Minor > Attachments: HIVE-2477.1.patch.txt, hive.2477.4.patch, > HIVE-2477.D7161.1.patch, HIVE-2477.D7161.2.patch > > > CAST(foo AS INT) > should, by default, consider itself a column named foo if > unspecified/unaliased. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2477) Use name of original expression for name of CAST output
[ https://issues.apache.org/jira/browse/HIVE-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511192#comment-13511192 ] Phabricator commented on HIVE-2477: --- navis has commented on the revision "HIVE-2477 [jira] Use name of original expression for name of CAST output". INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:1185 Seemed reasonable. I'll do that. ql/src/test/queries/clientpositive/alias_casted_column.q:1 Sorry REVISION DETAIL https://reviews.facebook.net/D7161 To: JIRA, navis Cc: njain > Use name of original expression for name of CAST output > --- > > Key: HIVE-2477 > URL: https://issues.apache.org/jira/browse/HIVE-2477 > Project: Hive > Issue Type: Improvement >Reporter: Adam Kramer >Assignee: Navis >Priority: Minor > Attachments: HIVE-2477.1.patch.txt, HIVE-2477.D7161.1.patch > > > CAST(foo AS INT) > should, by default, consider itself a column named foo if > unspecified/unaliased. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2477) Use name of original expression for name of CAST output
[ https://issues.apache.org/jira/browse/HIVE-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511082#comment-13511082 ] Phabricator commented on HIVE-2477: --- njain has commented on the revision "HIVE-2477 [jira] Use name of original expression for name of CAST output". minor comments INLINE COMMENTS ql/src/test/queries/clientpositive/alias_casted_column.q:1 you forgot to add the output file for this ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:1185 do you want to add a indirection ? something like: isOpPreserveInputName() -- which can call isOpCast (isOpCast can be private). and the caller (SemanticAnalyzer can call isOpPreserveName). If in future there is another function with this requirement, it would be easy. REVISION DETAIL https://reviews.facebook.net/D7161 To: JIRA, navis Cc: njain > Use name of original expression for name of CAST output > --- > > Key: HIVE-2477 > URL: https://issues.apache.org/jira/browse/HIVE-2477 > Project: Hive > Issue Type: Improvement >Reporter: Adam Kramer >Assignee: Navis >Priority: Minor > Attachments: HIVE-2477.1.patch.txt, HIVE-2477.D7161.1.patch > > > CAST(foo AS INT) > should, by default, consider itself a column named foo if > unspecified/unaliased. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
