[jira] [Commented] (HIVE-2682) Clean-up logs
[ https://issues.apache.org/jira/browse/HIVE-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547851#comment-13547851 ] Hudson commented on HIVE-2682: -- Integrated in Hive-trunk-hadoop2 #54 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/54/]) HIVE-2682: Clean-up logs (Rajat Goel via Ashutosh Chauhan) (Revision 1230379) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1230379 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsPublisher.java * /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java * /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryStruct.java > Clean-up logs > - > > Key: HIVE-2682 > URL: https://issues.apache.org/jira/browse/HIVE-2682 > Project: Hive > Issue Type: Wish > Components: Logging >Affects Versions: 0.8.1, 0.9.0 >Reporter: Rajat Goel >Assignee: Rajat Goel >Priority: Trivial > Labels: logging > Fix For: 0.9.0 > > Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2682.D1035.1.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2682.D1035.2.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2682.D1035.3.patch, hive-2682.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Just wanted to cleanup some logs being printed at wrong loglevel - > 1. org.apache.hadoop.hive.ql.exec.CommonJoinOperator prints "table 0 has 1000 > rows for join key [...]" as WARNING. Is it really that? > 2. org.apache.hadoop.hive.ql.exec.GroupByOperator prints "Hash Table > completed flushed" and "Begin Hash Table flush at close: size = 21" as > WARNING. It shouldn't be. > 3. org.apache.hadoop.hive.ql.stats.jdbc.JDBCStatsPublisher prints "Warning. > Invalid statistic." which looks fishy. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2682) Clean-up logs
[ https://issues.apache.org/jira/browse/HIVE-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534431#comment-13534431 ] Phabricator commented on HIVE-2682: --- rajat has closed the revision "HIVE-2682 [jira] Clean-up logs". Committed REVISION DETAIL https://reviews.facebook.net/D1035 To: JIRA, jsichi, jonchang, heyongqiang, njain, ashutoshc, rajat Cc: raghotham, rajat, njain > Clean-up logs > - > > Key: HIVE-2682 > URL: https://issues.apache.org/jira/browse/HIVE-2682 > Project: Hive > Issue Type: Wish > Components: Logging >Affects Versions: 0.8.1, 0.9.0 >Reporter: Rajat Goel >Assignee: Rajat Goel >Priority: Trivial > Labels: logging > Fix For: 0.9.0 > > Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2682.D1035.1.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2682.D1035.2.patch, > ASF.LICENSE.NOT.GRANTED--HIVE-2682.D1035.3.patch, hive-2682.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Just wanted to cleanup some logs being printed at wrong loglevel - > 1. org.apache.hadoop.hive.ql.exec.CommonJoinOperator prints "table 0 has 1000 > rows for join key [...]" as WARNING. Is it really that? > 2. org.apache.hadoop.hive.ql.exec.GroupByOperator prints "Hash Table > completed flushed" and "Begin Hash Table flush at close: size = 21" as > WARNING. It shouldn't be. > 3. org.apache.hadoop.hive.ql.stats.jdbc.JDBCStatsPublisher prints "Warning. > Invalid statistic." which looks fishy. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2682) Clean-up logs
[ https://issues.apache.org/jira/browse/HIVE-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187020#comment-13187020 ] Hudson commented on HIVE-2682: -- Integrated in Hive-trunk-h0.21-dbg #5 (See [https://builds.apache.org/job/Hive-trunk-h0.21-dbg/5/]) HIVE-2682: Clean-up logs (Rajat Goel via Ashutosh Chauhan) hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1230379 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsPublisher.java * /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java * /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryStruct.java > Clean-up logs > - > > Key: HIVE-2682 > URL: https://issues.apache.org/jira/browse/HIVE-2682 > Project: Hive > Issue Type: Wish > Components: Logging >Affects Versions: 0.8.1, 0.9.0 >Reporter: Rajat Goel >Assignee: Rajat Goel >Priority: Trivial > Labels: logging > Fix For: 0.9.0 > > Attachments: HIVE-2682.D1035.1.patch, HIVE-2682.D1035.2.patch, > HIVE-2682.D1035.3.patch, hive-2682.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Just wanted to cleanup some logs being printed at wrong loglevel - > 1. org.apache.hadoop.hive.ql.exec.CommonJoinOperator prints "table 0 has 1000 > rows for join key [...]" as WARNING. Is it really that? > 2. org.apache.hadoop.hive.ql.exec.GroupByOperator prints "Hash Table > completed flushed" and "Begin Hash Table flush at close: size = 21" as > WARNING. It shouldn't be. > 3. org.apache.hadoop.hive.ql.stats.jdbc.JDBCStatsPublisher prints "Warning. > Invalid statistic." which looks fishy. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2682) Clean-up logs
[ https://issues.apache.org/jira/browse/HIVE-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186777#comment-13186777 ] Hudson commented on HIVE-2682: -- Integrated in Hive-trunk-h0.21-dbg #3 (See [https://builds.apache.org/job/Hive-trunk-h0.21-dbg/3/]) HIVE-2682: Clean-up logs (Rajat Goel via Ashutosh Chauhan) hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1230379 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsPublisher.java * /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java * /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryStruct.java > Clean-up logs > - > > Key: HIVE-2682 > URL: https://issues.apache.org/jira/browse/HIVE-2682 > Project: Hive > Issue Type: Wish > Components: Logging >Affects Versions: 0.8.1, 0.9.0 >Reporter: Rajat Goel >Assignee: Rajat Goel >Priority: Trivial > Labels: logging > Fix For: 0.9.0 > > Attachments: HIVE-2682.D1035.1.patch, HIVE-2682.D1035.2.patch, > HIVE-2682.D1035.3.patch, hive-2682.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Just wanted to cleanup some logs being printed at wrong loglevel - > 1. org.apache.hadoop.hive.ql.exec.CommonJoinOperator prints "table 0 has 1000 > rows for join key [...]" as WARNING. Is it really that? > 2. org.apache.hadoop.hive.ql.exec.GroupByOperator prints "Hash Table > completed flushed" and "Begin Hash Table flush at close: size = 21" as > WARNING. It shouldn't be. > 3. org.apache.hadoop.hive.ql.stats.jdbc.JDBCStatsPublisher prints "Warning. > Invalid statistic." which looks fishy. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2682) Clean-up logs
[ https://issues.apache.org/jira/browse/HIVE-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184822#comment-13184822 ] Hudson commented on HIVE-2682: -- Integrated in Hive-trunk-h0.21 #1195 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1195/]) HIVE-2682: Clean-up logs (Rajat Goel via Ashutosh Chauhan) hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1230379 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsPublisher.java * /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java * /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryStruct.java > Clean-up logs > - > > Key: HIVE-2682 > URL: https://issues.apache.org/jira/browse/HIVE-2682 > Project: Hive > Issue Type: Wish > Components: Logging >Affects Versions: 0.8.1, 0.9.0 >Reporter: Rajat Goel >Assignee: Rajat Goel >Priority: Trivial > Labels: logging > Fix For: 0.9.0 > > Attachments: HIVE-2682.D1035.1.patch, HIVE-2682.D1035.2.patch, > HIVE-2682.D1035.3.patch, hive-2682.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Just wanted to cleanup some logs being printed at wrong loglevel - > 1. org.apache.hadoop.hive.ql.exec.CommonJoinOperator prints "table 0 has 1000 > rows for join key [...]" as WARNING. Is it really that? > 2. org.apache.hadoop.hive.ql.exec.GroupByOperator prints "Hash Table > completed flushed" and "Begin Hash Table flush at close: size = 21" as > WARNING. It shouldn't be. > 3. org.apache.hadoop.hive.ql.stats.jdbc.JDBCStatsPublisher prints "Warning. > Invalid statistic." which looks fishy. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2682) Clean-up logs
[ https://issues.apache.org/jira/browse/HIVE-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184505#comment-13184505 ] Namit Jain commented on HIVE-2682: -- Sorry Ashutosh, didn't notice that you are looking at it. > Clean-up logs > - > > Key: HIVE-2682 > URL: https://issues.apache.org/jira/browse/HIVE-2682 > Project: Hive > Issue Type: Wish > Components: Logging >Affects Versions: 0.8.1, 0.9.0 >Reporter: Rajat Goel >Assignee: Rajat Goel >Priority: Trivial > Labels: logging > Attachments: HIVE-2682.D1035.1.patch, HIVE-2682.D1035.2.patch, > HIVE-2682.D1035.3.patch, hive-2682.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Just wanted to cleanup some logs being printed at wrong loglevel - > 1. org.apache.hadoop.hive.ql.exec.CommonJoinOperator prints "table 0 has 1000 > rows for join key [...]" as WARNING. Is it really that? > 2. org.apache.hadoop.hive.ql.exec.GroupByOperator prints "Hash Table > completed flushed" and "Begin Hash Table flush at close: size = 21" as > WARNING. It shouldn't be. > 3. org.apache.hadoop.hive.ql.stats.jdbc.JDBCStatsPublisher prints "Warning. > Invalid statistic." which looks fishy. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2682) Clean-up logs
[ https://issues.apache.org/jira/browse/HIVE-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184506#comment-13184506 ] Phabricator commented on HIVE-2682: --- njain has accepted the revision "HIVE-2682 [jira] Clean-up logs". REVISION DETAIL https://reviews.facebook.net/D1035 > Clean-up logs > - > > Key: HIVE-2682 > URL: https://issues.apache.org/jira/browse/HIVE-2682 > Project: Hive > Issue Type: Wish > Components: Logging >Affects Versions: 0.8.1, 0.9.0 >Reporter: Rajat Goel >Assignee: Rajat Goel >Priority: Trivial > Labels: logging > Attachments: HIVE-2682.D1035.1.patch, HIVE-2682.D1035.2.patch, > HIVE-2682.D1035.3.patch, hive-2682.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Just wanted to cleanup some logs being printed at wrong loglevel - > 1. org.apache.hadoop.hive.ql.exec.CommonJoinOperator prints "table 0 has 1000 > rows for join key [...]" as WARNING. Is it really that? > 2. org.apache.hadoop.hive.ql.exec.GroupByOperator prints "Hash Table > completed flushed" and "Begin Hash Table flush at close: size = 21" as > WARNING. It shouldn't be. > 3. org.apache.hadoop.hive.ql.stats.jdbc.JDBCStatsPublisher prints "Warning. > Invalid statistic." which looks fishy. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2682) Clean-up logs
[ https://issues.apache.org/jira/browse/HIVE-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184047#comment-13184047 ] Ashutosh Chauhan commented on HIVE-2682: Click on More Actions button at top of this page then click on Add Files and then add your patch. Don't forget to click on radio button to grant perms. > Clean-up logs > - > > Key: HIVE-2682 > URL: https://issues.apache.org/jira/browse/HIVE-2682 > Project: Hive > Issue Type: Wish > Components: Logging >Affects Versions: 0.8.1, 0.9.0 >Reporter: Rajat Goel >Assignee: Rajat Goel >Priority: Trivial > Labels: logging > Attachments: HIVE-2682.D1035.1.patch, HIVE-2682.D1035.2.patch, > HIVE-2682.D1035.3.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Just wanted to cleanup some logs being printed at wrong loglevel - > 1. org.apache.hadoop.hive.ql.exec.CommonJoinOperator prints "table 0 has 1000 > rows for join key [...]" as WARNING. Is it really that? > 2. org.apache.hadoop.hive.ql.exec.GroupByOperator prints "Hash Table > completed flushed" and "Begin Hash Table flush at close: size = 21" as > WARNING. It shouldn't be. > 3. org.apache.hadoop.hive.ql.stats.jdbc.JDBCStatsPublisher prints "Warning. > Invalid statistic." which looks fishy. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2682) Clean-up logs
[ https://issues.apache.org/jira/browse/HIVE-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184042#comment-13184042 ] Phabricator commented on HIVE-2682: --- rajat has commented on the revision "HIVE-2682 [jira] Clean-up logs". REVISION DETAIL https://reviews.facebook.net/D1035 > Clean-up logs > - > > Key: HIVE-2682 > URL: https://issues.apache.org/jira/browse/HIVE-2682 > Project: Hive > Issue Type: Wish > Components: Logging >Reporter: Rajat Goel >Assignee: Rajat Goel >Priority: Trivial > Attachments: HIVE-2682.D1035.1.patch, HIVE-2682.D1035.2.patch, > HIVE-2682.D1035.3.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Just wanted to cleanup some logs being printed at wrong loglevel - > 1. org.apache.hadoop.hive.ql.exec.CommonJoinOperator prints "table 0 has 1000 > rows for join key [...]" as WARNING. Is it really that? > 2. org.apache.hadoop.hive.ql.exec.GroupByOperator prints "Hash Table > completed flushed" and "Begin Hash Table flush at close: size = 21" as > WARNING. It shouldn't be. > 3. org.apache.hadoop.hive.ql.stats.jdbc.JDBCStatsPublisher prints "Warning. > Invalid statistic." which looks fishy. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2682) Clean-up logs
[ https://issues.apache.org/jira/browse/HIVE-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184043#comment-13184043 ] Rajat Goel commented on HIVE-2682: -- Definitely. How to do that? I have added you as a reviewer at https://reviews.facebook.net/D1035 And thanks a lot of looking at the diff. Rajat On Wed, Jan 11, 2012 at 18:17, Ashutosh Chauhan (Commented) (JIRA) > Clean-up logs > - > > Key: HIVE-2682 > URL: https://issues.apache.org/jira/browse/HIVE-2682 > Project: Hive > Issue Type: Wish > Components: Logging >Reporter: Rajat Goel >Assignee: Rajat Goel >Priority: Trivial > Attachments: HIVE-2682.D1035.1.patch, HIVE-2682.D1035.2.patch, > HIVE-2682.D1035.3.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Just wanted to cleanup some logs being printed at wrong loglevel - > 1. org.apache.hadoop.hive.ql.exec.CommonJoinOperator prints "table 0 has 1000 > rows for join key [...]" as WARNING. Is it really that? > 2. org.apache.hadoop.hive.ql.exec.GroupByOperator prints "Hash Table > completed flushed" and "Begin Hash Table flush at close: size = 21" as > WARNING. It shouldn't be. > 3. org.apache.hadoop.hive.ql.stats.jdbc.JDBCStatsPublisher prints "Warning. > Invalid statistic." which looks fishy. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2682) Clean-up logs
[ https://issues.apache.org/jira/browse/HIVE-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184030#comment-13184030 ] Ashutosh Chauhan commented on HIVE-2682: Can you upload the patch on jira directly and grant perms? > Clean-up logs > - > > Key: HIVE-2682 > URL: https://issues.apache.org/jira/browse/HIVE-2682 > Project: Hive > Issue Type: Wish > Components: Logging >Reporter: Rajat Goel >Assignee: Rajat Goel >Priority: Trivial > Attachments: HIVE-2682.D1035.1.patch, HIVE-2682.D1035.2.patch, > HIVE-2682.D1035.3.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Just wanted to cleanup some logs being printed at wrong loglevel - > 1. org.apache.hadoop.hive.ql.exec.CommonJoinOperator prints "table 0 has 1000 > rows for join key [...]" as WARNING. Is it really that? > 2. org.apache.hadoop.hive.ql.exec.GroupByOperator prints "Hash Table > completed flushed" and "Begin Hash Table flush at close: size = 21" as > WARNING. It shouldn't be. > 3. org.apache.hadoop.hive.ql.stats.jdbc.JDBCStatsPublisher prints "Warning. > Invalid statistic." which looks fishy. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2682) Clean-up logs
[ https://issues.apache.org/jira/browse/HIVE-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183941#comment-13183941 ] Ashutosh Chauhan commented on HIVE-2682: +1 Looks good. Will commit once tests pass. > Clean-up logs > - > > Key: HIVE-2682 > URL: https://issues.apache.org/jira/browse/HIVE-2682 > Project: Hive > Issue Type: Wish > Components: Logging >Reporter: Rajat Goel >Priority: Trivial > Attachments: HIVE-2682.D1035.1.patch, HIVE-2682.D1035.2.patch, > HIVE-2682.D1035.3.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Just wanted to cleanup some logs being printed at wrong loglevel - > 1. org.apache.hadoop.hive.ql.exec.CommonJoinOperator prints "table 0 has 1000 > rows for join key [...]" as WARNING. Is it really that? > 2. org.apache.hadoop.hive.ql.exec.GroupByOperator prints "Hash Table > completed flushed" and "Begin Hash Table flush at close: size = 21" as > WARNING. It shouldn't be. > 3. org.apache.hadoop.hive.ql.stats.jdbc.JDBCStatsPublisher prints "Warning. > Invalid statistic." which looks fishy. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2682) Clean-up logs
[ https://issues.apache.org/jira/browse/HIVE-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176429#comment-13176429 ] Phabricator commented on HIVE-2682: --- rajat has commented on the revision "HIVE-2682 [jira] Clean-up logs". INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsPublisher.java:128 :P Then I need to change this in multiple places. ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java:112-114 I think this is related to skew joins. If we touch 1000 rows for a single key, there is a chance of data being skewed for that key and it needs to be handled specially. (I am just guessing, though). REVISION DETAIL https://reviews.facebook.net/D1035 > Clean-up logs > - > > Key: HIVE-2682 > URL: https://issues.apache.org/jira/browse/HIVE-2682 > Project: Hive > Issue Type: Wish > Components: Logging >Reporter: Rajat Goel >Priority: Trivial > Attachments: HIVE-2682.D1035.1.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Just wanted to cleanup some logs being printed at wrong loglevel - > 1. org.apache.hadoop.hive.ql.exec.CommonJoinOperator prints "table 0 has 1000 > rows for join key [...]" as WARNING. Is it really that? > 2. org.apache.hadoop.hive.ql.exec.GroupByOperator prints "Hash Table > completed flushed" and "Begin Hash Table flush at close: size = 21" as > WARNING. It shouldn't be. > 3. org.apache.hadoop.hive.ql.stats.jdbc.JDBCStatsPublisher prints "Warning. > Invalid statistic." which looks fishy. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2682) Clean-up logs
[ https://issues.apache.org/jira/browse/HIVE-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176269#comment-13176269 ] Phabricator commented on HIVE-2682: --- raghotham has commented on the revision "HIVE-2682 [jira] Clean-up logs". INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsPublisher.java:128 you dont really need to say 'Warning' - it will show up in the log anyway. ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java:112-114 what does this comment even mean? :) REVISION DETAIL https://reviews.facebook.net/D1035 > Clean-up logs > - > > Key: HIVE-2682 > URL: https://issues.apache.org/jira/browse/HIVE-2682 > Project: Hive > Issue Type: Wish > Components: Logging >Reporter: Rajat Goel >Priority: Trivial > Attachments: HIVE-2682.D1035.1.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Just wanted to cleanup some logs being printed at wrong loglevel - > 1. org.apache.hadoop.hive.ql.exec.CommonJoinOperator prints "table 0 has 1000 > rows for join key [...]" as WARNING. Is it really that? > 2. org.apache.hadoop.hive.ql.exec.GroupByOperator prints "Hash Table > completed flushed" and "Begin Hash Table flush at close: size = 21" as > WARNING. It shouldn't be. > 3. org.apache.hadoop.hive.ql.stats.jdbc.JDBCStatsPublisher prints "Warning. > Invalid statistic." which looks fishy. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
