[GitHub] [jackrabbit-oak] reschke commented on a diff in pull request #549: OAK-9750: Oak-run-elastic: Add right tika dependency
reschke commented on code in PR #549: URL: https://github.com/apache/jackrabbit-oak/pull/549#discussion_r854936987 ## oak-run-elastic/pom.xml: ## @@ -221,7 +221,7 @@ org.apache.tika tika-core -1.24.1 +${tika.version} Review Comment: I believe it would be better to just remove the version tag here (I think than then decl in the parent pom applies) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [jackrabbit-oak] reschke commented on a diff in pull request #549: OAK-9750: Oak-run-elastic: Add right tika dependency
reschke commented on code in PR #549: URL: https://github.com/apache/jackrabbit-oak/pull/549#discussion_r854936987 ## oak-run-elastic/pom.xml: ## @@ -221,7 +221,7 @@ org.apache.tika tika-core -1.24.1 +${tika.version} Review Comment: I believe it would be better to just remove the version tag here (I think than then decl in the parent pom applies) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [jackrabbit-oak] reschke commented on a diff in pull request #549: OAK-9750: Oak-run-elastic: Add right tika dependency
reschke commented on code in PR #549: URL: https://github.com/apache/jackrabbit-oak/pull/549#discussion_r854852600 ## oak-run-elastic/pom.xml: ## @@ -218,6 +218,11 @@ ${project.version} true + +org.apache.tika +tika-core +1.24.1 Review Comment: FWIW; Tika 2.x has been around since July. Minimally, we should update Tika to the latest version from the maintenance branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org