Jenkins build is back to normal : JMeter-trunk #7012

2019-01-05 Thread Apache Jenkins Server 
See

buildbot success in on jmeter-trunk

2019-01-05 Thread buildbot 
The Buildbot has detected a restored build on builder jmeter-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/4116

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_slave1_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1850516
Blamelist: fschumacher

Build succeeded!

Sincerely,
 -The Buildbot

Re: svn commit: r1850507 - in /jmeter/trunk/xdocs/images/screenshots/templates: template_folder.png template_parameters.png template_recording_retrieved_value.png

2019-01-05 Thread Felix Schumacher 



Am 05.01.19 um 22:08 schrieb Philippe Mouawad:

Probably not.
Feel free to change it.


Any idea, what word would be better? Execute, fill-in, render, generate, 
...?


Felix



Thanks

On Saturday, January 5, 2019, Felix Schumacher <
felix.schumac...@internetallee.de> wrote:


While compressing and checking these images, they reminded me to ask, if
the button to execute the templates should really be labeled "validate".

Regards,

  Felix


Am 05.01.19 um 21:30 schrieb fschumac...@apache.org:


Author: fschumacher
Date: Sat Jan  5 20:30:48 2019
New Revision: 1850507

URL: http://svn.apache.org/viewvc?rev=1850507=rev
Log:
Compress png images in docs

Modified:
  jmeter/trunk/xdocs/images/screenshots/templates/template_folder.png
  jmeter/trunk/xdocs/images/screenshots/templates/template_
parameters.png
  jmeter/trunk/xdocs/images/screenshots/templates/template_
recording_retrieved_value.png

Modified: jmeter/trunk/xdocs/images/screenshots/templates/template_
folder.png
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/images/scree
nshots/templates/template_folder.png?rev=1850507=
1850506=1850507=diff

==
Binary files - no diff available.

Modified: jmeter/trunk/xdocs/images/screenshots/templates/template_
parameters.png
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/images/scree
nshots/templates/template_parameters.png?rev=1850507=
1850506=1850507=diff

==
Binary files - no diff available.

Modified: jmeter/trunk/xdocs/images/screenshots/templates/template_
recording_retrieved_value.png
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/images/scree
nshots/templates/template_recording_retrieved_value.png?
rev=1850507=1850506=1850507=diff

==
Binary files - no diff available.

Re: search and replace feature

2019-01-05 Thread Philippe Mouawad 
On Saturday, January 5, 2019, Felix Schumacher <
felix.schumac...@internetallee.de> wrote:

> Hi all,
>
> while looking after Bug 63025 I saw, that the only samplers that are
> "Replaceable" are HTTPSamplerBase and HeaderManager.
>
> Shouldn't we extend the set of samplers further?


There are 2 reasons if I remember :

- it was an expertiment and intention was to have something working and
useful even if not complete and a basis to see if feature would be useful.
In my usage and feedback it ended up being useful
- My intention was to center the feature on correlation, that’s why it
concerns more http related elements



> The second thing I noticed was the repetitive code that is used to do the
> replacement of the values. I think the new code in HTTPSamplerBase could be
> moved somewhere else (into the interface Replaceable?) and be reused from
> HeaderManager. What do you think?


Yes, feel free to improve

>
> Regards,
>
>  Felix
>
>

-- 
Cordialement.
Philippe Mouawad.

buildbot failure in on jmeter-trunk

2019-01-05 Thread buildbot 
The Buildbot has detected a new failure on builder jmeter-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/4115

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_slave1_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1850515
Blamelist: fschumacher

BUILD FAILED: failed shell_3

Sincerely,
 -The Buildbot

Re: svn commit: r1850507 - in /jmeter/trunk/xdocs/images/screenshots/templates: template_folder.png template_parameters.png template_recording_retrieved_value.png

2019-01-05 Thread Philippe Mouawad 
On Saturday, January 5, 2019, Felix Schumacher <
felix.schumac...@internetallee.de> wrote:

>
> Am 05.01.19 um 22:08 schrieb Philippe Mouawad:
>
>> Probably not.
>> Feel free to change it.
>>
>
> Any idea, what word would be better? Execute, fill-in, render, generate,
> ...?
>
> generate / confirm ?

> Felix
>
>
>> Thanks
>>
>> On Saturday, January 5, 2019, Felix Schumacher <
>> felix.schumac...@internetallee.de> wrote:
>>
>> While compressing and checking these images, they reminded me to ask, if
>>> the button to execute the templates should really be labeled "validate".
>>>
>>> Regards,
>>>
>>>   Felix
>>>
>>>
>>> Am 05.01.19 um 21:30 schrieb fschumac...@apache.org:
>>>
>>> Author: fschumacher
 Date: Sat Jan  5 20:30:48 2019
 New Revision: 1850507

 URL: http://svn.apache.org/viewvc?rev=1850507=rev
 Log:
 Compress png images in docs

 Modified:
   jmeter/trunk/xdocs/images/screenshots/templates/template_
 folder.png
   jmeter/trunk/xdocs/images/screenshots/templates/template_
 parameters.png
   jmeter/trunk/xdocs/images/screenshots/templates/template_
 recording_retrieved_value.png

 Modified: jmeter/trunk/xdocs/images/screenshots/templates/template_
 folder.png
 URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/images/scree
 nshots/templates/template_folder.png?rev=1850507=
 1850506=1850507=diff
 
 ==
 Binary files - no diff available.

 Modified: jmeter/trunk/xdocs/images/screenshots/templates/template_
 parameters.png
 URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/images/scree
 nshots/templates/template_parameters.png?rev=1850507=
 1850506=1850507=diff
 
 ==
 Binary files - no diff available.

 Modified: jmeter/trunk/xdocs/images/screenshots/templates/template_
 recording_retrieved_value.png
 URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/images/scree
 nshots/templates/template_recording_retrieved_value.png?
 rev=1850507=1850506=1850507=diff
 
 ==
 Binary files - no diff available.





-- 
Cordialement.
Philippe Mouawad.

search and replace feature

2019-01-05 Thread Felix Schumacher 

Hi all,

while looking after Bug 63025 I saw, that the only samplers that are 
"Replaceable" are HTTPSamplerBase and HeaderManager.


Shouldn't we extend the set of samplers further?

The second thing I noticed was the repetitive code that is used to do 
the replacement of the values. I think the new code in HTTPSamplerBase 
could be moved somewhere else (into the interface Replaceable?) and be 
reused from HeaderManager. What do you think?


Regards,

 Felix