[jira] [Commented] (JOSHUA-262) Implement all logging as Slf4j over Log4j
[ https://issues.apache.org/jira/browse/JOSHUA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313110#comment-15313110 ] Thamme Gowda commented on JOSHUA-262: - Yes, I think we can close this [~post] > Implement all logging as Slf4j over Log4j > - > > Key: JOSHUA-262 > URL: https://issues.apache.org/jira/browse/JOSHUA-262 > Project: Joshua > Issue Type: Improvement > Components: core >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney >Assignee: Thamme Gowda N > Fix For: 6.1 > > > [~hsaputra] suggested that we implement all logging as Slf4j over Log4j. If > we use [parameterized logging > notation|http://www.slf4j.org/faq.html#logging_performance] we can have good > logging in place. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-262) Implement all logging as Slf4j over Log4j
[ https://issues.apache.org/jira/browse/JOSHUA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313106#comment-15313106 ] Matt Post commented on JOSHUA-262: -- This is done, right? Can we close out this request, [~tgow...@gmail.com]? > Implement all logging as Slf4j over Log4j > - > > Key: JOSHUA-262 > URL: https://issues.apache.org/jira/browse/JOSHUA-262 > Project: Joshua > Issue Type: Improvement > Components: core >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney >Assignee: Thamme Gowda N > Fix For: 6.1 > > > [~hsaputra] suggested that we implement all logging as Slf4j over Log4j. If > we use [parameterized logging > notation|http://www.slf4j.org/faq.html#logging_performance] we can have good > logging in place. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-262) Implement all logging as Slf4j over Log4j
[ https://issues.apache.org/jira/browse/JOSHUA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301637#comment-15301637 ] ASF GitHub Bot commented on JOSHUA-262: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-joshua/pull/17 > Implement all logging as Slf4j over Log4j > - > > Key: JOSHUA-262 > URL: https://issues.apache.org/jira/browse/JOSHUA-262 > Project: Joshua > Issue Type: Improvement > Components: core >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney >Assignee: Thamme Gowda N > Fix For: 6.1 > > > [~hsaputra] suggested that we implement all logging as Slf4j over Log4j. If > we use [parameterized logging > notation|http://www.slf4j.org/faq.html#logging_performance] we can have good > logging in place. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-262) Implement all logging as Slf4j over Log4j
[
https://issues.apache.org/jira/browse/JOSHUA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301565#comment-15301565
]
ASF GitHub Bot commented on JOSHUA-262:
---
GitHub user thammegowda opened a pull request:
https://github.com/apache/incubator-joshua/pull/17
JOSHUA-262 : Replacing System.{out,err}.print* and java.util.log with SLF4j
This is a duplicate of #15
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thammegowda/incubator-joshua JOSHUA-262
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-joshua/pull/17.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17
commit 09fb6a2d363ac78f091b217a88a8712c47edc5f0
Author: Matt Post
Date: 2016-05-14T19:27:38Z
don't separately pack the test grammar (done in run bundler)
commit f354c298ff9d1f16b8c034a5d885428d95e43ca3
Author: Matt Post
Date: 2016-05-16T22:20:45Z
Merge branch 'JOSHUA-264' of
https://github.com/thammegowda/incubator-joshua into JOSHUA-264
commit 659e464665254050a8f9ed321dcbdd08eef8a3d7
Author: Matt Post
Date: 2016-05-17T00:14:04Z
Merge branch 'jar-with-dependencies' of
https://github.com/thammegowda/incubator-joshua into JOSHUA-264
commit c21fa9e82db5b1f784b89ea8109735a3645298f2
Author: Thamme Gowda
Date: 2016-05-21T07:02:42Z
Log4j - Slf4j bridge
+ Removed java.util.log statements
+ SLF4j with string format pattern replacement
commit 9114a007ae4a42d97e2218712defafa3a9761560
Author: Thamme Gowda
Date: 2016-05-21T07:12:24Z
Read me updated
commit 4d04cc2c01669e3b93399758f54aae27e6e2d0ec
Author: Thamme Gowda
Date: 2016-05-21T18:22:28Z
LOG scope is privatized
commit d6efccbc51260028225652c77bfa0f4bdab8061b
Author: Thamme Gowda
Date: 2016-05-21T19:06:20Z
Clean LOGs, no redudant if(enabled) checks, no eager toString()s
commit 8652d19d1094cc6329220984d0693e6dcef4
Author: Thamme Gowda
Date: 2016-05-21T19:14:29Z
Fix spaces
commit d4ac45193450f1c901f23cc938e5981bb64eb8d6
Author: Thamme Gowda
Date: 2016-05-21T19:32:39Z
Fix log issues such as redundant checks and spaces
commit 158685310332be4166164bce28058a90f1d168d7
Author: Thamme Gowda
Date: 2016-05-23T04:18:21Z
Replaced System.err.print* with logger api
commit 9d6f84d35754a099123c256b9932a89a2bd316aa
Author: Thamme Gowda
Date: 2016-05-26T05:34:57Z
Rebased with JOSHUA-252 and resolved merge conflicts
> Implement all logging as Slf4j over Log4j
> -
>
> Key: JOSHUA-262
> URL: https://issues.apache.org/jira/browse/JOSHUA-262
> Project: Joshua
> Issue Type: Improvement
> Components: core
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Assignee: Thamme Gowda N
> Fix For: 6.1
>
>
> [~hsaputra] suggested that we implement all logging as Slf4j over Log4j. If
> we use [parameterized logging
> notation|http://www.slf4j.org/faq.html#logging_performance] we can have good
> logging in place.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (JOSHUA-262) Implement all logging as Slf4j over Log4j
[ https://issues.apache.org/jira/browse/JOSHUA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294879#comment-15294879 ] Kellen Sunderland commented on JOSHUA-262: -- Hey Thamme. Just wanted to say a huge thanks for taking this on. The PR looks really good but I've added a bunch of comments for minor issues. > Implement all logging as Slf4j over Log4j > - > > Key: JOSHUA-262 > URL: https://issues.apache.org/jira/browse/JOSHUA-262 > Project: Joshua > Issue Type: Improvement > Components: core >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney >Assignee: Thamme Gowda N > Fix For: 6.1 > > > [~hsaputra] suggested that we implement all logging as Slf4j over Log4j. If > we use [parameterized logging > notation|http://www.slf4j.org/faq.html#logging_performance] we can have good > logging in place. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-262) Implement all logging as Slf4j over Log4j
[ https://issues.apache.org/jira/browse/JOSHUA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294678#comment-15294678 ] Thamme Gowda commented on JOSHUA-262: - Oh yes, the actual output of the Decoder should go to STDOUT. I missed it. Thanks for correcting. > Implement all logging as Slf4j over Log4j > - > > Key: JOSHUA-262 > URL: https://issues.apache.org/jira/browse/JOSHUA-262 > Project: Joshua > Issue Type: Improvement > Components: core >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney >Assignee: Thamme Gowda N > Fix For: 6.1 > > > [~hsaputra] suggested that we implement all logging as Slf4j over Log4j. If > we use [parameterized logging > notation|http://www.slf4j.org/faq.html#logging_performance] we can have good > logging in place. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-262) Implement all logging as Slf4j over Log4j
[ https://issues.apache.org/jira/browse/JOSHUA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294673#comment-15294673 ] Matt Post commented on JOSHUA-262: -- I'm not sure if that's right (also not sure it's wrong). Logging is just for things that go to STDERR, right? It seems like there should be the following: - Decoder output that cannot be turned off. This is the most basic information, the translation. This isn't logging information, this is system output. - Informative output that is useful for diagnostics, making sure things are running, etc. Things like reporting each sentence as it comes in, how long it took to translate, etc. This to me is INFO. - WARN is for warnings, things out of the ordinary that could trip the user up - ERROR is for errors. > Implement all logging as Slf4j over Log4j > - > > Key: JOSHUA-262 > URL: https://issues.apache.org/jira/browse/JOSHUA-262 > Project: Joshua > Issue Type: Improvement > Components: core >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney >Assignee: Thamme Gowda N > Fix For: 6.1 > > > [~hsaputra] suggested that we implement all logging as Slf4j over Log4j. If > we use [parameterized logging > notation|http://www.slf4j.org/faq.html#logging_performance] we can have good > logging in place. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-262) Implement all logging as Slf4j over Log4j
[ https://issues.apache.org/jira/browse/JOSHUA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294664#comment-15294664 ] Thamme Gowda commented on JOSHUA-262: - that means: - 0 for DEBUG. When we set level to INFO, these messages don't show up. - 1 for INFO. No ambiguities here - 2+ It seems like DEBUG, although I am not sure Since log4j allows us to set different levels to specific classes and packages, we can tune them. I will send any System.err.print*s to ERROR and System.out.print*s to INFO. Please correct me if this is wrong. > Implement all logging as Slf4j over Log4j > - > > Key: JOSHUA-262 > URL: https://issues.apache.org/jira/browse/JOSHUA-262 > Project: Joshua > Issue Type: Improvement > Components: core >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney >Assignee: Thamme Gowda N > Fix For: 6.1 > > > [~hsaputra] suggested that we implement all logging as Slf4j over Log4j. If > we use [parameterized logging > notation|http://www.slf4j.org/faq.html#logging_performance] we can have good > logging in place. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-262) Implement all logging as Slf4j over Log4j
[ https://issues.apache.org/jira/browse/JOSHUA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294656#comment-15294656 ] Lewis John McGibbney commented on JOSHUA-262: - I honestly have no idea. > Implement all logging as Slf4j over Log4j > - > > Key: JOSHUA-262 > URL: https://issues.apache.org/jira/browse/JOSHUA-262 > Project: Joshua > Issue Type: Improvement > Components: core >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney >Assignee: Thamme Gowda N > Fix For: 6.1 > > > [~hsaputra] suggested that we implement all logging as Slf4j over Log4j. If > we use [parameterized logging > notation|http://www.slf4j.org/faq.html#logging_performance] we can have good > logging in place. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-262) Implement all logging as Slf4j over Log4j
[ https://issues.apache.org/jira/browse/JOSHUA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294655#comment-15294655 ] Matt Post commented on JOSHUA-262: -- It's not very systematic. - 0: print nothing. This mostly works, except the flag is not passed to KenLM, which sometimes prints something - 1: print "basic" information, like progress loading models, information about each sentence, and so on - 2+: extended debugging and detail I think it's useful to have a "silent" model (-v 0), and 1 should probably be for INFO. I'm not sure what the standard practice is when you want extra debugging output? > Implement all logging as Slf4j over Log4j > - > > Key: JOSHUA-262 > URL: https://issues.apache.org/jira/browse/JOSHUA-262 > Project: Joshua > Issue Type: Improvement > Components: core >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney >Assignee: Thamme Gowda N > Fix For: 6.1 > > > [~hsaputra] suggested that we implement all logging as Slf4j over Log4j. If > we use [parameterized logging > notation|http://www.slf4j.org/faq.html#logging_performance] we can have good > logging in place. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-262) Implement all logging as Slf4j over Log4j
[ https://issues.apache.org/jira/browse/JOSHUA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294651#comment-15294651 ] Thamme Gowda commented on JOSHUA-262: - Can somebody please clarify the mapping of old log levels to new log levels? *Older levels (Decoder.LOG):* * LOG(0, ...) * LOG(1, ...) * LOG(2, ...) *Newer levels (Slf4j)* * DEBUG * INFO * WARN * ERROR cc [~lewismc] [~post] > Implement all logging as Slf4j over Log4j > - > > Key: JOSHUA-262 > URL: https://issues.apache.org/jira/browse/JOSHUA-262 > Project: Joshua > Issue Type: Improvement > Components: core >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney > Fix For: 6.1 > > > [~hsaputra] suggested that we implement all logging as Slf4j over Log4j. If > we use [parameterized logging > notation|http://www.slf4j.org/faq.html#logging_performance] we can have good > logging in place. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-262) Implement all logging as Slf4j over Log4j
[ https://issues.apache.org/jira/browse/JOSHUA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294633#comment-15294633 ] Thamme Gowda commented on JOSHUA-262: - I second that. I am taking this task :-) Please assign it to me for the sake of tracking! > Implement all logging as Slf4j over Log4j > - > > Key: JOSHUA-262 > URL: https://issues.apache.org/jira/browse/JOSHUA-262 > Project: Joshua > Issue Type: Improvement > Components: core >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney > Fix For: 6.1 > > > [~hsaputra] suggested that we implement all logging as Slf4j over Log4j. If > we use [parameterized logging > notation|http://www.slf4j.org/faq.html#logging_performance] we can have good > logging in place. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-262) Implement all logging as Slf4j over Log4j
[ https://issues.apache.org/jira/browse/JOSHUA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15283166#comment-15283166 ] Kellen Sunderland commented on JOSHUA-262: -- There's two immediate benefits here: First to create a loose coupling to concrete logging systems, such that organizations can plug in whatever loggers they want at runtime. There's also a surprisingly large performance consideration that can be addressed here as well. There's a few cases where a ton of the cpu work is actually to build strings that don't get logged at the logging levels we're running under. Lazy evaluation of these strings should prevent this issue. > Implement all logging as Slf4j over Log4j > - > > Key: JOSHUA-262 > URL: https://issues.apache.org/jira/browse/JOSHUA-262 > Project: Joshua > Issue Type: Improvement > Components: core >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney > Fix For: 6.1 > > > [~hsaputra] suggested that we implement all logging as Slf4j over Log4j. If > we use [parameterized logging > notation|http://www.slf4j.org/faq.html#logging_performance] we can have good > logging in place. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
