[jira] [Commented] (KAFKA-5412) Using connect-console-sink/source.properties raises an exception related to "file" property not found
[ https://issues.apache.org/jira/browse/KAFKA-5412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046700#comment-16046700 ] Randall Hauch commented on KAFKA-5412: -- [~ppatierno], the committer that reviews and merges the PR will decides the versions/branches to which they'll this patch. > Using connect-console-sink/source.properties raises an exception related to > "file" property not found > - > > Key: KAFKA-5412 > URL: https://issues.apache.org/jira/browse/KAFKA-5412 > Project: Kafka > Issue Type: Bug > Components: KafkaConnect >Affects Versions: 0.10.2.1 >Reporter: Paolo Patierno > Fix For: 0.11.1.0 > > > With the latest 0.11.1.0-SNAPSHOT it happens that the Kafka Connect example > using connect-console-sink/source.properties doesn't work anymore because the > needed "file" property isn't found. This is because the underlying used > FileStreamSink/Source connector and task has defined a ConfigDef with "file" > as mandatory parameter. In the case of console example we want to have > file=null so that stdin and stdout are used. > One possible solution and workaround is set "file=" inside the provided > connect-console-sink/source.properties. The other one could be modify the > FileStreamSink/Source source code in order to remove the "file" definition > from the ConfigDef. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KAFKA-5412) Using connect-console-sink/source.properties raises an exception related to "file" property not found
[ https://issues.apache.org/jira/browse/KAFKA-5412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046325#comment-16046325 ] Paolo Patierno commented on KAFKA-5412: --- Sorry [~rhauch], on what version do you mean to backport this fix ? > Using connect-console-sink/source.properties raises an exception related to > "file" property not found > - > > Key: KAFKA-5412 > URL: https://issues.apache.org/jira/browse/KAFKA-5412 > Project: Kafka > Issue Type: Bug > Components: KafkaConnect >Affects Versions: 0.10.2.1 >Reporter: Paolo Patierno > Fix For: 0.11.1.0 > > > With the latest 0.11.1.0-SNAPSHOT it happens that the Kafka Connect example > using connect-console-sink/source.properties doesn't work anymore because the > needed "file" property isn't found. This is because the underlying used > FileStreamSink/Source connector and task has defined a ConfigDef with "file" > as mandatory parameter. In the case of console example we want to have > file=null so that stdin and stdout are used. > One possible solution and workaround is set "file=" inside the provided > connect-console-sink/source.properties. The other one could be modify the > FileStreamSink/Source source code in order to remove the "file" definition > from the ConfigDef. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KAFKA-5412) Using connect-console-sink/source.properties raises an exception related to "file" property not found
[ https://issues.apache.org/jira/browse/KAFKA-5412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044608#comment-16044608 ] Randall Hauch commented on KAFKA-5412: -- [~ppatierno], you might want to use "Submit Patch" button to set the correct status. Not sure why that was not done automatically. > Using connect-console-sink/source.properties raises an exception related to > "file" property not found > - > > Key: KAFKA-5412 > URL: https://issues.apache.org/jira/browse/KAFKA-5412 > Project: Kafka > Issue Type: Bug > Components: KafkaConnect >Affects Versions: 0.10.2.1 >Reporter: Paolo Patierno > Fix For: 0.11.1.0 > > > Hi, > with the latest 0.11.1.0-SNAPSHOT it happens that the Kafka Connect example > using connect-console-sink/source.properties doesn't work anymore because the > needed "file" property isn't found. > This is because the underlying used FileStreamSink/Source connector and task > has defined a ConfigDef with "file" as mandatory parameter. In the case of > console example we want to have file=null so that stdin and stdout are used. > One possible solution is set "file=" inside the provided > connect-console-sink/source.properties. > The other one could be modify the FileStreamSink/Source source code in order > to remove the "file" definition from the ConfigDef. > What do you think ? > I can provide a PR for that. > Thanks, > Paolo. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KAFKA-5412) Using connect-console-sink/source.properties raises an exception related to "file" property not found
[ https://issues.apache.org/jira/browse/KAFKA-5412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044606#comment-16044606 ] Randall Hauch commented on KAFKA-5412: -- I've initially targeted this to 0.11.1.0, since I think the first release candidate for 0.11.0.0 was already cut and this likely isn't an essential fix. Since this is a problem with the examples, it'd be great to backport. > Using connect-console-sink/source.properties raises an exception related to > "file" property not found > - > > Key: KAFKA-5412 > URL: https://issues.apache.org/jira/browse/KAFKA-5412 > Project: Kafka > Issue Type: Bug > Components: KafkaConnect >Affects Versions: 0.11.0.0 >Reporter: Paolo Patierno > Fix For: 0.11.1.0 > > > Hi, > with the latest 0.11.1.0-SNAPSHOT it happens that the Kafka Connect example > using connect-console-sink/source.properties doesn't work anymore because the > needed "file" property isn't found. > This is because the underlying used FileStreamSink/Source connector and task > has defined a ConfigDef with "file" as mandatory parameter. In the case of > console example we want to have file=null so that stdin and stdout are used. > One possible solution is set "file=" inside the provided > connect-console-sink/source.properties. > The other one could be modify the FileStreamSink/Source source code in order > to remove the "file" definition from the ConfigDef. > What do you think ? > I can provide a PR for that. > Thanks, > Paolo. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KAFKA-5412) Using connect-console-sink/source.properties raises an exception related to "file" property not found
[ https://issues.apache.org/jira/browse/KAFKA-5412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044181#comment-16044181 ] ASF GitHub Bot commented on KAFKA-5412: --- GitHub user ppatierno opened a pull request: https://github.com/apache/kafka/pull/3279 KAFKA-5412: Using connect-console-sink/source.properties raises an exception related to "file" property not found You can merge this pull request into a Git repository by running: $ git pull https://github.com/ppatierno/kafka kafka-5412 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3279.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3279 commit dcbe72dc72f2fcd2fafb84772b5fe5d9e80e1f75 Author: ppatierno Date: 2017-06-09T09:13:38Z Added default null value for "file" parameter and more descriptive documentation on its usage > Using connect-console-sink/source.properties raises an exception related to > "file" property not found > - > > Key: KAFKA-5412 > URL: https://issues.apache.org/jira/browse/KAFKA-5412 > Project: Kafka > Issue Type: Bug > Components: KafkaConnect >Affects Versions: 0.11.0.0 >Reporter: Paolo Patierno > > Hi, > with the latest 0.11.1.0-SNAPSHOT it happens that the Kafka Connect example > using connect-console-sink/source.properties doesn't work anymore because the > needed "file" property isn't found. > This is because the underlying used FileStreamSink/Source connector and task > has defined a ConfigDef with "file" as mandatory parameter. In the case of > console example we want to have file=null so that stdin and stdout are used. > One possible solution is set "file=" inside the provided > connect-console-sink/source.properties. > The other one could be modify the FileStreamSink/Source source code in order > to remove the "file" definition from the ConfigDef. > What do you think ? > I can provide a PR for that. > Thanks, > Paolo. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KAFKA-5412) Using connect-console-sink/source.properties raises an exception related to "file" property not found
[ https://issues.apache.org/jira/browse/KAFKA-5412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043988#comment-16043988 ] Paolo Patierno commented on KAFKA-5412: --- Thanks [~rhauch] ! I'll do the PR ... Btw I already sent the request for being part of the contributors list a couple of days ago but no response right now :-( > Using connect-console-sink/source.properties raises an exception related to > "file" property not found > - > > Key: KAFKA-5412 > URL: https://issues.apache.org/jira/browse/KAFKA-5412 > Project: Kafka > Issue Type: Bug > Components: KafkaConnect >Affects Versions: 0.11.0.0 >Reporter: Paolo Patierno > > Hi, > with the latest 0.11.1.0-SNAPSHOT it happens that the Kafka Connect example > using connect-console-sink/source.properties doesn't work anymore because the > needed "file" property isn't found. > This is because the underlying used FileStreamSink/Source connector and task > has defined a ConfigDef with "file" as mandatory parameter. In the case of > console example we want to have file=null so that stdin and stdout are used. > One possible solution is set "file=" inside the provided > connect-console-sink/source.properties. > The other one could be modify the FileStreamSink/Source source code in order > to remove the "file" definition from the ConfigDef. > What do you think ? > I can provide a PR for that. > Thanks, > Paolo. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KAFKA-5412) Using connect-console-sink/source.properties raises an exception related to "file" property not found
[ https://issues.apache.org/jira/browse/KAFKA-5412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043986#comment-16043986 ] Randall Hauch commented on KAFKA-5412: -- Please fix both the FileStreamSink and FileStreamSource. BTW, while you're making changes, it might also be good to expand the description of the "file" {{ConfigDef}} to say what the value should represent and what it means to not set it. Thanks! > Using connect-console-sink/source.properties raises an exception related to > "file" property not found > - > > Key: KAFKA-5412 > URL: https://issues.apache.org/jira/browse/KAFKA-5412 > Project: Kafka > Issue Type: Bug > Components: KafkaConnect >Affects Versions: 0.11.0.0 >Reporter: Paolo Patierno > > Hi, > with the latest 0.11.1.0-SNAPSHOT it happens that the Kafka Connect example > using connect-console-sink/source.properties doesn't work anymore because the > needed "file" property isn't found. > This is because the underlying used FileStreamSink/Source connector and task > has defined a ConfigDef with "file" as mandatory parameter. In the case of > console example we want to have file=null so that stdin and stdout are used. > One possible solution is set "file=" inside the provided > connect-console-sink/source.properties. > The other one could be modify the FileStreamSink/Source source code in order > to remove the "file" definition from the ConfigDef. > What do you think ? > I can provide a PR for that. > Thanks, > Paolo. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KAFKA-5412) Using connect-console-sink/source.properties raises an exception related to "file" property not found
[ https://issues.apache.org/jira/browse/KAFKA-5412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043984#comment-16043984 ] Randall Hauch commented on KAFKA-5412: -- [~ppatierno], thanks! Go ahead and submit a pull request with a description that begins with "KAFKA-5412", and see https://kafka.apache.org/contributing for details. That page suggests you email "dev@kafka.apache.org" and request to be added to the contributors list, at which point you can assign KAFKA issues to yourself. > Using connect-console-sink/source.properties raises an exception related to > "file" property not found > - > > Key: KAFKA-5412 > URL: https://issues.apache.org/jira/browse/KAFKA-5412 > Project: Kafka > Issue Type: Bug > Components: KafkaConnect >Affects Versions: 0.11.0.0 >Reporter: Paolo Patierno > > Hi, > with the latest 0.11.1.0-SNAPSHOT it happens that the Kafka Connect example > using connect-console-sink/source.properties doesn't work anymore because the > needed "file" property isn't found. > This is because the underlying used FileStreamSink/Source connector and task > has defined a ConfigDef with "file" as mandatory parameter. In the case of > console example we want to have file=null so that stdin and stdout are used. > One possible solution is set "file=" inside the provided > connect-console-sink/source.properties. > The other one could be modify the FileStreamSink/Source source code in order > to remove the "file" definition from the ConfigDef. > What do you think ? > I can provide a PR for that. > Thanks, > Paolo. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KAFKA-5412) Using connect-console-sink/source.properties raises an exception related to "file" property not found
[ https://issues.apache.org/jira/browse/KAFKA-5412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043034#comment-16043034 ] Paolo Patierno commented on KAFKA-5412: --- Yes I agree this is a better solution. I'd like to work on that as a newbie contributor to the project. Can you add me to the contributor list so that I can assign myself to this and eventually other JIRAs.What do you think ? > Using connect-console-sink/source.properties raises an exception related to > "file" property not found > - > > Key: KAFKA-5412 > URL: https://issues.apache.org/jira/browse/KAFKA-5412 > Project: Kafka > Issue Type: Bug > Components: KafkaConnect >Affects Versions: 0.11.0.0 >Reporter: Paolo Patierno > > Hi, > with the latest 0.11.1.0-SNAPSHOT it happens that the Kafka Connect example > using connect-console-sink/source.properties doesn't work anymore because the > needed "file" property isn't found. > This is because the underlying used FileStreamSink/Source connector and task > has defined a ConfigDef with "file" as mandatory parameter. In the case of > console example we want to have file=null so that stdin and stdout are used. > One possible solution is set "file=" inside the provided > connect-console-sink/source.properties. > The other one could be modify the FileStreamSink/Source source code in order > to remove the "file" definition from the ConfigDef. > What do you think ? > I can provide a PR for that. > Thanks, > Paolo. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KAFKA-5412) Using connect-console-sink/source.properties raises an exception related to "file" property not found
[ https://issues.apache.org/jira/browse/KAFKA-5412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043018#comment-16043018 ] Randall Hauch commented on KAFKA-5412: -- I believe the proper correction would be to add a null default value to the ConfigDef in FileStreamSink/Source. When no default value is provided, this means that the value is required. Clearly the FileStreamSink/Source is able to handle the "file" configuration not being specified, since it then works on the standard ouptut/input, respectively. > Using connect-console-sink/source.properties raises an exception related to > "file" property not found > - > > Key: KAFKA-5412 > URL: https://issues.apache.org/jira/browse/KAFKA-5412 > Project: Kafka > Issue Type: Bug > Components: KafkaConnect >Affects Versions: 0.11.1.0 >Reporter: Paolo Patierno > > Hi, > with the latest 0.11.1.0-SNAPSHOT it happens that the Kafka Connect example > using connect-console-sink/source.properties doesn't work anymore because the > needed "file" property isn't found. > This is because the underlying used FileStreamSink/Source connector and task > has defined a ConfigDef with "file" as mandatory parameter. In the case of > console example we want to have file=null so that stdin and stdout are used. > One possible solution is set "file=" inside the provided > connect-console-sink/source.properties. > The other one could be modify the FileStreamSink/Source source code in order > to remove the "file" definition from the ConfigDef. > What do you think ? > I can provide a PR for that. > Thanks, > Paolo. -- This message was sent by Atlassian JIRA (v6.3.15#6346)