Re: Log4j-audit release

[Remko Popma]

I had time to look at this during the flight, here it is:


index.html

typo: Diagnostic logs are critical in aiding in maintaining the
servicability -> critical in maintaining?

Overall, the first three sections, "What is Audit Logging", What is the
difference between audit logging and normal logging?" and "What is Log4j
Audit?" are very good: give good overview of the purpose and don't assume
prior knowledge.

>From the "Features" section, the narrative changes perspective from what
users would want to what Log4j Audit provides.
I would add a few sentences to that transition, something like:

{quote}
(after Features)
Each application has its own audit events. Before using Log4j Audit,
applications need to define AuditMessages that capture the exact attributes
of its audit events. The [Getting Started](link) page provides a tutorial
that explains how to define audit events for an application.

(after Audit Event Catalog header)
Once audit events are defined, they need to be maintained: as the
application evolves, developers will inevitably discover they need to add,
remove or change attributes of the audit events. Log4j Audit can persist
the audit event definitions in a JSON file. This file becomes the Audit
Event Catalog for the application. Log4j Audit is designed to store the
event definition file in a Git repository so that the evolution of the
audit events themselves have an audit trail in the Git history of the file.
Log4j Audit provides a web interface for editing the events.

Log4j Audit uses the catalog of events to determine ... (continue with
current text of Audit Event Catalog)
{quote}

Question about the Requirements section: it isn't clear to me (and likely
to other readers) why Dynamic Event Catalogs would require a database
instead of one or more JSON files. Is that explained somewhere? Perhaps
Dynamic Audit Events need a separate page or dedicated section somewhere.
The Getting Started page mentions "manage dynamic catalogs" in the
paragraph under "What you will build" but I couldn't find anything on the
topic of dynamic catalogs.




catalog.html

>From the first paragraph, I would remove "The events may be grouped by
Products and/or Categories, but at this time nothing in Log4j Audit makes
use of the product or catalog definitions". The same sentences is repeated
at the bottom of the page and since this feature is not used it is
confusing to me that the feature is so prominently mentioned in the first
paragraph of the page. I would consider removing this feature altogether.

Overall this is a very good page. Succinct but complete. Consider moving it
above RequestContext in the left-hand navigation menu.




gettingStarted.html

Overall, this page is only effective for people who actually perform the
steps and execute the commands mentioned in the page.

It would be good if the page would also be useful for people who only read
the page but don't actually perform the steps:

* Can the page also show an example of an audit event in JSON format. This
could be a simple event with few attributes (maybe a login event?) or the
transfer event that is used later in the page.
* I would also like to see the Java interface that is generated from this
JSON audit event.
* Finally, I would like to see how my application would use this generated
Java interface. How do I get an instance, how do I populate the attributes,
and what do I do with the instance after I populated it?

I'm sure the above is available in the source code of the sample
application, but this page is a good place to show some of the highlights
of that source code with some explanatory text.

Secondly, the page mentions remote audit logging and how the war file
provides endpoints for remove audit logging. Is it worth dedicating a
separate page to show how to configure end points for remote audit logging?

Finally, about the catalog screenshots: I understand that attributes are
managed separately so they can be reused. The second screenshot shows the
billPay and deposit events. Are these events related to the transfer event
that is mentioned in the curl example in this page? I was trying to see how
they could be related but couldn't figure it out.
Also, what are the attributes for the billPay and deposit events? If the
Catalog Editor has a screen to show the attributes that are part of an
event then it may be good to add a screenshot for this (I guess this would
be the Edit Event screen) as well. That would tie all these concepts
together.



requestContext.html

typo: typcial -> typical
typo: acrossall -> across all
typo: datbase -> database

About Mapping Annotations:
This is still a bit abstract to me. Would it be possible to provide some
more explanation on when applications should use ClientServer, when Local,
and when Chained annotations? Perhaps some example use cases? Or, if
possible, tie this to the use case presented in the sample application (if
that makes sense)?

About Transporting the RequestContext:

Re: Async Appenders

[William Davis]

I gotcha, if there is interest Id like to get a pr started.

On Mon, May 7, 2018, 1:25 PM Matt Sicker  wrote:

> Log4j and Log4net don't share any code, just similar architectures. As for
> why we haven't merged that into log4net, that may because it either was
> never noticed or the authors never attempted to donate it upstream in the
> first place.
>
> On 7 May 2018 at 12:22, William Davis  wrote:
>
> > Ok then, so are the same Async Appenders available in Log4Net that are in
> > Log4j ?
> > Here are some one I'm using:
> > https://github.com/cjbhaines/Log4Net.Async
> > (my .net standard port: https://github.com/wjdavis5/Log4Net.Async)
> > Also been looking into an Async Buffering Appender. Just seems we could
> get
> > so much more value out of the core product if these were rolled in. (And
> I
> > wouldnt have to struggle to get .net core support from ill maintained
> > repos.)
> >
> >
> >
> > On Mon, May 7, 2018 at 10:04 AM, Matt Sicker  wrote:
> >
> > > Oh, no worries, you're on the correct list!
> > >
> > > On 7 May 2018 at 09:02, William Davis 
> > wrote:
> > >
> > > > Sorry I meant to send this to the Log4Net distro
> > > >
> > > > On Mon, May 7, 2018 at 9:47 AM, Matt Sicker 
> wrote:
> > > >
> > > > > Like the Kafka appender's async option? Or like the async logger
> and
> > > > > appenders?
> > > > >
> > > > > On 7 May 2018 at 07:38, Remko Popma  wrote:
> > > > >
> > > > > > Log4j core provides about 4 flavours of async logging, several of
> > > which
> > > > > > use non-blocking data structures.
> > > > > >
> > > > > > Can you link to the ones you think should be included?
> > > > > >
> > > > > > Thanks!
> > > > > >
> > > > > > Remko
> > > > > >
> > > > > > (Shameless plug) Every java main() method deserves
> > > http://picocli.info
> > > > > >
> > > > > > > On May 7, 2018, at 14:15, William Davis <
> > > william.j.dav...@gmail.com>
> > > > > > wrote:
> > > > > > >
> > > > > > > I've noticed that there are several Async implementations of
> > > standard
> > > > > > > appenders out in the wild. Is there a reason none of these have
> > > made
> > > > > > there
> > > > > > > way into the core product? Is it just b/c no one has taken the
> > time
> > > > to
> > > > > > do a
> > > > > > > pull request, or is there some other reason?
> > > > > > >
> > > > > > > I've had several projects where we need the non-blocking nature
> > of
> > > > > these
> > > > > > > appenders to achieve desired performance.
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Matt Sicker 
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Matt Sicker 
> > >
> >
>
>
>
> --
> Matt Sicker 
>

Re: Log4j and OSGi

[Ralph Goers]

Nope. I have been swamped at work and there are a couple of issues I’d really 
like to address first. Also, I would like to get log4j-audit released.

But I wouldn’t expect OSGi enhancements like this to be in 2.11.x anyway. They 
should be targeted at 3.0.

Ralph

> On May 7, 2018, at 2:02 PM, Gary Gregory  wrote:
> 
> Even before that, or, for that, we already have a medium size change set
> for 2.11.1. Any thoughts on a time frame for releasing?
> 
> Gary
> 
> On Mon, May 7, 2018 at 2:55 PM, Ralph Goers 
> wrote:
> 
>> I just noticed https://github.com/rotty3000/osgi.to.logback <
>> https://github.com/rotty3000/osgi.to.logback>. I have not looked at the
>> OSGi R7 specification and I haven’t looked at the PR, but I’d hate to see
>> Logback be the only thing Felix can integrate with.
>> 
>> Ralph

Re: Log4j and OSGi

[Gary Gregory]

Even before that, or, for that, we already have a medium size change set
for 2.11.1. Any thoughts on a time frame for releasing?

Gary

On Mon, May 7, 2018 at 2:55 PM, Ralph Goers 
wrote:

> I just noticed https://github.com/rotty3000/osgi.to.logback <
> https://github.com/rotty3000/osgi.to.logback>. I have not looked at the
> OSGi R7 specification and I haven’t looked at the PR, but I’d hate to see
> Logback be the only thing Felix can integrate with.
>
> Ralph

Log4j and OSGi

[Ralph Goers]

I just noticed https://github.com/rotty3000/osgi.to.logback 
. I have not looked at the OSGi 
R7 specification and I haven’t looked at the PR, but I’d hate to see Logback be 
the only thing Felix can integrate with.

Ralph

Re: Async Appenders

[Matt Sicker]

Log4j and Log4net don't share any code, just similar architectures. As for
why we haven't merged that into log4net, that may because it either was
never noticed or the authors never attempted to donate it upstream in the
first place.

On 7 May 2018 at 12:22, William Davis  wrote:

> Ok then, so are the same Async Appenders available in Log4Net that are in
> Log4j ?
> Here are some one I'm using:
> https://github.com/cjbhaines/Log4Net.Async
> (my .net standard port: https://github.com/wjdavis5/Log4Net.Async)
> Also been looking into an Async Buffering Appender. Just seems we could get
> so much more value out of the core product if these were rolled in. (And I
> wouldnt have to struggle to get .net core support from ill maintained
> repos.)
>
>
>
> On Mon, May 7, 2018 at 10:04 AM, Matt Sicker  wrote:
>
> > Oh, no worries, you're on the correct list!
> >
> > On 7 May 2018 at 09:02, William Davis 
> wrote:
> >
> > > Sorry I meant to send this to the Log4Net distro
> > >
> > > On Mon, May 7, 2018 at 9:47 AM, Matt Sicker  wrote:
> > >
> > > > Like the Kafka appender's async option? Or like the async logger and
> > > > appenders?
> > > >
> > > > On 7 May 2018 at 07:38, Remko Popma  wrote:
> > > >
> > > > > Log4j core provides about 4 flavours of async logging, several of
> > which
> > > > > use non-blocking data structures.
> > > > >
> > > > > Can you link to the ones you think should be included?
> > > > >
> > > > > Thanks!
> > > > >
> > > > > Remko
> > > > >
> > > > > (Shameless plug) Every java main() method deserves
> > http://picocli.info
> > > > >
> > > > > > On May 7, 2018, at 14:15, William Davis <
> > william.j.dav...@gmail.com>
> > > > > wrote:
> > > > > >
> > > > > > I've noticed that there are several Async implementations of
> > standard
> > > > > > appenders out in the wild. Is there a reason none of these have
> > made
> > > > > there
> > > > > > way into the core product? Is it just b/c no one has taken the
> time
> > > to
> > > > > do a
> > > > > > pull request, or is there some other reason?
> > > > > >
> > > > > > I've had several projects where we need the non-blocking nature
> of
> > > > these
> > > > > > appenders to achieve desired performance.
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Matt Sicker 
> > > >
> > >
> >
> >
> >
> > --
> > Matt Sicker 
> >
>



-- 
Matt Sicker 

Re: Async Appenders

[William Davis]

Ok then, so are the same Async Appenders available in Log4Net that are in
Log4j ?
Here are some one I'm using:
https://github.com/cjbhaines/Log4Net.Async
(my .net standard port: https://github.com/wjdavis5/Log4Net.Async)
Also been looking into an Async Buffering Appender. Just seems we could get
so much more value out of the core product if these were rolled in. (And I
wouldnt have to struggle to get .net core support from ill maintained
repos.)



On Mon, May 7, 2018 at 10:04 AM, Matt Sicker  wrote:

> Oh, no worries, you're on the correct list!
>
> On 7 May 2018 at 09:02, William Davis  wrote:
>
> > Sorry I meant to send this to the Log4Net distro
> >
> > On Mon, May 7, 2018 at 9:47 AM, Matt Sicker  wrote:
> >
> > > Like the Kafka appender's async option? Or like the async logger and
> > > appenders?
> > >
> > > On 7 May 2018 at 07:38, Remko Popma  wrote:
> > >
> > > > Log4j core provides about 4 flavours of async logging, several of
> which
> > > > use non-blocking data structures.
> > > >
> > > > Can you link to the ones you think should be included?
> > > >
> > > > Thanks!
> > > >
> > > > Remko
> > > >
> > > > (Shameless plug) Every java main() method deserves
> http://picocli.info
> > > >
> > > > > On May 7, 2018, at 14:15, William Davis <
> william.j.dav...@gmail.com>
> > > > wrote:
> > > > >
> > > > > I've noticed that there are several Async implementations of
> standard
> > > > > appenders out in the wild. Is there a reason none of these have
> made
> > > > there
> > > > > way into the core product? Is it just b/c no one has taken the time
> > to
> > > > do a
> > > > > pull request, or is there some other reason?
> > > > >
> > > > > I've had several projects where we need the non-blocking nature of
> > > these
> > > > > appenders to achieve desired performance.
> > > >
> > >
> > >
> > >
> > > --
> > > Matt Sicker 
> > >
> >
>
>
>
> --
> Matt Sicker 
>

Re: [VOTE] Migrate git repositories to gitbox

[Matt Sicker]

And here is my +1.

This vote passes with 5 +1s binding and 1 +1 non-binding. I'll follow up
with the migration details over the next couple days.

On 30 April 2018 at 07:04, Apache  wrote:

> +1
>
> Ralph
>
>
> > On Apr 29, 2018, at 7:38 PM, Ílson Bolzan  wrote:
> >
> > +1
> >
> >> On Sun, Apr 29, 2018 at 3:20 PM, Matt Sicker  wrote:
> >>
> >> Good point on the clarification. I said all git repos, and that actually
> >> entails:
> >>
> >> * chainsaw
> >> * log4cxx
> >> * log4j2 and all its repos
> >> * log4net
> >> * log4php
> >> * parent pom
> >>
> >> In fact, the only repos this doesn't cover are the old log4j 1 svn repos
> >> that we have.
> >>
> >>> On 29 April 2018 at 05:08, Dominik Psenner  wrote:
> >>>
> >>> +1
> >>>
> >>> Also for the log4net repository.
> >>>
>  On Sat, 28 Apr 2018, 23:59 Remko Popma, 
> wrote:
> 
>  +1
> 
>  On Sat, Apr 28, 2018 at 11:48 PM, Gary Gregory <
> garydgreg...@gmail.com
> >>>
>  wrote:
> 
> > +1
> >
> > Gary
> >
> >> On Sat, Apr 28, 2018, 17:12 Matt Sicker  wrote:
> >>
> >> This is a vote to migrate from the existing git-wip-us
> >> infrastructure
>  to
> >> the currently supported gitbox infrastructure that Infra advocates
> >>> for
> >> using nowadays. Using gitbox will allow our projects to integrate
>  better
> >> with GitHub including the ability to merge PRs directly from the
> >> site
>  and
> >> the ability to push commits to GitHub and have them be
> >> automatically
> >> mirrored back to Apache. Not only that, but new Apache projects
> >>> cannot
> > use
> >> the old git-wip-us infrastructure anymore, so it makes sense to
> >>> migrate
> > to
> >> the best supported option going forward.
> >>
> >> The migration process will entail the following:
> >>
> >> * Marking existing git repo as read-only
> >> * Moving repo to gitbox
> >> * Update website and pom.xml with new SCM URLs
> >> * Update local git clones with the new remote URL(s)
> >>
> >> Note that this vote only applies to the source code. I'm not
>  considering
> >> using GitHub Issues instead of Jira, for example. Note also that
> >> this
> > vote
> >> does not apply to the use of subversion for publishing the site
> > (svnpubsub)
> >> nor the use of it for publishing releases (only available via svn),
> > though
> >> moving the sites from svnpubsub to gitpubsub (i.e., storing the
>  generated
> >> site in a branch called "asf-site", similar to the "gh-pages"
> >> branch
> >> feature on GitHub) would be a related topic to cover separately.
> >>
> >> Please vote +1, +0, -0, or -1.
> >>
> >> --
> >> Matt Sicker 
> >>
> >
> 
> >>>
> >>
> >>
> >>
> >> --
> >> Matt Sicker 
> >>
>
>
>


-- 
Matt Sicker 

Re: Async Appenders

[Matt Sicker]

Oh, no worries, you're on the correct list!

On 7 May 2018 at 09:02, William Davis  wrote:

> Sorry I meant to send this to the Log4Net distro
>
> On Mon, May 7, 2018 at 9:47 AM, Matt Sicker  wrote:
>
> > Like the Kafka appender's async option? Or like the async logger and
> > appenders?
> >
> > On 7 May 2018 at 07:38, Remko Popma  wrote:
> >
> > > Log4j core provides about 4 flavours of async logging, several of which
> > > use non-blocking data structures.
> > >
> > > Can you link to the ones you think should be included?
> > >
> > > Thanks!
> > >
> > > Remko
> > >
> > > (Shameless plug) Every java main() method deserves http://picocli.info
> > >
> > > > On May 7, 2018, at 14:15, William Davis 
> > > wrote:
> > > >
> > > > I've noticed that there are several Async implementations of standard
> > > > appenders out in the wild. Is there a reason none of these have made
> > > there
> > > > way into the core product? Is it just b/c no one has taken the time
> to
> > > do a
> > > > pull request, or is there some other reason?
> > > >
> > > > I've had several projects where we need the non-blocking nature of
> > these
> > > > appenders to achieve desired performance.
> > >
> >
> >
> >
> > --
> > Matt Sicker 
> >
>



-- 
Matt Sicker 

Re: Async Appenders

[William Davis]

Sorry I meant to send this to the Log4Net distro

On Mon, May 7, 2018 at 9:47 AM, Matt Sicker  wrote:

> Like the Kafka appender's async option? Or like the async logger and
> appenders?
>
> On 7 May 2018 at 07:38, Remko Popma  wrote:
>
> > Log4j core provides about 4 flavours of async logging, several of which
> > use non-blocking data structures.
> >
> > Can you link to the ones you think should be included?
> >
> > Thanks!
> >
> > Remko
> >
> > (Shameless plug) Every java main() method deserves http://picocli.info
> >
> > > On May 7, 2018, at 14:15, William Davis 
> > wrote:
> > >
> > > I've noticed that there are several Async implementations of standard
> > > appenders out in the wild. Is there a reason none of these have made
> > there
> > > way into the core product? Is it just b/c no one has taken the time to
> > do a
> > > pull request, or is there some other reason?
> > >
> > > I've had several projects where we need the non-blocking nature of
> these
> > > appenders to achieve desired performance.
> >
>
>
>
> --
> Matt Sicker 
>

Re: Async Appenders

[Remko Popma]

Log4j core provides about 4 flavours of async logging, several of which use 
non-blocking data structures. 

Can you link to the ones you think should be included?

Thanks!

Remko 

(Shameless plug) Every java main() method deserves http://picocli.info

> On May 7, 2018, at 14:15, William Davis  wrote:
> 
> I've noticed that there are several Async implementations of standard
> appenders out in the wild. Is there a reason none of these have made there
> way into the core product? Is it just b/c no one has taken the time to do a
> pull request, or is there some other reason?
> 
> I've had several projects where we need the non-blocking nature of these
> appenders to achieve desired performance.

Async Appenders

[William Davis]

I've noticed that there are several Async implementations of standard
appenders out in the wild. Is there a reason none of these have made there
way into the core product? Is it just b/c no one has taken the time to do a
pull request, or is there some other reason?

I've had several projects where we need the non-blocking nature of these
appenders to achieve desired performance.