[jira] [Commented] (SOLR-5020) Add final() method to DelegatingCollector
[ https://issues.apache.org/jira/browse/SOLR-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13703189#comment-13703189 ] Mikhail Khludnev commented on SOLR-5020: I second this feature, however I suppose it should be done on Lucene level ie. base Collector should has such method for notification and IndexSearcher should call it. Add final() method to DelegatingCollector - Key: SOLR-5020 URL: https://issues.apache.org/jira/browse/SOLR-5020 Project: Solr Issue Type: New Feature Components: search Affects Versions: 5.0 Reporter: Joel Bernstein Priority: Minor Fix For: 5.0 Attachments: SOLR-5020.patch This issue adds a final() method to the DelegatingCollector class so that it can be notified when collection is complete. The current collect() method assumes that the delegating collector will either forward on the document or not with each call. The final() method will allow DelegatingCollectors to have more sophisticated behavior. For example a Field Collapsing delegating collector could collapse the documents as the collect() method is being called. Then when the final() method is called it could pass the collapsed documents to the delegate collectors. This would allow grouping to be implemented within the PostFilter framework. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5020) Add final() method to DelegatingCollector
[ https://issues.apache.org/jira/browse/SOLR-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13703200#comment-13703200 ] Robert Muir commented on SOLR-5020: --- We discussed this on another issue (I think I may have opened it, not sure), the thing is that if someone calls search(Query, Filter, Collector), they know when its done, when this very method returns! I also tried to look at what it would take (even though it seems stupid for lucene), thinking it might make things easier somehow for people: and tried to test that all collectors were well-behaved, and its really complicated. So after review I think it doesnt make a lot of sense there. Add final() method to DelegatingCollector - Key: SOLR-5020 URL: https://issues.apache.org/jira/browse/SOLR-5020 Project: Solr Issue Type: New Feature Components: search Affects Versions: 5.0 Reporter: Joel Bernstein Priority: Minor Fix For: 5.0 Attachments: SOLR-5020.patch This issue adds a final() method to the DelegatingCollector class so that it can be notified when collection is complete. The current collect() method assumes that the delegating collector will either forward on the document or not with each call. The final() method will allow DelegatingCollectors to have more sophisticated behavior. For example a Field Collapsing delegating collector could collapse the documents as the collect() method is being called. Then when the final() method is called it could pass the collapsed documents to the delegate collectors. This would allow grouping to be implemented within the PostFilter framework. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5020) Add final() method to DelegatingCollector
[ https://issues.apache.org/jira/browse/SOLR-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13703492#comment-13703492 ] ASF subversion and git services commented on SOLR-5020: --- Commit 1501376 from [~yo...@apache.org] [ https://svn.apache.org/r1501376 ] SOLR-5020: add DelegatingCollector.final() Add final() method to DelegatingCollector - Key: SOLR-5020 URL: https://issues.apache.org/jira/browse/SOLR-5020 Project: Solr Issue Type: New Feature Components: search Affects Versions: 5.0 Reporter: Joel Bernstein Priority: Minor Fix For: 5.0 Attachments: SOLR-5020.patch This issue adds a final() method to the DelegatingCollector class so that it can be notified when collection is complete. The current collect() method assumes that the delegating collector will either forward on the document or not with each call. The final() method will allow DelegatingCollectors to have more sophisticated behavior. For example a Field Collapsing delegating collector could collapse the documents as the collect() method is being called. Then when the final() method is called it could pass the collapsed documents to the delegate collectors. This would allow grouping to be implemented within the PostFilter framework. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5020) Add final() method to DelegatingCollector
[ https://issues.apache.org/jira/browse/SOLR-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13703509#comment-13703509 ] ASF subversion and git services commented on SOLR-5020: --- Commit 1501383 from [~yo...@apache.org] [ https://svn.apache.org/r1501383 ] SOLR-5020: add DelegatingCollector.final() Add final() method to DelegatingCollector - Key: SOLR-5020 URL: https://issues.apache.org/jira/browse/SOLR-5020 Project: Solr Issue Type: New Feature Components: search Affects Versions: 5.0 Reporter: Joel Bernstein Priority: Minor Fix For: 5.0 Attachments: SOLR-5020.patch This issue adds a final() method to the DelegatingCollector class so that it can be notified when collection is complete. The current collect() method assumes that the delegating collector will either forward on the document or not with each call. The final() method will allow DelegatingCollectors to have more sophisticated behavior. For example a Field Collapsing delegating collector could collapse the documents as the collect() method is being called. Then when the final() method is called it could pass the collapsed documents to the delegate collectors. This would allow grouping to be implemented within the PostFilter framework. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
