[RESULT] [VOTE] Release Apache NLPCraft 0.5.0
NLPCraft-ers, The vote for a new release candidate is closed now. Vote result: The vote PASSES with 5 votes +1 and no -1. +1 votes: - Nikita Ivanov - Sergey Kamov - Furkan KAMACI - Sergey Makov - Paul King Thank you, -- Aaron Radzinski
Re: [VOTE] Release Apache NLPCraft 0.5.0 (incubating)
Hi,
+1 from me.
I checked:
- Incubating in name
- DISCLAIMER exists
- LICENSE and NOTICE are fine
- No unexpected binary files
- Checked PGP signatures
- Checked Checksums
- Code compiles and tests successfully run
Kind Regards,
Furkan KAMACI
On Wed, Apr 15, 2020 at 8:53 PM Nikita Ivanov wrote:
> NLPCraft-ers,
> The vote's timeline is over but we still need more votes. Can some of the
> mentors please vote? We need to move this forward...
>
> Thank you,
> --
> Nikita Ivanov
>
>
>
> On Tue, Apr 14, 2020 at 1:55 AM Paul King wrote:
>
> > +1 (with some comments below):
> >
> > Tested:
> > - signature okay
> > - checksums okay
> > - LICENSE, DISCLAIMER okay
> > - NOTICE has more than needed (lines 6-95 should be deleted for source
> zip,
> > I don't believe a showstopper but fix for next time)
> > - incubating in name
> > - mvn clean package (okay on Windows and Linux with JDK8 )
> > - mvn verify (okay on Windows and Linux with JDK8)
> > - mvn apache-rat:check -Prelease (okay but perhaps excludes too
> permissive)
> >
> > Comments
> > - KEYS present in the jar but should not be (I don't believe that is a
> > showstopper but remove next time). It's a separate channel verification
> > mechanism.
> > - KEYS should be in release area only, i.e.
> > https://downloads.apache.org/incubator/nlpcraft/KEYS (there should be a
> > single source of truth for this file - I suspect not a showstopper for
> > first release but can you move before incubator vote?)
> > - JDK version to use would be good to mention in email and README (I am
> not
> > a Maven guru but it seems that you have Maven enforcer configured to
> check
> > that at least JDK8 is used but not a maximum version, yet with JDK11 I
> get
> > an error during Scala compilation[1])
> > - I am unsure why the javadoc folder is needed in the source (it seems to
> > be rebuilt in target/apidocs? Or is that Scala specific files? If so, can
> > they not be built too? But I did notice some warnings[2] - perhaps that
> is
> > why?)
> > - The rat check excludes seem to exclude more than needed. In general,
> you
> > want to exclude the minimum possible files and only then if there is a
> > valid reason for each exclude. Rat would pass with reduced excludes [3].
> > - I did notice some other warnings[4][5] but given the JDK8 build
> > requirement, I believe they can be ignored.
> >
> > Cheers, Paul.
> >
> >
> >
> > [1] Error on Windows and Linux with JDK 11.0.6:
> > [ERROR] error: java.lang.NoClassDefFoundError: javax/tools/ToolProvider
> > [INFO] at
> > scala.reflect.io.JavaToolsPlatformArchive.iterator(ZipArchive.scala:301)
> > [INFO] ...
> > [ERROR] Failed to execute goal
> > net.alchim31.maven:scala-maven-plugin:3.3.1:compile (scala-compile-first)
> > on project nlpcraft: wrap: org.apache.commons.exec.ExecuteException:
> > Process exited with an error: -1 (Exit value: -1)
> >
> > [2] [WARNING] Javadoc Warnings [multiple warnings, one shown below]
> > [WARNING]
> >
> >
> D:\tmp\nlpcraft\050\apache-nlpcraft\src\main\scala\org\apache\nlpcraft\model\opencensus\NCZipkinExporter.java:21:
> > error: package org.apache.nlpcraft.common.config does not exist
> > [WARNING] import org.apache.nlpcraft.common.config.*;
> > [WARNING] ^
> > [WARNING]
> >
> >
> D:\tmp\nlpcraft\050\apache-nlpcraft\src\main\scala\org\apache\nlpcraft\model\opencensus\NCZipkinExporter.java:37:
> > error: cannot find symbol
> > [WARNING] private static class Config extends NCConfigurableJava {
> > [WARNING] ^
> > [WARNING] symbol: class NCConfigurableJava
> > [WARNING] location: class NCZipkinExporter
> >
> > [3] Rat check still passed with the following changes:
> > Removed:
> > docs/**/*
> > zips/**/*
> > LICENSE
> > KEYS
> > DISCLAIMER
> > NOTICE
> > **/*.html
> > **/*.txt
> > docs/**/*
> > Changes:
> > FROM:**/*.json
> > TO:
> > src/main/resources/geo/countries/*.json
> >
> > [4] [WARNING] Discovered module-info.class. Shading will break its strong
> > encapsulation. [multiple times]
> > [5] [WARNING] jaxb-impl-2.4.0-b180830.0438.jar, jaxb-runtime-2.3.2.jar
> > define 536 overlapping classes:[...details elided...][multiple similar
> > warnings]
> >
> >
> >
> > On Sun, Apr 12, 2020 at 6:23 AM Aaron Radzinski <
> aradzin...@datalingvo.com
> > >
> > wrote:
> >
> > > NLPCraft-ers,
> > > We've made another round of fixes. Note that the internal version of
> this
> > > release is now 0.5.0-rc1. If and when voted in - we'll simply upgrade
> the
> > > version to 0.5.0.
> > >
> > > NOTE: the 'dist' location has double 'nlpcraft' folders which may look
> > > suspicious. First 'nlpcraft' is a root for the project, while the
> second
> > > denotes core project name. Note
Re: [VOTE] Release Apache NLPCraft 0.5.0 (incubating)
NLPCraft-ers,
The vote's timeline is over but we still need more votes. Can some of the
mentors please vote? We need to move this forward...
Thank you,
--
Nikita Ivanov
On Tue, Apr 14, 2020 at 1:55 AM Paul King wrote:
> +1 (with some comments below):
>
> Tested:
> - signature okay
> - checksums okay
> - LICENSE, DISCLAIMER okay
> - NOTICE has more than needed (lines 6-95 should be deleted for source zip,
> I don't believe a showstopper but fix for next time)
> - incubating in name
> - mvn clean package (okay on Windows and Linux with JDK8 )
> - mvn verify (okay on Windows and Linux with JDK8)
> - mvn apache-rat:check -Prelease (okay but perhaps excludes too permissive)
>
> Comments
> - KEYS present in the jar but should not be (I don't believe that is a
> showstopper but remove next time). It's a separate channel verification
> mechanism.
> - KEYS should be in release area only, i.e.
> https://downloads.apache.org/incubator/nlpcraft/KEYS (there should be a
> single source of truth for this file - I suspect not a showstopper for
> first release but can you move before incubator vote?)
> - JDK version to use would be good to mention in email and README (I am not
> a Maven guru but it seems that you have Maven enforcer configured to check
> that at least JDK8 is used but not a maximum version, yet with JDK11 I get
> an error during Scala compilation[1])
> - I am unsure why the javadoc folder is needed in the source (it seems to
> be rebuilt in target/apidocs? Or is that Scala specific files? If so, can
> they not be built too? But I did notice some warnings[2] - perhaps that is
> why?)
> - The rat check excludes seem to exclude more than needed. In general, you
> want to exclude the minimum possible files and only then if there is a
> valid reason for each exclude. Rat would pass with reduced excludes [3].
> - I did notice some other warnings[4][5] but given the JDK8 build
> requirement, I believe they can be ignored.
>
> Cheers, Paul.
>
>
>
> [1] Error on Windows and Linux with JDK 11.0.6:
> [ERROR] error: java.lang.NoClassDefFoundError: javax/tools/ToolProvider
> [INFO] at
> scala.reflect.io.JavaToolsPlatformArchive.iterator(ZipArchive.scala:301)
> [INFO] ...
> [ERROR] Failed to execute goal
> net.alchim31.maven:scala-maven-plugin:3.3.1:compile (scala-compile-first)
> on project nlpcraft: wrap: org.apache.commons.exec.ExecuteException:
> Process exited with an error: -1 (Exit value: -1)
>
> [2] [WARNING] Javadoc Warnings [multiple warnings, one shown below]
> [WARNING]
>
> D:\tmp\nlpcraft\050\apache-nlpcraft\src\main\scala\org\apache\nlpcraft\model\opencensus\NCZipkinExporter.java:21:
> error: package org.apache.nlpcraft.common.config does not exist
> [WARNING] import org.apache.nlpcraft.common.config.*;
> [WARNING] ^
> [WARNING]
>
> D:\tmp\nlpcraft\050\apache-nlpcraft\src\main\scala\org\apache\nlpcraft\model\opencensus\NCZipkinExporter.java:37:
> error: cannot find symbol
> [WARNING] private static class Config extends NCConfigurableJava {
> [WARNING] ^
> [WARNING] symbol: class NCConfigurableJava
> [WARNING] location: class NCZipkinExporter
>
> [3] Rat check still passed with the following changes:
> Removed:
> docs/**/*
> zips/**/*
> LICENSE
> KEYS
> DISCLAIMER
> NOTICE
> **/*.html
> **/*.txt
> docs/**/*
> Changes:
> FROM:**/*.json
> TO:
> src/main/resources/geo/countries/*.json
>
> [4] [WARNING] Discovered module-info.class. Shading will break its strong
> encapsulation. [multiple times]
> [5] [WARNING] jaxb-impl-2.4.0-b180830.0438.jar, jaxb-runtime-2.3.2.jar
> define 536 overlapping classes:[...details elided...][multiple similar
> warnings]
>
>
>
> On Sun, Apr 12, 2020 at 6:23 AM Aaron Radzinski >
> wrote:
>
> > NLPCraft-ers,
> > We've made another round of fixes. Note that the internal version of this
> > release is now 0.5.0-rc1. If and when voted in - we'll simply upgrade the
> > version to 0.5.0.
> >
> > NOTE: the 'dist' location has double 'nlpcraft' folders which may look
> > suspicious. First 'nlpcraft' is a root for the project, while the second
> > denotes core project name. Note that we'll be releasing our sub-projects
> > (i.e. java client) under the root 'nlpcraft' folder so the dist location
> > will eventually have structure like this:
> > -- nlpcraft
> > |-- nlpcraft
> > |-- nlpcraft-java-client
> > |-- nlpcraft-web-ui
> >
> > Artifacts are under
> > https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/:
> > 1. Quick links for ZIP tarball
> > <
> >
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0-rc1.zip
> > >
> > (SHA256
> > <
> >
>
[jira] [Updated] (NLPCRAFT-37) NCModel#onMatchedIntent behaviour
[ https://issues.apache.org/jira/browse/NLPCRAFT-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Kamov updated NLPCRAFT-37: - Description: 1) We can't use super.onMatchedIntent in implementations because NCModel is the interface. Maybe better to have constant default values? 2) If onMatchedIntent returns false and single variant found, we have an endless cycle. Users can check it on the probe side, but maybe safer to check it on the server-side and throw some error? 3) onMatchedIntent should return boolean and sometimes throw an exception. Maybe better to return some enumeration values? (Note that some `on` methods can throw rejection exception, but some can't. ) was: 1) We can't use super.onMatchedIntent in implementations because NCModel is interface. Maybe better to have constant default values? 2) If onMatchedIntent returns false and single variant found, we have endless cycle. User can check it on probe side, but maybe safer to check it on server side and throw some error? > NCModel#onMatchedIntent behaviour > - > > Key: NLPCRAFT-37 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-37 > Project: NLPCraft > Issue Type: Improvement > Components: probe >Reporter: Sergey Kamov >Assignee: Aaron Radzinski >Priority: Major > Fix For: 0.6.0 > > > 1) We can't use super.onMatchedIntent in implementations because NCModel is > the interface. > Maybe better to have constant default values? > 2) If onMatchedIntent returns false and single variant found, we have an > endless cycle. > Users can check it on the probe side, but maybe safer to check it on the > server-side and throw some error? > 3) onMatchedIntent should return boolean and sometimes throw an exception. > Maybe better to return some enumeration values? (Note that some `on` methods > can throw rejection exception, but some can't. ) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NLPCRAFT-37) NCModel#onMatchedIntent behaviour
Sergey Kamov created NLPCRAFT-37: Summary: NCModel#onMatchedIntent behaviour Key: NLPCRAFT-37 URL: https://issues.apache.org/jira/browse/NLPCRAFT-37 Project: NLPCraft Issue Type: Improvement Components: probe Reporter: Sergey Kamov Assignee: Aaron Radzinski Fix For: 0.6.0 1) We can't use super.onMatchedIntent in implementations because NCModel is interface. Maybe better to have constant default values? 2) If onMatchedIntent returns false and single variant found, we have endless cycle. User can check it on probe side, but maybe safer to check it on server side and throw some error? -- This message was sent by Atlassian Jira (v8.3.4#803005)
