[jira] [Commented] (OFBIZ-4837) Separator Error in data file tools
[ https://issues.apache.org/jira/browse/OFBIZ-4837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501147#comment-14501147 ] Deepak Dixit commented on OFBIZ-4837: - Thanks Gil Portenseigne and Aditya. Your patch has been committed at following revision: Trunk at r#1674447 14.12 at r#1674448 13.07 at r#1674449 12.04 at r#1674450 > Separator Error in data file tools > -- > > Key: OFBIZ-4837 > URL: https://issues.apache.org/jira/browse/OFBIZ-4837 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Gil Portenseigne >Assignee: Deepak Dixit >Priority: Minor > Labels: data, parsing > Fix For: 14.12.01, 12.04.06, 13.07.02, Upcoming Branch > > Attachments: OFBIZ-4837.patch, OFBIZ-4837.patch, OFBIZ-4837_2.patch, > dataDefinition.xml, dataSample.csv, result.xml, resultBefore.xml > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > In https://demo-trunk.ofbiz.apache.org/webtools/control/viewdatafile > There is a bug when defining simple separator (for instance ",") in > definition file, and when in data file a string data contains the separator. > This one sould not be interpreted in data parsing. > To illustrate a bit more, i add small sample files to reproduce the problem. > And the patch which fix the bug. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-4837) Separator Error in data file tools
[ https://issues.apache.org/jira/browse/OFBIZ-4837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259955#comment-13259955 ] Erwan de FERRIERES commented on OFBIZ-4837: --- Hi Gil, there is no need to rename your patches, Jira is directly deactivating the oldest one. Also, maybe the best test to explain your work is to add unit tests. thanks > Separator Error in data file tools > -- > > Key: OFBIZ-4837 > URL: https://issues.apache.org/jira/browse/OFBIZ-4837 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Gil Portenseigne >Priority: Minor > Labels: data, parsing > Attachments: OFBIZ-4837.patch, OFBIZ-4837_2.patch, > dataDefinition.xml, dataSample.csv, result.xml, resultBefore.xml > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > In https://demo-trunk.ofbiz.apache.org/webtools/control/viewdatafile > There is a bug when defining simple separator (for instance ",") in > definition file, and when in data file a string data contains the separator. > This one sould not be interpreted in data parsing. > To illustrate a bit more, i add small sample files to reproduce the problem. > And the patch which fix the bug. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4837) Separator Error in data file tools
[ https://issues.apache.org/jira/browse/OFBIZ-4837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259665#comment-13259665 ] Gil Portenseigne commented on OFBIZ-4837: - I didn't comment the code : I add strVal != null, to avoid NPE The while loop is here to concatene the string value until the ending string separator is found. > Separator Error in data file tools > -- > > Key: OFBIZ-4837 > URL: https://issues.apache.org/jira/browse/OFBIZ-4837 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Gil Portenseigne >Priority: Minor > Labels: data, parsing > Attachments: OFBIZ-4837.patch, dataDefinition.xml, dataSample.csv, > result.xml, resultBefore.xml > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > In https://demo-trunk.ofbiz.apache.org/webtools/control/viewdatafile > There is a bug when defining simple separator (for instance ",") in > definition file, and when in data file a string data contains the separator. > This one sould not be interpreted in data parsing. > To illustrate a bit more, i add small sample files to reproduce the problem. > And the patch which fix the bug. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
