[jira] [Commented] (PROTON-2236) [proton-j] Error message when decoding illegal message properties key is unhelpful
[ https://issues.apache.org/jira/browse/PROTON-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161337#comment-17161337 ] ASF subversion and git services commented on PROTON-2236: - Commit c5d306193ba89a07b7070c362d28cc1699c5a8ee in qpid-proton-j's branch refs/heads/master from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=qpid-proton-j.git;h=c5d3061 ] PROTON-2236: restore prior usage of DecodeException and fix up some other cases > [proton-j] Error message when decoding illegal message properties key is > unhelpful > -- > > Key: PROTON-2236 > URL: https://issues.apache.org/jira/browse/PROTON-2236 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-j >Reporter: Kim van der Riet >Priority: Trivial > Fix For: proton-j-0.34.0 > > > While decoding a message containing a non-string application-properties key > (eg a symbol key), then the following message is seen: > {{Error on transform: Expected String type but found encoding: -93}} > which is not very intuitive. Perhaps converting the type to hex and providing > a stringified version would be better, such as: > {{Expected String type but found encoding 0xb3 (symbol)}} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2236) [proton-j] Error message when decoding illegal message properties key is unhelpful
[ https://issues.apache.org/jira/browse/PROTON-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125208#comment-17125208 ] ASF subversion and git services commented on PROTON-2236: - Commit 9adf419eab623e363422bf89d79b5884c747a644 in qpid-proton-j's branch refs/heads/master from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=qpid-proton-j.git;h=9adf419 ] PROTON-2236 Report more meaningful unexpected encoding errors When the decoder reads a type encoding that does not match the encoding code of the primitive type expected then report a more menaingful error including the type expected and the type / code that was read, or unknown / code if type code read is not valid. > [proton-j] Error message when decoding illegal message properties key is > unhelpful > -- > > Key: PROTON-2236 > URL: https://issues.apache.org/jira/browse/PROTON-2236 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-j >Reporter: Kim van der Riet >Priority: Trivial > > While decoding a message containing a non-string application-properties key > (eg a symbol key), then the following message is seen: > {{Error on transform: Expected String type but found encoding: -93}} > which is not very intuitive. Perhaps converting the type to hex and providing > a stringified version would be better, such as: > {{Expected String type but found encoding 0xb3 (symbol)}} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2236) [proton-j] Error message when decoding illegal message properties key is unhelpful
[ https://issues.apache.org/jira/browse/PROTON-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124255#comment-17124255 ] ASF subversion and git services commented on PROTON-2236: - Commit 9adf419eab623e363422bf89d79b5884c747a644 in qpid-proton-j's branch refs/heads/PROTON-2236 from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=qpid-proton-j.git;h=9adf419 ] PROTON-2236 Report more meaningful unexpected encoding errors When the decoder reads a type encoding that does not match the encoding code of the primitive type expected then report a more menaingful error including the type expected and the type / code that was read, or unknown / code if type code read is not valid. > [proton-j] Error message when decoding illegal message properties key is > unhelpful > -- > > Key: PROTON-2236 > URL: https://issues.apache.org/jira/browse/PROTON-2236 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-j >Reporter: Kim van der Riet >Priority: Trivial > > While decoding a message containing a non-string application-properties key > (eg a symbol key), then the following message is seen: > {{Error on transform: Expected String type but found encoding: -93}} > which is not very intuitive. Perhaps converting the type to hex and providing > a stringified version would be better, such as: > {{Expected String type but found encoding 0xb3 (symbol)}} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2236) [proton-j] Error message when decoding illegal message properties key is unhelpful
[ https://issues.apache.org/jira/browse/PROTON-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124065#comment-17124065 ] Robbie Gemmell commented on PROTON-2236: I'd definitely agree about the hex. A stringed version will require some added hoops, which I'm not sure add enough to warrant given its pretty clear already what was found is not-string as is required. Something to consider though. > [proton-j] Error message when decoding illegal message properties key is > unhelpful > -- > > Key: PROTON-2236 > URL: https://issues.apache.org/jira/browse/PROTON-2236 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-j >Reporter: Kim van der Riet >Priority: Trivial > > While decoding a message containing a non-string application-properties key > (eg a symbol key), then the following message is seen: > {{Error on transform: Expected String type but found encoding: -93}} > which is not very intuitive. Perhaps converting the type to hex and providing > a stringified version would be better, such as: > {{Expected String type but found encoding 0xb3 (symbol)}} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org