Re: Review Request 71603: RANGER-2613: Public API for listing roles needs to return a Java list of RangerRole objects

2019-10-09 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71603/#review218166
---


Ship it!




Ship It!

- Madhan Neethiraj


On Oct. 9, 2019, 10:54 p.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71603/
> ---
> 
> (Updated Oct. 9, 2019, 10:54 p.m.)
> 
> 
> Review request for ranger, kalyan kumar kalvagadda, Madhan Neethiraj, and 
> Ramesh Mani.
> 
> 
> Bugs: RANGER-2613
> https://issues.apache.org/jira/browse/RANGER-2613
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> PublicAPIsv2 provides a REST endpoint to retrieve Roles defined in Ranger 
> Admin. This API needs to return a plain Java list of Ranger Roles to the 
> caller (instead of an enhanced, internal Java object more suitable for GUI 
> consumption).
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 
> f329d1775 
> 
> 
> Diff: https://reviews.apache.org/r/71603/diff/2/
> 
> 
> Testing
> ---
> 
> Ran all unit tests successfully
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>

Re: Review Request 71603: RANGER-2613: Public API for listing roles needs to return a Java list of RangerRole objects

2019-10-09 Thread Abhay Kulkarni 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71603/
---

(Updated Oct. 9, 2019, 10:54 p.m.)


Review request for ranger, kalyan kumar kalvagadda, Madhan Neethiraj, and 
Ramesh Mani.


Changes
---

Address review comment


Bugs: RANGER-2613
https://issues.apache.org/jira/browse/RANGER-2613


Repository: ranger


Description
---

PublicAPIsv2 provides a REST endpoint to retrieve Roles defined in Ranger 
Admin. This API needs to return a plain Java list of Ranger Roles to the caller 
(instead of an enhanced, internal Java object more suitable for GUI 
consumption).


Diffs (updated)
-

  security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 
f329d1775 


Diff: https://reviews.apache.org/r/71603/diff/2/

Changes: https://reviews.apache.org/r/71603/diff/1-2/


Testing
---

Ran all unit tests successfully


Thanks,

Abhay Kulkarni

Re: Review Request 71603: RANGER-2613: Public API for listing roles needs to return a Java list of RangerRole objects

2019-10-09 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71603/#review218165
---




security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java
Line 123 (original), 122 (patched)


Please review if 'RangerSecurityZoneList' should be replaced with 
List.


- Madhan Neethiraj


On Oct. 9, 2019, 9:45 p.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71603/
> ---
> 
> (Updated Oct. 9, 2019, 9:45 p.m.)
> 
> 
> Review request for ranger, kalyan kumar kalvagadda, Madhan Neethiraj, and 
> Ramesh Mani.
> 
> 
> Bugs: RANGER-2613
> https://issues.apache.org/jira/browse/RANGER-2613
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> PublicAPIsv2 provides a REST endpoint to retrieve Roles defined in Ranger 
> Admin. This API needs to return a plain Java list of Ranger Roles to the 
> caller (instead of an enhanced, internal Java object more suitable for GUI 
> consumption).
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 
> f329d1775 
> 
> 
> Diff: https://reviews.apache.org/r/71603/diff/1/
> 
> 
> Testing
> ---
> 
> Ran all unit tests successfully
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>

Re: Review Request 71603: RANGER-2613: Public API for listing roles needs to return a Java list of RangerRole objects

2019-10-09 Thread Ramesh Mani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71603/#review218164
---


Ship it!




Ship It!

- Ramesh Mani


On Oct. 9, 2019, 9:45 p.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71603/
> ---
> 
> (Updated Oct. 9, 2019, 9:45 p.m.)
> 
> 
> Review request for ranger, kalyan kumar kalvagadda, Madhan Neethiraj, and 
> Ramesh Mani.
> 
> 
> Bugs: RANGER-2613
> https://issues.apache.org/jira/browse/RANGER-2613
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> PublicAPIsv2 provides a REST endpoint to retrieve Roles defined in Ranger 
> Admin. This API needs to return a plain Java list of Ranger Roles to the 
> caller (instead of an enhanced, internal Java object more suitable for GUI 
> consumption).
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 
> f329d1775 
> 
> 
> Diff: https://reviews.apache.org/r/71603/diff/1/
> 
> 
> Testing
> ---
> 
> Ran all unit tests successfully
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>