[GitHub] [rocketmq] vongosling commented on issue #1386: [ISSUE #1388]Add lite pull consumer support for RocketMQ
vongosling commented on issue #1386: [ISSUE #1388]Add lite pull consumer support for RocketMQ URL: https://github.com/apache/rocketmq/pull/1386#issuecomment-521582716 The unit test coverage does not meet the commit checklist, please do not tick it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-spring] RongtongJin commented on issue #119: fix #117
RongtongJin commented on issue #119: fix #117 URL: https://github.com/apache/rocketmq-spring/pull/119#issuecomment-521610351 @vongosling @ShannonDing Could you help merge this pr? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-externals] yiliuchen opened a new issue #386: [rocketmq-replicator] sourceTaskTopicList can not be empty
yiliuchen opened a new issue #386: [rocketmq-replicator] sourceTaskTopicList can not be empty URL: https://github.com/apache/rocketmq-externals/issues/386 The issue tracker is **ONLY** used for bug report and feature request. Any question or RocketMQ proposal please use our [mailing lists](http://rocketmq.apache.org/about/contact/). **BUG REPORT** 1. Please describe the issue you observed:  - What did you do (The steps to reproduce)? - What did you expect to see? - What did you see instead? 2. Please tell us about your environment: 3. Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc): **FEATURE REQUEST** 1. Please describe the feature you are requesting. 2. Provide any additional detail on your proposed use case for this feature. 2. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue? 4. If there are some sub-tasks using -[] for each subtask and create a corresponding issue to map to the sub task: - [sub-task1-issue-number](example_sub_issue1_link_here): sub-task1 description here, - [sub-task2-issue-number](example_sub_issue2_link_here): sub-task2 description here, - ... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq] coveralls edited a comment on issue #1352: [RIP-15]Add Ipv6 support for RocketMQ
coveralls edited a comment on issue #1352: [RIP-15]Add Ipv6 support for RocketMQ URL: https://github.com/apache/rocketmq/pull/1352#issuecomment-516737962 [](https://coveralls.io/builds/25152730) Coverage increased (+0.6%) to 51.185% when pulling **1377887cd2312e47b9884ec6b0220047a74e558b on supercym:IPV6** into **be7c6dd219c250a289ebf7d6d23d2a2b61f32f70 on apache:IPV6**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-spring] RongtongJin commented on issue #118: consumer.subscribe is not valid
RongtongJin commented on issue #118: consumer.subscribe is not valid URL: https://github.com/apache/rocketmq-spring/issues/118#issuecomment-521609443 You can set filter expression by setting selectorExpression like this： ```@RocketMQMessageListener (topic = “xxx”, selectorExpression = “yyy”, consumerGroup = “zzz”)``` It is not recommended to invoke subscribe again in the prepareStart method. If you subscribe the same topic in this method, the original filter expression will be overwritten. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-externals] yiliuchen closed issue #351: [rocketmq-replicator] sourceTask and sinkTask rmq client must setInstanceName
yiliuchen closed issue #351: [rocketmq-replicator] sourceTask and sinkTask rmq client must setInstanceName URL: https://github.com/apache/rocketmq-externals/issues/351 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-client-go] wenfengwang closed pull request #152: [ISSUE #151] Optimize PullConsumer API
wenfengwang closed pull request #152: [ISSUE #151] Optimize PullConsumer API URL: https://github.com/apache/rocketmq-client-go/pull/152 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq] wutongpeng opened a new pull request #1389: Merge pull request #1 from apache/master
wutongpeng opened a new pull request #1389: Merge pull request #1 from apache/master URL: https://github.com/apache/rocketmq/pull/1389 更新代码 ## What is the purpose of the change X ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq] wutongpeng closed pull request #1389: Merge pull request #1 from apache/master
wutongpeng closed pull request #1389: Merge pull request #1 from apache/master URL: https://github.com/apache/rocketmq/pull/1389 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq] vongosling commented on a change in pull request #1386: [ISSUE #1388]Add lite pull consumer support for RocketMQ
vongosling commented on a change in pull request #1386: [ISSUE #1388]Add lite
pull consumer support for RocketMQ
URL: https://github.com/apache/rocketmq/pull/1386#discussion_r314216890
##
File path:
example/src/main/java/org/apache/rocketmq/example/simple/LitePullConsumer.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.example.simple;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import org.apache.rocketmq.client.consumer.DefaultLitePullConsumer;
+import org.apache.rocketmq.common.message.MessageExt;
+import org.apache.rocketmq.common.message.MessageQueue;
+
+public class LitePullConsumer {
+public static void main(String[] args) throws Exception {
+DefaultLitePullConsumer litePullConsumer = new
DefaultLitePullConsumer("please_rename_unique_group_name");
+litePullConsumer.setAutoCommit(false);
+litePullConsumer.start();
+Collection mqSet =
litePullConsumer.fetchMessageQueues("TopicTest");
+List list = new ArrayList<>(mqSet);
+Collection assginMq =
Collections.singletonList(list.get(0));
+litePullConsumer.assign(assginMq);
+int size = 0;
+litePullConsumer.seek(list.get(0), 26);
+
+while (true) {
Review comment:
No jump out from the while true and application quit logic.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] wenfengwang closed pull request #157: [ISSUE #147] support domain of namrsrv
wenfengwang closed pull request #157: [ISSUE #147] support domain of namrsrv URL: https://github.com/apache/rocketmq-client-go/pull/157 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-client-go] zongtanghu merged pull request #156: update defaultConsumer.client init AND add push_consumer testing
zongtanghu merged pull request #156: update defaultConsumer.client init AND add push_consumer testing URL: https://github.com/apache/rocketmq-client-go/pull/156 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-client-go] wenfengwang commented on issue #158: [ISSUE #151] Optimize PullConsumer API
wenfengwang commented on issue #158: [ISSUE #151] Optimize PullConsumer API URL: https://github.com/apache/rocketmq-client-go/pull/158#issuecomment-521869637 aligin https://github.com/apache/rocketmq/pull/1386 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-client-go] codecov-io commented on issue #141: [ISSUE#120] update strategy and add offset_store test
codecov-io commented on issue #141: [ISSUE#120] update strategy and add offset_store test URL: https://github.com/apache/rocketmq-client-go/pull/141#issuecomment-521882656 # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/141?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`native@79058cc`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `83.87%`. [](https://codecov.io/gh/apache/rocketmq-client-go/pull/141?src=pr=tree) ```diff @@Coverage Diff@@ ## native #141 +/- ## = Coverage ? 24.47% = Files ? 42 Lines ? 4453 Branches ?0 = Hits ? 1090 Misses? 3225 Partials ? 138 ``` | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/141?src=pr=tree) | Coverage Δ | | |---|---|---| | [internal/utils/helper.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/141/diff?src=pr=tree#diff-aW50ZXJuYWwvdXRpbHMvaGVscGVyLmdv) | `0% <ø> (ø)` | | | [consumer/option.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/141/diff?src=pr=tree#diff-Y29uc3VtZXIvb3B0aW9uLmdv) | `33.33% <0%> (ø)` | | | [consumer/strategy.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/141/diff?src=pr=tree#diff-Y29uc3VtZXIvc3RyYXRlZ3kuZ28=) | `86.45% <88.13%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/141?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/141?src=pr=footer). Last update [79058cc...0f82ff9](https://codecov.io/gh/apache/rocketmq-client-go/pull/141?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-externals] duhenglucky commented on a change in pull request #370: [ISSUE #371]Develop Jdbc Source Connector
duhenglucky commented on a change in pull request #370: [ISSUE #371]Develop
Jdbc Source Connector
URL: https://github.com/apache/rocketmq-externals/pull/370#discussion_r314552921
##
File path:
rocketmq-connect-jdbc/src/test/java/org/apache/rocketmq/connect/jdbc/connector/JdbcSourceTaskTest.java
##
@@ -16,29 +16,88 @@
*/
package org.apache.rocketmq.connect.jdbc.connector;
+
import java.util.Collection;
-import org.junit.Test;
+import java.util.HashMap;
+import java.util.Map;
+
+import javax.sql.DataSource;
+import org.junit.Test;
+import java.sql.*;
+import com.alibaba.druid.pool.DruidDataSourceFactory;
import io.openmessaging.KeyValue;
+import io.openmessaging.connector.api.Task;
import io.openmessaging.connector.api.data.SourceDataEntry;
import io.openmessaging.internal.DefaultKeyValue;
public class JdbcSourceTaskTest {
+ KeyValue kv;
+ DataSource dataSource;
+
+ @Test
+ public void testBulk() throws InterruptedException {
Review comment:
Please mock the real database connection in unite test.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] codecov-io commented on issue #158: [ISSUE #151] Optimize PullConsumer API
codecov-io commented on issue #158: [ISSUE #151] Optimize PullConsumer API URL: https://github.com/apache/rocketmq-client-go/pull/158#issuecomment-521868994 # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/158?src=pr=h1) Report > Merging [#158](https://codecov.io/gh/apache/rocketmq-client-go/pull/158?src=pr=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/1e69007667ff887fbbcc44192a91a9064e59e5c6?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/rocketmq-client-go/pull/158?src=pr=tree) ```diff @@ Coverage Diff @@ ## native#158 +/- ## == Coverage20.3% 20.3% == Files 42 42 Lines44024402 == Hits 894 894 Misses 33893389 Partials 119 119 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/158?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/158?src=pr=footer). Last update [1e69007...ffd48d7](https://codecov.io/gh/apache/rocketmq-client-go/pull/158?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-externals] duhenglucky merged pull request #348: [ISSUE #345]merge rmq client
duhenglucky merged pull request #348: [ISSUE #345]merge rmq client URL: https://github.com/apache/rocketmq-externals/pull/348 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-externals] yiliuchen closed issue #345: [RocketMQ-Connect-Runtime] When the namesrv environment is different，create different rmq client by setInstanceName
yiliuchen closed issue #345: [RocketMQ-Connect-Runtime] When the namesrv environment is different，create different rmq client by setInstanceName URL: https://github.com/apache/rocketmq-externals/issues/345 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-externals] yiliuchen closed issue #349: [RocketMQ-Connect-Runtime] merge rmq task client
yiliuchen closed issue #349: [RocketMQ-Connect-Runtime] merge rmq task client URL: https://github.com/apache/rocketmq-externals/issues/349 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-spring] RongtongJin commented on issue #108: How to send SQL92 filter msg in RocketMQTemplate?
RongtongJin commented on issue #108: How to send SQL92 filter msg in RocketMQTemplate? URL: https://github.com/apache/rocketmq-spring/issues/108#issuecomment-521864156 @whoamigodson Sorry, it is not supported yet. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-client-go] jonnxu merged pull request #145: [ISSUE #144] Fix nil pointer when file not exist
jonnxu merged pull request #145: [ISSUE #144] Fix nil pointer when file not exist URL: https://github.com/apache/rocketmq-client-go/pull/145 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-spring] RongtongJin commented on issue #107: Two consumer instances consume the same message, and some messages are not consumed
RongtongJin commented on issue #107: Two consumer instances consume the same message, and some messages are not consumed URL: https://github.com/apache/rocketmq-spring/issues/107#issuecomment-521865529 @whoamigodson Currently, you can temporarily solve this issue by implementing RocketMQPushConsumerLifecycleListener and setting a unique instanceName in prepareStart. Contributors are welcome to solve this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-spring] RongtongJin commented on issue #99: the message was consumed twice because of the same instanceName
RongtongJin commented on issue #99: the message was consumed twice because of the same instanceName URL: https://github.com/apache/rocketmq-spring/issues/99#issuecomment-521865669 @xiaotanxingchen Currently, you can temporarily solve this issue by implementing RocketMQPushConsumerLifecycleListener and setting a unique instanceName in prepareStart. Contributors are welcome to solve this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-client-go] wenfengwang opened a new pull request #158: [ISSUE #151] Optimize PullConsumer API
wenfengwang opened a new pull request #158: [ISSUE #151] Optimize PullConsumer API URL: https://github.com/apache/rocketmq-client-go/pull/158 ## What is the purpose of the change Optimize PullConsumer API ## Brief changelog align LiteConsumer of RocektMQ ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq] areyouok opened a new issue #1390: Slave crash break HA of transaction message
areyouok opened a new issue #1390: Slave crash break HA of transaction message URL: https://github.com/apache/rocketmq/issues/1390 Setup a cluster with 4 brokers: (master1/slave1), (master2/slave2) Kill master1, RocketMQ producer client will send all message to master2 after a while. The cluster is still available. Kill slave1, RocketMQ producer client still send 50% message to master1 and get sendStatus=SLAVE_NOT_AVAILABLE, the message is not committed. So there are 50% messages will fail and the cluster never recover. To solve this problem we need 2 slaves for each master. Is there any setting to change this behavior? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
