[jira] [Commented] (SLING-3350) Simplify Feature Flags API
[ https://issues.apache.org/jira/browse/SLING-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13886376#comment-13886376 ] Felix Meschberger commented on SLING-3350: -- Adapted the Resource Resolver implementation to the simplified API in Rev. 1562713 Simplify Feature Flags API -- Key: SLING-3350 URL: https://issues.apache.org/jira/browse/SLING-3350 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: Feature Flags 1.0.0 Attachments: SLING-3350.patch The Feature Flags API currently is quite complex involving a helper object making query for FeatureFlag status quite complex. Also, setting the current context is clumsy with (currently) two filters. I propose a few changes: (a) Remove ClientContext object. Checking for feature enablement should be as simple as just calling Features.isEnabled(featureName). Currently the curent ClientContext has to be retrieved and then the isEnabled method being called there. (b) Feature flag values are egerly evaluated. This should be done on demand making the context setup much quicker and light-weight. For added performance the evaluation results can still be cached. (c) The duplicate filter can be removed by code directly grabbing the ResourceResolver from the request attribute just like the SlingMainServlet does (thanks CarstenZ for the hint). (d) We don't currently need the explicit context management because the servlet filter does that directly using internal API. (e) I wonder, whether we need all these feature accessors in the Features service, some look like convenience methods, particularly the one of getFeatureNames and getFeatures. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (SLING-2986) Merged Resource Provider
[ https://issues.apache.org/jira/browse/SLING-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13886378#comment-13886378 ] Carsten Ziegeler commented on SLING-2986: - I've reimplemented the listChildren method to rely on getResource and make the MergedResource object immutable. This puts handling of the special properties in a single place Merged Resource Provider Key: SLING-2986 URL: https://issues.apache.org/jira/browse/SLING-2986 Project: Sling Issue Type: New Feature Components: Extensions Reporter: Gilles Knobloch Assignee: Carsten Ziegeler Fix For: Resource Merger 1.0.0 Attachments: SLING-2986-WithService.zip, SLING-2986.zip As exchanged once with Felix Meschberger, the idea is to implement a custom resource provider, with ability to merge multiple resources based on your search paths. For instance, if your search paths are /apps /libs Hitting /merge/my/resource/is/here will check /apps/my/resource/is/here /libs/my/resource/is/here There are some options like: - add/override property - delete a property of the resource under /libs - reorder nodes if available I intend to submit this patch as soon as possible. Code is currently located at https://github.com/gknob/sling-resourcemerger -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (SLING-3345) Regression of SLING-1414
[
https://issues.apache.org/jira/browse/SLING-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated SLING-3345:
Fix Version/s: JCR Resource 2.3.0
Regression of SLING-1414
Key: SLING-3345
URL: https://issues.apache.org/jira/browse/SLING-3345
Project: Sling
Issue Type: Bug
Components: JCR
Affects Versions: JCR Resource 2.2.8
Environment: GNU/Linux 2.6.18-274.18.1.el5
java version 1.7.0
Java(TM) SE Runtime Environment (build 1.7.0-b147)
Java HotSpot(TM) 64-Bit Server VM (build 21.0-b17, mixed mode)
Reporter: Olaf Otto
Assignee: Carsten Ziegeler
Fix For: JCR Resource 2.3.0
The issue described in SLING-1414 arises only on JDK 1.7 on the previously
described Linux platform. It can be assumed that there is a platform-specific
deviation in compiler behavior, as the issue does not arise in MacOs or
Windows environments:
{code}
Caused by: java.lang.IllegalAccessException: Class javax.el.BeanELResolver
can not access a member of class
org.apache.sling.jcr.resource.internal.helper.jcr.JcrItemResource with
modifiers public
at sun.reflect.Reflection.ensureMemberAccess(Reflection.java:95)
at
java.lang.reflect.AccessibleObject.slowCheckMemberAccess(AccessibleObject.java:261)
at
java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:253)
at java.lang.reflect.Method.invoke(Method.java:594)
at javax.el.BeanELResolver.getValue(BeanELResolver.java:62)
{code}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (SLING-2919) Support handlebars as a scripting language
[ https://issues.apache.org/jira/browse/SLING-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13886414#comment-13886414 ] Ian Boston commented on SLING-2919: --- [~Pushparajan] Its implemented at http://svn.apache.org/repos/asf/sling/whiteboard/ieb/handlebars/ but not extensively tested. There didn't appear to be much interest so I didn't take it any further. Support handlebars as a scripting language -- Key: SLING-2919 URL: https://issues.apache.org/jira/browse/SLING-2919 Project: Sling Issue Type: New Feature Components: Scripting Reporter: Ian Boston Assignee: Ian Boston Handlebars.js is a popular scripting language used client side. The markup is simple and straightforward, much like velocity in some ways, but without any of the confusion ove template or MVC. There is a version of Handlebars for java that uses an identical template language and appears to be well supported and has some nice features such as pre-compiling scripts serverside into Javascript functions and modules. (not all that relevant for server side scripting, but interesting none the less). I am going to experiment with a Sling Script engine in the whiteboard area to see if its viable to use handlebars java as an alternative to JSP. Handlebars Java, A2 Liencesed: https://github.com/jknack/handlebars.java -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (SLING-3352) Expose OSGI configuration as JCR nodes
Marius Petria created SLING-3352: Summary: Expose OSGI configuration as JCR nodes Key: SLING-3352 URL: https://issues.apache.org/jira/browse/SLING-3352 Project: Sling Issue Type: Improvement Reporter: Marius Petria We need a safe way to expose OSGI configuration via HTTP. Requirements: - all configs for a certain factory should be manageable - they should have associated JCR nodes that contain the config properties - only configs that are available through ConfigurationAdmin should be available - the HTTP urls should have friendly names - (Optional) the implementation should be general enough to be used for other configs other than replication if needed For example: a configuration with name publish for org.apache.sling.replication.agent.impl.ReplicationAgentServiceFactory should be mapped to /etc/replication/agent/publish Problems with current implementation of JCR nodes created by JCR installed: - Configuration files are read and created from /apps/.../config or /libs/.../config, and there is no easy way to determine which are active in the ConfigurationAdmin - There is no way to restrict a repository path to create only configuration from a specified factory (making it unusable with relaxed ACLs) - The url of a configuration is unfriendly (it contains the fully qualified name of the factory) - The node types are not homogenous making it hard to use in a client application (some are nt:file, some are sling:OsgiConfig) -- This message was sent by Atlassian JIRA (v6.1.5#6160)
Re: Trunk build fails: missing Features.isEnabled method in ResourceResolverContext
+1..move 2014-01-30 Bertrand Delacretaz bdelacre...@apache.org: Hi, On Thu, Jan 30, 2014 at 9:53 AM, Felix Meschberger fmesc...@adobe.com wrote: ...Hmm, are contrib bundles built separately from the oder bundles ? If so, we should wait for contrib to have built The builds are totally independent, and we don't have contrib builds on http://ci.apache.org/ so far. ...Maybe, it is also time to move the featureflags from contrib to bundles... Yes, I think we aim to support it anyway, so +1 on moving. -Bertrand -- Carsten Ziegeler cziege...@apache.org
[VOTE] Release Apache Sling JCR API 2.2.0, JCR Base 2.2.0 and JCR Resource 2.3.0
Hi, this vote is about three related modules in the jcr space, apart from bug fixes it contains the base for the replacement of login administrative JCR API 2.2.0 https://issues.apache.org/jira/browse/SLING/fixforversion/12315316 JCR Base 2.2.0 https://issues.apache.org/jira/browse/SLING/fixforversion/12319516 JCR Resource https://issues.apache.org/jira/browse/SLING/fixforversion/12324379 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1008 You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1008 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This vote will be open for 72 hours. Regards Carsten -- Carsten Ziegeler cziege...@apache.org
Re: [VOTE] Release Apache Sling JCR API 2.2.0, JCR Base 2.2.0 and JCR Resource 2.3.0
+1 2014-01-30 Carsten Ziegeler cziege...@apache.org: Hi, this vote is about three related modules in the jcr space, apart from bug fixes it contains the base for the replacement of login administrative JCR API 2.2.0 https://issues.apache.org/jira/browse/SLING/fixforversion/12315316 JCR Base 2.2.0 https://issues.apache.org/jira/browse/SLING/fixforversion/12319516 JCR Resource https://issues.apache.org/jira/browse/SLING/fixforversion/12324379 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1008 You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1008 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This vote will be open for 72 hours. Regards Carsten -- Carsten Ziegeler cziege...@apache.org -- Carsten Ziegeler cziege...@apache.org
[jira] [Created] (SLING-3353) Move feature flags bundle to bundles (out of contrib)
Felix Meschberger created SLING-3353: Summary: Move feature flags bundle to bundles (out of contrib) Key: SLING-3353 URL: https://issues.apache.org/jira/browse/SLING-3353 Project: Sling Issue Type: Task Components: Extensions Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: Feature Flags 1.0.0 As discussed on dev@ the feature flags project should be moved from contrib to prime time. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Resolved] (SLING-3353) Move feature flags bundle to bundles (out of contrib)
[ https://issues.apache.org/jira/browse/SLING-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger resolved SLING-3353. -- Resolution: Fixed Moved in Rev. 1562757 Move feature flags bundle to bundles (out of contrib) - Key: SLING-3353 URL: https://issues.apache.org/jira/browse/SLING-3353 Project: Sling Issue Type: Task Components: Extensions Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: Feature Flags 1.0.0 As discussed on dev@ the feature flags project should be moved from contrib to prime time. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (SLING-3354) Search paths are returned in wrong order
Carsten Ziegeler created SLING-3354: --- Summary: Search paths are returned in wrong order Key: SLING-3354 URL: https://issues.apache.org/jira/browse/SLING-3354 Project: Sling Issue Type: Bug Components: Testing Affects Versions: Testing ResourceResolver Mock 0.1.0 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Testing ResourceResolver Mock 0.2.0 The resource resolver returns the default search paths in the wrong order -- This message was sent by Atlassian JIRA (v6.1.5#6160)
buildbot success in ASF Buildbot on sling-trunk
The Buildbot has detected a restored build on builder sling-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/sling-trunk/builds/220 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: osiris_ubuntu Build Reason: scheduler Build Source Stamp: [branch sling/trunk] 1562757 Blamelist: fmeschbe Build succeeded! sincerely, -The Buildbot
[jira] [Resolved] (SLING-3354) Search paths are returned in wrong order
[ https://issues.apache.org/jira/browse/SLING-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3354. - Resolution: Fixed Fixed, I've also updated the project to the latest api Search paths are returned in wrong order Key: SLING-3354 URL: https://issues.apache.org/jira/browse/SLING-3354 Project: Sling Issue Type: Bug Components: Testing Affects Versions: Testing ResourceResolver Mock 0.1.0 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Testing ResourceResolver Mock 0.2.0 The resource resolver returns the default search paths in the wrong order -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (SLING-3352) Expose OSGI configuration as JCR nodes
[ https://issues.apache.org/jira/browse/SLING-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13886461#comment-13886461 ] Marius Petria commented on SLING-3352: -- The HTTP endpoints for replication were implemented in SLING-3315. However that implementation relies on a custom ResourceProvider and ResourceAccessSecurity to security. That triggered objections (in a private discussion with some people including [~tripod] and [~cziegeler]) that was followed by the recommendation to base security on shadow nodes rather than on access security gates. In general if osgi configs are to be used by admins through configuration console and also through HTTP by restricted users we should work out a way to provide such a functionality in a way that is secure (links a resource path with a configuration factory) and easy to use (should allow modification of content via standard servlets). The synchronization does not look that bad. - When the sync agent is activated copies all configs from ConfigurationAdmin to the desired location. - Any change to the content or to the configuration triggers an update to the related entity. Updates are made only if content is really changed to prevent circular updates. - When the sync agent is deactivate all copies are deleted. Expose OSGI configuration as JCR nodes -- Key: SLING-3352 URL: https://issues.apache.org/jira/browse/SLING-3352 Project: Sling Issue Type: Improvement Reporter: Marius Petria Labels: replication We need a safe way to expose OSGI configuration via HTTP. Requirements: - all configs for a certain factory should be manageable - they should have associated JCR nodes that contain the config properties - only configs that are available through ConfigurationAdmin should be available - the HTTP urls should have friendly names - (Optional) the implementation should be general enough to be used for other configs other than replication if needed For example: a configuration with name publish for org.apache.sling.replication.agent.impl.ReplicationAgentServiceFactory should be mapped to /etc/replication/agent/publish Problems with current implementation of JCR nodes created by JCR installed: - Configuration files are read and created from /apps/.../config or /libs/.../config, and there is no easy way to determine which are active in the ConfigurationAdmin - There is no way to restrict a repository path to create only configuration from a specified factory (making it unusable with relaxed ACLs) - The url of a configuration is unfriendly (it contains the fully qualified name of the factory) - The node types are not homogenous making it hard to use in a client application (some are nt:file, some are sling:OsgiConfig) -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (SLING-2986) Merged Resource Provider
[ https://issues.apache.org/jira/browse/SLING-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13886467#comment-13886467 ] Carsten Ziegeler commented on SLING-2986: - Added some basic tests Merged Resource Provider Key: SLING-2986 URL: https://issues.apache.org/jira/browse/SLING-2986 Project: Sling Issue Type: New Feature Components: Extensions Reporter: Gilles Knobloch Assignee: Carsten Ziegeler Fix For: Resource Merger 1.0.0 Attachments: SLING-2986-WithService.zip, SLING-2986.zip As exchanged once with Felix Meschberger, the idea is to implement a custom resource provider, with ability to merge multiple resources based on your search paths. For instance, if your search paths are /apps /libs Hitting /merge/my/resource/is/here will check /apps/my/resource/is/here /libs/my/resource/is/here There are some options like: - add/override property - delete a property of the resource under /libs - reorder nodes if available I intend to submit this patch as soon as possible. Code is currently located at https://github.com/gknob/sling-resourcemerger -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (SLING-3352) Expose OSGI configuration as JCR nodes
[ https://issues.apache.org/jira/browse/SLING-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13886473#comment-13886473 ] Bertrand Delacretaz commented on SLING-3352: bq. The synchronization does not look that bad Is that demonstrated by automated tests? Expose OSGI configuration as JCR nodes -- Key: SLING-3352 URL: https://issues.apache.org/jira/browse/SLING-3352 Project: Sling Issue Type: Improvement Reporter: Marius Petria Labels: replication We need a safe way to expose OSGI configuration via HTTP. Requirements: - all configs for a certain factory should be manageable - they should have associated JCR nodes that contain the config properties - only configs that are available through ConfigurationAdmin should be available - the HTTP urls should have friendly names - (Optional) the implementation should be general enough to be used for other configs other than replication if needed For example: a configuration with name publish for org.apache.sling.replication.agent.impl.ReplicationAgentServiceFactory should be mapped to /etc/replication/agent/publish Problems with current implementation of JCR nodes created by JCR installed: - Configuration files are read and created from /apps/.../config or /libs/.../config, and there is no easy way to determine which are active in the ConfigurationAdmin - There is no way to restrict a repository path to create only configuration from a specified factory (making it unusable with relaxed ACLs) - The url of a configuration is unfriendly (it contains the fully qualified name of the factory) - The node types are not homogenous making it hard to use in a client application (some are nt:file, some are sling:OsgiConfig) -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (SLING-3352) Expose OSGI configuration as JCR nodes
[ https://issues.apache.org/jira/browse/SLING-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13886477#comment-13886477 ] Carsten Ziegeler commented on SLING-3352: - I just would like to comment why we shouldn't use the sling:osgiconfig nodes used by the installer, these nodes are spread across the repository and might not reflect current state of the ConfigurationAdmin. These configurations might have been created through other providers of the installer (like the launchpad one or the file provider) or the installer wasn't running while a configuration has been changed etc. In addition, configuration nodes stored in the repo might be shadowed by others having higher precedence. So the only truth is the configuration admin. Or in short, the config nodes are not a 1:1 copy of the state in the configuration admin. Expose OSGI configuration as JCR nodes -- Key: SLING-3352 URL: https://issues.apache.org/jira/browse/SLING-3352 Project: Sling Issue Type: Improvement Reporter: Marius Petria Labels: replication We need a safe way to expose OSGI configuration via HTTP. Requirements: - all configs for a certain factory should be manageable - they should have associated JCR nodes that contain the config properties - only configs that are available through ConfigurationAdmin should be available - the HTTP urls should have friendly names - (Optional) the implementation should be general enough to be used for other configs other than replication if needed For example: a configuration with name publish for org.apache.sling.replication.agent.impl.ReplicationAgentServiceFactory should be mapped to /etc/replication/agent/publish Problems with current implementation of JCR nodes created by JCR installed: - Configuration files are read and created from /apps/.../config or /libs/.../config, and there is no easy way to determine which are active in the ConfigurationAdmin - There is no way to restrict a repository path to create only configuration from a specified factory (making it unusable with relaxed ACLs) - The url of a configuration is unfriendly (it contains the fully qualified name of the factory) - The node types are not homogenous making it hard to use in a client application (some are nt:file, some are sling:OsgiConfig) -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (SLING-3352) Expose OSGI configuration as JCR nodes
[ https://issues.apache.org/jira/browse/SLING-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13886485#comment-13886485 ] Marius Petria commented on SLING-3352: -- [~bdelacretaz] my affirmation is not backed up by automated tests (I will try to write some before submiting the patch). I just wanted to show the scope of the syncronization, meaning that nodes need to exist only during the lifetime of the synchronization agent, they are not a persistence mechanism, just an access mechanism. Of course it might be tricky to implement it and especially hard to test in a multithreaded environment. Because of that I am planning to propose the patch only for replication and use it as a proof of concept for something that maybe is worth generalized. Expose OSGI configuration as JCR nodes -- Key: SLING-3352 URL: https://issues.apache.org/jira/browse/SLING-3352 Project: Sling Issue Type: Improvement Reporter: Marius Petria Labels: replication We need a safe way to expose OSGI configuration via HTTP. Requirements: - all configs for a certain factory should be manageable - they should have associated JCR nodes that contain the config properties - only configs that are available through ConfigurationAdmin should be available - the HTTP urls should have friendly names - (Optional) the implementation should be general enough to be used for other configs other than replication if needed For example: a configuration with name publish for org.apache.sling.replication.agent.impl.ReplicationAgentServiceFactory should be mapped to /etc/replication/agent/publish Problems with current implementation of JCR nodes created by JCR installed: - Configuration files are read and created from /apps/.../config or /libs/.../config, and there is no easy way to determine which are active in the ConfigurationAdmin - There is no way to restrict a repository path to create only configuration from a specified factory (making it unusable with relaxed ACLs) - The url of a configuration is unfriendly (it contains the fully qualified name of the factory) - The node types are not homogenous making it hard to use in a client application (some are nt:file, some are sling:OsgiConfig) -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Resolved] (SLING-3355) Add helper methods for creating resources
[ https://issues.apache.org/jira/browse/SLING-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3355. - Resolution: Fixed New Helper class to create resources: MockHelper.create(resolver).resource(/libs).p(prop, value) .resource(sub).p(sub, hello) .resource(/apps).p(foo, baa).commit() Add helper methods for creating resources - Key: SLING-3355 URL: https://issues.apache.org/jira/browse/SLING-3355 Project: Sling Issue Type: Improvement Components: Testing Affects Versions: Testing ResourceResolver Mock 0.1.0 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Testing ResourceResolver Mock 0.2.0 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (SLING-3355) Add helper methods for creating resources
Carsten Ziegeler created SLING-3355: --- Summary: Add helper methods for creating resources Key: SLING-3355 URL: https://issues.apache.org/jira/browse/SLING-3355 Project: Sling Issue Type: Improvement Components: Testing Affects Versions: Testing ResourceResolver Mock 0.1.0 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Testing ResourceResolver Mock 0.2.0 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (SLING-3351) org.apache.sling.jcr.resource.JcrResourceUtil.setProperty method doesn't handle primitive arrays
[
https://issues.apache.org/jira/browse/SLING-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13886614#comment-13886614
]
Alexei Krainiouk commented on SLING-3351:
-
Sorry for not submitting proper patch, - I was having troubles checking out
your project yesterday.
org.apache.sling.jcr.resource.JcrResourceUtil.setProperty method doesn't
handle primitive arrays
Key: SLING-3351
URL: https://issues.apache.org/jira/browse/SLING-3351
Project: Sling
Issue Type: Bug
Components: JCR
Affects Versions: JCR Resource 2.2.8
Reporter: Alexei Krainiouk
Assignee: Carsten Ziegeler
Fix For: JCR Resource 2.3.0
org.apache.sling.jcr.resource.JcrResourceUtil.setProperty(Node, String,
Object) method throws ClassCastException if primitive array is passed as a
property value.
The reason is that the method implementation attempts cast propertyValue
parameter to Object[] directly after detecting that the property class is an
array (see
http://svn.apache.org/repos/asf/sling/trunk/bundles/jcr/resource/src/main/java/org/apache/sling/jcr/resource/JcrResourceUtil.java
lines 176:177):
} else if ( propertyValue.getClass().isArray() ) {
final Object[] values = (Object[])propertyValue;
.
This doesn't take into account that primitive arrays are not subclasses of
Object[] thus leading to ClassCastException.
Here is the fixed version of setProperty method:
public static void setProperty(final Node node,
final String propertyName,
final Object propertyValue)
throws RepositoryException {
if ( propertyValue == null ) {
node.setProperty(propertyName, (String)null);
} else if ( propertyValue.getClass().isArray() ) {
final int length = Array.getLength(propertyValue);
final Value[] setValues = new Value[length];
for(int i=0; ilength; i++) {
Object value = Array.get(propertyValue, i);
setValues[i] = createValue(value, node.getSession());
}
node.setProperty(propertyName, setValues);
} else {
node.setProperty(propertyName, createValue(propertyValue,
node.getSession()));
}
}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[VOTE] Release Testing Resource Resolver Mock 0.2.0
Hi, this vote is about Testing Resource Resolver Mock 0.2.0 We've fixed one issue and improved the usability: https://issues.apache.org/jira/browse/SLING/fixforversion/12324344https://issues.apache.org/jira/browse/SLING-2944 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1009 You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1009 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This vote will be open for 72 hours. Regards Carsten
[jira] [Created] (SLING-3356) Expose the import queue for reverse replication through ReplicationAgent interface
Marius Petria created SLING-3356: Summary: Expose the import queue for reverse replication through ReplicationAgent interface Key: SLING-3356 URL: https://issues.apache.org/jira/browse/SLING-3356 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Marius Petria The replication agent should have 3 main queues (the request queue, the transport queue and the response queue). These queues should be accessible and manageable through ReplicationAgent interface. This issue relates to the implementation of the response queue inside the ReplicationAgent and making it accessible through ReplicationAgent.getQueue API. The response queue is the queue where reverse replication on author stores packages from publish. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (SLING-3356) Expose the import queue for reverse replication through ReplicationAgent interface
[ https://issues.apache.org/jira/browse/SLING-3356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marius Petria updated SLING-3356: - Attachment: SLING-3356.patch - Moved packages from a transporthandler into the agent through a callback - When a transport handler receives an answer it can call a queue processor and add the item to the response queue. The item will then be imported using the default packagebuilder. Additional refactorings: - made the queue providers, queue strategies and transport handler interfaces take the agentname as a parameter in order to allow them to be used by multiple agents. (they only take the name in order to minimize their exposure to the agent api) - added a passive mode configuration to the agent to make it only store the packages, not auto process it. Expose the import queue for reverse replication through ReplicationAgent interface -- Key: SLING-3356 URL: https://issues.apache.org/jira/browse/SLING-3356 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Marius Petria Labels: replication Attachments: SLING-3356.patch The replication agent should have 3 main queues (the request queue, the transport queue and the response queue). These queues should be accessible and manageable through ReplicationAgent interface. This issue relates to the implementation of the response queue inside the ReplicationAgent and making it accessible through ReplicationAgent.getQueue API. The response queue is the queue where reverse replication on author stores packages from publish. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (SLING-3100) Provide a m2e project configurator for packaging content-package
[ https://issues.apache.org/jira/browse/SLING-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13886765#comment-13886765 ] Konrad Windszus commented on SLING-3100: The discussion in mailing list is at http://www.mail-archive.com/dev@sling.apache.org/msg24616.html. Basically the content-package-maven-plugin is about to become open-source as well. Provide a m2e project configurator for packaging content-package -- Key: SLING-3100 URL: https://issues.apache.org/jira/browse/SLING-3100 Project: Sling Issue Type: New Feature Components: IDE Affects Versions: Sling Eclipse IDE 1.0.0 Reporter: Konrad Windszus Fix For: Sling Eclipse IDE 1.0.2 Attachments: SLING-3100-m2e-integration.patch To set up the appropriate project configuration just from the POM an according m2e project configurator is needed (http://wiki.eclipse.org/M2E_plugin_execution_not_covered#delegate_to_a_project_configurator_.28recommended.29) The m2e-war-plugin comes with a project configurator which works also for content-packages pretty well but it is currently hard to reuse for any other packaging than war (due to the delegate pattern being used internally, compare with https://bugs.eclipse.org/bugs/show_bug.cgi?id=412213). Only if the project is having the dynamic web project facet the following features in Eclipse are supported: - JSP include directives (considered for validation and supports ctrl+click to open linked file) - Tag Library Support ( http://wiki.eclipse.org/WTP_FAQ#Why_isn.27t_the_JSP_editor.2Fvalidator_finding_my_custom_tag_libraries.3F ) - probably other features as well. Apart from that a feature like overlays should be supported ( https://bugs.eclipse.org/bugs/show_bug.cgi?id=384154 ), as often content-package projects are referencing JSPs from other projects, and the IDE needs to know those, to complete the validation. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (SLING-3352) Expose OSGI configuration as JCR nodes
[ https://issues.apache.org/jira/browse/SLING-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13886852#comment-13886852 ] Tobias Bocanegra commented on SLING-3352: - bq. You might also want to provide the HTTP endpoint as a node in the repository that you protect. let's look at the special case of replication agents: IMO what is needed is to have 1 JCR node for each replication agent (or agent group) that has a special resource type and will be protected by JCR ACLs. If those nodes also contain the properties of the respective OSGi configuration is not relevant. the servlet behind the resource type should create a response derived from the OSGi config. but it might also include other, more dynamic information, like # of pending items. the service should also listen for config admin changes and create/remove(/update) the nodes. I agree with felix, that adding a 2-way sync might result it a mess - but would simplify the management of course. note: if the config properties are also mapped to the node, you can use the norma json-get to read the data. Expose OSGI configuration as JCR nodes -- Key: SLING-3352 URL: https://issues.apache.org/jira/browse/SLING-3352 Project: Sling Issue Type: Improvement Reporter: Marius Petria Labels: replication We need a safe way to expose OSGI configuration via HTTP. Requirements: - all configs for a certain factory should be manageable - they should have associated JCR nodes that contain the config properties - only configs that are available through ConfigurationAdmin should be available - the HTTP urls should have friendly names - (Optional) the implementation should be general enough to be used for other configs other than replication if needed For example: a configuration with name publish for org.apache.sling.replication.agent.impl.ReplicationAgentServiceFactory should be mapped to /etc/replication/agent/publish Problems with current implementation of JCR nodes created by JCR installed: - Configuration files are read and created from /apps/.../config or /libs/.../config, and there is no easy way to determine which are active in the ConfigurationAdmin - There is no way to restrict a repository path to create only configuration from a specified factory (making it unusable with relaxed ACLs) - The url of a configuration is unfriendly (it contains the fully qualified name of the factory) - The node types are not homogenous making it hard to use in a client application (some are nt:file, some are sling:OsgiConfig) -- This message was sent by Atlassian JIRA (v6.1.5#6160)
Re: [VOTE] Release Apache Sling Auth Core 1.1.6
Am Dienstag, 28. Januar 2014 schrieb Carsten Ziegeler: Hi, I think we should cut a release of Sling Auth Core 1.1.6 which fixes one bug https://issues.apache.org/jira/browse/SLING/fixforversion/12325026 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1006 You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1006 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This vote will be open for 72 hours. +1 O. Regards Carsten
Re: [VOTE] Release Service User Mapper 1.0.0
Am Mittwoch, 29. Januar 2014 schrieb Carsten Ziegeler: Hi, this vote is about the first release of the Servic User Mapper to replace administrative logins https://issues.apache.org/jira/browse/SLING-2944 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1007 You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1007 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This vote will be open for 72 hours. -0 prefer String ServiceUserMapper#getServiceUserId(Bundle, String) and module should be placed in bundles as it's not optional (an extension) for new org.apache.sling.jcr.base O. Regards Carsten
Re: [VOTE] Release Apache Sling JCR API 2.2.0, JCR Base 2.2.0 and JCR Resource 2.3.0
Am Donnerstag, 30. Januar 2014 schrieb Carsten Ziegeler: Hi, this vote is about three related modules in the jcr space, apart from bug fixes it contains the base for the replacement of login administrative JCR API 2.2.0 https://issues.apache.org/jira/browse/SLING/fixforversion/12315316 JCR Base 2.2.0 https://issues.apache.org/jira/browse/SLING/fixforversion/12319516 JCR Resource https://issues.apache.org/jira/browse/SLING/fixforversion/12324379 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1008 You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1008 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This vote will be open for 72 hours. +1 O. Regards Carsten
[jira] [Resolved] (SLING-3335) Create Configuration Printer to output available injectors
[ https://issues.apache.org/jira/browse/SLING-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-3335. --- Resolution: Fixed Assignee: Justin Edelson configuration printer added in r1563047 Create Configuration Printer to output available injectors -- Key: SLING-3335 URL: https://issues.apache.org/jira/browse/SLING-3335 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Sling Models Implementation 1.0.0 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (SLING-3357) Support the use of constructor injection of the adaptable
Justin Edelson created SLING-3357: - Summary: Support the use of constructor injection of the adaptable Key: SLING-3357 URL: https://issues.apache.org/jira/browse/SLING-3357 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Sling Models Implementation 1.0.0 Model objects should be able to have a single-argument constructor which can be invoked with the adaptable itself. If a single-argument and zero-argument constructor are both provided, the single-argument constructor should be used. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Assigned] (SLING-3334) Explicitly define and document service.ranking for standard Injectors
[ https://issues.apache.org/jira/browse/SLING-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson reassigned SLING-3334: - Assignee: Justin Edelson service ranking set in r 1563048 Explicitly define and document service.ranking for standard Injectors - Key: SLING-3334 URL: https://issues.apache.org/jira/browse/SLING-3334 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Sling Models Implementation 1.0.0 The standard Injectors should be explicitly ordered and this order should be documented. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Resolved] (SLING-3357) Support the use of constructor injection of the adaptable
[ https://issues.apache.org/jira/browse/SLING-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-3357. --- Resolution: Fixed support for construction injection added in r 1563049 Support the use of constructor injection of the adaptable - Key: SLING-3357 URL: https://issues.apache.org/jira/browse/SLING-3357 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Sling Models Implementation 1.0.0 Model objects should be able to have a single-argument constructor which can be invoked with the adaptable itself. If a single-argument and zero-argument constructor are both provided, the single-argument constructor should be used. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Resolved] (SLING-3334) Explicitly define and document service.ranking for standard Injectors
[ https://issues.apache.org/jira/browse/SLING-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-3334. --- Resolution: Fixed documentation updated to reflect ordering of injectors Explicitly define and document service.ranking for standard Injectors - Key: SLING-3334 URL: https://issues.apache.org/jira/browse/SLING-3334 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Sling Models Implementation 1.0.0 The standard Injectors should be explicitly ordered and this order should be documented. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
buildbot failure in ASF Buildbot on sling-trunk
The Buildbot has detected a new failure on builder sling-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/sling-trunk/builds/228 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: osiris_ubuntu Build Reason: scheduler Build Source Stamp: [branch sling/trunk] 1563055 Blamelist: justin BUILD FAILED: failed compile sincerely, -The Buildbot
[VOTE] Release Apache Sling Models API Implementation 1.0.0
Hi, This is the first release of these projects. Documentation is up to date on http://sling.apache.org/documentation/bundles/models.html Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1010/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1010 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This vote will be open for 72 hours.
Re: [VOTE] Release Apache Sling HealthCheck Core 1.1.0 and Webconsole 1.1.0
We're missing one binding vote, anyone? 2014-01-28 Bertrand Delacretaz bdelacre...@apache.org: Hi, On Mon, Jan 27, 2014 at 5:49 PM, Carsten Ziegeler cziege...@apache.org wrote: ...Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1005... +1 for the release, checked signatures, build and that the following archives match the corresponding svn tags: MD5 (./org.apache.sling.hc.core/1.1.0/org.apache.sling.hc.core-1.1.0-source-release.zip) = 4de92074fe0db29858ab19e46450bd8f MD5 (./org.apache.sling.hc.webconsole/1.1.0/org.apache.sling.hc.webconsole-1.1.0-source-release.zip) = 8af4495f9c4d8271f81a9b66658ada21 -Bertrand -- Carsten Ziegeler cziege...@apache.org
Re: [VOTE] Release Apache Sling Auth Core 1.1.6
We're still missing one binding vote, anyone? 2014-01-30 Oliver Lietz apa...@oliverlietz.de: Am Dienstag, 28. Januar 2014 schrieb Carsten Ziegeler: Hi, I think we should cut a release of Sling Auth Core 1.1.6 which fixes one bug https://issues.apache.org/jira/browse/SLING/fixforversion/12325026 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1006 You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1006 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This vote will be open for 72 hours. +1 O. Regards Carsten -- Carsten Ziegeler cziege...@apache.org
Re: [VOTE] Release Apache Sling Auth Core 1.1.6
+1 Regards Felix Am 28.01.2014 um 08:50 schrieb Carsten Ziegeler cziege...@apache.org: Hi, I think we should cut a release of Sling Auth Core 1.1.6 which fixes one bug https://issues.apache.org/jira/browse/SLING/fixforversion/12325026 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1006 You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1006 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This vote will be open for 72 hours. Regards Carsten -- Carsten Ziegeler cziege...@apache.org
[VOTE RESULT] Release Apache Sling Auth Core 1.1.6
The vote passed with three binding +1 votes from Felix Meschberger, Bertrand Delacretaz, and Carsten Ziegeler and one non-binding +1 vote from Oliver Lietz. Thanks everyone for voting, I'll continue with the release process. Regards Carsten -- Carsten Ziegeler cziege...@apache.org
