[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #163: [draft] remove toobig check
sonarcloud[bot] commented on PR #163: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/163#issuecomment-1523834272 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter=163) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=163=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=163=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=163=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=163=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #166: SLING-11837 - Align index definition generation logic with the one from Oak
sonarcloud[bot] commented on PR #166: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/166#issuecomment-1523832209 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter=166) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=166=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=166=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=166=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=166=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=166=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=166=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=166=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=166=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=166=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=166=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=166=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=166=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=166=new_coverage=list) [88.9% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=166=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=166=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=166=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #137: Bump gson from 2.8.6 to 2.8.9
sonarcloud[bot] commented on PR #137: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/137#issuecomment-1523831641 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter=137) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=137=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=137=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=137=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] enapps-enorman commented on pull request #155: SLING-11836 - Add Jakarta JSON support to the Sling Starter
enapps-enorman commented on PR #155: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/155#issuecomment-1523764136 > @enapps-enorman - I did try using the SPIFly bundle locally, but I think I did not do it properly. There is some discussion about it at [osgi/osgi#434](https://github.com/osgi/osgi/issues/434) and also a larger discussion about ServiceLoader at [osgi/osgi#372](https://github.com/osgi/osgi/issues/372). > > I will try again the SPIFly approach. I haven't done much testing, but I think something like this should work: https://github.com/eclipse-ee4j/parsson/compare/master...enapps-enorman:parsson:use-osgi-serviceloader-mediator -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-sling-mock] raducotescu merged pull request #21: SLING-11852 - Make the ThreadsafeMockAdapterManagerWrapper use an InheritableThreadLocal
raducotescu merged PR #21: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-11849) Create osgiContext#unregisterService() for easy unregistering of services
[
https://issues.apache.org/jira/browse/SLING-11849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716762#comment-17716762
]
Stefan Seifert commented on SLING-11849:
the usual way in OSGi to unregister a service is to call the {{unregister}}
methods on the service registration instance.
context.registerService is just a convenience method and does not return the
service registration, but the registered service instance.
in case you need to unregister a service in the unit test (i think that does
happen only in rare cases), register the service directly via
context.bundleContext() and keep the reference to the service registration.
> Create osgiContext#unregisterService() for easy unregistering of services
> -
>
> Key: SLING-11849
> URL: https://issues.apache.org/jira/browse/SLING-11849
> Project: Sling
> Issue Type: Improvement
> Components: Testing
>Affects Versions: Testing OSGi Mock 3.3.6
>Reporter: Henry Kuijpers
>Priority: Major
>
> Since we can do:
> {code:java}
> this.underTest = context.registerInjectActivateService(Test.class);
> {code}
> it would be very useful if we can also do:
> {code:java}
> context.unregisterService(this.underTest);
> {code}
> for example.
> It would be very convenient to do this, since the OSGi Mock API is easy and
> simple to write and to be able to unregister services, it would be needed to
> have a ServiceRegistration and also a ServiceReference to be able
> to call .unregister() on it
> If we add this method, then all this logic can be put in this method.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…
sonarcloud[bot] commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-1523404500 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-servlets-resolver=7) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=7=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=7=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=7=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_coverage=list) [70.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #31: SLING-11558 part1: remove the LocationIterator
sonarcloud[bot] commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/31#issuecomment-1523402641 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-servlets-resolver=31) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=31=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=31=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=31=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=31=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=31=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=31=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=31=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling Servlet Helpers 1.4.6, Testing JCR Mock 1.6.8, Testing Sling Mock 3.4.6
+1 > On 24 Apr 2023, at 02:28, Eric Norman wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ...
[GitHub] [sling-org-apache-sling-testing-sling-mock] sonarcloud[bot] commented on pull request #21: SLING-11852 - Make the ThreadsafeMockAdapterManagerWrapper use an InheritableThreadLocal
sonarcloud[bot] commented on PR #21: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/21#issuecomment-1523341428 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-sling-mock=21) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=21=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=21=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=21=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=21=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=21=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=21=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-sling-mock=21=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-sling-mock=21=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-sling-mock=21=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=21=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=21=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=21=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock=21=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock=21=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock=21=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock=21=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-sling-mock] raducotescu commented on pull request #21: SLING-11852 - Make the ThreadsafeMockAdapterManagerWrapper use an InheritableThreadLocal
raducotescu commented on PR #21: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/21#issuecomment-1523334748 @stefanseifert, could you please tell me if you're ok with this tiny change? It was the least invasive way to fix my test setup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (SLING-11852) Make the ThreadsafeMockAdapterManagerWrapper use an InheritableThreadLocal
[
https://issues.apache.org/jira/browse/SLING-11852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu reassigned SLING-11852:
Assignee: Radu Cotescu
> Make the ThreadsafeMockAdapterManagerWrapper use an InheritableThreadLocal
> --
>
> Key: SLING-11852
> URL: https://issues.apache.org/jira/browse/SLING-11852
> Project: Sling
> Issue Type: Improvement
> Components: Testing
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Testing Sling Mock 3.4.8
>
>
> For scenarios where the mocked OSGi framework executes calls in other threads
> than the test thread (e.g. servlets under test in Jetty), the only way to
> pass the test's {{AdapterManager}} is to directly call
> {{{}SlingAdaptable#setAdapterManager{}}}. However, this will affect tests
> starting after this initial call.
> A better solution would be to make the
> {{org.apache.sling.testing.mock.sling.ThreadsafeMockAdapterManagerWrapper#THREAD_LOCAL}}
> an {{{}InheritableThreadLocal{}}}. This would allow the tests to still be
> executable in parallel, but threads started from a test thread (e.g. the
> servlets under test in Jetty) could inherit the thread local context.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-11852) Make the ThreadsafeMockAdapterManagerWrapper use an InheritableThreadLocal
Radu Cotescu created SLING-11852:
Summary: Make the ThreadsafeMockAdapterManagerWrapper use an
InheritableThreadLocal
Key: SLING-11852
URL: https://issues.apache.org/jira/browse/SLING-11852
Project: Sling
Issue Type: Improvement
Components: Testing
Reporter: Radu Cotescu
Fix For: Testing Sling Mock 3.4.8
For scenarios where the mocked OSGi framework executes calls in other threads
than the test thread (e.g. servlets under test in Jetty), the only way to pass
the test's {{AdapterManager}} is to directly call
{{{}SlingAdaptable#setAdapterManager{}}}. However, this will affect tests
starting after this initial call.
A better solution would be to make the
{{org.apache.sling.testing.mock.sling.ThreadsafeMockAdapterManagerWrapper#THREAD_LOCAL}}
an {{{}InheritableThreadLocal{}}}. This would allow the tests to still be
executable in parallel, but threads started from a test thread (e.g. the
servlets under test in Jetty) could inherit the thread local context.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (SLING-11843) Change Default JDK/OS for Jenkins Builds to JDK11/17 on Unix/Windows
[
https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716652#comment-17716652
]
Konrad Windszus edited comment on SLING-11843 at 4/26/23 11:14 AM:
---
For me the ultimate goal of this issue is to ease and foster contributions.
Building should work with Java 11/17 because that is what developers naturally
expect these days (and what they have setup on their machines). Also the
majority of potential contributors is working with Windows machines I guess, so
if tests fail for them they probably won't contribute.
What this means for the maintainers is secondary here, because each maintainer
can decide to not support certain versions/OS (for whatever reason) by just
deviating from the default in the {{sling-module.json}}.
The broken CI builds will also give some transparency with regards to whether
it is supposed to work at all with 11/17 and Windows. Currently a contributor
won't know whether a failing local build/test case is an issue with her/his
setup or an issue due to the lack of support of this module.
was (Author: kwin):
For me the ultimate goal of this issue to ease and foster contributions.
Building should work with Java 11/17 because that is what developers naturally
expect these days (and what they have setup on their machines). Also the
majority of potential contributors is working with Windows machines I guess, so
if tests fail for them they probably won't contribute.
What this means for the maintainers is secondary here, because each maintainer
can decide to not support certain versions/OS (for whatever reason) by just
deviating from the default in the {{sling-module.json}}.
The broken CI builds will also give some transparency with regards to whether
it is supposed to work at all with 11/17 and Windows. Currently a contributor
won't know whether a failing local build/test case is an issue with her/his
setup or an issue due to the lack of support of this module.
> Change Default JDK/OS for Jenkins Builds to JDK11/17 on Unix/Windows
>
>
> Key: SLING-11843
> URL: https://issues.apache.org/jira/browse/SLING-11843
> Project: Sling
> Issue Type: Improvement
> Components: CI
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently our Jenkins jobs by default only run on JDK8 with Linux.
> I would propose to change the default (mentioned in
> https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor#Slingmoduledescriptor-DefaultValues)
> to
> * Build with JDK 11 and 17 on
> * Windows and Linux
> Although this might break some builds, I think it is time now to make all
> modules compatible with it once we touch it for whatever reason.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (SLING-11843) Change Default JDK/OS for Jenkins Builds to JDK11/17 on Unix/Windows
[ https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716654#comment-17716654 ] Konrad Windszus edited comment on SLING-11843 at 4/26/23 10:25 AM: --- bq. One concern that I have with Java 17 is that projects using PowerMock will be broken - see https://stackoverflow.com/questions/69896191/powermock-compatibility-with-jdk-17 . I have very little hope that this will ever work with newer Java versions (compare with discussions at https://github.com/powermock/powermock/issues/1094), so it is probably time to get rid of powermock in tests. was (Author: kwin): bq. One concern that I have with Java 17 is that projects using PowerMock will be broken - see https://stackoverflow.com/questions/69896191/powermock-compatibility-with-jdk-17 . I have very little hope that this will ever work with newer Java versions, so it is probably time to get rid of powermock in tests. > Change Default JDK/OS for Jenkins Builds to JDK11/17 on Unix/Windows > > > Key: SLING-11843 > URL: https://issues.apache.org/jira/browse/SLING-11843 > Project: Sling > Issue Type: Improvement > Components: CI >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > Currently our Jenkins jobs by default only run on JDK8 with Linux. > I would propose to change the default (mentioned in > https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor#Slingmoduledescriptor-DefaultValues) > to > * Build with JDK 11 and 17 on > * Windows and Linux > Although this might break some builds, I think it is time now to make all > modules compatible with it once we touch it for whatever reason. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11843) Change Default JDK/OS for Jenkins Builds to JDK11/17 on Unix/Windows
[ https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716654#comment-17716654 ] Konrad Windszus commented on SLING-11843: - bq. One concern that I have with Java 17 is that projects using PowerMock will be broken - see https://stackoverflow.com/questions/69896191/powermock-compatibility-with-jdk-17 . I have very little hope that this will ever work with newer Java versions, so it is probably time to get rid of powermock in tests. > Change Default JDK/OS for Jenkins Builds to JDK11/17 on Unix/Windows > > > Key: SLING-11843 > URL: https://issues.apache.org/jira/browse/SLING-11843 > Project: Sling > Issue Type: Improvement > Components: CI >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > Currently our Jenkins jobs by default only run on JDK8 with Linux. > I would propose to change the default (mentioned in > https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor#Slingmoduledescriptor-DefaultValues) > to > * Build with JDK 11 and 17 on > * Windows and Linux > Although this might break some builds, I think it is time now to make all > modules compatible with it once we touch it for whatever reason. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11843) Change Default JDK/OS for Jenkins Builds to JDK11/17 on Unix/Windows
[
https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716652#comment-17716652
]
Konrad Windszus commented on SLING-11843:
-
For me the ultimate goal of this issue to ease and foster contributions.
Building should work with Java 11/17 because that is what developers naturally
expect these days (and what they have setup on their machines). Also the
majority of potential contributors is working with Windows machines I guess, so
if tests fail for them they probably won't contribute.
What this means for the maintainers is secondary here, because each maintainer
can decide to not support certain versions/OS (for whatever reason) by just
deviating from the default in the {{sling-module.json}}.
The broken CI builds will also give some transparency with regards to whether
it is supposed to work at all with 11/17 and Windows. Currently a contributor
won't know whether a failing local build/test case is an issue with her/his
setup or an issue due to the lack of support of this module.
> Change Default JDK/OS for Jenkins Builds to JDK11/17 on Unix/Windows
>
>
> Key: SLING-11843
> URL: https://issues.apache.org/jira/browse/SLING-11843
> Project: Sling
> Issue Type: Improvement
> Components: CI
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently our Jenkins jobs by default only run on JDK8 with Linux.
> I would propose to change the default (mentioned in
> https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor#Slingmoduledescriptor-DefaultValues)
> to
> * Build with JDK 11 and 17 on
> * Windows and Linux
> Although this might break some builds, I think it is time now to make all
> modules compatible with it once we touch it for whatever reason.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-tooling-jenkins] kwin commented on pull request #16: SLING-11843 build on JDK11/17 with Windows and Linux by default
kwin commented on PR #16: URL: https://github.com/apache/sling-tooling-jenkins/pull/16#issuecomment-1523170026 Checking out the parent version is not that easy (IMHO the Jenkins library should not parse the pom.xml). Also I consider all modules still on parent 35 or older basically unmaintained (so they don't need a working CI) and a failing build hopefully triggers the necessary update (which is crucial also for other reasons). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling Rewriter version 1.3.6
On Mon, 2023-04-24 at 09:29 -0500, Daniel Klco wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
[jira] [Commented] (SLING-11843) Change Default JDK/OS for Jenkins Builds to JDK11/17 on Unix/Windows
[ https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716611#comment-17716611 ] Robert Munteanu commented on SLING-11843: - One concern that I have with Java 17 is that projects using PowerMock will be broken - see https://stackoverflow.com/questions/69896191/powermock-compatibility-with-jdk-17 . > Change Default JDK/OS for Jenkins Builds to JDK11/17 on Unix/Windows > > > Key: SLING-11843 > URL: https://issues.apache.org/jira/browse/SLING-11843 > Project: Sling > Issue Type: Improvement > Components: CI >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > Currently our Jenkins jobs by default only run on JDK8 with Linux. > I would propose to change the default (mentioned in > https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor#Slingmoduledescriptor-DefaultValues) > to > * Build with JDK 11 and 17 on > * Windows and Linux > Although this might break some builds, I think it is time now to make all > modules compatible with it once we touch it for whatever reason. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-starter] rombert commented on pull request #155: SLING-11836 - Add Jakarta JSON support to the Sling Starter
rombert commented on PR #155: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/155#issuecomment-1523029559 @enapps-enorman - I did try using the SPIFly bundle locally, but I think I did not do it properly. There is some discussion about it at https://github.com/osgi/osgi/issues/434 and also a larger discussion about ServiceLoader at https://github.com/osgi/osgi/issues/372. I will try again the SPIFly approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…
sonarcloud[bot] commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-1523021917 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-servlets-resolver=7) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=7=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=7=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=7=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_coverage=list) [70.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #31: SLING-11558 part1: remove the LocationIterator
sonarcloud[bot] commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/31#issuecomment-1523019001 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-servlets-resolver=31) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=31=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=31=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=31=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=31=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=31=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=31=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=31=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=31=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-11843) Change Default JDK/OS for Jenkins Builds to JDK11/17 on Unix/Windows
[ https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716604#comment-17716604 ] Robert Munteanu commented on SLING-11843: - [~kwin] - it would help by giving maintainers a chance to react and incrementally fix the modules. What I am trying to prevent is having dozens of broken builds with a lot of work to debug; e.g. Windows CI failures may be harder to fix than failures on Java 11. And, to be honest, I don't see too many people stepping up and fixing CI failures. Perhaps we should be a bit more specific regarding the Java version being used and not enable it when we know for sure it will fail. We know for a fact that parent pom 35 is required for Java 11, so let's only enable Java 11 builds for projects with have a recent enough parent pom version. I think we can make a similar statement for Java 17, so I propose we conditionally enable Java 11 and Java 17 based on the parent pom version. > Change Default JDK/OS for Jenkins Builds to JDK11/17 on Unix/Windows > > > Key: SLING-11843 > URL: https://issues.apache.org/jira/browse/SLING-11843 > Project: Sling > Issue Type: Improvement > Components: CI >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > Currently our Jenkins jobs by default only run on JDK8 with Linux. > I would propose to change the default (mentioned in > https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor#Slingmoduledescriptor-DefaultValues) > to > * Build with JDK 11 and 17 on > * Windows and Linux > Although this might break some builds, I think it is time now to make all > modules compatible with it once we touch it for whatever reason. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11838) Unexpected runmode inheritance behavior
[ https://issues.apache.org/jira/browse/SLING-11838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-11838. - Resolution: Fixed PR merged, thanks for the contribution [~dsuess]! > Unexpected runmode inheritance behavior > --- > > Key: SLING-11838 > URL: https://issues.apache.org/jira/browse/SLING-11838 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Reporter: Dominik Süß >Assignee: Dominik Süß >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.2 > > > The current behavior how runmodes are evaluated for targeting the right > feature model is counterintuitive and can lead to dependency bugs. > Right now only the location within the direct package is evaluated but if a > package is embedded within a package with a specific runmode that leads to > problems: > a) the expectation that everything within an e.g. install.author folder only > applies to the author runmode is broken as install folders without author > would target the generic model > b) the implicit dependencies that are made explicit by the converter are > broken an embedded package may be broken as a package of a generic install > folder that's nested in a runmode specific install folder within a nesting > package would have a dependency on a package not launched (and therefore > fails the analyser checks) > As some people may have established some implicit dependency on this behavior > the goal for a fix is to provide a "legacy" mode and log the scenarios to be > able to to track usages and evaluate the impact and only switch on a > corresponding inheritance policy when this switch can be considered safe. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-feature-cpconverter] rombert merged pull request #165: SLING-11838 - adding support for runMode policies & runmode inheritance
rombert merged PR #165: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
