Re: [PR] chore(deps): update dependency org.apache.sling:slingfeature-maven-plugin to v1.9.0 [sling-org-apache-sling-starter]
rombert merged PR #373: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency commons-io:commons-io to v2.17.0 [sling-org-apache-sling-starter]
rombert merged PR #372: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency org.apache.felix:org.apache.felix.webconsole to v5.0.8 [sling-org-apache-sling-starter]
rombert merged PR #371: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12440 - Changed Extension annotation from ProviderType to ConsumerType [sling-org-apache-sling-sitemap]
sonarcloud[bot] commented on PR #17: URL: https://github.com/apache/sling-org-apache-sling-sitemap/pull/17#issuecomment-2369978032 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-sitemap&pullRequest=17) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-sitemap&pullRequest=17&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-sitemap&pullRequest=17&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-sitemap&pullRequest=17&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-sitemap&pullRequest=17&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-sitemap&pullRequest=17&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-sitemap&pullRequest=17) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12440 - Changed Extension annotation from ProviderType to ConsumerType [sling-org-apache-sling-sitemap]
bmxcode opened a new pull request, #17: URL: https://github.com/apache/sling-org-apache-sling-sitemap/pull/17 …merType -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12440 - Changed Extension annotation from ProviderType to ConsumerType [sling-org-apache-sling-sitemap]
bmxcode closed pull request #16: SLING-12440 - Changed Extension annotation from ProviderType to ConsumerType URL: https://github.com/apache/sling-org-apache-sling-sitemap/pull/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12440 - Changed Extension annotation from ProviderType to ConsumerType [sling-org-apache-sling-sitemap]
bmxcode opened a new pull request, #16: URL: https://github.com/apache/sling-org-apache-sling-sitemap/pull/16 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12244 cache the result of the getParentResourceType call [sling-org-apache-sling-resourceresolver]
sonarcloud[bot] commented on PR #115: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/115#issuecomment-2369224937 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=115) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=115&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=115&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=115&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=115&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=115&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=115) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11352 - Fix parsing of path-only mappings [sling-org-apache-sling-resourceresolver]
sonarcloud[bot] commented on PR #84: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/84#issuecomment-2369224695 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=84) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=84&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=84&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=84&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=84&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=84&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=84) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Various improvements for the webconsole plugin [sling-org-apache-sling-resourceresolver]
sonarcloud[bot] commented on PR #78: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/78#issuecomment-2369224481 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=78) **Quality Gate failed** Failed conditions  [2.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=78&metric=new_coverage&view=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=78) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12402: ResourceResolver: add additional log entry when there are many conflicting or invalid aliases (also add metrics) [sling-org-apache-sling-resourceresolver]
sonarcloud[bot] commented on PR #125: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/125#issuecomment-2369223971 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=125) **Quality Gate failed** Failed conditions  [76.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=125&metric=new_coverage&view=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=125) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency org.apache.sling:slingfeature-maven-plugin to v1.9.0 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #373: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/373 This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.sling:slingfeature-maven-plugin](https://sling.apache.org/components/slingfeature-maven-plugin/) ([source](https://redirect.github.com/apache/sling-slingfeature-maven-plugin)) | `1.8.4` -> `1.9.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency org.apache.felix:org.apache.felix.webconsole to v5.0.8 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #371: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/371 This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.felix:org.apache.felix.webconsole](https://felix.apache.org/) ([source](https://gitbox.apache.org/repos/asf?p=felix-dev.git)) | `5.0.6` -> `5.0.8` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency commons-io:commons-io to v2.17.0 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #372: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/372 This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [commons-io:commons-io](https://commons.apache.org/proper/commons-io/) ([source](https://gitbox.apache.org/repos/asf?p=commons-io.git)) | `2.16.1` -> `2.17.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency com.github.eirslett:frontend-maven-plugin to v1.15.1 [sling-site]
rombert merged PR #179: URL: https://github.com/apache/sling-site/pull/179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add processor based calculation for the eventing threadpool [sling-org-apache-sling-event]
joerghoh commented on code in PR #38:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/38#discussion_r1769640388
##
src/main/java/org/apache/sling/event/impl/EventingThreadPool.java:
##
@@ -53,11 +55,19 @@ public class EventingThreadPool implements ThreadPool {
public @interface Config {
@AttributeDefinition(name = "Pool Size",
- description="The size of the thread pool. This pool is used to
execute jobs and therefore "
-+ "limits the maximum number of jobs executed in
parallel.")
-int minPoolSize() default 35;
+description = "The size of the thread pool. This pool is used
to execute jobs and therefore "
++ "limits the maximum number of jobs executed in
parallel. "
++ "A value of -1 is substituted with the number of
available processors. "
++ "A decimal number between 0.0 and 1.0 is treated as
a fraction of available processors. "
++ "For example 0.5 means half of the available
processors. ")
+double minPoolSize() default 35;
Review Comment:
I think that this has the chance to break a system where this value is
defined as int. Have you checked how a running works if you provide an int? Is
it automatically converted to a double?
##
src/main/java/org/apache/sling/event/impl/EventingThreadPool.java:
##
@@ -53,11 +55,19 @@ public class EventingThreadPool implements ThreadPool {
public @interface Config {
@AttributeDefinition(name = "Pool Size",
- description="The size of the thread pool. This pool is used to
execute jobs and therefore "
-+ "limits the maximum number of jobs executed in
parallel.")
-int minPoolSize() default 35;
+description = "The size of the thread pool. This pool is used
to execute jobs and therefore "
++ "limits the maximum number of jobs executed in
parallel. "
++ "A value of -1 is substituted with the number of
available processors. "
++ "A decimal number between 0.0 and 1.0 is treated as
a fraction of available processors. "
++ "For example 0.5 means half of the available
processors. ")
+double minPoolSize() default 35;
}
+/**
+ * Logger.
+ */
+private final Logger logger = LoggerFactory.getLogger(this.getClass());
Review Comment:
I think that in most Sling classes we use a static Logger:
```suggestion
private static final Logger LOGGER =
LoggerFactory.getLogger(EventingThreadPool.class);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] chore(deps): update dependency com.github.eirslett:frontend-maven-plugin to v1.15.1 [sling-site]
renovate-bot opened a new pull request, #179: URL: https://github.com/apache/sling-site/pull/179 This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.github.eirslett:frontend-maven-plugin](https://redirect.github.com/eirslett/frontend-maven-plugin) | `1.15.0` -> `1.15.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes eirslett/frontend-maven-plugin (com.github.eirslett:frontend-maven-plugin) ### [`v1.15.1`](https://redirect.github.com/eirslett/frontend-maven-plugin/blob/HEAD/CHANGELOG.md#1151) - Fix [#1150](https://redirect.github.com/eirslett/frontend-maven-plugin/issues/1150): Update lifecycle-mapping-metadata.xml for npx --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/apache/sling-site). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12438 - Update Sling Scripting JSP to parent version 60 [sling-org-apache-sling-scripting-jsp]
jsedding opened a new pull request, #10: URL: https://github.com/apache/sling-org-apache-sling-scripting-jsp/pull/10 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12437: Remove groovy-macro which is not properly working in OSGi [sling-org-apache-sling-starter]
royteeuwen merged PR #370: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12437: Remove groovy-macro which is not properly working in OSGi [sling-org-apache-sling-starter]
royteeuwen opened a new pull request, #370: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/370 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12421 - Race between serving request and destroying JspServletWrapper [sling-org-apache-sling-scripting-jsp]
jsedding merged PR #9: URL: https://github.com/apache/sling-org-apache-sling-scripting-jsp/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12420 - JSP scripts are falsely re-compiled on events from HTL engine [sling-org-apache-sling-scripting-jsp]
jsedding merged PR #8: URL: https://github.com/apache/sling-org-apache-sling-scripting-jsp/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12435 Make timeout to wait for ResourceResolverFactoryActivator configurable via system property [sling-org-apache-sling-testing-sling-mock]
stefanseifert merged PR #41: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12435 Make timeout to wait for ResourceResolverFactoryActivator configurable via system property [sling-org-apache-sling-testing-sling-mock]
sonarcloud[bot] commented on PR #41: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/41#issuecomment-2355090658 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-sling-mock&pullRequest=41) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock&pullRequest=41&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock&pullRequest=41&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-sling-mock&pullRequest=41&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock&pullRequest=41&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock&pullRequest=41&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-sling-mock&pullRequest=41) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12435 Make timeout to wait for ResourceResolverFactoryActivator configurable via system property [sling-org-apache-sling-testing-sling-mock]
stefanseifert opened a new pull request, #41: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/41 add this parameter to the commandline to use a different timeout (instead of the default value of 250ms): `-Dsling.mock.resourceresolverfactoryactivator.timeout.ms=500` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12421 - Race between serving request and destroying JspServletWrapper [sling-org-apache-sling-scripting-jsp]
jsedding opened a new pull request, #9: URL: https://github.com/apache/sling-org-apache-sling-scripting-jsp/pull/9 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12428 - Relax constraints for the highest supported Java version [sling-parent]
rombert merged PR #45: URL: https://github.com/apache/sling-parent/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12301 improve error handling [sling-org-apache-sling-engine]
sonarcloud[bot] commented on PR #49: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/49#issuecomment-2351542048 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine&pullRequest=49) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=49&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=49&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=49&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [66.7% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=49&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=49&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine&pullRequest=49) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12301 improve error handling [sling-org-apache-sling-engine]
sonarcloud[bot] commented on PR #49: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/49#issuecomment-2351535400 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine&pullRequest=49) **Quality Gate failed** Failed conditions  [B Maintainability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine&pullRequest=49) (required ≥ A) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine&pullRequest=49) ##  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency org.apache.felix:org.apache.felix.http.jetty to v5.1.26 [sling-org-apache-sling-starter]
rombert merged PR #369: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency org.apache.felix:org.apache.felix.http.jetty to v5.1.26 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #369: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/369 This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.felix:org.apache.felix.http.jetty](https://felix.apache.org/) ([source](https://gitbox.apache.org/repos/asf?p=felix-dev.git)) | `5.1.24` -> `5.1.26` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency org.apache.sling:org.apache.sling.installer.factory.configuration to v1.4.6 [sling-org-apache-sling-starter]
rombert merged PR #362: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12402: ResourceResolver: add additional log entry when there are many conflicting or invalid aliases (also add metrics) [sling-org-apache-sling-resourceresolver]
sonarcloud[bot] commented on PR #125: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/125#issuecomment-2348653288 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=125) **Quality Gate failed** Failed conditions  [76.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=125&metric=new_coverage&view=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=125) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12402: ResourceResolver: add additional log entry when there are many conflicting or invalid aliases (also add metrics) [sling-org-apache-sling-resourceresolver]
reschke opened a new pull request, #125: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/125 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency org.owasp.encoder:encoder to v1.3.1 [sling-org-apache-sling-starter]
enapps-enorman merged PR #368: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump commons-io:commons-io from 2.4 to 2.7 [sling-org-apache-sling-discovery-impl]
sonarcloud[bot] commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-discovery-impl/pull/5#issuecomment-2347300684 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-discovery-impl&pullRequest=5) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-impl&pullRequest=5&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-impl&pullRequest=5&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-impl&pullRequest=5&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-impl&pullRequest=5&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-impl&pullRequest=5&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-discovery-impl&pullRequest=5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency org.owasp.encoder:encoder to v1.3.1 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #368:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/368
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[org.owasp.encoder:encoder](https://www.owasp.org/index.php/OWASP_Java_Encoder_Project)
([source](https://redirect.github.com/owasp/owasp-java-encoder)) | `1.2.3` ->
`1.3.1` |
[](https://docs.renovatebot.com/merge-confidence/)
|
[](https://docs.renovatebot.com/merge-confidence/)
|
[](https://docs.renovatebot.com/merge-confidence/)
|
[](https://docs.renovatebot.com/merge-confidence/)
|
---
### Release Notes
owasp/owasp-java-encoder (org.owasp.encoder:encoder)
###
[`v1.3.1`](https://redirect.github.com/OWASP/owasp-java-encoder/releases/tag/v1.3.1)
[Compare
Source](https://redirect.github.com/owasp/owasp-java-encoder/compare/v1.3.0...v1.3.1)
What's Changed
- fix: java.lang.NoSuchMethodError when running on Java 8 by
[@jeremylong](https://redirect.github.com/jeremylong) in
[https://github.com/OWASP/owasp-java-encoder/pull/80](https://redirect.github.com/OWASP/owasp-java-encoder/pull/80)
- fix: add OSGi related entries in the MANIFEST.MF file by
[@enapps-enorman](https://redirect.github.com/enapps-enorman) in
[https://github.com/OWASP/owasp-java-encoder/pull/82](https://redirect.github.com/OWASP/owasp-java-encoder/pull/82)
New Contributors
- [@enapps-enorman](https://redirect.github.com/enapps-enorman)
made their first contribution in
[https://github.com/OWASP/owasp-java-encoder/pull/82](https://redirect.github.com/OWASP/owasp-java-encoder/pull/82)
**Full Changelog**:
https://github.com/OWASP/owasp-java-encoder/compare/v1.3.0...v1.3.1
###
[`v1.3.0`](https://redirect.github.com/OWASP/owasp-java-encoder/releases/tag/v1.3.0)
[Compare
Source](https://redirect.github.com/owasp/owasp-java-encoder/compare/v1.2.3...v1.3.0)
# What's Changed
- Add automatic module name by
[@casid](https://redirect.github.com/casid) in
[https://github.com/OWASP/owasp-java-encoder/pull/45](https://redirect.github.com/OWASP/owasp-java-encoder/pull/45)
- Correct javadoc for Encode class. by
[@kwwall](https://redirect.github.com/kwwall) in
[https://github.com/OWASP/owasp-java-encoder/pull/52](https://redirect.github.com/OWASP/owasp-java-encoder/pull/52)
- Add badge for javadoc by
[@seanf](https://redirect.github.com/seanf) in
[https://github.com/OWASP/owasp-java-encoder/pull/55](https://redirect.github.com/OWASP/owasp-java-encoder/pull/55)
- Tiny typo Fix by
[@loris-s-sonarsource](https://redirect.github.com/loris-s-sonarsource)
in
[https://github.com/OWASP/owasp-java-encoder/pull/58](https://redirect.github.com/OWASP/owasp-java-encoder/pull/58)
- Bump spring-core from 5.1.3.RELEASE to 5.3.19 in /jsp by
[@dependabot](https://redirect.github.com/dependabot) in
[https://github.com/OWASP/owasp-java-encoder/pull/59](https://redirect.github.com/OWASP/owasp-java-encoder/pull/59)
- General Maintenance by
[@jeremylong](https://redirect.github.com/jeremylong) in
[https://github.com/OWASP/owasp-java-encoder/pull/61](https://redirect.github.com/OWASP/owasp-java-encoder/pull/61)
- Improve Encode.forHtmlAttribute docs by
[@meeque](https://redirect.github.com/meeque) in
[https://github.com/OWASP/owasp-java-encoder/pull/72](https://redirect.github.com/OWASP/owasp-java-encoder/pull/72)
- fix: update esapi thunk by
[@jeremylong](https://redirect.github.com/jeremylong) in
[https://github.com/OWASP/owasp-java-encoder/pull/76](https://redirect.github.com/OWASP/owasp-java-encoder/pull/76)
- feat: multi-release jars - add module name by
[@jeremylong](https://redirect.github.com/jeremylong) in
[https://github.com/OWASP/owasp-java-encoder/pull/77](https://redirect.github.com/OWASP/owasp-java-encoder/pull/77)
- feat: support jakarta jsp by
[@jeremylong](https://redirect.github.com/jeremylong) in
[https://github.com/OWASP/owasp-java-encoder/pull/75](https://redirect.github.com/OWASP/owasp-java-encoder/pull/75)
# New Contributors
- [@casid](https://redirect.github.com/casid) made their first
contribution in
[https://github.com/OWASP/owasp-java-encoder/pull/45](https://redirect.github.com/OWASP/owasp-java-encoder/pull/45)
- [@seanf](https://redirect.github.com/seanf) made their first
contribution in
[https://github.com
Re: [PR] chore(deps): update dependency io.fabric8:docker-maven-plugin to v0.45.0 [sling-org-apache-sling-starter]
rombert merged PR #357: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency org.apache.sling:org.apache.sling.i18n to v2.6.4 [sling-org-apache-sling-starter]
rombert merged PR #361: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency org.apache.commons:commons-lang3 to v3.17.0 [sling-org-apache-sling-starter]
rombert merged PR #366: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12428 - Relax constraints for the highest supported Java version [sling-parent]
sonarcloud[bot] commented on PR #45: URL: https://github.com/apache/sling-parent/pull/45#issuecomment-2346150460 ## [](https://sonarcloud.io/dashboard?id=apache_sling-parent&pullRequest=45) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=45&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=45&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent&pullRequest=45&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-parent&pullRequest=45&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-parent&pullRequest=45&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-parent&pullRequest=45) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12426 - Remove the default value of sling.java.version from the parent pom [sling-parent]
rombert commented on PR #44: URL: https://github.com/apache/sling-parent/pull/44#issuecomment-2346090260 > but i also think we should not limit the java-version to <= java 19 via regex. if we want to keep an upper cap of the java version this should be managed elsewhere (e.g. wiki/documentation) and not here in the parent pom. See https://github.com/apache/sling-parent/pull/44#pullrequestreview-2298180136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12424: Migrate discovery.impl to official OSGi annotations [sling-org-apache-sling-discovery-impl]
jsedding merged PR #8: URL: https://github.com/apache/sling-org-apache-sling-discovery-impl/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12428 - Relax constraints for the highest supported Java version [sling-parent]
rombert opened a new pull request, #45: URL: https://github.com/apache/sling-parent/pull/45 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12426 - Remove the default value of sling.java.version from the parent pom [sling-parent]
rombert merged PR #44: URL: https://github.com/apache/sling-parent/pull/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12424: Migrate discovery.impl to official OSGi annotations [sling-org-apache-sling-discovery-impl]
mreutegg commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-discovery-impl/pull/8#issuecomment-2345761961 > Is this ready to be merged? I'd say yes, but I'm not a Sling committer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency org.apache.sling:org.apache.sling.jcr.repoinit to v1.1.52 [sling-org-apache-sling-starter]
rombert merged PR #363: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency org.apache.sling:org.apache.sling.xss to v2.4.2 [sling-org-apache-sling-starter]
rombert merged PR #365: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency org.apache.sling:org.apache.sling.scripting.core to v2.4.10 [sling-org-apache-sling-starter]
rombert merged PR #364: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency org.apache.sling:org.apache.sling.commons.threads to v3.3.0 [sling-org-apache-sling-starter]
rombert merged PR #367: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12426 - Remove the default value of sling.java.version from the parent pom [sling-parent]
sonarcloud[bot] commented on PR #44: URL: https://github.com/apache/sling-parent/pull/44#issuecomment-2343782180 ## [](https://sonarcloud.io/dashboard?id=apache_sling-parent&pullRequest=44) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=44&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=44&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent&pullRequest=44&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-parent&pullRequest=44&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-parent&pullRequest=44&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-parent&pullRequest=44) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency org.apache.sling:org.apache.sling.commons.threads to v3.3.0 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #367: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/367 This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.sling:org.apache.sling.commons.threads](https://sling.apache.org) ([source](https://redirect.github.com/apache/sling-org-apache-sling-commons-threads)) | `3.2.22` -> `3.3.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency org.apache.commons:commons-lang3 to v3.17.0 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #366: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/366 This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.commons:commons-lang3](https://commons.apache.org/proper/commons-lang/) ([source](https://gitbox.apache.org/repos/asf?p=commons-lang.git)) | `3.15.0` -> `3.17.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency org.apache.sling:org.apache.sling.xss to v2.4.2 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #365: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/365 This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.sling:org.apache.sling.xss](https://sling.apache.org) ([source](https://redirect.github.com/apache/sling-org-apache-sling-xss)) | `2.4.0` -> `2.4.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency org.apache.sling:org.apache.sling.scripting.core to v2.4.10 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #364: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/364 This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.sling:org.apache.sling.scripting.core](https://sling.apache.org) ([source](https://redirect.github.com/apache/sling-org-apache-sling-scripting-core)) | `2.4.8` -> `2.4.10` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency org.apache.sling:org.apache.sling.jcr.repoinit to v1.1.52 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #363: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/363 This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.sling:org.apache.sling.jcr.repoinit](https://sling.apache.org) ([source](https://redirect.github.com/apache/sling-org-apache-sling-jcr-repoinit)) | `1.1.50` -> `1.1.52` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency org.apache.sling:org.apache.sling.installer.factory.configuration to v1.4.6 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #362: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/362 This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.sling:org.apache.sling.installer.factory.configuration](https://sling.apache.org) ([source](https://redirect.github.com/apache/sling-org-apache-sling-installer-factory-configuration)) | `1.4.4` -> `1.4.6` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https: //docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency org.apache.sling:org.apache.sling.i18n to v2.6.4 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #361: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/361 This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.sling:org.apache.sling.i18n](https://sling.apache.org) ([source](https://redirect.github.com/apache/sling-org-apache-sling-i18n)) | `2.6.2` -> `2.6.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12426 - Remove the default value of sling.java.version from the parent pom [sling-parent]
rombert opened a new pull request, #44: URL: https://github.com/apache/sling-parent/pull/44 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12424: Migrate discovery.impl to official OSGi annotations [sling-org-apache-sling-discovery-impl]
sonarcloud[bot] commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-discovery-impl/pull/8#issuecomment-2343524019 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-discovery-impl&pullRequest=8) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-impl&pullRequest=8&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-impl&pullRequest=8&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-impl&pullRequest=8&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-impl&pullRequest=8&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-impl&pullRequest=8&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-discovery-impl&pullRequest=8) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency com.h2database:h2-mvstore to v2.3.232 [sling-org-apache-sling-starter]
rombert merged PR #355: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12424: Migrate discovery.impl to official OSGi annotations [sling-org-apache-sling-discovery-impl]
mreutegg commented on code in PR #6:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-impl/pull/6#discussion_r1753922418
##
src/main/java/org/apache/sling/discovery/impl/DiscoveryServiceConfig.java:
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.sling.discovery.impl;
+
+import org.osgi.service.metatype.annotations.AttributeDefinition;
+import org.osgi.service.metatype.annotations.ObjectClassDefinition;
+
+@ObjectClassDefinition(
+localization = "OSGI-INF/l10n/metatype",
+name = "%config.name",
+description = "%config.description"
+)
+public @interface DiscoveryServiceConfig {
+
+/** Configure the timeout (in seconds) after which an instance is
considered dead/crashed. */
+long DEFAULT_HEARTBEAT_TIMEOUT = 120;
+@AttributeDefinition(name = "%heartbeatTimeout.name", description =
"%heartbeatTimeout.description")
+long heartbeatTimeout() default DEFAULT_HEARTBEAT_TIMEOUT;
+
+/** Configure the interval (in seconds) according to which the heartbeats
are exchanged in the topology. */
+long DEFAULT_HEARTBEAT_INTERVAL = 30;
+@AttributeDefinition(name = "%heartbeatInterval.name", description =
"%heartbeatInterval.description")
+long heartbeatInterval() default DEFAULT_HEARTBEAT_INTERVAL;
+
+/** Configure the time (in seconds) which must be passed at minimum
between sending TOPOLOGY_CHANGING/_CHANGED (avoid flooding). */
+int DEFAULT_MIN_EVENT_DELAY = 3;
+@AttributeDefinition(name = "%minEventDelay.name", description =
"%minEventDelay.description")
+int minEventDelay() default DEFAULT_MIN_EVENT_DELAY;
+
+/** Configure the socket connect timeout for topology connectors. */
+int DEFAULT_CONNECTION_TIMEOUT = 10;
+@AttributeDefinition(name = "%connectionTimeout.name", description =
"%connectionTimeout.description")
+int connectionTimeout() default DEFAULT_CONNECTION_TIMEOUT;
+
+/** Configure the socket read timeout (SO_TIMEOUT) for topology
connectors. */
+int DEFAULT_SO_TIMEOUT = 10;
+@AttributeDefinition(name = "%soTimeout.name", description =
"%soTimeout.description")
+int soTimeout() default DEFAULT_SO_TIMEOUT;
+
+/** Name of the repository descriptor to be taken into account for leader
election:
+ those instances have preference to become leader which have the
corresponding descriptor value of 'false' */
+@AttributeDefinition(name = "%leaderElectionRepositoryDescriptor.name",
description = "%leaderElectionRepositoryDescriptor.description")
+String leaderElectionRepositoryDescriptor();
+
+/**
+ * Whether or not (default false) the leaderElectionRepositoryDescriptor
should be inverted (if that one
+ * is configured at all).
+ */
+@AttributeDefinition(name = "%invertRepositoryDescriptor.name",
description = "%invertRepositoryDescriptor.description")
+boolean invertRepositoryDescriptor() default false;
+
+/** URLs where to join a topology, eg
http://localhost:4502/libs/sling/topology/connector */
+@AttributeDefinition(name = "%topologyConnectorUrls.name", description =
"%topologyConnectorUrls.description", cardinality=1024)
+String[] topologyConnectorUrls() default {};
+
+/** list of ips and/or hostnames which are allowed to connect to
/libs/sling/topology/connector */
+@AttributeDefinition(name = "%topologyConnectorWhitelist.name",
description = "%topologyConnectorWhitelist.description")
+String[] topologyConnectorWhitelist() default {"localhost", "127.0.0.1"};
+String[] DEFAULT_TOPOLOGY_CONNECTOR_WHITELIST = {"localhost", "127.0.0.1"};
+
+/** Path of resource where to keep discovery information, e.g
/var/discovery/impl/ */
+@AttributeDefinition(name = "%discoveryResourcePath.name", description =
"%discoveryResourcePath.description")
+String discoveryResourcePath() default DEFAULT_DISCOVERY_RESOURCE_PATH;
+String DEFAULT_DISCOVERY_RESOURCE_PATH = "/var/discovery/impl/";
+
+/**
+ * If set to true, local-loops of topology connectors are automatically
stopped when detected so.
+ */
+@AttributeDefinition(name = "%autoStopLocalLoopEnabled.name", description
= "%autoStop
Re: [PR] SLING-12424: Migrate discovery.impl to official OSGi annotations [sling-org-apache-sling-discovery-impl]
mreutegg commented on code in PR #6:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-impl/pull/6#discussion_r1753921258
##
src/main/java/org/apache/sling/discovery/impl/common/heartbeat/HeartbeatHandler.java:
##
@@ -63,11 +63,17 @@
* Local heartbeats are stored in the repository. Remote heartbeats are POSTs
to
* remote TopologyConnectorServlets.
*/
-@Component
-@Service(value = HeartbeatHandler.class)
-@Reference(referenceInterface=HttpService.class,
- cardinality=ReferenceCardinality.OPTIONAL_MULTIPLE,
- policy=ReferencePolicy.DYNAMIC)
+@Component(service = {HeartbeatHandler.class},
+reference = {
+@Reference(name = "HttpService",
+service = HttpService.class,
+cardinality = ReferenceCardinality.MULTIPLE,
+policy = ReferencePolicy.DYNAMIC,
+bind = "bindHttpService",
+unbind = "unbindHttpService"
+)
Review Comment:
See https://github.com/apache/sling-org-apache-sling-discovery-impl/pull/8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] SLING-12424: Migrate discovery.impl to official OSGi annotations [sling-org-apache-sling-discovery-impl]
mreutegg opened a new pull request, #8: URL: https://github.com/apache/sling-org-apache-sling-discovery-impl/pull/8 Use correct name for useSyncTokenService configuration property Move HttpService reference annotation to bind method -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12424: Migrate discovery.impl to official OSGi annotations [sling-org-apache-sling-discovery-impl]
mreutegg commented on code in PR #6:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-impl/pull/6#discussion_r1753308769
##
src/main/java/org/apache/sling/discovery/impl/TopologyWebConsolePlugin.java:
##
@@ -63,23 +56,31 @@
import
org.apache.sling.discovery.commons.providers.spi.base.ClusterSyncHistory;
import org.apache.sling.discovery.commons.providers.spi.base.SyncTokenService;
import org.osgi.framework.BundleContext;
+import org.osgi.service.component.annotations.Activate;
+import org.osgi.service.component.annotations.Component;
+import org.osgi.service.component.annotations.Deactivate;
+import org.osgi.service.component.annotations.Reference;
+import org.osgi.service.component.propertytypes.ServiceDescription;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import static org.apache.felix.webconsole.WebConsoleConstants.PLUGIN_LABEL;
+import static org.apache.felix.webconsole.WebConsoleConstants.PLUGIN_TITLE;
+
/**
* Simple webconsole which gives an overview of the topology visible by the
* discovery service
*/
-@Component
-@Service(value = { TopologyEventListener.class, Servlet.class })
-@Properties({
-@Property(name=org.osgi.framework.Constants.SERVICE_DESCRIPTION,
-value="Apache Sling Web Console Plugin to display Background
servlets and ExecutionEngine status"),
-@Property(name=WebConsoleConstants.PLUGIN_LABEL,
value=TopologyWebConsolePlugin.LABEL),
-@Property(name=WebConsoleConstants.PLUGIN_TITLE,
value=TopologyWebConsolePlugin.TITLE),
-@Property(name="felix.webconsole.category", value="Sling"),
-@Property(name="felix.webconsole.configprinter.modes", value={"zip"})
-})
+@Component(
+service = { TopologyEventListener.class, Servlet.class },
+property = {
+PLUGIN_LABEL + "=" + TopologyWebConsolePlugin.LABEL,
+PLUGIN_TITLE + "=" + TopologyWebConsolePlugin.TITLE,
+"felix.webconsole.category=Sling",
+"felix.webconsole.configprinter.modes={zip}"
Review Comment:
Can you explain why? The sibling class in discovery.oak does the same:
https://github.com/apache/sling-org-apache-sling-discovery-oak/blob/181a2a7f4efb87ae4bb4eaa5bced92e9485774d4/src/main/java/org/apache/sling/discovery/oak/TopologyWebConsolePlugin.java#L80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-12424: Migrate discovery.impl to official OSGi annotations [sling-org-apache-sling-discovery-impl]
mreutegg commented on code in PR #6: URL: https://github.com/apache/sling-org-apache-sling-discovery-impl/pull/6#discussion_r1753301991 ## src/main/java/org/apache/sling/discovery/impl/DiscoveryServiceConfig.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.sling.discovery.impl; + +import org.osgi.service.metatype.annotations.AttributeDefinition; +import org.osgi.service.metatype.annotations.ObjectClassDefinition; + +@ObjectClassDefinition( +localization = "OSGI-INF/l10n/metatype", Review Comment: Agreed, but I didn't want to change more than necessary. I think this should be done with a separate issue/PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12424: Migrate discovery.impl to official OSGi annotations [sling-org-apache-sling-discovery-impl]
mreutegg commented on code in PR #6:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-impl/pull/6#discussion_r1753280686
##
src/main/java/org/apache/sling/discovery/impl/DiscoveryServiceConfig.java:
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.sling.discovery.impl;
+
+import org.osgi.service.metatype.annotations.AttributeDefinition;
+import org.osgi.service.metatype.annotations.ObjectClassDefinition;
+
+@ObjectClassDefinition(
+localization = "OSGI-INF/l10n/metatype",
+name = "%config.name",
+description = "%config.description"
+)
+public @interface DiscoveryServiceConfig {
+
+/** Configure the timeout (in seconds) after which an instance is
considered dead/crashed. */
+long DEFAULT_HEARTBEAT_TIMEOUT = 120;
+@AttributeDefinition(name = "%heartbeatTimeout.name", description =
"%heartbeatTimeout.description")
+long heartbeatTimeout() default DEFAULT_HEARTBEAT_TIMEOUT;
+
+/** Configure the interval (in seconds) according to which the heartbeats
are exchanged in the topology. */
+long DEFAULT_HEARTBEAT_INTERVAL = 30;
+@AttributeDefinition(name = "%heartbeatInterval.name", description =
"%heartbeatInterval.description")
+long heartbeatInterval() default DEFAULT_HEARTBEAT_INTERVAL;
+
+/** Configure the time (in seconds) which must be passed at minimum
between sending TOPOLOGY_CHANGING/_CHANGED (avoid flooding). */
+int DEFAULT_MIN_EVENT_DELAY = 3;
+@AttributeDefinition(name = "%minEventDelay.name", description =
"%minEventDelay.description")
+int minEventDelay() default DEFAULT_MIN_EVENT_DELAY;
+
+/** Configure the socket connect timeout for topology connectors. */
+int DEFAULT_CONNECTION_TIMEOUT = 10;
+@AttributeDefinition(name = "%connectionTimeout.name", description =
"%connectionTimeout.description")
+int connectionTimeout() default DEFAULT_CONNECTION_TIMEOUT;
+
+/** Configure the socket read timeout (SO_TIMEOUT) for topology
connectors. */
+int DEFAULT_SO_TIMEOUT = 10;
+@AttributeDefinition(name = "%soTimeout.name", description =
"%soTimeout.description")
+int soTimeout() default DEFAULT_SO_TIMEOUT;
+
+/** Name of the repository descriptor to be taken into account for leader
election:
+ those instances have preference to become leader which have the
corresponding descriptor value of 'false' */
+@AttributeDefinition(name = "%leaderElectionRepositoryDescriptor.name",
description = "%leaderElectionRepositoryDescriptor.description")
+String leaderElectionRepositoryDescriptor();
+
+/**
+ * Whether or not (default false) the leaderElectionRepositoryDescriptor
should be inverted (if that one
+ * is configured at all).
+ */
+@AttributeDefinition(name = "%invertRepositoryDescriptor.name",
description = "%invertRepositoryDescriptor.description")
+boolean invertRepositoryDescriptor() default false;
+
+/** URLs where to join a topology, eg
http://localhost:4502/libs/sling/topology/connector */
+@AttributeDefinition(name = "%topologyConnectorUrls.name", description =
"%topologyConnectorUrls.description", cardinality=1024)
+String[] topologyConnectorUrls() default {};
+
+/** list of ips and/or hostnames which are allowed to connect to
/libs/sling/topology/connector */
+@AttributeDefinition(name = "%topologyConnectorWhitelist.name",
description = "%topologyConnectorWhitelist.description")
+String[] topologyConnectorWhitelist() default {"localhost", "127.0.0.1"};
+String[] DEFAULT_TOPOLOGY_CONNECTOR_WHITELIST = {"localhost", "127.0.0.1"};
+
+/** Path of resource where to keep discovery information, e.g
/var/discovery/impl/ */
+@AttributeDefinition(name = "%discoveryResourcePath.name", description =
"%discoveryResourcePath.description")
+String discoveryResourcePath() default DEFAULT_DISCOVERY_RESOURCE_PATH;
+String DEFAULT_DISCOVERY_RESOURCE_PATH = "/var/discovery/impl/";
+
+/**
+ * If set to true, local-loops of topology connectors are automatically
stopped when detected so.
+ */
+@AttributeDefinition(name = "%autoStopLocalLoopEnabled.name", description
= "%autoStop
Re: [PR] SLING-12424: Migrate discovery.impl to official OSGi annotations [sling-org-apache-sling-discovery-impl]
mreutegg commented on code in PR #6:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-impl/pull/6#discussion_r1753316448
##
src/main/java/org/apache/sling/discovery/impl/common/heartbeat/HeartbeatHandler.java:
##
@@ -63,11 +63,17 @@
* Local heartbeats are stored in the repository. Remote heartbeats are POSTs
to
* remote TopologyConnectorServlets.
*/
-@Component
-@Service(value = HeartbeatHandler.class)
-@Reference(referenceInterface=HttpService.class,
- cardinality=ReferenceCardinality.OPTIONAL_MULTIPLE,
- policy=ReferencePolicy.DYNAMIC)
+@Component(service = {HeartbeatHandler.class},
+reference = {
+@Reference(name = "HttpService",
+service = HttpService.class,
+cardinality = ReferenceCardinality.MULTIPLE,
+policy = ReferencePolicy.DYNAMIC,
+bind = "bindHttpService",
+unbind = "unbindHttpService"
+)
Review Comment:
Sounds good to me. I'll include that in a follow up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-12424: Migrate discovery.impl to official OSGi annotations [sling-org-apache-sling-discovery-impl]
mreutegg commented on code in PR #6:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-impl/pull/6#discussion_r1753289372
##
src/main/java/org/apache/sling/discovery/impl/DiscoveryServiceConfig.java:
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.sling.discovery.impl;
+
+import org.osgi.service.metatype.annotations.AttributeDefinition;
+import org.osgi.service.metatype.annotations.ObjectClassDefinition;
+
+@ObjectClassDefinition(
+localization = "OSGI-INF/l10n/metatype",
+name = "%config.name",
+description = "%config.description"
+)
+public @interface DiscoveryServiceConfig {
+
+/** Configure the timeout (in seconds) after which an instance is
considered dead/crashed. */
+long DEFAULT_HEARTBEAT_TIMEOUT = 120;
+@AttributeDefinition(name = "%heartbeatTimeout.name", description =
"%heartbeatTimeout.description")
+long heartbeatTimeout() default DEFAULT_HEARTBEAT_TIMEOUT;
+
+/** Configure the interval (in seconds) according to which the heartbeats
are exchanged in the topology. */
+long DEFAULT_HEARTBEAT_INTERVAL = 30;
+@AttributeDefinition(name = "%heartbeatInterval.name", description =
"%heartbeatInterval.description")
+long heartbeatInterval() default DEFAULT_HEARTBEAT_INTERVAL;
+
+/** Configure the time (in seconds) which must be passed at minimum
between sending TOPOLOGY_CHANGING/_CHANGED (avoid flooding). */
+int DEFAULT_MIN_EVENT_DELAY = 3;
+@AttributeDefinition(name = "%minEventDelay.name", description =
"%minEventDelay.description")
+int minEventDelay() default DEFAULT_MIN_EVENT_DELAY;
+
+/** Configure the socket connect timeout for topology connectors. */
+int DEFAULT_CONNECTION_TIMEOUT = 10;
+@AttributeDefinition(name = "%connectionTimeout.name", description =
"%connectionTimeout.description")
+int connectionTimeout() default DEFAULT_CONNECTION_TIMEOUT;
+
+/** Configure the socket read timeout (SO_TIMEOUT) for topology
connectors. */
+int DEFAULT_SO_TIMEOUT = 10;
+@AttributeDefinition(name = "%soTimeout.name", description =
"%soTimeout.description")
+int soTimeout() default DEFAULT_SO_TIMEOUT;
+
+/** Name of the repository descriptor to be taken into account for leader
election:
+ those instances have preference to become leader which have the
corresponding descriptor value of 'false' */
+@AttributeDefinition(name = "%leaderElectionRepositoryDescriptor.name",
description = "%leaderElectionRepositoryDescriptor.description")
+String leaderElectionRepositoryDescriptor();
+
+/**
+ * Whether or not (default false) the leaderElectionRepositoryDescriptor
should be inverted (if that one
+ * is configured at all).
+ */
+@AttributeDefinition(name = "%invertRepositoryDescriptor.name",
description = "%invertRepositoryDescriptor.description")
+boolean invertRepositoryDescriptor() default false;
+
+/** URLs where to join a topology, eg
http://localhost:4502/libs/sling/topology/connector */
+@AttributeDefinition(name = "%topologyConnectorUrls.name", description =
"%topologyConnectorUrls.description", cardinality=1024)
+String[] topologyConnectorUrls() default {};
+
+/** list of ips and/or hostnames which are allowed to connect to
/libs/sling/topology/connector */
+@AttributeDefinition(name = "%topologyConnectorWhitelist.name",
description = "%topologyConnectorWhitelist.description")
+String[] topologyConnectorWhitelist() default {"localhost", "127.0.0.1"};
+String[] DEFAULT_TOPOLOGY_CONNECTOR_WHITELIST = {"localhost", "127.0.0.1"};
+
+/** Path of resource where to keep discovery information, e.g
/var/discovery/impl/ */
+@AttributeDefinition(name = "%discoveryResourcePath.name", description =
"%discoveryResourcePath.description")
+String discoveryResourcePath() default DEFAULT_DISCOVERY_RESOURCE_PATH;
+String DEFAULT_DISCOVERY_RESOURCE_PATH = "/var/discovery/impl/";
+
+/**
+ * If set to true, local-loops of topology connectors are automatically
stopped when detected so.
+ */
+@AttributeDefinition(name = "%autoStopLocalLoopEnabled.name", description
= "%autoStop
Re: [PR] SLING-12424: Migrate discovery.impl to official OSGi annotations [sling-org-apache-sling-discovery-impl]
mreutegg commented on code in PR #6:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-impl/pull/6#discussion_r1753284281
##
src/main/java/org/apache/sling/discovery/impl/DiscoveryServiceConfig.java:
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.sling.discovery.impl;
+
+import org.osgi.service.metatype.annotations.AttributeDefinition;
+import org.osgi.service.metatype.annotations.ObjectClassDefinition;
+
+@ObjectClassDefinition(
+localization = "OSGI-INF/l10n/metatype",
+name = "%config.name",
+description = "%config.description"
+)
+public @interface DiscoveryServiceConfig {
+
+/** Configure the timeout (in seconds) after which an instance is
considered dead/crashed. */
+long DEFAULT_HEARTBEAT_TIMEOUT = 120;
+@AttributeDefinition(name = "%heartbeatTimeout.name", description =
"%heartbeatTimeout.description")
+long heartbeatTimeout() default DEFAULT_HEARTBEAT_TIMEOUT;
+
+/** Configure the interval (in seconds) according to which the heartbeats
are exchanged in the topology. */
+long DEFAULT_HEARTBEAT_INTERVAL = 30;
+@AttributeDefinition(name = "%heartbeatInterval.name", description =
"%heartbeatInterval.description")
+long heartbeatInterval() default DEFAULT_HEARTBEAT_INTERVAL;
+
+/** Configure the time (in seconds) which must be passed at minimum
between sending TOPOLOGY_CHANGING/_CHANGED (avoid flooding). */
+int DEFAULT_MIN_EVENT_DELAY = 3;
+@AttributeDefinition(name = "%minEventDelay.name", description =
"%minEventDelay.description")
+int minEventDelay() default DEFAULT_MIN_EVENT_DELAY;
+
+/** Configure the socket connect timeout for topology connectors. */
+int DEFAULT_CONNECTION_TIMEOUT = 10;
+@AttributeDefinition(name = "%connectionTimeout.name", description =
"%connectionTimeout.description")
+int connectionTimeout() default DEFAULT_CONNECTION_TIMEOUT;
+
+/** Configure the socket read timeout (SO_TIMEOUT) for topology
connectors. */
+int DEFAULT_SO_TIMEOUT = 10;
+@AttributeDefinition(name = "%soTimeout.name", description =
"%soTimeout.description")
+int soTimeout() default DEFAULT_SO_TIMEOUT;
+
+/** Name of the repository descriptor to be taken into account for leader
election:
+ those instances have preference to become leader which have the
corresponding descriptor value of 'false' */
+@AttributeDefinition(name = "%leaderElectionRepositoryDescriptor.name",
description = "%leaderElectionRepositoryDescriptor.description")
+String leaderElectionRepositoryDescriptor();
+
+/**
+ * Whether or not (default false) the leaderElectionRepositoryDescriptor
should be inverted (if that one
+ * is configured at all).
+ */
+@AttributeDefinition(name = "%invertRepositoryDescriptor.name",
description = "%invertRepositoryDescriptor.description")
+boolean invertRepositoryDescriptor() default false;
+
+/** URLs where to join a topology, eg
http://localhost:4502/libs/sling/topology/connector */
+@AttributeDefinition(name = "%topologyConnectorUrls.name", description =
"%topologyConnectorUrls.description", cardinality=1024)
+String[] topologyConnectorUrls() default {};
+
+/** list of ips and/or hostnames which are allowed to connect to
/libs/sling/topology/connector */
+@AttributeDefinition(name = "%topologyConnectorWhitelist.name",
description = "%topologyConnectorWhitelist.description")
+String[] topologyConnectorWhitelist() default {"localhost", "127.0.0.1"};
+String[] DEFAULT_TOPOLOGY_CONNECTOR_WHITELIST = {"localhost", "127.0.0.1"};
+
+/** Path of resource where to keep discovery information, e.g
/var/discovery/impl/ */
+@AttributeDefinition(name = "%discoveryResourcePath.name", description =
"%discoveryResourcePath.description")
+String discoveryResourcePath() default DEFAULT_DISCOVERY_RESOURCE_PATH;
+String DEFAULT_DISCOVERY_RESOURCE_PATH = "/var/discovery/impl/";
+
+/**
+ * If set to true, local-loops of topology connectors are automatically
stopped when detected so.
+ */
+@AttributeDefinition(name = "%autoStopLocalLoopEnabled.name", description
= "%autoStop
Re: [PR] SLING-12424: Migrate discovery.impl to official OSGi annotations [sling-org-apache-sling-discovery-impl]
mreutegg commented on code in PR #6:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-impl/pull/6#discussion_r1753280686
##
src/main/java/org/apache/sling/discovery/impl/DiscoveryServiceConfig.java:
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.sling.discovery.impl;
+
+import org.osgi.service.metatype.annotations.AttributeDefinition;
+import org.osgi.service.metatype.annotations.ObjectClassDefinition;
+
+@ObjectClassDefinition(
+localization = "OSGI-INF/l10n/metatype",
+name = "%config.name",
+description = "%config.description"
+)
+public @interface DiscoveryServiceConfig {
+
+/** Configure the timeout (in seconds) after which an instance is
considered dead/crashed. */
+long DEFAULT_HEARTBEAT_TIMEOUT = 120;
+@AttributeDefinition(name = "%heartbeatTimeout.name", description =
"%heartbeatTimeout.description")
+long heartbeatTimeout() default DEFAULT_HEARTBEAT_TIMEOUT;
+
+/** Configure the interval (in seconds) according to which the heartbeats
are exchanged in the topology. */
+long DEFAULT_HEARTBEAT_INTERVAL = 30;
+@AttributeDefinition(name = "%heartbeatInterval.name", description =
"%heartbeatInterval.description")
+long heartbeatInterval() default DEFAULT_HEARTBEAT_INTERVAL;
+
+/** Configure the time (in seconds) which must be passed at minimum
between sending TOPOLOGY_CHANGING/_CHANGED (avoid flooding). */
+int DEFAULT_MIN_EVENT_DELAY = 3;
+@AttributeDefinition(name = "%minEventDelay.name", description =
"%minEventDelay.description")
+int minEventDelay() default DEFAULT_MIN_EVENT_DELAY;
+
+/** Configure the socket connect timeout for topology connectors. */
+int DEFAULT_CONNECTION_TIMEOUT = 10;
+@AttributeDefinition(name = "%connectionTimeout.name", description =
"%connectionTimeout.description")
+int connectionTimeout() default DEFAULT_CONNECTION_TIMEOUT;
+
+/** Configure the socket read timeout (SO_TIMEOUT) for topology
connectors. */
+int DEFAULT_SO_TIMEOUT = 10;
+@AttributeDefinition(name = "%soTimeout.name", description =
"%soTimeout.description")
+int soTimeout() default DEFAULT_SO_TIMEOUT;
+
+/** Name of the repository descriptor to be taken into account for leader
election:
+ those instances have preference to become leader which have the
corresponding descriptor value of 'false' */
+@AttributeDefinition(name = "%leaderElectionRepositoryDescriptor.name",
description = "%leaderElectionRepositoryDescriptor.description")
+String leaderElectionRepositoryDescriptor();
+
+/**
+ * Whether or not (default false) the leaderElectionRepositoryDescriptor
should be inverted (if that one
+ * is configured at all).
+ */
+@AttributeDefinition(name = "%invertRepositoryDescriptor.name",
description = "%invertRepositoryDescriptor.description")
+boolean invertRepositoryDescriptor() default false;
+
+/** URLs where to join a topology, eg
http://localhost:4502/libs/sling/topology/connector */
+@AttributeDefinition(name = "%topologyConnectorUrls.name", description =
"%topologyConnectorUrls.description", cardinality=1024)
+String[] topologyConnectorUrls() default {};
+
+/** list of ips and/or hostnames which are allowed to connect to
/libs/sling/topology/connector */
+@AttributeDefinition(name = "%topologyConnectorWhitelist.name",
description = "%topologyConnectorWhitelist.description")
+String[] topologyConnectorWhitelist() default {"localhost", "127.0.0.1"};
+String[] DEFAULT_TOPOLOGY_CONNECTOR_WHITELIST = {"localhost", "127.0.0.1"};
+
+/** Path of resource where to keep discovery information, e.g
/var/discovery/impl/ */
+@AttributeDefinition(name = "%discoveryResourcePath.name", description =
"%discoveryResourcePath.description")
+String discoveryResourcePath() default DEFAULT_DISCOVERY_RESOURCE_PATH;
+String DEFAULT_DISCOVERY_RESOURCE_PATH = "/var/discovery/impl/";
+
+/**
+ * If set to true, local-loops of topology connectors are automatically
stopped when detected so.
+ */
+@AttributeDefinition(name = "%autoStopLocalLoopEnabled.name", description
= "%autoStop
Re: [PR] SLING-12424: Migrate discovery.impl to official OSGi annotations [sling-org-apache-sling-discovery-impl]
mreutegg commented on code in PR #6:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-impl/pull/6#discussion_r1753266143
##
src/main/java/org/apache/sling/discovery/impl/DiscoveryServiceConfig.java:
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.sling.discovery.impl;
+
+import org.osgi.service.metatype.annotations.AttributeDefinition;
+import org.osgi.service.metatype.annotations.ObjectClassDefinition;
+
+@ObjectClassDefinition(
+localization = "OSGI-INF/l10n/metatype",
+name = "%config.name",
+description = "%config.description"
+)
+public @interface DiscoveryServiceConfig {
Review Comment:
The discovery.oak bundle has a similar structure and went through the same
migration to official OSGi annotations. The config class there doesn't have a
pid. I'm also a bit confused, because I understand the configuration pid is
defined on `org.apache.sling.discovery.impl.Config` with
Component(configurationPid=...) and the value defaults to the name of the
component, which itself defaults to the fully qualified class name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-12424: Migrate discovery.impl to official OSGi annotations [sling-org-apache-sling-discovery-impl]
mreutegg commented on code in PR #6:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-impl/pull/6#discussion_r1753247709
##
src/main/java/org/apache/sling/discovery/impl/Config.java:
##
@@ -22,26 +22,34 @@
import java.net.URL;
import java.util.LinkedList;
import java.util.List;
-import java.util.Map;
-import org.apache.felix.scr.annotations.Activate;
-import org.apache.felix.scr.annotations.Component;
-import org.apache.felix.scr.annotations.Property;
-import org.apache.felix.scr.annotations.Service;
import org.apache.sling.commons.osgi.PropertiesUtil;
import org.apache.sling.discovery.base.connectors.BaseConfig;
import
org.apache.sling.discovery.commons.providers.spi.base.DiscoveryLiteConfig;
+import org.osgi.service.component.annotations.Activate;
+import org.osgi.service.component.annotations.Component;
+import org.osgi.service.metatype.annotations.Designate;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import static
org.apache.sling.discovery.impl.DiscoveryServiceConfig.DEFAULT_BACKOFF_STABLE_FACTOR;
+import static
org.apache.sling.discovery.impl.DiscoveryServiceConfig.DEFAULT_BACKOFF_STANDBY_FACTOR;
+import static
org.apache.sling.discovery.impl.DiscoveryServiceConfig.DEFAULT_CONNECTION_TIMEOUT;
+import static
org.apache.sling.discovery.impl.DiscoveryServiceConfig.DEFAULT_DISCOVERY_RESOURCE_PATH;
+import static
org.apache.sling.discovery.impl.DiscoveryServiceConfig.DEFAULT_HEARTBEAT_INTERVAL;
+import static
org.apache.sling.discovery.impl.DiscoveryServiceConfig.DEFAULT_HEARTBEAT_TIMEOUT;
+import static
org.apache.sling.discovery.impl.DiscoveryServiceConfig.DEFAULT_MIN_EVENT_DELAY;
+import static
org.apache.sling.discovery.impl.DiscoveryServiceConfig.DEFAULT_SO_TIMEOUT;
+import static
org.apache.sling.discovery.impl.DiscoveryServiceConfig.DEFAULT_TOPOLOGY_CONNECTOR_WHITELIST;
+
/**
* Configuration object used as a central config point for the discovery
service
* implementation
*
* The properties are described below under.
*/
-@Component(metatype = true, label="%config.name",
description="%config.description")
-@Service(value = { Config.class, BaseConfig.class, DiscoveryLiteConfig.class })
+@Component(service = { Config.class, BaseConfig.class,
DiscoveryLiteConfig.class })
+@Designate(ocd = DiscoveryServiceConfig.class)
public class Config implements BaseConfig, DiscoveryLiteConfig {
Review Comment:
I don't know this OSGi feature and I tried to keep changes to a minimum. But
it probably make sense to clean up the implementation further when there are
more simple alternatives for configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-12424: Migrate discovery.impl to official OSGi annotations [sling-org-apache-sling-discovery-impl]
mreutegg commented on code in PR #6:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-impl/pull/6#discussion_r1753235944
##
src/main/java/org/apache/sling/discovery/impl/Config.java:
##
@@ -227,50 +124,40 @@ public class Config implements BaseConfig,
DiscoveryLiteConfig {
private boolean useSyncTokenService = true;
@Activate
-protected void activate(final Map properties) {
+protected void activate(final DiscoveryServiceConfig config) {
logger.debug("activate: config activated.");
-configure(properties);
+configure(config);
}
-protected void configure(final Map properties) {
-this.heartbeatTimeout = PropertiesUtil.toLong(
-properties.get(HEARTBEAT_TIMEOUT_KEY),
-DEFAULT_HEARTBEAT_TIMEOUT);
+protected void configure(final DiscoveryServiceConfig config) {
+this.heartbeatTimeout = config.heartbeatTimeout();
logger.debug("configure: heartbeatTimeout='{}'",
this.heartbeatTimeout);
-this.heartbeatInterval = PropertiesUtil.toLong(
-properties.get(HEARTBEAT_INTERVAL_KEY),
-DEFAULT_HEARTBEAT_INTERVAL);
+this.heartbeatInterval = config.heartbeatInterval();
logger.debug("configure: heartbeatInterval='{}'",
this.heartbeatInterval);
-this.minEventDelay = PropertiesUtil.toInteger(
-properties.get(MIN_EVENT_DELAY_KEY),
-DEFAULT_MIN_EVENT_DELAY);
+this.minEventDelay = config.minEventDelay();
logger.debug("configure: minEventDelay='{}'",
this.minEventDelay);
-this.connectionTimeout = PropertiesUtil.toInteger(
-properties.get(CONNECTION_TIMEOUT_KEY),
-DEFAULT_CONNECTION_TIMEOUT);
+this.connectionTimeout = config.connectionTimeout();
logger.debug("configure: connectionTimeout='{}'",
this.connectionTimeout);
-this.soTimeout = PropertiesUtil.toInteger(
-properties.get(SO_TIMEOUT_KEY),
-DEFAULT_SO_TIMEOUT);
+this.soTimeout = config.soTimeout();
logger.debug("configure: soTimeout='{}'",
this.soTimeout);
Review Comment:
You mean the field declarations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-12424: Migrate discovery.impl to official OSGi annotations [sling-org-apache-sling-discovery-impl]
mreutegg commented on code in PR #6: URL: https://github.com/apache/sling-org-apache-sling-discovery-impl/pull/6#discussion_r1753234140 ## pom.xml: ## @@ -286,47 +194,21 @@ javax.servlet - servlet-api - - - org.apache.httpcomponents - httpclient-osgi - 4.3.5 - provided - - -commons-io -commons-io -2.4 + javax.servlet-api Review Comment: The existing pom.xml uses tabs and spaces inconsistently. I didn't want to spoil the diff/PR with unrelated changes and tried to keep the existing indentation style of a line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Various improvements for the webconsole plugin [sling-org-apache-sling-resourceresolver]
sonarcloud[bot] commented on PR #78: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/78#issuecomment-2338947001 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=78) **Quality Gate failed** Failed conditions  [2.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=78&metric=new_coverage&view=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=78) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12244 cache the result of the getParentResourceType call [sling-org-apache-sling-resourceresolver]
sonarcloud[bot] commented on PR #115: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/115#issuecomment-2338946429 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=115) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=115&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=115&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=115&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=115&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=115&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=115) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12424: Migrate discovery.impl to official OSGi annotations [sling-org-apache-sling-discovery-impl]
rombert merged PR #6: URL: https://github.com/apache/sling-org-apache-sling-discovery-impl/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12424: Migrate discovery.impl to official OSGi annotations [sling-org-apache-sling-discovery-impl]
mreutegg opened a new pull request, #6: URL: https://github.com/apache/sling-org-apache-sling-discovery-impl/pull/6 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.apache.derby:derby from 10.14.2.0 to 10.17.1.0 [sling-org-apache-sling-discovery-impl]
dependabot[bot] opened a new pull request, #4: URL: https://github.com/apache/sling-org-apache-sling-discovery-impl/pull/4 Bumps org.apache.derby:derby from 10.14.2.0 to 10.17.1.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/sling-org-apache-sling-discovery-impl/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12419: Snapshot dependencies in discovery.impl [sling-org-apache-sling-discovery-impl]
rombert merged PR #3: URL: https://github.com/apache/sling-org-apache-sling-discovery-impl/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Adding fix for SLING-8974 [sling-org-apache-sling-servlets-post]
sonarcloud[bot] commented on PR #26: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/26#issuecomment-2334916936 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-servlets-post&pullRequest=26) **Quality Gate failed** Failed conditions  [54.5% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=26&metric=new_coverage&view=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-servlets-post&pullRequest=26) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12420 - JSP scripts are falsely re-compiled on events from HTL engine [sling-org-apache-sling-scripting-jsp]
jsedding opened a new pull request, #8: URL: https://github.com/apache/sling-org-apache-sling-scripting-jsp/pull/8 - only handle changes under path /org/apache/jsp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12244 cache the result of the getParentResourceType call [sling-org-apache-sling-resourceresolver]
sonarcloud[bot] commented on PR #115: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/115#issuecomment-2327305093 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=115) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=115&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=115&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=115&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=115&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=115&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=115) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Various improvements for the webconsole plugin [sling-org-apache-sling-resourceresolver]
sonarcloud[bot] commented on PR #78: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/78#issuecomment-2327302439 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=78) **Quality Gate failed** Failed conditions  [2.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=78&metric=new_coverage&view=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=78) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11352 - Fix parsing of path-only mappings [sling-org-apache-sling-resourceresolver]
sonarcloud[bot] commented on PR #84: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/84#issuecomment-2327302134 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=84) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=84&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=84&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=84&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=84&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=84&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=84) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Adding ability to review selected auth handler [sling-org-apache-sling-auth-core]
pat-lego commented on PR #15: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/15#issuecomment-2326797887 @cziegeler fixed the code to use toString. Note that some classes override the toString and use generic naming conventions which makes it more complex to determine the class that represents AuthenticationHandler. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Adding ability to review selected auth handler [sling-org-apache-sling-auth-core]
sonarcloud[bot] commented on PR #15: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/15#issuecomment-2326782854 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-auth-core&pullRequest=15) **Quality Gate failed** Failed conditions  [50.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-core&pullRequest=15&metric=new_coverage&view=list) (required ≥ 80%)  [B Maintainability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-auth-core&pullRequest=15) (required ≥ A) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-auth-core&pullRequest=15) ##  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] explain that empty strings are invalid alias values (see SLING-12399) [sling-site]
reschke merged PR #178: URL: https://github.com/apache/sling-site/pull/178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12399: make empty alias invalid [sling-org-apache-sling-resourceresolver]
reschke merged PR #123: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Adding ability to review selected auth handler [sling-org-apache-sling-auth-core]
cziegeler commented on PR #15: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/15#issuecomment-2324746762 ok, simply relying on toString() will give you that - avoids all null checking/handling - and if the handler overrides toString you benefit from that as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Adding ability to review selected auth handler [sling-org-apache-sling-auth-core]
pat-lego commented on PR #15: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/15#issuecomment-2324734509 The original purpose of this change was to expose the authentication handler class name. This was the necessary information needed to resolve a large escalation no other information was needed. This pull request provides that exact information, anything else is just extra and was not needed to resolve the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12413: update/improve code [sling-org-apache-sling-testing-osgi-mock]
stefanseifert merged PR #42: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12413: update/improve code [sling-org-apache-sling-testing-osgi-mock]
stefanseifert commented on PR #42: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/42#issuecomment-2324659439 > The sonarcloud issues are because I fixed a typo in an exception message, so it asks for a constant. Don't think that's crucial here. thanks, lgtm. not sure why those warnings relating to the RuntimeException and it's messages are reported as new issues here - they were present before already. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12413: update/improve code [sling-org-apache-sling-testing-osgi-mock]
senn commented on PR #42: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/42#issuecomment-2324475939 The sonarcloud issues are because I fixed a typo in an exception message, so it asks for a constant. Don't think that's crucial here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12413: update/improve code [sling-org-apache-sling-testing-osgi-mock]
sonarcloud[bot] commented on PR #42: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/42#issuecomment-2324426075 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=42) **Quality Gate failed** Failed conditions  [D Maintainability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=42) (required ≥ A) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=42) ##  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12413: update/improve code [sling-org-apache-sling-testing-osgi-mock]
senn commented on PR #42: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/42#issuecomment-2324115017 @stefanseifert anything else you'd like to see updated? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12413: update/improve code [sling-org-apache-sling-testing-osgi-mock]
senn opened a new pull request, #42: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/42 Some code improvements suggested by Sonar in original PR #41 + fixed some (some-what related) warnings my IDE pointed out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Adding ability to review selected auth handler [sling-org-apache-sling-auth-core]
cziegeler commented on PR #15: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/15#issuecomment-2323807272 @pat-lego Thanks for the updates, any reason why you want to explicitly log the class name instead of relying on toString() returning something (more) useful? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency org.apache.sling:org.apache.sling.commons.threads to v3.3.0 [sling-site]
renovate-bot opened a new pull request, #177: URL: https://github.com/apache/sling-site/pull/177 This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.sling:org.apache.sling.commons.threads](https://sling.apache.org) ([source](https://togithub.com/apache/sling-org-apache-sling-commons-threads)) | `3.2.30` -> `3.3.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/apache/sling-site). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
