[jira] [Commented] (SLING-7486) Remove tags of canceled releases from Subversion and Git repositories

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378810#comment-16378810
 ] 

Robert Munteanu commented on SLING-7486:


But we can always clean up Git, there's nothing stopping us from doing that and 
I think it's the right thing to do. It's SVN that I don't really want to touch 
anymore :-)

> Remove tags of canceled releases from Subversion and Git repositories
> -
>
> Key: SLING-7486
> URL: https://issues.apache.org/jira/browse/SLING-7486
> Project: Sling
>  Issue Type: Task
>  Components: Best practices, General
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> ||Subversion Tag||POM Group ID||POM Artifact ID||POM Version||TODO||
> |org.apache.sling.bgservlets-1.0.0|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT|
>  remove |
> |org.apache.sling.bgservlets-1.0.2|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT|
>  remove |
> |org.apache.sling.commons.johnzon-1.0.2|org.apache.sling|org.apache.sling.commons.johnzon|1.0.2|
>  remove |
> |org.apache.sling.commons.metrics-0.0.2|org.apache.sling|org.apache.sling.commons.metrics|0.0.2|
>  remove |
> |org.apache.sling.crankstart.api.fragment-1.0.0|org.apache.sling|org.apache.sling.crankstart.api.fragment|1.0.0|
>  remove |
> |org.apache.sling.discovery.base-2.0.2|org.apache.sling|org.apache.sling.discovery.base|2.0.2|
>  remove |
> |org.apache.sling.discovery.commons-1.0.14|org.apache.sling|org.apache.sling.discovery.commons|1.0.14|
>  remove |
> |org.apache.sling.discovery.commons-1.0.22|org.apache.sling|org.apache.sling.discovery.commons|1.0.22|
>  remove |
> |org.apache.sling.discovery.oak-1.2.12|org.apache.sling|org.apache.sling.discovery.oak|1.2.12|
>  remove |
> |org.apache.sling.event-3.3.8|org.apache.sling|org.apache.sling.event|3.3.8| 
> remove |
> |org.apache.sling.fsresource-1.2.0|org.apache.sling|org.apache.sling.fsresource|1.2.0|
>  remove |
> |org.apache.sling.hc.core-1.0.0|org.apache.sling|sling-builder|7-SNAPSHOT| 
> remove |
> |org.apache.sling.hc.core-1.0.2|org.apache.sling|sling-builder|7-SNAPSHOT| 
> remove |
> |org.apache.sling.i18n-2.3.0|org.apache.sling|org.apache.sling.i18n|2.3.0| 
> remove |
> |org.apache.sling.i18n-2.4.0|org.apache.sling|org.apache.sling.i18n|2.4.0| 
> remove |
> |org.apache.sling.installer.factory.configuration-1.0.6|org.apache.sling|org.apache.sling.installer.factory.configuration|1.0.6|
>  remove |
> |org.apache.sling.jcr.base-2.0.8|org.apache.sling|org.apache.sling.jcr.base|2.0.8|
>  remove |
> |org.apache.sling.jcr.oak.server-1.1.2|org.apache.sling|org.apache.sling.jcr.oak.server|1.1.2|
>  remove |
> |org.apache.sling.jcr.resource-2.4.0|org.apache.sling|org.apache.sling.jcr.resource|2.4.0|
>  remove |
> |org.apache.sling.junit.healthcheck-1.0.4|org.apache.sling|org.apache.sling.junit.remote|1.0.9-SNAPSHOT|
>  remove |
> |org.apache.sling.launchpad.test-services-2.0.4-incubator|org.apache.sling|org.apache.sling.launchpad.test-services|2.0.4-incubator|
>  remove |
> |org.apache.sling.launchpad.testing-6|org.apache.sling|org.apache.sling.launchpad.testing|6|
>  remove |
> |org.apache.sling.launchpad.testing-war-6|org.apache.sling|org.apache.sling.launchpad.testing-war|6|
>  remove |
> |org.apache.sling.performance.base-0.0.2|org.apache.sling|org.apache.sling.performance.base|0.0.2|
>  remove |
> |org.apache.sling.resourcemerger-1.2.2|org.apache.sling|org.apache.sling.resourcemerger|1.2.2|
>  remove |
> |org.apache.sling.resourceresolver-1.4.6|org.apache.sling|org.apache.sling.resourceresolver|1.4.6|
>  remove |
> |org.apache.sling.scripting.core-2.0.12|org.apache.sling|org.apache.sling.scripting.core|2.0.12|
>  remove |
> |org.apache.sling.scripting.java-2.0.8|org.apache.sling|org.apache.sling.scripting.java|2.0.8|
>  remove |
> |org.apache.sling.scripting.jsp-2.1.2|org.apache.sling|org.apache.sling.scripting.jsp|2.1.2|
>  remove |
> |org.apache.sling.scripting.jsp.taglib-2.1.4|org.apache.sling|org.apache.sling.scripting.jsp.taglib|2.1.4|
>  remove |
> |org.apache.sling.scripting.velocity-2.0.0|org.apache.sling|org.apache.sling.scripting.velocity|2.0.0|
>  remove |
> |org.apache.sling.testing.tools-1.0.4|org.apache.sling|org.apache.sling.testing.tools|1.0.4|
>  remove |
> |org.apache.sling.validation.reactor-1.0.0|org.apache.sling|org.apache.sling.validation.reactor|1.0.0-SNAPSHOT|
>  remove |
> |sling-6-source-release|org.apache.sling|sling-builder|6-SNAPSHOT| remove |
> |sling-archetype-parent-2|org.apache.sling|sling-archetype-parent|2-SNAPSHOT| 
> remove |
> |sling-archetype-parent-3|org.apache.sling|sling-archetype-parent|3| remove |
> |sling-ide-tooling-1.0.10|org.apache.sling.ide|reactor|1.0.10| keep |
> |sling-ide-tooling-1.0.2|org.apache.sling.ide|reactor|1.0.2| keep |
> 

Re: If it didn't happen on the dev list... (was: [Maven] Updating to parent pom 33 breaks all projects)

[Robert Munteanu]

+1

On Mon, 2018-02-26 at 13:38 +0100, Bertrand Delacretaz wrote:
> Hi,
> 
> On Mon, Feb 26, 2018 at 1:28 PM, Carsten Ziegeler  rg> wrote:
> > ...It would just have been nice to hear about
> > these breaking changes in some way. But I guess I could have seen
> > this
> > coming by watching the commits...
> 
> I think we need to remember to bring *all* important discussions
> here,
> even if it's just a heads up and link asking people to participate in
> a discussion in another place.
> 
> With our many Git repositories and tickets it's easy for discussions
> to happen elsewhere, and it's fine in many cases, but one should be
> aware of all important things by just following this list.
> 
> Now, of course, the definition of "important" varies...so this is
> just
> a friendly reminder, I'm not pointing fingers - but we have a
> concrete
> example here where breaking changes were apparently not discussed on
> this list, and it's not ok in general.
> 
> -Bertrand

[jira] [Assigned] (SLING-7520) Sling Query - shortened URL goes to non apache site

[Jason E Bailey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason E Bailey reassigned SLING-7520:
-

Assignee: Jason E Bailey

> Sling Query - shortened URL goes to non apache site
> ---
>
> Key: SLING-7520
> URL: https://issues.apache.org/jira/browse/SLING-7520
> Project: Sling
>  Issue Type: Improvement
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Trivial
>
> Warning is generated out of Sling Query which contains a shortened url that 
> links to the previous site before it was merged.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7519) Add webconsole ds module to SlingOptions

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz updated SLING-7519:

Attachment: Toolbox.png

> Add webconsole ds module to SlingOptions
> 
>
> Key: SLING-7519
> URL: https://issues.apache.org/jira/browse/SLING-7519
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Sling Pax Exam Utilities 1.0.4
>Reporter: Christian Schneider
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Pax Exam Utilities 1.0.6
>
> Attachments: Toolbox.png
>
>
> Sling uses DS all over the place. We should add the ds module for the 
> webconsole to have more insight into the DS components in tests.
> I will supply a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [Maven] Updating to parent pom 33 breaks all projects

[Oliver Lietz]

On Tuesday 27 February 2018 18:28:05 Robert Munteanu wrote:
> On Tue, 2018-02-27 at 17:09 +0100, Oliver Lietz wrote:
> > > Well, let's try and avoid that :-)
> > > 
> > > Could we either:
> > > 
> > > 1) Create a profile in the parent pom, activated for bundle
> > > projects,
> > > which adds the OSGi dependencies?
> > > 
> > > 2) Create a 'non-OSGi' parent POM (A) and an 'OSGi' parent POM (B),
> > > where A is the parent of B. This way we could use the parent POM in
> > > different projects without getting any clashes.
> > 
> > We could use the bundle profile but that "requires" switching to bnd
> > Maven
> > Plugin (or at least placing a file bnd.bnd in the module).
> 
> Well, I assume that using the bnd.bnd file is another manual transition
> that we must do, right? If that is the case we should discuss it on the
> dev list before committing to another migration.

Putting bnd instructions into a file is the preferred way (instead of POM, see 
discussion in SLING-7417). Once Maven JAR Plugin is fixed those profile from 
parent can be removed. You don't have to switch to bnd Maven Plugin, Maven 
Bundle Plugin is still supported.

> Maybe we can have a compromise and require a property in the pom, e.g.
> 
>   
> true
>   
> 
> That property will activate the OSGi-related profile from the parent
> pom.
> 
> Not ideal but still better than copy/pasting considerably more
> dependency versions.

Ugly... no other way to activate profile?

O.

> Robert

[jira] [Commented] (SLING-7519) Add webconsole ds module to SlingOptions

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378884#comment-16378884
 ] 

Robert Munteanu commented on SLING-7519:


[~olli] - I don't have a strong opinion on this so I'll leave this between you 
and [~ch...@die-schneider.net]

> Add webconsole ds module to SlingOptions
> 
>
> Key: SLING-7519
> URL: https://issues.apache.org/jira/browse/SLING-7519
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Sling Pax Exam Utilities 1.0.4
>Reporter: Christian Schneider
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Pax Exam Utilities 1.0.6
>
> Attachments: Toolbox.png
>
>
> Sling uses DS all over the place. We should add the ds module for the 
> webconsole to have more insight into the DS components in tests.
> I will supply a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [Maven] Updating to parent pom 33 breaks all projects

[Konrad Windszus]

> 
> Maybe we can have a compromise and require a property in the pom, e.g. 
> 
>  
>true
>  
> 
> That property will activate the OSGi-related profile from the parent
> pom.
> 
> Not ideal but still better than copy/pasting considerably more
> dependency versions.
> 

This is not supported by Maven. Only properties given via command line can be 
used for profile activation (see https://issues.apache.org/jira/browse/MNG-5127 
and a lot of related tickets). Therefore we would rather need to rely on 
existence of a dedicated marker file.

role permission added in JIRA

[Jason E Bailey]

I need someone with admin access in JIRA, which there are a bunch of
you :) to provide me with a committers role so that I can assign stuff
to myself.
username: jebailey
role: committers

And I already checked, this is not an Infra ticket, there is no ldap
synchronization going on.
thanks!
- Jason

Re: [Maven] Updating to parent pom 33 breaks all projects

[Robert Munteanu]

On Mon, 2018-02-26 at 12:54 +0100, Carsten Ziegeler wrote:
> I'm talking about:
> 
>
>
> org.osgi
> org.osgi.annotation.versioning d>
> 1.0.0
> provided
> 
> 
> 
> org.osgi
> 
> org.osgi.service.component.annotations
> 1.3.0
> provided
> 
> 
> 
> org.osgi
> 
> org.osgi.service.metatype.annotations
> 1.3.0
> provided
> 
> 
> Sure, it's a one time effort, but for 100++ modules


Well, let's try and avoid that :-)

Could we either:

1) Create a profile in the parent pom, activated for bundle projects,
which adds the OSGi dependencies?

2) Create a 'non-OSGi' parent POM (A) and an 'OSGi' parent POM (B),
where A is the parent of B. This way we could use the parent POM in
different projects without getting any clashes.

Robert

[jira] [Updated] (SLING-7520) Sling Query - shortened URL goes to non apache site

[Jason E Bailey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason E Bailey updated SLING-7520:
--
Component/s: Sling Query

> Sling Query - shortened URL goes to non apache site
> ---
>
> Key: SLING-7520
> URL: https://issues.apache.org/jira/browse/SLING-7520
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Query
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Trivial
>
> Warning is generated out of Sling Query which contains a shortened url that 
> links to the previous site before it was merged.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [Maven] Updating to parent pom 33 breaks all projects

[Robert Munteanu]

On Tue, 2018-02-27 at 17:09 +0100, Oliver Lietz wrote:
> > Well, let's try and avoid that :-)
> > 
> > Could we either:
> > 
> > 1) Create a profile in the parent pom, activated for bundle
> > projects,
> > which adds the OSGi dependencies?
> > 
> > 2) Create a 'non-OSGi' parent POM (A) and an 'OSGi' parent POM (B),
> > where A is the parent of B. This way we could use the parent POM in
> > different projects without getting any clashes.
> 
> We could use the bundle profile but that "requires" switching to bnd
> Maven 
> Plugin (or at least placing a file bnd.bnd in the module).

Well, I assume that using the bnd.bnd file is another manual transition
that we must do, right? If that is the case we should discuss it on the
dev list before committing to another migration.

Maybe we can have a compromise and require a property in the pom, e.g. 

  
true
  

That property will activate the OSGi-related profile from the parent
pom.

Not ideal but still better than copy/pasting considerably more
dependency versions.

Robert

[jira] [Commented] (SLING-7519) Add webconsole ds module to SlingOptions

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378878#comment-16378878
 ] 

Oliver Lietz commented on SLING-7519:
-

[~ch...@die-schneider.net], [~rombert], in a nutshell: do we really have to 
extend the {{webconsole}} option or is adding the plugin to a module's base 
test class sufficient? How about adding the plugin to options 
{{slingQuickstartOakTar}} and {{slingQuickstartOakMongo}} (the ones with params 
in template).

> Add webconsole ds module to SlingOptions
> 
>
> Key: SLING-7519
> URL: https://issues.apache.org/jira/browse/SLING-7519
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Sling Pax Exam Utilities 1.0.4
>Reporter: Christian Schneider
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Pax Exam Utilities 1.0.6
>
> Attachments: Toolbox.png
>
>
> Sling uses DS all over the place. We should add the ds module for the 
> webconsole to have more insight into the DS components in tests.
> I will supply a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7521) [Sling Feature Model] Order bundles in the generated app based on feature order and start order

[David Bosschaert (JIRA)]

David Bosschaert created SLING-7521:
---

 Summary: [Sling Feature Model] Order bundles in the generated app 
based on feature order and start order
 Key: SLING-7521
 URL: https://issues.apache.org/jira/browse/SLING-7521
 Project: Sling
  Issue Type: Improvement
  Components: Tooling
Reporter: David Bosschaert


When an application is generated from a number of features it needs to 
aggregate all bundles form these features and put them in the correct global 
order. Bundles have a start-order associated with them which is local within 
the feature, but outside of the feature needs to be relative to other features.

The resulting application needs to have all bundles ordered in such an order 
that all dependencies by other bundles are started before the bundles that 
depend on them are started.
Additionally, the start-order of bundles within the feature from which the 
bundles originate must be complied with.

The result needs to be a bundle list that has a total ordering of bundles from 
all features that are part of the application.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: role permission added in JIRA

[Robert Munteanu]

Hi Jason,

On Tue, 2018-02-27 at 10:30 -0500, Jason E Bailey wrote:
> I need someone with admin access in JIRA, which there are a bunch of
> you :) to provide me with a committers role so that I can assign
> stuff
> to myself.
> username: jebailey
> role: committers
> 
> And I already checked, this is not an Infra ticket, there is no ldap
> synchronization going on.

:-)

Added you to the admins group, please double-check.

Robert

[jira] [Commented] (SLING-7519) Add webconsole ds module to SlingOptions

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378865#comment-16378865
 ] 

Oliver Lietz commented on SLING-7519:
-

[~ch...@die-schneider.net], affects/fix versions of this issue: _Sling Pax Exam 
Utilities_ – it's an outdated relative but not the affected module _Sling 
Testing PaxExam_.

{{slf4j-simple}} – is logging in the tests required/useful (then {{test}} scope 
is fine)?

Templates: The process from Karaf Features → Handlebars Templates → Java 
sources cannot be fully automated and requires some intervention by hand (see 
comments in {{SlingOptions.java}}). I'm using a tool (with GUI) for processing 
those templates and updating Karaf features which is still work in progress and 
not available in public yet (and not required as updating by hand is possible 
of course).

 !Toolbox.png|width=1044! 

> Add webconsole ds module to SlingOptions
> 
>
> Key: SLING-7519
> URL: https://issues.apache.org/jira/browse/SLING-7519
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Sling Pax Exam Utilities 1.0.4
>Reporter: Christian Schneider
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Pax Exam Utilities 1.0.6
>
> Attachments: Toolbox.png
>
>
> Sling uses DS all over the place. We should add the ds module for the 
> webconsole to have more insight into the DS components in tests.
> I will supply a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7511) Add importContent to SlingClient

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378842#comment-16378842
 ] 

ASF GitHub Bot commented on SLING-7511:
---

rombert commented on a change in pull request #6: SLING-7511: Add importContent 
to SlingClient
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/6#discussion_r170972204
 
 

 ##
 File path: src/main/java/org/apache/sling/testing/clients/package-info.java
 ##
 @@ -17,7 +17,7 @@
  * under the License.
  */
 
-@Version("1.4.0")
+@Version("1.5.0")
 
 Review comment:
   Right, this one should be ok.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add importContent to SlingClient
> 
>
> Key: SLING-7511
> URL: https://issues.apache.org/jira/browse/SLING-7511
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Reporter: Valentin Olteanu
>Priority: Major
>
> Add operations specific to 
> [http://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#importing-content-structures]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7520) Sling Query - shortened URL goes to non apache site

[Jason E Bailey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason E Bailey resolved SLING-7520.
---
Resolution: Fixed

url updated

> Sling Query - shortened URL goes to non apache site
> ---
>
> Key: SLING-7520
> URL: https://issues.apache.org/jira/browse/SLING-7520
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Query
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Trivial
>
> Warning is generated out of Sling Query which contains a shortened url that 
> links to the previous site before it was merged.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: role permission added in JIRA

[Jason E Bailey]

Everything looks good. Thanks Robert !

- Jason

On Tue, Feb 27, 2018, at 10:41 AM, Robert Munteanu wrote:
> Hi Jason,
> 
> On Tue, 2018-02-27 at 10:30 -0500, Jason E Bailey wrote:
> > I need someone with admin access in JIRA, which there are a bunch of
> > you :) to provide me with a committers role so that I can assign
> > stuff
> > to myself.
> > username: jebailey
> > role: committers
> > 
> > And I already checked, this is not an Infra ticket, there is no ldap
> > synchronization going on.
> 
> :-)
> 
> Added you to the admins group, please double-check.
> 
> Robert

[jira] [Commented] (SLING-7521) [Sling Feature Model] Order bundles in the generated app based on feature order and start order

[David Bosschaert (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378892#comment-16378892
 ] 

David Bosschaert commented on SLING-7521:
-

I'm currently looking at a way to address this.

> [Sling Feature Model] Order bundles in the generated app based on feature 
> order and start order
> ---
>
> Key: SLING-7521
> URL: https://issues.apache.org/jira/browse/SLING-7521
> Project: Sling
>  Issue Type: Improvement
>  Components: Tooling
>Reporter: David Bosschaert
>Priority: Major
>
> When an application is generated from a number of features it needs to 
> aggregate all bundles form these features and put them in the correct global 
> order. Bundles have a start-order associated with them which is local within 
> the feature, but outside of the feature needs to be relative to other 
> features.
> The resulting application needs to have all bundles ordered in such an order 
> that all dependencies by other bundles are started before the bundles that 
> depend on them are started.
> Additionally, the start-order of bundles within the feature from which the 
> bundles originate must be complied with.
> The result needs to be a bundle list that has a total ordering of bundles 
> from all features that are part of the application.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7519) Add webconsole ds module to SlingOptions

[Christian Schneider (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378921#comment-16378921
 ] 

Christian Schneider commented on SLING-7519:


I am fine with adding this to some basic test class if you think it makes more 
sense. 

I simply thought that we use DS all over the place so I added the DS plugin in 
a central place where it is always there. 

 

> Add webconsole ds module to SlingOptions
> 
>
> Key: SLING-7519
> URL: https://issues.apache.org/jira/browse/SLING-7519
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Sling Pax Exam Utilities 1.0.4
>Reporter: Christian Schneider
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Pax Exam Utilities 1.0.6
>
> Attachments: Toolbox.png
>
>
> Sling uses DS all over the place. We should add the ds module for the 
> webconsole to have more insight into the DS components in tests.
> I will supply a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7519) Add webconsole ds module to SlingOptions

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378760#comment-16378760
 ] 

Oliver Lietz commented on SLING-7519:
-

See also SLING-5896.

> Add webconsole ds module to SlingOptions
> 
>
> Key: SLING-7519
> URL: https://issues.apache.org/jira/browse/SLING-7519
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Sling Pax Exam Utilities 1.0.4
>Reporter: Christian Schneider
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Pax Exam Utilities 1.0.6
>
>
> Sling uses DS all over the place. We should add the ds module for the 
> webconsole to have more insight into the DS components in tests.
> I will supply a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7169) FullTextIndexingTest sometimes fails with a timeout

[Thomas Mueller (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378800#comment-16378800
 ] 

Thomas Mueller commented on SLING-7169:
---

For older versions of Oak, if "option(index tag fulltextAsync)" is not 
available, one option is to run the query with the "explain" feature, and check 
if the right index is used. If not, then re-run the query until it is. The 
"explain" feature means: prepend the term "explain " to the query. See [the 
docs|http://jackrabbit.apache.org/oak/docs/query/grammar-xpath.html#explain] 
for "explain". This feature is available since Oak 1.0 I believe.

> FullTextIndexingTest sometimes fails with a timeout
> ---
>
> Key: SLING-7169
> URL: https://issues.apache.org/jira/browse/SLING-7169
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad
>Reporter: Robert Munteanu
>Priority: Major
>  Labels: sling-IT
> Attachments: SLING-7169-logs.tar.gz
>
>
> The test fails maybe 1 in 10 runs. I could reproduce this locally by running 
> many times. I've also seen it once on Jenkins.
> **Old description below**
> After upgrading the launchpad to commons.threads 3.2.10 the 
> FullTextIndexingTest failed ( [build 
> 1547|https://builds.apache.org/job/sling-launchpad-testing-1.8/1547/] ).
> I also reproduced it once locally.
> [~kwin] - since the commons.threads release is the potential root cause, can 
> you please take a look at the failure and see if it's related?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [Maven] Updating to parent pom 33 breaks all projects

[Oliver Lietz]

On Tuesday 27 February 2018 17:58:50 Robert Munteanu wrote:
> On Mon, 2018-02-26 at 12:54 +0100, Carsten Ziegeler wrote:
> > I'm talking about:
> >
> >
> >
> > org.osgi
> > org.osgi.annotation.versioning > 
> > d>
> > 
> > 1.0.0
> > provided
> > 
> > 
> > 
> > 
> > 
> > 
> > org.osgi
> > 
> > org.osgi.service.component.annotations
> > 
> > 1.3.0
> > provided
> > 
> > 
> > 
> > 
> > 
> > 
> > org.osgi
> > 
> > org.osgi.service.metatype.annotations
> > 
> > 1.3.0
> > provided
> > 
> > 
> > 
> > Sure, it's a one time effort, but for 100++ modules
> 
> Well, let's try and avoid that :-)
> 
> Could we either:
> 
> 1) Create a profile in the parent pom, activated for bundle projects,
> which adds the OSGi dependencies?
> 
> 2) Create a 'non-OSGi' parent POM (A) and an 'OSGi' parent POM (B),
> where A is the parent of B. This way we could use the parent POM in
> different projects without getting any clashes.

We could use the bundle profile but that "requires" switching to bnd Maven 
Plugin (or at least placing a file bnd.bnd in the module).

Regards,
O.

> Robert

Re: [Maven] Updating to parent pom 33 breaks all projects

[Jason E Bailey]

+1 on this, my mental model of a parent POM is to handle the commonality, if 
there are a hundred projects that require the same settings in a POM that 
should be moved up to a parent, much like I would do if I were developing.

--
Jason

On Tue, Feb 27, 2018, at 10:58 AM, Robert Munteanu wrote:

> 
> Well, let's try and avoid that :-)
> 
> Could we either:
> 
> 1) Create a profile in the parent pom, activated for bundle projects,
> which adds the OSGi dependencies?
> 
> 2) Create a 'non-OSGi' parent POM (A) and an 'OSGi' parent POM (B),
> where A is the parent of B. This way we could use the parent POM in
> different projects without getting any clashes.
> 
> Robert

[jira] [Commented] (SLING-7519) Add webconsole ds module to SlingOptions

[Christian Schneider (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378769#comment-16378769
 ] 

Christian Schneider commented on SLING-7519:


[~olli] I did not yet understand how those templates work. How do I trigger 
them? I did not find any maven goal. I will provide a PR to fix the templates 
but I would like to see how they reflect in the java code. I then can also 
provide some text in the readme for how to use the templates.

About slf4j-simple. I added it just for the the tests in this project. As it 
has the test scope I think it should not affect other bundles transitively. Is 
this assumption correct?

I also did not understand what you mean by "fix version". Where do I need to do 
this?

 

> Add webconsole ds module to SlingOptions
> 
>
> Key: SLING-7519
> URL: https://issues.apache.org/jira/browse/SLING-7519
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Sling Pax Exam Utilities 1.0.4
>Reporter: Christian Schneider
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Pax Exam Utilities 1.0.6
>
>
> Sling uses DS all over the place. We should add the ds module for the 
> webconsole to have more insight into the DS components in tests.
> I will supply a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Reopened] (SLING-7519) Add webconsole ds module to SlingOptions

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reopened SLING-7519:


Reopening until we have consensus on the fix, thanks for the heads-up [~olli]

> Add webconsole ds module to SlingOptions
> 
>
> Key: SLING-7519
> URL: https://issues.apache.org/jira/browse/SLING-7519
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Sling Pax Exam Utilities 1.0.4
>Reporter: Christian Schneider
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Pax Exam Utilities 1.0.6
>
>
> Sling uses DS all over the place. We should add the ds module for the 
> webconsole to have more insight into the DS components in tests.
> I will supply a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7169) FullTextIndexingTest sometimes fails with a timeout

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378807#comment-16378807
 ] 

Robert Munteanu commented on SLING-7169:


Moving to Oak 1.8 is "in progress", see SLING-7446 . Adding Oak 1.6 support 
depends on how much of in a hurry you are :-)

> FullTextIndexingTest sometimes fails with a timeout
> ---
>
> Key: SLING-7169
> URL: https://issues.apache.org/jira/browse/SLING-7169
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad
>Reporter: Robert Munteanu
>Priority: Major
>  Labels: sling-IT
> Attachments: SLING-7169-logs.tar.gz
>
>
> The test fails maybe 1 in 10 runs. I could reproduce this locally by running 
> many times. I've also seen it once on Jenkins.
> **Old description below**
> After upgrading the launchpad to commons.threads 3.2.10 the 
> FullTextIndexingTest failed ( [build 
> 1547|https://builds.apache.org/job/sling-launchpad-testing-1.8/1547/] ).
> I also reproduced it once locally.
> [~kwin] - since the commons.threads release is the potential root cause, can 
> you please take a look at the failure and see if it's related?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7511) Add importContent to SlingClient

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378840#comment-16378840
 ] 

ASF GitHub Bot commented on SLING-7511:
---

rombert commented on a change in pull request #6: SLING-7511: Add importContent 
to SlingClient
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/6#discussion_r170971993
 
 

 ##
 File path: 
src/test/java/org/apache/sling/testing/clients/SlingClientImportContentTest.java
 ##
 @@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations 
under
+ * the License.
+ */
+package org.apache.sling.testing.clients;
+
+import org.apache.http.*;
+import org.apache.http.client.utils.URLEncodedUtils;
+import org.apache.http.protocol.HttpContext;
+import org.apache.http.protocol.HttpRequestHandler;
+import org.codehaus.jackson.node.JsonNodeFactory;
+import org.codehaus.jackson.node.ObjectNode;
+import org.junit.ClassRule;
+import org.junit.Ignore;
+import org.junit.Test;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.PrintWriter;
+import java.net.URI;
+import java.util.List;
+
+import static org.apache.http.HttpStatus.SC_BAD_REQUEST;
+import static org.apache.http.HttpStatus.SC_CREATED;
+import static org.apache.http.HttpStatus.SC_OK;
+
+public class SlingClientImportContentTest {
+private static final String IMPORT_PATH = "/test/import/parent";
+
+@ClassRule
+public static HttpServerRule httpServer = new HttpServerRule() {
+@Override
+protected void registerHandlers() throws IOException {
+serverBootstrap.registerHandler(IMPORT_PATH, new 
HttpRequestHandler() {
+@Override
+public void handle(HttpRequest request, HttpResponse response, 
HttpContext context) throws HttpException, IOException {
+String operation = null;
+String content = null;
+if (request instanceof HttpEntityEnclosingRequest) {
+HttpEntity entity = ((HttpEntityEnclosingRequest) 
request).getEntity();
+List params = 
URLEncodedUtils.parse(entity);
+for (NameValuePair param : params) {
+if (param.getName().equals(":operation")) {
+operation = param.getValue();
+}
+
+if (param.getName().equals(":content")) {
+content = param.getValue();
+}
+}
+}
+
+if (!"import".equals(operation)) {
+response.setStatusCode(SC_BAD_REQUEST);
+return;
+}
+
+if 
(!"{\"something\":{\"prop1\":\"val1\"}}".equals(content)) {
+System.out.println("Unexpected content: " + content);
+response.setStatusCode(SC_BAD_REQUEST);
+return;
+}
+
+response.setStatusCode(SC_CREATED);
+}
+});
+}
+};
+
+@Test
+public void testImportContent() throws Exception {
+SlingClient c = new SlingClient(httpServer.getURI(), "user", "pass");
+SlingHttpResponse res = c.importContent(IMPORT_PATH, "json", 
"{\"something\":{\"prop1\":\"val1\"}}");
+}
+
+@Test
+public void testImportJson() throws Exception {
+ObjectNode node = JsonNodeFactory.instance.objectNode();
+ObjectNode props = JsonNodeFactory.instance.objectNode();
+props.put("prop1", "val1");
+
+node.put("something", props);
+SlingClient c = new SlingClient(httpServer.getURI(), "user", "pass");
+SlingHttpResponse res = c.importJson(IMPORT_PATH, node);
+}
+
+@Test
+@Ignore
+public void testImportRemote() throws ClientException {
+SlingClient c = new SlingClient(URI.create("http://localhost:8080;), 
"admin", "admin");
+c.importContent("/content/", "json", 
"{\"something\":{\"prop1\":\"val1\"}}");
+}
+
+@Test
+@Ignore
 
 Review comment:

Re: [VOTE] Release Apache Sling Commons Log 5.1.2

[Robert Munteanu]

On Thu, 2018-02-22 at 15:14 +0100, Karl Pauls wrote:
> Please vote to approve these releases:

+1

Robert

signature.asc
Description: This is a digitally signed message part

[jira] [Comment Edited] (SLING-7519) Add webconsole ds module to SlingOptions

[Christian Schneider (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378921#comment-16378921
 ] 

Christian Schneider edited comment on SLING-7519 at 2/27/18 5:20 PM:
-

I am fine with adding this to some basic test class if you think it makes more 
sense. 

I simply thought that we use DS all over the place so I added the DS plugin in 
a central place where it is always there. 

Is the problem with the webconsole() method that this is derived from the 
standard karaf feature? Then I understand why it does not make sense to add 
something here.  


was (Author: ch...@die-schneider.net):
I am fine with adding this to some basic test class if you think it makes more 
sense. 

I simply thought that we use DS all over the place so I added the DS plugin in 
a central place where it is always there. 

 

> Add webconsole ds module to SlingOptions
> 
>
> Key: SLING-7519
> URL: https://issues.apache.org/jira/browse/SLING-7519
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Sling Pax Exam Utilities 1.0.4
>Reporter: Christian Schneider
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Pax Exam Utilities 1.0.6
>
> Attachments: Toolbox.png
>
>
> Sling uses DS all over the place. We should add the ds module for the 
> webconsole to have more insight into the DS components in tests.
> I will supply a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

RE: [Maven] Updating to parent pom 33 breaks all projects

[Stefan Seifert]

>Not even this is an option, see Konrad's response. So maybe we should
>consider multiple parent poms.

yes, i think multiple parents are the cleanest solution.
the only drawback i see is that a new release of the main parent also requires 
a new release of the osgi-parent - but this can be combined in one vote.

additional bonus of two parents: it would be possible to support different 
major versions or artifacts of osgi-parents, e.g. one for OSGi R6 and one for 
OSGi R7.

stefan

Re: [Maven] Updating to parent pom 33 breaks all projects

[Robert Munteanu]

On Tue, 2018-02-27 at 17:38 +0100, Oliver Lietz wrote:
> On Tuesday 27 February 2018 18:28:05 Robert Munteanu wrote:
> > On Tue, 2018-02-27 at 17:09 +0100, Oliver Lietz wrote:
> > > > Well, let's try and avoid that :-)
> > > > 
> > > > Could we either:
> > > > 
> > > > 1) Create a profile in the parent pom, activated for bundle
> > > > projects,
> > > > which adds the OSGi dependencies?
> > > > 
> > > > 2) Create a 'non-OSGi' parent POM (A) and an 'OSGi' parent POM
> > > > (B),
> > > > where A is the parent of B. This way we could use the parent
> > > > POM in
> > > > different projects without getting any clashes.
> > > 
> > > We could use the bundle profile but that "requires" switching to
> > > bnd
> > > Maven
> > > Plugin (or at least placing a file bnd.bnd in the module).
> > 
> > Well, I assume that using the bnd.bnd file is another manual
> > transition
> > that we must do, right? If that is the case we should discuss it on
> > the
> > dev list before committing to another migration.
> 
> Putting bnd instructions into a file is the preferred way (instead of
> POM, see 
> discussion in SLING-7417). Once Maven JAR Plugin is fixed those
> profile from 
> parent can be removed. You don't have to switch to bnd Maven Plugin,
> Maven 
> Bundle Plugin is still supported.

Right, but AFAICT a marker file is the only way to detect a bundle, and
 I'd like to not tie up the migration to the bnd-maven-plugin and the
migration to a newer parent pom.

> 
> > Maybe we can have a compromise and require a property in the pom,
> > e.g.
> > 
> >   
> > true
> >   
> > 
> > That property will activate the OSGi-related profile from the
> > parent
> > pom.
> > 
> > Not ideal but still better than copy/pasting considerably more
> > dependency versions.
> 
> Ugly... no other way to activate profile?

Not even this is an option, see Konrad's response. So maybe we should
consider multiple parent poms.

Robert

Re: Making github.com/apache/sling a git repo, moving away old svn mirror (Re: apache/sling as github landing repository)

[Robert Munteanu]

On Thu, 2018-02-15 at 20:57 +, Alexander Klimetschek wrote:
> On 12.02.2018, at 01:23, Robert Munteanu  wrote:
> > The basic proposal as I see it would be to add a new 'sling' top-
> > level
> > github repo, which means that:
> > 
> > 1. we control what goes in there - README.md most importantly
> > 2. old links to sling commits and files will be broken .
> 
> No! It's absolutely not necessary to break the old links.
> 
> If apache/sling is based on the "old" repo, and you are only adding
> new stuff on the "master" branch (which is new, as it was never used
> in the subversion based Sling), you don't have any conflicts.
> 
> You can have your cake and eat it too in this case - that's what I am
> trying to say all the time :D It's just a matter of working with
> infra to copy things around and replace the github repo accordingly.

IIUC the proposal was to import the old svn mirror as a git repo, and
Betrand argued this would be a really large repo, and that's an
impediment for something which would be heavily cloned.

Robert

[jira] [Commented] (SLING-7519) Add webconsole ds module to SlingOptions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378310#comment-16378310
 ] 

ASF GitHub Bot commented on SLING-7519:
---

cschneider opened a new pull request #1: SLING-7519 Add webconsole ds module to 
get better insight into DS 
URL: https://github.com/apache/sling-org-apache-sling-testing-paxexam/pull/1
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add webconsole ds module to SlingOptions
> 
>
> Key: SLING-7519
> URL: https://issues.apache.org/jira/browse/SLING-7519
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Sling Pax Exam Utilities 1.0.4
>Reporter: Christian Schneider
>Priority: Major
> Fix For: Sling Pax Exam Utilities 1.0.6
>
>
> Sling uses DS all over the place. We should add the ds module for the 
> webconsole to have more insight into the DS components in tests.
> I will supply a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7519) Add webconsole ds module to SlingOptions

[Christian Schneider (JIRA)]

Christian Schneider created SLING-7519:
--

 Summary: Add webconsole ds module to SlingOptions
 Key: SLING-7519
 URL: https://issues.apache.org/jira/browse/SLING-7519
 Project: Sling
  Issue Type: Improvement
Affects Versions: Sling Pax Exam Utilities 1.0.4
Reporter: Christian Schneider
 Fix For: Sling Pax Exam Utilities 1.0.6


Sling uses DS all over the place. We should add the ds module for the 
webconsole to have more insight into the DS components in tests.

I will supply a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7486) Remove tags of canceled releases from Subversion and Git repositories

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378354#comment-16378354
 ] 

Oliver Lietz commented on SLING-7486:
-

I would name [~bdelacretaz], [~rombert] and [~olli] in INFRA-16104. Ok?

> Remove tags of canceled releases from Subversion and Git repositories
> -
>
> Key: SLING-7486
> URL: https://issues.apache.org/jira/browse/SLING-7486
> Project: Sling
>  Issue Type: Task
>  Components: Best practices, General
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> ||Subversion Tag||POM Group ID||POM Artifact ID||POM Version||TODO||
> |org.apache.sling.bgservlets-1.0.0|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT|
>  remove |
> |org.apache.sling.bgservlets-1.0.2|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT|
>  remove |
> |org.apache.sling.commons.johnzon-1.0.2|org.apache.sling|org.apache.sling.commons.johnzon|1.0.2|
>  remove |
> |org.apache.sling.commons.metrics-0.0.2|org.apache.sling|org.apache.sling.commons.metrics|0.0.2|
>  remove |
> |org.apache.sling.crankstart.api.fragment-1.0.0|org.apache.sling|org.apache.sling.crankstart.api.fragment|1.0.0|
>  remove |
> |org.apache.sling.discovery.base-2.0.2|org.apache.sling|org.apache.sling.discovery.base|2.0.2|
>  remove |
> |org.apache.sling.discovery.commons-1.0.14|org.apache.sling|org.apache.sling.discovery.commons|1.0.14|
>  remove |
> |org.apache.sling.discovery.commons-1.0.22|org.apache.sling|org.apache.sling.discovery.commons|1.0.22|
>  remove |
> |org.apache.sling.discovery.oak-1.2.12|org.apache.sling|org.apache.sling.discovery.oak|1.2.12|
>  remove |
> |org.apache.sling.event-3.3.8|org.apache.sling|org.apache.sling.event|3.3.8| 
> remove |
> |org.apache.sling.fsresource-1.2.0|org.apache.sling|org.apache.sling.fsresource|1.2.0|
>  remove |
> |org.apache.sling.hc.core-1.0.0|org.apache.sling|sling-builder|7-SNAPSHOT| 
> remove |
> |org.apache.sling.hc.core-1.0.2|org.apache.sling|sling-builder|7-SNAPSHOT| 
> remove |
> |org.apache.sling.i18n-2.3.0|org.apache.sling|org.apache.sling.i18n|2.3.0| 
> remove |
> |org.apache.sling.i18n-2.4.0|org.apache.sling|org.apache.sling.i18n|2.4.0| 
> remove |
> |org.apache.sling.installer.factory.configuration-1.0.6|org.apache.sling|org.apache.sling.installer.factory.configuration|1.0.6|
>  remove |
> |org.apache.sling.jcr.base-2.0.8|org.apache.sling|org.apache.sling.jcr.base|2.0.8|
>  remove |
> |org.apache.sling.jcr.oak.server-1.1.2|org.apache.sling|org.apache.sling.jcr.oak.server|1.1.2|
>  remove |
> |org.apache.sling.jcr.resource-2.4.0|org.apache.sling|org.apache.sling.jcr.resource|2.4.0|
>  remove |
> |org.apache.sling.junit.healthcheck-1.0.4|org.apache.sling|org.apache.sling.junit.remote|1.0.9-SNAPSHOT|
>  remove |
> |org.apache.sling.launchpad.test-services-2.0.4-incubator|org.apache.sling|org.apache.sling.launchpad.test-services|2.0.4-incubator|
>  remove |
> |org.apache.sling.launchpad.testing-6|org.apache.sling|org.apache.sling.launchpad.testing|6|
>  remove |
> |org.apache.sling.launchpad.testing-war-6|org.apache.sling|org.apache.sling.launchpad.testing-war|6|
>  remove |
> |org.apache.sling.performance.base-0.0.2|org.apache.sling|org.apache.sling.performance.base|0.0.2|
>  remove |
> |org.apache.sling.resourcemerger-1.2.2|org.apache.sling|org.apache.sling.resourcemerger|1.2.2|
>  remove |
> |org.apache.sling.resourceresolver-1.4.6|org.apache.sling|org.apache.sling.resourceresolver|1.4.6|
>  remove |
> |org.apache.sling.scripting.core-2.0.12|org.apache.sling|org.apache.sling.scripting.core|2.0.12|
>  remove |
> |org.apache.sling.scripting.java-2.0.8|org.apache.sling|org.apache.sling.scripting.java|2.0.8|
>  remove |
> |org.apache.sling.scripting.jsp-2.1.2|org.apache.sling|org.apache.sling.scripting.jsp|2.1.2|
>  remove |
> |org.apache.sling.scripting.jsp.taglib-2.1.4|org.apache.sling|org.apache.sling.scripting.jsp.taglib|2.1.4|
>  remove |
> |org.apache.sling.scripting.velocity-2.0.0|org.apache.sling|org.apache.sling.scripting.velocity|2.0.0|
>  remove |
> |org.apache.sling.testing.tools-1.0.4|org.apache.sling|org.apache.sling.testing.tools|1.0.4|
>  remove |
> |org.apache.sling.validation.reactor-1.0.0|org.apache.sling|org.apache.sling.validation.reactor|1.0.0-SNAPSHOT|
>  remove |
> |sling-6-source-release|org.apache.sling|sling-builder|6-SNAPSHOT| remove |
> |sling-archetype-parent-2|org.apache.sling|sling-archetype-parent|2-SNAPSHOT| 
> remove |
> |sling-archetype-parent-3|org.apache.sling|sling-archetype-parent|3| remove |
> |sling-ide-tooling-1.0.10|org.apache.sling.ide|reactor|1.0.10| keep |
> |sling-ide-tooling-1.0.2|org.apache.sling.ide|reactor|1.0.2| keep |
> |sling-ide-tooling-1.0.4|org.apache.sling.ide|reactor|1.0.4| keep |
> 

[jira] [Commented] (SLING-7508) StackOverflowError adapting ServletResource to Sling Model with impl picker

[Dirk Rudolph (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378230#comment-16378230
 ] 

Dirk Rudolph commented on SLING-7508:
-

I thought so. Thank you very much, I like the IT you wrote. 

> StackOverflowError adapting ServletResource to Sling Model with impl picker
> ---
>
> Key: SLING-7508
> URL: https://issues.apache.org/jira/browse/SLING-7508
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Sling Models Impl 1.4.2
>Reporter: Dirk Rudolph
>Assignee: Justin Edelson
>Priority: Major
> Fix For: Sling Models Impl 1.4.8
>
>
> Adapting a {{SlingHttpServletRequest}} to a servlet that is registered using 
> sling.servlet.paths to a {{@Model}} fails in the following StackOverflowError:
> {code}
> java.lang.StackOverflowError: null
> ...
> at 
> org.apache.sling.models.impl.AdapterImplementations.getModelClassForResource(AdapterImplementations.java:318)
> at 
> org.apache.sling.models.impl.AdapterImplementations.getModelClassForResource(AdapterImplementations.java:322)
> at 
> org.apache.sling.models.impl.AdapterImplementations.getModelClassForResource(AdapterImplementations.java:322)
> {code}
> See for example the following pseudo code:
> {code}
> @SlingServlet(paths = "/apps/mypath")
> class MyServlet extends SlingSafeMethodsServlet {
>  doGet(request) { request.adaptTo(Model.class); }
> }
> interface Model {
>  ...
> }
> @Model(adaptables = SlingHttpServletRequest.class, adapters = 
> {ModelImpl.class, Model.class})
> class ModelImpl implements Model {
>  ...
> }
> {code}
> See the example here: 
> https://github.com/Buuhuu/sling-org-apache-sling-models-integration-tests/commit/db174f7a8d43432e4445f4e0aa90487827f66f72



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

RE: [VOTE] Release Apache Sling IDE Tooling version 1.2.2

[Stefan Seifert]

+1 (checked signatures)

stefan

[GitHub] cschneider opened a new pull request #1: SLING-7519 Add webconsole ds module to get better insight into DS

[GitBox]

cschneider opened a new pull request #1: SLING-7519 Add webconsole ds module to 
get better insight into DS 
URL: https://github.com/apache/sling-org-apache-sling-testing-paxexam/pull/1
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Comment Edited] (SLING-7437) Support Jackrabbit 2.16 in org.apache.sling.jcr.registration

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378484#comment-16378484
 ] 

Robert Munteanu edited comment on SLING-7437 at 2/27/18 12:19 PM:
--

[~olli] - I think you meant to mention [~ch...@die-schneider.net] :-)

At any rate, if this would work with all Jackrabbit versions I'd rather extend 
the import ranges than break backwards compatibility.

_edit_: typo


was (Author: rombert):
[~olli] - I think you mean to mention [~ch...@die-schneider.net] :-)

At any rate, if this would work with all Jackrabbit versions I'd rather extend 
the import ranges than break backwards compatibility.

> Support Jackrabbit 2.16 in org.apache.sling.jcr.registration
> 
>
> Key: SLING-7437
> URL: https://issues.apache.org/jira/browse/SLING-7437
> Project: Sling
>  Issue Type: Sub-task
>  Components: JCR
>Affects Versions: JCR Registration 1.0.4
>Reporter: Christian Schneider
>Assignee: Oliver Lietz
>Priority: Major
>
> JCR Registration is not compatible to Oak 1.8. We need to migrate it.
> I will provide a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7437) Support Jackrabbit 2.16 in org.apache.sling.jcr.registration

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378484#comment-16378484
 ] 

Robert Munteanu commented on SLING-7437:


[~olli] - I think you mean to mention [~ch...@die-schneider.net] :-)

At any rate, if this would work with all Jackrabbit versions I'd rather extend 
the import ranges than break backwards compatibility.

> Support Jackrabbit 2.16 in org.apache.sling.jcr.registration
> 
>
> Key: SLING-7437
> URL: https://issues.apache.org/jira/browse/SLING-7437
> Project: Sling
>  Issue Type: Sub-task
>  Components: JCR
>Affects Versions: JCR Registration 1.0.4
>Reporter: Christian Schneider
>Assignee: Oliver Lietz
>Priority: Major
>
> JCR Registration is not compatible to Oak 1.8. We need to migrate it.
> I will provide a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Support for Oak 1.8 (SLING-7446)

[Robert Munteanu]

On Tue, 2018-02-27 at 12:11 +0100, Oliver Lietz wrote:
> is everyone fine with upgrading to Oak 1.8 and dropping support (in
> HEAD) for 
> older versions of Oak and Jackrabbit in some modules?

+1

For the sake of completeness, can you list which modules will be
changed? I assume oak-server and testing.pax-exam are amongst those.

Robert

[jira] [Commented] (SLING-7486) Remove tags of canceled releases from Subversion and Git repositories

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378494#comment-16378494
 ] 

Bertrand Delacretaz commented on SLING-7486:


Your examples are from Git repositories, do you need to be able to change 
Subversion data to fix them?

> Remove tags of canceled releases from Subversion and Git repositories
> -
>
> Key: SLING-7486
> URL: https://issues.apache.org/jira/browse/SLING-7486
> Project: Sling
>  Issue Type: Task
>  Components: Best practices, General
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> ||Subversion Tag||POM Group ID||POM Artifact ID||POM Version||TODO||
> |org.apache.sling.bgservlets-1.0.0|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT|
>  remove |
> |org.apache.sling.bgservlets-1.0.2|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT|
>  remove |
> |org.apache.sling.commons.johnzon-1.0.2|org.apache.sling|org.apache.sling.commons.johnzon|1.0.2|
>  remove |
> |org.apache.sling.commons.metrics-0.0.2|org.apache.sling|org.apache.sling.commons.metrics|0.0.2|
>  remove |
> |org.apache.sling.crankstart.api.fragment-1.0.0|org.apache.sling|org.apache.sling.crankstart.api.fragment|1.0.0|
>  remove |
> |org.apache.sling.discovery.base-2.0.2|org.apache.sling|org.apache.sling.discovery.base|2.0.2|
>  remove |
> |org.apache.sling.discovery.commons-1.0.14|org.apache.sling|org.apache.sling.discovery.commons|1.0.14|
>  remove |
> |org.apache.sling.discovery.commons-1.0.22|org.apache.sling|org.apache.sling.discovery.commons|1.0.22|
>  remove |
> |org.apache.sling.discovery.oak-1.2.12|org.apache.sling|org.apache.sling.discovery.oak|1.2.12|
>  remove |
> |org.apache.sling.event-3.3.8|org.apache.sling|org.apache.sling.event|3.3.8| 
> remove |
> |org.apache.sling.fsresource-1.2.0|org.apache.sling|org.apache.sling.fsresource|1.2.0|
>  remove |
> |org.apache.sling.hc.core-1.0.0|org.apache.sling|sling-builder|7-SNAPSHOT| 
> remove |
> |org.apache.sling.hc.core-1.0.2|org.apache.sling|sling-builder|7-SNAPSHOT| 
> remove |
> |org.apache.sling.i18n-2.3.0|org.apache.sling|org.apache.sling.i18n|2.3.0| 
> remove |
> |org.apache.sling.i18n-2.4.0|org.apache.sling|org.apache.sling.i18n|2.4.0| 
> remove |
> |org.apache.sling.installer.factory.configuration-1.0.6|org.apache.sling|org.apache.sling.installer.factory.configuration|1.0.6|
>  remove |
> |org.apache.sling.jcr.base-2.0.8|org.apache.sling|org.apache.sling.jcr.base|2.0.8|
>  remove |
> |org.apache.sling.jcr.oak.server-1.1.2|org.apache.sling|org.apache.sling.jcr.oak.server|1.1.2|
>  remove |
> |org.apache.sling.jcr.resource-2.4.0|org.apache.sling|org.apache.sling.jcr.resource|2.4.0|
>  remove |
> |org.apache.sling.junit.healthcheck-1.0.4|org.apache.sling|org.apache.sling.junit.remote|1.0.9-SNAPSHOT|
>  remove |
> |org.apache.sling.launchpad.test-services-2.0.4-incubator|org.apache.sling|org.apache.sling.launchpad.test-services|2.0.4-incubator|
>  remove |
> |org.apache.sling.launchpad.testing-6|org.apache.sling|org.apache.sling.launchpad.testing|6|
>  remove |
> |org.apache.sling.launchpad.testing-war-6|org.apache.sling|org.apache.sling.launchpad.testing-war|6|
>  remove |
> |org.apache.sling.performance.base-0.0.2|org.apache.sling|org.apache.sling.performance.base|0.0.2|
>  remove |
> |org.apache.sling.resourcemerger-1.2.2|org.apache.sling|org.apache.sling.resourcemerger|1.2.2|
>  remove |
> |org.apache.sling.resourceresolver-1.4.6|org.apache.sling|org.apache.sling.resourceresolver|1.4.6|
>  remove |
> |org.apache.sling.scripting.core-2.0.12|org.apache.sling|org.apache.sling.scripting.core|2.0.12|
>  remove |
> |org.apache.sling.scripting.java-2.0.8|org.apache.sling|org.apache.sling.scripting.java|2.0.8|
>  remove |
> |org.apache.sling.scripting.jsp-2.1.2|org.apache.sling|org.apache.sling.scripting.jsp|2.1.2|
>  remove |
> |org.apache.sling.scripting.jsp.taglib-2.1.4|org.apache.sling|org.apache.sling.scripting.jsp.taglib|2.1.4|
>  remove |
> |org.apache.sling.scripting.velocity-2.0.0|org.apache.sling|org.apache.sling.scripting.velocity|2.0.0|
>  remove |
> |org.apache.sling.testing.tools-1.0.4|org.apache.sling|org.apache.sling.testing.tools|1.0.4|
>  remove |
> |org.apache.sling.validation.reactor-1.0.0|org.apache.sling|org.apache.sling.validation.reactor|1.0.0-SNAPSHOT|
>  remove |
> |sling-6-source-release|org.apache.sling|sling-builder|6-SNAPSHOT| remove |
> |sling-archetype-parent-2|org.apache.sling|sling-archetype-parent|2-SNAPSHOT| 
> remove |
> |sling-archetype-parent-3|org.apache.sling|sling-archetype-parent|3| remove |
> |sling-ide-tooling-1.0.10|org.apache.sling.ide|reactor|1.0.10| keep |
> |sling-ide-tooling-1.0.2|org.apache.sling.ide|reactor|1.0.2| keep |
> |sling-ide-tooling-1.0.4|org.apache.sling.ide|reactor|1.0.4| 

[jira] [Commented] (SLING-7437) Support Jackrabbit 2.16 in org.apache.sling.jcr.registration

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378498#comment-16378498
 ] 

Oliver Lietz commented on SLING-7437:
-

[~rombert], no – Chetan did the last changes and release. As there is not much 
activity in this module (and I don't expect more in the near future), there is 
not much value in keeping backwards compatibility. But I'm fine with either way.

> Support Jackrabbit 2.16 in org.apache.sling.jcr.registration
> 
>
> Key: SLING-7437
> URL: https://issues.apache.org/jira/browse/SLING-7437
> Project: Sling
>  Issue Type: Sub-task
>  Components: JCR
>Affects Versions: JCR Registration 1.0.4
>Reporter: Christian Schneider
>Assignee: Oliver Lietz
>Priority: Major
>
> JCR Registration is not compatible to Oak 1.8. We need to migrate it.
> I will provide a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Support for Oak 1.8 (SLING-7446)

[Oliver Lietz]

On Tuesday 27 February 2018 14:20:03 Robert Munteanu wrote:
> On Tue, 2018-02-27 at 12:11 +0100, Oliver Lietz wrote:
> > is everyone fine with upgrading to Oak 1.8 and dropping support (in
> > HEAD) for
> > older versions of Oak and Jackrabbit in some modules?
> 
> +1
> 
> For the sake of completeness, can you list which modules will be
> changed? I assume oak-server and testing.pax-exam are amongst those.

Right. JCR Registration, Starter/Launchpad and Karaf Features/ITs at least – 
not sure about Oak Restrictions.

O.

> Robert

[jira] [Commented] (SLING-7486) Remove tags of canceled releases from Subversion and Git repositories

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378529#comment-16378529
 ] 

Oliver Lietz commented on SLING-7486:
-

I'm not sure if we are able to fix all tagging issues in our Git repositories, 
but having only valid tags in Subversion could help.

> Remove tags of canceled releases from Subversion and Git repositories
> -
>
> Key: SLING-7486
> URL: https://issues.apache.org/jira/browse/SLING-7486
> Project: Sling
>  Issue Type: Task
>  Components: Best practices, General
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> ||Subversion Tag||POM Group ID||POM Artifact ID||POM Version||TODO||
> |org.apache.sling.bgservlets-1.0.0|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT|
>  remove |
> |org.apache.sling.bgservlets-1.0.2|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT|
>  remove |
> |org.apache.sling.commons.johnzon-1.0.2|org.apache.sling|org.apache.sling.commons.johnzon|1.0.2|
>  remove |
> |org.apache.sling.commons.metrics-0.0.2|org.apache.sling|org.apache.sling.commons.metrics|0.0.2|
>  remove |
> |org.apache.sling.crankstart.api.fragment-1.0.0|org.apache.sling|org.apache.sling.crankstart.api.fragment|1.0.0|
>  remove |
> |org.apache.sling.discovery.base-2.0.2|org.apache.sling|org.apache.sling.discovery.base|2.0.2|
>  remove |
> |org.apache.sling.discovery.commons-1.0.14|org.apache.sling|org.apache.sling.discovery.commons|1.0.14|
>  remove |
> |org.apache.sling.discovery.commons-1.0.22|org.apache.sling|org.apache.sling.discovery.commons|1.0.22|
>  remove |
> |org.apache.sling.discovery.oak-1.2.12|org.apache.sling|org.apache.sling.discovery.oak|1.2.12|
>  remove |
> |org.apache.sling.event-3.3.8|org.apache.sling|org.apache.sling.event|3.3.8| 
> remove |
> |org.apache.sling.fsresource-1.2.0|org.apache.sling|org.apache.sling.fsresource|1.2.0|
>  remove |
> |org.apache.sling.hc.core-1.0.0|org.apache.sling|sling-builder|7-SNAPSHOT| 
> remove |
> |org.apache.sling.hc.core-1.0.2|org.apache.sling|sling-builder|7-SNAPSHOT| 
> remove |
> |org.apache.sling.i18n-2.3.0|org.apache.sling|org.apache.sling.i18n|2.3.0| 
> remove |
> |org.apache.sling.i18n-2.4.0|org.apache.sling|org.apache.sling.i18n|2.4.0| 
> remove |
> |org.apache.sling.installer.factory.configuration-1.0.6|org.apache.sling|org.apache.sling.installer.factory.configuration|1.0.6|
>  remove |
> |org.apache.sling.jcr.base-2.0.8|org.apache.sling|org.apache.sling.jcr.base|2.0.8|
>  remove |
> |org.apache.sling.jcr.oak.server-1.1.2|org.apache.sling|org.apache.sling.jcr.oak.server|1.1.2|
>  remove |
> |org.apache.sling.jcr.resource-2.4.0|org.apache.sling|org.apache.sling.jcr.resource|2.4.0|
>  remove |
> |org.apache.sling.junit.healthcheck-1.0.4|org.apache.sling|org.apache.sling.junit.remote|1.0.9-SNAPSHOT|
>  remove |
> |org.apache.sling.launchpad.test-services-2.0.4-incubator|org.apache.sling|org.apache.sling.launchpad.test-services|2.0.4-incubator|
>  remove |
> |org.apache.sling.launchpad.testing-6|org.apache.sling|org.apache.sling.launchpad.testing|6|
>  remove |
> |org.apache.sling.launchpad.testing-war-6|org.apache.sling|org.apache.sling.launchpad.testing-war|6|
>  remove |
> |org.apache.sling.performance.base-0.0.2|org.apache.sling|org.apache.sling.performance.base|0.0.2|
>  remove |
> |org.apache.sling.resourcemerger-1.2.2|org.apache.sling|org.apache.sling.resourcemerger|1.2.2|
>  remove |
> |org.apache.sling.resourceresolver-1.4.6|org.apache.sling|org.apache.sling.resourceresolver|1.4.6|
>  remove |
> |org.apache.sling.scripting.core-2.0.12|org.apache.sling|org.apache.sling.scripting.core|2.0.12|
>  remove |
> |org.apache.sling.scripting.java-2.0.8|org.apache.sling|org.apache.sling.scripting.java|2.0.8|
>  remove |
> |org.apache.sling.scripting.jsp-2.1.2|org.apache.sling|org.apache.sling.scripting.jsp|2.1.2|
>  remove |
> |org.apache.sling.scripting.jsp.taglib-2.1.4|org.apache.sling|org.apache.sling.scripting.jsp.taglib|2.1.4|
>  remove |
> |org.apache.sling.scripting.velocity-2.0.0|org.apache.sling|org.apache.sling.scripting.velocity|2.0.0|
>  remove |
> |org.apache.sling.testing.tools-1.0.4|org.apache.sling|org.apache.sling.testing.tools|1.0.4|
>  remove |
> |org.apache.sling.validation.reactor-1.0.0|org.apache.sling|org.apache.sling.validation.reactor|1.0.0-SNAPSHOT|
>  remove |
> |sling-6-source-release|org.apache.sling|sling-builder|6-SNAPSHOT| remove |
> |sling-archetype-parent-2|org.apache.sling|sling-archetype-parent|2-SNAPSHOT| 
> remove |
> |sling-archetype-parent-3|org.apache.sling|sling-archetype-parent|3| remove |
> |sling-ide-tooling-1.0.10|org.apache.sling.ide|reactor|1.0.10| keep |
> |sling-ide-tooling-1.0.2|org.apache.sling.ide|reactor|1.0.2| keep |
> 

[jira] [Commented] (SLING-7437) Support Jackrabbit 2.16 in org.apache.sling.jcr.registration

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378525#comment-16378525
 ] 

Robert Munteanu commented on SLING-7437:


Ah, sorry [~olli], thought the mention was due to Christian's comments above :-)

> Support Jackrabbit 2.16 in org.apache.sling.jcr.registration
> 
>
> Key: SLING-7437
> URL: https://issues.apache.org/jira/browse/SLING-7437
> Project: Sling
>  Issue Type: Sub-task
>  Components: JCR
>Affects Versions: JCR Registration 1.0.4
>Reporter: Christian Schneider
>Assignee: Oliver Lietz
>Priority: Major
>
> JCR Registration is not compatible to Oak 1.8. We need to migrate it.
> I will provide a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Fwd: [sling-ide-tooling] annotated tag sling-ide-tooling-1.2.0 updated (7c6b87f -> 58d714a)

[Oliver Lietz]

Hi (Robert),

I've seen several warnings like the one below and running "git fsck --tags" in 
sling-ide-tooling shows duplicated tags:

Checking object directories: 100% (256/256), done.
tagged commit 7c6b87ff71855258f18153df9a389c99ced773ad (sling-ide-
tooling-1.2.0) in 58d714a3ba9dc5a4df305f9307fa665604c03037
tagged commit 68fd958c0c09283b72ea2a0d693cc78083d3f67c (sling-ide-
tooling-1.2.2) in 561a6b09d6cb22d3aef31b7bba6c840dc02db08b
tagged commit 7c6b87ff71855258f18153df9a389c99ced773ad (sling-ide-
tooling-1.2.0) in 58d714a3ba9dc5a4df305f9307fa665604c03037
tagged commit 68fd958c0c09283b72ea2a0d693cc78083d3f67c (sling-ide-
tooling-1.2.2) in 561a6b09d6cb22d3aef31b7bba6c840dc02db08b
tagged commit 2ed70934dc9e8903219082b567bcd1093b5e7315 (sling-ide-
tooling-1.0.0) in c2e176e6fd905147bed26a32b3e4c015a43636a7
tagged commit 9e2b822a5a7ef2c30ab58230a9859267fd1588e4 (sling-ide-
tooling-1.0.10) in ce7e8a6073dcb182c4ea2d442f570ff5e40e2051
tagged commit 855dcc4dfa9123054b245f08254c27f976bdcf53 (sling-ide-
tooling-1.0.2) in ea7fbe2daeca66d99a138ac6691ac0306dcef280
tagged commit f51ce7047506641cc53220ce262f2d195df542cb (sling-ide-
tooling-1.0.4) in c40a4d69b4ad89ccf62b2e13697a343c77b228d1
tagged commit 53f092e78698572094a7fe5be26586d540b40386 (sling-ide-
tooling-1.0.6) in ba80b42819be44b98969b1c53f8f900e37794cfc
tagged commit 1a5cb7186c93213dc43967450e5134be44781a2d (sling-ide-
tooling-1.0.8) in a4bc1180eb5cde337fd9d64ee25fa93c64387494
tagged commit 50c9950462c30ab4ba13ab8c51360b39196997f7 (sling-ide-
tooling-1.1.0) in b42387d5d6d84b65001da8d7ebb6737b7f4be21a
Checking objects: 100% (15228/15228), done.

What's going wrong here?

Regards,
O.

--  Forwarded Message  --

Subject: [sling-ide-tooling] annotated tag sling-ide-tooling-1.2.0 updated 
(7c6b87f -> 58d714a)
Date: Monday 26 February 2018, 20:59:12
From: romb...@apache.org
To: ' comm...@sling.apache.org , '@gitbox.apache.org

This is an automated email from the ASF dual-hosted git repository.

rombert pushed a change to annotated tag sling-ide-tooling-1.2.0
in repository https://gitbox.apache.org/repos/asf/sling-ide-tooling.git.


*** WARNING: tag sling-ide-tooling-1.2.0 was modified! ***

from 7c6b87f  (commit)
  to 58d714a  (tag)
 tagging 7c6b87ff71855258f18153df9a389c99ced773ad (commit)
  by Robert Munteanu
  on Tue Jan 16 22:55:44 2018 +0200

- Log -
Tag 1.2.0 release
---


No new revisions were added by this update.

Summary of changes:

-- 
To stop receiving notification emails like this one, please contact
romb...@apache.org.
-

[jira] [Commented] (SLING-7486) Remove tags of canceled releases from Subversion and Git repositories

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378387#comment-16378387
 ] 

Bertrand Delacretaz commented on SLING-7486:


I do not support removing tags from the locked-down subversion Sling 
repository, I don't think it's really useful and as Greg says in INFRA-16104 it 
creates work for our infra team.

I suggest just cleaning up Git.

> Remove tags of canceled releases from Subversion and Git repositories
> -
>
> Key: SLING-7486
> URL: https://issues.apache.org/jira/browse/SLING-7486
> Project: Sling
>  Issue Type: Task
>  Components: Best practices, General
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> ||Subversion Tag||POM Group ID||POM Artifact ID||POM Version||TODO||
> |org.apache.sling.bgservlets-1.0.0|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT|
>  remove |
> |org.apache.sling.bgservlets-1.0.2|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT|
>  remove |
> |org.apache.sling.commons.johnzon-1.0.2|org.apache.sling|org.apache.sling.commons.johnzon|1.0.2|
>  remove |
> |org.apache.sling.commons.metrics-0.0.2|org.apache.sling|org.apache.sling.commons.metrics|0.0.2|
>  remove |
> |org.apache.sling.crankstart.api.fragment-1.0.0|org.apache.sling|org.apache.sling.crankstart.api.fragment|1.0.0|
>  remove |
> |org.apache.sling.discovery.base-2.0.2|org.apache.sling|org.apache.sling.discovery.base|2.0.2|
>  remove |
> |org.apache.sling.discovery.commons-1.0.14|org.apache.sling|org.apache.sling.discovery.commons|1.0.14|
>  remove |
> |org.apache.sling.discovery.commons-1.0.22|org.apache.sling|org.apache.sling.discovery.commons|1.0.22|
>  remove |
> |org.apache.sling.discovery.oak-1.2.12|org.apache.sling|org.apache.sling.discovery.oak|1.2.12|
>  remove |
> |org.apache.sling.event-3.3.8|org.apache.sling|org.apache.sling.event|3.3.8| 
> remove |
> |org.apache.sling.fsresource-1.2.0|org.apache.sling|org.apache.sling.fsresource|1.2.0|
>  remove |
> |org.apache.sling.hc.core-1.0.0|org.apache.sling|sling-builder|7-SNAPSHOT| 
> remove |
> |org.apache.sling.hc.core-1.0.2|org.apache.sling|sling-builder|7-SNAPSHOT| 
> remove |
> |org.apache.sling.i18n-2.3.0|org.apache.sling|org.apache.sling.i18n|2.3.0| 
> remove |
> |org.apache.sling.i18n-2.4.0|org.apache.sling|org.apache.sling.i18n|2.4.0| 
> remove |
> |org.apache.sling.installer.factory.configuration-1.0.6|org.apache.sling|org.apache.sling.installer.factory.configuration|1.0.6|
>  remove |
> |org.apache.sling.jcr.base-2.0.8|org.apache.sling|org.apache.sling.jcr.base|2.0.8|
>  remove |
> |org.apache.sling.jcr.oak.server-1.1.2|org.apache.sling|org.apache.sling.jcr.oak.server|1.1.2|
>  remove |
> |org.apache.sling.jcr.resource-2.4.0|org.apache.sling|org.apache.sling.jcr.resource|2.4.0|
>  remove |
> |org.apache.sling.junit.healthcheck-1.0.4|org.apache.sling|org.apache.sling.junit.remote|1.0.9-SNAPSHOT|
>  remove |
> |org.apache.sling.launchpad.test-services-2.0.4-incubator|org.apache.sling|org.apache.sling.launchpad.test-services|2.0.4-incubator|
>  remove |
> |org.apache.sling.launchpad.testing-6|org.apache.sling|org.apache.sling.launchpad.testing|6|
>  remove |
> |org.apache.sling.launchpad.testing-war-6|org.apache.sling|org.apache.sling.launchpad.testing-war|6|
>  remove |
> |org.apache.sling.performance.base-0.0.2|org.apache.sling|org.apache.sling.performance.base|0.0.2|
>  remove |
> |org.apache.sling.resourcemerger-1.2.2|org.apache.sling|org.apache.sling.resourcemerger|1.2.2|
>  remove |
> |org.apache.sling.resourceresolver-1.4.6|org.apache.sling|org.apache.sling.resourceresolver|1.4.6|
>  remove |
> |org.apache.sling.scripting.core-2.0.12|org.apache.sling|org.apache.sling.scripting.core|2.0.12|
>  remove |
> |org.apache.sling.scripting.java-2.0.8|org.apache.sling|org.apache.sling.scripting.java|2.0.8|
>  remove |
> |org.apache.sling.scripting.jsp-2.1.2|org.apache.sling|org.apache.sling.scripting.jsp|2.1.2|
>  remove |
> |org.apache.sling.scripting.jsp.taglib-2.1.4|org.apache.sling|org.apache.sling.scripting.jsp.taglib|2.1.4|
>  remove |
> |org.apache.sling.scripting.velocity-2.0.0|org.apache.sling|org.apache.sling.scripting.velocity|2.0.0|
>  remove |
> |org.apache.sling.testing.tools-1.0.4|org.apache.sling|org.apache.sling.testing.tools|1.0.4|
>  remove |
> |org.apache.sling.validation.reactor-1.0.0|org.apache.sling|org.apache.sling.validation.reactor|1.0.0-SNAPSHOT|
>  remove |
> |sling-6-source-release|org.apache.sling|sling-builder|6-SNAPSHOT| remove |
> |sling-archetype-parent-2|org.apache.sling|sling-archetype-parent|2-SNAPSHOT| 
> remove |
> |sling-archetype-parent-3|org.apache.sling|sling-archetype-parent|3| remove |
> |sling-ide-tooling-1.0.10|org.apache.sling.ide|reactor|1.0.10| keep |
> 

[jira] [Commented] (SLING-7486) Remove tags of canceled releases from Subversion and Git repositories

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378401#comment-16378401
 ] 

Oliver Lietz commented on SLING-7486:
-

[~bdelacretaz], e.g. all tags for Parent are missing: 
https://github.com/apache/sling-parent

> Remove tags of canceled releases from Subversion and Git repositories
> -
>
> Key: SLING-7486
> URL: https://issues.apache.org/jira/browse/SLING-7486
> Project: Sling
>  Issue Type: Task
>  Components: Best practices, General
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> ||Subversion Tag||POM Group ID||POM Artifact ID||POM Version||TODO||
> |org.apache.sling.bgservlets-1.0.0|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT|
>  remove |
> |org.apache.sling.bgservlets-1.0.2|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT|
>  remove |
> |org.apache.sling.commons.johnzon-1.0.2|org.apache.sling|org.apache.sling.commons.johnzon|1.0.2|
>  remove |
> |org.apache.sling.commons.metrics-0.0.2|org.apache.sling|org.apache.sling.commons.metrics|0.0.2|
>  remove |
> |org.apache.sling.crankstart.api.fragment-1.0.0|org.apache.sling|org.apache.sling.crankstart.api.fragment|1.0.0|
>  remove |
> |org.apache.sling.discovery.base-2.0.2|org.apache.sling|org.apache.sling.discovery.base|2.0.2|
>  remove |
> |org.apache.sling.discovery.commons-1.0.14|org.apache.sling|org.apache.sling.discovery.commons|1.0.14|
>  remove |
> |org.apache.sling.discovery.commons-1.0.22|org.apache.sling|org.apache.sling.discovery.commons|1.0.22|
>  remove |
> |org.apache.sling.discovery.oak-1.2.12|org.apache.sling|org.apache.sling.discovery.oak|1.2.12|
>  remove |
> |org.apache.sling.event-3.3.8|org.apache.sling|org.apache.sling.event|3.3.8| 
> remove |
> |org.apache.sling.fsresource-1.2.0|org.apache.sling|org.apache.sling.fsresource|1.2.0|
>  remove |
> |org.apache.sling.hc.core-1.0.0|org.apache.sling|sling-builder|7-SNAPSHOT| 
> remove |
> |org.apache.sling.hc.core-1.0.2|org.apache.sling|sling-builder|7-SNAPSHOT| 
> remove |
> |org.apache.sling.i18n-2.3.0|org.apache.sling|org.apache.sling.i18n|2.3.0| 
> remove |
> |org.apache.sling.i18n-2.4.0|org.apache.sling|org.apache.sling.i18n|2.4.0| 
> remove |
> |org.apache.sling.installer.factory.configuration-1.0.6|org.apache.sling|org.apache.sling.installer.factory.configuration|1.0.6|
>  remove |
> |org.apache.sling.jcr.base-2.0.8|org.apache.sling|org.apache.sling.jcr.base|2.0.8|
>  remove |
> |org.apache.sling.jcr.oak.server-1.1.2|org.apache.sling|org.apache.sling.jcr.oak.server|1.1.2|
>  remove |
> |org.apache.sling.jcr.resource-2.4.0|org.apache.sling|org.apache.sling.jcr.resource|2.4.0|
>  remove |
> |org.apache.sling.junit.healthcheck-1.0.4|org.apache.sling|org.apache.sling.junit.remote|1.0.9-SNAPSHOT|
>  remove |
> |org.apache.sling.launchpad.test-services-2.0.4-incubator|org.apache.sling|org.apache.sling.launchpad.test-services|2.0.4-incubator|
>  remove |
> |org.apache.sling.launchpad.testing-6|org.apache.sling|org.apache.sling.launchpad.testing|6|
>  remove |
> |org.apache.sling.launchpad.testing-war-6|org.apache.sling|org.apache.sling.launchpad.testing-war|6|
>  remove |
> |org.apache.sling.performance.base-0.0.2|org.apache.sling|org.apache.sling.performance.base|0.0.2|
>  remove |
> |org.apache.sling.resourcemerger-1.2.2|org.apache.sling|org.apache.sling.resourcemerger|1.2.2|
>  remove |
> |org.apache.sling.resourceresolver-1.4.6|org.apache.sling|org.apache.sling.resourceresolver|1.4.6|
>  remove |
> |org.apache.sling.scripting.core-2.0.12|org.apache.sling|org.apache.sling.scripting.core|2.0.12|
>  remove |
> |org.apache.sling.scripting.java-2.0.8|org.apache.sling|org.apache.sling.scripting.java|2.0.8|
>  remove |
> |org.apache.sling.scripting.jsp-2.1.2|org.apache.sling|org.apache.sling.scripting.jsp|2.1.2|
>  remove |
> |org.apache.sling.scripting.jsp.taglib-2.1.4|org.apache.sling|org.apache.sling.scripting.jsp.taglib|2.1.4|
>  remove |
> |org.apache.sling.scripting.velocity-2.0.0|org.apache.sling|org.apache.sling.scripting.velocity|2.0.0|
>  remove |
> |org.apache.sling.testing.tools-1.0.4|org.apache.sling|org.apache.sling.testing.tools|1.0.4|
>  remove |
> |org.apache.sling.validation.reactor-1.0.0|org.apache.sling|org.apache.sling.validation.reactor|1.0.0-SNAPSHOT|
>  remove |
> |sling-6-source-release|org.apache.sling|sling-builder|6-SNAPSHOT| remove |
> |sling-archetype-parent-2|org.apache.sling|sling-archetype-parent|2-SNAPSHOT| 
> remove |
> |sling-archetype-parent-3|org.apache.sling|sling-archetype-parent|3| remove |
> |sling-ide-tooling-1.0.10|org.apache.sling.ide|reactor|1.0.10| keep |
> |sling-ide-tooling-1.0.2|org.apache.sling.ide|reactor|1.0.2| keep |
> |sling-ide-tooling-1.0.4|org.apache.sling.ide|reactor|1.0.4| keep |
> 

Support for Oak 1.8 (SLING-7446)

[Oliver Lietz]

hi,

is everyone fine with upgrading to Oak 1.8 and dropping support (in HEAD) for 
older versions of Oak and Jackrabbit in some modules?

https://issues.apache.org/jira/browse/SLING-7446

Thanks,
O.

Re: Support for Oak 1.8 (SLING-7446)

[Ioan Eugen Stan]

+1, but I'm a new user and don't have older sling code to maintain :D.


On 27.02.2018 13:11, Oliver Lietz wrote:
> hi,
>
> is everyone fine with upgrading to Oak 1.8 and dropping support (in HEAD) for 
> older versions of Oak and Jackrabbit in some modules?
>
> https://issues.apache.org/jira/browse/SLING-7446
>
> Thanks,
> O.
>




signature.asc
Description: OpenPGP digital signature

[jira] [Commented] (SLING-7486) Remove tags of canceled releases from Subversion and Git repositories

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378404#comment-16378404
 ] 

Oliver Lietz commented on SLING-7486:
-

The Sightly engine repo contains tags from other Sightly repos: 
https://github.com/apache/sling-org-apache-sling-scripting-sightly

> Remove tags of canceled releases from Subversion and Git repositories
> -
>
> Key: SLING-7486
> URL: https://issues.apache.org/jira/browse/SLING-7486
> Project: Sling
>  Issue Type: Task
>  Components: Best practices, General
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> ||Subversion Tag||POM Group ID||POM Artifact ID||POM Version||TODO||
> |org.apache.sling.bgservlets-1.0.0|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT|
>  remove |
> |org.apache.sling.bgservlets-1.0.2|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT|
>  remove |
> |org.apache.sling.commons.johnzon-1.0.2|org.apache.sling|org.apache.sling.commons.johnzon|1.0.2|
>  remove |
> |org.apache.sling.commons.metrics-0.0.2|org.apache.sling|org.apache.sling.commons.metrics|0.0.2|
>  remove |
> |org.apache.sling.crankstart.api.fragment-1.0.0|org.apache.sling|org.apache.sling.crankstart.api.fragment|1.0.0|
>  remove |
> |org.apache.sling.discovery.base-2.0.2|org.apache.sling|org.apache.sling.discovery.base|2.0.2|
>  remove |
> |org.apache.sling.discovery.commons-1.0.14|org.apache.sling|org.apache.sling.discovery.commons|1.0.14|
>  remove |
> |org.apache.sling.discovery.commons-1.0.22|org.apache.sling|org.apache.sling.discovery.commons|1.0.22|
>  remove |
> |org.apache.sling.discovery.oak-1.2.12|org.apache.sling|org.apache.sling.discovery.oak|1.2.12|
>  remove |
> |org.apache.sling.event-3.3.8|org.apache.sling|org.apache.sling.event|3.3.8| 
> remove |
> |org.apache.sling.fsresource-1.2.0|org.apache.sling|org.apache.sling.fsresource|1.2.0|
>  remove |
> |org.apache.sling.hc.core-1.0.0|org.apache.sling|sling-builder|7-SNAPSHOT| 
> remove |
> |org.apache.sling.hc.core-1.0.2|org.apache.sling|sling-builder|7-SNAPSHOT| 
> remove |
> |org.apache.sling.i18n-2.3.0|org.apache.sling|org.apache.sling.i18n|2.3.0| 
> remove |
> |org.apache.sling.i18n-2.4.0|org.apache.sling|org.apache.sling.i18n|2.4.0| 
> remove |
> |org.apache.sling.installer.factory.configuration-1.0.6|org.apache.sling|org.apache.sling.installer.factory.configuration|1.0.6|
>  remove |
> |org.apache.sling.jcr.base-2.0.8|org.apache.sling|org.apache.sling.jcr.base|2.0.8|
>  remove |
> |org.apache.sling.jcr.oak.server-1.1.2|org.apache.sling|org.apache.sling.jcr.oak.server|1.1.2|
>  remove |
> |org.apache.sling.jcr.resource-2.4.0|org.apache.sling|org.apache.sling.jcr.resource|2.4.0|
>  remove |
> |org.apache.sling.junit.healthcheck-1.0.4|org.apache.sling|org.apache.sling.junit.remote|1.0.9-SNAPSHOT|
>  remove |
> |org.apache.sling.launchpad.test-services-2.0.4-incubator|org.apache.sling|org.apache.sling.launchpad.test-services|2.0.4-incubator|
>  remove |
> |org.apache.sling.launchpad.testing-6|org.apache.sling|org.apache.sling.launchpad.testing|6|
>  remove |
> |org.apache.sling.launchpad.testing-war-6|org.apache.sling|org.apache.sling.launchpad.testing-war|6|
>  remove |
> |org.apache.sling.performance.base-0.0.2|org.apache.sling|org.apache.sling.performance.base|0.0.2|
>  remove |
> |org.apache.sling.resourcemerger-1.2.2|org.apache.sling|org.apache.sling.resourcemerger|1.2.2|
>  remove |
> |org.apache.sling.resourceresolver-1.4.6|org.apache.sling|org.apache.sling.resourceresolver|1.4.6|
>  remove |
> |org.apache.sling.scripting.core-2.0.12|org.apache.sling|org.apache.sling.scripting.core|2.0.12|
>  remove |
> |org.apache.sling.scripting.java-2.0.8|org.apache.sling|org.apache.sling.scripting.java|2.0.8|
>  remove |
> |org.apache.sling.scripting.jsp-2.1.2|org.apache.sling|org.apache.sling.scripting.jsp|2.1.2|
>  remove |
> |org.apache.sling.scripting.jsp.taglib-2.1.4|org.apache.sling|org.apache.sling.scripting.jsp.taglib|2.1.4|
>  remove |
> |org.apache.sling.scripting.velocity-2.0.0|org.apache.sling|org.apache.sling.scripting.velocity|2.0.0|
>  remove |
> |org.apache.sling.testing.tools-1.0.4|org.apache.sling|org.apache.sling.testing.tools|1.0.4|
>  remove |
> |org.apache.sling.validation.reactor-1.0.0|org.apache.sling|org.apache.sling.validation.reactor|1.0.0-SNAPSHOT|
>  remove |
> |sling-6-source-release|org.apache.sling|sling-builder|6-SNAPSHOT| remove |
> |sling-archetype-parent-2|org.apache.sling|sling-archetype-parent|2-SNAPSHOT| 
> remove |
> |sling-archetype-parent-3|org.apache.sling|sling-archetype-parent|3| remove |
> |sling-ide-tooling-1.0.10|org.apache.sling.ide|reactor|1.0.10| keep |
> |sling-ide-tooling-1.0.2|org.apache.sling.ide|reactor|1.0.2| keep |
> 

[jira] [Commented] (SLING-7486) Remove tags of canceled releases from Subversion and Git repositories

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378399#comment-16378399
 ] 

Oliver Lietz commented on SLING-7486:
-

[~bdelacretaz], infra will give write access to 1 - 3 PMCs so we can do it 
ourselves. We have several issues with tags in Git so having a clean Subversion 
repo is preferred.

> Remove tags of canceled releases from Subversion and Git repositories
> -
>
> Key: SLING-7486
> URL: https://issues.apache.org/jira/browse/SLING-7486
> Project: Sling
>  Issue Type: Task
>  Components: Best practices, General
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> ||Subversion Tag||POM Group ID||POM Artifact ID||POM Version||TODO||
> |org.apache.sling.bgservlets-1.0.0|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT|
>  remove |
> |org.apache.sling.bgservlets-1.0.2|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT|
>  remove |
> |org.apache.sling.commons.johnzon-1.0.2|org.apache.sling|org.apache.sling.commons.johnzon|1.0.2|
>  remove |
> |org.apache.sling.commons.metrics-0.0.2|org.apache.sling|org.apache.sling.commons.metrics|0.0.2|
>  remove |
> |org.apache.sling.crankstart.api.fragment-1.0.0|org.apache.sling|org.apache.sling.crankstart.api.fragment|1.0.0|
>  remove |
> |org.apache.sling.discovery.base-2.0.2|org.apache.sling|org.apache.sling.discovery.base|2.0.2|
>  remove |
> |org.apache.sling.discovery.commons-1.0.14|org.apache.sling|org.apache.sling.discovery.commons|1.0.14|
>  remove |
> |org.apache.sling.discovery.commons-1.0.22|org.apache.sling|org.apache.sling.discovery.commons|1.0.22|
>  remove |
> |org.apache.sling.discovery.oak-1.2.12|org.apache.sling|org.apache.sling.discovery.oak|1.2.12|
>  remove |
> |org.apache.sling.event-3.3.8|org.apache.sling|org.apache.sling.event|3.3.8| 
> remove |
> |org.apache.sling.fsresource-1.2.0|org.apache.sling|org.apache.sling.fsresource|1.2.0|
>  remove |
> |org.apache.sling.hc.core-1.0.0|org.apache.sling|sling-builder|7-SNAPSHOT| 
> remove |
> |org.apache.sling.hc.core-1.0.2|org.apache.sling|sling-builder|7-SNAPSHOT| 
> remove |
> |org.apache.sling.i18n-2.3.0|org.apache.sling|org.apache.sling.i18n|2.3.0| 
> remove |
> |org.apache.sling.i18n-2.4.0|org.apache.sling|org.apache.sling.i18n|2.4.0| 
> remove |
> |org.apache.sling.installer.factory.configuration-1.0.6|org.apache.sling|org.apache.sling.installer.factory.configuration|1.0.6|
>  remove |
> |org.apache.sling.jcr.base-2.0.8|org.apache.sling|org.apache.sling.jcr.base|2.0.8|
>  remove |
> |org.apache.sling.jcr.oak.server-1.1.2|org.apache.sling|org.apache.sling.jcr.oak.server|1.1.2|
>  remove |
> |org.apache.sling.jcr.resource-2.4.0|org.apache.sling|org.apache.sling.jcr.resource|2.4.0|
>  remove |
> |org.apache.sling.junit.healthcheck-1.0.4|org.apache.sling|org.apache.sling.junit.remote|1.0.9-SNAPSHOT|
>  remove |
> |org.apache.sling.launchpad.test-services-2.0.4-incubator|org.apache.sling|org.apache.sling.launchpad.test-services|2.0.4-incubator|
>  remove |
> |org.apache.sling.launchpad.testing-6|org.apache.sling|org.apache.sling.launchpad.testing|6|
>  remove |
> |org.apache.sling.launchpad.testing-war-6|org.apache.sling|org.apache.sling.launchpad.testing-war|6|
>  remove |
> |org.apache.sling.performance.base-0.0.2|org.apache.sling|org.apache.sling.performance.base|0.0.2|
>  remove |
> |org.apache.sling.resourcemerger-1.2.2|org.apache.sling|org.apache.sling.resourcemerger|1.2.2|
>  remove |
> |org.apache.sling.resourceresolver-1.4.6|org.apache.sling|org.apache.sling.resourceresolver|1.4.6|
>  remove |
> |org.apache.sling.scripting.core-2.0.12|org.apache.sling|org.apache.sling.scripting.core|2.0.12|
>  remove |
> |org.apache.sling.scripting.java-2.0.8|org.apache.sling|org.apache.sling.scripting.java|2.0.8|
>  remove |
> |org.apache.sling.scripting.jsp-2.1.2|org.apache.sling|org.apache.sling.scripting.jsp|2.1.2|
>  remove |
> |org.apache.sling.scripting.jsp.taglib-2.1.4|org.apache.sling|org.apache.sling.scripting.jsp.taglib|2.1.4|
>  remove |
> |org.apache.sling.scripting.velocity-2.0.0|org.apache.sling|org.apache.sling.scripting.velocity|2.0.0|
>  remove |
> |org.apache.sling.testing.tools-1.0.4|org.apache.sling|org.apache.sling.testing.tools|1.0.4|
>  remove |
> |org.apache.sling.validation.reactor-1.0.0|org.apache.sling|org.apache.sling.validation.reactor|1.0.0-SNAPSHOT|
>  remove |
> |sling-6-source-release|org.apache.sling|sling-builder|6-SNAPSHOT| remove |
> |sling-archetype-parent-2|org.apache.sling|sling-archetype-parent|2-SNAPSHOT| 
> remove |
> |sling-archetype-parent-3|org.apache.sling|sling-archetype-parent|3| remove |
> |sling-ide-tooling-1.0.10|org.apache.sling.ide|reactor|1.0.10| keep |
> |sling-ide-tooling-1.0.2|org.apache.sling.ide|reactor|1.0.2| keep |
> 

Re: Fwd: [sling-ide-tooling] annotated tag sling-ide-tooling-1.2.0 updated (7c6b87f -> 58d714a)

[Robert Munteanu]

Hi Olli,

On Tue, 2018-02-27 at 14:20 +0100, Oliver Lietz wrote:
> Hi (Robert),
> 
> I've seen several warnings like the one below and running "git fsck
> --tags" in 
> sling-ide-tooling shows duplicated tags:
> 
> Checking object directories: 100% (256/256), done.
> tagged commit 7c6b87ff71855258f18153df9a389c99ced773ad (sling-ide-
> tooling-1.2.0) in 58d714a3ba9dc5a4df305f9307fa665604c03037
> tagged commit 68fd958c0c09283b72ea2a0d693cc78083d3f67c (sling-ide-
> tooling-1.2.2) in 561a6b09d6cb22d3aef31b7bba6c840dc02db08b
> tagged commit 7c6b87ff71855258f18153df9a389c99ced773ad (sling-ide-
> tooling-1.2.0) in 58d714a3ba9dc5a4df305f9307fa665604c03037
> tagged commit 68fd958c0c09283b72ea2a0d693cc78083d3f67c (sling-ide-
> tooling-1.2.2) in 561a6b09d6cb22d3aef31b7bba6c840dc02db08b
> tagged commit 2ed70934dc9e8903219082b567bcd1093b5e7315 (sling-ide-
> tooling-1.0.0) in c2e176e6fd905147bed26a32b3e4c015a43636a7
> tagged commit 9e2b822a5a7ef2c30ab58230a9859267fd1588e4 (sling-ide-
> tooling-1.0.10) in ce7e8a6073dcb182c4ea2d442f570ff5e40e2051
> tagged commit 855dcc4dfa9123054b245f08254c27f976bdcf53 (sling-ide-
> tooling-1.0.2) in ea7fbe2daeca66d99a138ac6691ac0306dcef280
> tagged commit f51ce7047506641cc53220ce262f2d195df542cb (sling-ide-
> tooling-1.0.4) in c40a4d69b4ad89ccf62b2e13697a343c77b228d1
> tagged commit 53f092e78698572094a7fe5be26586d540b40386 (sling-ide-
> tooling-1.0.6) in ba80b42819be44b98969b1c53f8f900e37794cfc
> tagged commit 1a5cb7186c93213dc43967450e5134be44781a2d (sling-ide-
> tooling-1.0.8) in a4bc1180eb5cde337fd9d64ee25fa93c64387494
> tagged commit 50c9950462c30ab4ba13ab8c51360b39196997f7 (sling-ide-
> tooling-1.1.0) in b42387d5d6d84b65001da8d7ebb6737b7f4be21a
> Checking objects: 100% (15228/15228), done.
> 
> What's going wrong here?

I am not sure what is going on. I recently did a 

  git push --tags

for when staging the 1.2.2 release and it also pushed the 1.2.0 tag.

Locally the tags are consistent for me, no duplicates. I also did a
fresh clone from github and I have no issues.

$ git fsck --tags 
Checking object directories: 100% (256/256), done.
tagged commit 2ed70934dc9e8903219082b567bcd1093b5e7315 
(sling-ide-tooling-1.0.0) in c2e176e6fd905147bed26a32b3e4c015a43636a7
tagged commit 9e2b822a5a7ef2c30ab58230a9859267fd1588e4 
(sling-ide-tooling-1.0.10) in ce7e8a6073dcb182c4ea2d442f570ff5e40e2051
tagged commit 855dcc4dfa9123054b245f08254c27f976bdcf53 
(sling-ide-tooling-1.0.2) in ea7fbe2daeca66d99a138ac6691ac0306dcef280
tagged commit f51ce7047506641cc53220ce262f2d195df542cb 
(sling-ide-tooling-1.0.4) in c40a4d69b4ad89ccf62b2e13697a343c77b228d1
tagged commit 53f092e78698572094a7fe5be26586d540b40386 
(sling-ide-tooling-1.0.6) in ba80b42819be44b98969b1c53f8f900e37794cfc
tagged commit 1a5cb7186c93213dc43967450e5134be44781a2d 
(sling-ide-tooling-1.0.8) in a4bc1180eb5cde337fd9d64ee25fa93c64387494
tagged commit 50c9950462c30ab4ba13ab8c51360b39196997f7 
(sling-ide-tooling-1.1.0) in b42387d5d6d84b65001da8d7ebb6737b7f4be21a
tagged commit 7c6b87ff71855258f18153df9a389c99ced773ad 
(sling-ide-tooling-1.2.0) in 58d714a3ba9dc5a4df305f9307fa665604c03037
tagged commit 68fd958c0c09283b72ea2a0d693cc78083d3f67c 
(sling-ide-tooling-1.2.2) in 561a6b09d6cb22d3aef31b7bba6c840dc02db08b
Checking objects: 100% (14987/14987), done.

Robert

[jira] [Commented] (SLING-7486) Remove tags of canceled releases from Subversion and Git repositories

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378633#comment-16378633
 ] 

Robert Munteanu commented on SLING-7486:


The tagging problems were introduced when I migrated to Git. My tag checking 
script had a simplistic check of 'tag starts with the artifactId of the 
module'. Clearly that was wrong and now we need to clean up. However, I'm also 
wondering what we gain from touching SVN; everyone should be looking at Git now.

> Remove tags of canceled releases from Subversion and Git repositories
> -
>
> Key: SLING-7486
> URL: https://issues.apache.org/jira/browse/SLING-7486
> Project: Sling
>  Issue Type: Task
>  Components: Best practices, General
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> ||Subversion Tag||POM Group ID||POM Artifact ID||POM Version||TODO||
> |org.apache.sling.bgservlets-1.0.0|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT|
>  remove |
> |org.apache.sling.bgservlets-1.0.2|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT|
>  remove |
> |org.apache.sling.commons.johnzon-1.0.2|org.apache.sling|org.apache.sling.commons.johnzon|1.0.2|
>  remove |
> |org.apache.sling.commons.metrics-0.0.2|org.apache.sling|org.apache.sling.commons.metrics|0.0.2|
>  remove |
> |org.apache.sling.crankstart.api.fragment-1.0.0|org.apache.sling|org.apache.sling.crankstart.api.fragment|1.0.0|
>  remove |
> |org.apache.sling.discovery.base-2.0.2|org.apache.sling|org.apache.sling.discovery.base|2.0.2|
>  remove |
> |org.apache.sling.discovery.commons-1.0.14|org.apache.sling|org.apache.sling.discovery.commons|1.0.14|
>  remove |
> |org.apache.sling.discovery.commons-1.0.22|org.apache.sling|org.apache.sling.discovery.commons|1.0.22|
>  remove |
> |org.apache.sling.discovery.oak-1.2.12|org.apache.sling|org.apache.sling.discovery.oak|1.2.12|
>  remove |
> |org.apache.sling.event-3.3.8|org.apache.sling|org.apache.sling.event|3.3.8| 
> remove |
> |org.apache.sling.fsresource-1.2.0|org.apache.sling|org.apache.sling.fsresource|1.2.0|
>  remove |
> |org.apache.sling.hc.core-1.0.0|org.apache.sling|sling-builder|7-SNAPSHOT| 
> remove |
> |org.apache.sling.hc.core-1.0.2|org.apache.sling|sling-builder|7-SNAPSHOT| 
> remove |
> |org.apache.sling.i18n-2.3.0|org.apache.sling|org.apache.sling.i18n|2.3.0| 
> remove |
> |org.apache.sling.i18n-2.4.0|org.apache.sling|org.apache.sling.i18n|2.4.0| 
> remove |
> |org.apache.sling.installer.factory.configuration-1.0.6|org.apache.sling|org.apache.sling.installer.factory.configuration|1.0.6|
>  remove |
> |org.apache.sling.jcr.base-2.0.8|org.apache.sling|org.apache.sling.jcr.base|2.0.8|
>  remove |
> |org.apache.sling.jcr.oak.server-1.1.2|org.apache.sling|org.apache.sling.jcr.oak.server|1.1.2|
>  remove |
> |org.apache.sling.jcr.resource-2.4.0|org.apache.sling|org.apache.sling.jcr.resource|2.4.0|
>  remove |
> |org.apache.sling.junit.healthcheck-1.0.4|org.apache.sling|org.apache.sling.junit.remote|1.0.9-SNAPSHOT|
>  remove |
> |org.apache.sling.launchpad.test-services-2.0.4-incubator|org.apache.sling|org.apache.sling.launchpad.test-services|2.0.4-incubator|
>  remove |
> |org.apache.sling.launchpad.testing-6|org.apache.sling|org.apache.sling.launchpad.testing|6|
>  remove |
> |org.apache.sling.launchpad.testing-war-6|org.apache.sling|org.apache.sling.launchpad.testing-war|6|
>  remove |
> |org.apache.sling.performance.base-0.0.2|org.apache.sling|org.apache.sling.performance.base|0.0.2|
>  remove |
> |org.apache.sling.resourcemerger-1.2.2|org.apache.sling|org.apache.sling.resourcemerger|1.2.2|
>  remove |
> |org.apache.sling.resourceresolver-1.4.6|org.apache.sling|org.apache.sling.resourceresolver|1.4.6|
>  remove |
> |org.apache.sling.scripting.core-2.0.12|org.apache.sling|org.apache.sling.scripting.core|2.0.12|
>  remove |
> |org.apache.sling.scripting.java-2.0.8|org.apache.sling|org.apache.sling.scripting.java|2.0.8|
>  remove |
> |org.apache.sling.scripting.jsp-2.1.2|org.apache.sling|org.apache.sling.scripting.jsp|2.1.2|
>  remove |
> |org.apache.sling.scripting.jsp.taglib-2.1.4|org.apache.sling|org.apache.sling.scripting.jsp.taglib|2.1.4|
>  remove |
> |org.apache.sling.scripting.velocity-2.0.0|org.apache.sling|org.apache.sling.scripting.velocity|2.0.0|
>  remove |
> |org.apache.sling.testing.tools-1.0.4|org.apache.sling|org.apache.sling.testing.tools|1.0.4|
>  remove |
> |org.apache.sling.validation.reactor-1.0.0|org.apache.sling|org.apache.sling.validation.reactor|1.0.0-SNAPSHOT|
>  remove |
> |sling-6-source-release|org.apache.sling|sling-builder|6-SNAPSHOT| remove |
> |sling-archetype-parent-2|org.apache.sling|sling-archetype-parent|2-SNAPSHOT| 
> remove |
> |sling-archetype-parent-3|org.apache.sling|sling-archetype-parent|3| remove |
> 

[GitHub] rombert commented on issue #1: SLING-7519 Add webconsole ds module to get better insight into DS

[GitBox]

rombert commented on issue #1: SLING-7519 Add webconsole ds module to get 
better insight into DS 
URL: 
https://github.com/apache/sling-org-apache-sling-testing-paxexam/pull/1#issuecomment-368893166
 
 
   Thanks for the contribution @cschneider 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert closed pull request #1: SLING-7519 Add webconsole ds module to get better insight into DS

[GitBox]

rombert closed pull request #1: SLING-7519 Add webconsole ds module to get 
better insight into DS 
URL: https://github.com/apache/sling-org-apache-sling-testing-paxexam/pull/1
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pom.xml b/pom.xml
index 146e1ab..41bbc14 100644
--- a/pom.xml
+++ b/pom.xml
@@ -152,6 +152,11 @@
   ${org.ops4j.pax.exam.version}
   test
 
+
+  org.slf4j
+  slf4j-simple
+  test
+
   
 
 
diff --git a/src/main/java/org/apache/sling/testing/paxexam/SlingOptions.java 
b/src/main/java/org/apache/sling/testing/paxexam/SlingOptions.java
index ae5d333..8ce5810 100644
--- a/src/main/java/org/apache/sling/testing/paxexam/SlingOptions.java
+++ b/src/main/java/org/apache/sling/testing/paxexam/SlingOptions.java
@@ -81,7 +81,9 @@ public static Option scr() {
 
 public static Option webconsole() {
 return composite(
+scr(),
 
mavenBundle().groupId("org.apache.felix").artifactId("org.apache.felix.webconsole").version(versionResolver),
+
mavenBundle().groupId("org.apache.felix").artifactId("org.apache.felix.webconsole.plugins.ds").version(versionResolver),
 
mavenBundle().groupId("org.apache.felix").artifactId("org.apache.felix.inventory").version(versionResolver),
 
mavenBundle().groupId("commons-fileupload").artifactId("commons-fileupload").version(versionResolver),
 
mavenBundle().groupId("commons-io").artifactId("commons-io").version(versionResolver),


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on issue #1: SLING-7519 Add webconsole ds module to get better insight into DS

[GitBox]

rombert commented on issue #1: SLING-7519 Add webconsole ds module to get 
better insight into DS 
URL: 
https://github.com/apache/sling-org-apache-sling-testing-paxexam/pull/1#issuecomment-368893166
 
 
   Thanks for the contributyion @cschneider 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (SLING-7519) Add webconsole ds module to SlingOptions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378637#comment-16378637
 ] 

ASF GitHub Bot commented on SLING-7519:
---

rombert closed pull request #1: SLING-7519 Add webconsole ds module to get 
better insight into DS 
URL: https://github.com/apache/sling-org-apache-sling-testing-paxexam/pull/1
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pom.xml b/pom.xml
index 146e1ab..41bbc14 100644
--- a/pom.xml
+++ b/pom.xml
@@ -152,6 +152,11 @@
   ${org.ops4j.pax.exam.version}
   test
 
+
+  org.slf4j
+  slf4j-simple
+  test
+
   
 
 
diff --git a/src/main/java/org/apache/sling/testing/paxexam/SlingOptions.java 
b/src/main/java/org/apache/sling/testing/paxexam/SlingOptions.java
index ae5d333..8ce5810 100644
--- a/src/main/java/org/apache/sling/testing/paxexam/SlingOptions.java
+++ b/src/main/java/org/apache/sling/testing/paxexam/SlingOptions.java
@@ -81,7 +81,9 @@ public static Option scr() {
 
 public static Option webconsole() {
 return composite(
+scr(),
 
mavenBundle().groupId("org.apache.felix").artifactId("org.apache.felix.webconsole").version(versionResolver),
+
mavenBundle().groupId("org.apache.felix").artifactId("org.apache.felix.webconsole.plugins.ds").version(versionResolver),
 
mavenBundle().groupId("org.apache.felix").artifactId("org.apache.felix.inventory").version(versionResolver),
 
mavenBundle().groupId("commons-fileupload").artifactId("commons-fileupload").version(versionResolver),
 
mavenBundle().groupId("commons-io").artifactId("commons-io").version(versionResolver),


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add webconsole ds module to SlingOptions
> 
>
> Key: SLING-7519
> URL: https://issues.apache.org/jira/browse/SLING-7519
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Sling Pax Exam Utilities 1.0.4
>Reporter: Christian Schneider
>Priority: Major
> Fix For: Sling Pax Exam Utilities 1.0.6
>
>
> Sling uses DS all over the place. We should add the ds module for the 
> webconsole to have more insight into the DS components in tests.
> I will supply a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7509) Add QueryClient

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378671#comment-16378671
 ] 

ASF GitHub Bot commented on SLING-7509:
---

rombert commented on a change in pull request #5: SLING-7509 - Add QueryClient
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/5#discussion_r170940948
 
 

 ##
 File path: 
src/test/java/org/apache/sling/testing/clients/query/QueryClientTest.java
 ##
 @@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations 
under
+ * the License.
+ */
+package org.apache.sling.testing.clients.query;
+
+import org.apache.sling.testing.clients.ClientException;
+import org.junit.Ignore;
+import org.junit.Test;
+
+import java.net.URI;
+
+import static org.junit.Assert.*;
+
+/**
+ * Ignored since these cannot be executed without a running instance
+ */
+@Ignore
 
 Review comment:
   Either provide a testing setup for this or remove them.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add QueryClient
> ---
>
> Key: SLING-7509
> URL: https://issues.apache.org/jira/browse/SLING-7509
> Project: Sling
>  Issue Type: New Feature
>  Components: Apache Sling Testing Clients
>Reporter: Valentin Olteanu
>Priority: Major
>
> Currently, there is no way to run queries in sling using the clients. This is 
> needed in several tests to search content and assert the effects of a feature.
>  
> The solution proposed in 
> [https://github.com/apache/sling-org-apache-sling-testing-clients/pull/5] 
>  * installs a custom query servlet
>  * runs the query in any of the supported format
>  * returns results as json



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7520) Sling Query - shortened URL goes to non apache site

[Jason E Bailey (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378672#comment-16378672
 ] 

Jason E Bailey commented on SLING-7520:
---

replacing with apache shortened URL

> Sling Query - shortened URL goes to non apache site
> ---
>
> Key: SLING-7520
> URL: https://issues.apache.org/jira/browse/SLING-7520
> Project: Sling
>  Issue Type: Improvement
>Reporter: Jason E Bailey
>Priority: Trivial
>
> Warning is generated out of Sling Query which contains a shortened url that 
> links to the previous site before it was merged.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7509) Add QueryClient

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378667#comment-16378667
 ] 

ASF GitHub Bot commented on SLING-7509:
---

rombert commented on a change in pull request #5: SLING-7509 - Add QueryClient
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/5#discussion_r170940653
 
 

 ##
 File path: 
src/main/resources/org/apache/sling/testing/clients/query/testQuery.json.jsp
 ##
 @@ -0,0 +1,136 @@
+<%--
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+--%><%@ page session="false"
+%><%@ page import="
+   java.io.PrintWriter,
+   java.util.Date,
+   javax.jcr.Node,
+   javax.jcr.NodeIterator,
+   javax.jcr.RepositoryException,
+   javax.jcr.Session,
+   javax.jcr.query.Query,
+   javax.jcr.query.QueryManager,
+   javax.jcr.query.QueryResult,
+   javax.jcr.query.Row,
+   javax.jcr.query.RowIterator,
+   org.apache.jackrabbit.value.StringValue"
 
 Review comment:
   This import seems unused


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add QueryClient
> ---
>
> Key: SLING-7509
> URL: https://issues.apache.org/jira/browse/SLING-7509
> Project: Sling
>  Issue Type: New Feature
>  Components: Apache Sling Testing Clients
>Reporter: Valentin Olteanu
>Priority: Major
>
> Currently, there is no way to run queries in sling using the clients. This is 
> needed in several tests to search content and assert the effects of a feature.
>  
> The solution proposed in 
> [https://github.com/apache/sling-org-apache-sling-testing-clients/pull/5] 
>  * installs a custom query servlet
>  * runs the query in any of the supported format
>  * returns results as json



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7509) Add QueryClient

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378669#comment-16378669
 ] 

ASF GitHub Bot commented on SLING-7509:
---

rombert commented on a change in pull request #5: SLING-7509 - Add QueryClient
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/5#discussion_r170941108
 
 

 ##
 File path: 
src/main/resources/org/apache/sling/testing/clients/query/testQuery.json.jsp
 ##
 @@ -0,0 +1,136 @@
+<%--
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+--%><%@ page session="false"
+%><%@ page import="
+   java.io.PrintWriter,
+   java.util.Date,
+   javax.jcr.Node,
+   javax.jcr.NodeIterator,
+   javax.jcr.RepositoryException,
+   javax.jcr.Session,
+   javax.jcr.query.Query,
+   javax.jcr.query.QueryManager,
+   javax.jcr.query.QueryResult,
+   javax.jcr.query.Row,
+   javax.jcr.query.RowIterator,
+   org.apache.jackrabbit.value.StringValue"
+%><%@ taglib prefix="sling" uri="http://sling.apache.org/taglibs/sling/1.0;
+%><%
+
+response.setContentType("application/json");
+response.setCharacterEncoding("UTF-8");
+
+final PrintWriter pw = response.getWriter();
+
+try {
+final QueryManager qm = 
slingRequest.getResourceResolver().adaptTo(Session.class)
+.getWorkspace().getQueryManager();
+
+long before = 0;
+long after = 0;
+long total = 0;
+
+String query = slingRequest.getParameter("query");
+String type = slingRequest.getParameter("type");
+boolean showResults = 
!("false".equalsIgnoreCase(slingRequest.getParameter("showresults")));
+
+boolean tidy = false;
+for (String selector : 
slingRequest.getRequestPathInfo().getSelectors()) {
+if ("tidy".equals(selector)) {
+tidy = true;
+}
+}
+
+if ((query == null) || query.equals("") || (type == null) || 
type.equals("")) {
+  response.sendError(400, "Parameters query and type are required"); 
// invalid request
+  return;
+}
+
+// prepare
+javax.jcr.query.Query q = qm.createQuery(query, type);
+
+// execute
+before = new Date().getTime();
+QueryResult result = q.execute();
+after = new Date().getTime();
+
+// collect results
+String firstSelector = null;
+if (result.getSelectorNames().length > 1) {
+firstSelector = result.getSelectorNames()[0];
+try {
+String[] columnNames = result.getColumnNames();
+if (columnNames.length > 0) {
+String firstColumnName = columnNames[0];
+int firstDot = firstColumnName.indexOf('.');
+if (firstDot > 0) {
+firstSelector = firstColumnName.substring(0, firstDot);
+}
+}
+} catch (Exception e) {
+log.warn("Could not get selector name of the first column", e);
+}
+}
+
+// start the response json object
+pw.println("{");
 
 Review comment:
   Why don't we use a JSON library?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add QueryClient
> ---
>
> Key: SLING-7509
> URL: https://issues.apache.org/jira/browse/SLING-7509
> Project: Sling
>  Issue Type: New Feature
>  Components: Apache Sling Testing Clients
>Reporter: Valentin Olteanu
>Priority: Major
>
> Currently, there is no way to run queries in sling using the clients. This is 
> needed in several tests to search content and assert the effects of a feature.
>  
> The solution proposed in 
> 

[jira] [Created] (SLING-7520) Sling Query - shortened URL goes to non apache site

[Jason E Bailey (JIRA)]

Jason E Bailey created SLING-7520:
-

 Summary: Sling Query - shortened URL goes to non apache site
 Key: SLING-7520
 URL: https://issues.apache.org/jira/browse/SLING-7520
 Project: Sling
  Issue Type: Improvement
Reporter: Jason E Bailey


Warning is generated out of Sling Query which contains a shortened url that 
links to the previous site before it was merged.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7509) Add QueryClient

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378670#comment-16378670
 ] 

ASF GitHub Bot commented on SLING-7509:
---

rombert commented on a change in pull request #5: SLING-7509 - Add QueryClient
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/5#discussion_r170941464
 
 

 ##
 File path: 
src/main/java/org/apache/sling/testing/clients/query/QueryClient.java
 ##
 @@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations 
under
+ * the License.
+ */
+package org.apache.sling.testing.clients.query;
+
+import org.apache.http.NameValuePair;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.sling.testing.clients.ClientException;
+import org.apache.sling.testing.clients.SlingClient;
+import org.apache.sling.testing.clients.SlingClientConfig;
+import org.apache.sling.testing.clients.SlingHttpResponse;
+import org.apache.sling.testing.clients.osgi.OsgiConsoleClient;
+import org.apache.sling.testing.clients.util.JsonUtils;
+import org.apache.sling.testing.clients.util.URLParameterBuilder;
+import org.codehaus.jackson.JsonNode;
+import org.ops4j.pax.tinybundles.core.TinyBundles;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.URI;
+import java.nio.file.Files;
+import java.util.List;
+
+import static java.nio.file.StandardCopyOption.REPLACE_EXISTING;
+import static org.apache.http.HttpStatus.SC_NOT_FOUND;
+import static org.apache.http.HttpStatus.SC_OK;
+import static 
org.apache.sling.testing.clients.util.ResourceUtil.getResourceAsStream;
+
+/**
+ * Sling client for performing oak queries.
+ *
+ * Uses a custom query servlet {@code testQuery.json.jsp} to execute the 
query on the server
+ * and return the results as a json. If the servlet is not yet present, it 
automatically
+ * installs it and creates the corresponding nodes
+ *
+ * Paths created in jcr:
+ * - {@value JSP_PATH}, created by the bundle
+ * - {@value QUERY_NODE}, with {@code resourceType}={@value RESOURCE_TYPE}
+ * 
+ *
+ * The servlet is not automatically uninstalled to avoid too much noise on 
the instance.
+ * The caller should take care of it, if needed, by calling {@link 
#uninstallServlet()}
+ */
+public class QueryClient extends SlingClient {
+
+/**
+ * Query types, as defined in {@code 
org.apache.jackrabbit.oak.query.QueryEngineImpl}
+ */
+public enum QueryType {
+SQL2("JCR-SQL2"),
+SQL("sql"),
+XPATH("xpath"),
+JQOM("JCR-JQOM");
+
+private final String name;
+
+QueryType(String name) {
+this.name = name;
+}
+
+@Override
+public String toString() {
+return name;
+}
+}
+
+private static final Logger LOG = 
LoggerFactory.getLogger(QueryClient.class);
+
+private static final String BUNDLE_BSN = 
"org.apache.sling.testing.clients.query";
+private static final String BUNDLE_NAME = "Query servlet for testing";
+private static final String BUNDLE_VERSION = "1.0.0";
+private static final String BUNDLE_FILE = "testquery.bundle.";
+
+private static final String JSP_FILE = 
"/org/apache/sling/testing/clients/query/testQuery.json.jsp";
 
 Review comment:
   I think getClass().getResourceAsStream(...) would allow for a more compact 
name and less package names duplication


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add QueryClient
> ---
>
> Key: SLING-7509
> URL: https://issues.apache.org/jira/browse/SLING-7509
> Project: Sling
>  Issue Type: New Feature
>  Components: Apache Sling Testing Clients
>Reporter: Valentin Olteanu
>Priority: Major
>
> Currently, there is no way to run queries in sling using the clients. This 

[jira] [Commented] (SLING-7511) Add importContent to SlingClient

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378678#comment-16378678
 ] 

ASF GitHub Bot commented on SLING-7511:
---

rombert commented on a change in pull request #6: SLING-7511: Add importContent 
to SlingClient
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/6#discussion_r170942118
 
 

 ##
 File path: 
src/test/java/org/apache/sling/testing/clients/SlingClientImportContentTest.java
 ##
 @@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations 
under
+ * the License.
+ */
+package org.apache.sling.testing.clients;
+
+import org.apache.http.*;
+import org.apache.http.client.utils.URLEncodedUtils;
+import org.apache.http.protocol.HttpContext;
+import org.apache.http.protocol.HttpRequestHandler;
+import org.codehaus.jackson.node.JsonNodeFactory;
+import org.codehaus.jackson.node.ObjectNode;
+import org.junit.ClassRule;
+import org.junit.Ignore;
+import org.junit.Test;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.PrintWriter;
+import java.net.URI;
+import java.util.List;
+
+import static org.apache.http.HttpStatus.SC_BAD_REQUEST;
+import static org.apache.http.HttpStatus.SC_CREATED;
+import static org.apache.http.HttpStatus.SC_OK;
+
+public class SlingClientImportContentTest {
+private static final String IMPORT_PATH = "/test/import/parent";
+
+@ClassRule
+public static HttpServerRule httpServer = new HttpServerRule() {
+@Override
+protected void registerHandlers() throws IOException {
+serverBootstrap.registerHandler(IMPORT_PATH, new 
HttpRequestHandler() {
+@Override
+public void handle(HttpRequest request, HttpResponse response, 
HttpContext context) throws HttpException, IOException {
+String operation = null;
+String content = null;
+if (request instanceof HttpEntityEnclosingRequest) {
+HttpEntity entity = ((HttpEntityEnclosingRequest) 
request).getEntity();
+List params = 
URLEncodedUtils.parse(entity);
+for (NameValuePair param : params) {
+if (param.getName().equals(":operation")) {
+operation = param.getValue();
+}
+
+if (param.getName().equals(":content")) {
+content = param.getValue();
+}
+}
+}
+
+if (!"import".equals(operation)) {
+response.setStatusCode(SC_BAD_REQUEST);
+return;
+}
+
+if 
(!"{\"something\":{\"prop1\":\"val1\"}}".equals(content)) {
+System.out.println("Unexpected content: " + content);
+response.setStatusCode(SC_BAD_REQUEST);
+return;
+}
+
+response.setStatusCode(SC_CREATED);
+}
+});
+}
+};
+
+@Test
+public void testImportContent() throws Exception {
+SlingClient c = new SlingClient(httpServer.getURI(), "user", "pass");
+SlingHttpResponse res = c.importContent(IMPORT_PATH, "json", 
"{\"something\":{\"prop1\":\"val1\"}}");
+}
+
+@Test
+public void testImportJson() throws Exception {
+ObjectNode node = JsonNodeFactory.instance.objectNode();
+ObjectNode props = JsonNodeFactory.instance.objectNode();
+props.put("prop1", "val1");
+
+node.put("something", props);
+SlingClient c = new SlingClient(httpServer.getURI(), "user", "pass");
+SlingHttpResponse res = c.importJson(IMPORT_PATH, node);
+}
+
+@Test
+@Ignore
+public void testImportRemote() throws ClientException {
 
 Review comment:
   Please don't add ignored tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the

[jira] [Commented] (SLING-7511) Add importContent to SlingClient

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378679#comment-16378679
 ] 

ASF GitHub Bot commented on SLING-7511:
---

rombert commented on a change in pull request #6: SLING-7511: Add importContent 
to SlingClient
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/6#discussion_r170942232
 
 

 ##
 File path: 
src/test/java/org/apache/sling/testing/clients/SlingClientImportContentTest.java
 ##
 @@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations 
under
+ * the License.
+ */
+package org.apache.sling.testing.clients;
+
+import org.apache.http.*;
+import org.apache.http.client.utils.URLEncodedUtils;
+import org.apache.http.protocol.HttpContext;
+import org.apache.http.protocol.HttpRequestHandler;
+import org.codehaus.jackson.node.JsonNodeFactory;
+import org.codehaus.jackson.node.ObjectNode;
+import org.junit.ClassRule;
+import org.junit.Ignore;
+import org.junit.Test;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.PrintWriter;
+import java.net.URI;
+import java.util.List;
+
+import static org.apache.http.HttpStatus.SC_BAD_REQUEST;
+import static org.apache.http.HttpStatus.SC_CREATED;
+import static org.apache.http.HttpStatus.SC_OK;
+
+public class SlingClientImportContentTest {
+private static final String IMPORT_PATH = "/test/import/parent";
+
+@ClassRule
+public static HttpServerRule httpServer = new HttpServerRule() {
+@Override
+protected void registerHandlers() throws IOException {
+serverBootstrap.registerHandler(IMPORT_PATH, new 
HttpRequestHandler() {
+@Override
+public void handle(HttpRequest request, HttpResponse response, 
HttpContext context) throws HttpException, IOException {
+String operation = null;
+String content = null;
+if (request instanceof HttpEntityEnclosingRequest) {
+HttpEntity entity = ((HttpEntityEnclosingRequest) 
request).getEntity();
+List params = 
URLEncodedUtils.parse(entity);
+for (NameValuePair param : params) {
+if (param.getName().equals(":operation")) {
+operation = param.getValue();
+}
+
+if (param.getName().equals(":content")) {
+content = param.getValue();
+}
+}
+}
+
+if (!"import".equals(operation)) {
+response.setStatusCode(SC_BAD_REQUEST);
+return;
+}
+
+if 
(!"{\"something\":{\"prop1\":\"val1\"}}".equals(content)) {
+System.out.println("Unexpected content: " + content);
+response.setStatusCode(SC_BAD_REQUEST);
+return;
+}
+
+response.setStatusCode(SC_CREATED);
+}
+});
+}
+};
+
+@Test
+public void testImportContent() throws Exception {
+SlingClient c = new SlingClient(httpServer.getURI(), "user", "pass");
+SlingHttpResponse res = c.importContent(IMPORT_PATH, "json", 
"{\"something\":{\"prop1\":\"val1\"}}");
+}
+
+@Test
+public void testImportJson() throws Exception {
+ObjectNode node = JsonNodeFactory.instance.objectNode();
+ObjectNode props = JsonNodeFactory.instance.objectNode();
+props.put("prop1", "val1");
+
+node.put("something", props);
+SlingClient c = new SlingClient(httpServer.getURI(), "user", "pass");
+SlingHttpResponse res = c.importJson(IMPORT_PATH, node);
 
 Review comment:
   Should there be an assertion here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact 

[jira] [Commented] (SLING-7511) Add importContent to SlingClient

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378673#comment-16378673
 ] 

ASF GitHub Bot commented on SLING-7511:
---

rombert commented on a change in pull request #6: SLING-7511: Add importContent 
to SlingClient
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/6#discussion_r170942252
 
 

 ##
 File path: 
src/test/java/org/apache/sling/testing/clients/SlingClientImportContentTest.java
 ##
 @@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations 
under
+ * the License.
+ */
+package org.apache.sling.testing.clients;
+
+import org.apache.http.*;
+import org.apache.http.client.utils.URLEncodedUtils;
+import org.apache.http.protocol.HttpContext;
+import org.apache.http.protocol.HttpRequestHandler;
+import org.codehaus.jackson.node.JsonNodeFactory;
+import org.codehaus.jackson.node.ObjectNode;
+import org.junit.ClassRule;
+import org.junit.Ignore;
+import org.junit.Test;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.PrintWriter;
+import java.net.URI;
+import java.util.List;
+
+import static org.apache.http.HttpStatus.SC_BAD_REQUEST;
+import static org.apache.http.HttpStatus.SC_CREATED;
+import static org.apache.http.HttpStatus.SC_OK;
+
+public class SlingClientImportContentTest {
+private static final String IMPORT_PATH = "/test/import/parent";
+
+@ClassRule
+public static HttpServerRule httpServer = new HttpServerRule() {
+@Override
+protected void registerHandlers() throws IOException {
+serverBootstrap.registerHandler(IMPORT_PATH, new 
HttpRequestHandler() {
+@Override
+public void handle(HttpRequest request, HttpResponse response, 
HttpContext context) throws HttpException, IOException {
+String operation = null;
+String content = null;
+if (request instanceof HttpEntityEnclosingRequest) {
+HttpEntity entity = ((HttpEntityEnclosingRequest) 
request).getEntity();
+List params = 
URLEncodedUtils.parse(entity);
+for (NameValuePair param : params) {
+if (param.getName().equals(":operation")) {
+operation = param.getValue();
+}
+
+if (param.getName().equals(":content")) {
+content = param.getValue();
+}
+}
+}
+
+if (!"import".equals(operation)) {
+response.setStatusCode(SC_BAD_REQUEST);
+return;
+}
+
+if 
(!"{\"something\":{\"prop1\":\"val1\"}}".equals(content)) {
+System.out.println("Unexpected content: " + content);
+response.setStatusCode(SC_BAD_REQUEST);
+return;
+}
+
+response.setStatusCode(SC_CREATED);
+}
+});
+}
+};
+
+@Test
+public void testImportContent() throws Exception {
+SlingClient c = new SlingClient(httpServer.getURI(), "user", "pass");
+SlingHttpResponse res = c.importContent(IMPORT_PATH, "json", 
"{\"something\":{\"prop1\":\"val1\"}}");
 
 Review comment:
   Should there be an assertion here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add importContent to SlingClient
> 
>
> Key: SLING-7511
> URL: https://issues.apache.org/jira/browse/SLING-7511
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Reporter: Valentin Olteanu
>Priority: Major
>
> Add operations 

[jira] [Commented] (SLING-7511) Add importContent to SlingClient

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378676#comment-16378676
 ] 

ASF GitHub Bot commented on SLING-7511:
---

rombert commented on a change in pull request #6: SLING-7511: Add importContent 
to SlingClient
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/6#discussion_r170942082
 
 

 ##
 File path: 
src/test/java/org/apache/sling/testing/clients/SlingClientImportContentTest.java
 ##
 @@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations 
under
+ * the License.
+ */
+package org.apache.sling.testing.clients;
+
+import org.apache.http.*;
+import org.apache.http.client.utils.URLEncodedUtils;
+import org.apache.http.protocol.HttpContext;
+import org.apache.http.protocol.HttpRequestHandler;
+import org.codehaus.jackson.node.JsonNodeFactory;
+import org.codehaus.jackson.node.ObjectNode;
+import org.junit.ClassRule;
+import org.junit.Ignore;
+import org.junit.Test;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.PrintWriter;
+import java.net.URI;
+import java.util.List;
+
+import static org.apache.http.HttpStatus.SC_BAD_REQUEST;
+import static org.apache.http.HttpStatus.SC_CREATED;
+import static org.apache.http.HttpStatus.SC_OK;
+
+public class SlingClientImportContentTest {
+private static final String IMPORT_PATH = "/test/import/parent";
+
+@ClassRule
+public static HttpServerRule httpServer = new HttpServerRule() {
+@Override
+protected void registerHandlers() throws IOException {
+serverBootstrap.registerHandler(IMPORT_PATH, new 
HttpRequestHandler() {
+@Override
+public void handle(HttpRequest request, HttpResponse response, 
HttpContext context) throws HttpException, IOException {
+String operation = null;
+String content = null;
+if (request instanceof HttpEntityEnclosingRequest) {
+HttpEntity entity = ((HttpEntityEnclosingRequest) 
request).getEntity();
+List params = 
URLEncodedUtils.parse(entity);
+for (NameValuePair param : params) {
+if (param.getName().equals(":operation")) {
+operation = param.getValue();
+}
+
+if (param.getName().equals(":content")) {
+content = param.getValue();
+}
+}
+}
+
+if (!"import".equals(operation)) {
+response.setStatusCode(SC_BAD_REQUEST);
+return;
+}
+
+if 
(!"{\"something\":{\"prop1\":\"val1\"}}".equals(content)) {
+System.out.println("Unexpected content: " + content);
+response.setStatusCode(SC_BAD_REQUEST);
+return;
+}
+
+response.setStatusCode(SC_CREATED);
+}
+});
+}
+};
+
+@Test
+public void testImportContent() throws Exception {
+SlingClient c = new SlingClient(httpServer.getURI(), "user", "pass");
+SlingHttpResponse res = c.importContent(IMPORT_PATH, "json", 
"{\"something\":{\"prop1\":\"val1\"}}");
+}
+
+@Test
+public void testImportJson() throws Exception {
+ObjectNode node = JsonNodeFactory.instance.objectNode();
+ObjectNode props = JsonNodeFactory.instance.objectNode();
+props.put("prop1", "val1");
+
+node.put("something", props);
+SlingClient c = new SlingClient(httpServer.getURI(), "user", "pass");
+SlingHttpResponse res = c.importJson(IMPORT_PATH, node);
+}
+
+@Test
+@Ignore
+public void testImportRemote() throws ClientException {
+SlingClient c = new SlingClient(URI.create("http://localhost:8080;), 
"admin", "admin");
+c.importContent("/content/", "json", 
"{\"something\":{\"prop1\":\"val1\"}}");
+}
+
+@Test
+@Ignore
 
 Review comment:

[jira] [Commented] (SLING-7511) Add importContent to SlingClient

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378677#comment-16378677
 ] 

ASF GitHub Bot commented on SLING-7511:
---

rombert commented on a change in pull request #6: SLING-7511: Add importContent 
to SlingClient
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/6#discussion_r170941798
 
 

 ##
 File path: 
src/main/java/org/apache/sling/testing/clients/email/package-info.java
 ##
 @@ -17,7 +17,7 @@
  * under the License.
  */
 
-@Version("1.1.0")
+@Version("1.2.0")
 
 Review comment:
   Why is this version change needed?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add importContent to SlingClient
> 
>
> Key: SLING-7511
> URL: https://issues.apache.org/jira/browse/SLING-7511
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Reporter: Valentin Olteanu
>Priority: Major
>
> Add operations specific to 
> [http://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#importing-content-structures]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7511) Add importContent to SlingClient

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378675#comment-16378675
 ] 

ASF GitHub Bot commented on SLING-7511:
---

rombert commented on a change in pull request #6: SLING-7511: Add importContent 
to SlingClient
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/6#discussion_r170941886
 
 

 ##
 File path: 
src/main/java/org/apache/sling/testing/clients/html/package-info.java
 ##
 @@ -17,7 +17,7 @@
  * under the License.
  */
 
-@Version("2.2.0")
+@Version("2.3.0")
 
 Review comment:
   Why is this version change needed?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add importContent to SlingClient
> 
>
> Key: SLING-7511
> URL: https://issues.apache.org/jira/browse/SLING-7511
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Reporter: Valentin Olteanu
>Priority: Major
>
> Add operations specific to 
> [http://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#importing-content-structures]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7511) Add importContent to SlingClient

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378674#comment-16378674
 ] 

ASF GitHub Bot commented on SLING-7511:
---

rombert commented on a change in pull request #6: SLING-7511: Add importContent 
to SlingClient
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/6#discussion_r170941906
 
 

 ##
 File path: src/main/java/org/apache/sling/testing/clients/package-info.java
 ##
 @@ -17,7 +17,7 @@
  * under the License.
  */
 
-@Version("1.4.0")
+@Version("1.5.0")
 
 Review comment:
   Why is this version change needed?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add importContent to SlingClient
> 
>
> Key: SLING-7511
> URL: https://issues.apache.org/jira/browse/SLING-7511
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Reporter: Valentin Olteanu
>Priority: Major
>
> Add operations specific to 
> [http://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#importing-content-structures]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7169) FullTextIndexingTest sometimes fails with a timeout

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378681#comment-16378681
 ] 

ASF GitHub Bot commented on SLING-7169:
---

rombert commented on issue #7: SLING-7169
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/7#issuecomment-368899442
 
 
   @volteanu  - you seem to include the changes from #5 and #6 . Can you push a 
review with just the individual changes for SLING-7169? This would make it 
easier to review.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> FullTextIndexingTest sometimes fails with a timeout
> ---
>
> Key: SLING-7169
> URL: https://issues.apache.org/jira/browse/SLING-7169
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad
>Reporter: Robert Munteanu
>Priority: Major
>  Labels: sling-IT
> Attachments: SLING-7169-logs.tar.gz
>
>
> The test fails maybe 1 in 10 runs. I could reproduce this locally by running 
> many times. I've also seen it once on Jenkins.
> **Old description below**
> After upgrading the launchpad to commons.threads 3.2.10 the 
> FullTextIndexingTest failed ( [build 
> 1547|https://builds.apache.org/job/sling-launchpad-testing-1.8/1547/] ).
> I also reproduced it once locally.
> [~kwin] - since the commons.threads release is the potential root cause, can 
> you please take a look at the failure and see if it's related?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7446) Support Oak 1.8

[Christian Schneider (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378684#comment-16378684
 ] 

Christian Schneider commented on SLING-7446:


The branches feature/oak-1.8 work fine for me. What are the next steps now? Can 
I help in anything?

Btw. I just spoke to Robert and he is fine in moving the master to Oak 1.8.

> Support Oak 1.8
> ---
>
> Key: SLING-7446
> URL: https://issues.apache.org/jira/browse/SLING-7446
> Project: Sling
>  Issue Type: Task
>  Components: JCR, Karaf, Launchpad, Testing
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>  Labels: Sling-11-ReleaseNotes
>
> Oak 1.8 introduced several new modules and reorganized some public packages.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7519) Add webconsole ds module to SlingOptions

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-7519.

Resolution: Fixed
  Assignee: Robert Munteanu

PR merged, thanks Christian!

> Add webconsole ds module to SlingOptions
> 
>
> Key: SLING-7519
> URL: https://issues.apache.org/jira/browse/SLING-7519
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Sling Pax Exam Utilities 1.0.4
>Reporter: Christian Schneider
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Pax Exam Utilities 1.0.6
>
>
> Sling uses DS all over the place. We should add the ds module for the 
> webconsole to have more insight into the DS components in tests.
> I will supply a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7519) Add webconsole ds module to SlingOptions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378639#comment-16378639
 ] 

ASF GitHub Bot commented on SLING-7519:
---

rombert commented on issue #1: SLING-7519 Add webconsole ds module to get 
better insight into DS 
URL: 
https://github.com/apache/sling-org-apache-sling-testing-paxexam/pull/1#issuecomment-368893166
 
 
   Thanks for the contribution @cschneider 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add webconsole ds module to SlingOptions
> 
>
> Key: SLING-7519
> URL: https://issues.apache.org/jira/browse/SLING-7519
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Sling Pax Exam Utilities 1.0.4
>Reporter: Christian Schneider
>Priority: Major
> Fix For: Sling Pax Exam Utilities 1.0.6
>
>
> Sling uses DS all over the place. We should add the ds module for the 
> webconsole to have more insight into the DS components in tests.
> I will supply a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7519) Add webconsole ds module to SlingOptions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378638#comment-16378638
 ] 

ASF GitHub Bot commented on SLING-7519:
---

rombert commented on issue #1: SLING-7519 Add webconsole ds module to get 
better insight into DS 
URL: 
https://github.com/apache/sling-org-apache-sling-testing-paxexam/pull/1#issuecomment-368893166
 
 
   Thanks for the contributyion @cschneider 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add webconsole ds module to SlingOptions
> 
>
> Key: SLING-7519
> URL: https://issues.apache.org/jira/browse/SLING-7519
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Sling Pax Exam Utilities 1.0.4
>Reporter: Christian Schneider
>Priority: Major
> Fix For: Sling Pax Exam Utilities 1.0.6
>
>
> Sling uses DS all over the place. We should add the ds module for the 
> webconsole to have more insight into the DS components in tests.
> I will supply a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7509) Add QueryClient

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378704#comment-16378704
 ] 

ASF GitHub Bot commented on SLING-7509:
---

dulvac commented on a change in pull request #5: SLING-7509 - Add QueryClient
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/5#discussion_r170932869
 
 

 ##
 File path: 
src/main/java/org/apache/sling/testing/clients/query/QueryClient.java
 ##
 @@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations 
under
+ * the License.
+ */
+package org.apache.sling.testing.clients.query;
+
+import org.apache.http.NameValuePair;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.sling.testing.clients.ClientException;
+import org.apache.sling.testing.clients.SlingClient;
+import org.apache.sling.testing.clients.SlingClientConfig;
+import org.apache.sling.testing.clients.SlingHttpResponse;
+import org.apache.sling.testing.clients.osgi.OsgiConsoleClient;
+import org.apache.sling.testing.clients.util.JsonUtils;
+import org.apache.sling.testing.clients.util.URLParameterBuilder;
+import org.codehaus.jackson.JsonNode;
+import org.ops4j.pax.tinybundles.core.TinyBundles;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.URI;
+import java.nio.file.Files;
+import java.util.List;
+
+import static java.nio.file.StandardCopyOption.REPLACE_EXISTING;
+import static org.apache.http.HttpStatus.SC_NOT_FOUND;
+import static org.apache.http.HttpStatus.SC_OK;
+import static 
org.apache.sling.testing.clients.util.ResourceUtil.getResourceAsStream;
+
+/**
+ * Sling client for performing oak queries.
+ *
+ * Uses a custom query servlet {@code testQuery.json.jsp} to execute the 
query on the server
+ * and return the results as a json. If the servlet is not yet present, it 
automatically
+ * installs it and creates the corresponding nodes
+ *
+ * Paths created in jcr:
+ * - {@value JSP_PATH}, created by the bundle
+ * - {@value QUERY_NODE}, with {@code resourceType}={@value RESOURCE_TYPE}
+ * 
+ *
+ * The servlet is not automatically uninstalled to avoid too much noise on 
the instance.
+ * The caller should take care of it, if needed, by calling {@link 
#uninstallServlet()}
+ */
+public class QueryClient extends SlingClient {
+
+/**
+ * Query types, as defined in {@code 
org.apache.jackrabbit.oak.query.QueryEngineImpl}
+ */
+public enum QueryType {
+SQL2("JCR-SQL2"),
+SQL("sql"),
+XPATH("xpath"),
+JQOM("JCR-JQOM");
+
+private final String name;
+
+QueryType(String name) {
+this.name = name;
+}
+
+@Override
+public String toString() {
+return name;
+}
+}
+
+private static final Logger LOG = 
LoggerFactory.getLogger(QueryClient.class);
+
+private static final String BUNDLE_BSN = 
"org.apache.sling.testing.clients.query";
+private static final String BUNDLE_NAME = "Query servlet for testing";
+private static final String BUNDLE_VERSION = "1.0.0";
+private static final String BUNDLE_FILE = "testquery.bundle.";
+
+private static final String JSP_FILE = 
"/org/apache/sling/testing/clients/query/testQuery.json.jsp";
+private static final String RESOURCE_TYPE = "testQuery";
+private static final String COMPONENT_PATH = "apps/" + RESOURCE_TYPE;
+private static final String JSP_PATH = COMPONENT_PATH + "/" + 
RESOURCE_TYPE + ".json.jsp";
+private static final String QUERY_NODE = "/content/testquery";
+private static final String QUERY_PATH = QUERY_NODE + ".json";
+
+/**
+ * Constructor used by adaptTo
+ * @param http underlying HttpClient
+ * @param config config state
+ * @throws ClientException if the client cannot be created
+ */
+public QueryClient(CloseableHttpClient http, SlingClientConfig config) 
throws ClientException {
+super(http, config);
+}
+
+/**
+ * Convenience constructor
+ * @param url host url
+ * @param user username
+ * @param password password
+ * @throws 

[jira] [Commented] (SLING-7509) Add QueryClient

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378705#comment-16378705
 ] 

ASF GitHub Bot commented on SLING-7509:
---

dulvac commented on a change in pull request #5: SLING-7509 - Add QueryClient
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/5#discussion_r170932985
 
 

 ##
 File path: 
src/main/java/org/apache/sling/testing/clients/query/package-info.java
 ##
 @@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/**
+ * OSGI testing tools.
+ */
+@Version("1.0.0")
 
 Review comment:
   Can we make the version 0.1.0?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add QueryClient
> ---
>
> Key: SLING-7509
> URL: https://issues.apache.org/jira/browse/SLING-7509
> Project: Sling
>  Issue Type: New Feature
>  Components: Apache Sling Testing Clients
>Reporter: Valentin Olteanu
>Priority: Major
>
> Currently, there is no way to run queries in sling using the clients. This is 
> needed in several tests to search content and assert the effects of a feature.
>  
> The solution proposed in 
> [https://github.com/apache/sling-org-apache-sling-testing-clients/pull/5] 
>  * installs a custom query servlet
>  * runs the query in any of the supported format
>  * returns results as json



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7509) Add QueryClient

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378707#comment-16378707
 ] 

ASF GitHub Bot commented on SLING-7509:
---

dulvac commented on a change in pull request #5: SLING-7509 - Add QueryClient
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/5#discussion_r170932073
 
 

 ##
 File path: 
src/main/java/org/apache/sling/testing/clients/query/QueryClient.java
 ##
 @@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations 
under
+ * the License.
+ */
+package org.apache.sling.testing.clients.query;
+
+import org.apache.http.NameValuePair;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.sling.testing.clients.ClientException;
+import org.apache.sling.testing.clients.SlingClient;
+import org.apache.sling.testing.clients.SlingClientConfig;
+import org.apache.sling.testing.clients.SlingHttpResponse;
+import org.apache.sling.testing.clients.osgi.OsgiConsoleClient;
+import org.apache.sling.testing.clients.util.JsonUtils;
+import org.apache.sling.testing.clients.util.URLParameterBuilder;
+import org.codehaus.jackson.JsonNode;
+import org.ops4j.pax.tinybundles.core.TinyBundles;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.URI;
+import java.nio.file.Files;
+import java.util.List;
+
+import static java.nio.file.StandardCopyOption.REPLACE_EXISTING;
+import static org.apache.http.HttpStatus.SC_NOT_FOUND;
+import static org.apache.http.HttpStatus.SC_OK;
+import static 
org.apache.sling.testing.clients.util.ResourceUtil.getResourceAsStream;
+
+/**
+ * Sling client for performing oak queries.
+ *
+ * Uses a custom query servlet {@code testQuery.json.jsp} to execute the 
query on the server
+ * and return the results as a json. If the servlet is not yet present, it 
automatically
+ * installs it and creates the corresponding nodes
+ *
+ * Paths created in jcr:
+ * - {@value JSP_PATH}, created by the bundle
+ * - {@value QUERY_NODE}, with {@code resourceType}={@value RESOURCE_TYPE}
+ * 
+ *
+ * The servlet is not automatically uninstalled to avoid too much noise on 
the instance.
+ * The caller should take care of it, if needed, by calling {@link 
#uninstallServlet()}
+ */
+public class QueryClient extends SlingClient {
+
+/**
+ * Query types, as defined in {@code 
org.apache.jackrabbit.oak.query.QueryEngineImpl}
+ */
+public enum QueryType {
+SQL2("JCR-SQL2"),
+SQL("sql"),
+XPATH("xpath"),
+JQOM("JCR-JQOM");
+
+private final String name;
+
+QueryType(String name) {
+this.name = name;
+}
+
+@Override
+public String toString() {
+return name;
+}
+}
+
+private static final Logger LOG = 
LoggerFactory.getLogger(QueryClient.class);
+
+private static final String BUNDLE_BSN = 
"org.apache.sling.testing.clients.query";
+private static final String BUNDLE_NAME = "Query servlet for testing";
 
 Review comment:
   Can we make that be more clear? "Sling Testing Clients Query Servlet"?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add QueryClient
> ---
>
> Key: SLING-7509
> URL: https://issues.apache.org/jira/browse/SLING-7509
> Project: Sling
>  Issue Type: New Feature
>  Components: Apache Sling Testing Clients
>Reporter: Valentin Olteanu
>Priority: Major
>
> Currently, there is no way to run queries in sling using the clients. This is 
> needed in several tests to search content and assert the effects of a feature.
>  
> The solution proposed in 
> [https://github.com/apache/sling-org-apache-sling-testing-clients/pull/5] 
>  * installs a custom query servlet
>  * runs the query in any of the supported format

[jira] [Commented] (SLING-7509) Add QueryClient

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378706#comment-16378706
 ] 

ASF GitHub Bot commented on SLING-7509:
---

dulvac commented on a change in pull request #5: SLING-7509 - Add QueryClient
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/5#discussion_r170947383
 
 

 ##
 File path: 
src/main/java/org/apache/sling/testing/clients/query/QueryClient.java
 ##
 @@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations 
under
+ * the License.
+ */
+package org.apache.sling.testing.clients.query;
+
+import org.apache.http.NameValuePair;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.sling.testing.clients.ClientException;
+import org.apache.sling.testing.clients.SlingClient;
+import org.apache.sling.testing.clients.SlingClientConfig;
+import org.apache.sling.testing.clients.SlingHttpResponse;
+import org.apache.sling.testing.clients.osgi.OsgiConsoleClient;
+import org.apache.sling.testing.clients.util.JsonUtils;
+import org.apache.sling.testing.clients.util.URLParameterBuilder;
+import org.codehaus.jackson.JsonNode;
+import org.ops4j.pax.tinybundles.core.TinyBundles;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.URI;
+import java.nio.file.Files;
+import java.util.List;
+
+import static java.nio.file.StandardCopyOption.REPLACE_EXISTING;
+import static org.apache.http.HttpStatus.SC_NOT_FOUND;
+import static org.apache.http.HttpStatus.SC_OK;
+import static 
org.apache.sling.testing.clients.util.ResourceUtil.getResourceAsStream;
+
+/**
+ * Sling client for performing oak queries.
+ *
+ * Uses a custom query servlet {@code testQuery.json.jsp} to execute the 
query on the server
+ * and return the results as a json. If the servlet is not yet present, it 
automatically
+ * installs it and creates the corresponding nodes
+ *
+ * Paths created in jcr:
+ * - {@value JSP_PATH}, created by the bundle
+ * - {@value QUERY_NODE}, with {@code resourceType}={@value RESOURCE_TYPE}
+ * 
+ *
+ * The servlet is not automatically uninstalled to avoid too much noise on 
the instance.
+ * The caller should take care of it, if needed, by calling {@link 
#uninstallServlet()}
+ */
+public class QueryClient extends SlingClient {
+
+/**
+ * Query types, as defined in {@code 
org.apache.jackrabbit.oak.query.QueryEngineImpl}
+ */
+public enum QueryType {
+SQL2("JCR-SQL2"),
+SQL("sql"),
+XPATH("xpath"),
+JQOM("JCR-JQOM");
+
+private final String name;
+
+QueryType(String name) {
+this.name = name;
+}
+
+@Override
+public String toString() {
+return name;
+}
+}
+
+private static final Logger LOG = 
LoggerFactory.getLogger(QueryClient.class);
+
+private static final String BUNDLE_BSN = 
"org.apache.sling.testing.clients.query";
+private static final String BUNDLE_NAME = "Query servlet for testing";
+private static final String BUNDLE_VERSION = "1.0.0";
+private static final String BUNDLE_FILE = "testquery.bundle.";
+
+private static final String JSP_FILE = 
"/org/apache/sling/testing/clients/query/testQuery.json.jsp";
+private static final String RESOURCE_TYPE = "testQuery";
+private static final String COMPONENT_PATH = "apps/" + RESOURCE_TYPE;
+private static final String JSP_PATH = COMPONENT_PATH + "/" + 
RESOURCE_TYPE + ".json.jsp";
+private static final String QUERY_NODE = "/content/testquery";
+private static final String QUERY_PATH = QUERY_NODE + ".json";
+
+/**
+ * Constructor used by adaptTo
+ * @param http underlying HttpClient
+ * @param config config state
+ * @throws ClientException if the client cannot be created
+ */
+public QueryClient(CloseableHttpClient http, SlingClientConfig config) 
throws ClientException {
+super(http, config);
+}
+
+/**
+ * Convenience constructor
+ * @param url host url
+ * @param user username
+ * @param password password
+ * @throws 

[jira] [Commented] (SLING-7509) Add QueryClient

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378702#comment-16378702
 ] 

ASF GitHub Bot commented on SLING-7509:
---

dulvac commented on a change in pull request #5: SLING-7509 - Add QueryClient
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/5#discussion_r170932557
 
 

 ##
 File path: 
src/main/java/org/apache/sling/testing/clients/query/QueryClient.java
 ##
 @@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations 
under
+ * the License.
+ */
+package org.apache.sling.testing.clients.query;
+
+import org.apache.http.NameValuePair;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.sling.testing.clients.ClientException;
+import org.apache.sling.testing.clients.SlingClient;
+import org.apache.sling.testing.clients.SlingClientConfig;
+import org.apache.sling.testing.clients.SlingHttpResponse;
+import org.apache.sling.testing.clients.osgi.OsgiConsoleClient;
+import org.apache.sling.testing.clients.util.JsonUtils;
+import org.apache.sling.testing.clients.util.URLParameterBuilder;
+import org.codehaus.jackson.JsonNode;
+import org.ops4j.pax.tinybundles.core.TinyBundles;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.URI;
+import java.nio.file.Files;
+import java.util.List;
+
+import static java.nio.file.StandardCopyOption.REPLACE_EXISTING;
+import static org.apache.http.HttpStatus.SC_NOT_FOUND;
+import static org.apache.http.HttpStatus.SC_OK;
+import static 
org.apache.sling.testing.clients.util.ResourceUtil.getResourceAsStream;
+
+/**
+ * Sling client for performing oak queries.
+ *
+ * Uses a custom query servlet {@code testQuery.json.jsp} to execute the 
query on the server
+ * and return the results as a json. If the servlet is not yet present, it 
automatically
+ * installs it and creates the corresponding nodes
+ *
+ * Paths created in jcr:
+ * - {@value JSP_PATH}, created by the bundle
+ * - {@value QUERY_NODE}, with {@code resourceType}={@value RESOURCE_TYPE}
+ * 
+ *
+ * The servlet is not automatically uninstalled to avoid too much noise on 
the instance.
+ * The caller should take care of it, if needed, by calling {@link 
#uninstallServlet()}
+ */
+public class QueryClient extends SlingClient {
+
+/**
+ * Query types, as defined in {@code 
org.apache.jackrabbit.oak.query.QueryEngineImpl}
+ */
+public enum QueryType {
+SQL2("JCR-SQL2"),
+SQL("sql"),
+XPATH("xpath"),
+JQOM("JCR-JQOM");
+
+private final String name;
+
+QueryType(String name) {
+this.name = name;
+}
+
+@Override
+public String toString() {
+return name;
+}
+}
+
+private static final Logger LOG = 
LoggerFactory.getLogger(QueryClient.class);
+
+private static final String BUNDLE_BSN = 
"org.apache.sling.testing.clients.query";
+private static final String BUNDLE_NAME = "Query servlet for testing";
+private static final String BUNDLE_VERSION = "1.0.0";
+private static final String BUNDLE_FILE = "testquery.bundle.";
+
+private static final String JSP_FILE = 
"/org/apache/sling/testing/clients/query/testQuery.json.jsp";
+private static final String RESOURCE_TYPE = "testQuery";
+private static final String COMPONENT_PATH = "apps/" + RESOURCE_TYPE;
+private static final String JSP_PATH = COMPONENT_PATH + "/" + 
RESOURCE_TYPE + ".json.jsp";
+private static final String QUERY_NODE = "/content/testquery";
+private static final String QUERY_PATH = QUERY_NODE + ".json";
+
+/**
+ * Constructor used by adaptTo
+ * @param http underlying HttpClient
+ * @param config config state
+ * @throws ClientException if the client cannot be created
+ */
+public QueryClient(CloseableHttpClient http, SlingClientConfig config) 
throws ClientException {
+super(http, config);
+}
+
+/**
+ * Convenience constructor
+ * @param url host url
+ * @param user username
+ * @param password password
+ * @throws 

[jira] [Commented] (SLING-7509) Add QueryClient

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378703#comment-16378703
 ] 

ASF GitHub Bot commented on SLING-7509:
---

dulvac commented on a change in pull request #5: SLING-7509 - Add QueryClient
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/5#discussion_r170936645
 
 

 ##
 File path: 
src/main/java/org/apache/sling/testing/clients/query/QueryClient.java
 ##
 @@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations 
under
+ * the License.
+ */
+package org.apache.sling.testing.clients.query;
+
+import org.apache.http.NameValuePair;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.sling.testing.clients.ClientException;
+import org.apache.sling.testing.clients.SlingClient;
+import org.apache.sling.testing.clients.SlingClientConfig;
+import org.apache.sling.testing.clients.SlingHttpResponse;
+import org.apache.sling.testing.clients.osgi.OsgiConsoleClient;
+import org.apache.sling.testing.clients.util.JsonUtils;
+import org.apache.sling.testing.clients.util.URLParameterBuilder;
+import org.codehaus.jackson.JsonNode;
+import org.ops4j.pax.tinybundles.core.TinyBundles;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.URI;
+import java.nio.file.Files;
+import java.util.List;
+
+import static java.nio.file.StandardCopyOption.REPLACE_EXISTING;
+import static org.apache.http.HttpStatus.SC_NOT_FOUND;
+import static org.apache.http.HttpStatus.SC_OK;
+import static 
org.apache.sling.testing.clients.util.ResourceUtil.getResourceAsStream;
+
+/**
+ * Sling client for performing oak queries.
+ *
+ * Uses a custom query servlet {@code testQuery.json.jsp} to execute the 
query on the server
+ * and return the results as a json. If the servlet is not yet present, it 
automatically
+ * installs it and creates the corresponding nodes
+ *
+ * Paths created in jcr:
+ * - {@value JSP_PATH}, created by the bundle
+ * - {@value QUERY_NODE}, with {@code resourceType}={@value RESOURCE_TYPE}
+ * 
+ *
+ * The servlet is not automatically uninstalled to avoid too much noise on 
the instance.
+ * The caller should take care of it, if needed, by calling {@link 
#uninstallServlet()}
+ */
+public class QueryClient extends SlingClient {
+
+/**
+ * Query types, as defined in {@code 
org.apache.jackrabbit.oak.query.QueryEngineImpl}
+ */
+public enum QueryType {
+SQL2("JCR-SQL2"),
+SQL("sql"),
+XPATH("xpath"),
+JQOM("JCR-JQOM");
+
+private final String name;
+
+QueryType(String name) {
+this.name = name;
+}
+
+@Override
+public String toString() {
+return name;
+}
+}
+
+private static final Logger LOG = 
LoggerFactory.getLogger(QueryClient.class);
+
+private static final String BUNDLE_BSN = 
"org.apache.sling.testing.clients.query";
+private static final String BUNDLE_NAME = "Query servlet for testing";
+private static final String BUNDLE_VERSION = "1.0.0";
+private static final String BUNDLE_FILE = "testquery.bundle.";
+
+private static final String JSP_FILE = 
"/org/apache/sling/testing/clients/query/testQuery.json.jsp";
+private static final String RESOURCE_TYPE = "testQuery";
+private static final String COMPONENT_PATH = "apps/" + RESOURCE_TYPE;
+private static final String JSP_PATH = COMPONENT_PATH + "/" + 
RESOURCE_TYPE + ".json.jsp";
+private static final String QUERY_NODE = "/content/testquery";
+private static final String QUERY_PATH = QUERY_NODE + ".json";
+
+/**
+ * Constructor used by adaptTo
+ * @param http underlying HttpClient
+ * @param config config state
+ * @throws ClientException if the client cannot be created
+ */
+public QueryClient(CloseableHttpClient http, SlingClientConfig config) 
throws ClientException {
+super(http, config);
+}
+
+/**
+ * Convenience constructor
+ * @param url host url
+ * @param user username
+ * @param password password
+ * @throws 

[jira] [Commented] (SLING-7511) Add importContent to SlingClient

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378708#comment-16378708
 ] 

ASF GitHub Bot commented on SLING-7511:
---

dulvac commented on a change in pull request #6: SLING-7511: Add importContent 
to SlingClient
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/6#discussion_r170947935
 
 

 ##
 File path: 
src/test/java/org/apache/sling/testing/clients/SlingClientImportContentTest.java
 ##
 @@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations 
under
+ * the License.
+ */
+package org.apache.sling.testing.clients;
+
+import org.apache.http.*;
+import org.apache.http.client.utils.URLEncodedUtils;
+import org.apache.http.protocol.HttpContext;
+import org.apache.http.protocol.HttpRequestHandler;
+import org.codehaus.jackson.node.JsonNodeFactory;
+import org.codehaus.jackson.node.ObjectNode;
+import org.junit.ClassRule;
+import org.junit.Ignore;
+import org.junit.Test;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.PrintWriter;
+import java.net.URI;
+import java.util.List;
+
+import static org.apache.http.HttpStatus.SC_BAD_REQUEST;
+import static org.apache.http.HttpStatus.SC_CREATED;
+import static org.apache.http.HttpStatus.SC_OK;
+
+public class SlingClientImportContentTest {
+private static final String IMPORT_PATH = "/test/import/parent";
+
+@ClassRule
+public static HttpServerRule httpServer = new HttpServerRule() {
+@Override
+protected void registerHandlers() throws IOException {
+serverBootstrap.registerHandler(IMPORT_PATH, new 
HttpRequestHandler() {
+@Override
+public void handle(HttpRequest request, HttpResponse response, 
HttpContext context) throws HttpException, IOException {
+String operation = null;
+String content = null;
+if (request instanceof HttpEntityEnclosingRequest) {
+HttpEntity entity = ((HttpEntityEnclosingRequest) 
request).getEntity();
+List params = 
URLEncodedUtils.parse(entity);
+for (NameValuePair param : params) {
+if (param.getName().equals(":operation")) {
+operation = param.getValue();
+}
+
+if (param.getName().equals(":content")) {
+content = param.getValue();
+}
+}
+}
+
+if (!"import".equals(operation)) {
+response.setStatusCode(SC_BAD_REQUEST);
+return;
+}
+
+if 
(!"{\"something\":{\"prop1\":\"val1\"}}".equals(content)) {
+System.out.println("Unexpected content: " + content);
+response.setStatusCode(SC_BAD_REQUEST);
+return;
+}
+
+response.setStatusCode(SC_CREATED);
+}
+});
+}
+};
+
+@Test
+public void testImportContent() throws Exception {
+SlingClient c = new SlingClient(httpServer.getURI(), "user", "pass");
+SlingHttpResponse res = c.importContent(IMPORT_PATH, "json", 
"{\"something\":{\"prop1\":\"val1\"}}");
+}
+
+@Test
+public void testImportJson() throws Exception {
+ObjectNode node = JsonNodeFactory.instance.objectNode();
+ObjectNode props = JsonNodeFactory.instance.objectNode();
+props.put("prop1", "val1");
+
+node.put("something", props);
+SlingClient c = new SlingClient(httpServer.getURI(), "user", "pass");
+SlingHttpResponse res = c.importJson(IMPORT_PATH, node);
+}
+
+@Test
+@Ignore
+public void testImportRemote() throws ClientException {
+SlingClient c = new SlingClient(URI.create("http://localhost:8080;), 
"admin", "admin");
+c.importContent("/content/", "json", 
"{\"something\":{\"prop1\":\"val1\"}}");
+}
+
+@Test
+@Ignore
 
 Review comment:
 

[jira] [Commented] (SLING-7519) Add webconsole ds module to SlingOptions

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378709#comment-16378709
 ] 

Oliver Lietz commented on SLING-7519:
-

[~ch...@die-schneider.net], [~rombert], this change is arguable of course. 
{{slf4j-simple}} is not required at all and adding the DS plugin to a module's 
base test class \[1\] should be sufficient and keeps provided options small. 
Also the change would get overridden because it is missing from the template 
({{SlingOptions.hbs}}). And please fix versions.

\[1\] 
{{mavenBundle().groupId("org.apache.felix").artifactId("org.apache.felix.webconsole.plugins.ds").version(versionResolver)}}

> Add webconsole ds module to SlingOptions
> 
>
> Key: SLING-7519
> URL: https://issues.apache.org/jira/browse/SLING-7519
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Sling Pax Exam Utilities 1.0.4
>Reporter: Christian Schneider
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Pax Exam Utilities 1.0.6
>
>
> Sling uses DS all over the place. We should add the ds module for the 
> webconsole to have more insight into the DS components in tests.
> I will supply a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7511) Add importContent to SlingClient

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378715#comment-16378715
 ] 

ASF GitHub Bot commented on SLING-7511:
---

dulvac commented on a change in pull request #6: SLING-7511: Add importContent 
to SlingClient
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/6#discussion_r170948690
 
 

 ##
 File path: 
src/main/java/org/apache/sling/testing/clients/email/package-info.java
 ##
 @@ -17,7 +17,7 @@
  * under the License.
  */
 
-@Version("1.1.0")
+@Version("1.2.0")
 
 Review comment:
   good question. nothing changed in that package, right @volteanu ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add importContent to SlingClient
> 
>
> Key: SLING-7511
> URL: https://issues.apache.org/jira/browse/SLING-7511
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Reporter: Valentin Olteanu
>Priority: Major
>
> Add operations specific to 
> [http://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#importing-content-structures]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7511) Add importContent to SlingClient

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378716#comment-16378716
 ] 

ASF GitHub Bot commented on SLING-7511:
---

dulvac commented on a change in pull request #6: SLING-7511: Add importContent 
to SlingClient
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/6#discussion_r170950434
 
 

 ##
 File path: src/main/java/org/apache/sling/testing/clients/package-info.java
 ##
 @@ -17,7 +17,7 @@
  * under the License.
  */
 
-@Version("1.4.0")
+@Version("1.5.0")
 
 Review comment:
   @rombert , isn't it because there are new public methods here and the 
default is `ConsumerType`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add importContent to SlingClient
> 
>
> Key: SLING-7511
> URL: https://issues.apache.org/jira/browse/SLING-7511
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Reporter: Valentin Olteanu
>Priority: Major
>
> Add operations specific to 
> [http://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#importing-content-structures]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7519) Add webconsole ds module to SlingOptions

[Christian Schneider (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378731#comment-16378731
 ] 

Christian Schneider commented on SLING-7519:


Thanks for the review Oliver. I will look into it and provide another PR.

> Add webconsole ds module to SlingOptions
> 
>
> Key: SLING-7519
> URL: https://issues.apache.org/jira/browse/SLING-7519
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Sling Pax Exam Utilities 1.0.4
>Reporter: Christian Schneider
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Pax Exam Utilities 1.0.6
>
>
> Sling uses DS all over the place. We should add the ds module for the 
> webconsole to have more insight into the DS components in tests.
> I will supply a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7486) Remove tags of canceled releases from Subversion and Git repositories

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378753#comment-16378753
 ] 

Oliver Lietz commented on SLING-7486:
-

We agreed once on [removing broken release 
tags|http://sling.apache.org/documentation/development/release-management.html#canceling-the-release]
 from repositories but missed clean up before switching to Git. Once in a while 
when checking source and comparing versions I stumble upon invalid release tags 
(also in our Subversion repo due to mentioned tagging issues in Git repos) and 
spend some minutes to find out release was canceled or whatsoever. So I tried 
to fix it now. Obviously I'm the only one who is annoyed by this and so I give 
it up.

> Remove tags of canceled releases from Subversion and Git repositories
> -
>
> Key: SLING-7486
> URL: https://issues.apache.org/jira/browse/SLING-7486
> Project: Sling
>  Issue Type: Task
>  Components: Best practices, General
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> ||Subversion Tag||POM Group ID||POM Artifact ID||POM Version||TODO||
> |org.apache.sling.bgservlets-1.0.0|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT|
>  remove |
> |org.apache.sling.bgservlets-1.0.2|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT|
>  remove |
> |org.apache.sling.commons.johnzon-1.0.2|org.apache.sling|org.apache.sling.commons.johnzon|1.0.2|
>  remove |
> |org.apache.sling.commons.metrics-0.0.2|org.apache.sling|org.apache.sling.commons.metrics|0.0.2|
>  remove |
> |org.apache.sling.crankstart.api.fragment-1.0.0|org.apache.sling|org.apache.sling.crankstart.api.fragment|1.0.0|
>  remove |
> |org.apache.sling.discovery.base-2.0.2|org.apache.sling|org.apache.sling.discovery.base|2.0.2|
>  remove |
> |org.apache.sling.discovery.commons-1.0.14|org.apache.sling|org.apache.sling.discovery.commons|1.0.14|
>  remove |
> |org.apache.sling.discovery.commons-1.0.22|org.apache.sling|org.apache.sling.discovery.commons|1.0.22|
>  remove |
> |org.apache.sling.discovery.oak-1.2.12|org.apache.sling|org.apache.sling.discovery.oak|1.2.12|
>  remove |
> |org.apache.sling.event-3.3.8|org.apache.sling|org.apache.sling.event|3.3.8| 
> remove |
> |org.apache.sling.fsresource-1.2.0|org.apache.sling|org.apache.sling.fsresource|1.2.0|
>  remove |
> |org.apache.sling.hc.core-1.0.0|org.apache.sling|sling-builder|7-SNAPSHOT| 
> remove |
> |org.apache.sling.hc.core-1.0.2|org.apache.sling|sling-builder|7-SNAPSHOT| 
> remove |
> |org.apache.sling.i18n-2.3.0|org.apache.sling|org.apache.sling.i18n|2.3.0| 
> remove |
> |org.apache.sling.i18n-2.4.0|org.apache.sling|org.apache.sling.i18n|2.4.0| 
> remove |
> |org.apache.sling.installer.factory.configuration-1.0.6|org.apache.sling|org.apache.sling.installer.factory.configuration|1.0.6|
>  remove |
> |org.apache.sling.jcr.base-2.0.8|org.apache.sling|org.apache.sling.jcr.base|2.0.8|
>  remove |
> |org.apache.sling.jcr.oak.server-1.1.2|org.apache.sling|org.apache.sling.jcr.oak.server|1.1.2|
>  remove |
> |org.apache.sling.jcr.resource-2.4.0|org.apache.sling|org.apache.sling.jcr.resource|2.4.0|
>  remove |
> |org.apache.sling.junit.healthcheck-1.0.4|org.apache.sling|org.apache.sling.junit.remote|1.0.9-SNAPSHOT|
>  remove |
> |org.apache.sling.launchpad.test-services-2.0.4-incubator|org.apache.sling|org.apache.sling.launchpad.test-services|2.0.4-incubator|
>  remove |
> |org.apache.sling.launchpad.testing-6|org.apache.sling|org.apache.sling.launchpad.testing|6|
>  remove |
> |org.apache.sling.launchpad.testing-war-6|org.apache.sling|org.apache.sling.launchpad.testing-war|6|
>  remove |
> |org.apache.sling.performance.base-0.0.2|org.apache.sling|org.apache.sling.performance.base|0.0.2|
>  remove |
> |org.apache.sling.resourcemerger-1.2.2|org.apache.sling|org.apache.sling.resourcemerger|1.2.2|
>  remove |
> |org.apache.sling.resourceresolver-1.4.6|org.apache.sling|org.apache.sling.resourceresolver|1.4.6|
>  remove |
> |org.apache.sling.scripting.core-2.0.12|org.apache.sling|org.apache.sling.scripting.core|2.0.12|
>  remove |
> |org.apache.sling.scripting.java-2.0.8|org.apache.sling|org.apache.sling.scripting.java|2.0.8|
>  remove |
> |org.apache.sling.scripting.jsp-2.1.2|org.apache.sling|org.apache.sling.scripting.jsp|2.1.2|
>  remove |
> |org.apache.sling.scripting.jsp.taglib-2.1.4|org.apache.sling|org.apache.sling.scripting.jsp.taglib|2.1.4|
>  remove |
> |org.apache.sling.scripting.velocity-2.0.0|org.apache.sling|org.apache.sling.scripting.velocity|2.0.0|
>  remove |
> |org.apache.sling.testing.tools-1.0.4|org.apache.sling|org.apache.sling.testing.tools|1.0.4|
>  remove |
> |org.apache.sling.validation.reactor-1.0.0|org.apache.sling|org.apache.sling.validation.reactor|1.0.0-SNAPSHOT|
>  remove |
>