[jira] [Resolved] (SLING-8046) Correct and improve classifier handling
[ https://issues.apache.org/jira/browse/SLING-8046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-8046. - Resolution: Fixed I've fixed a couple of minor issues and inconsistencies with respect to classifier handling > Correct and improve classifier handling > --- > > Key: SLING-8046 > URL: https://issues.apache.org/jira/browse/SLING-8046 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: slingfeature-maven-plugin 1.0.0 > > > The classifier handling for features is currently not correct as it makes a > feature named feature.json the main artifact but also adds the classifier > "feature" to the "id" of that feature, which clearly is a mismatch > At the same time we could improve the error handling and messages around > classifiers -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-8046) Correct and improve classifier handling
Carsten Ziegeler created SLING-8046: --- Summary: Correct and improve classifier handling Key: SLING-8046 URL: https://issues.apache.org/jira/browse/SLING-8046 Project: Sling Issue Type: Improvement Components: Maven Plugins and Archetypes Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: slingfeature-maven-plugin 1.0.0 The classifier handling for features is currently not correct as it makes a feature named feature.json the main artifact but also adds the classifier "feature" to the "id" of that feature, which clearly is a mismatch At the same time we could improve the error handling and messages around classifiers -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[RESULT] [VOTE] Release Apache Sling Oak Restrictions 1.0.2
Hi, The vote has passed with the following result: +1 (binding): Robert Munteanu, Bertrand Delacretaz, Daniel Klco, Georg Henzler I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. -Georg On 2018-10-17 16:40, Daniel Klco wrote: +1 On Wed, Oct 17, 2018 at 5:16 AM Bertrand Delacretaz wrote: On Tue, Oct 16, 2018 at 9:21 PM Georg Henzler wrote: > ...Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-1996 ... +1 for the release of
[jira] [Updated] (SLING-7960) Repoinit: "delete user" also deletes service user
[
https://issues.apache.org/jira/browse/SLING-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jörg Hoh updated SLING-7960:
Attachment: SLING-7960-4-oasjr.patch
> Repoinit: "delete user" also deletes service user
> -
>
> Key: SLING-7960
> URL: https://issues.apache.org/jira/browse/SLING-7960
> Project: Sling
> Issue Type: Bug
> Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.8
>Reporter: Jörg Hoh
>Priority: Major
> Attachments: SLING-7960-2.patch, SLING-7960-3.patch,
> SLING-7960-4-oasjr.patch, SLING-7960-4-oasrp.patch, SLING-7960.patch
>
>
> My current application uses a regular user, but with some changes to the
> framework we need to migrate to regular service users. The service user is
> being added as part of the deployment.
> To automate this I decided to use the repoinit to remove the regular user and
> then deploy the service user. Which works fine, but only until the next time
> the repoinit is executed again. Because then the repoinit statement
> {{delete user foo}}
> purges the newly created serviceuser "foo". Which is totally unexpected,
> because there is a dedicated command "delete service user" which is supposed
> to remove users. So "delete user foo" must only delete a regular user "foo"
> but not a service user named "foo".
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SLING-7960) Repoinit: "delete user" also deletes service user
[
https://issues.apache.org/jira/browse/SLING-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jörg Hoh updated SLING-7960:
Attachment: SLING-7960-4-oasrp.patch
> Repoinit: "delete user" also deletes service user
> -
>
> Key: SLING-7960
> URL: https://issues.apache.org/jira/browse/SLING-7960
> Project: Sling
> Issue Type: Bug
> Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.8
>Reporter: Jörg Hoh
>Priority: Major
> Attachments: SLING-7960-2.patch, SLING-7960-3.patch,
> SLING-7960-4-oasjr.patch, SLING-7960-4-oasrp.patch, SLING-7960.patch
>
>
> My current application uses a regular user, but with some changes to the
> framework we need to migrate to regular service users. The service user is
> being added as part of the deployment.
> To automate this I decided to use the repoinit to remove the regular user and
> then deploy the service user. Which works fine, but only until the next time
> the repoinit is executed again. Because then the repoinit statement
> {{delete user foo}}
> purges the newly created serviceuser "foo". Which is totally unexpected,
> because there is a dedicated command "delete service user" which is supposed
> to remove users. So "delete user foo" must only delete a regular user "foo"
> but not a service user named "foo".
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: How to manage repoinit language + implementation evolutions?
Am Di., 16. Okt. 2018 um 10:57 Uhr schrieb Bertrand Delacretaz < bdelacre...@apache.org>: > > > WDYT? > +1 I will update the patches at SLING-7960. -- Cheers, Jörg Hoh, http://cqdump.wordpress.com Twitter: @joerghoh
[jira] [Commented] (SLING-7960) Repoinit: "delete user" also deletes service user
[
https://issues.apache.org/jira/browse/SLING-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658268#comment-16658268
]
Jörg Hoh commented on SLING-7960:
-
Bertrand suggested this:
# Introduce a new DELETE REAL USER command that only deletes real users.
# Keep DELETE USER as is, deleting both types of users. Document these
commands better to avoid confusion here.
# Fix DELETE SERVICE USER so that it only deletes service users.
# None of these commands fail if is not of the expected type or does not
exist, they just log INFO messages in such cases.
Let's do it as Bertrand suggested.
To get this work I needed to change both the repoinit-parser and jcr-repoinit
modules. Therefor I have 2 patches:
* [^SLING-7960-4-oasrp.patch] for org.apache.sling.repoinit.parser and
* [^SLING-7960-4-oasjr.patch] for org.apache.sling.jcr.repoinit
Notable changes:
* I needed to bump the package version of
org.apache.sling.repoinit.parser.operations to 4.2.0
* "DELETE USER u" will work as it did before, but I it will always log a
warning to user either "DELETE SERVICE USER" or "DELETE REAL USER" for
disambiguation.
> Repoinit: "delete user" also deletes service user
> -
>
> Key: SLING-7960
> URL: https://issues.apache.org/jira/browse/SLING-7960
> Project: Sling
> Issue Type: Bug
> Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.8
>Reporter: Jörg Hoh
>Priority: Major
> Attachments: SLING-7960-2.patch, SLING-7960-3.patch,
> SLING-7960-4-oasjr.patch, SLING-7960-4-oasrp.patch, SLING-7960.patch
>
>
> My current application uses a regular user, but with some changes to the
> framework we need to migrate to regular service users. The service user is
> being added as part of the deployment.
> To automate this I decided to use the repoinit to remove the regular user and
> then deploy the service user. Which works fine, but only until the next time
> the repoinit is executed again. Because then the repoinit statement
> {{delete user foo}}
> purges the newly created serviceuser "foo". Which is totally unexpected,
> because there is a dedicated command "delete service user" which is supposed
> to remove users. So "delete user foo" must only delete a regular user "foo"
> but not a service user named "foo".
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
