[jira] Created: (SLING-1626) Launchpad: NamespaceException: sling: is not a registered namespace prefix
Launchpad: NamespaceException: sling: is not a registered namespace prefix -- Key: SLING-1626 URL: https://issues.apache.org/jira/browse/SLING-1626 Project: Sling Issue Type: Bug Components: JCR Affects Versions: Launchpad Builder 6 Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Starting the standalone jar from launchpad/builder produces this error in the logs: org.apache.sling.jcr.contentloader.internal.ContentLoaderService activate: Problem while loading initial content and registering mappings for existing bundles javax.jcr.NamespaceException: sling: is not a registered namespace prefix. which (obviously) prevents many features from working -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1626) Launchpad: NamespaceException: sling: is not a registered namespace prefix
[ https://issues.apache.org/jira/browse/SLING-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12894878#action_12894878 ] Bertrand Delacretaz commented on SLING-1626: Looks like a timing/dependencies problem, with the following scenario the content is loaded: 1. Start sling from scratch - above error in log, no content loaded 2. Reload org.apache.sling.jcr.resource bundle - sling namespace registered 3. Reload org.apache.sling.launchpad.content bundle - content loaded After that, 300 integration tests pass, but not all of them (in revision 981845) Launchpad: NamespaceException: sling: is not a registered namespace prefix -- Key: SLING-1626 URL: https://issues.apache.org/jira/browse/SLING-1626 Project: Sling Issue Type: Bug Components: JCR Affects Versions: Launchpad Builder 6 Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Starting the standalone jar from launchpad/builder produces this error in the logs: org.apache.sling.jcr.contentloader.internal.ContentLoaderService activate: Problem while loading initial content and registering mappings for existing bundles javax.jcr.NamespaceException: sling: is not a registered namespace prefix. which (obviously) prevents many features from working -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1626) Launchpad: NamespaceException: sling: is not a registered namespace prefix
[ https://issues.apache.org/jira/browse/SLING-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-1626. Fix Version/s: Launchpad Builder 6 Resolution: Fixed Revision 981860 fixes this particular problem, but a number of integration tests still fail (maybe unrelated). Tests run: 354, Failures: 27, Errors: 3, Skipped: 0 Marking this issue resolved, SLING-1548 will introduce an improved content loading code anyway. Launchpad: NamespaceException: sling: is not a registered namespace prefix -- Key: SLING-1626 URL: https://issues.apache.org/jira/browse/SLING-1626 Project: Sling Issue Type: Bug Components: JCR Affects Versions: Launchpad Builder 6 Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Fix For: Launchpad Builder 6 Starting the standalone jar from launchpad/builder produces this error in the logs: org.apache.sling.jcr.contentloader.internal.ContentLoaderService activate: Problem while loading initial content and registering mappings for existing bundles javax.jcr.NamespaceException: sling: is not a registered namespace prefix. which (obviously) prevents many features from working -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1671) New features for jQuery JCR Explorer - step 1
[ https://issues.apache.org/jira/browse/SLING-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12902835#action_12902835 ] Bertrand Delacretaz commented on SLING-1671: I just gave user Clemens Wyss the Contributor role, you should be able to assign the issue to yourself now New features for jQuery JCR Explorer - step 1 - Key: SLING-1671 URL: https://issues.apache.org/jira/browse/SLING-1671 Project: Sling Issue Type: New Feature Components: Extensions Reporter: Clemens Wyss Priority: Minor + property (type) specific editors (e.g. date, boolean) + search (SQL2, JQDOM, sql and xpath) + optimized tree (navigation) + pluggable resource/node editors -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-920) Hudson continuous integration setup
[ https://issues.apache.org/jira/browse/SLING-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12903351#action_12903351 ] Bertrand Delacretaz commented on SLING-920: --- Removed the https://hudson.apache.org/hudson/view/Sling/job/sling-installer-1.5/ as the installer is now included in the trunk build. Hudson continuous integration setup --- Key: SLING-920 URL: https://issues.apache.org/jira/browse/SLING-920 Project: Sling Issue Type: Task Components: Testing Reporter: Bertrand Delacretaz Use this issue to record changes to the Hudson continuous environment setup at http://hudson.zones.apache.org/hudson/view/Sling/ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (SLING-920) Hudson continuous integration setup
[ https://issues.apache.org/jira/browse/SLING-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12903351#action_12903351 ] Bertrand Delacretaz edited comment on SLING-920 at 8/27/10 5:17 AM: Removed the https://hudson.apache.org/hudson/view/Sling/job/sling-installer-1.5/ build from Hudson, as the installer is now included in the trunk build. was (Author: bdelacretaz): Removed the https://hudson.apache.org/hudson/view/Sling/job/sling-installer-1.5/ as the installer is now included in the trunk build. Hudson continuous integration setup --- Key: SLING-920 URL: https://issues.apache.org/jira/browse/SLING-920 Project: Sling Issue Type: Task Components: Testing Reporter: Bertrand Delacretaz Use this issue to record changes to the Hudson continuous environment setup at http://hudson.zones.apache.org/hudson/view/Sling/ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1603) SlingServlet service
[ https://issues.apache.org/jira/browse/SLING-1603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12904949#action_12904949 ] Bertrand Delacretaz commented on SLING-1603: Refactoring looks good to me (haven't looked at the code, just Felix's description). Maybe SlingEngine would be a better, more specific name than just Engine? Not terribly important. It would be better IMO to have a distinct patch for SLING-1213 SlingServlet service Key: SLING-1603 URL: https://issues.apache.org/jira/browse/SLING-1603 Project: Sling Issue Type: Improvement Components: Engine Affects Versions: Engine 2.0.6 Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Attachments: SLING-1603-fmeschbe.patch, SLING-1603.patch, SLING-1603.patch For SLING-550 I need to call the SlingMainServlet outside of the web container's request/response cycle. I'll attach a patch that introduces a new SlingServlet interface that SlingMainServlet implements. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1603) SlingServlet service
[ https://issues.apache.org/jira/browse/SLING-1603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12904978#action_12904978 ] Bertrand Delacretaz commented on SLING-1603: I like SlingRequestProcessor, it's very clear. No strong opinions on the SLING-1213 thing, I trust you to do it right. SlingServlet service Key: SLING-1603 URL: https://issues.apache.org/jira/browse/SLING-1603 Project: Sling Issue Type: Improvement Components: Engine Affects Versions: Engine 2.0.6 Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Attachments: SLING-1603-fmeschbe.patch, SLING-1603.patch, SLING-1603.patch For SLING-550 I need to call the SlingMainServlet outside of the web container's request/response cycle. I'll attach a patch that introduces a new SlingServlet interface that SlingMainServlet implements. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-1731) Sling Explorer: cannot edit nodes using Chrome
Sling Explorer: cannot edit nodes using Chrome -- Key: SLING-1731 URL: https://issues.apache.org/jira/browse/SLING-1731 Project: Sling Issue Type: Bug Components: Extensions Reporter: Bertrand Delacretaz Priority: Minor Attachments: SLING-1731-chrome.jpg Tried the explorer by adding the contrib/explorers/jquery bundle to a fresh launchpad/builder standalone Sling instance. On Firefox http://localhost:8080/sling-test/sling.explorer.html correcly displays the add new sub-node and related editing fields, but using Chrome 5.0.375.127 on macosx those fields are not shown. Screenshot follows. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1731) Sling Explorer: cannot edit nodes using Chrome
[ https://issues.apache.org/jira/browse/SLING-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-1731: --- Attachment: SLING-1731-chrome.jpg Screenshot with Chrome Sling Explorer: cannot edit nodes using Chrome -- Key: SLING-1731 URL: https://issues.apache.org/jira/browse/SLING-1731 Project: Sling Issue Type: Bug Components: Extensions Reporter: Bertrand Delacretaz Priority: Minor Attachments: SLING-1731-chrome.jpg Tried the explorer by adding the contrib/explorers/jquery bundle to a fresh launchpad/builder standalone Sling instance. On Firefox http://localhost:8080/sling-test/sling.explorer.html correcly displays the add new sub-node and related editing fields, but using Chrome 5.0.375.127 on macosx those fields are not shown. Screenshot follows. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-1731) Sling Explorer: cannot edit nodes using Chrome
[ https://issues.apache.org/jira/browse/SLING-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz closed SLING-1731. -- Sling Explorer: cannot edit nodes using Chrome -- Key: SLING-1731 URL: https://issues.apache.org/jira/browse/SLING-1731 Project: Sling Issue Type: Bug Components: Extensions Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Attachments: SLING-1731-chrome.jpg Tried the explorer by adding the contrib/explorers/jquery bundle to a fresh launchpad/builder standalone Sling instance. On Firefox http://localhost:8080/sling-test/sling.explorer.html correcly displays the add new sub-node and related editing fields, but using Chrome 5.0.375.127 on macosx those fields are not shown. Screenshot follows. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1778) Symlinks
[ https://issues.apache.org/jira/browse/SLING-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910186#action_12910186 ] Bertrand Delacretaz commented on SLING-1778: Just thinking out loud here, but how about *only* supporting overlays. I can see how overlays and symlinks are related, but they actually seems like different use cases. I like that. Symlinks Key: SLING-1778 URL: https://issues.apache.org/jira/browse/SLING-1778 Project: Sling Issue Type: New Feature Components: JCR Reporter: Julian Sedding Attachments: symlinks.patch I have implemented a ResourceProvider, which allows to create symlink nodes in the JCR repository. A symlink node has a sling:symlinkTarget property, which should contain a valid JCR path. JCR content from the sling:symlinkTarget path is then exposed below the symlink node. There is a mixin node type, sling:Symlink with a mandatory property sling:symlinkTarget and an optional property sling:overlayable. Additionally, there is a convenience node type, sling:SymlinkResource, which extends from sling:symlinkTarget and nt:unstructured. ResourceProvider instances are registered for existing symlinks when the bundle is started. Modifications are taken care of via JCR observation. To get started: * apply the attached patch to a trunk checkout * build and install the bundle * create a symlink node, pointing to some existing content * access the symlink node e.g. via a browser -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1778) Symlinks
[ https://issues.apache.org/jira/browse/SLING-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910197#action_12910197 ] Bertrand Delacretaz commented on SLING-1778: I suggest sling:overlayPath for the property name. As for symlinks, I'd consider this a distinct problem, and if needed create a distinct component to handle them. I think that's what Justin meant. Symlinks Key: SLING-1778 URL: https://issues.apache.org/jira/browse/SLING-1778 Project: Sling Issue Type: New Feature Components: JCR Reporter: Julian Sedding Attachments: symlinks.patch I have implemented a ResourceProvider, which allows to create symlink nodes in the JCR repository. A symlink node has a sling:symlinkTarget property, which should contain a valid JCR path. JCR content from the sling:symlinkTarget path is then exposed below the symlink node. There is a mixin node type, sling:Symlink with a mandatory property sling:symlinkTarget and an optional property sling:overlayable. Additionally, there is a convenience node type, sling:SymlinkResource, which extends from sling:symlinkTarget and nt:unstructured. ResourceProvider instances are registered for existing symlinks when the bundle is started. Modifications are taken care of via JCR observation. To get started: * apply the attached patch to a trunk checkout * build and install the bundle * create a symlink node, pointing to some existing content * access the symlink node e.g. via a browser -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1780) check_staged_release.sh gives BAD md5/sha1 on macosx
[ https://issues.apache.org/jira/browse/SLING-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910212#action_12910212 ] Bertrand Delacretaz commented on SLING-1780: Refactored the script in revision 997819, also displays the digests if they differ: gpg: GOOD md5 : BAD!! : b4d1e4b7d4f80d990320e48f186ace79 not equal to (stdin)= b4d1e4b7d4f80d990320e48f186ace79 sha1 : BAD!! : 236278d6ee804a04ec4df37beaed0aebc1d99077 not equal to (stdin)= 236278d6ee804a04ec4df37beaed0aebc1d99077 Bugfix in next revision... check_staged_release.sh gives BAD md5/sha1 on macosx Key: SLING-1780 URL: https://issues.apache.org/jira/browse/SLING-1780 Project: Sling Issue Type: Bug Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor With the 039 staged release on my fully updated macosx 10.6.4 system I get BAD md5/sha1 as openssl adds (stdin) to its output: $ cat org.apache.sling.install.fileinstall-1.0.0.jar.md5 ; echo d903fcea9bf63e8f463b87d837bea540 $ openssl md5 org.apache.sling.install.fileinstall-1.0.0.jar (stdin)= d903fcea9bf63e8f463b87d837bea540 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-1786) Integration tests for authentication
Integration tests for authentication Key: SLING-1786 URL: https://issues.apache.org/jira/browse/SLING-1786 Project: Sling Issue Type: Test Components: Authentication Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz There's been a number of changes to the auth stuff lately, which probably require more integration testing. For now, please link issues related to such changes to this one, so that we can find out which tests are needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-1798) Test enum exported from a bundle in a JSP script
Test enum exported from a bundle in a JSP script Key: SLING-1798 URL: https://issues.apache.org/jira/browse/SLING-1798 Project: Sling Issue Type: Test Components: Scripting Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Users of our Sling-based product have reported Illegal type in constant pool errors when using enums in JSPs, add some tests to verify that enums exported from a bundle work correctly in a JSP script. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1798) Test enum exported from a bundle in a JSP script
[ https://issues.apache.org/jira/browse/SLING-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-1798. Fix Version/s: Launchpad Testing 6 Resolution: Fixed Tests added in revision 1000497 Test enum exported from a bundle in a JSP script Key: SLING-1798 URL: https://issues.apache.org/jira/browse/SLING-1798 Project: Sling Issue Type: Test Components: Scripting Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Fix For: Launchpad Testing 6 Users of our Sling-based product have reported Illegal type in constant pool errors when using enums in JSPs, add some tests to verify that enums exported from a bundle work correctly in a JSP script. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-1809) Eclipse compiler used commons.compiler causes Illegal type in constant pool with enums
Eclipse compiler used commons.compiler causes Illegal type in constant pool
with enums
Key: SLING-1809
URL: https://issues.apache.org/jira/browse/SLING-1809
Project: Sling
Issue Type: Bug
Components: Commons
Affects Versions: Commons Compiler 2.0.0
Reporter: Bertrand Delacretaz
According to [0] the eclipse compiler can't handle enums in certain
environments.
The trunk org.apache.sling.commons.compiler bundle embeds (eclipse-jdt)
core-3.3.0-v_771.jar which exposes this issue.
According to [0] the issue should be fixed in v3.5.2, but the central Maven
repository does not provide a more recent version than the one we currently use.
To reproduce the problem, install the compiler and java scripting bundle and
create a scripted java servlet that uses enums (example below), at runtime this
causes:
java.lang.VerifyError:
(class: enumtest/EnumTest, method: valueOf signature:
(Ljava/lang/String;)Lenumtest/EnumTest;)
Illegal type in constant pool
[0] https://bugs.eclipse.org/bugs/show_bug.cgi?id=291985
Here's the example servlet, store in
/apps/JavaScriptingTest2/JavaScriptingTest2.java and use JavaScriptingTest2
resource type:
package apps.JavaScriptingTest2;
import javax.servlet.http.*;
import java.io.IOException;
public class JavaScriptingTest2 extends HttpServlet {
static enum EnumTest { FOO, BAR };
public void doGet(HttpServletRequest req, HttpServletResponse resp) throws
IOException {
resp.getWriter().write(FOO= + EnumTest.FOO);
}
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1809) Eclipse compiler used in commons.compiler causes Illegal type in constant pool with enums
[
https://issues.apache.org/jira/browse/SLING-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz updated SLING-1809:
---
Summary: Eclipse compiler used in commons.compiler causes Illegal type in
constant pool with enums (was: Eclipse compiler used commons.compiler causes
Illegal type in constant pool with enums)
Eclipse compiler used in commons.compiler causes Illegal type in constant
pool with enums
---
Key: SLING-1809
URL: https://issues.apache.org/jira/browse/SLING-1809
Project: Sling
Issue Type: Bug
Components: Commons
Affects Versions: Commons Compiler 2.0.0
Reporter: Bertrand Delacretaz
According to [0] the eclipse compiler can't handle enums in certain
environments.
The trunk org.apache.sling.commons.compiler bundle embeds (eclipse-jdt)
core-3.3.0-v_771.jar which exposes this issue.
According to [0] the issue should be fixed in v3.5.2, but the central Maven
repository does not provide a more recent version than the one we currently
use.
To reproduce the problem, install the compiler and java scripting bundle and
create a scripted java servlet that uses enums (example below), at runtime
this causes:
java.lang.VerifyError:
(class: enumtest/EnumTest, method: valueOf signature:
(Ljava/lang/String;)Lenumtest/EnumTest;)
Illegal type in constant pool
[0] https://bugs.eclipse.org/bugs/show_bug.cgi?id=291985
Here's the example servlet, store in
/apps/JavaScriptingTest2/JavaScriptingTest2.java and use JavaScriptingTest2
resource type:
package apps.JavaScriptingTest2;
import javax.servlet.http.*;
import java.io.IOException;
public class JavaScriptingTest2 extends HttpServlet {
static enum EnumTest { FOO, BAR };
public void doGet(HttpServletRequest req, HttpServletResponse resp)
throws IOException {
resp.getWriter().write(FOO= + EnumTest.FOO);
}
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1809) Eclipse compiler used in commons.compiler causes Illegal type in constant pool with enums
[
https://issues.apache.org/jira/browse/SLING-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12915326#action_12915326
]
Bertrand Delacretaz commented on SLING-1809:
The tycho project seems to provide a more recent version of the compiler:
dependency
groupIdorg.sonatype.tycho/groupId
artifactIdorg.eclipse.jdt.core/artifactId
version3.6.0.v_A58/version
/dependency
Eclipse compiler used in commons.compiler causes Illegal type in constant
pool with enums
---
Key: SLING-1809
URL: https://issues.apache.org/jira/browse/SLING-1809
Project: Sling
Issue Type: Bug
Components: Commons
Affects Versions: Commons Compiler 2.0.0
Reporter: Bertrand Delacretaz
According to [0] the eclipse compiler can't handle enums in certain
environments.
The trunk org.apache.sling.commons.compiler bundle embeds (eclipse-jdt)
core-3.3.0-v_771.jar which exposes this issue.
According to [0] the issue should be fixed in v3.5.2, but the central Maven
repository does not provide a more recent version than the one we currently
use.
To reproduce the problem, install the compiler and java scripting bundle and
create a scripted java servlet that uses enums (example below), at runtime
this causes:
java.lang.VerifyError:
(class: enumtest/EnumTest, method: valueOf signature:
(Ljava/lang/String;)Lenumtest/EnumTest;)
Illegal type in constant pool
[0] https://bugs.eclipse.org/bugs/show_bug.cgi?id=291985
Here's the example servlet, store in
/apps/JavaScriptingTest2/JavaScriptingTest2.java and use JavaScriptingTest2
resource type:
package apps.JavaScriptingTest2;
import javax.servlet.http.*;
import java.io.IOException;
public class JavaScriptingTest2 extends HttpServlet {
static enum EnumTest { FOO, BAR };
public void doGet(HttpServletRequest req, HttpServletResponse resp)
throws IOException {
resp.getWriter().write(FOO= + EnumTest.FOO);
}
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SLING-1817) switch HTTP Basic Authentication completely off by default
[ https://issues.apache.org/jira/browse/SLING-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz reopened SLING-1817: This is a backwards incompatible change that requires a vote a discussion, please revert your changes until we vote on this. switch HTTP Basic Authentication completely off by default -- Key: SLING-1817 URL: https://issues.apache.org/jira/browse/SLING-1817 Project: Sling Issue Type: Improvement Components: Authentication Affects Versions: Auth Core 1.0.2 Reporter: Mike Müller Assignee: Mike Müller Priority: Minor Fix For: Auth Core 1.0.4 As of SLING-1765 it would be better to switch HTTP Basic Auth completly off by default. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (SLING-1817) switch HTTP Basic Authentication completely off by default
[ https://issues.apache.org/jira/browse/SLING-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12917897#action_12917897 ] Bertrand Delacretaz edited comment on SLING-1817 at 10/5/10 4:23 AM: - This is a backwards incompatible change that requires a discussion and vote, please revert your changes until we vote on this. was (Author: bdelacretaz): This is a backwards incompatible change that requires a vote a discussion, please revert your changes until we vote on this. switch HTTP Basic Authentication completely off by default -- Key: SLING-1817 URL: https://issues.apache.org/jira/browse/SLING-1817 Project: Sling Issue Type: Improvement Components: Authentication Affects Versions: Auth Core 1.0.2 Reporter: Mike Müller Assignee: Mike Müller Priority: Minor Fix For: Auth Core 1.0.4 As of SLING-1765 it would be better to switch HTTP Basic Auth completly off by default. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-1852) bgservlets extension should use Sling's ThreadPool
bgservlets extension should use Sling's ThreadPool -- Key: SLING-1852 URL: https://issues.apache.org/jira/browse/SLING-1852 Project: Sling Issue Type: Bug Components: Extensions Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor The ExecutionEngineImpl in the contrib/extensions/bgservlets module uses a plain Executor, it should use Sling's ThreadPoolManager instead. That module's ModifiableThreadPoolConfig can be used to customize the pool, which is created via ThreadPoolManager.create(ThreadPoolConfig config, String label); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-1853) bgservlets extension fails with multipart form requests
bgservlets extension fails with multipart form requests --- Key: SLING-1853 URL: https://issues.apache.org/jira/browse/SLING-1853 Project: Sling Issue Type: Bug Components: Extensions Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor curl -F title=foo2 -Fsling:bg=true http://admin:ad...@localhost:8080/foo; fails, but curl -X POST http://admin:ad...@localhost:8080/foo?sling:bg=truetitle=foo3; succeeds -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1438) GSoC 2010: create a mini-CMS to demonstrate Sling
[ https://issues.apache.org/jira/browse/SLING-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12966563#action_12966563 ] Bertrand Delacretaz commented on SLING-1438: I finally found time to look at this to see if we can commit it alongside the Sling samples. The following licenses, mentioned in 3rdparty.txt, are not ok for redistribution with Apache projects [1], so we cannot commit the code as is: WP-Cumulus SWF : GPL v3 license - http://wordpress.org/extend/plugins/wp-cumulus/ iText : AGPL v3 license - http://itextpdf.com/terms-of-use/index.php Does it make sense to create a version of the mini-CMS that doesn't use these tools? [1] http://www.apache.org/legal/resolved.html GSoC 2010: create a mini-CMS to demonstrate Sling - Key: SLING-1438 URL: https://issues.apache.org/jira/browse/SLING-1438 Project: Sling Issue Type: Task Components: Documentation Reporter: Bertrand Delacretaz Assignee: Federico Paparoni Attachments: david.rar, david16092010.zip This is a suggested project for Google Summer of Code 2010. The goal is to create a mini-CMS with Sling, that demonstrates Sling best practices. The emphasis is on the quality and readability of the demo code, and we expect to have to go through several iterations to refine it and the corresponding JCR content model so that they demonstrate Sling best practices. We will not necessarily create a full-fledged CMS, the goal is for the result to be educational and help Sling newcomers understand how to create web applications with it. Suggested technologies: jQuery for the front-end, ESP and/or JSP for server-side scripting, and Java code in OSGi bundles for back-end functionality. See http://tinyurl.com/asfgsoc for the full list of GSoC 2010 projects at the ASF, and http://community.apache.org/gsoc for general GSoC information. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1884) Bgservlets extension: job says QUEUED even if running after creation
[ https://issues.apache.org/jira/browse/SLING-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-1884. Resolution: Fixed Fixed in revision 1042649 Bgservlets extension: job says QUEUED even if running after creation Key: SLING-1884 URL: https://issues.apache.org/jira/browse/SLING-1884 Project: Sling Issue Type: Bug Components: Extensions Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor After starting a background servlet job, its status stays QUEUED even though it is actually running. After suspending and resuming, the state correctly says RUNNING. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-1887) Slingbucks sample
Slingbucks sample - Key: SLING-1887 URL: https://issues.apache.org/jira/browse/SLING-1887 Project: Sling Issue Type: New Feature Components: Samples Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor I'll contribute the Slingbucks sample used in my ApacheCon presentation http://www.slideshare.net/bdelacretaz/restful-slingbdelacretaz2010 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1887) Slingbucks sample
[ https://issues.apache.org/jira/browse/SLING-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-1887. Resolution: Fixed Sample added in revision 1043087 and 1043089 Slingbucks sample - Key: SLING-1887 URL: https://issues.apache.org/jira/browse/SLING-1887 Project: Sling Issue Type: New Feature Components: Samples Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor I'll contribute the Slingbucks sample used in my ApacheCon presentation http://www.slideshare.net/bdelacretaz/restful-slingbdelacretaz2010 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1899) JcrResourceResolver map method is not reverse operation of resolve method with special chars in path
[ https://issues.apache.org/jira/browse/SLING-1899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12972493#action_12972493 ] Bertrand Delacretaz commented on SLING-1899: I like Carsten's proposal - it's important to keep backwards compatibility, but the current map method does too much. I'd like to add (and you see me coming ;-) that we should make sure we have automated tests for the existing behavior before changing it. JcrResourceResolver map method is not reverse operation of resolve method with special chars in path Key: SLING-1899 URL: https://issues.apache.org/jira/browse/SLING-1899 Project: Sling Issue Type: Bug Components: JCR Affects Versions: JCR Resource 2.0.6 Reporter: Stefan Seifert Attachments: 101216_mapresolv_specialchars_fix.patch, 101216_mapresolve_specialchars_test.patch according to the javadocs of the ResourceResolver API interface, the map method is intended as the reverse operation of the resolve method. this is not the case if the path contains special chars like spaces - they are url-encoded, although the javadocs of the API does not require this. additionally the resolve method does not url-decode the path (which is correct in my opinion because the servlet engine already decodes the path). the map method should be fixed, so that not url-encoding takes place in it. the application is responsible for url-encoding a path if needed, not the sling api. i've attached a patch which contains a simple unit tests that makes the current implementation fail when resolving a path generated with the map method: [^101216_mapresolve_specialchars_test.patch] -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1900) launchpad/installer uses old OSGi installer dependency
[ https://issues.apache.org/jira/browse/SLING-1900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-1900. Resolution: Fixed Fixed in launchpad/installer and launchpad/builder launchpad/installer uses old OSGi installer dependency -- Key: SLING-1900 URL: https://issues.apache.org/jira/browse/SLING-1900 Project: Sling Issue Type: Bug Components: Launchpad Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz org.apache.sling.osgi.installer is now org.apache.sling.installer.core -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-1901) Integration test for LaunchpadConfigInstaller
Integration test for LaunchpadConfigInstaller - Key: SLING-1901 URL: https://issues.apache.org/jira/browse/SLING-1901 Project: Sling Issue Type: Test Components: Testing Affects Versions: Launchpad App 5 Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Add basic launchpad/integration-tests to verify the installation of a config at startup -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1901) Integration test for LaunchpadConfigInstaller
[ https://issues.apache.org/jira/browse/SLING-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-1901. Resolution: Fixed Fix Version/s: Launchpad Testing 6 Test added in revision 1052489 Integration test for LaunchpadConfigInstaller - Key: SLING-1901 URL: https://issues.apache.org/jira/browse/SLING-1901 Project: Sling Issue Type: Test Components: Testing Affects Versions: Launchpad App 5 Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Fix For: Launchpad Testing 6 Add basic launchpad/integration-tests to verify the installation of a config at startup -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-1902) Integration test for ResourceDecorator
Integration test for ResourceDecorator -- Key: SLING-1902 URL: https://issues.apache.org/jira/browse/SLING-1902 Project: Sling Issue Type: Test Components: Launchpad Affects Versions: Launchpad Test Services 2.0.6 Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Add integration tests for ResourceDecorator services. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1902) Integration test for ResourceDecorator
[ https://issues.apache.org/jira/browse/SLING-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-1902. Resolution: Fixed Test added in revision 1053035 Integration test for ResourceDecorator -- Key: SLING-1902 URL: https://issues.apache.org/jira/browse/SLING-1902 Project: Sling Issue Type: Test Components: Launchpad Affects Versions: Launchpad Test Services 2.0.6 Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Add integration tests for ResourceDecorator services. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1803) add coverage reporting of integration tests
[ https://issues.apache.org/jira/browse/SLING-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-1803: --- Attachment: SLING-1803-1053340.patch I tried running this on trunk revision 1053340, and I had to apply the attached patch. I won't commit it now as there might be a way to avoid the optional dependency. The Drools rule change was needed to avoid an NPE when executing mvn directly from the launchpad/testing folder, but that might not make sense. Note also that the DavExIntegrationTest fails when running with both profiles mentioned in this issue, probably a classpath problem as the failure is: java.lang.NoSuchMethodError: javax.jcr.Session.getNode(Ljava/lang/String;)Ljavax/jcr/Node; at org.apache.sling.launchpad.webapp.integrationtest.DavExIntegrationTest.testReadNode(DavExIntegrationTest.java:60) I haven't investigated that failure. add coverage reporting of integration tests --- Key: SLING-1803 URL: https://issues.apache.org/jira/browse/SLING-1803 Project: Sling Issue Type: New Feature Components: Launchpad Reporter: Justin Edelson Assignee: Justin Edelson Attachments: SLING-1803-1053340.patch I've tried both emma and clover. Looks like emma is the right choice as it is a little more flexible in terms of breaking apart the instrumentation from the test execution. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-1903) JobStateChangeServlet throws JobStorageException for DONE jobs
JobStateChangeServlet throws JobStorageException for DONE jobs
--
Key: SLING-1903
URL: https://issues.apache.org/jira/browse/SLING-1903
Project: Sling
Issue Type: Bug
Components: Extensions
Reporter: Bertrand Delacretaz
Assignee: Bertrand Delacretaz
Trying to change the state of a DONE job causes a JobStorageException, as the
state cannot be changed anymore.
This is not consistent with other state changes which return JSON information
about the change - in this case that should be something like:
{
info:Requested state change,
desiredState:RUNNING,
path:/var/bg/jobs/2010/12/28/15/54/7,
currentState:DONE,
stateChanged:false
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-1904) JobStatus should indicate allowed state transitions
JobStatus should indicate allowed state transitions
---
Key: SLING-1904
URL: https://issues.apache.org/jira/browse/SLING-1904
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Bertrand Delacretaz
Assignee: Bertrand Delacretaz
Priority: Minor
The bgservlet module's JobStatus class should indicate which user-level
transitions are allowed based on the current job state.
A human user looking at a list of jobs can only request a subset of the {
RUNNING, SUSPENDED, STOPPED } states, JobStatus should indicate which ones of
those are allowed based on its current state.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1904) JobStatus should indicate allowed state transitions
[
https://issues.apache.org/jira/browse/SLING-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz resolved SLING-1904.
Resolution: Fixed
Implemented in revision 1053386
JobStatus should indicate allowed state transitions
---
Key: SLING-1904
URL: https://issues.apache.org/jira/browse/SLING-1904
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Bertrand Delacretaz
Assignee: Bertrand Delacretaz
Priority: Minor
The bgservlet module's JobStatus class should indicate which user-level
transitions are allowed based on the current job state.
A human user looking at a list of jobs can only request a subset of the {
RUNNING, SUSPENDED, STOPPED } states, JobStatus should indicate which ones of
those are allowed based on its current state.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-1345) Sling is not listed at http://projects.apache.org/
[ https://issues.apache.org/jira/browse/SLING-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz closed SLING-1345. -- Sling is not listed at http://projects.apache.org/ -- Key: SLING-1345 URL: https://issues.apache.org/jira/browse/SLING-1345 Project: Sling Issue Type: Bug Components: Documentation Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor We need to create a DOAP file, see http://projects.apache.org/create.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1345) Sling is not listed at http://projects.apache.org/
[ https://issues.apache.org/jira/browse/SLING-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-1345. Resolution: Fixed Assignee: Bertrand Delacretaz Has been fixed a while ago, http://projects.apache.org/projects/sling.html Sling is not listed at http://projects.apache.org/ -- Key: SLING-1345 URL: https://issues.apache.org/jira/browse/SLING-1345 Project: Sling Issue Type: Bug Components: Documentation Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor We need to create a DOAP file, see http://projects.apache.org/create.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1682) add osgi and jcr install into launchpad
[ https://issues.apache.org/jira/browse/SLING-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-1682. Resolution: Won't Fix Modules have been renamed to installer.* and included in launchpad add osgi and jcr install into launchpad --- Key: SLING-1682 URL: https://issues.apache.org/jira/browse/SLING-1682 Project: Sling Issue Type: Improvement Components: Launchpad Reporter: Justin Edelson Fix For: Launchpad Builder 6 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-920) Hudson continuous integration setup
[ https://issues.apache.org/jira/browse/SLING-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12983698#action_12983698 ] Bertrand Delacretaz commented on SLING-920: --- Added -PwarIntegrationTests to both sling-trunk-1.5 and sling-trunk-1.6 jobs. Hudson continuous integration setup --- Key: SLING-920 URL: https://issues.apache.org/jira/browse/SLING-920 Project: Sling Issue Type: Task Components: Testing Reporter: Bertrand Delacretaz Use this issue to record changes to the Hudson continuous environment setup at http://hudson.zones.apache.org/hudson/view/Sling/ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-1963) Support for server-side JUnit tests, injected in a running Sling instance
Support for server-side JUnit tests, injected in a running Sling instance - Key: SLING-1963 URL: https://issues.apache.org/jira/browse/SLING-1963 Project: Sling Issue Type: Improvement Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz I've been working on a prototype JUnit extension framework [1] that allows JUnit tests to be injected in a Sling instance, and executed via a test runner servlet. Tests are not yet OSGi-aware in the first prototype, but they are dynamically injected as exported classes in a bundle that points to them with a Test-Package header. Apart from that they are 100% normal JUnit3 or 4 tests. Next step is to use annotations to inject services in the tests, I'm thinking of something like @TestReference SlingRepository repository And maybe @Test @OptionalTest(requiredService=repository) public void someTest()... which would ignore the test if the repository service is not present. The prototype consists of two bundles: extension which is the test detection and runner services, and testbundle which provides a few example tests. To play with it, install the two bundles and access the test servlet at /system/sling/junit/ [1] http://svn.apache.org/repos/asf/sling/whiteboard/bdelacretaz/junit -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SLING-1963) Support for server-side JUnit tests, injected in a running Sling instance
[ https://issues.apache.org/jira/browse/SLING-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12988803#comment-12988803 ] Bertrand Delacretaz commented on SLING-1963: And BTW if would be easy to access OSGi services from the test bundle, using an Activator that stores the BundleContext and makes it available via a static variable. Support for server-side JUnit tests, injected in a running Sling instance - Key: SLING-1963 URL: https://issues.apache.org/jira/browse/SLING-1963 Project: Sling Issue Type: Improvement Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz I've been working on a prototype JUnit extension framework [1] that allows JUnit tests to be injected in a Sling instance, and executed via a test runner servlet. Tests are not yet OSGi-aware in the first prototype, but they are dynamically injected as exported classes in a bundle that points to them with a Test-Package header. Apart from that they are 100% normal JUnit3 or 4 tests. Next step is to use annotations to inject services in the tests, I'm thinking of something like @TestReference SlingRepository repository And maybe @Test @OptionalTest(requiredService=repository) public void someTest()... which would ignore the test if the repository service is not present. The prototype consists of two bundles: extension which is the test detection and runner services, and testbundle which provides a few example tests. To play with it, install the two bundles and access the test servlet at /system/sling/junit/ [1] http://svn.apache.org/repos/asf/sling/whiteboard/bdelacretaz/junit -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SLING-1963) Support for server-side JUnit tests, injected in a running Sling instance
[ https://issues.apache.org/jira/browse/SLING-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12989155#comment-12989155 ] Bertrand Delacretaz commented on SLING-1963: @TestReference annotation implemented in revision 1065993, see http://svn.apache.org/repos/asf/sling/whiteboard/bdelacretaz/junit/testbundle/src/main/java/org/apache/sling/extensions/junit/testbundle/tests/OsgiAwareTest.java for an example. Also changed the required bundle header that selects test classes to Sling-Test-Regexp, more flexible than a path. Support for server-side JUnit tests, injected in a running Sling instance - Key: SLING-1963 URL: https://issues.apache.org/jira/browse/SLING-1963 Project: Sling Issue Type: Improvement Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz I've been working on a prototype JUnit extension framework [1] that allows JUnit tests to be injected in a Sling instance, and executed via a test runner servlet. Tests are not yet OSGi-aware in the first prototype, but they are dynamically injected as exported classes in a bundle that points to them with a Test-Package header. Apart from that they are 100% normal JUnit3 or 4 tests. Next step is to use annotations to inject services in the tests, I'm thinking of something like @TestReference SlingRepository repository And maybe @Test @OptionalTest(requiredService=repository) public void someTest()... which would ignore the test if the repository service is not present. The prototype consists of two bundles: extension which is the test detection and runner services, and testbundle which provides a few example tests. To play with it, install the two bundles and access the test servlet at /system/sling/junit/ [1] http://svn.apache.org/repos/asf/sling/whiteboard/bdelacretaz/junit -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SLING-1963) Support for server-side JUnit tests, injected in a running Sling instance
[ https://issues.apache.org/jira/browse/SLING-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12990141#comment-12990141 ] Bertrand Delacretaz commented on SLING-1963: Here's an example of how to create a scripted test: $ curl -Fsling:resourceType=foo -F jcr:mixinTypes=sling:Test http://admin:admin@localhost:8080/content/test/foo $ cat /tmp/foo.txt.esp # Some comments first % if(Math.random() 0.5) out.print(Random fail!); % TEST_PASSED ^D $ curl -X MKCOL http://admin:admin@localhost:8080/apps/foo $ curl -T /tmp/foo.txt.esp http://admin:admin@localhost:8080/apps/foo/foo.txt.esp Refreshing /system/sling/junit should then show a failure of the content/test/foo.test.txt test about 50% of the time. Support for server-side JUnit tests, injected in a running Sling instance - Key: SLING-1963 URL: https://issues.apache.org/jira/browse/SLING-1963 Project: Sling Issue Type: Improvement Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz I've been working on a prototype JUnit extension framework [1] that allows JUnit tests to be injected in a Sling instance, and executed via a test runner servlet. Tests are not yet OSGi-aware in the first prototype, but they are dynamically injected as exported classes in a bundle that points to them with a Test-Package header. Apart from that they are 100% normal JUnit3 or 4 tests. Next step is to use annotations to inject services in the tests, I'm thinking of something like @TestReference SlingRepository repository And maybe @Test @OptionalTest(requiredService=repository) public void someTest()... which would ignore the test if the repository service is not present. The prototype consists of two bundles: extension which is the test detection and runner services, and testbundle which provides a few example tests. To play with it, install the two bundles and access the test servlet at /system/sling/junit/ [1] http://svn.apache.org/repos/asf/sling/whiteboard/bdelacretaz/junit -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SLING-1963) Support for server-side JUnit tests, injected in a running Sling instance
[ https://issues.apache.org/jira/browse/SLING-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12990549#comment-12990549 ] Bertrand Delacretaz commented on SLING-1963: In revision 1067171 the ScriptableTestsProvider only considers test nodes under /apps or /libs, for security reasons. This means that /content/test/foo won't work anymore as a test resource, to create an example test node use for example $ curl -Fsling:resourceType=foo -F jcr:mixinTypes=sling:Test http://admin:admin@localhost:8080/apps/foo/fooTestNode which also makes the MKCOL request unnecessary in the above example. Support for server-side JUnit tests, injected in a running Sling instance - Key: SLING-1963 URL: https://issues.apache.org/jira/browse/SLING-1963 Project: Sling Issue Type: Improvement Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz I've been working on a prototype JUnit extension framework [1] that allows JUnit tests to be injected in a Sling instance, and executed via a test runner servlet. Tests are not yet OSGi-aware in the first prototype, but they are dynamically injected as exported classes in a bundle that points to them with a Test-Package header. Apart from that they are 100% normal JUnit3 or 4 tests. Next step is to use annotations to inject services in the tests, I'm thinking of something like @TestReference SlingRepository repository And maybe @Test @OptionalTest(requiredService=repository) public void someTest()... which would ignore the test if the repository service is not present. The prototype consists of two bundles: extension which is the test detection and runner services, and testbundle which provides a few example tests. To play with it, install the two bundles and access the test servlet at /system/sling/junit/ [1] http://svn.apache.org/repos/asf/sling/whiteboard/bdelacretaz/junit -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SLING-1963) Support for server-side JUnit tests, injected in a running Sling instance
[ https://issues.apache.org/jira/browse/SLING-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12990586#comment-12990586 ] Bertrand Delacretaz commented on SLING-1963: Added basic HTML rendering and test selection in revision 1067200. I think tests should only executed on POST, as they might be costly. Right now GET both lists and executes the tests. Example URLs for test selection: http://localhost:8080/system/sling/junit/ http://localhost:8080/system/sling/junit/org.apache.sling.junit.scriptable.html http://localhost:8080/system/sling/junit/org.apache.sling.junit.scriptable.txt Support for server-side JUnit tests, injected in a running Sling instance - Key: SLING-1963 URL: https://issues.apache.org/jira/browse/SLING-1963 Project: Sling Issue Type: Improvement Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz I've been working on a prototype JUnit extension framework [1] that allows JUnit tests to be injected in a Sling instance, and executed via a test runner servlet. Tests are not yet OSGi-aware in the first prototype, but they are dynamically injected as exported classes in a bundle that points to them with a Test-Package header. Apart from that they are 100% normal JUnit3 or 4 tests. Next step is to use annotations to inject services in the tests, I'm thinking of something like @TestReference SlingRepository repository And maybe @Test @OptionalTest(requiredService=repository) public void someTest()... which would ignore the test if the repository service is not present. The prototype consists of two bundles: extension which is the test detection and runner services, and testbundle which provides a few example tests. To play with it, install the two bundles and access the test servlet at /system/sling/junit/ [1] http://svn.apache.org/repos/asf/sling/whiteboard/bdelacretaz/junit -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SLING-1974) Accept header issues in the Sling POST Servlet
[ https://issues.apache.org/jira/browse/SLING-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12992941#comment-12992941 ] Bertrand Delacretaz commented on SLING-1974: I much prefer Jukka's proposal to use server-side configured preferences. It's much more predictable than relying on the client ordering of the entries. We can simply add an ordered list of preferred content types to the post servlet configuration, and use those to resolve ties. Accept header issues in the Sling POST Servlet -- Key: SLING-1974 URL: https://issues.apache.org/jira/browse/SLING-1974 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Post 2.1.0 Reporter: Felix Meschberger Fix For: Servlets Post 2.1.2 Attachments: SLING-1974.patch As of SLING-1336 the Sling POST Servlet can interpret the Accept request header to select what response content type to render. Unfortunately that handling seems broken as for an Accept header like (as generated by FireFox with the JSONovich plugin installed) : Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8,application/json the JSON response might be selected but sometimes also text/html (we can observe both behaviours for different server platforms with our application). The Accept header should probably consider equivalent q values (as for text/html and application/json in the example) to solve the tie by selecting the first type list; thus text/html in this example. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (SLING-1973) [PATCH] XmlRenderer for JUnit module
[ https://issues.apache.org/jira/browse/SLING-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-1973. Resolution: Fixed Assignee: Bertrand Delacretaz Patch applied in revision 1069403, thanks for your contribution! [PATCH] XmlRenderer for JUnit module Key: SLING-1973 URL: https://issues.apache.org/jira/browse/SLING-1973 Project: Sling Issue Type: Improvement Components: Testing Reporter: Shay Thompson Assignee: Bertrand Delacretaz Priority: Minor Attachments: org.apache.sling.junit.impl.servlet.patch Original Estimate: 0h Remaining Estimate: 0h -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SLING-1963) Support for server-side JUnit tests, injected in a running Sling instance
[ https://issues.apache.org/jira/browse/SLING-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12993071#comment-12993071 ] Bertrand Delacretaz commented on SLING-1963: As discussed on list, moved the junit modules source to http://svn.apache.org/repos/asf/sling/trunk/testing/junit Note also that XML rendering is available, SLING-1973 Support for server-side JUnit tests, injected in a running Sling instance - Key: SLING-1963 URL: https://issues.apache.org/jira/browse/SLING-1963 Project: Sling Issue Type: Improvement Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz I've been working on a prototype JUnit extension framework [1] that allows JUnit tests to be injected in a Sling instance, and executed via a test runner servlet. Tests are not yet OSGi-aware in the first prototype, but they are dynamically injected as exported classes in a bundle that points to them with a Test-Package header. Apart from that they are 100% normal JUnit3 or 4 tests. Next step is to use annotations to inject services in the tests, I'm thinking of something like @TestReference SlingRepository repository And maybe @Test @OptionalTest(requiredService=repository) public void someTest()... which would ignore the test if the repository service is not present. The prototype consists of two bundles: extension which is the test detection and runner services, and testbundle which provides a few example tests. To play with it, install the two bundles and access the test servlet at /system/sling/junit/ [1] http://svn.apache.org/repos/asf/sling/whiteboard/bdelacretaz/junit -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (SLING-1981) Creating a sample that demonstrates our testing tools and techniques
Creating a sample that demonstrates our testing tools and techniques Key: SLING-1981 URL: https://issues.apache.org/jira/browse/SLING-1981 Project: Sling Issue Type: New Feature Components: Testing Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Although our Launchpad tests can be used as examples of how to test Sling applications, we should create a much simpler sample project that demonstrates the following testing tools and techniques: -Start a Sling instance and waiting for it to be ready -Run simple HTTP integration tests against that instance -Run server-side JUnit tests using @TestReference to access OSGi services (SLING-1963) -Run server-side scriptable tests (SLING-1963) The tests should run in the integration-tests phase of the Maven build. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SLING-1981) Create a sample that demonstrates our testing tools and techniques
[ https://issues.apache.org/jira/browse/SLING-1981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-1981: --- Summary: Create a sample that demonstrates our testing tools and techniques (was: Creating a sample that demonstrates our testing tools and techniques) Create a sample that demonstrates our testing tools and techniques -- Key: SLING-1981 URL: https://issues.apache.org/jira/browse/SLING-1981 Project: Sling Issue Type: New Feature Components: Testing Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Although our Launchpad tests can be used as examples of how to test Sling applications, we should create a much simpler sample project that demonstrates the following testing tools and techniques: -Start a Sling instance and waiting for it to be ready -Run simple HTTP integration tests against that instance -Run server-side JUnit tests using @TestReference to access OSGi services (SLING-1963) -Run server-side scriptable tests (SLING-1963) The tests should run in the integration-tests phase of the Maven build. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SLING-1981) Create a sample that demonstrates our testing tools and techniques
[ https://issues.apache.org/jira/browse/SLING-1981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-1981: --- Description: Although our Launchpad tests can be used as examples of how to test Sling applications, we should create a much simpler sample project that demonstrates the following testing tools and techniques: 1) Start a Sling instance and waiting for it to be ready 2) Run simple HTTP integration tests against that instance 3) Run server-side JUnit tests using @TestReference to access OSGi services (SLING-1963) 4) Run server-side scriptable tests (SLING-1963) The tests should run in the integration-tests phase of the Maven build. was: Although our Launchpad tests can be used as examples of how to test Sling applications, we should create a much simpler sample project that demonstrates the following testing tools and techniques: -Start a Sling instance and waiting for it to be ready -Run simple HTTP integration tests against that instance -Run server-side JUnit tests using @TestReference to access OSGi services (SLING-1963) -Run server-side scriptable tests (SLING-1963) The tests should run in the integration-tests phase of the Maven build. Create a sample that demonstrates our testing tools and techniques -- Key: SLING-1981 URL: https://issues.apache.org/jira/browse/SLING-1981 Project: Sling Issue Type: New Feature Components: Testing Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Although our Launchpad tests can be used as examples of how to test Sling applications, we should create a much simpler sample project that demonstrates the following testing tools and techniques: 1) Start a Sling instance and waiting for it to be ready 2) Run simple HTTP integration tests against that instance 3) Run server-side JUnit tests using @TestReference to access OSGi services (SLING-1963) 4) Run server-side scriptable tests (SLING-1963) The tests should run in the integration-tests phase of the Maven build. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SLING-1981) Create a sample that demonstrates our testing tools and techniques
[ https://issues.apache.org/jira/browse/SLING-1981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12995760#comment-12995760 ] Bertrand Delacretaz commented on SLING-1981: Revision 1071581 implements steps 1) and 2) and installs the additional bundles required for 3), but does not run the server-side tests yet. The Stanbol SNAPSHOT dependencies must be revision 1071577 or later. To test, run mvn clean install on the http://svn.apache.org/repos/asf/sling/trunk/testing/samples/test-tools module Create a sample that demonstrates our testing tools and techniques -- Key: SLING-1981 URL: https://issues.apache.org/jira/browse/SLING-1981 Project: Sling Issue Type: New Feature Components: Testing Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Although our Launchpad tests can be used as examples of how to test Sling applications, we should create a much simpler sample project that demonstrates the following testing tools and techniques: -Start a Sling instance and waiting for it to be ready -Run simple HTTP integration tests against that instance -Run server-side JUnit tests using @TestReference to access OSGi services (SLING-1963) -Run server-side scriptable tests (SLING-1963) The tests should run in the integration-tests phase of the Maven build. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SLING-1981) Create a sample that demonstrates our testing tools and techniques
[ https://issues.apache.org/jira/browse/SLING-1981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-1981: --- Description: Although our Launchpad tests can be used as examples of how to test Sling applications, we should create a much simpler sample project that demonstrates the following testing tools and techniques: 1) Start a Sling instance and wait for it to be ready 2) Run simple HTTP integration tests against that instance 3) Run server-side JUnit tests using @TestReference to access OSGi services (SLING-1963) 4) Run server-side scriptable tests (SLING-1963) The tests should run in the integration-tests phase of the Maven build. was: Although our Launchpad tests can be used as examples of how to test Sling applications, we should create a much simpler sample project that demonstrates the following testing tools and techniques: 1) Start a Sling instance and waiting for it to be ready 2) Run simple HTTP integration tests against that instance 3) Run server-side JUnit tests using @TestReference to access OSGi services (SLING-1963) 4) Run server-side scriptable tests (SLING-1963) The tests should run in the integration-tests phase of the Maven build. Create a sample that demonstrates our testing tools and techniques -- Key: SLING-1981 URL: https://issues.apache.org/jira/browse/SLING-1981 Project: Sling Issue Type: New Feature Components: Testing Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Although our Launchpad tests can be used as examples of how to test Sling applications, we should create a much simpler sample project that demonstrates the following testing tools and techniques: 1) Start a Sling instance and wait for it to be ready 2) Run simple HTTP integration tests against that instance 3) Run server-side JUnit tests using @TestReference to access OSGi services (SLING-1963) 4) Run server-side scriptable tests (SLING-1963) The tests should run in the integration-tests phase of the Maven build. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (SLING-1984) [Patch] Support for running individual test method in junit module and integration with eclipse runner
[ https://issues.apache.org/jira/browse/SLING-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz reassigned SLING-1984: -- Assignee: Bertrand Delacretaz [Patch] Support for running individual test method in junit module and integration with eclipse runner -- Key: SLING-1984 URL: https://issues.apache.org/jira/browse/SLING-1984 Project: Sling Issue Type: Improvement Components: Testing Reporter: Pooja Kothari Assignee: Bertrand Delacretaz Priority: Minor Attachments: junit-patch -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SLING-1984) [Patch] Support for running individual test method in junit module and integration with eclipse runner
[
https://issues.apache.org/jira/browse/SLING-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12996465#comment-12996465
]
Bertrand Delacretaz commented on SLING-1984:
Thanks very much for this contribution, here are my comments after reviewing it
- I'll number my comments to make it easier to reply.
1. Can you confirm the use case? IIUC the goal is to allow executing tests from
an IDE - for example if you execute your RemoteJUnit4Test in your IDE, it runs
on a remote Sling instance and you get tests results in the IDE, exactly as if
the test ran locally.
Can you also debug the tests remotely when doing that?
2. I'd rather put those new classes in a separate junit remote module, to
keep the dependencies of the junit core module minimal, so that it can be
reused in other OSGi environments. No big deal, I could do that refactoring
after we apply your patch.
3. Using Logger instead of System.out or err is preferred (ExecutionRule.java)
4. Your patches to RequestInfo break the current navigation in tests, for
example currently a GET on /system/sling/junit/org.apache.foo.html selects all
test classes that start with org.apache.foo. I'd like to keep this, and use
request parameters only when absolutely required, which I think is the case for
selecting a method in a test class.
5. Do you think OUTPUT_FORMAT_PARAMETER is needed? The extension should be
sufficient to select the output format?
6. Why this change in JUnitServlet? I think it breaks things (and I should add
tests for said things ;-)
final String pi = request.getPathInfo();
-if(pi == null) {
+if(request.getParameterMap() == null) {
7. For us to apply the patch we need the Grant license to ASF for inclusion in
ASF works checkbox to be checked when uploading a patch - if you agree and are
allowed to do that, of course.
Don't be put off by the long list of comments!
I'm sure this can be very useful for people who use IDEs to run tests, but I
don't usually do that so I'll need to understand the context better - again
thanks, and feel free to discuss things on the Sling dev list if it's easier,
see
http://sling.apache.org/site/project-information.html#ProjectInformation-lists
[Patch] Support for running individual test method in junit module and
integration with eclipse runner
--
Key: SLING-1984
URL: https://issues.apache.org/jira/browse/SLING-1984
Project: Sling
Issue Type: Improvement
Components: Testing
Reporter: Pooja Kothari
Assignee: Bertrand Delacretaz
Priority: Minor
Attachments: junit-patch
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (SLING-1989) Windows line-ends in zip files if a Sling release is built on Windows
Windows line-ends in zip files if a Sling release is built on Windows - Key: SLING-1989 URL: https://issues.apache.org/jira/browse/SLING-1989 Project: Sling Issue Type: Improvement Reporter: Bertrand Delacretaz Priority: Minor See http://markmail.org/message/32rqy75djrtxlgcs - according to Justin we could fix this in the assembly descriptor -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SLING-1981) Create a sample that demonstrates our testing tools and techniques
[ https://issues.apache.org/jira/browse/SLING-1981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12997902#comment-12997902 ] Bertrand Delacretaz commented on SLING-1981: At revision 1073407 the sample runs server-side tests as part of the Maven build. Some tests fail by design as some of the testbundle tests fail all the time or randomly, to verify that failures are correctly reported - will need to find a way to handle that better in the Maven build, or maybe have the tests pass by default with a way of failing them manually. Create a sample that demonstrates our testing tools and techniques -- Key: SLING-1981 URL: https://issues.apache.org/jira/browse/SLING-1981 Project: Sling Issue Type: New Feature Components: Testing Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Although our Launchpad tests can be used as examples of how to test Sling applications, we should create a much simpler sample project that demonstrates the following testing tools and techniques: 1) Start a Sling instance and wait for it to be ready 2) Run simple HTTP integration tests against that instance 3) Run server-side JUnit tests using @TestReference to access OSGi services (SLING-1963) 4) Run server-side scriptable tests (SLING-1963) The tests should run in the integration-tests phase of the Maven build. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (SLING-1992) JUnitServlet should be replaceable
JUnitServlet should be replaceable -- Key: SLING-1992 URL: https://issues.apache.org/jira/browse/SLING-1992 Project: Sling Issue Type: Improvement Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor The JUnitServlet of the testing/junit/core module should be replaceable, which means: -Factoring out the actual test selection, listing and execution logic in a separate service -Allowing for disabling the servlet or mounting it under a different path, by configuration -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SLING-1992) JUnitServlet should be replaceable
[ https://issues.apache.org/jira/browse/SLING-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-1992: --- Labels: integration-tests junit testing (was: ) JUnitServlet should be replaceable -- Key: SLING-1992 URL: https://issues.apache.org/jira/browse/SLING-1992 Project: Sling Issue Type: Improvement Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Labels: integration-tests, junit, testing The JUnitServlet of the testing/junit/core module should be replaceable, which means: -Factoring out the actual test selection, listing and execution logic in a separate service -Allowing for disabling the servlet or mounting it under a different path, by configuration -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SLING-1981) Create a sample that demonstrates our testing tools and techniques
[ https://issues.apache.org/jira/browse/SLING-1981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-1981: --- Labels: integration-tests junit testing (was: ) Create a sample that demonstrates our testing tools and techniques -- Key: SLING-1981 URL: https://issues.apache.org/jira/browse/SLING-1981 Project: Sling Issue Type: New Feature Components: Testing Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Labels: integration-tests, junit, testing Although our Launchpad tests can be used as examples of how to test Sling applications, we should create a much simpler sample project that demonstrates the following testing tools and techniques: 1) Start a Sling instance and wait for it to be ready 2) Run simple HTTP integration tests against that instance 3) Run server-side JUnit tests using @TestReference to access OSGi services (SLING-1963) 4) Run server-side scriptable tests (SLING-1963) The tests should run in the integration-tests phase of the Maven build. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SLING-1963) Support for server-side JUnit tests, injected in a running Sling instance
[ https://issues.apache.org/jira/browse/SLING-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-1963: --- Labels: integration-tests junit testing (was: ) Support for server-side JUnit tests, injected in a running Sling instance - Key: SLING-1963 URL: https://issues.apache.org/jira/browse/SLING-1963 Project: Sling Issue Type: Improvement Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Labels: integration-tests, junit, testing I've been working on a prototype JUnit extension framework [1] that allows JUnit tests to be injected in a Sling instance, and executed via a test runner servlet. Tests are not yet OSGi-aware in the first prototype, but they are dynamically injected as exported classes in a bundle that points to them with a Test-Package header. Apart from that they are 100% normal JUnit3 or 4 tests. Next step is to use annotations to inject services in the tests, I'm thinking of something like @TestReference SlingRepository repository And maybe @Test @OptionalTest(requiredService=repository) public void someTest()... which would ignore the test if the repository service is not present. The prototype consists of two bundles: extension which is the test detection and runner services, and testbundle which provides a few example tests. To play with it, install the two bundles and access the test servlet at /system/sling/junit/ [1] http://svn.apache.org/repos/asf/sling/whiteboard/bdelacretaz/junit -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (SLING-1992) JUnitServlet should be replaceable
[ https://issues.apache.org/jira/browse/SLING-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-1992. Resolution: Fixed JUnitServlet is now a simple wrapper on the TestsManager service. The servlet can be disabled by configuration, and implementing an alternate servlet should be easy. JUnitServlet should be replaceable -- Key: SLING-1992 URL: https://issues.apache.org/jira/browse/SLING-1992 Project: Sling Issue Type: Improvement Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Labels: integration-tests, junit, testing The JUnitServlet of the testing/junit/core module should be replaceable, which means: -Factoring out the actual test selection, listing and execution logic in a separate service -Allowing for disabling the servlet or mounting it under a different path, by configuration -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (SLING-1993) Use annotations instead of @scr tags in launchpad/test-services and launchpad/test-services-war
Use annotations instead of @scr tags in launchpad/test-services and launchpad/test-services-war --- Key: SLING-1993 URL: https://issues.apache.org/jira/browse/SLING-1993 Project: Sling Issue Type: Improvement Components: Testing Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Those modules still use @scr tags, move them to SCR annotations -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (SLING-1996) Create a sample framework extension bundle that causes additional JVM packages to be exported
Create a sample framework extension bundle that causes additional JVM packages to be exported - Key: SLING-1996 URL: https://issues.apache.org/jira/browse/SLING-1996 Project: Sling Issue Type: New Feature Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz People are often asking how to do that, changing sling.properties to export additional packages is not convenient and using a framework extension bundle is more flexible. Create a sample that shows how to do this. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (SLING-1996) Create a sample framework extension bundle that causes additional JVM packages to be exported
[ https://issues.apache.org/jira/browse/SLING-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-1996. Resolution: Fixed Sample implemented, it's really only a pom.xml file, see http://svn.apache.org/repos/asf/sling/trunk/samples/framework-fragment/pom.xml Create a sample framework extension bundle that causes additional JVM packages to be exported - Key: SLING-1996 URL: https://issues.apache.org/jira/browse/SLING-1996 Project: Sling Issue Type: New Feature Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz People are often asking how to do that, changing sling.properties to export additional packages is not convenient and using a framework extension bundle is more flexible. Create a sample that shows how to do this. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SLING-1996) Create a sample framework extension bundle that causes additional JVM packages to be exported
[ https://issues.apache.org/jira/browse/SLING-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12999430#comment-12999430 ] Bertrand Delacretaz commented on SLING-1996: Ah - thanks for the pointer ;-) Create a sample framework extension bundle that causes additional JVM packages to be exported - Key: SLING-1996 URL: https://issues.apache.org/jira/browse/SLING-1996 Project: Sling Issue Type: New Feature Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz People are often asking how to do that, changing sling.properties to export additional packages is not convenient and using a framework extension bundle is more flexible. Create a sample that shows how to do this. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SLING-1984) [Patch] Support for running individual test method in junit module and integration with eclipse runner
[ https://issues.apache.org/jira/browse/SLING-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12999447#comment-12999447 ] Bertrand Delacretaz commented on SLING-1984: Revision 1074632 contains this feature, largely based on your code but adapted to the current state of the testing tools. With this I've been able to run the ExampleRemoteTest [1] remotely from Eclipse, by starting a Sling instance with all the bundles from sling/testing active, and setting this system property in Eclipse when running the tests: -Dsling.remote.test.url=http://localhost:8080/system/sling/junit/ Please cross-check and again thanks for your contribution! [Patch] Support for running individual test method in junit module and integration with eclipse runner -- Key: SLING-1984 URL: https://issues.apache.org/jira/browse/SLING-1984 Project: Sling Issue Type: Improvement Components: Testing Reporter: Pooja Kothari Assignee: Bertrand Delacretaz Priority: Minor Attachments: junit-patch, patch.txt -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SLING-1984) [Patch] Support for running individual test method in junit module and integration with eclipse runner
[ https://issues.apache.org/jira/browse/SLING-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12999448#comment-12999448 ] Bertrand Delacretaz commented on SLING-1984: Forgot the URL: [1] http://svn.apache.org/repos/asf/sling/trunk/testing/junit/remote/src/main/java/org/apache/sling/junit/remote/exported/ExampleRemoteTest.java [Patch] Support for running individual test method in junit module and integration with eclipse runner -- Key: SLING-1984 URL: https://issues.apache.org/jira/browse/SLING-1984 Project: Sling Issue Type: Improvement Components: Testing Reporter: Pooja Kothari Assignee: Bertrand Delacretaz Priority: Minor Attachments: junit-patch, patch.txt -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SLING-2001) Sample Integration tests are failing
[ https://issues.apache.org/jira/browse/SLING-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13000334#comment-13000334 ] Bertrand Delacretaz commented on SLING-2001: A full build of the testing subtree on revision 1075373 with Apache Maven 3.0.2 (r1056850; 2011-01-09 01:58:10+0100) Java version: 1.5.0_19, vendor: Apple Inc. works for me, can you try again (it failed earlier this afternoon), can you try again with this revision? Sample Integration tests are failing Key: SLING-2001 URL: https://issues.apache.org/jira/browse/SLING-2001 Project: Sling Issue Type: Bug Components: Testing Environment: $ mvn -v Apache Maven 3.0.2 (r1056850; 2011-01-09 01:58:10+0100) Java version: 1.5.0_21, vendor: Sun Microsystems Inc. Java home: /usr/java/jdk1.5.0_21/jre Default locale: de_CH, platform encoding: UTF-8 OS name: linux, version: 2.6.35-25-generic, arch: amd64, family: unix Reporter: Felix Meschberger Attachments: org.apache.sling.testing.samples.testtools.http.OsgiConsoleTest.txt, org.apache.sling.testing.samples.testtools.serverside.FailingTestsTest.txt, org.apache.sling.testing.samples.testtools.serverside.JSONResponseTest.txt, org.apache.sling.testing.samples.testtools.serverside.ServerSideSampleTest.txt, org.apache.sling.testing.samples.testtools.serverside.SingleServerSideMethodTest.txt Running a trunk build aborts in the Sample Integration tests: Failed tests: initializationError(org.apache.sling.testing.samples.testtools.serverside.ServerSideSampleTest) testWithRetries(org.apache.sling.testing.samples.testtools.serverside.JSONResponseTest) testSomeConsolePaths(org.apache.sling.testing.samples.testtools.http.OsgiConsoleTest) initializationError(org.apache.sling.testing.samples.testtools.serverside.SingleServerSideMethodTest) testFailures(org.apache.sling.testing.samples.testtools.serverside.FailingTestsTest) Will attach the surefire data files -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SLING-2001) Sample Integration tests are failing
[ https://issues.apache.org/jira/browse/SLING-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13000357#comment-13000357 ] Bertrand Delacretaz commented on SLING-2001: Might be a timing problem: the test code installs and starts 5 additional bundles one after the other, without considering their dependencies. If the junit core bundle is installed last, for example, the others will not start. If that hypothesis is right, I'll need to either loop starting all newly installed bundles until they all start, or consider their dependencies when installing them. Sample Integration tests are failing Key: SLING-2001 URL: https://issues.apache.org/jira/browse/SLING-2001 Project: Sling Issue Type: Bug Components: Testing Environment: $ mvn -v Apache Maven 3.0.2 (r1056850; 2011-01-09 01:58:10+0100) Java version: 1.5.0_21, vendor: Sun Microsystems Inc. Java home: /usr/java/jdk1.5.0_21/jre Default locale: de_CH, platform encoding: UTF-8 OS name: linux, version: 2.6.35-25-generic, arch: amd64, family: unix Reporter: Felix Meschberger Attachments: org.apache.sling.testing.samples.testtools.http.OsgiConsoleTest.txt, org.apache.sling.testing.samples.testtools.serverside.FailingTestsTest.txt, org.apache.sling.testing.samples.testtools.serverside.JSONResponseTest.txt, org.apache.sling.testing.samples.testtools.serverside.ServerSideSampleTest.txt, org.apache.sling.testing.samples.testtools.serverside.SingleServerSideMethodTest.txt Running a trunk build aborts in the Sample Integration tests: Failed tests: initializationError(org.apache.sling.testing.samples.testtools.serverside.ServerSideSampleTest) testWithRetries(org.apache.sling.testing.samples.testtools.serverside.JSONResponseTest) testSomeConsolePaths(org.apache.sling.testing.samples.testtools.http.OsgiConsoleTest) initializationError(org.apache.sling.testing.samples.testtools.serverside.SingleServerSideMethodTest) testFailures(org.apache.sling.testing.samples.testtools.serverside.FailingTestsTest) Will attach the surefire data files -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SLING-2001) Sample Integration tests are failing
[ https://issues.apache.org/jira/browse/SLING-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13000365#comment-13000365 ] Bertrand Delacretaz commented on SLING-2001: It's a bundle ordering problem actually, added sorting of additional bundles to install in revision 1075401 With the reverse sort the tests fail on my macos box, so I guess that's what happened on Felix's linux box. Revision 1075401 should work on your box as well but that's by chance, as ordering the bundles by name in our case causes junit.core to be installed first. I'll add some code to loop starting all bundles after they are all installed, to make sure this works whatever the inter-bundles dependencies are. Sample Integration tests are failing Key: SLING-2001 URL: https://issues.apache.org/jira/browse/SLING-2001 Project: Sling Issue Type: Bug Components: Testing Environment: $ mvn -v Apache Maven 3.0.2 (r1056850; 2011-01-09 01:58:10+0100) Java version: 1.5.0_21, vendor: Sun Microsystems Inc. Java home: /usr/java/jdk1.5.0_21/jre Default locale: de_CH, platform encoding: UTF-8 OS name: linux, version: 2.6.35-25-generic, arch: amd64, family: unix Reporter: Felix Meschberger Attachments: org.apache.sling.testing.samples.testtools.http.OsgiConsoleTest.txt, org.apache.sling.testing.samples.testtools.serverside.FailingTestsTest.txt, org.apache.sling.testing.samples.testtools.serverside.JSONResponseTest.txt, org.apache.sling.testing.samples.testtools.serverside.ServerSideSampleTest.txt, org.apache.sling.testing.samples.testtools.serverside.SingleServerSideMethodTest.txt Running a trunk build aborts in the Sample Integration tests: Failed tests: initializationError(org.apache.sling.testing.samples.testtools.serverside.ServerSideSampleTest) testWithRetries(org.apache.sling.testing.samples.testtools.serverside.JSONResponseTest) testSomeConsolePaths(org.apache.sling.testing.samples.testtools.http.OsgiConsoleTest) initializationError(org.apache.sling.testing.samples.testtools.serverside.SingleServerSideMethodTest) testFailures(org.apache.sling.testing.samples.testtools.serverside.FailingTestsTest) Will attach the surefire data files -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SLING-2001) Sample Integration tests are failing
[ https://issues.apache.org/jira/browse/SLING-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13000386#comment-13000386 ] Bertrand Delacretaz commented on SLING-2001: In revision 1075415 the additional bundles under test are installed in a defined order, set in the pom, where they are defined anyway. Assuming the webconsole starts a bundle synchronously when it's installed by a POST with bundlestart=true (Felix, can you confirm that?) this should now work in all environments. Please cross-check and close this issue if ok. Sample Integration tests are failing Key: SLING-2001 URL: https://issues.apache.org/jira/browse/SLING-2001 Project: Sling Issue Type: Bug Components: Testing Environment: $ mvn -v Apache Maven 3.0.2 (r1056850; 2011-01-09 01:58:10+0100) Java version: 1.5.0_21, vendor: Sun Microsystems Inc. Java home: /usr/java/jdk1.5.0_21/jre Default locale: de_CH, platform encoding: UTF-8 OS name: linux, version: 2.6.35-25-generic, arch: amd64, family: unix Reporter: Felix Meschberger Attachments: org.apache.sling.testing.samples.testtools.http.OsgiConsoleTest.txt, org.apache.sling.testing.samples.testtools.serverside.FailingTestsTest.txt, org.apache.sling.testing.samples.testtools.serverside.JSONResponseTest.txt, org.apache.sling.testing.samples.testtools.serverside.ServerSideSampleTest.txt, org.apache.sling.testing.samples.testtools.serverside.SingleServerSideMethodTest.txt Running a trunk build aborts in the Sample Integration tests: Failed tests: initializationError(org.apache.sling.testing.samples.testtools.serverside.ServerSideSampleTest) testWithRetries(org.apache.sling.testing.samples.testtools.serverside.JSONResponseTest) testSomeConsolePaths(org.apache.sling.testing.samples.testtools.http.OsgiConsoleTest) initializationError(org.apache.sling.testing.samples.testtools.serverside.SingleServerSideMethodTest) testFailures(org.apache.sling.testing.samples.testtools.serverside.FailingTestsTest) Will attach the surefire data files -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SLING-2001) Sample Integration tests fail due to unpredictable install order of additional bundles
[ https://issues.apache.org/jira/browse/SLING-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-2001: --- Assignee: Bertrand Delacretaz Summary: Sample Integration tests fail due to unpredictable install order of additional bundles (was: Sample Integration tests are failing) Sample Integration tests fail due to unpredictable install order of additional bundles -- Key: SLING-2001 URL: https://issues.apache.org/jira/browse/SLING-2001 Project: Sling Issue Type: Bug Components: Testing Environment: $ mvn -v Apache Maven 3.0.2 (r1056850; 2011-01-09 01:58:10+0100) Java version: 1.5.0_21, vendor: Sun Microsystems Inc. Java home: /usr/java/jdk1.5.0_21/jre Default locale: de_CH, platform encoding: UTF-8 OS name: linux, version: 2.6.35-25-generic, arch: amd64, family: unix Reporter: Felix Meschberger Assignee: Bertrand Delacretaz Attachments: org.apache.sling.testing.samples.testtools.http.OsgiConsoleTest.txt, org.apache.sling.testing.samples.testtools.serverside.FailingTestsTest.txt, org.apache.sling.testing.samples.testtools.serverside.JSONResponseTest.txt, org.apache.sling.testing.samples.testtools.serverside.ServerSideSampleTest.txt, org.apache.sling.testing.samples.testtools.serverside.SingleServerSideMethodTest.txt Running a trunk build aborts in the Sample Integration tests: Failed tests: initializationError(org.apache.sling.testing.samples.testtools.serverside.ServerSideSampleTest) testWithRetries(org.apache.sling.testing.samples.testtools.serverside.JSONResponseTest) testSomeConsolePaths(org.apache.sling.testing.samples.testtools.http.OsgiConsoleTest) initializationError(org.apache.sling.testing.samples.testtools.serverside.SingleServerSideMethodTest) testFailures(org.apache.sling.testing.samples.testtools.serverside.FailingTestsTest) Will attach the surefire data files -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SLING-2001) Sample Integration tests fail due to unpredictable install order of additional bundles
[ https://issues.apache.org/jira/browse/SLING-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13000784#comment-13000784 ] Bertrand Delacretaz commented on SLING-2001: I agree that installing all bundles first and starting them all next is best. Ideally the scenario with the webconsole would be: 1. POST to webconsole to install bundle 2. webconsole returns path of bundle resource 3. repeat for all bundles 4. POST to bundle resources to start them But I think at 2. the webconsole only redirects to /system/console/bundles, so I don't get a path to the bundle resource. Sample Integration tests fail due to unpredictable install order of additional bundles -- Key: SLING-2001 URL: https://issues.apache.org/jira/browse/SLING-2001 Project: Sling Issue Type: Bug Components: Testing Environment: $ mvn -v Apache Maven 3.0.2 (r1056850; 2011-01-09 01:58:10+0100) Java version: 1.5.0_21, vendor: Sun Microsystems Inc. Java home: /usr/java/jdk1.5.0_21/jre Default locale: de_CH, platform encoding: UTF-8 OS name: linux, version: 2.6.35-25-generic, arch: amd64, family: unix Reporter: Felix Meschberger Assignee: Bertrand Delacretaz Attachments: org.apache.sling.testing.samples.testtools.http.OsgiConsoleTest.txt, org.apache.sling.testing.samples.testtools.serverside.FailingTestsTest.txt, org.apache.sling.testing.samples.testtools.serverside.JSONResponseTest.txt, org.apache.sling.testing.samples.testtools.serverside.ServerSideSampleTest.txt, org.apache.sling.testing.samples.testtools.serverside.SingleServerSideMethodTest.txt Running a trunk build aborts in the Sample Integration tests: Failed tests: initializationError(org.apache.sling.testing.samples.testtools.serverside.ServerSideSampleTest) testWithRetries(org.apache.sling.testing.samples.testtools.serverside.JSONResponseTest) testSomeConsolePaths(org.apache.sling.testing.samples.testtools.http.OsgiConsoleTest) initializationError(org.apache.sling.testing.samples.testtools.serverside.SingleServerSideMethodTest) testFailures(org.apache.sling.testing.samples.testtools.serverside.FailingTestsTest) Will attach the surefire data files -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SLING-2002) Migrate the Sling website to the ASF CMS
[ https://issues.apache.org/jira/browse/SLING-2002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13000997#comment-13000997 ] Bertrand Delacretaz commented on SLING-2002: CMS staging has been setup at https://cms.apache.org/sling/ Migrate the Sling website to the ASF CMS Key: SLING-2002 URL: https://issues.apache.org/jira/browse/SLING-2002 Project: Sling Issue Type: Task Components: Site Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz As discussed at http://markmail.org/thread/vbdqqnbaghpcxwp5 I'll try the tools mentioned at http://wiki.apache.org/general/ApacheCms2010#Migrating_from_Confluence -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (SLING-2009) Webconsole install fails with Unable to acquire global lock for resolve
Webconsole install fails with Unable to acquire global lock for resolve - Key: SLING-2009 URL: https://issues.apache.org/jira/browse/SLING-2009 Project: Sling Issue Type: Bug Reporter: Bertrand Delacretaz The testing/samples/integration-tests module failed in Hudson build 1127 [1], due to the installation of the org.apache.sling.junit.core bundle failing with the below stack trace. The integration tests install those bundles as soon as the Sling server is up (checked by requesting a few URLs like / and /.explorer.html, see logs) - should that wait until the webconsole/OSGi framework is ready for new installs, and how to check this? [1] https://hudson.apache.org/hudson/view/S-Z/view/Sling/job/sling-trunk-1.5/1127/ Log excerpt (I'll attach the complete sling log): 01.03.2011 11:49:06.747 *INFO* [FelixDispatchQueue] org.apache.sling.junit.core BundleEvent INSTALLED 01.03.2011 11:49:06.752 *ERROR* [Background Install /tmp/install63068254848590030.tmp] org.apache.felix.http.jetty %bundles.pluginTitle: Cannot install or update bundle from /tmp/install63068254848590030.tmp (org.osgi.framework.BundleException: Unresolved constraint in bundle org.apache.sling.junit.core [72]: Unable to acquire global lock for resolve.) org.osgi.framework.BundleException: Unresolved constraint in bundle org.apache.sling.junit.core [72]: Unable to acquire global lock for resolve. at org.apache.felix.framework.Felix.resolveBundle(Felix.java:3443) at org.apache.felix.framework.Felix.startBundle(Felix.java:1727) at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:922) at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:909) at org.apache.felix.webconsole.internal.core.InstallHelper.doRun(InstallHelper.java:67) at org.apache.felix.webconsole.internal.core.BaseUpdateInstallHelper.doRun(BaseUpdateInstallHelper.java:89) at org.apache.felix.webconsole.internal.core.BaseUpdateInstallHelper.run(BaseUpdateInstallHelper.java:121) at java.lang.Thread.run(Thread.java:595) -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SLING-2009) Webconsole install fails with Unable to acquire global lock for resolve
[ https://issues.apache.org/jira/browse/SLING-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-2009: --- Attachment: error.log Sling log Webconsole install fails with Unable to acquire global lock for resolve - Key: SLING-2009 URL: https://issues.apache.org/jira/browse/SLING-2009 Project: Sling Issue Type: Bug Reporter: Bertrand Delacretaz Attachments: error.log The testing/samples/integration-tests module failed in Hudson build 1127 [1], due to the installation of the org.apache.sling.junit.core bundle failing with the below stack trace. The integration tests install those bundles as soon as the Sling server is up (checked by requesting a few URLs like / and /.explorer.html, see logs) - should that wait until the webconsole/OSGi framework is ready for new installs, and how to check this? [1] https://hudson.apache.org/hudson/view/S-Z/view/Sling/job/sling-trunk-1.5/1127/ Log excerpt (I'll attach the complete sling log): 01.03.2011 11:49:06.747 *INFO* [FelixDispatchQueue] org.apache.sling.junit.core BundleEvent INSTALLED 01.03.2011 11:49:06.752 *ERROR* [Background Install /tmp/install63068254848590030.tmp] org.apache.felix.http.jetty %bundles.pluginTitle: Cannot install or update bundle from /tmp/install63068254848590030.tmp (org.osgi.framework.BundleException: Unresolved constraint in bundle org.apache.sling.junit.core [72]: Unable to acquire global lock for resolve.) org.osgi.framework.BundleException: Unresolved constraint in bundle org.apache.sling.junit.core [72]: Unable to acquire global lock for resolve. at org.apache.felix.framework.Felix.resolveBundle(Felix.java:3443) at org.apache.felix.framework.Felix.startBundle(Felix.java:1727) at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:922) at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:909) at org.apache.felix.webconsole.internal.core.InstallHelper.doRun(InstallHelper.java:67) at org.apache.felix.webconsole.internal.core.BaseUpdateInstallHelper.doRun(BaseUpdateInstallHelper.java:89) at org.apache.felix.webconsole.internal.core.BaseUpdateInstallHelper.run(BaseUpdateInstallHelper.java:121) at java.lang.Thread.run(Thread.java:595) -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SLING-2009) Webconsole install fails with Unable to acquire global lock for resolve
[ https://issues.apache.org/jira/browse/SLING-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13001403#comment-13001403 ] Bertrand Delacretaz commented on SLING-2009: Similar issues have been reported in http://markmail.org/thread/wi6utz26tmfktkkk Webconsole install fails with Unable to acquire global lock for resolve - Key: SLING-2009 URL: https://issues.apache.org/jira/browse/SLING-2009 Project: Sling Issue Type: Bug Reporter: Bertrand Delacretaz Attachments: error.log The testing/samples/integration-tests module failed in Hudson build 1127 [1], due to the installation of the org.apache.sling.junit.core bundle failing with the below stack trace. The integration tests install those bundles as soon as the Sling server is up (checked by requesting a few URLs like / and /.explorer.html, see logs) - should that wait until the webconsole/OSGi framework is ready for new installs, and how to check this? [1] https://hudson.apache.org/hudson/view/S-Z/view/Sling/job/sling-trunk-1.5/1127/ Log excerpt (I'll attach the complete sling log): 01.03.2011 11:49:06.747 *INFO* [FelixDispatchQueue] org.apache.sling.junit.core BundleEvent INSTALLED 01.03.2011 11:49:06.752 *ERROR* [Background Install /tmp/install63068254848590030.tmp] org.apache.felix.http.jetty %bundles.pluginTitle: Cannot install or update bundle from /tmp/install63068254848590030.tmp (org.osgi.framework.BundleException: Unresolved constraint in bundle org.apache.sling.junit.core [72]: Unable to acquire global lock for resolve.) org.osgi.framework.BundleException: Unresolved constraint in bundle org.apache.sling.junit.core [72]: Unable to acquire global lock for resolve. at org.apache.felix.framework.Felix.resolveBundle(Felix.java:3443) at org.apache.felix.framework.Felix.startBundle(Felix.java:1727) at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:922) at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:909) at org.apache.felix.webconsole.internal.core.InstallHelper.doRun(InstallHelper.java:67) at org.apache.felix.webconsole.internal.core.BaseUpdateInstallHelper.doRun(BaseUpdateInstallHelper.java:89) at org.apache.felix.webconsole.internal.core.BaseUpdateInstallHelper.run(BaseUpdateInstallHelper.java:121) at java.lang.Thread.run(Thread.java:595) -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SLING-2009) Webconsole install fails with Unable to acquire global lock for resolve
[ https://issues.apache.org/jira/browse/SLING-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13001404#comment-13001404 ] Bertrand Delacretaz commented on SLING-2009: And note that this happens rarely, never seen it on my development machine. Webconsole install fails with Unable to acquire global lock for resolve - Key: SLING-2009 URL: https://issues.apache.org/jira/browse/SLING-2009 Project: Sling Issue Type: Bug Reporter: Bertrand Delacretaz Attachments: error.log The testing/samples/integration-tests module failed in Hudson build 1127 [1], due to the installation of the org.apache.sling.junit.core bundle failing with the below stack trace. The integration tests install those bundles as soon as the Sling server is up (checked by requesting a few URLs like / and /.explorer.html, see logs) - should that wait until the webconsole/OSGi framework is ready for new installs, and how to check this? [1] https://hudson.apache.org/hudson/view/S-Z/view/Sling/job/sling-trunk-1.5/1127/ Log excerpt (I'll attach the complete sling log): 01.03.2011 11:49:06.747 *INFO* [FelixDispatchQueue] org.apache.sling.junit.core BundleEvent INSTALLED 01.03.2011 11:49:06.752 *ERROR* [Background Install /tmp/install63068254848590030.tmp] org.apache.felix.http.jetty %bundles.pluginTitle: Cannot install or update bundle from /tmp/install63068254848590030.tmp (org.osgi.framework.BundleException: Unresolved constraint in bundle org.apache.sling.junit.core [72]: Unable to acquire global lock for resolve.) org.osgi.framework.BundleException: Unresolved constraint in bundle org.apache.sling.junit.core [72]: Unable to acquire global lock for resolve. at org.apache.felix.framework.Felix.resolveBundle(Felix.java:3443) at org.apache.felix.framework.Felix.startBundle(Felix.java:1727) at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:922) at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:909) at org.apache.felix.webconsole.internal.core.InstallHelper.doRun(InstallHelper.java:67) at org.apache.felix.webconsole.internal.core.BaseUpdateInstallHelper.doRun(BaseUpdateInstallHelper.java:89) at org.apache.felix.webconsole.internal.core.BaseUpdateInstallHelper.run(BaseUpdateInstallHelper.java:121) at java.lang.Thread.run(Thread.java:595) -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (SLING-2015) Provide a Sling servlet to run server-side JUnit tests
Provide a Sling servlet to run server-side JUnit tests -- Key: SLING-2015 URL: https://issues.apache.org/jira/browse/SLING-2015 Project: Sling Issue Type: Improvement Components: Testing Reporter: Bertrand Delacretaz The testing/junit/core module currently uses a plain servlet that runs outside of the Sling request cycle. However, some tests depend on custom Sling Filters, for example, and as such need to run in the Sling request cycle. To keep the junit/core module reusable outside of Sling, I'll implement a second servlet, that will be active only in a Sling environment. The existing plain servlet can be disabled by configuration if needed. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (SLING-2015) Provide a Sling servlet to run server-side JUnit tests
[ https://issues.apache.org/jira/browse/SLING-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-2015. Resolution: Fixed Assignee: Bertrand Delacretaz Implemented in revision 1076648 - the existing servlet at /system/sling/junit stays (although with slightly different URL patterns to select tests), and a new Sling servlet is available that handles the .junit selector. To activate the Sling JUnit servlet, create a resource with the sling/junit/testing resource type: curl -Fsling:resourceType=sling/junit/testing http://admin:admin@localhost:8080/test/foo And the tests can then be run as in these examples: Run all tests in the OsgiAware class: curl -X POST http://admin:admin@localhost:8080/test/foo.junit/org.apache.sling.testing.samples.sampletests.OsgiAwareTest.json Run a single test method from that class: curl -X POST http://admin:admin@localhost:8080/test/foo.junit/org.apache.sling.testing.samples.sampletests.OsgiAwareTest/testConfigAdmin.json Run all tests in a given package: curl -X POST http://admin:admin@localhost:8080/test/foo.junit/org.apache.sling.testing.samples.json Run all available tests: curl -X POST http://admin:admin@localhost:8080/test/foo.junit/.json Provide a Sling servlet to run server-side JUnit tests -- Key: SLING-2015 URL: https://issues.apache.org/jira/browse/SLING-2015 Project: Sling Issue Type: Improvement Components: Testing Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Labels: integration-tests, junit The testing/junit/core module currently uses a plain servlet that runs outside of the Sling request cycle. However, some tests depend on custom Sling Filters, for example, and as such need to run in the Sling request cycle. To keep the junit/core module reusable outside of Sling, I'll implement a second servlet, that will be active only in a Sling environment. The existing plain servlet can be disabled by configuration if needed. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (SLING-2021) JarExecutor should not be a singleton
JarExecutor should not be a singleton - Key: SLING-2021 URL: https://issues.apache.org/jira/browse/SLING-2021 Project: Sling Issue Type: Improvement Components: Testing Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor In testing/tools, JarExecutor uses a singleton pattern but that's not needed, a regular constructor would be fine. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (SLING-2021) JarExecutor should not be a singleton
[ https://issues.apache.org/jira/browse/SLING-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-2021. Resolution: Fixed Changed to a regular constructor in revision 1078776 JarExecutor should not be a singleton - Key: SLING-2021 URL: https://issues.apache.org/jira/browse/SLING-2021 Project: Sling Issue Type: Improvement Components: Testing Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Labels: integration-tests In testing/tools, JarExecutor uses a singleton pattern but that's not needed, a regular constructor would be fine. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (SLING-2022) JarExecutor: optionally run in a specific folder
JarExecutor: optionally run in a specific folder Key: SLING-2022 URL: https://issues.apache.org/jira/browse/SLING-2022 Project: Sling Issue Type: Improvement Components: Testing Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Add a property to configure the path where the runnable jar is executed. Folder must exist before running the test. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SLING-2022) More JarExecutor options: work folder and options for the executable jar
[ https://issues.apache.org/jira/browse/SLING-2022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-2022: --- Description: Add a property to configure the path where the runnable jar is executed. Folder must exist before running the test. And one to define options that are passed to the jar that's executed was:Add a property to configure the path where the runnable jar is executed. Folder must exist before running the test. Summary: More JarExecutor options: work folder and options for the executable jar (was: JarExecutor: optionally run in a specific folder) More JarExecutor options: work folder and options for the executable jar Key: SLING-2022 URL: https://issues.apache.org/jira/browse/SLING-2022 Project: Sling Issue Type: Improvement Components: Testing Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Labels: integration-tests Add a property to configure the path where the runnable jar is executed. Folder must exist before running the test. And one to define options that are passed to the jar that's executed -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (SLING-2022) More JarExecutor options: work folder and options for the executable jar
[ https://issues.apache.org/jira/browse/SLING-2022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-2022. Resolution: Fixed Implemented in revision 1078781 More JarExecutor options: work folder and options for the executable jar Key: SLING-2022 URL: https://issues.apache.org/jira/browse/SLING-2022 Project: Sling Issue Type: Improvement Components: Testing Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Labels: integration-tests Add a property to configure the path where the runnable jar is executed. Folder must exist before running the test. And one to define options that are passed to the jar that's executed -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (SLING-2023) Sample Integration tests should run in the integration-tests phase
Sample Integration tests should run in the integration-tests phase -- Key: SLING-2023 URL: https://issues.apache.org/jira/browse/SLING-2023 Project: Sling Issue Type: Improvement Components: Testing Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Currently the tests of the testing/samples/integration-tests module run in the test phase, but they are really integration tests. Running in the integration-tests phase also helps special pre and post-tests setups, via the pre-integration-tests and post-integration-tests build phases ( http://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (SLING-2026) Junit Core Bundle packages duplicate copy of JUnit classes
[ https://issues.apache.org/jira/browse/SLING-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz reassigned SLING-2026: -- Assignee: Bertrand Delacretaz Junit Core Bundle packages duplicate copy of JUnit classes -- Key: SLING-2026 URL: https://issues.apache.org/jira/browse/SLING-2026 Project: Sling Issue Type: Bug Components: Testing Reporter: Chetan Mehrotra Assignee: Bertrand Delacretaz Priority: Minor The org.apache.sling.junit.core Bundle embed the Junit jar. The bundle produced has Junit classes present as inline and also as part of embedded jar The maven-bundle-plugin should have one of the following two configuration 1. Inline the Junit jar dependency 2. Use _exportcontent instead of the Export-Package for exporting clases which are part of any embedded jar For more details have a look at http://felix.apache.org/site/apache-felix-maven-bundle-plugin-bnd.html#ApacheFelixMavenBundlePlugin%28BND%29-EmbedDependencyandExportPackage -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (SLING-2026) Junit Core Bundle packages duplicate copy of JUnit classes
[ https://issues.apache.org/jira/browse/SLING-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-2026. Resolution: Fixed Fixed in revision 1079844, thanks for the detailed report! Junit Core Bundle packages duplicate copy of JUnit classes -- Key: SLING-2026 URL: https://issues.apache.org/jira/browse/SLING-2026 Project: Sling Issue Type: Bug Components: Testing Reporter: Chetan Mehrotra Assignee: Bertrand Delacretaz Priority: Minor The org.apache.sling.junit.core Bundle embed the Junit jar. The bundle produced has Junit classes present as inline and also as part of embedded jar The maven-bundle-plugin should have one of the following two configuration 1. Inline the Junit jar dependency 2. Use _exportcontent instead of the Export-Package for exporting clases which are part of any embedded jar For more details have a look at http://felix.apache.org/site/apache-felix-maven-bundle-plugin-bnd.html#ApacheFelixMavenBundlePlugin%28BND%29-EmbedDependencyandExportPackage -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (SLING-2027) SlingRemoteTestParameters: make tests count check optional
SlingRemoteTestParameters: make tests count check optional -- Key: SLING-2027 URL: https://issues.apache.org/jira/browse/SLING-2027 Project: Sling Issue Type: Improvement Components: Testing Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor SlingRemoteTestParameters.getExpectedNumberOfTests should be optional, create a separate interface that also allows different comparisons (= etc) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (SLING-2028) SlingClient: conversion of Location header value to path assumes hostname is present
SlingClient: conversion of Location header value to path assumes hostname is present Key: SLING-2028 URL: https://issues.apache.org/jira/browse/SLING-2028 Project: Sling Issue Type: Bug Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor The o.a.s.testing.tools SlingClient.createNode() method breaks if the Location header value is shorter than slingServerUrl.length() - use a more robust extraction method. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (SLING-2029) RemoteTestHttpClient does not support credentials
RemoteTestHttpClient does not support credentials - Key: SLING-2029 URL: https://issues.apache.org/jira/browse/SLING-2029 Project: Sling Issue Type: Bug Components: Testing Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor RemoteTestHttpClient should allow tests to provide credentials -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SLING-2028) SlingClient: conversion of Location header value to path assumes hostname is present
[ https://issues.apache.org/jira/browse/SLING-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-2028: --- Component/s: Testing SlingClient: conversion of Location header value to path assumes hostname is present Key: SLING-2028 URL: https://issues.apache.org/jira/browse/SLING-2028 Project: Sling Issue Type: Bug Components: Testing Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor The o.a.s.testing.tools SlingClient.createNode() method breaks if the Location header value is shorter than slingServerUrl.length() - use a more robust extraction method. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (SLING-2028) SlingClient: conversion of Location header value to path assumes hostname is present
[ https://issues.apache.org/jira/browse/SLING-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-2028. Resolution: Fixed Fixed in revision 1080625 SlingClient: conversion of Location header value to path assumes hostname is present Key: SLING-2028 URL: https://issues.apache.org/jira/browse/SLING-2028 Project: Sling Issue Type: Bug Components: Testing Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor The o.a.s.testing.tools SlingClient.createNode() method breaks if the Location header value is shorter than slingServerUrl.length() - use a more robust extraction method. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (SLING-2027) SlingRemoteTestParameters: make tests count check optional
[ https://issues.apache.org/jira/browse/SLING-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-2027. Resolution: Fixed Implemented in revision 1080639 SlingRemoteTestParameters: make tests count check optional -- Key: SLING-2027 URL: https://issues.apache.org/jira/browse/SLING-2027 Project: Sling Issue Type: Improvement Components: Testing Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor SlingRemoteTestParameters.getExpectedNumberOfTests should be optional, create a separate interface that also allows different comparisons (= etc) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-1967) Document possibility of caching in Adaptable
[ https://issues.apache.org/jira/browse/SLING-1967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13009176#comment-13009176 ] Bertrand Delacretaz commented on SLING-1967: FWIW, I've been bitten by this as well and it took quite a while to figure out. I haven't studied the details yet but adding a doNotCache parameter to the adaptTo call might help make things more explicit. Document possibility of caching in Adaptable Key: SLING-1967 URL: https://issues.apache.org/jira/browse/SLING-1967 Project: Sling Issue Type: Improvement Components: API Affects Versions: API 2.2.0 Reporter: Alexander Klimetschek Assignee: Felix Meschberger Fix For: API 2.2.2 SLING-1673 added caching in SlingAdaptable. This means that Adaptable.adapTo() users must be aware that there won't be a new instance of the requested object upon repeated calls. This should be documented in adaptTo(), i.e. that one cannot expect new instances - or rely on any behavior, be it always the same instance or always a new one. This affects mostly adapters provided by AdapterFactories, as these will be behind the default caching implementation in SlingAdaptable. If adaptTo() is directly implemented in an object, it can chose itself whether it does caching or not. So I think the docs for AdapterFactory should also be changed to note that - something like make sure you return re-usable objects here, as these might get cached and the adapter factory won't be called for each adaptTo call of the same object. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2029) RemoteTestHttpClient does not support credentials
[ https://issues.apache.org/jira/browse/SLING-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13009678#comment-13009678 ] Bertrand Delacretaz commented on SLING-2029: Thanks for your contribution! I'm not a fan of thread locals at the framework level if we can avoid them, so I implemented a different mechanism in revision 1084217, using optional interfaces. The SlingRemoteExecutionRule class is a RequestCustomizer which does nothing by default, but if you want to use thread locals in your project inheriting your own rule class from that one should work. Please let us know if this works for you, and I'll close this issue if it does. RemoteTestHttpClient does not support credentials - Key: SLING-2029 URL: https://issues.apache.org/jira/browse/SLING-2029 Project: Sling Issue Type: Bug Components: Testing Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Attachments: Threadlocal-based-approach.patch RemoteTestHttpClient should allow tests to provide credentials -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
