[GitHub] storm issue #1687: Apache master storm 1694 top storm 2097
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1687 @hmcl also this PR is the same as this one with one more commit? https://github.com/apache/storm/pull/1757/commits . If so can you close this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1687: Apache master storm 1694 top storm 2097
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1687 @hmcl these PR titles are very confusing. Can you fix that in both the PRs. Not sure what it means by "Apache master storm 1694 top storm 2097". Just add the JIRA title as PR title. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1687: Apache master storm 1694 top storm 2097
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1687 @hmcl OK thanks for following up. @harshach Please treat my comment as addressed, and also feel free to merge when you think it's OK to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1687: Apache master storm 1694 top storm 2097
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/1687 @HeartSaVioR I believe I address your valid concerns about the kafka library versions in this [PR](https://github.com/apache/storm/pull/1757) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1687: Apache master storm 1694 top storm 2097
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1687
Since it does load the two modules - storm-kafka and storm-kafka-client -
but only load kafka-client with `${storm.kafka.client.version}`. Does
storm-starter work with both storm-kafka and storm-kafka-client? If not, I
guess we need to move out storm-kafka and storm-kafka-client to separate
modules like recent examples modules.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
