[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString
Github user cbaenziger commented on a diff in the pull request: https://github.com/apache/twill/pull/65#discussion_r166133525 --- Diff: pom.xml --- @@ -680,9 +680,9 @@ -hadoop-2.5 +hadoop-2.6 -2.5.1 +2.6.5 --- End diff -- @chtyim You are asking me to leave the 2.5 profile alone and add the 2.6 profile? ---
[GitHub] twill issue #65: (TWILL-254) Update to use ContainerId.fromString
Github user cbaenziger commented on the issue: https://github.com/apache/twill/pull/65 Hi @chtyim, thank you for the review. Could you please expand on what you see concerning in the `pom.xml`? For reference, I need to provide a 2.6 target as it is the first version to provide the `ContainerId.fromString()` API. ---
[GitHub] twill issue #65: (TWILL-254) Update to use ContainerId.fromString
Github user cbaenziger commented on the issue: https://github.com/apache/twill/pull/65 Thank you for the super fast code review @serranom! I think all comments have been addressed and the code should be complete now. Please let me know if you see anything else necessary. It is great working with Twill! Hopefully I can provide some other ideas as I work with it. ---
[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString
Github user cbaenziger commented on a diff in the pull request: https://github.com/apache/twill/pull/65#discussion_r165862926 --- Diff: twill-yarn/src/main/hadoop22/org/apache/twill/internal/yarn/Hadoop22YarnAMClient.java --- @@ -26,7 +26,7 @@ /** * Wrapper class for AMRMClient for Hadoop version 2.2 or greater. */ -public final class Hadoop22YarnAMClient extends Hadoop21YarnAMClient { +public class Hadoop22YarnAMClient extends Hadoop21YarnAMClient { --- End diff -- If marked `final`, I can not extend it for [`Hadoop26YarnAMClient`](https://github.com/apache/twill/pull/65/files#diff-8c254de8ae00c6007495979dcb66a986R30)? ---
[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString
Github user cbaenziger commented on a diff in the pull request: https://github.com/apache/twill/pull/65#discussion_r165862857 --- Diff: twill-yarn/src/main/hadoop20/org/apache/twill/internal/yarn/Hadoop20YarnAMClient.java --- @@ -71,6 +73,11 @@ public Hadoop20YarnAMClient(Configuration conf) { this.nmClient = new Hadoop20YarnNMClient(YarnRPC.create(conf), conf); } + @Override + private ContainerId containerIdLookup(String containerIdStr) { +return (ConverterUtils.toContainerId(containerIdStr)); --- End diff -- Thank you ---
[GitHub] twill issue #65: (TWILL-254) Update to use ContainerId.fromString
Github user cbaenziger commented on the issue: https://github.com/apache/twill/pull/65 I added a few omissions and corrected the parent `pom.xml` from my original submission. Now the new code is actually being used and I have updated the default target to Hadoop 2.6 and removed the generic `hadoop.version` as suggested. ---
[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString
Github user cbaenziger commented on a diff in the pull request: https://github.com/apache/twill/pull/65#discussion_r165862673 --- Diff: pom.xml --- @@ -680,9 +680,9 @@ -hadoop-2.5 +hadoop-2.6 -2.5.1 +2.6.5 --- End diff -- I didn't see any code specific to 2.5 that 2.3 did not provide? ---
[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString
GitHub user cbaenziger opened a pull request: https://github.com/apache/twill/pull/65 (TWILL-254) Update to use ContainerId.fromString This moves away from the deprecated `ConverterUitls.toContainerId` and updates the build to use Hadoop 2.7.2 to avoid folks grabbing master and having a failure trying to run on clusters with code newer than November 18th, 2014 (release of Hadoop 2.6.0). You can merge this pull request into a Git repository by running: $ git pull https://github.com/cbaenziger/twill master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/twill/pull/65.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #65 commit 391553308ccc0539b72fac6bf13cd819ce3bb5e1 Author: Clay Baenziger Date: 2018-02-03T03:35:37Z (TWILL-254) Update to use ContainerId.fromString ---