[GitHub] [zeppelin] prabhjyotsingh commented on issue #3378: [ZEPPELIN-4187] Bump up version of Scala from 2.11.8 to 2.11.12
prabhjyotsingh commented on issue #3378: [ZEPPELIN-4187] Bump up version of Scala from 2.11.8 to 2.11.12 URL: https://github.com/apache/zeppelin/pull/3378#issuecomment-501119539 @felixcheung yes I've upgraded Flink from 1.7.1 to 1.7.2 as well. To upgrade it to 1.8.0 will be slightly tricky, I can do it on a follow-up PR. Or does it makes more sense to revert all of the Flink changes from here and implement it on a different PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] prabhjyotsingh commented on a change in pull request #3378: [ZEPPELIN-4187] Bump up version of Scala from 2.11.8 to 2.11.12
prabhjyotsingh commented on a change in pull request #3378: [ZEPPELIN-4187]
Bump up version of Scala from 2.11.8 to 2.11.12
URL: https://github.com/apache/zeppelin/pull/3378#discussion_r292744521
##
File path:
flink/src/main/scala/org/apache/zeppelin/flink/FlinkScalaInterpreter.scala
##
@@ -231,3 +233,71 @@ class FlinkScalaInterpreter(val properties: Properties) {
def getBatchTableEnviroment(): BatchTableEnvironment = this.btenv
}
+
+private object FlinkScalaInterpreter {
+
+ /**
+* This is a hack to call `loopPostInit` at `ILoop`. At higher version of
Scala such
+* as 2.11.12, `loopPostInit` became a nested function which is
inaccessible. Here,
+* we redefine `loopPostInit` at Scala's 2.11.8 side and ignore
`loadInitFiles` being called at
+* Scala 2.11.12 since here we do not have to load files.
+*
+* Both methods `loopPostInit` and `unleashAndSetPhase` are redefined, and
`phaseCommand` and
+* `asyncMessage` are being called via reflection since both exist in Scala
2.11.8 and 2.11.12.
+*
+* Please see the codes below:
+*
https://github.com/scala/scala/blob/v2.11.8/src/repl/scala/tools/nsc/interpreter/ILoop.scala
+*
https://github.com/scala/scala/blob/v2.11.12/src/repl/scala/tools/nsc/interpreter/ILoop.scala
+*
+* See also ZEPPELIN-3810/ZEPPELIN-4187.
+*/
+ private def loopPostInit(interpreter: FlinkScalaInterpreter): Unit = {
+import StdReplTags._
+import scala.reflect.{classTag, io}
+
+val sparkILoop = interpreter.flinkILoop
Review comment:
`callMethod(flinkILoop, "scala$tools$nsc$interpreter$ILoop$$loopPostInit")`
was failing so got it replaced with the help of ZEPPELIN-3810, let me fix the
variable name.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] felixcheung commented on a change in pull request #3378: [ZEPPELIN-4187] Bump up version of Scala from 2.11.8 to 2.11.12
felixcheung commented on a change in pull request #3378: [ZEPPELIN-4187] Bump
up version of Scala from 2.11.8 to 2.11.12
URL: https://github.com/apache/zeppelin/pull/3378#discussion_r292744100
##
File path:
flink/src/main/scala/org/apache/zeppelin/flink/FlinkScalaInterpreter.scala
##
@@ -231,3 +233,71 @@ class FlinkScalaInterpreter(val properties: Properties) {
def getBatchTableEnviroment(): BatchTableEnvironment = this.btenv
}
+
+private object FlinkScalaInterpreter {
+
+ /**
+* This is a hack to call `loopPostInit` at `ILoop`. At higher version of
Scala such
+* as 2.11.12, `loopPostInit` became a nested function which is
inaccessible. Here,
+* we redefine `loopPostInit` at Scala's 2.11.8 side and ignore
`loadInitFiles` being called at
+* Scala 2.11.12 since here we do not have to load files.
+*
+* Both methods `loopPostInit` and `unleashAndSetPhase` are redefined, and
`phaseCommand` and
+* `asyncMessage` are being called via reflection since both exist in Scala
2.11.8 and 2.11.12.
+*
+* Please see the codes below:
+*
https://github.com/scala/scala/blob/v2.11.8/src/repl/scala/tools/nsc/interpreter/ILoop.scala
+*
https://github.com/scala/scala/blob/v2.11.12/src/repl/scala/tools/nsc/interpreter/ILoop.scala
+*
+* See also ZEPPELIN-3810/ZEPPELIN-4187.
+*/
+ private def loopPostInit(interpreter: FlinkScalaInterpreter): Unit = {
+import StdReplTags._
+import scala.reflect.{classTag, io}
+
+val sparkILoop = interpreter.flinkILoop
Review comment:
`sparkILoop`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] felixcheung commented on a change in pull request #3378: [ZEPPELIN-4187] Bump up version of Scala from 2.11.8 to 2.11.12
felixcheung commented on a change in pull request #3378: [ZEPPELIN-4187] Bump
up version of Scala from 2.11.8 to 2.11.12
URL: https://github.com/apache/zeppelin/pull/3378#discussion_r292744011
##
File path:
flink/src/main/scala/org/apache/zeppelin/flink/FlinkScalaInterpreter.scala
##
@@ -30,18 +29,20 @@ import org.apache.flink.runtime.minicluster.MiniCluster
import org.apache.flink.streaming.api.scala.StreamExecutionEnvironment
import org.apache.flink.table.api.TableEnvironment
import org.apache.flink.table.api.scala.{BatchTableEnvironment,
StreamTableEnvironment}
+import org.apache.spark.repl.SparkILoop
Review comment:
???
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] felixcheung commented on a change in pull request #3378: [ZEPPELIN-4187] Bump up version of Scala from 2.11.8 to 2.11.12
felixcheung commented on a change in pull request #3378: [ZEPPELIN-4187] Bump up version of Scala from 2.11.8 to 2.11.12 URL: https://github.com/apache/zeppelin/pull/3378#discussion_r292743874 ## File path: flink/pom.xml ## @@ -36,11 +36,12 @@ flink -1.7.1 +1.7.2 2.3.7 -2.0.1 +2.1.1 2.11 -2.11.8 +2.11.12 +2.4.0 Review comment: why is this here? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] felixcheung commented on issue #3378: [ZEPPELIN-4187] Bump up version of Scala from 2.11.8 to 2.11.12
felixcheung commented on issue #3378: [ZEPPELIN-4187] Bump up version of Scala from 2.11.8 to 2.11.12 URL: https://github.com/apache/zeppelin/pull/3378#issuecomment-501117141 flink can run with 2.11.12 https://github.com/apache/flink/blob/master/pom.xml#L119 but maybe we need to update the flink version - we have 1.7 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (ZEPPELIN-4190) Unable to Open Zeppelin documentation and Notebook options missing
Saurabh Awasthi created ZEPPELIN-4190: - Summary: Unable to Open Zeppelin documentation and Notebook options missing Key: ZEPPELIN-4190 URL: https://issues.apache.org/jira/browse/ZEPPELIN-4190 Project: Zeppelin Issue Type: Bug Components: front-end Reporter: Saurabh Awasthi Attachments: Zeppelin Error.png [https://labs.cognitiveclass.ai/tools/zeppelin-notebook/] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [zeppelin] prabhjyotsingh merged pull request #3377: [ZEPPELIN-4186] Bump up version of org.jsoup:jsoup
prabhjyotsingh merged pull request #3377: [ZEPPELIN-4186] Bump up version of org.jsoup:jsoup URL: https://github.com/apache/zeppelin/pull/3377 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (ZEPPELIN-4189) Record INTERPRETER_RUN_COMMAND execution log in the interpreter.sh
Xun Liu created ZEPPELIN-4189: - Summary: Record INTERPRETER_RUN_COMMAND execution log in the interpreter.sh Key: ZEPPELIN-4189 URL: https://issues.apache.org/jira/browse/ZEPPELIN-4189 Project: Zeppelin Issue Type: Improvement Components: Interpreters Reporter: Xun Liu Assignee: Xun Liu Fix For: 0.9.0 Record the INTERPRETER_RUN_COMMAND execution log in the interpreter.sh file. Can help find the reason why the startup interpreter failed to execute. Especially in the container environment, it can play a relatively large role. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [zeppelin] asfgit closed pull request #3375: ZEPPELIN-4176. Remove old spark interpreter
asfgit closed pull request #3375: ZEPPELIN-4176. Remove old spark interpreter URL: https://github.com/apache/zeppelin/pull/3375 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] asfgit closed pull request #3359: [ZEPPELIN-4131] Add %sh.terminal interpreter
asfgit closed pull request #3359: [ZEPPELIN-4131] Add %sh.terminal interpreter URL: https://github.com/apache/zeppelin/pull/3359 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: Angular version upgrade in Zeppelin
Hi What is the status of the ZEPPELIN-3981? Is this still committed? The bootstrap version used in 0.8 Zeppelin has many security issues. Please prioritize the frontend upgrade, because the security issues would prevent Zeppelin to be deployed in the cloud environment. Thanks Denny > On May 12, 2019, at 11:04 PM, Jeff Zhang wrote: > > There's some work going on, but it would require time as this is not a > trivial upgrade. The ETA would be next half of this year IMO. > > Denny 于2019年5月13日周一 上午11:00写道： > >> Hi >> >> Any update on this issue? When can we expect to see the angular and >> bootstrap upgrade to happen? The current versions are quite old and have >> security issues. Thanks >> >> https://issues.apache.org/jira/browse/ZEPPELIN-3981 >> >>> On Mar 7, 2019, at 8:46 PM, Xun Liu wrote: >>> >>> Now write the python algorithm in the note, The reaction has been slow. >>> Thank you very much, you can help upgrade the frontend. >>> >>> Thank! >>> 在 2019年3月8日，上午9:27，Jeff Zhang 写道： The old angular version do cause many issues in frontend, I am thinking >> of it for a long time to upgrade it to angular 7. If anyone is interested >> on it, I would be very appreciated. 于2019年3月8日周五 上午9:24写道： > That’s great! I assume bootstrap is part of the upgrade (it has >> security > issues). What is the timeframe this will be done? > > Thanks > Denny > >> On Mar 7, 2019, at 6:56 PM, Jongyoul Lee wrote: >> >> Hi, >> >> I've added the related issue to GSOC as well. Please check >> https://issues.apache.org/jira/browse/ZEPPELIN-3981 >> >>> On Fri, Mar 8, 2019 at 2:44 AM wrote: >>> >>> Hi All >>> >>> The current Angular 1.5 used in the latest Zeppelin has security >> issues >>> (XSS). I see there is an outstanding jira issue to address the >> version >>> upgrade (ZEPPELIN-2747), but it is not assigned to be worked on. Can > this >>> issue be addressed soon? >>> >>> Thanks >>> Denny >>> >> >> >> -- >> 이종열, Jongyoul Lee, 李宗烈 >> http://madeng.net > > -- Best Regards Jeff Zhang >>> >>> >> > > > -- > Best Regards > > Jeff Zhang
[GitHub] [zeppelin] prabhjyotsingh edited a comment on issue #3378: [ZEPPELIN-4187] Bump up version of Scala from 2.11.8 to 2.11.12
prabhjyotsingh edited a comment on issue #3378: [ZEPPELIN-4187] Bump up version of Scala from 2.11.8 to 2.11.12 URL: https://github.com/apache/zeppelin/pull/3378#issuecomment-500888676 Should we upgrade Scala version for Flink as well, or can it run with an older version of Scala (2.11.8)? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] prabhjyotsingh commented on a change in pull request #3378: [ZEPPELIN-4187] Bump up version of Scala from 2.11.8 to 2.11.12
prabhjyotsingh commented on a change in pull request #3378: [ZEPPELIN-4187] Bump up version of Scala from 2.11.8 to 2.11.12 URL: https://github.com/apache/zeppelin/pull/3378#discussion_r292513644 ## File path: pom.xml ## @@ -750,7 +750,7 @@ scala-2.11 -2.11.8 +2.11.12 Review comment: I see all of Casandra, Flink, and Ignite will get the version upgrade because of this. Sure, let me revert this change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] prabhjyotsingh commented on issue #3378: [ZEPPELIN-4187] Bump up version of Scala from 2.11.8 to 2.11.12
prabhjyotsingh commented on issue #3378: [ZEPPELIN-4187] Bump up version of Scala from 2.11.8 to 2.11.12 URL: https://github.com/apache/zeppelin/pull/3378#issuecomment-500888676 We need to upgrade Scala version for Flink as well, or should it run with an older version of Scala (2.11.8)? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] zjffdu commented on a change in pull request #3378: [ZEPPELIN-4187] Bump up version of Scala from 2.11.8 to 2.11.12
zjffdu commented on a change in pull request #3378: [ZEPPELIN-4187] Bump up version of Scala from 2.11.8 to 2.11.12 URL: https://github.com/apache/zeppelin/pull/3378#discussion_r292502381 ## File path: pom.xml ## @@ -750,7 +750,7 @@ scala-2.11 -2.11.8 +2.11.12 Review comment: I think we just only need to change scala version in spark interpreter. Changing it in project root's `pom.xml` will affect all the interpreters, this may introduce other issues. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] r-kamath commented on issue #3376: [ZEPPELIN-4185] Upgrade Thrift to 0.12.0
r-kamath commented on issue #3376: [ZEPPELIN-4185] Upgrade Thrift to 0.12.0 URL: https://github.com/apache/zeppelin/pull/3376#issuecomment-500858353 will merge this if there are no more discussions This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] r-kamath opened a new pull request #3379: [ZEPPELIN-4188] Upgrade Jetty to 9.4.18.v20190429
r-kamath opened a new pull request #3379: [ZEPPELIN-4188] Upgrade Jetty to 9.4.18.v20190429 URL: https://github.com/apache/zeppelin/pull/3379 ### What is this PR for? [ZEPPELIN-4188] Upgrade Jetty to 9.4.18.v20190429 ### What type of PR is it? Improvement ### Todos * [ ] - Task ### What is the Jira issue? [ZEPPELIN-4188](https://jira.apache.org/jira/browse/ZEPPELIN-4188) ### How should this be tested? Should pass CI ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (ZEPPELIN-4188) Upgrade Jetty to 9.4.18.v20190429
Renjith Kamath created ZEPPELIN-4188: Summary: Upgrade Jetty to 9.4.18.v20190429 Key: ZEPPELIN-4188 URL: https://issues.apache.org/jira/browse/ZEPPELIN-4188 Project: Zeppelin Issue Type: Improvement Reporter: Renjith Kamath Assignee: Renjith Kamath -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [zeppelin] prabhjyotsingh commented on issue #3378: [ZEPPELIN-4187] Bump up version of Scala from 2.11.8 to 2.11.12
prabhjyotsingh commented on issue #3378: [ZEPPELIN-4187] Bump up version of Scala from 2.11.8 to 2.11.12 URL: https://github.com/apache/zeppelin/pull/3378#issuecomment-500763415 Thank you @zjffdu that definitely makes sense, let me update the version to `2.11.12` and change the PR title as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] zjffdu commented on issue #3378: [ZEPPELIN-4187] Bump up version of Scala from 2.11.8 to 2.11.11
zjffdu commented on issue #3378: [ZEPPELIN-4187] Bump up version of Scala from 2.11.8 to 2.11.11 URL: https://github.com/apache/zeppelin/pull/3378#issuecomment-500761220 I believe so, that latest spark support scala 2.11.12 https://github.com/apache/spark/blob/branch-2.4/pom.xml#L158 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] prabhjyotsingh commented on issue #3378: [ZEPPELIN-4187] Bump up version of Scala from 2.11.8 to 2.11.11
prabhjyotsingh commented on issue #3378: [ZEPPELIN-4187] Bump up version of Scala from 2.11.8 to 2.11.11 URL: https://github.com/apache/zeppelin/pull/3378#issuecomment-500755310 @felixcheung @zjffdu can you help review this. Also, should we upgrade to the latest 2.11.12? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] prabhjyotsingh opened a new pull request #3378: [ZEPPELIN-4187] Bump up version of Scala from 2.11.8 to 2.11.11
prabhjyotsingh opened a new pull request #3378: [ZEPPELIN-4187] Bump up version of Scala from 2.11.8 to 2.11.11 URL: https://github.com/apache/zeppelin/pull/3378 ### What is this PR for? This is to bump up the version of Scala from 2.11.8 to 2.11.11. This is a minor version upgrade to the latest fixes from Scala. ### What type of PR is it? [Improvement] ### What is the Jira issue? * [ZEPPELIN-4187](https://jira.apache.org/jira/browse/ZEPPELIN-4187) ### How should this be tested? * CI should be green ### Screenshots (if appropriate) N/A ### Questions: * Does the licenses files need update? n/a * Is there breaking changes for older versions? n/a * Does this needs documentation? n/a This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (ZEPPELIN-4187) Bump up version of scala from 2.11.8 to 2.11.11
Prabhjyot Singh created ZEPPELIN-4187: - Summary: Bump up version of scala from 2.11.8 to 2.11.11 Key: ZEPPELIN-4187 URL: https://issues.apache.org/jira/browse/ZEPPELIN-4187 Project: Zeppelin Issue Type: Bug Components: spark Reporter: Prabhjyot Singh Assignee: Prabhjyot Singh -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [zeppelin] prabhjyotsingh commented on issue #3377: [ZEPPELIN-4186] Bump up version of org.jsoup:jsoup
prabhjyotsingh commented on issue #3377: [ZEPPELIN-4186] Bump up version of org.jsoup:jsoup URL: https://github.com/apache/zeppelin/pull/3377#issuecomment-500728792 CI green (https://travis-ci.org/prabhjyotsingh/zeppelin/builds/544050357) will merge this to master soon. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
