ZooKeeper-trunk-WinVS2008 - Build # 756 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/756/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 67 lines...] ivy-init: ivy-retrieve: [ivy:retrieve] :: Ivy 2.2.0 - 20100923230623 :: http://ant.apache.org/ivy/ :: [ivy:retrieve] :: loading settings :: file = f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\ivysettings.xml [ivy:retrieve] :: resolving dependencies :: org.apache.zookeeper#zookeeper;3.5.0 [ivy:retrieve] confs: [default] [ivy:retrieve] found org.slf4j#slf4j-api;1.6.2 in default [ivy:retrieve] found org.slf4j#slf4j-log4j12;1.6.2 in default [ivy:retrieve] found commons-cli#commons-cli;1.2 in default [ivy:retrieve] found log4j#log4j;1.2.16 in default [ivy:retrieve] found jline#jline;0.9.94 in default [ivy:retrieve] found org.jboss.netty#netty;3.2.5.Final in default [ivy:retrieve] found net.java.dev.javacc#javacc;5.0 in default BUILD FAILED f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\build.xml:362: impossible to resolve dependencies: java.io.IOException: There is not enough space on the disk at java.io.FileOutputStream.writeBytes(Native Method) at java.io.FileOutputStream.write(FileOutputStream.java:282) at sun.nio.cs.StreamEncoder.writeBytes(StreamEncoder.java:202) at sun.nio.cs.StreamEncoder.implFlushBuffer(StreamEncoder.java:272) at sun.nio.cs.StreamEncoder.implFlush(StreamEncoder.java:276) at sun.nio.cs.StreamEncoder.flush(StreamEncoder.java:122) at java.io.OutputStreamWriter.flush(OutputStreamWriter.java:212) at java.io.BufferedWriter.flush(BufferedWriter.java:236) at java.util.Properties.store0(Properties.java:822) at java.util.Properties.store(Properties.java:796) at org.apache.ivy.core.resolve.ResolveEngine.resolve(ResolveEngine.java:307) at org.apache.ivy.core.resolve.ResolveEngine.resolve(ResolveEngine.java:195) at org.apache.ivy.Ivy.resolve(Ivy.java:502) at org.apache.ivy.ant.IvyResolve.doExecute(IvyResolve.java:244) at org.apache.ivy.ant.IvyTask.execute(IvyTask.java:277) at org.apache.ivy.ant.IvyPostResolveTask.ensureResolved(IvyPostResolveTask.java:217) at org.apache.ivy.ant.IvyPostResolveTask.prepareAndCheck(IvyPostResolveTask.java:164) at org.apache.ivy.ant.IvyRetrieve.doExecute(IvyRetrieve.java:57) at org.apache.ivy.ant.IvyTask.execute(IvyTask.java:277) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) at org.apache.tools.ant.Task.perform(Task.java:348) at org.apache.tools.ant.Target.execute(Target.java:390) at org.apache.tools.ant.Target.performTasks(Target.java:411) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1399) at org.apache.tools.ant.Project.executeTarget(Project.java:1368) at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) at org.apache.tools.ant.Project.executeTargets(Project.java:1251) at org.apache.tools.ant.Main.runBuild(Main.java:809) at org.apache.tools.ant.Main.startAnt(Main.java:217) at org.apache.tools.ant.launch.Launcher.run(Launcher.java:280) at org.apache.tools.ant.launch.Launcher.main(Launcher.java:109) Total time: 4 seconds Build step 'Invoke Ant' marked build as failure Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
ZooKeeper-trunk-solaris - Build # 487 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-solaris/487/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 167047 lines...] [junit] 2013-03-04 08:59:26,031 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@413] - selector thread exitted run method [junit] 2013-03-04 08:59:26,032 [myid:] - INFO [main:ZooKeeperServer@398] - shutting down [junit] 2013-03-04 08:59:26,032 [myid:] - INFO [main:SessionTrackerImpl@180] - Shutting down [junit] 2013-03-04 08:59:26,032 [myid:] - INFO [main:PrepRequestProcessor@804] - Shutting down [junit] 2013-03-04 08:59:26,032 [myid:] - INFO [main:SyncRequestProcessor@175] - Shutting down [junit] 2013-03-04 08:59:26,032 [myid:] - INFO [ProcessThread(sid:0 cport:-1)::PrepRequestProcessor@144] - PrepRequestProcessor exited loop! [junit] 2013-03-04 08:59:26,033 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@155] - SyncRequestProcessor exited! [junit] 2013-03-04 08:59:26,033 [myid:] - INFO [main:FinalRequestProcessor@421] - shutdown of request processor complete [junit] 2013-03-04 08:59:26,033 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-03-04 08:59:26,034 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[] [junit] 2013-03-04 08:59:26,035 [myid:] - INFO [main:ClientBase@414] - STARTING server [junit] 2013-03-04 08:59:26,035 [myid:] - INFO [main:ZooKeeperServer@149] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test6956121034666712852.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test6956121034666712852.junit.dir/version-2 [junit] 2013-03-04 08:59:26,036 [myid:] - INFO [main:NIOServerCnxnFactory@663] - Configuring NIO connection handler with 10s sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 kB direct buffers. [junit] 2013-03-04 08:59:26,036 [myid:] - INFO [main:NIOServerCnxnFactory@676] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2013-03-04 08:59:26,037 [myid:] - INFO [main:FileSnap@83] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test6956121034666712852.junit.dir/version-2/snapshot.b [junit] 2013-03-04 08:59:26,040 [myid:] - INFO [main:FileTxnSnapLog@270] - Snapshotting: 0xb to /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test6956121034666712852.junit.dir/version-2/snapshot.b [junit] 2013-03-04 08:59:26,041 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-03-04 08:59:26,042 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@289] - Accepted socket connection from /127.0.0.1:62107 [junit] 2013-03-04 08:59:26,042 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@829] - Processing stat command from /127.0.0.1:62107 [junit] 2013-03-04 08:59:26,043 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn$StatCommand@678] - Stat command output [junit] 2013-03-04 08:59:26,043 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@1000] - Closed socket connection for client /127.0.0.1:62107 (no session established for client) [junit] 2013-03-04 08:59:26,043 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] 2013-03-04 08:59:26,045 [myid:] - INFO [main:JMXEnv@105] - expect:InMemoryDataTree [junit] 2013-03-04 08:59:26,045 [myid:] - INFO [main:JMXEnv@108] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] 2013-03-04 08:59:26,045 [myid:] - INFO [main:JMXEnv@105] - expect:StandaloneServer_port [junit] 2013-03-04 08:59:26,045 [myid:] - INFO [main:JMXEnv@108] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-03-04 08:59:26,045 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@57] - FINISHED TEST METHOD testQuota [junit] 2013-03-04 08:59:26,045 [myid:] - INFO [main:ClientBase@451] - tearDown starting [junit] 2013-03-04 08:59:26,117 [myid:] - INFO [main:ZooKeeper@744] - Session: 0x13d34a07d0d closed [junit] 2013-03-04 08:59:26,117 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down [junit] 2013-03-04 08:59:26,117 [myid:] - INFO [main:ClientBase@421] - STOPPING server [junit] 2013-03-04 08:59:26,118 [myid:] - INFO
[jira] [Commented] (ZOOKEEPER-1382) Zookeeper server holds onto dead/expired session ids in the watch data structures
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13592254#comment-13592254 ] Michael Morello commented on ZOOKEEPER-1382: It seems that the behavior of disableRecv() / enableRecv() has changed a bit in 3.5 : there is a new thread (SelectorThread) in charge of interest op updates and updates are processed in a non blocking fashion (updates are queued to be handled later by the SelectorThread, if i understand correctly it is more a throttle mechanism than something else). The unit test is no more relevant. If we want to fix the two branches (3.4 and 3.5) it is imho no more a good idea to rely on enableRecv(). May be it would be cleaner to introduce a new function ServerCnxn.setValidSession(boolean valid) that informs the implementation (NIOServerCnxn or NettyServerCnxn) that the session has been (re)validated and then allow subsequent messages to be processed. If you don't mind i will try to provide an other patch and a unit test for both branches. Zookeeper server holds onto dead/expired session ids in the watch data structures - Key: ZOOKEEPER-1382 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1382 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.4.5 Reporter: Neha Narkhede Assignee: Neha Narkhede Priority: Critical Fix For: 3.4.6 Attachments: ZOOKEEPER-1382_3.3.4.patch, ZOOKEEPER-1382-branch-3.4.patch I've observed that zookeeper server holds onto expired session ids in the watcher data structures. The result is the wchp command reports session ids that cannot be found through cons/dump and those expired session ids sit there maybe until the server is restarted. Here are snippets from the client and the server logs that lead to this state, for one particular session id 0x134485fd7bcb26f - There are 4 servers in the zookeeper cluster - 223, 224, 225 (leader), 226 and I'm using ZkClient to connect to the cluster From the application log - application.log.2012-01-26-325.gz:2012/01/26 04:56:36.177 INFO [ClientCnxn] [main-SendThread(223.prod:12913)] [application Session establishment complete on server 223.prod/172.17.135.38:12913, sessionid = 0x134485fd7bcb26f, negotiated timeout = 6000 application.log.2012-01-27.gz:2012/01/27 09:52:37.714 INFO [ClientCnxn] [main-SendThread(223.prod:12913)] [application] Client session timed out, have not heard from server in 9827ms for sessionid 0x134485fd7bcb26f, closing socket connection and attempting reconnect application.log.2012-01-27.gz:2012/01/27 09:52:38.191 INFO [ClientCnxn] [main-SendThread(226.prod:12913)] [application] Unable to reconnect to ZooKeeper service, session 0x134485fd7bcb26f has expired, closing socket connection On the leader zk, 225 - zookeeper.log.2012-01-27-leader-225.gz:2012-01-27 09:52:34,010 - INFO [SessionTracker:ZooKeeperServer@314] - Expiring session 0x134485fd7bcb26f, timeout of 6000ms exceeded zookeeper.log.2012-01-27-leader-225.gz:2012-01-27 09:52:34,010 - INFO [ProcessThread:-1:PrepRequestProcessor@391] - Processed session termination for sessionid: 0x134485fd7bcb26f On the server, the client was initially connected to, 223 - zookeeper.log.2012-01-26-223.gz:2012-01-26 04:56:36,173 - INFO [CommitProcessor:1:NIOServerCnxn@1580] - Established session 0x134485fd7bcb26f with negotiated timeout 6000 for client /172.17.136.82:45020 zookeeper.log.2012-01-27-223.gz:2012-01-27 09:52:34,018 - INFO [CommitProcessor:1:NIOServerCnxn@1435] - Closed socket connection for client /172.17.136.82:45020 which had sessionid 0x134485fd7bcb26f Here are the log snippets from 226, which is the server, the client reconnected to, before getting session expired event - 2012-01-27 09:52:38,190 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:12913:NIOServerCnxn@770] - Client attempting to renew session 0x134485fd7bcb26f at /172.17.136.82:49367 2012-01-27 09:52:38,191 - INFO [QuorumPeer:/0.0.0.0:12913:NIOServerCnxn@1573] - Invalid session 0x134485fd7bcb26f for client /172.17.136.82:49367, probably expired 2012-01-27 09:52:38,191 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:12913:NIOServerCnxn@1435] - Closed socket connection for client /172.17.136.82:49367 which had sessionid 0x134485fd7bcb26f wchp output from 226, taken on 01/30 - nnarkhed-ld:zk-cons-wchp-2012013000 nnarkhed$ grep 0x134485fd7bcb26f *226.*wchp* | wc -l 3 wchp output from 223, taken on 01/30 - nnarkhed-ld:zk-cons-wchp-2012013000 nnarkhed$ grep 0x134485fd7bcb26f *223.*wchp* | wc -l 0 cons output from 223 and 226, taken on 01/30 - nnarkhed-ld:zk-cons-wchp-2012013000 nnarkhed$ grep
[jira] [Updated] (ZOOKEEPER-1657) Increased CPU usage by unnecessary SASL checks
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gunnar Wagenknecht updated ZOOKEEPER-1657:
--
Attachment: zookeeper-hotspot-gone.png
After deploying the fix on a separate node and profiling again (similar
workload, similar conditions) I can confirm that ZooKeeper is no longer a
hot-spot.
Increased CPU usage by unnecessary SASL checks
--
Key: ZOOKEEPER-1657
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1657
Project: ZooKeeper
Issue Type: Bug
Components: java client
Affects Versions: 3.4.5
Reporter: Gunnar Wagenknecht
Labels: performance
Fix For: 3.5.0, 3.4.6
Attachments: ZOOKEEPER-1657.patch, ZOOKEEPER-1657.patch,
ZOOKEEPER-1657.patch, zookeeper-hotspot-gone.png, zookeeper-hotspot.png
I did some profiling in one of our Java environments and found an interesting
footprint in ZooKeeper. The SASL support seems to trigger a lot times on the
client although it's not even in use.
Is there a switch to disable SASL completely?
The attached screenshot shows a 10-minute profiling session on one of our
production Jetty servers. The Jetty server handles ~1k web requests per
minute. The average response time per web request is a few milli seconds. The
profiling was performed on a machine running for 24h.
We noticed a significant CPU increase on our servers when deploying an update
from ZooKeeper 3.3.2 to ZooKeeper 3.4.5. Thus, we started investigating. The
screenshot shows that only 32% CPU time are spent in Jetty. In contrast, 65%
are spend in ZooKeeper.
A few notes/thoughts:
* {{ClientCnxn$SendThread.clientTunneledAuthenticationInProgress}} seems to
be the culprit
* {{javax.security.auth.login.Configuration.getConfiguration}} seems to be
called very often?
* There is quite a bit reflection involved in
{{java.security.AccessController.doPrivileged}}
* No security manager is active in the JVM: I tend to place an if-check in
the code before calling {{AccessController.doPrivileged}}. When no SM is
installed, the runnable can be called directly which safes cycles.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Failed: ZOOKEEPER-1657 PreCommit Build #1421
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1657 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1421/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 63 lines...] [exec] == [exec] Applying patch. [exec] == [exec] == [exec] [exec] [exec] patch unexpectedly ends in middle of line [exec] /usr/bin/patch: Only garbage was found in the patch input. [exec] PATCH APPLICATION FAILED [exec] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12571944/zookeeper-hotspot-gone.png [exec] against trunk revision 1448007. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] -1 patch. The patch command could not apply the patch. [exec] [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1421//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] c3fac3903121462b8b95e665ac1a61eaa822d476 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623: exec returned: 1 Total time: 41 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-1657 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Commented] (ZOOKEEPER-1657) Increased CPU usage by unnecessary SASL checks
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13592595#comment-13592595
]
Hadoop QA commented on ZOOKEEPER-1657:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12571944/zookeeper-hotspot-gone.png
against trunk revision 1448007.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1421//console
This message is automatically generated.
Increased CPU usage by unnecessary SASL checks
--
Key: ZOOKEEPER-1657
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1657
Project: ZooKeeper
Issue Type: Bug
Components: java client
Affects Versions: 3.4.5
Reporter: Gunnar Wagenknecht
Labels: performance
Fix For: 3.5.0, 3.4.6
Attachments: ZOOKEEPER-1657.patch, ZOOKEEPER-1657.patch,
ZOOKEEPER-1657.patch, zookeeper-hotspot-gone.png, zookeeper-hotspot.png
I did some profiling in one of our Java environments and found an interesting
footprint in ZooKeeper. The SASL support seems to trigger a lot times on the
client although it's not even in use.
Is there a switch to disable SASL completely?
The attached screenshot shows a 10-minute profiling session on one of our
production Jetty servers. The Jetty server handles ~1k web requests per
minute. The average response time per web request is a few milli seconds. The
profiling was performed on a machine running for 24h.
We noticed a significant CPU increase on our servers when deploying an update
from ZooKeeper 3.3.2 to ZooKeeper 3.4.5. Thus, we started investigating. The
screenshot shows that only 32% CPU time are spent in Jetty. In contrast, 65%
are spend in ZooKeeper.
A few notes/thoughts:
* {{ClientCnxn$SendThread.clientTunneledAuthenticationInProgress}} seems to
be the culprit
* {{javax.security.auth.login.Configuration.getConfiguration}} seems to be
called very often?
* There is quite a bit reflection involved in
{{java.security.AccessController.doPrivileged}}
* No security manager is active in the JVM: I tend to place an if-check in
the code before calling {{AccessController.doPrivileged}}. When no SM is
installed, the runnable can be called directly which safes cycles.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1657) Increased CPU usage by unnecessary SASL checks
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13592756#comment-13592756
]
Eugene Koontz commented on ZOOKEEPER-1657:
--
Thanks for reporting back Gunnar! Good to hear that this patch fixes the
hotspot.
Increased CPU usage by unnecessary SASL checks
--
Key: ZOOKEEPER-1657
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1657
Project: ZooKeeper
Issue Type: Bug
Components: java client
Affects Versions: 3.4.5
Reporter: Gunnar Wagenknecht
Labels: performance
Fix For: 3.5.0, 3.4.6
Attachments: ZOOKEEPER-1657.patch, ZOOKEEPER-1657.patch,
ZOOKEEPER-1657.patch, zookeeper-hotspot-gone.png, zookeeper-hotspot.png
I did some profiling in one of our Java environments and found an interesting
footprint in ZooKeeper. The SASL support seems to trigger a lot times on the
client although it's not even in use.
Is there a switch to disable SASL completely?
The attached screenshot shows a 10-minute profiling session on one of our
production Jetty servers. The Jetty server handles ~1k web requests per
minute. The average response time per web request is a few milli seconds. The
profiling was performed on a machine running for 24h.
We noticed a significant CPU increase on our servers when deploying an update
from ZooKeeper 3.3.2 to ZooKeeper 3.4.5. Thus, we started investigating. The
screenshot shows that only 32% CPU time are spent in Jetty. In contrast, 65%
are spend in ZooKeeper.
A few notes/thoughts:
* {{ClientCnxn$SendThread.clientTunneledAuthenticationInProgress}} seems to
be the culprit
* {{javax.security.auth.login.Configuration.getConfiguration}} seems to be
called very often?
* There is quite a bit reflection involved in
{{java.security.AccessController.doPrivileged}}
* No security manager is active in the JVM: I tend to place an if-check in
the code before calling {{AccessController.doPrivileged}}. When no SM is
installed, the runnable can be called directly which safes cycles.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1657) Increased CPU usage by unnecessary SASL checks
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13592757#comment-13592757
]
Eugene Koontz commented on ZOOKEEPER-1657:
--
Regarding: Please justify why no new tests are needed for this patch.
This is an optimization that avoids some unnecessary code execution. No bugs
are fixed and no new behavior is introduced that would require additional
testing.
Increased CPU usage by unnecessary SASL checks
--
Key: ZOOKEEPER-1657
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1657
Project: ZooKeeper
Issue Type: Bug
Components: java client
Affects Versions: 3.4.5
Reporter: Gunnar Wagenknecht
Labels: performance
Fix For: 3.5.0, 3.4.6
Attachments: ZOOKEEPER-1657.patch, ZOOKEEPER-1657.patch,
ZOOKEEPER-1657.patch, zookeeper-hotspot-gone.png, zookeeper-hotspot.png
I did some profiling in one of our Java environments and found an interesting
footprint in ZooKeeper. The SASL support seems to trigger a lot times on the
client although it's not even in use.
Is there a switch to disable SASL completely?
The attached screenshot shows a 10-minute profiling session on one of our
production Jetty servers. The Jetty server handles ~1k web requests per
minute. The average response time per web request is a few milli seconds. The
profiling was performed on a machine running for 24h.
We noticed a significant CPU increase on our servers when deploying an update
from ZooKeeper 3.3.2 to ZooKeeper 3.4.5. Thus, we started investigating. The
screenshot shows that only 32% CPU time are spent in Jetty. In contrast, 65%
are spend in ZooKeeper.
A few notes/thoughts:
* {{ClientCnxn$SendThread.clientTunneledAuthenticationInProgress}} seems to
be the culprit
* {{javax.security.auth.login.Configuration.getConfiguration}} seems to be
called very often?
* There is quite a bit reflection involved in
{{java.security.AccessController.doPrivileged}}
* No security manager is active in the JVM: I tend to place an if-check in
the code before calling {{AccessController.doPrivileged}}. When no SM is
installed, the runnable can be called directly which safes cycles.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-107: --- Attachment: ZOOKEEPER-107-5-Mar.patch Small fix to reconfig java CLI command Allow dynamic changes to server cluster membership -- Key: ZOOKEEPER-107 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-107 Project: ZooKeeper Issue Type: Improvement Components: server Reporter: Patrick Hunt Assignee: Alexander Shraer Fix For: 3.5.0 Attachments: SimpleAddition.rtf, zkreconfig-usenixatc-final.pdf, ZOOKEEPER-107-14-Jan.patch, ZOOKEEPER-107-14-Oct.patch, ZOOKEEPER-107-15-Oct.patch, ZOOKEEPER-107-15-Oct-ver1.patch, ZOOKEEPER-107-15-Oct-ver2.patch, ZOOKEEPER-107-15-Oct-ver3.patch, ZOOKEEPER-107-16-Jan.patch, ZOOKEEPER-107-17-Jan.patch, ZOOKEEPER-107-18-Jan.patch, ZOOKEEPER-107-18-Jan-ver2.patch, ZOOKEEPER-107-1-Mar.patch, ZOOKEEPER-107-20-Jan.patch, ZOOKEEPER-107-20-July.patch, ZOOKEEPER-107-21-July.patch, ZOOKEEPER-107-22-Apr.patch, ZOOKEEPER-107-23-SEP.patch, ZOOKEEPER-107-24-Jan.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-NOV-ver2.patch, ZOOKEEPER-107-29-Feb.patch, ZOOKEEPER-107-2-Mar.patch, ZOOKEEPER-107-3-Oct.patch, ZOOKEEPER-107-4-Feb.patch, ZOOKEEPER-107-4-Feb-ver1.patch, ZOOKEEPER-107-4-Feb-ver2.patch, ZOOKEEPER-107-4-Feb-ver2.patch, ZOOKEEPER-107-5-Mar.patch, ZOOKEEPER-107-6-NOV-2.patch, ZOOKEEPER-107-7-NOV.patch, ZOOKEEPER-107-7-NOV-ver1.patch, ZOOKEEPER-107-7-NOV-ver2.patch, ZOOKEEPER-107-Aug-20.patch, ZOOKEEPER-107-Aug-20-ver1.patch, ZOOKEEPER-107-Aug-25.patch, ZOOKEEPER-107.patch, zookeeper-3.4.0.jar, zookeeper-dev-fatjar.jar, zookeeper-reconfig-sep11.patch, zookeeper-reconfig-sep12.patch, zoo_replicated1.cfg, zoo_replicated1.members Currently cluster membership is statically defined, adding/removing hosts to/from the server cluster dynamically needs to be supported. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Failed: ZOOKEEPER-107 PreCommit Build #1422
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-107 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1422/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 305010 lines...] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12571991/ZOOKEEPER-107-5-Mar.patch [exec] against trunk revision 1448007. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 49 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1422//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1422//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1422//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 9a5548fe0c31cc966de97de9544cc825e1d90f51 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623: exec returned: 1 Total time: 30 minutes 15 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-107 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13592847#comment-13592847 ] Hadoop QA commented on ZOOKEEPER-107: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12571991/ZOOKEEPER-107-5-Mar.patch against trunk revision 1448007. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 49 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1422//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1422//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1422//console This message is automatically generated. Allow dynamic changes to server cluster membership -- Key: ZOOKEEPER-107 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-107 Project: ZooKeeper Issue Type: Improvement Components: server Reporter: Patrick Hunt Assignee: Alexander Shraer Fix For: 3.5.0 Attachments: SimpleAddition.rtf, zkreconfig-usenixatc-final.pdf, ZOOKEEPER-107-14-Jan.patch, ZOOKEEPER-107-14-Oct.patch, ZOOKEEPER-107-15-Oct.patch, ZOOKEEPER-107-15-Oct-ver1.patch, ZOOKEEPER-107-15-Oct-ver2.patch, ZOOKEEPER-107-15-Oct-ver3.patch, ZOOKEEPER-107-16-Jan.patch, ZOOKEEPER-107-17-Jan.patch, ZOOKEEPER-107-18-Jan.patch, ZOOKEEPER-107-18-Jan-ver2.patch, ZOOKEEPER-107-1-Mar.patch, ZOOKEEPER-107-20-Jan.patch, ZOOKEEPER-107-20-July.patch, ZOOKEEPER-107-21-July.patch, ZOOKEEPER-107-22-Apr.patch, ZOOKEEPER-107-23-SEP.patch, ZOOKEEPER-107-24-Jan.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-NOV-ver2.patch, ZOOKEEPER-107-29-Feb.patch, ZOOKEEPER-107-2-Mar.patch, ZOOKEEPER-107-3-Oct.patch, ZOOKEEPER-107-4-Feb.patch, ZOOKEEPER-107-4-Feb-ver1.patch, ZOOKEEPER-107-4-Feb-ver2.patch, ZOOKEEPER-107-4-Feb-ver2.patch, ZOOKEEPER-107-5-Mar.patch, ZOOKEEPER-107-6-NOV-2.patch, ZOOKEEPER-107-7-NOV.patch, ZOOKEEPER-107-7-NOV-ver1.patch, ZOOKEEPER-107-7-NOV-ver2.patch, ZOOKEEPER-107-Aug-20.patch, ZOOKEEPER-107-Aug-20-ver1.patch, ZOOKEEPER-107-Aug-25.patch, ZOOKEEPER-107.patch, zookeeper-3.4.0.jar, zookeeper-dev-fatjar.jar, zookeeper-reconfig-sep11.patch, zookeeper-reconfig-sep12.patch, zoo_replicated1.cfg, zoo_replicated1.members Currently cluster membership is statically defined, adding/removing hosts to/from the server cluster dynamically needs to be supported. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-107: --- Attachment: ZOOKEEPER-107-5-Mar-ver2.patch Allow dynamic changes to server cluster membership -- Key: ZOOKEEPER-107 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-107 Project: ZooKeeper Issue Type: Improvement Components: server Reporter: Patrick Hunt Assignee: Alexander Shraer Fix For: 3.5.0 Attachments: SimpleAddition.rtf, zkreconfig-usenixatc-final.pdf, ZOOKEEPER-107-14-Jan.patch, ZOOKEEPER-107-14-Oct.patch, ZOOKEEPER-107-15-Oct.patch, ZOOKEEPER-107-15-Oct-ver1.patch, ZOOKEEPER-107-15-Oct-ver2.patch, ZOOKEEPER-107-15-Oct-ver3.patch, ZOOKEEPER-107-16-Jan.patch, ZOOKEEPER-107-17-Jan.patch, ZOOKEEPER-107-18-Jan.patch, ZOOKEEPER-107-18-Jan-ver2.patch, ZOOKEEPER-107-1-Mar.patch, ZOOKEEPER-107-20-Jan.patch, ZOOKEEPER-107-20-July.patch, ZOOKEEPER-107-21-July.patch, ZOOKEEPER-107-22-Apr.patch, ZOOKEEPER-107-23-SEP.patch, ZOOKEEPER-107-24-Jan.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-NOV-ver2.patch, ZOOKEEPER-107-29-Feb.patch, ZOOKEEPER-107-2-Mar.patch, ZOOKEEPER-107-3-Oct.patch, ZOOKEEPER-107-4-Feb.patch, ZOOKEEPER-107-4-Feb-ver1.patch, ZOOKEEPER-107-4-Feb-ver2.patch, ZOOKEEPER-107-4-Feb-ver2.patch, ZOOKEEPER-107-5-Mar.patch, ZOOKEEPER-107-5-Mar-ver2.patch, ZOOKEEPER-107-6-NOV-2.patch, ZOOKEEPER-107-7-NOV.patch, ZOOKEEPER-107-7-NOV-ver1.patch, ZOOKEEPER-107-7-NOV-ver2.patch, ZOOKEEPER-107-Aug-20.patch, ZOOKEEPER-107-Aug-20-ver1.patch, ZOOKEEPER-107-Aug-25.patch, ZOOKEEPER-107.patch, zookeeper-3.4.0.jar, zookeeper-dev-fatjar.jar, zookeeper-reconfig-sep11.patch, zookeeper-reconfig-sep12.patch, zoo_replicated1.cfg, zoo_replicated1.members Currently cluster membership is statically defined, adding/removing hosts to/from the server cluster dynamically needs to be supported. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Success: ZOOKEEPER-107 PreCommit Build #1423
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-107 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1423/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 296710 lines...] [exec] BUILD SUCCESSFUL [exec] Total time: 0 seconds [exec] [exec] [exec] [exec] [exec] +1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12572003/ZOOKEEPER-107-5-Mar-ver2.patch [exec] against trunk revision 1448007. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 50 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1423//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1423//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1423//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 9c74438f23e7ea87d649e8883584830431f9ece5 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 33 minutes 52 seconds Archiving artifacts Recording test results Description set: ZOOKEEPER-107 Email was triggered for: Success Sending email for trigger: Success ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13592898#comment-13592898 ] Hadoop QA commented on ZOOKEEPER-107: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12572003/ZOOKEEPER-107-5-Mar-ver2.patch against trunk revision 1448007. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 50 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1423//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1423//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1423//console This message is automatically generated. Allow dynamic changes to server cluster membership -- Key: ZOOKEEPER-107 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-107 Project: ZooKeeper Issue Type: Improvement Components: server Reporter: Patrick Hunt Assignee: Alexander Shraer Fix For: 3.5.0 Attachments: SimpleAddition.rtf, zkreconfig-usenixatc-final.pdf, ZOOKEEPER-107-14-Jan.patch, ZOOKEEPER-107-14-Oct.patch, ZOOKEEPER-107-15-Oct.patch, ZOOKEEPER-107-15-Oct-ver1.patch, ZOOKEEPER-107-15-Oct-ver2.patch, ZOOKEEPER-107-15-Oct-ver3.patch, ZOOKEEPER-107-16-Jan.patch, ZOOKEEPER-107-17-Jan.patch, ZOOKEEPER-107-18-Jan.patch, ZOOKEEPER-107-18-Jan-ver2.patch, ZOOKEEPER-107-1-Mar.patch, ZOOKEEPER-107-20-Jan.patch, ZOOKEEPER-107-20-July.patch, ZOOKEEPER-107-21-July.patch, ZOOKEEPER-107-22-Apr.patch, ZOOKEEPER-107-23-SEP.patch, ZOOKEEPER-107-24-Jan.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-NOV-ver2.patch, ZOOKEEPER-107-29-Feb.patch, ZOOKEEPER-107-2-Mar.patch, ZOOKEEPER-107-3-Oct.patch, ZOOKEEPER-107-4-Feb.patch, ZOOKEEPER-107-4-Feb-ver1.patch, ZOOKEEPER-107-4-Feb-ver2.patch, ZOOKEEPER-107-4-Feb-ver2.patch, ZOOKEEPER-107-5-Mar.patch, ZOOKEEPER-107-5-Mar-ver2.patch, ZOOKEEPER-107-6-NOV-2.patch, ZOOKEEPER-107-7-NOV.patch, ZOOKEEPER-107-7-NOV-ver1.patch, ZOOKEEPER-107-7-NOV-ver2.patch, ZOOKEEPER-107-Aug-20.patch, ZOOKEEPER-107-Aug-20-ver1.patch, ZOOKEEPER-107-Aug-25.patch, ZOOKEEPER-107.patch, zookeeper-3.4.0.jar, zookeeper-dev-fatjar.jar, zookeeper-reconfig-sep11.patch, zookeeper-reconfig-sep12.patch, zoo_replicated1.cfg, zoo_replicated1.members Currently cluster membership is statically defined, adding/removing hosts to/from the server cluster dynamically needs to be supported. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
ZooKeeper_branch33_solaris - Build # 461 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch33_solaris/461/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 100105 lines...] [junit] 2013-03-05 06:57:49,937 - INFO [main:ZooKeeperServer@154] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test6931814298090266294.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test6931814298090266294.junit.dir/version-2 [junit] 2013-03-05 06:57:49,938 - INFO [main:NIOServerCnxn$Factory@143] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2013-03-05 06:57:49,940 - INFO [main:FileSnap@82] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test6931814298090266294.junit.dir/version-2/snapshot.0 [junit] 2013-03-05 06:57:49,943 - INFO [main:FileTxnSnapLog@256] - Snapshotting: b [junit] 2013-03-05 06:57:49,945 - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-03-05 06:57:49,946 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@251] - Accepted socket connection from /127.0.0.1:44724 [junit] 2013-03-05 06:57:49,947 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1237] - Processing stat command from /127.0.0.1:44724 [junit] 2013-03-05 06:57:49,948 - INFO [Thread-4:NIOServerCnxn$StatCommand@1153] - Stat command output [junit] 2013-03-05 06:57:49,948 - INFO [Thread-4:NIOServerCnxn@1435] - Closed socket connection for client /127.0.0.1:44724 (no session established for client) [junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] expect:InMemoryDataTree [junit] found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] expect:StandaloneServer_port [junit] found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-03-05 06:57:49,950 - INFO [main:ClientBase@408] - STOPPING server [junit] 2013-03-05 06:57:49,952 - INFO [ProcessThread:-1:PrepRequestProcessor@128] - PrepRequestProcessor exited loop! [junit] 2013-03-05 06:57:49,952 - INFO [SyncThread:0:SyncRequestProcessor@151] - SyncRequestProcessor exited! [junit] 2013-03-05 06:57:49,953 - INFO [main:FinalRequestProcessor@370] - shutdown of request processor complete [junit] 2013-03-05 06:57:49,954 - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] ensureOnly:[] [junit] 2013-03-05 06:57:49,956 - INFO [main:ClientBase@401] - STARTING server [junit] 2013-03-05 06:57:49,957 - INFO [main:ZooKeeperServer@154] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test6931814298090266294.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test6931814298090266294.junit.dir/version-2 [junit] 2013-03-05 06:57:49,958 - INFO [main:NIOServerCnxn$Factory@143] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2013-03-05 06:57:49,959 - INFO [main:FileSnap@82] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test6931814298090266294.junit.dir/version-2/snapshot.b [junit] 2013-03-05 06:57:49,961 - INFO [main:FileTxnSnapLog@256] - Snapshotting: b [junit] 2013-03-05 06:57:49,963 - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-03-05 06:57:49,964 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@251] - Accepted socket connection from /127.0.0.1:44726 [junit] 2013-03-05 06:57:49,965 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1237] - Processing stat command from /127.0.0.1:44726 [junit] 2013-03-05 06:57:49,966 - INFO [Thread-5:NIOServerCnxn$StatCommand@1153] - Stat command output [junit] 2013-03-05 06:57:49,966 - INFO [Thread-5:NIOServerCnxn@1435] - Closed socket connection for client /127.0.0.1:44726 (no session established for client) [junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] expect:InMemoryDataTree [junit] found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] expect:StandaloneServer_port [junit] found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-03-05 06:57:49,968 - INFO
[jira] [Commented] (BOOKKEEPER-578) LedgerCacheImpl is reserving 1/3 of Heap size but allocates NonHeap memory
[ https://issues.apache.org/jira/browse/BOOKKEEPER-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13592462#comment-13592462 ] Ivan Kelly commented on BOOKKEEPER-578: --- As I understand it, direct byte buffers can be used for DMA, which skips a memory copy when reading in pages. LedgerCacheImpl is reserving 1/3 of Heap size but allocates NonHeap memory -- Key: BOOKKEEPER-578 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-578 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Matteo Merli Priority: Minor By default the page limit parameter is set to -1, which means to assign 1/3 of Heap space to the LedgerCache. Each LedgerEntryPage is then allocating the memory outside the heap (ByteBuffer.allocateDirect()). This makes BK to use more memory than the -XmxNN configured setting. Is there any particular reason for the LedgerEntryPage buffer to be allocated outside the java heap? Could that be changed? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-578) LedgerCacheImpl is reserving 1/3 of Heap size but allocates NonHeap memory
[ https://issues.apache.org/jira/browse/BOOKKEEPER-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13592528#comment-13592528 ] Matteo Merli commented on BOOKKEEPER-578: - Yes, I've seen the buffers are read with NIO from disk so it makes sense to direct buffers. The only thing, it's that using the default on 1/3 heap for that is misleading, because one assumes that memory will be allocated from inside the java heap. Say, if I configure the bookie jvm with -Xmx20g then the total amount of memory that the jvm will be using is 27Gb (20 + 20*1/3). LedgerCacheImpl is reserving 1/3 of Heap size but allocates NonHeap memory -- Key: BOOKKEEPER-578 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-578 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Matteo Merli Priority: Minor By default the page limit parameter is set to -1, which means to assign 1/3 of Heap space to the LedgerCache. Each LedgerEntryPage is then allocating the memory outside the heap (ByteBuffer.allocateDirect()). This makes BK to use more memory than the -XmxNN configured setting. Is there any particular reason for the LedgerEntryPage buffer to be allocated outside the java heap? Could that be changed? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-578) LedgerCacheImpl is reserving 1/3 of Heap size but allocates NonHeap memory
[ https://issues.apache.org/jira/browse/BOOKKEEPER-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13592536#comment-13592536 ] Ivan Kelly commented on BOOKKEEPER-578: --- yes. It's a documentation issue. I admit that before this issue cropped up, I assumed that direct memory was counted on the heap stats. We have 2 options. Document this better (which might involve updating the scripts to warn if mx is set too high), or switch to using non direct buffers. Direct buffers are slower to allocate, but avoid the read. But maybe the read isn't an issue. LedgerCacheImpl is reserving 1/3 of Heap size but allocates NonHeap memory -- Key: BOOKKEEPER-578 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-578 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-server Reporter: Matteo Merli Priority: Minor By default the page limit parameter is set to -1, which means to assign 1/3 of Heap space to the LedgerCache. Each LedgerEntryPage is then allocating the memory outside the heap (ByteBuffer.allocateDirect()). This makes BK to use more memory than the -XmxNN configured setting. Is there any particular reason for the LedgerEntryPage buffer to be allocated outside the java heap? Could that be changed? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
