Re: QA for pull requests
Merged: https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=commitdiff;h=881256ea97a19e51b1c6e9a114e6e61ad83bd4ec;hp=440e0923dd9e3be533a196fdd6ada960860ca7f6 Thanks Flavio! -rgs On 12 November 2016 at 19:48, Raúl Gutiérrez Segalés wrote: > Looking > > On 12 November 2016 at 11:25, Flavio Junqueira wrote: > >> Second attempt, could any of the committers of this project take a look >> at this, please? >> >> -Flavio >> >> > On 11 Nov 2016, at 08:11, Flavio Junqueira wrote: >> > >> > I have made some changes to fix a couple issues with the QA for pull >> requests. Can I have a committer checking it out, please? We need to have >> this in otherwise the builds will keep failing. >> > >> > The issue is ZOOKEEPER-2631 and the pull request is this one: >> > >> > https://github.com/apache/zookeeper/pull/104/ >> > >> > Thanks, >> > >> > -Flavio >> > >> >> On 10 Nov 2016, at 18:33, Flavio P JUNQUEIRA wrote: >> >> >> >> I think the way I've done extract the jira number isn't working, none >> of the recent pull requests is going through because the title isn't in the >> expected format. We need to make that more robust. >> >> >> >> If anyone wants to contribute, then great, otherwise I'll fix it when >> I have a chance. >> >> >> >> -Flavio >> > >> >> >
Re: QA for pull requests
Looking On 12 November 2016 at 11:25, Flavio Junqueira wrote: > Second attempt, could any of the committers of this project take a look at > this, please? > > -Flavio > > > On 11 Nov 2016, at 08:11, Flavio Junqueira wrote: > > > > I have made some changes to fix a couple issues with the QA for pull > requests. Can I have a committer checking it out, please? We need to have > this in otherwise the builds will keep failing. > > > > The issue is ZOOKEEPER-2631 and the pull request is this one: > > > > https://github.com/apache/zookeeper/pull/104/ > > > > Thanks, > > > > -Flavio > > > >> On 10 Nov 2016, at 18:33, Flavio P JUNQUEIRA wrote: > >> > >> I think the way I've done extract the jira number isn't working, none > of the recent pull requests is going through because the title isn't in the > expected format. We need to make that more robust. > >> > >> If anyone wants to contribute, then great, otherwise I'll fix it when I > have a chance. > >> > >> -Flavio > > > >
Re: QA for pull requests
Second attempt, could any of the committers of this project take a look at this, please? -Flavio > On 11 Nov 2016, at 08:11, Flavio Junqueira wrote: > > I have made some changes to fix a couple issues with the QA for pull > requests. Can I have a committer checking it out, please? We need to have > this in otherwise the builds will keep failing. > > The issue is ZOOKEEPER-2631 and the pull request is this one: > > https://github.com/apache/zookeeper/pull/104/ > > Thanks, > > -Flavio > >> On 10 Nov 2016, at 18:33, Flavio P JUNQUEIRA wrote: >> >> I think the way I've done extract the jira number isn't working, none of the >> recent pull requests is going through because the title isn't in the >> expected format. We need to make that more robust. >> >> If anyone wants to contribute, then great, otherwise I'll fix it when I have >> a chance. >> >> -Flavio >
Re: QA for pull requests
I have made some changes to fix a couple issues with the QA for pull requests. Can I have a committer checking it out, please? We need to have this in otherwise the builds will keep failing. The issue is ZOOKEEPER-2631 and the pull request is this one: https://github.com/apache/zookeeper/pull/104/ Thanks, -Flavio > On 10 Nov 2016, at 18:33, Flavio P JUNQUEIRA wrote: > > I think the way I've done extract the jira number isn't working, none of the > recent pull requests is going through because the title isn't in the expected > format. We need to make that more robust. > > If anyone wants to contribute, then great, otherwise I'll fix it when I have > a chance. > > -Flavio