Re: [Development] Strange behavior on 5.12 branch and moc genrated file ( KDE application )
On Thursday, 6 September 2018 05:38:08 PDT Helio Chissini de Castro wrote: > No, still getting same error. Updated. I made a signed-char error: if (c < 0x20) is true for non-ASCII when chars are signed. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Strange behavior on 5.12 branch and moc genrated file ( KDE application )
Hi No, still getting same error. The .moc generated file is the same, so or this not solve the issue, or something is fishy on my environment. I'm doing a full clean build by hand with your patch to dobcle check right now, but as concerned on my current status, still a nope. Here's the moc compile line that resulting the attached file: kcoreaddons 1 /opt/qt5/bin/moc -I/code/kde/build-kde/frameworks/kcoreaddons/autotests -I/code/kde/build-kde/frameworks/kcoreaddons/autotests/jsonplugin2_autogen/include -I/code/kde/build-kde/frameworks/kcoreaddons/src/lib/../.. -I/code/kde/build-kde/frameworks/kcoreaddons/src/lib/io -I/code/kde/build-kde/frameworks/kcoreaddons/src/lib -I/code/kde/src/frameworks/kcoreaddons/autotests -I/code/kde/src/frameworks/kcoreaddons/src/lib/caching -I/code/kde/src/frameworks/kcoreaddons/src/lib/io -I/code/kde/src/frameworks/kcoreaddons/src/lib/jobs -I/code/kde/src/frameworks/kcoreaddons/src/lib/plugin -I/code/kde/src/frameworks/kcoreaddons/src/lib/randomness -I/code/kde/src/frameworks/kcoreaddons/src/lib/text -I/code/kde/src/frameworks/kcoreaddons/src/lib/util -I/code/kde/src/frameworks/kcoreaddons/src/lib -I/opt/qt5/include -I/opt/qt5/include/QtCore -I/opt/qt5/./mkspecs/linux-clang "-DKDELIBS4CONFIGMIGRATOR_DATA_DIR=\"/code/kde/src/frameworks/kcoreaddons/autotests/data\"" -DQT_CORE_LIB -DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_FROM_BYTEARRAY -DQT_NO_CAST_TO_ASCII -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT -DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_NO_URL_CAST_FROM_STRING -DQT_USE_QSTRINGBUILDER -D_GNU_SOURCE -D_LARGEFILE64_SOURCE --include /code/kde/build-kde/frameworks/kcoreaddons/autotests/jsonplugin2_autogen/moc_predefs.h -o /code/kde/build-kde/frameworks/kcoreaddons/autotests/jsonplugin2_autogen/include/jsonplugin2.moc /code/kde/src/frameworks/kcoreaddons/autotests/jsonplugin2.cpp []'s On Wed, 5 Sep 2018 at 19:05, Thiago Macieira wrote: > On Wednesday, 5 September 2018 09:57:30 PDT Thiago Macieira wrote: > > On Wednesday, 5 September 2018 00:20:22 PDT Helio Chissini de Castro > wrote: > > > jsonplugin2.moc:153:1: error: narrowing conversion of ‘'\303'’ > > > from ‘char’ to ‘unsigned char’ inside { } [-Wnarrowing] > > > }; > > > > [cut] > > > > > lude/jsonplugin2.moc:123:48: error: constant expression evaluates to > -61 > > > which cannot be narrowed to type 'unsigned char' > [-Wc++11-narrowing] > > > ']', 0x76, 'E', 's', 't', 'e', ' ', '\xc3', > > >^~ > > > > I guess I didn't test non-ASCII content. > > > > moc was changed recently to save data in CBOR format instead of our > binary > > JSON. > > Please test this fix: > https://codereview.qt-project.org/238950 > > -- > Thiago Macieira - thiago.macieira (AT) intel.com > Software Architect - Intel Open Source Technology Center > > > > ___ > Development mailing list > Development@qt-project.org > http://lists.qt-project.org/mailman/listinfo/development > / ** Meta object code from reading C++ file 'jsonplugin2.cpp' ** ** Created by: The Qt Meta Object Compiler version 67 (Qt 5.12.0) ** ** WARNING! All changes made in this file will be lost! */ #include #include #include #if !defined(Q_MOC_OUTPUT_REVISION) #error "The header file 'jsonplugin2.cpp' doesn't include ." #elif Q_MOC_OUTPUT_REVISION != 67 #error "This file was generated using the moc from 5.12.0. It" #error "cannot be used with the include files from this version of Qt." #error "(The moc has changed too much.)" #endif QT_BEGIN_MOC_NAMESPACE QT_WARNING_PUSH QT_WARNING_DISABLE_DEPRECATED struct qt_meta_stringdata_jsonplugin2_t { QByteArrayData data[1]; char stringdata0[12]; }; #define QT_MOC_LITERAL(idx, ofs, len) \ Q_STATIC_BYTE_ARRAY_DATA_HEADER_INITIALIZER_WITH_OFFSET(len, \ qptrdiff(offsetof(qt_meta_stringdata_jsonplugin2_t, stringdata0) + ofs \ - idx * sizeof(QByteArrayData)) \ ) static const qt_meta_stringdata_jsonplugin2_t qt_meta_stringdata_jsonplugin2 = { { QT_MOC_LITERAL(0, 0, 11) // "jsonplugin2" }, "jsonplugin2" }; #undef QT_MOC_LITERAL static const uint qt_meta_data_jsonplugin2[] = { // content: 8, // revision 0, // classname 0,0, // classinfo 0,0, // methods 0,0, // properties 0,0, // enums/sets 0,0, // constructors 0, // flags 0, // signalCount 0// eod }; void jsonplugin2::qt_static_metacall(QObject *_o, QMetaObject::Call _c, int _id, void **_a) { Q_UNUSED(_o); Q_UNUSED(_id); Q_UNUSED(_c); Q_UNUSED(_a); } QT_INIT_METAOBJECT const QMetaObject jsonplugin2::staticMetaObject = { { &KPluginFactory::staticMetaObject, qt_meta_stringdata_jsonplugin2.data, qt_meta_data_jsonplugin2, qt_static_metaca
Re: [Development] Strange behavior on 5.12 branch and moc genrated file ( KDE application )
On Wednesday, 5 September 2018 09:57:30 PDT Thiago Macieira wrote: > On Wednesday, 5 September 2018 00:20:22 PDT Helio Chissini de Castro wrote: > > jsonplugin2.moc:153:1: error: narrowing conversion of ‘'\303'’ > > from ‘char’ to ‘unsigned char’ inside { } [-Wnarrowing] > > }; > > [cut] > > > lude/jsonplugin2.moc:123:48: error: constant expression evaluates to -61 > > which cannot be narrowed to type 'unsigned char' [-Wc++11-narrowing] > > ']', 0x76, 'E', 's', 't', 'e', ' ', '\xc3', > >^~ > > I guess I didn't test non-ASCII content. > > moc was changed recently to save data in CBOR format instead of our binary > JSON. Please test this fix: https://codereview.qt-project.org/238950 -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Strange behavior on 5.12 branch and moc genrated file ( KDE application )
On Wednesday, 5 September 2018 00:20:22 PDT Helio Chissini de Castro wrote: > jsonplugin2.moc:153:1: error: narrowing conversion of ‘'\303'’ > from ‘char’ to ‘unsigned char’ inside { } [-Wnarrowing] > }; [cut] > lude/jsonplugin2.moc:123:48: error: constant expression evaluates to -61 > which cannot be narrowed to type 'unsigned char' [-Wc++11-narrowing] > ']', 0x76, 'E', 's', 't', 'e', ' ', '\xc3', >^~ I guess I didn't test non-ASCII content. moc was changed recently to save data in CBOR format instead of our binary JSON. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Strange behavior on 5.12 branch and moc genrated file ( KDE application )
On 9/5/18 2:11 PM, Ville Voutilainen wrote: On 5 September 2018 at 14:42, Helio Chissini de Castro wrote: Unfortunately not. Just compiled again reverting this commit and the issue still there. No ideas for now :-/ Any volunteers to bisect the problem? Most likely https://codereview.qt-project.org/233481 (Plugins: store the metadata in CBOR instead of binary JSON) ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Strange behavior on 5.12 branch and moc genrated file ( KDE application )
On 5 September 2018 at 14:42, Helio Chissini de Castro wrote: > Unfortunately not. > > Just compiled again reverting this commit and the issue still there. > > No ideas for now :-/ Any volunteers to bisect the problem? ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Strange behavior on 5.12 branch and moc genrated file ( KDE application )
Unfortunately not. Just compiled again reverting this commit and the issue still there. No ideas for now :-/ On Wed, 5 Sep 2018 at 10:17, Liang Qi wrote: > Perhaps it's related with https://codereview.qt-project.org/#/c/235352/ . > > --Liang > > On Wed, 5 Sep 2018 at 09:20, Helio Chissini de Castro > wrote: > >> Morning guys >> >> After compile 5.12 branch from yesterday morning, i got one KDE >> application failing due a compiler error on a generated moc file. >> Is there any moc relevant change ? I didn't change my compiler >> environment from previous 5.11 and always compile all in a clean chroot, >> with no previous versions installed. >> Qt itself was build with clang 6.0.1 >> >> Here's the logs >> >> With gcc 8.1.1 x86_64: >> >> In file included from >> /code/kde/src/frameworks/kcoreaddons/autotests/jsonplugin2.cpp:23: >> /code/kde/src/frameworks/kcoreaddons/src/lib/plugin/kpluginfactory.h: In >> member function ‘void KPluginFactory::registerPlugin(const QString&, >> KPluginFactory::CreateInstanceFunction) [with T = JsonPlugin2; >> KPluginFactory::CreateInstanceFunction = QObject* (*)(QWidget*, QObject*, >> const QList&); QVariantList = QList]’: >> /code/kde/src/frameworks/kcoreaddons/src/lib/plugin/kpluginfactory.h:487:74: >> warning: zero as null pointer constant [-Wzero-as-null-pointer-constant] >> = >> InheritanceChecker().createInstanceFunction(reinterpret_cast(0))) >> >> ^~~~ >> In file included from >> /code/kde/src/frameworks/kcoreaddons/autotests/jsonplugin2.cpp:34: >> /code/kde/build-kde/frameworks/kcoreaddons/autotests/jsonplugin2_autogen/include/jsonplugin2.moc: >> At global scope: >> /code/kde/build-kde/frameworks/kcoreaddons/autotests/jsonplugin2_autogen/include/jsonplugin2.moc:153:1: >> error: narrowing conversion of ‘'\303'’ from ‘char’ to ‘unsigned >> char’ inside { } [-Wnarrowing] >> }; >> ^ >> /code/kde/build-kde/frameworks/kcoreaddons/autotests/jsonplugin2_autogen/include/jsonplugin2.moc:153:1: >> error: narrowing conversion of ‘'\3777651'’ from ‘char’ to ‘unsigned >> char’ inside { } [-Wnarrowing] >> >> >> >> With clang 6.0.1 x86_64 >> >> [ 63%] Building CXX object >> autotests/CMakeFiles/jsonplugin2.dir/jsonplugin2.cpp.o >> In file included from >> /code/kde/src/frameworks/kcoreaddons/autotests/jsonplugin2.cpp:34: >> /code/kde/build-kde/frameworks/kcoreaddons/autotests/jsonplugin2_autogen/include/jsonplugin2.moc:123:48: >> error: constant expression evaluates to -61 >> which cannot be narrowed to type 'unsigned char' [-Wc++11-narrowing] >> ']', 0x76, 'E', 's', 't', 'e', ' ', '\xc3', >>^~ >> /code/kde/build-kde/frameworks/kcoreaddons/autotests/jsonplugin2_autogen/include/jsonplugin2.moc:123:48: >> note: insert an explicit cast to silence >> this issue >> ']', 0x76, 'E', 's', 't', 'e', ' ', '\xc3', >>^~ >>static_cast> char>( ) >> /code/kde/build-kde/frameworks/kcoreaddons/autotests/jsonplugin2_autogen/include/jsonplugin2.moc:124:5: >> error: constant expression evaluates to -87 >> which cannot be narrowed to type 'unsigned char' [-Wc++11-narrowing] >> '\xa9', ' ', 'o', 'u', 't', 'r', 'o', ' ', >> ^~ >> >> Any idea ? >> >> >> ___ >> Development mailing list >> Development@qt-project.org >> http://lists.qt-project.org/mailman/listinfo/development >> > ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Strange behavior on 5.12 branch and moc genrated file ( KDE application )
Perhaps it's related with https://codereview.qt-project.org/#/c/235352/ . --Liang On Wed, 5 Sep 2018 at 09:20, Helio Chissini de Castro wrote: > Morning guys > > After compile 5.12 branch from yesterday morning, i got one KDE > application failing due a compiler error on a generated moc file. > Is there any moc relevant change ? I didn't change my compiler environment > from previous 5.11 and always compile all in a clean chroot, with no > previous versions installed. > Qt itself was build with clang 6.0.1 > > Here's the logs > > With gcc 8.1.1 x86_64: > > In file included from > /code/kde/src/frameworks/kcoreaddons/autotests/jsonplugin2.cpp:23: > /code/kde/src/frameworks/kcoreaddons/src/lib/plugin/kpluginfactory.h: In > member function ‘void KPluginFactory::registerPlugin(const QString&, > KPluginFactory::CreateInstanceFunction) [with T = JsonPlugin2; > KPluginFactory::CreateInstanceFunction = QObject* (*)(QWidget*, QObject*, > const QList&); QVariantList = QList]’: > /code/kde/src/frameworks/kcoreaddons/src/lib/plugin/kpluginfactory.h:487:74: > warning: zero as null pointer constant [-Wzero-as-null-pointer-constant] > = > InheritanceChecker().createInstanceFunction(reinterpret_cast(0))) > > ^~~~ > In file included from > /code/kde/src/frameworks/kcoreaddons/autotests/jsonplugin2.cpp:34: > /code/kde/build-kde/frameworks/kcoreaddons/autotests/jsonplugin2_autogen/include/jsonplugin2.moc: > At global scope: > /code/kde/build-kde/frameworks/kcoreaddons/autotests/jsonplugin2_autogen/include/jsonplugin2.moc:153:1: > error: narrowing conversion of ‘'\303'’ from ‘char’ to ‘unsigned > char’ inside { } [-Wnarrowing] > }; > ^ > /code/kde/build-kde/frameworks/kcoreaddons/autotests/jsonplugin2_autogen/include/jsonplugin2.moc:153:1: > error: narrowing conversion of ‘'\3777651'’ from ‘char’ to ‘unsigned > char’ inside { } [-Wnarrowing] > > > > With clang 6.0.1 x86_64 > > [ 63%] Building CXX object > autotests/CMakeFiles/jsonplugin2.dir/jsonplugin2.cpp.o > In file included from > /code/kde/src/frameworks/kcoreaddons/autotests/jsonplugin2.cpp:34: > /code/kde/build-kde/frameworks/kcoreaddons/autotests/jsonplugin2_autogen/include/jsonplugin2.moc:123:48: > error: constant expression evaluates to -61 > which cannot be narrowed to type 'unsigned char' [-Wc++11-narrowing] > ']', 0x76, 'E', 's', 't', 'e', ' ', '\xc3', >^~ > /code/kde/build-kde/frameworks/kcoreaddons/autotests/jsonplugin2_autogen/include/jsonplugin2.moc:123:48: > note: insert an explicit cast to silence > this issue > ']', 0x76, 'E', 's', 't', 'e', ' ', '\xc3', >^~ >static_cast( > ) > /code/kde/build-kde/frameworks/kcoreaddons/autotests/jsonplugin2_autogen/include/jsonplugin2.moc:124:5: > error: constant expression evaluates to -87 > which cannot be narrowed to type 'unsigned char' [-Wc++11-narrowing] > '\xa9', ' ', 'o', 'u', 't', 'r', 'o', ' ', > ^~ > > Any idea ? > > > ___ > Development mailing list > Development@qt-project.org > http://lists.qt-project.org/mailman/listinfo/development > ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
[Development] Strange behavior on 5.12 branch and moc genrated file ( KDE application )
Morning guys After compile 5.12 branch from yesterday morning, i got one KDE application failing due a compiler error on a generated moc file. Is there any moc relevant change ? I didn't change my compiler environment from previous 5.11 and always compile all in a clean chroot, with no previous versions installed. Qt itself was build with clang 6.0.1 Here's the logs With gcc 8.1.1 x86_64: In file included from /code/kde/src/frameworks/kcoreaddons/autotests/jsonplugin2.cpp:23: /code/kde/src/frameworks/kcoreaddons/src/lib/plugin/kpluginfactory.h: In member function ‘void KPluginFactory::registerPlugin(const QString&, KPluginFactory::CreateInstanceFunction) [with T = JsonPlugin2; KPluginFactory::CreateInstanceFunction = QObject* (*)(QWidget*, QObject*, const QList&); QVariantList = QList]’: /code/kde/src/frameworks/kcoreaddons/src/lib/plugin/kpluginfactory.h:487:74: warning: zero as null pointer constant [-Wzero-as-null-pointer-constant] = InheritanceChecker().createInstanceFunction(reinterpret_cast(0))) ^~~~ In file included from /code/kde/src/frameworks/kcoreaddons/autotests/jsonplugin2.cpp:34: /code/kde/build-kde/frameworks/kcoreaddons/autotests/jsonplugin2_autogen/include/jsonplugin2.moc: At global scope: /code/kde/build-kde/frameworks/kcoreaddons/autotests/jsonplugin2_autogen/include/jsonplugin2.moc:153:1: error: narrowing conversion of ‘'\303'’ from ‘char’ to ‘unsigned char’ inside { } [-Wnarrowing] }; ^ /code/kde/build-kde/frameworks/kcoreaddons/autotests/jsonplugin2_autogen/include/jsonplugin2.moc:153:1: error: narrowing conversion of ‘'\3777651'’ from ‘char’ to ‘unsigned char’ inside { } [-Wnarrowing] With clang 6.0.1 x86_64 [ 63%] Building CXX object autotests/CMakeFiles/jsonplugin2.dir/jsonplugin2.cpp.o In file included from /code/kde/src/frameworks/kcoreaddons/autotests/jsonplugin2.cpp:34: /code/kde/build-kde/frameworks/kcoreaddons/autotests/jsonplugin2_autogen/include/jsonplugin2.moc:123:48: error: constant expression evaluates to -61 which cannot be narrowed to type 'unsigned char' [-Wc++11-narrowing] ']', 0x76, 'E', 's', 't', 'e', ' ', '\xc3', ^~ /code/kde/build-kde/frameworks/kcoreaddons/autotests/jsonplugin2_autogen/include/jsonplugin2.moc:123:48: note: insert an explicit cast to silence this issue ']', 0x76, 'E', 's', 't', 'e', ' ', '\xc3', ^~ static_cast( ) /code/kde/build-kde/frameworks/kcoreaddons/autotests/jsonplugin2_autogen/include/jsonplugin2.moc:124:5: error: constant expression evaluates to -87 which cannot be narrowed to type 'unsigned char' [-Wc++11-narrowing] '\xa9', ' ', 'o', 'u', 't', 'r', 'o', ' ', ^~ Any idea ? ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development