Re: [git pull] drm fixes for 6.11-rc8
The pull request you sent on Fri, 13 Sep 2024 16:46:14 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-09-13 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/46040ea8a6a58e5645d91ffa3ead7ed8fd633d56 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.11-rc7
The pull request you sent on Fri, 6 Sep 2024 14:42:24 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-09-06 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/ea462f0fa438381e0d420f94193c075e2a114894 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.11-rc6
On Mon, 2024-09-02 at 12:33 +0200, Christian König wrote: > Am 02.09.24 um 11:32 schrieb Thomas Hellström: > > On Mon, 2024-09-02 at 08:13 +1000, Dave Airlie wrote: > > > On Fri, 30 Aug 2024 at 12:32, Linus Torvalds > > > wrote: > > > > On Fri, 30 Aug 2024 at 14:08, Dave Airlie > > > > wrote: > > > > > The TTM revert is due to some stuttering graphical apps > > > > > probably > > > > > due > > > > > to longer stalls while prefaulting. > > > > Yeah, trying to pre-fault a PMD worth of pages in one go is > > > > just > > > > crazy talk. > > > > > > > > Now, if it was PMD-aligned and you faulted in a single PMD, > > > > that > > > > would > > > > be different. But just doing prn_insert_page() in a loop is > > > > insane. > > > > > > > > The code doesn't even stop when it hits a page that already > > > > existed, > > > > and it keeps locking and unlocking the last-level page table > > > > over > > > > and > > > > over again. > > > > > > > > Honestly, that code is questionable even for the *small* value, > > > > much > > > > less the "a PMD size" case. > > > > > > > > Now, if you have an array of 'struct page *", you can use > > > > vm_insert_pages(), and that's reasonably efficient. > > > > > > > > And if you have a *contiguous* are of pfns, you can use > > > > remap_pfn_range(). > > > > > > > > But that "insert one pfn at a time" that the drm layer does is > > > > complete garbage. You're not speeding anything up, you're just > > > > digging > > > > deeper. > > > > > I wonder if there is functionality that could be provided in a > > > common > > > helper, by the mm layers, or if there would be too many locking > > > interactions to make it sane, > > > > > > It seems too fraught with danger for drivers or subsystems to be > > > just > > > doing this in the simplest way that isn't actually that smart. > > Hmm. I see even the "Don't error on prefaults" check was broken at > > some > > point :/. > > > > There have been numerous ways to try to address this, > > > > The remap_pfn_range was last tried, at least in the context of the > > i915 > > driver IIRC by Christoph Hellwig but had to be ripped out since it > > requires the mmap_lock in write mode. Here we have it only in read > > mode. > > > > Then there's the apply_to_page_range() used by the igfx > > functionality > > of the i915 driver. I don't think we should go that route without > > turning it into something like vm_insert_pfns() with proper > > checking. > > This approach populates all entries of a buffer object. > > > > Finally there's the huge fault attempt that had to be ripped out > > due to > > lack of pmd_special and pud_special flags and resulting clashes > > with > > gup_fast. > > > > Perhaps a combination of the two latter if properly implemented > > would > > be the best choice. > > I'm not deep enough into the memory management background to judge > which > approach is the best, just one more data point to provide: > > The pre-faulting was increased because of virtualization. When > KVM/XEN > is mapping a BO into a guest the switching overhead for each fault is > so > high that mapping a lot of PFNs at the same time becomes beneficial. Since populating at mmap time is not possible due to eviction / migration, perhaps one way would be to use madvise() to toggle prefaulting size? MADV_RANDOM vs MADV_SEQUENTIAL vs MADV_NORMAL. /Thomas > > Regards, > Christian. > > > > > /Thomas > > > > > Dave. >
Re: [git pull] drm fixes for 6.11-rc6
On Mon, 2 Sept 2024 at 03:34, Christian König wrote: > > Am 02.09.24 um 11:32 schrieb Thomas Hellström: > > > > The remap_pfn_range was last tried, at least in the context of the i915 > > driver IIRC by Christoph Hellwig but had to be ripped out since it > > requires the mmap_lock in write mode. Here we have it only in read > > mode. Yeah, that does make things much more fragile. The "fill in multiple pages" helpers are really meant to be used at mmap() time, not as some kind of fault-around. So remap_pfn_range() sets the vma flags etc, but it also depends on being the only one to fill in the ptes, and will be *very* unhappy if it finds something that has already been filled in. And fault-around is *much* more fragile because unlike the mmap time thing, it can happen concurrently with other faults, and you cannot make assumptions about existing page table layout etc. > The pre-faulting was increased because of virtualization. When KVM/XEN > is mapping a BO into a guest the switching overhead for each fault is so > high that mapping a lot of PFNs at the same time becomes beneficial. Honestly, from a pure performance standpoint, if you can just do all the page mapping at mmap() time, that would be *much* much better. Then you can easily use that remap_pfn_range() function, and latencies are much less of an issue in general (not because it would be any faster, but simply because people don't tend to use mmap() in latency-critical code - but taking a page fault is *easily* very critical indeed). Linus
Re: [git pull] drm fixes for 6.11-rc6
Am 02.09.24 um 11:32 schrieb Thomas Hellström: On Mon, 2024-09-02 at 08:13 +1000, Dave Airlie wrote: On Fri, 30 Aug 2024 at 12:32, Linus Torvalds wrote: On Fri, 30 Aug 2024 at 14:08, Dave Airlie wrote: The TTM revert is due to some stuttering graphical apps probably due to longer stalls while prefaulting. Yeah, trying to pre-fault a PMD worth of pages in one go is just crazy talk. Now, if it was PMD-aligned and you faulted in a single PMD, that would be different. But just doing prn_insert_page() in a loop is insane. The code doesn't even stop when it hits a page that already existed, and it keeps locking and unlocking the last-level page table over and over again. Honestly, that code is questionable even for the *small* value, much less the "a PMD size" case. Now, if you have an array of 'struct page *", you can use vm_insert_pages(), and that's reasonably efficient. And if you have a *contiguous* are of pfns, you can use remap_pfn_range(). But that "insert one pfn at a time" that the drm layer does is complete garbage. You're not speeding anything up, you're just digging deeper. I wonder if there is functionality that could be provided in a common helper, by the mm layers, or if there would be too many locking interactions to make it sane, It seems too fraught with danger for drivers or subsystems to be just doing this in the simplest way that isn't actually that smart. Hmm. I see even the "Don't error on prefaults" check was broken at some point :/. There have been numerous ways to try to address this, The remap_pfn_range was last tried, at least in the context of the i915 driver IIRC by Christoph Hellwig but had to be ripped out since it requires the mmap_lock in write mode. Here we have it only in read mode. Then there's the apply_to_page_range() used by the igfx functionality of the i915 driver. I don't think we should go that route without turning it into something like vm_insert_pfns() with proper checking. This approach populates all entries of a buffer object. Finally there's the huge fault attempt that had to be ripped out due to lack of pmd_special and pud_special flags and resulting clashes with gup_fast. Perhaps a combination of the two latter if properly implemented would be the best choice. I'm not deep enough into the memory management background to judge which approach is the best, just one more data point to provide: The pre-faulting was increased because of virtualization. When KVM/XEN is mapping a BO into a guest the switching overhead for each fault is so high that mapping a lot of PFNs at the same time becomes beneficial. Regards, Christian. /Thomas Dave.
Re: [git pull] drm fixes for 6.11-rc6
On Mon, 2024-09-02 at 08:13 +1000, Dave Airlie wrote: > On Fri, 30 Aug 2024 at 12:32, Linus Torvalds > wrote: > > > > On Fri, 30 Aug 2024 at 14:08, Dave Airlie > > wrote: > > > > > > The TTM revert is due to some stuttering graphical apps probably > > > due > > > to longer stalls while prefaulting. > > > > Yeah, trying to pre-fault a PMD worth of pages in one go is just > > crazy talk. > > > > Now, if it was PMD-aligned and you faulted in a single PMD, that > > would > > be different. But just doing prn_insert_page() in a loop is insane. > > > > The code doesn't even stop when it hits a page that already > > existed, > > and it keeps locking and unlocking the last-level page table over > > and > > over again. > > > > Honestly, that code is questionable even for the *small* value, > > much > > less the "a PMD size" case. > > > > Now, if you have an array of 'struct page *", you can use > > vm_insert_pages(), and that's reasonably efficient. > > > > And if you have a *contiguous* are of pfns, you can use > > remap_pfn_range(). > > > > But that "insert one pfn at a time" that the drm layer does is > > complete garbage. You're not speeding anything up, you're just > > digging > > deeper. > > I wonder if there is functionality that could be provided in a common > helper, by the mm layers, or if there would be too many locking > interactions to make it sane, > > It seems too fraught with danger for drivers or subsystems to be just > doing this in the simplest way that isn't actually that smart. Hmm. I see even the "Don't error on prefaults" check was broken at some point :/. There have been numerous ways to try to address this, The remap_pfn_range was last tried, at least in the context of the i915 driver IIRC by Christoph Hellwig but had to be ripped out since it requires the mmap_lock in write mode. Here we have it only in read mode. Then there's the apply_to_page_range() used by the igfx functionality of the i915 driver. I don't think we should go that route without turning it into something like vm_insert_pfns() with proper checking. This approach populates all entries of a buffer object. Finally there's the huge fault attempt that had to be ripped out due to lack of pmd_special and pud_special flags and resulting clashes with gup_fast. Perhaps a combination of the two latter if properly implemented would be the best choice. /Thomas > > Dave.
Re: [git pull] drm fixes for 6.11-rc6
On Fri, 30 Aug 2024 at 12:32, Linus Torvalds wrote: > > On Fri, 30 Aug 2024 at 14:08, Dave Airlie wrote: > > > > The TTM revert is due to some stuttering graphical apps probably due > > to longer stalls while prefaulting. > > Yeah, trying to pre-fault a PMD worth of pages in one go is just crazy talk. > > Now, if it was PMD-aligned and you faulted in a single PMD, that would > be different. But just doing prn_insert_page() in a loop is insane. > > The code doesn't even stop when it hits a page that already existed, > and it keeps locking and unlocking the last-level page table over and > over again. > > Honestly, that code is questionable even for the *small* value, much > less the "a PMD size" case. > > Now, if you have an array of 'struct page *", you can use > vm_insert_pages(), and that's reasonably efficient. > > And if you have a *contiguous* are of pfns, you can use remap_pfn_range(). > > But that "insert one pfn at a time" that the drm layer does is > complete garbage. You're not speeding anything up, you're just digging > deeper. I wonder if there is functionality that could be provided in a common helper, by the mm layers, or if there would be too many locking interactions to make it sane, It seems too fraught with danger for drivers or subsystems to be just doing this in the simplest way that isn't actually that smart. Dave.
Re: [git pull] drm fixes for 6.11-rc6
The pull request you sent on Fri, 30 Aug 2024 12:08:41 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-08-30 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/20371ba120635d9ab7fc7670497105af8f33eb08 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.11-rc6
On Fri, 30 Aug 2024 at 14:08, Dave Airlie wrote: > > The TTM revert is due to some stuttering graphical apps probably due > to longer stalls while prefaulting. Yeah, trying to pre-fault a PMD worth of pages in one go is just crazy talk. Now, if it was PMD-aligned and you faulted in a single PMD, that would be different. But just doing prn_insert_page() in a loop is insane. The code doesn't even stop when it hits a page that already existed, and it keeps locking and unlocking the last-level page table over and over again. Honestly, that code is questionable even for the *small* value, much less the "a PMD size" case. Now, if you have an array of 'struct page *", you can use vm_insert_pages(), and that's reasonably efficient. And if you have a *contiguous* are of pfns, you can use remap_pfn_range(). But that "insert one pfn at a time" that the drm layer does is complete garbage. You're not speeding anything up, you're just digging deeper. Linus
Re: [git pull] drm fixes for 6.11-rc5
The pull request you sent on Sat, 24 Aug 2024 04:27:35 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-08-24 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/79a899e3d643a256b120d3e9cbf518b55e6f3686 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.11-rc4
The pull request you sent on Fri, 16 Aug 2024 14:09:28 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-08-16 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/37b20e9a5810e132a21c54f858043b22671396dd Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.11-rc3
The pull request you sent on Sat, 10 Aug 2024 06:00:08 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-08-10 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/15833fea97c1fdb3b34fceefa4b51177dd57e18f Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.11-rc2
The pull request you sent on Fri, 2 Aug 2024 15:08:04 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-08-02 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/29b4a6996c244f0d360537d6a4a0996468372c17 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.11-rc1
The pull request you sent on Fri, 26 Jul 2024 14:00:29 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-next-2024-07-26 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/0ba9b1551185a8b42003b708b6a9c25a9808701e Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.10-rc8
On Fri, 12 Jul 2024 at 14:46, Dave Airlie wrote: > > Hi Linus, > > Back to work, thanks to Sima for last week, not too many fixes as > expected getting close to release, amdgpu and xe have a couple each, > and then some other misc ones. Oh I screwed up last week's fixes pull, and forgot to send to Linus, Linus, can you just pull this in at the start of the merge window and we can fix things up if anything needs to get backported. Dave. > > Dave. > > drm-fixes-2024-07-12: > drm fixes for 6.10-rc8 > > amdgpu: > - PSR-SU fix > - Reseved VMID fix > > xe: > - Use write-back caching mode for system memory on DGFX > - Do not leak object when finalizing hdcp gsc > > bridge: > - adv7511 EDID irq fix > > gma500: > - NULL mode fixes. > > meson: > - fix resource leak > The following changes since commit 256abd8e550ce977b728be79a74e1729438b4948: > > Linux 6.10-rc7 (2024-07-07 14:23:46 -0700) > > are available in the Git repository at: > > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-07-12 > > for you to fetch changes up to 8b68788bebd3f697ae62aa9af3dac35ed112ebd7: > > Merge tag 'amd-drm-fixes-6.10-2024-07-11' of > https://gitlab.freedesktop.org/agd5f/linux into drm-fixes (2024-07-12 > 13:32:36 +1000) > > > drm fixes for 6.10-rc8 > > amdgpu: > - PSR-SU fix > - Reseved VMID fix > > xe: > - Use write-back caching mode for system memory on DGFX > - Do not leak object when finalizing hdcp gsc > > bridge: > - adv7511 EDID irq fix > > gma500: > - NULL mode fixes. > > meson: > - fix resource leak > > > Adam Ford (1): > drm/bridge: adv7511: Fix Intermittent EDID failures > > Christian König (1): > drm/amdgpu: reject gang submit on reserved VMIDs > > Dave Airlie (3): > Merge tag 'drm-misc-fixes-2024-07-11' of > https://gitlab.freedesktop.org/drm/misc/kernel into drm-fixes > Merge tag 'drm-xe-fixes-2024-07-11' of > https://gitlab.freedesktop.org/drm/xe/kernel into drm-fixes > Merge tag 'amd-drm-fixes-6.10-2024-07-11' of > https://gitlab.freedesktop.org/agd5f/linux into drm-fixes > > Leo Li (1): > Revert "drm/amd/display: Reset freesync config before update new state" > > Ma Ke (2): > drm/gma500: fix null pointer dereference in psb_intel_lvds_get_modes > drm/gma500: fix null pointer dereference in cdv_intel_lvds_get_modes > > Nirmoy Das (1): > drm/xe/display/xe_hdcp_gsc: Free arbiter on driver removal > > Thomas Hellström (1): > drm/xe: Use write-back caching mode for system memory on DGFX > > Yao Zi (1): > drm/meson: fix canvas release in bind function > > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 15 > drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 15 +++- > drivers/gpu/drm/amd/amdgpu/amdgpu_ids.h | 1 + > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - > drivers/gpu/drm/bridge/adv7511/adv7511.h | 2 +- > drivers/gpu/drm/bridge/adv7511/adv7511_cec.c | 13 +-- > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 22 ++- > drivers/gpu/drm/gma500/cdv_intel_lvds.c | 3 ++ > drivers/gpu/drm/gma500/psb_intel_lvds.c | 3 ++ > drivers/gpu/drm/meson/meson_drv.c | 37 +- > drivers/gpu/drm/xe/display/xe_hdcp_gsc.c | 12 -- > drivers/gpu/drm/xe/xe_bo.c| 47 > ++- > drivers/gpu/drm/xe/xe_bo_types.h | 3 +- > include/uapi/drm/xe_drm.h | 8 +++- > 14 files changed, 122 insertions(+), 60 deletions(-)
Re: [git pull] drm fixes for 6.10-rc6
The pull request you sent on Fri, 28 Jun 2024 09:58:07 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-06-28 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/1c52cf5e79d30ac996f34b64284f2c317004d641 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.10-rc5
The pull request you sent on Sat, 22 Jun 2024 06:41:13 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-06-22 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/d6c941570680d4d11e5c7480c3bcbeff8d3860f9 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.10-rc4
The pull request you sent on Sat, 15 Jun 2024 08:05:44 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-06-15 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/d4332da0f2b5cccf2b195035a3f30fce7c1bb7a7 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.10-rc3
The pull request you sent on Fri, 7 Jun 2024 12:05:49 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-06-07 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/2e32d580757362edc95fdd7a86d3b869b78e58d8 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.10-rc2
The pull request you sent on Sat, 1 Jun 2024 06:46:21 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-06-01 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/cc8ed4d0a8486c7472cd72ec3c19957e509dc68c Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.10-rc1
The pull request you sent on Sat, 25 May 2024 06:23:25 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-next-2024-05-25 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/56fb6f92854f29dcb6c3dc3ba92eeda1b615e88c Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.9 final
The pull request you sent on Sat, 11 May 2024 07:18:11 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-05-11 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/cf87f46fd34d6c19283d9625a7822f20d90b64a4 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.9-rc7
The pull request you sent on Fri, 3 May 2024 13:52:43 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-05-03 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/b5a66609a643443e2b14773dcc784496ee1e5457 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.8-rc6
The pull request you sent on Fri, 26 Apr 2024 13:12:03 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-04-26 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/61ef6208e0df073072a764eb5c5f5a6db3ffadb6 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.9-rc5
The pull request you sent on Fri, 19 Apr 2024 10:53:05 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-04-19 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/ce944f3f97cf1bc813003ea2f3bf2abefa87dbd7 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.9-rc4
The pull request you sent on Fri, 12 Apr 2024 11:34:33 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-04-12 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/d1c13e80049d927c88021e3180d5103f2e6f55c4 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.9-rc3
The pull request you sent on Fri, 5 Apr 2024 13:41:06 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-04-05 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/89103a164210f1c88caedf880ac9ab9576a1190d Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.9-rc2
The pull request you sent on Sat, 30 Mar 2024 06:29:04 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-03-30 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/486291a0e6246364936df1ecd64c90affef4b9c5 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.9-rc1
The pull request you sent on Fri, 22 Mar 2024 11:34:13 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-next-2024-03-22 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/7ee04901215b3cab8fa35aa5bf4692d7aa312e36 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.8 final
The pull request you sent on Fri, 8 Mar 2024 13:52:40 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-03-08 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e6fac3c1f3287735faf1b68e0068f64e6966618d Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.8-rc7
The pull request you sent on Fri, 1 Mar 2024 15:41:03 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-03-01 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/7187ea0978bb4226873b55a065b5dcdda7530b9f Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.8-rc6
The pull request you sent on Fri, 23 Feb 2024 11:32:09 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2024-02-23 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/06b7ef70b1f29de685ea80f0c1b8f0a0b0e16d18 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.8-rc5
The pull request you sent on Fri, 16 Feb 2024 17:20:39 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2024-02-16 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/ca6a62f9fe23713ea2b58a256a1ab27b9cc5a05a Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.8-rc4
The pull request you sent on Fri, 9 Feb 2024 14:28:39 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2024-02-09 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/c76b766ec50d3d43e2dacea53a733b285f4b730d Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.8-rc3
The pull request you sent on Sat, 3 Feb 2024 05:46:00 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2024-02-03 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/9c2f0338bbd132a4b12b988004d796798609d297 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.8-rc2
The pull request you sent on Sat, 27 Jan 2024 04:56:27 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2024-01-27 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/168174d78157bba1315d5f8e1c66548b92c84ae9 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.8-rc1 (part two)
The pull request you sent on Fri, 19 Jan 2024 16:58:59 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-next-2024-01-19 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e08b5758153981ca812c5991209a6133c732e799 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.8-rc1
The pull request you sent on Mon, 15 Jan 2024 16:18:01 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-next-2024-01-15-1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/8893a6bfff312ea6fee89bfaa8761f0b9456199b Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes (part2) for 6.7 final
The pull request you sent on Fri, 5 Jan 2024 13:31:53 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2024-01-05 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/2b5bd1498da5537e3d130b3862bccdd9aedd6c84 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.8
On Fri, 5 Jan 2024 at 04:50, Linus Torvalds wrote: > > On Wed, 3 Jan 2024 at 18:30, Dave Airlie wrote: > > > > These were from over the holiday period, mainly i915, a couple of > > qaic, bridge and an mgag200. > > > > I have a set of nouveau fixes that I'll send after this, that might be > > too rich for you at this point. > > > > I expect there might also be some more regular fixes before 6.8, but > > they should be minor. > > I'm assuming you're just confused about the numbering, and meant 6.7 > here and in the subject line. > > This seems to be too small of a pull to be an early pull request for > the 6.8 merge window. Indeed this is for 6.7 holiday brain hasn't lifted yet, sorry for noise. Dave.
Re: [git pull] drm fixes for 6.8
The pull request you sent on Thu, 4 Jan 2024 12:29:55 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2024-01-04 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/5939a693dc6e6d6f293681017c70ff60c3723d43 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.8
On Wed, 3 Jan 2024 at 18:30, Dave Airlie wrote: > > These were from over the holiday period, mainly i915, a couple of > qaic, bridge and an mgag200. > > I have a set of nouveau fixes that I'll send after this, that might be > too rich for you at this point. > > I expect there might also be some more regular fixes before 6.8, but > they should be minor. I'm assuming you're just confused about the numbering, and meant 6.7 here and in the subject line. This seems to be too small of a pull to be an early pull request for the 6.8 merge window. Linus
Re: [git pull] drm fixes for 6.7-rc7
The pull request you sent on Fri, 22 Dec 2023 14:59:38 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-12-22 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/8afe6f0e0e257bf7f79f5996c037e8977dcc8cc1 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.7-rc6
The pull request you sent on Fri, 15 Dec 2023 16:42:01 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-12-15 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/595609b2ad023088dfd0ae74abb4602ea267e739 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.7-rc5
The pull request you sent on Fri, 8 Dec 2023 14:54:20 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-12-08 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/38bafa65b1260cb774cfc0c9a3ddf82d3c563e10 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.7-rc4
The pull request you sent on Fri, 1 Dec 2023 16:41:39 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-12-01 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/b1e51588aa50287c3d33e14969d47ccdd403ad80 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.7-rc3
The pull request you sent on Fri, 24 Nov 2023 11:38:52 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-11-24 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/afa0f6ee000abd220a8160f0375b5b8d3e4284f2 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.6 final
The pull request you sent on Fri, 27 Oct 2023 16:15:45 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-10-27 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/750b95887e567848ac2c851dae47922cac6db946 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.6-rc7
The pull request you sent on Fri, 20 Oct 2023 15:01:24 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-10-20 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/c8045b4a33a511ff1feaeb806e819572b90b6625 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.6-rc6
The pull request you sent on Fri, 13 Oct 2023 14:24:48 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-10-13 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/10a6e5feccb877c3c75ad11d27942ad52c24815f Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.6-rc5
The pull request you sent on Fri, 6 Oct 2023 14:58:38 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-10-06 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/4940c1543b4381a4895072489b4de7b6145694f5 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.6-rc4
The pull request you sent on Fri, 29 Sep 2023 11:46:12 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-09-29 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/6edc84bc3f8aceae74eb63684d53c17553382ec0 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.6-rc3
The pull request you sent on Fri, 22 Sep 2023 16:14:46 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-09-22 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/b41b28366d3b176c8297961de4f095f2e392402d Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.6-rc2
The pull request you sent on Fri, 15 Sep 2023 12:57:50 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-09-15 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/9608c7b729e29c177525006711966ae0fd399b11 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.6-rc1
The pull request you sent on Fri, 8 Sep 2023 12:45:13 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-next-2023-09-08 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a48fa7efaf1161c1c898931fe4c7f0070964233a Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.6-rc1
On Thu, 7 Sept 2023 at 19:45, Dave Airlie wrote: > > Just a poke about the outstanding drm CI support pull request since I > haven't see any movement on that in the week, hopefully it's not as > difficult a problem as bcachefs :-) I was assuming that it wouldn't interfere with anything else... and that I could just ignore it until I have all my "real" pulls done. I didn't want to even look at it until I was "done". Yes, it's past the mid-way point of the second week of the merge window, and I mostly _should_ be "done". But I still keep finding new pull requests in my inbox that aren't just fixes and updates for previous main pull requests. Linus
Re: [git pull] drm fixes for 6.5 final
The pull request you sent on Fri, 25 Aug 2023 13:07:17 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-08-25 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/beaa71d6e64103403a328bcc8cefa6e9b19544c1 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.5-rc7
The pull request you sent on Fri, 18 Aug 2023 07:36:16 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-08-18-1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/1ada9c07407d66679967fe5c2cbb7eda2e0addbf Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.4-rc6
The pull request you sent on Fri, 11 Aug 2023 16:27:34 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-08-11 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/9b1b1b74ddb236e7ccf6d11d4c0b642fbe0c66c6 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.5-rc5
The pull request you sent on Fri, 4 Aug 2023 15:07:56 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-08-04 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/4142fc6743d39271e712936d9fb284cd84cb6010 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.5-rc4
The pull request you sent on Fri, 28 Jul 2023 12:20:10 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-07-28 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/17bf3df9af08c5e87c07a92b811b7f9f8034a32c Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.5-rc4
On Thu, 27 Jul 2023 at 19:20, Dave Airlie wrote: > > Regular scheduled fixes, msm and amdgpu leading the way, with some > i915 and a single misc fbdev, all seems fine. Pulled. Tangentially related: where do you keep your pgp key? The one I have is long expired, and doing a refresh doesn't get any updates... Linus
Re: [git pull] drm fixes for 6.5-rc3
The pull request you sent on Fri, 21 Jul 2023 13:14:05 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-07-21 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/f7e3a1bafdea735050dfde00523cf505dc7fd309 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.5-rc2
The pull request you sent on Fri, 14 Jul 2023 14:39:37 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-07-14-1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/3a97a2993e7e7392292323fefc46d79bf9633e44 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.5-rc1
The pull request you sent on Fri, 7 Jul 2023 11:14:46 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-next-2023-07-07 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/5133c9e51de41bfa902153888e11add3342ede18 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.4 final
The pull request you sent on Fri, 23 Jun 2023 16:48:56 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-06-23 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a92b7d26c743b9dc06d520f863d624e94978a1d9 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.4 final
On Fri, Jun 23, 2023 at 2:49 AM Dave Airlie wrote: > > Hey Linus, > > very quiet last week, just two misc fixes, one dp-mst and one qaic. > > Should be all ready for the merge window next week. Was out of the office this week and didn't get to -fixes until today. Will send the PR to everyone now. Alex > > Dave. > > drm-fixes-2023-06-23: > drm fixes for 6.4 final > > qaic: > - dma-buf import fix > > dp-mst: > - fix NULL ptr deref > The following changes since commit 45a3e24f65e90a047bef86f927ebdc4c710edaa1: > > Linux 6.4-rc7 (2023-06-18 14:06:27 -0700) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-06-23 > > for you to fetch changes up to 9bd9be5cbaf8a8faa175ef4fba04a5623281debe: > > Merge tag 'drm-misc-fixes-2023-06-21' of > git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2023-06-23 > 12:16:48 +1000) > > > drm fixes for 6.4 final > > qaic: > - dma-buf import fix > > dp-mst: > - fix NULL ptr deref > > > Dave Airlie (1): > Merge tag 'drm-misc-fixes-2023-06-21' of > git://anongit.freedesktop.org/drm/drm-misc into drm-fixes > > Jeff Layton (1): > drm: use mgr->dev in drm_dbg_kms in drm_dp_add_payload_part2 > > Pranjal Ramajor Asha Kanojiya (1): > accel/qaic: Call DRM helper function to destroy prime GEM > > drivers/accel/qaic/qaic_data.c| 4 ++-- > drivers/gpu/drm/display/drm_dp_mst_topology.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-)
Re: [git pull] drm fixes for 6.4-rc7
The pull request you sent on Sat, 17 Jun 2023 06:29:31 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-06-17 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/1639fae5132bc8a904af28d97cea0bedb3af802e Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.4-rc6
The pull request you sent on Fri, 9 Jun 2023 11:39:32 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-06-09 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/33f2b5785a2b6b0ed1948aafee60d3abb12f1e3a Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.4-rc5
The pull request you sent on Fri, 2 Jun 2023 14:12:59 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-06-02 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e99a74673a19631d4a23c7e1fe2f21c55471a5d1 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.4-rc4
The pull request you sent on Fri, 26 May 2023 16:04:02 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-05-26 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/b83ac44e02986e640ee954e187ba414cb94453e2 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.4-rc3
The pull request you sent on Sat, 20 May 2023 11:09:38 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-05-20 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/d635f6cc934bcd467c5d67148ece74632fd96abf Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.4-rc2
The pull request you sent on Fri, 12 May 2023 06:59:57 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-05-12 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/cc3c44c9fda264c6d401be04e95449a57c1231c6 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes part 2 for 6.4-rc1
The pull request you sent on Fri, 5 May 2023 13:10:28 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-next-2023-05-05 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/084f51d473cd566eab310d5da56fe7b68d0b10be Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.3 final
The pull request you sent on Fri, 21 Apr 2023 11:27:42 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-04-21 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/2af3e53a4dc08657f1b46f97f04ff4a0ab3cad8d Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for v6.3-rc3
The pull request you sent on Fri, 17 Mar 2023 17:59:36 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-03-17 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/2cf5a401c87178237c5b782c44578c26690a802b Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.3-rc2
The pull request you sent on Fri, 10 Mar 2023 14:44:33 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-03-10 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/b0d14d2aaf7d4b36b44f5a09955ebdf9eef4b0f8 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.2 final
The pull request you sent on Fri, 17 Feb 2023 12:16:34 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-02-17 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/ec35307e18ba8174e2a3f701956059f6a36f22fb Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.2-rc8
The pull request you sent on Fri, 10 Feb 2023 11:19:51 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-02-10 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/38c1e0c65865426676123cc9a127526fa02bcac6 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.2-rc7
The pull request you sent on Fri, 3 Feb 2023 13:59:18 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-02-03 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/bffede38f82c27cf5e203a2c659fcc9b581dd7b8 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.2-rc6
The pull request you sent on Fri, 27 Jan 2023 15:22:36 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-01-27 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/76e26e3c6a49b368a6fd38e2da2b1b164470cc52 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.2-rc5
The pull request you sent on Fri, 20 Jan 2023 12:52:59 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-01-20 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/ff83fec8179e392be2f472f0a9ec3da8f6d529c6 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.2-rc4
The pull request you sent on Fri, 13 Jan 2023 15:15:17 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-01-13 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/ff5ebafd51ecc01014f1db510299eede60faf22a Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.2-rc1
The pull request you sent on Fri, 23 Dec 2022 14:02:33 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-next-2022-12-23 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/55c7d6a91d42ad98cbfb10da077ce8bb7084dc0e Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.1 final
The pull request you sent on Fri, 9 Dec 2022 10:51:00 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2022-12-09 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/0d1409e4ff08aa4a9a254d3f723410db32aa7552 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.1-rc8
The pull request you sent on Fri, 2 Dec 2022 11:44:43 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2022-12-02 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/c290db013742e98fe5b64073bc2dd8c8a2ac9e4c Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.1-rc7
The pull request you sent on Fri, 25 Nov 2022 13:47:02 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2022-11-25 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/6fe0e074e76985c7be3eaa7a8fd51401a8999cae Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for v6.1-rc6
The pull request you sent on Sat, 19 Nov 2022 06:35:47 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2022-11-19 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/b5bf1d8a23a683d56be574a934a8296912efc758 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.1-rc5
The pull request you sent on Fri, 11 Nov 2022 12:18:21 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2022-11-11 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/fd979ca691715891a979ce12d1a485b108af74d3 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.1-rc4
The pull request you sent on Fri, 4 Nov 2022 13:21:02 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2022-11-04-1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/fde25beb382b7dd6f2eab8022ab017cbdfaa3ff6 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.1-rc3
The pull request you sent on Fri, 28 Oct 2022 13:53:24 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2022-10-28 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e3493d682516e2b7ef69587ddf91b0371a1511d0 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.1-rc2
The pull request you sent on Fri, 21 Oct 2022 10:37:33 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2022-10-21 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e35184f321518acadb681928a016da21a9a20c13 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [git pull] drm fixes for 6.1-rc1
Thanks Arunpravin, your patch applied to the 6.1-rc1 code built a kernel that loaded the amdgpu module on my pc with Cape Verde GPU card with no problems. Regards, Arthur. On 18 October 2022 7:10:45 am ACDT, Arunpravin Paneer Selvam wrote: >Hi Christian, > >Looks like we have to exit the loop if there are no blocks to compare. >May be that's why the function returns false. > >@Arthur Marsh Could you please test the attached patch. > >Thanks, >Arun > >On 10/17/2022 1:39 PM, Christian König wrote: >> Am 17.10.22 um 10:01 schrieb Dave Airlie: >>> On Mon, 17 Oct 2022 at 17:07, Christian König >>> wrote: Hi Arun, the hw generation doesn't matter. This error message here: amdgpu: Move buffer fallback to memcpy unavailable indicates that the detection of linear buffers still doesn't work as expected or that we have a bug somewhere else. Maybe the limiting when SDMA moves are not available isn't working correctly? >>> It is a CAPE_VERDE, so maybe something with the SI UVD memory limitations? >> >> Yeah, good point. Could be that we try to move something into the UVD memory >> window and that something isn't allocated linearly. >> >> Arun can you trace the allocation and make sure that all kernel allocations >> have the CONTIGUOUS flag set? >> >> Thanks, >> Christian. >> >>> >>> Dave. >> -- Sent from my Android device with K-9 Mail. Please excuse my brevity.
Re: [git pull] drm fixes for 6.1-rc1
Hi Christian, Looks like we have to exit the loop if there are no blocks to compare. May be that's why the function returns false. @Arthur Marsh Could you please test the attached patch. Thanks, Arun On 10/17/2022 1:39 PM, Christian König wrote: Am 17.10.22 um 10:01 schrieb Dave Airlie: On Mon, 17 Oct 2022 at 17:07, Christian König wrote: Hi Arun, the hw generation doesn't matter. This error message here: amdgpu: Move buffer fallback to memcpy unavailable indicates that the detection of linear buffers still doesn't work as expected or that we have a bug somewhere else. Maybe the limiting when SDMA moves are not available isn't working correctly? It is a CAPE_VERDE, so maybe something with the SI UVD memory limitations? Yeah, good point. Could be that we try to move something into the UVD memory window and that something isn't allocated linearly. Arun can you trace the allocation and make sure that all kernel allocations have the CONTIGUOUS flag set? Thanks, Christian. Dave. From 132ce83f893eaea743fb7f41a9dc72afea52cdaa Mon Sep 17 00:00:00 2001 From: Arunpravin Paneer Selvam Date: Mon, 17 Oct 2022 13:15:21 -0700 Subject: [PATCH] drm/amdgpu: Fix for BO move issue If there are no blocks to compare then exit the loop. Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index dc262d2c2925..57277b1cf183 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c @@ -439,6 +439,9 @@ static bool amdgpu_mem_visible(struct amdgpu_device *adev, while (cursor.remaining) { amdgpu_res_next(&cursor, cursor.size); + if (!cursor.remaining) + break; + /* ttm_resource_ioremap only supports contiguous memory */ if (end != cursor.start) return false; -- 2.25.1
Re: [git pull] drm fixes for 6.1-rc1
Am 17.10.22 um 10:01 schrieb Dave Airlie: On Mon, 17 Oct 2022 at 17:07, Christian König wrote: Hi Arun, the hw generation doesn't matter. This error message here: amdgpu: Move buffer fallback to memcpy unavailable indicates that the detection of linear buffers still doesn't work as expected or that we have a bug somewhere else. Maybe the limiting when SDMA moves are not available isn't working correctly? It is a CAPE_VERDE, so maybe something with the SI UVD memory limitations? Yeah, good point. Could be that we try to move something into the UVD memory window and that something isn't allocated linearly. Arun can you trace the allocation and make sure that all kernel allocations have the CONTIGUOUS flag set? Thanks, Christian. Dave.
Re: [git pull] drm fixes for 6.1-rc1
On Mon, 17 Oct 2022 at 17:07, Christian König wrote: > > Hi Arun, > > the hw generation doesn't matter. This error message here: > > amdgpu: Move buffer fallback to memcpy unavailable > > indicates that the detection of linear buffers still doesn't work as > expected or that we have a bug somewhere else. > > Maybe the limiting when SDMA moves are not available isn't working > correctly? It is a CAPE_VERDE, so maybe something with the SI UVD memory limitations? Dave.
Re: [git pull] drm fixes for 6.1-rc1
Hi Arun, the hw generation doesn't matter. This error message here: amdgpu: Move buffer fallback to memcpy unavailable indicates that the detection of linear buffers still doesn't work as expected or that we have a bug somewhere else. Maybe the limiting when SDMA moves are not available isn't working correctly? Regards, Christian. Am 17.10.22 um 08:54 schrieb Arunpravin Paneer Selvam: Hi Arthur, Is this old radeon card? Thanks, Arun On 10/17/2022 11:50 AM, Christian König wrote: Arun please take a look into this ASAP. Thanks, Christian. Am 17.10.22 um 03:13 schrieb Arthur Marsh: Thanks Dave, I reverted patch 312b4dc11d4f74bfe03ea25ffe04c1f2fdd13cb9 against 6.1-rc1 and the resulting kernel loaded amdgpu fine on my pc with Cape Verde GPU. Regards, Arthur. On 17 October 2022 8:14:18 am ACDT, Dave Airlie wrote: On Sun, 16 Oct 2022 at 18:09, Arthur Marsh wrote: From: Arthur Marsh Hi, the "drm fixes for 6.1-rc1" commit caused the amdgpu module to fail with my Cape Verde radeonsi card. I haven't been able to bisect the problem to an individual commit, but attach a dmesg extract below. I'm happy to supply any other configuration information and test patches. Can you try reverting: it's the only think I can spot that might affect a card that old since most changes in that request were for display hw you don't have. ommit 312b4dc11d4f74bfe03ea25ffe04c1f2fdd13cb9 Author: Arunpravin Paneer Selvam Date: Tue Oct 4 07:33:39 2022 -0700 drm/amdgpu: Fix VRAM BO swap issue DRM buddy manager allocates the contiguous memory requests in a single block or multiple blocks. So for the ttm move operation (incase of low vram memory) we should consider all the blocks to compute the total memory size which compared with the struct ttm_resource num_pages in order to verify that the blocks are contiguous for the eviction process. v2: Added a Fixes tag v3: Rewrite the code to save a bit of calculations and variables (Christian) Fixes: c9cad937c0c5 ("drm/amdgpu: add drm buddy support to amdgpu") Signed-off-by: Arunpravin Paneer Selvam Reviewed-by: Christian König Signed-off-by: Alex Deucher Thanks, Dave. Arthur. Linux version 6.0.0+ (root@am64) (gcc-12 (Debian 12.2.0-5) 12.2.0, GNU ld (GNU Binutils for Debian) 2.39) #5179 SMP PREEMPT_DYNAMIC Fri Oct 14 17:00:40 ACDT 2022 Command line: BOOT_IMAGE=/vmlinuz-6.0.0+ root=UUID=39706f53-7c27-4310-b22a-36c7b042d1a1 ro single amdgpu.audio=1 amdgpu.si_support=1 radeon.si_support=0 page_owner=on amdgpu.gpu_recovery=1 ... [drm] amdgpu kernel modesetting enabled. amdgpu :01:00.0: vgaarb: deactivate vga console Console: switching to colour dummy device 80x25 [drm] initializing kernel modesetting (VERDE 0x1002:0x682B 0x1458:0x22CA 0x87). [drm] register mmio base: 0xFE8C [drm] register mmio size: 262144 [drm] add ip block number 0 [drm] add ip block number 1 [drm] add ip block number 2 [drm] add ip block number 3 [drm] add ip block number 4 [drm] add ip block number 5 [drm] add ip block number 6 [drm] add ip block number 7 [drm] BIOS signature incorrect 5b 7 resource sanity check: requesting [mem 0x000c-0x000d], which spans more than PCI Bus :00 [mem 0x000d-0x000d window] caller pci_map_rom+0x68/0x1b0 mapping multiple BARs amdgpu :01:00.0: No more image in the PCI ROM amdgpu :01:00.0: amdgpu: Fetched VBIOS from ROM BAR amdgpu: ATOM BIOS: xxx-xxx-xxx amdgpu :01:00.0: amdgpu: Trusted Memory Zone (TMZ) feature not supported amdgpu :01:00.0: amdgpu: PCIE atomic ops is not supported [drm] PCIE gen 2 link speeds already enabled [drm] vm size is 64 GB, 2 levels, block size is 10-bit, fragment size is 9-bit RTL8211B Gigabit Ethernet r8169-0-300:00: attached PHY driver (mii_bus:phy_addr=r8169-0-300:00, irq=MAC) r8169 :03:00.0 eth0: Link is Down amdgpu :01:00.0: amdgpu: VRAM: 2048M 0x00F4 - 0x00F47FFF (2048M used) amdgpu :01:00.0: amdgpu: GART: 1024M 0x00FF - 0x00FF3FFF [drm] Detected VRAM RAM=2048M, BAR=256M [drm] RAM width 128bits DDR3 [drm] amdgpu: 2048M of VRAM memory ready [drm] amdgpu: 3979M of GTT memory ready. [drm] GART: num cpu pages 262144, num gpu pages 262144 amdgpu :01:00.0: amdgpu: PCIE GART of 1024M enabled (table at 0x00F400A0). [drm] Internal thermal controller with fan control [drm] amdgpu: dpm initialized [drm] AMDGPU Display Connectors [drm] Connector 0: [drm] HDMI-A-1 [drm] HPD1 [drm] DDC: 0x194c 0x194c 0x194d 0x194d 0x194e 0x194e 0x194f 0x194f [drm] Encoders: [drm] DFP1: INTERNAL_UNIPHY [drm] Connector 1: [drm] DVI-D-1 [drm] HPD2 [drm] DDC: 0x1950 0x1950 0x1951 0x1951 0x1952 0x1952 0x1953 0x1953 [drm] Encoders: [drm] DFP2: INTERNAL_UNIPHY [drm] Connector 2: [drm] VGA-1 [drm] DDC: 0x1970 0x1970 0x1971
Re: [git pull] drm fixes for 6.1-rc1
Hi Arthur, Is this old radeon card? Thanks, Arun On 10/17/2022 11:50 AM, Christian König wrote: Arun please take a look into this ASAP. Thanks, Christian. Am 17.10.22 um 03:13 schrieb Arthur Marsh: Thanks Dave, I reverted patch 312b4dc11d4f74bfe03ea25ffe04c1f2fdd13cb9 against 6.1-rc1 and the resulting kernel loaded amdgpu fine on my pc with Cape Verde GPU. Regards, Arthur. On 17 October 2022 8:14:18 am ACDT, Dave Airlie wrote: On Sun, 16 Oct 2022 at 18:09, Arthur Marsh wrote: From: Arthur Marsh Hi, the "drm fixes for 6.1-rc1" commit caused the amdgpu module to fail with my Cape Verde radeonsi card. I haven't been able to bisect the problem to an individual commit, but attach a dmesg extract below. I'm happy to supply any other configuration information and test patches. Can you try reverting: it's the only think I can spot that might affect a card that old since most changes in that request were for display hw you don't have. ommit 312b4dc11d4f74bfe03ea25ffe04c1f2fdd13cb9 Author: Arunpravin Paneer Selvam Date: Tue Oct 4 07:33:39 2022 -0700 drm/amdgpu: Fix VRAM BO swap issue DRM buddy manager allocates the contiguous memory requests in a single block or multiple blocks. So for the ttm move operation (incase of low vram memory) we should consider all the blocks to compute the total memory size which compared with the struct ttm_resource num_pages in order to verify that the blocks are contiguous for the eviction process. v2: Added a Fixes tag v3: Rewrite the code to save a bit of calculations and variables (Christian) Fixes: c9cad937c0c5 ("drm/amdgpu: add drm buddy support to amdgpu") Signed-off-by: Arunpravin Paneer Selvam Reviewed-by: Christian König Signed-off-by: Alex Deucher Thanks, Dave. Arthur. Linux version 6.0.0+ (root@am64) (gcc-12 (Debian 12.2.0-5) 12.2.0, GNU ld (GNU Binutils for Debian) 2.39) #5179 SMP PREEMPT_DYNAMIC Fri Oct 14 17:00:40 ACDT 2022 Command line: BOOT_IMAGE=/vmlinuz-6.0.0+ root=UUID=39706f53-7c27-4310-b22a-36c7b042d1a1 ro single amdgpu.audio=1 amdgpu.si_support=1 radeon.si_support=0 page_owner=on amdgpu.gpu_recovery=1 ... [drm] amdgpu kernel modesetting enabled. amdgpu :01:00.0: vgaarb: deactivate vga console Console: switching to colour dummy device 80x25 [drm] initializing kernel modesetting (VERDE 0x1002:0x682B 0x1458:0x22CA 0x87). [drm] register mmio base: 0xFE8C [drm] register mmio size: 262144 [drm] add ip block number 0 [drm] add ip block number 1 [drm] add ip block number 2 [drm] add ip block number 3 [drm] add ip block number 4 [drm] add ip block number 5 [drm] add ip block number 6 [drm] add ip block number 7 [drm] BIOS signature incorrect 5b 7 resource sanity check: requesting [mem 0x000c-0x000d], which spans more than PCI Bus :00 [mem 0x000d-0x000d window] caller pci_map_rom+0x68/0x1b0 mapping multiple BARs amdgpu :01:00.0: No more image in the PCI ROM amdgpu :01:00.0: amdgpu: Fetched VBIOS from ROM BAR amdgpu: ATOM BIOS: xxx-xxx-xxx amdgpu :01:00.0: amdgpu: Trusted Memory Zone (TMZ) feature not supported amdgpu :01:00.0: amdgpu: PCIE atomic ops is not supported [drm] PCIE gen 2 link speeds already enabled [drm] vm size is 64 GB, 2 levels, block size is 10-bit, fragment size is 9-bit RTL8211B Gigabit Ethernet r8169-0-300:00: attached PHY driver (mii_bus:phy_addr=r8169-0-300:00, irq=MAC) r8169 :03:00.0 eth0: Link is Down amdgpu :01:00.0: amdgpu: VRAM: 2048M 0x00F4 - 0x00F47FFF (2048M used) amdgpu :01:00.0: amdgpu: GART: 1024M 0x00FF - 0x00FF3FFF [drm] Detected VRAM RAM=2048M, BAR=256M [drm] RAM width 128bits DDR3 [drm] amdgpu: 2048M of VRAM memory ready [drm] amdgpu: 3979M of GTT memory ready. [drm] GART: num cpu pages 262144, num gpu pages 262144 amdgpu :01:00.0: amdgpu: PCIE GART of 1024M enabled (table at 0x00F400A0). [drm] Internal thermal controller with fan control [drm] amdgpu: dpm initialized [drm] AMDGPU Display Connectors [drm] Connector 0: [drm] HDMI-A-1 [drm] HPD1 [drm] DDC: 0x194c 0x194c 0x194d 0x194d 0x194e 0x194e 0x194f 0x194f [drm] Encoders: [drm] DFP1: INTERNAL_UNIPHY [drm] Connector 1: [drm] DVI-D-1 [drm] HPD2 [drm] DDC: 0x1950 0x1950 0x1951 0x1951 0x1952 0x1952 0x1953 0x1953 [drm] Encoders: [drm] DFP2: INTERNAL_UNIPHY [drm] Connector 2: [drm] VGA-1 [drm] DDC: 0x1970 0x1970 0x1971 0x1971 0x1972 0x1972 0x1973 0x1973 [drm] Encoders: [drm] CRT1: INTERNAL_KLDSCP_DAC1 [drm] Found UVD firmware Version: 64.0 Family ID: 13 amdgpu: Move buffer fallback to memcpy unavailable [drm:amdgpu_device_init.cold [amdgpu]] *ERROR* sw_init of IP block failed -19 amdgpu :01:00.0: amdgpu: amdgpu_device_ip_init failed amdgpu :01:00.0: amdgpu: Fatal error during GPU init
Re: [git pull] drm fixes for 6.1-rc1
Arun please take a look into this ASAP. Thanks, Christian. Am 17.10.22 um 03:13 schrieb Arthur Marsh: Thanks Dave, I reverted patch 312b4dc11d4f74bfe03ea25ffe04c1f2fdd13cb9 against 6.1-rc1 and the resulting kernel loaded amdgpu fine on my pc with Cape Verde GPU. Regards, Arthur. On 17 October 2022 8:14:18 am ACDT, Dave Airlie wrote: On Sun, 16 Oct 2022 at 18:09, Arthur Marsh wrote: From: Arthur Marsh Hi, the "drm fixes for 6.1-rc1" commit caused the amdgpu module to fail with my Cape Verde radeonsi card. I haven't been able to bisect the problem to an individual commit, but attach a dmesg extract below. I'm happy to supply any other configuration information and test patches. Can you try reverting: it's the only think I can spot that might affect a card that old since most changes in that request were for display hw you don't have. ommit 312b4dc11d4f74bfe03ea25ffe04c1f2fdd13cb9 Author: Arunpravin Paneer Selvam Date: Tue Oct 4 07:33:39 2022 -0700 drm/amdgpu: Fix VRAM BO swap issue DRM buddy manager allocates the contiguous memory requests in a single block or multiple blocks. So for the ttm move operation (incase of low vram memory) we should consider all the blocks to compute the total memory size which compared with the struct ttm_resource num_pages in order to verify that the blocks are contiguous for the eviction process. v2: Added a Fixes tag v3: Rewrite the code to save a bit of calculations and variables (Christian) Fixes: c9cad937c0c5 ("drm/amdgpu: add drm buddy support to amdgpu") Signed-off-by: Arunpravin Paneer Selvam Reviewed-by: Christian König Signed-off-by: Alex Deucher Thanks, Dave. Arthur. Linux version 6.0.0+ (root@am64) (gcc-12 (Debian 12.2.0-5) 12.2.0, GNU ld (GNU Binutils for Debian) 2.39) #5179 SMP PREEMPT_DYNAMIC Fri Oct 14 17:00:40 ACDT 2022 Command line: BOOT_IMAGE=/vmlinuz-6.0.0+ root=UUID=39706f53-7c27-4310-b22a-36c7b042d1a1 ro single amdgpu.audio=1 amdgpu.si_support=1 radeon.si_support=0 page_owner=on amdgpu.gpu_recovery=1 ... [drm] amdgpu kernel modesetting enabled. amdgpu :01:00.0: vgaarb: deactivate vga console Console: switching to colour dummy device 80x25 [drm] initializing kernel modesetting (VERDE 0x1002:0x682B 0x1458:0x22CA 0x87). [drm] register mmio base: 0xFE8C [drm] register mmio size: 262144 [drm] add ip block number 0 [drm] add ip block number 1 [drm] add ip block number 2 [drm] add ip block number 3 [drm] add ip block number 4 [drm] add ip block number 5 [drm] add ip block number 6 [drm] add ip block number 7 [drm] BIOS signature incorrect 5b 7 resource sanity check: requesting [mem 0x000c-0x000d], which spans more than PCI Bus :00 [mem 0x000d-0x000d window] caller pci_map_rom+0x68/0x1b0 mapping multiple BARs amdgpu :01:00.0: No more image in the PCI ROM amdgpu :01:00.0: amdgpu: Fetched VBIOS from ROM BAR amdgpu: ATOM BIOS: xxx-xxx-xxx amdgpu :01:00.0: amdgpu: Trusted Memory Zone (TMZ) feature not supported amdgpu :01:00.0: amdgpu: PCIE atomic ops is not supported [drm] PCIE gen 2 link speeds already enabled [drm] vm size is 64 GB, 2 levels, block size is 10-bit, fragment size is 9-bit RTL8211B Gigabit Ethernet r8169-0-300:00: attached PHY driver (mii_bus:phy_addr=r8169-0-300:00, irq=MAC) r8169 :03:00.0 eth0: Link is Down amdgpu :01:00.0: amdgpu: VRAM: 2048M 0x00F4 - 0x00F47FFF (2048M used) amdgpu :01:00.0: amdgpu: GART: 1024M 0x00FF - 0x00FF3FFF [drm] Detected VRAM RAM=2048M, BAR=256M [drm] RAM width 128bits DDR3 [drm] amdgpu: 2048M of VRAM memory ready [drm] amdgpu: 3979M of GTT memory ready. [drm] GART: num cpu pages 262144, num gpu pages 262144 amdgpu :01:00.0: amdgpu: PCIE GART of 1024M enabled (table at 0x00F400A0). [drm] Internal thermal controller with fan control [drm] amdgpu: dpm initialized [drm] AMDGPU Display Connectors [drm] Connector 0: [drm] HDMI-A-1 [drm] HPD1 [drm] DDC: 0x194c 0x194c 0x194d 0x194d 0x194e 0x194e 0x194f 0x194f [drm] Encoders: [drm] DFP1: INTERNAL_UNIPHY [drm] Connector 1: [drm] DVI-D-1 [drm] HPD2 [drm] DDC: 0x1950 0x1950 0x1951 0x1951 0x1952 0x1952 0x1953 0x1953 [drm] Encoders: [drm] DFP2: INTERNAL_UNIPHY [drm] Connector 2: [drm] VGA-1 [drm] DDC: 0x1970 0x1970 0x1971 0x1971 0x1972 0x1972 0x1973 0x1973 [drm] Encoders: [drm] CRT1: INTERNAL_KLDSCP_DAC1 [drm] Found UVD firmware Version: 64.0 Family ID: 13 amdgpu: Move buffer fallback to memcpy unavailable [drm:amdgpu_device_init.cold [amdgpu]] *ERROR* sw_init of IP block failed -19 amdgpu :01:00.0: amdgpu: amdgpu_device_ip_init failed amdgpu :01:00.0: amdgpu: Fatal error during GPU init amdgpu :01:00.0: amdgpu: amdgpu: finishing device. BUG: kernel NULL pointer dereference, address: 009
Re: [git pull] drm fixes for 6.1-rc1
Thanks Dave, I reverted patch 312b4dc11d4f74bfe03ea25ffe04c1f2fdd13cb9 against 6.1-rc1 and the resulting kernel loaded amdgpu fine on my pc with Cape Verde GPU. Regards, Arthur. On 17 October 2022 8:14:18 am ACDT, Dave Airlie wrote: >On Sun, 16 Oct 2022 at 18:09, Arthur Marsh > wrote: >> >> From: Arthur Marsh >> >> Hi, the "drm fixes for 6.1-rc1" commit caused the amdgpu module to fail >> with my Cape Verde radeonsi card. >> >> I haven't been able to bisect the problem to an individual commit, but >> attach a dmesg extract below. >> >> I'm happy to supply any other configuration information and test patches. >> > >Can you try reverting: it's the only think I can spot that might >affect a card that old since most changes in that request were for >display hw you don't have. > >ommit 312b4dc11d4f74bfe03ea25ffe04c1f2fdd13cb9 >Author: Arunpravin Paneer Selvam >Date: Tue Oct 4 07:33:39 2022 -0700 > >drm/amdgpu: Fix VRAM BO swap issue > >DRM buddy manager allocates the contiguous memory requests in >a single block or multiple blocks. So for the ttm move operation >(incase of low vram memory) we should consider all the blocks to >compute the total memory size which compared with the struct >ttm_resource num_pages in order to verify that the blocks are >contiguous for the eviction process. > >v2: Added a Fixes tag >v3: Rewrite the code to save a bit of calculations and >variables (Christian) > >Fixes: c9cad937c0c5 ("drm/amdgpu: add drm buddy support to amdgpu") >Signed-off-by: Arunpravin Paneer Selvam >Reviewed-by: Christian König >Signed-off-by: Alex Deucher > > >Thanks, >Dave. > >> Arthur. >> >> Linux version 6.0.0+ (root@am64) (gcc-12 (Debian 12.2.0-5) 12.2.0, GNU ld >> (GNU Binutils for Debian) 2.39) #5179 SMP PREEMPT_DYNAMIC Fri Oct 14 >> 17:00:40 ACDT 2022 >> Command line: BOOT_IMAGE=/vmlinuz-6.0.0+ >> root=UUID=39706f53-7c27-4310-b22a-36c7b042d1a1 ro single amdgpu.audio=1 >> amdgpu.si_support=1 radeon.si_support=0 page_owner=on amdgpu.gpu_recovery=1 >> ... >> >> [drm] amdgpu kernel modesetting enabled. >> amdgpu :01:00.0: vgaarb: deactivate vga console >> Console: switching to colour dummy device 80x25 >> [drm] initializing kernel modesetting (VERDE 0x1002:0x682B 0x1458:0x22CA >> 0x87). >> [drm] register mmio base: 0xFE8C >> [drm] register mmio size: 262144 >> [drm] add ip block number 0 >> [drm] add ip block number 1 >> [drm] add ip block number 2 >> [drm] add ip block number 3 >> [drm] add ip block number 4 >> [drm] add ip block number 5 >> [drm] add ip block number 6 >> [drm] add ip block number 7 >> [drm] BIOS signature incorrect 5b 7 >> resource sanity check: requesting [mem 0x000c-0x000d], which spans >> more than PCI Bus :00 [mem 0x000d-0x000d window] >> caller pci_map_rom+0x68/0x1b0 mapping multiple BARs >> amdgpu :01:00.0: No more image in the PCI ROM >> amdgpu :01:00.0: amdgpu: Fetched VBIOS from ROM BAR >> amdgpu: ATOM BIOS: xxx-xxx-xxx >> amdgpu :01:00.0: amdgpu: Trusted Memory Zone (TMZ) feature not supported >> amdgpu :01:00.0: amdgpu: PCIE atomic ops is not supported >> [drm] PCIE gen 2 link speeds already enabled >> [drm] vm size is 64 GB, 2 levels, block size is 10-bit, fragment size is >> 9-bit >> RTL8211B Gigabit Ethernet r8169-0-300:00: attached PHY driver >> (mii_bus:phy_addr=r8169-0-300:00, irq=MAC) >> r8169 :03:00.0 eth0: Link is Down >> amdgpu :01:00.0: amdgpu: VRAM: 2048M 0x00F4 - >> 0x00F47FFF (2048M used) >> amdgpu :01:00.0: amdgpu: GART: 1024M 0x00FF - >> 0x00FF3FFF >> [drm] Detected VRAM RAM=2048M, BAR=256M >> [drm] RAM width 128bits DDR3 >> [drm] amdgpu: 2048M of VRAM memory ready >> [drm] amdgpu: 3979M of GTT memory ready. >> [drm] GART: num cpu pages 262144, num gpu pages 262144 >> amdgpu :01:00.0: amdgpu: PCIE GART of 1024M enabled (table at >> 0x00F400A0). >> [drm] Internal thermal controller with fan control >> [drm] amdgpu: dpm initialized >> [drm] AMDGPU Display Connectors >> [drm] Connector 0: >> [drm] HDMI-A-1 >> [drm] HPD1 >> [drm] DDC: 0x194c 0x194c 0x194d 0x194d 0x194e 0x194e 0x194f 0x194f >> [drm] Encoders: >> [drm] DFP1: INTERNAL_UNIPHY >> [drm] Connector 1: >> [drm] DVI-D-1 >> [drm] HPD2 >> [drm] DDC: 0x1950 0x1950 0x1951 0x1951 0x1952 0x1952 0x1953 0x1953 >> [drm] Encoders: >> [drm] DFP2: INTERNAL_UNIPHY >> [drm] Connector 2: >> [drm] VGA-1 >> [drm] DDC: 0x1970 0x1970 0x1971 0x1971 0x1972 0x1972 0x1973 0x1973 >> [drm] Encoders: >> [drm] CRT1: INTERNAL_KLDSCP_DAC1 >> [drm] Found UVD firmware Version: 64.0 Family ID: 13 >> amdgpu: Move buffer fallback to memcpy unavailable >> [drm:amdgpu_device_init.cold [amdgpu]] *ERROR* sw_init of IP block >> failed -19 >> amdgpu :01:00.0: amdgpu: amdgpu_device_ip_init failed >> amdgpu :01:00.0: amdgpu: Fatal error during GPU ini