Re: [edk2] [PATCH v1 1/1] BaseTools: incorrect calculation for 16M

[Carsey, Jaben]

Ignore.  Duplicate. Already sent out.

> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jaben Carsey
> Sent: Wednesday, May 09, 2018 1:51 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming@intel.com>
> Subject: [edk2] [PATCH v1 1/1] BaseTools: incorrect calculation for 16M
> Importance: High
> 
> the "0x" was missing.
> 
> Cc: Liming Gao <liming@intel.com>
> Cc: Yonghong Zhu <yonghong@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jaben Carsey <jaben.car...@intel.com>
> ---
>  BaseTools/Source/Python/GenFds/FvImageSection.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/BaseTools/Source/Python/GenFds/FvImageSection.py
> b/BaseTools/Source/Python/GenFds/FvImageSection.py
> index eb84b44bbec4..57ecea0377bf 100644
> --- a/BaseTools/Source/Python/GenFds/FvImageSection.py
> +++ b/BaseTools/Source/Python/GenFds/FvImageSection.py
> @@ -1,7 +1,7 @@
>  ## @file
>  # process FV image section generation
>  #
> -#  Copyright (c) 2007 - 2017, Intel Corporation. All rights reserved.
> +#  Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
>  #
>  #  This program and the accompanying materials
>  #  are licensed and made available under the terms and conditions of the
> BSD License
> @@ -83,7 +83,7 @@ class FvImageSection(FvImageSectionClassObject):
>  if MaxFvAlignment >= 0x400:
>  if MaxFvAlignment >= 0x10:
>  #The max alignment supported by FFS is 16M.
> -if MaxFvAlignment >=100:
> +if MaxFvAlignment >= 0x100:
>  self.Alignment = "16M"
>  else:
>  self.Alignment = str(MaxFvAlignment / 0x10) + "M"
> --
> 2.16.2.windows.1
> 
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v1 1/1] BaseTools: incorrect calculation for 16M

[Zhu, Yonghong]

Reviewed-by: Yonghong Zhu  

Best Regards,
Zhu Yonghong


-Original Message-
From: Carsey, Jaben 
Sent: Wednesday, May 09, 2018 12:02 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming ; Zhu, Yonghong 
Subject: [PATCH v1 1/1] BaseTools: incorrect calculation for 16M

the "0x" was missing.

Cc: Liming Gao 
Cc: Yonghong Zhu 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey 
---
 BaseTools/Source/Python/GenFds/FvImageSection.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/BaseTools/Source/Python/GenFds/FvImageSection.py 
b/BaseTools/Source/Python/GenFds/FvImageSection.py
index eb84b44bbec4..57ecea0377bf 100644
--- a/BaseTools/Source/Python/GenFds/FvImageSection.py
+++ b/BaseTools/Source/Python/GenFds/FvImageSection.py
@@ -1,7 +1,7 @@
 ## @file
 # process FV image section generation
 #
-#  Copyright (c) 2007 - 2017, Intel Corporation. All rights reserved.
+#  Copyright (c) 2007 - 2018, Intel Corporation. All rights 
+reserved.
 #
 #  This program and the accompanying materials  #  are licensed and made 
available under the terms and conditions of the BSD License @@ -83,7 +83,7 @@ 
class FvImageSection(FvImageSectionClassObject):
 if MaxFvAlignment >= 0x400:
 if MaxFvAlignment >= 0x10:
 #The max alignment supported by FFS is 16M.
-if MaxFvAlignment >=100:
+if MaxFvAlignment >= 0x100:
 self.Alignment = "16M"
 else:
 self.Alignment = str(MaxFvAlignment / 0x10) + "M"
--
2.16.2.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH v1 1/1] BaseTools: incorrect calculation for 16M

[Jaben Carsey]

the "0x" was missing.

Cc: Liming Gao 
Cc: Yonghong Zhu 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey 
---
 BaseTools/Source/Python/GenFds/FvImageSection.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/BaseTools/Source/Python/GenFds/FvImageSection.py 
b/BaseTools/Source/Python/GenFds/FvImageSection.py
index eb84b44bbec4..57ecea0377bf 100644
--- a/BaseTools/Source/Python/GenFds/FvImageSection.py
+++ b/BaseTools/Source/Python/GenFds/FvImageSection.py
@@ -1,7 +1,7 @@
 ## @file
 # process FV image section generation
 #
-#  Copyright (c) 2007 - 2017, Intel Corporation. All rights reserved.
+#  Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
 #
 #  This program and the accompanying materials
 #  are licensed and made available under the terms and conditions of the BSD 
License
@@ -83,7 +83,7 @@ class FvImageSection(FvImageSectionClassObject):
 if MaxFvAlignment >= 0x400:
 if MaxFvAlignment >= 0x10:
 #The max alignment supported by FFS is 16M.
-if MaxFvAlignment >=100:
+if MaxFvAlignment >= 0x100:
 self.Alignment = "16M"
 else:
 self.Alignment = str(MaxFvAlignment / 0x10) + "M"
-- 
2.16.2.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel