Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: Zeng, Star
> Sent: Thursday, July 19, 2018 3:32 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Kinney, Michael D
>
> Subject: [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg
> FmpDxe: Return 0 when LSV check is not required
>
> Current code return 1 when LSV check is not required,
> but 1 LSV will make 0 Version capsule image update failed.
>
> 0 LSV is valid, this patch updates the code to return 0
> when
> LSV check is not required
> We can see even the DEFAULT_LOWESTSUPPORTEDVERSION is 0.
>
> Cc: Michael D Kinney
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng
> ---
> FmpDevicePkg/FmpDxe/FmpDxe.c | 9 ++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c
> b/FmpDevicePkg/FmpDxe/FmpDxe.c
> index c0c1383723fb..d6b599ee1a56 100644
> --- a/FmpDevicePkg/FmpDxe/FmpDxe.c
> +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c
> @@ -210,12 +210,15 @@ GetLowestSupportedVersion (
>// Get the LowestSupportedVersion.
>//
>
> - DeviceLibLowestSupportedVersion =
> DEFAULT_LOWESTSUPPORTEDVERSION;
> - ReturnLsv = PcdGet32
> (PcdFmpDeviceBuildTimeLowestSupportedVersion);
>if (!IsLowestSupportedVersionCheckRequired ()) {
> -return 1;
> +//
> +// Any Versioon can pass the 0 LowestSupportedVersion
> check.
> +//
> +return 0;
>}
>
> + ReturnLsv = PcdGet32
> (PcdFmpDeviceBuildTimeLowestSupportedVersion);
> +
>//
>// Check the FmpDeviceLib
>//
> --
> 2.7.0.windows.1
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel