[Bug 483277] Review Request: nautilus-gdu - Nautilus extension for disk formatting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483277 Tomáš Bžatek changed: What|Removed |Added Status|NEW |CLOSED Resolution||NEXTRELEASE --- Comment #8 from Tomáš Bžatek 2009-02-04 08:15:16 EDT --- Successfully built in rawhide: http://koji.fedoraproject.org/koji/buildinfo?buildID=81493 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483277] Review Request: nautilus-gdu - Nautilus extension for disk formatting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483277 Huzaifa S. Sidhpurwala changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483277] Review Request: nautilus-gdu - Nautilus extension for disk formatting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483277 --- Comment #7 from Huzaifa S. Sidhpurwala 2009-02-04 05:56:11 EDT --- cvs done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483277] Review Request: nautilus-gdu - Nautilus extension for disk formatting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483277 Tomáš Bžatek changed: What|Removed |Added AssignedTo|mcla...@redhat.com |tbza...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483277] Review Request: nautilus-gdu - Nautilus extension for disk formatting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483277 Tomáš Bžatek changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Tomáš Bžatek 2009-02-03 04:29:56 EDT --- New Package CVS Request === Package Name: nautilus-gdu Short Description: Nautilus extension for disk formatting Owners: tbzatek Branches: devel InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483277] Review Request: nautilus-gdu - Nautilus extension for disk formatting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483277 Matthias Clasen changed: What|Removed |Added Flag||fedora-review+ --- Comment #5 from Matthias Clasen 2009-02-02 22:53:58 EDT --- looks good now. approved -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483277] Review Request: nautilus-gdu - Nautilus extension for disk formatting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483277 --- Comment #4 from Tomáš Bžatek 2009-02-02 09:06:01 EDT --- Thanks for the review. I've added a comment how to get sources from git (by cloning the repo). Fixed files: Spec URL: http://tbzatek.fedorapeople.org/nautilus-gdu/nautilus-gdu.spec SRPM URL: http://tbzatek.fedorapeople.org/nautilus-gdu/nautilus-gdu-0.1-git20090130.1.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483277] Review Request: nautilus-gdu - Nautilus extension for disk formatting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483277 --- Comment #3 from Matthias Clasen 2009-01-30 13:50:57 EDT --- package name: ok spec file name: ok packaging guidelines: ok license: ok license field: ok license file: ok spec file language: ok spec file legible: ok sources: you should probably add a comment explaining how to get the tarball from git. longer-term, we need to sort out hosting buildable: ok excludearch: ok build deps: ok locale handling: ok, no translations right now. sorting that out ties in to the hosting question... ldconfig: I don't think you need to call ldconfig in %post/%postun, since you are not installing a shared library in the linker path, just a loadable module relocatable: n/a directory ownership: ok duplicate files: ok permissions: ok %clean: ok macro use: ok permissible content: ok large docs: n/a %doc content: ok headers: n/a static libs: n/a pc files: ok shared libs: ok devel subpackage: n/a libtool archives: ok gui apps: ok file ownership: ok %install: ok utf8 filenames: ok Summary: - add source comment - remove unnecessary %post/%postun -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483277] Review Request: nautilus-gdu - Nautilus extension for disk formatting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483277 --- Comment #2 from Matthias Clasen 2009-01-30 13:25:38 EDT --- requires/provides/file list look sane -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483277] Review Request: nautilus-gdu - Nautilus extension for disk formatting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483277 --- Comment #1 from Matthias Clasen 2009-01-30 13:16:34 EDT --- Package builds fine in mock. rpmlint output: 3 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483277] Review Request: nautilus-gdu - Nautilus extension for disk formatting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483277 Matthias Clasen changed: What|Removed |Added CC||mcla...@redhat.com AssignedTo|nob...@fedoraproject.org|mcla...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review