[Bug 483625] Review Request: mythes-pt - Portuguese thesaurus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483625 Caolan McNamara changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225744] Merge Review: fbset
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225744
--- Comment #3 from Zdenek Prikryl 2009-02-03 04:09:38
EDT ---
(In reply to comment #1)
> * change buildroot to be guidelines compliant
Fixed.
> * add comment why %{?_smp_mflags} cannot be used
fbset doesn't use autotool's stuff, it is written by hand. So, you have to use
CFLAGS variable to pass additional options to the gcc.
> * add comment why make install DESTDIR=%{buildroot} cannot be used
This is a similar problem like above. In the makefile, there is no such
variable. There is a $(PREFIX) variable which is set by %makeinstall
> * add noreplace to the config (to silence rpmlint)
Fixed.
I committed the new spec into cvs. Please, review it, so I can bump a new
release.
Zdenek
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 431829] Review Request: thaifonts-scalable - Thai TrueType fonts (renamed to thai-scalable-fonts)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=431829 Jens Petersen changed: What|Removed |Added Summary|Review Request: |Review Request: |thaifonts-scalable - Thai |thaifonts-scalable - Thai |TrueType fonts |TrueType fonts (renamed to ||thai-scalable-fonts) --- Comment #9 from Jens Petersen 2009-02-03 04:24:17 EDT --- This package has been renamed to thai-scalable-fonts as part of the new fonts packaging process (bug 477465). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483277] Review Request: nautilus-gdu - Nautilus extension for disk formatting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483277 Tomáš Bžatek changed: What|Removed |Added AssignedTo|mcla...@redhat.com |tbza...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483277] Review Request: nautilus-gdu - Nautilus extension for disk formatting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483277 Tomáš Bžatek changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Tomáš Bžatek 2009-02-03 04:29:56 EDT --- New Package CVS Request === Package Name: nautilus-gdu Short Description: Nautilus extension for disk formatting Owners: tbzatek Branches: devel InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483615] Review Request: CodeAnalyst - Performance Analysis Suite for AMD-based System (based on Oprofile)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483615 --- Comment #3 from Jussi Lehtola 2009-02-03 04:36:48 EDT --- *** Bug 483320 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483540] Review Request: perl-Net-Stomp - Stomp client module for Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483540 Lubomir Rintel changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #4 from Lubomir Rintel 2009-02-03 04:41:01 EDT --- Imported and built. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483320] Review Request: CodeAnalyst - Performance Analysis Suite for AMD-based System (based on Oprofile)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483320 Jussi Lehtola changed: What|Removed |Added Resolution|WONTFIX |DUPLICATE --- Comment #2 from Jussi Lehtola 2009-02-03 04:36:48 EDT --- Is open source after all, but a new review request has been opened. Closing as duplicate. *** This bug has been marked as a duplicate of 483615 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481428] Review Request: rednotebook - A desktop diary
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481428 Fabian Affolter changed: What|Removed |Added Depends on||439667 --- Comment #3 from Fabian Affolter 2009-02-03 05:08:48 EDT --- A person reports that it works with the workaround from https://bugzilla.redhat.com/show_bug.cgi?id=439667#c8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483718] New: Review Request: hyphen-ca - Catalan hyphenation rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: hyphen-ca - Catalan hyphenation rules https://bugzilla.redhat.com/show_bug.cgi?id=483718 Summary: Review Request: hyphen-ca - Catalan hyphenation rules Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: caol...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://people.redhat.com/caolanm/rpms/hyphen-ca.spec SRPM URL: http://people.redhat.com/caolanm/rpms/hyphen-ca-0.20030920-1.fc10.src.rpm Description: Catalan hyphenation rules -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483718] Review Request: hyphen-ca - Catalan hyphenation rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483718 Parag AN(पराग) changed: What|Removed |Added CC||panem...@gmail.com AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483474] Review Request: perl-Test-TempDir - Temporary files support for testing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483474 Allisson Azevedo changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225856] Merge Review: gpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225856 --- Comment #10 from Zdenek Prikryl 2009-02-03 05:58:50 EDT --- Ok, I committed the new spec file into the cvs. The library is now stripped. Please, review it, so I can bump a new release. Also, I did minor clean up in %prep and %bild section. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483641] Review Request: perl-Date-Tiny - Date object with as little code as possible
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483641 Allisson Azevedo changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Allisson Azevedo 2009-02-03 05:58:50 EDT --- New Package CVS Request === Package Name: perl-Date-Tiny Short Description: Date object with as little code as possible Owners: allisson Branches: F-9 F-10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483723] New: Review Request: mythes-bg - Bulgarian thesaurus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: mythes-bg - Bulgarian thesaurus https://bugzilla.redhat.com/show_bug.cgi?id=483723 Summary: Review Request: mythes-bg - Bulgarian thesaurus Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: caol...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://people.redhat.com/caolanm/rpms/mythes-bg.spec SRPM URL: http://people.redhat.com/caolanm/rpms/mythes-bg-4.1-1.fc10.src.rpm Description: Bulgarian thesaurus -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483641] Review Request: perl-Date-Tiny - Date object with as little code as possible
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483641 manuel wolfshant changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|wo...@nobugconsulting.ro Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483657] Review Request: perl-MooseX-Policy-SemiAffordanceAccessor - Policy to name accessors foo() and set_foo()
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483657 Allisson Azevedo changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Allisson Azevedo 2009-02-03 05:43:52 EDT --- New Package CVS Request === Package Name: perl-MooseX-Policy-SemiAffordanceAccessor Short Description: Policy to name accessors foo() and set_foo() Owners: allisson Branches: F-9 F-10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483718] Review Request: hyphen-ca - Catalan hyphenation rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483718 Parag AN(पराग) changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-review? |fedora-review+ --- Comment #1 from Parag AN(पराग) 2009-02-03 05:29:24 EDT --- Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1101212 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 16ba21e982d981c8c74e54c5a9254fa3 hyph_ca_ES.zip + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483729] Review Request:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483729 Itamar Reis Peixoto changed: What|Removed |Added CC||ita...@ispbrasil.com.br --- Comment #1 from Itamar Reis Peixoto 2009-02-03 07:26:03 EDT --- hello, what package you're trying to submit for review ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483730] New: Review Request: kde-plasma-translatoid - A Google Translation Plasmoid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: kde-plasma-translatoid - A Google Translation Plasmoid https://bugzilla.redhat.com/show_bug.cgi?id=483730 Summary: Review Request: kde-plasma-translatoid - A Google Translation Plasmoid Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: e...@orbsky.homelinux.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://orbsky.homelinux.org/packages/kde-plasma-tranlatoid.spec Spec URL: ftp://orbsky.homelinux.org/pub/packages/http://orbsky.homelinux.org/packages/kde-plasma-translatoid-0.4.1-1.fc10.src.rpm SRPM URL: http://orbsky.homelinux.org/packages/kde-plasma-translatoid-0.4.1-1.fc10.src.rpm SRPM URL: ftp://orbsky.homelinux.org/pub/packages/http://orbsky.homelinux.org/packages/kde-plasma-translatoid-0.4.1-1.fc10.src.rpm Description: This my second package :) kde-plasma-translatoid provides a widget that will allow users to perform tranlations using the Google Translation engine. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483729] Review Request:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483729 Itamar Reis Peixoto changed: What|Removed |Added Status|NEW |CLOSED Resolution||INSUFFICIENT_DATA --- Comment #2 from Itamar Reis Peixoto 2009-02-03 07:37:49 EDT --- feel free to reopen this ticket if you need help in something -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483728] Review Request: kde-plasma-ihatethecashew - Gets rid of the cashew on KDE Workspace
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483728
Jaroslav Reznik changed:
What|Removed |Added
CC||jrez...@redhat.com
--- Comment #1 from Jaroslav Reznik 2009-02-03 07:48:31
EDT ---
rpmlint output:
kde-plasma-ihatethecashew.src: E: no-cleaning-of-buildroot %install
- remove mkdir %{buildroot}
kde-plasma-ihatethecashew.src: W: summary-ended-with-dot Removes the KDE Plasma
Cashew From the Corner of the Display.
- remove dot, summary shouldn't end with dot
kde-plasma-ihatethecashew.src: E: description-line-too-long I don't like the
cashew (the nasty icon in the right top corner of your plasma desktop
kde-plasma-ihatethecashew.src: E: description-line-too-long that won't go away,
even if plasma's locked)... It's impossible to remove this [cashew]
- description is a little weird and full of emotions :) "I don't like..." is
not a good description, please rewrite it in more polite and descriptive way.
kde-plasma-ihatethecashew.x86_64: W: incoherent-version-in-changelog 0.2b
['0.2b-1.fc10', '0.2b-1']
- use release too
* Mon Feb 02 2009 Eli Wapniarski 0.2b-1
Do not say "My first package" in Changelog, "Initial package" is OK
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483730] Review Request: kde-plasma-translatoid - A Google Translation Plasmoid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483730 Jaroslav Reznik changed: What|Removed |Added CC||jrez...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483730] Review Request: kde-plasma-translatoid - A Google Translation Plasmoid
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483730
--- Comment #1 from Jaroslav Reznik 2009-02-03 08:29:48
EDT ---
rpmlint output:
kde-plasma-translatoid.src: E: invalid-spec-name
- missing 's' in spec filename
kde-plasma-translatoid.src: E: no-cleaning-of-buildroot %install
- same as for #483728
kde-plasma-translatoid.src: W: summary-not-capitalized translator using google
translator
- capitalize summary, description too
kde-plasma-translatoid.x86_64: W: spurious-executable-perm
/usr/share/doc/kde-plasma-translatoid-0.4.1/README
kde-plasma-translatoid.x86_64: W: incoherent-version-in-changelog 0.4.1
['0.4.1-1.fc10', '0.4.1-1']
- same as for #483728
- license GPLv2+
- I'm not sure about Google trademarks, let me check
- URL should be
http://www.kde-look.org/content/show.php/translatoid?content=97511
- you should use 97511-translatoid%{version} in Source0
- remove flags due to Fedora policy
- use build root consistently - rm -rf $RPM_BUILD_ROOT -> rm -rf ${buildroot}
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483723] Review Request: mythes-bg - Bulgarian thesaurus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483723 Parag AN(पराग) changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483728] Review Request: kde-plasma-ihatethecashew - Gets rid of the cashew on KDE Workspace
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483728 --- Comment #3 from Eli Wapniarski 2009-02-03 09:20:09 EDT --- I requested clarification for the licenses. Made the corrections as indicated in the above comments Spec URL: http://orbsky.homelinux.org/packages/kde-plasma-ihatethecashew.spec Spec URL: ftp://orbsky.homelinux.org/pub/packages/kde-plasma-ihatethecashew.spec SRPM URL: http://orbsky.homelinux.org/packages/kde-plasma-ihatethecashew-0.2b-2.fc10.src.rpm SRPM URL: ftp://orbsky.homelinux.org/pub/packages/kde-plasma-ihatethecashew-0.2b-2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481224] Review Request: rabbitmq-server - An AMQP server written in Erlang
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481224
--- Comment #4 from Peter Lemenkov 2009-02-03 05:55:14
EDT ---
* In some cases you don't need to create directories before installing files to
them, because 'install' utility has special switch '-D'. E.g. instead of
mkdir -p %{buildroot}%{_initrddir}
install -m 0755 %SOURCE1 %{buildroot}%{_initrddir}/rabbitmq-server
you may write
install -D -m 0755 %SOURCE1 %{buildroot}%{_initrddir}/rabbitmq-server
* Invoke 'install' with '-p' switch while installing files (in order to
preserve timestamps).
* This line should be removed (looks like leftover)
chmod 0755 %{buildroot}%{_initrddir}/rabbitmq-server
* you should consider using
rm %{_maindir}/{LICENSE,LICENSE-MPL-RabbitMQ,INSTALL}
instead of
rm %{_maindir}/LICENSE %{_maindir}/LICENSE-MPL-RabbitMQ %{_maindir}/INSTALL
* regarding init-script. It should not be started by default. So, please, fix
chkconfig's header from
#chkconfig: 2345 80 05
to
#chkconfig: - 80 05
You should fix init-header also.
* It's a generally good idea to move some commandline switches from start
section of initscript to /etc/sysconfig/%{name}
See this, for example:
http://cvs.fedoraproject.org/viewvc/rpms/ejabberd/devel/ejabberd.init?view=markup
http://cvs.fedoraproject.org/viewvc/rpms/ejabberd/devel/ejabberd.sysconfig?view=markup
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226463] Merge Review: system-config-netboot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226463 --- Comment #15 from Jaroslav Reznik 2009-02-03 09:24:24 EDT --- Updated package in Rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225764] Merge Review: fonts-ISO8859-2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225764 Parag AN(पराग) changed: What|Removed |Added CC|panem...@gmail.com | AssignedTo|panem...@gmail.com |nob...@fedoraproject.org Flag|fedora-review? | --- Comment #6 from Parag AN(पराग) 2009-02-03 09:36:48 EDT --- Almost more than one month no response from package maintainer. And looks like I also lost now interest in this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477870] Review Request: eclipse-emf - Eclipse Modeling Framework (EMF) Eclipse plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477870 Andrew Overholt changed: What|Removed |Added Status|NEW |ASSIGNED Flag||needinfo?(fed...@matbooth.c ||o.uk) --- Comment #13 from Andrew Overholt 2009-02-03 10:10:26 EDT --- I'll take this review. Everything looks good to me. I have a few questions: - does this comment mean we have reduced functionality? "... these files aren't needed for source plugins; they are only needed "so the example-installer plugins can create full projects in your workspace)" - could we match upstream's qualifier instead of that of the build? I worry this will give multilib conflicts since the builds on x86_64 and x86 will happen on different machines without the same hour and minute. If we can't match upstream's qualifier (in the case they're all different), just set it to something sane so all arches end up the same. - why not use separate dropins directories for the sub-packages? This gives a much cleaner %files section Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481022] Review Request: SPE - Stani's Python Editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481022 --- Comment #7 from Mamoru Tasaka 2009-02-03 10:11:04 EDT --- (In reply to comment #5) > 2/in tar file they are a shortcuts directories: _spe/shortcuts/ > this directories i can remove it in the spec file? > > rm -rf ./_spe/shortcuts/ - If you think this directory is not needed, please do. > ___ > 3/ i look all import from .py file, left 3 diorecotries(tabs,test ans view) - So would you tell me if the dependency I pointed out on my previous comment is a must or just optional? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 428567] Review Request: ETL - Extended Template Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=428567 --- Comment #67 from Nicolas Chauvet (kwizart) 2009-02-03 10:43:52 EDT --- any question / tought ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477870] Review Request: eclipse-emf - Eclipse Modeling Framework (EMF) Eclipse plugin
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=477870
--- Comment #14 from Andrew Overholt 2009-02-03 11:02:35
EDT ---
As for the
FIX rpmlint shows no warnings
The only one is this:
eclipse-emf.noarch: W: obsolete-not-provided eclipse-emf-standalone
I think we need a Provide there as well (see
http://fedoraproject.org/wiki/PackagingDrafts/ProvidesObsoletes)
OK package named correctly
OK spec file named correctly
OK meets the Packaging Guidelines (except for above)
OK license is correct, approved and in %doc
OK license field in the package spec file matches the actual license
OK shell script for fetching sources is included
OK package MUST successfully compile and build into binary rpms on at least
one primary architecture (I tested x86_64 but it's noarch ...)
OK md5sum of my fetched tarball doesn't match yours but that's just timestamps;
diff -r gives no output
OK owns all directories
OK doesn't contain any duplicate files
OK permissions are correctly set
OK clean section present
OK uses macros consistently
OK package contains code
OK no large documentation files
OK if a package includes something as %doc, it must not affect the runtime of
the application.
OK packages must not own files or directories already owned by other packages.
OK %install MUST run rm -rf %{buildroot}
OK all filenames must be valid UTF-8
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483729] New: Review Request:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: https://bugzilla.redhat.com/show_bug.cgi?id=483729 Summary: Review Request: Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: e...@orbsky.homelinux.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: SRPM URL: Description: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483728] New: Review Request: kde-plasma-ihatethecashew - Gets rid of the cashew on KDE Workspace
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: kde-plasma-ihatethecashew - Gets rid of the cashew on KDE Workspace https://bugzilla.redhat.com/show_bug.cgi?id=483728 Summary: Review Request: kde-plasma-ihatethecashew - Gets rid of the cashew on KDE Workspace Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: e...@orbsky.homelinux.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://orbsky.homelinux.org/packages/kde-plasma-ihatethecashew.spec Spec URL: ftp://orbsky.homelinux.org/pub/packages/kde-plasma-ihatethecashew.spec SRPM URL: http://orbsky.homelinux.org/packages/kde-plasma-ihatethecashew-0.2b-1.fc10.src.rpm SRPM URL: ftp://orbsky.homelinux.org/pub/packages/kde-plasma-ihatethecashew-0.2b-1.fc10.src.rpm Description: This is my first effort at packaging. It would be greatly appreciated if the package was reviewed. kde-plasma-ihatethecashew will create a plasmoid widget when added to the workspace will get rid of the "cashew" sitting on the top left of the KDE Workspace. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483569] Review Request: perl-MooseX-Types-Set-Object - Set::Object type with coercions and stuff
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483569 Allisson Azevedo changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483728] Review Request: kde-plasma-ihatethecashew - Gets rid of the cashew on KDE Workspace
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483728
--- Comment #2 from Jaroslav Reznik 2009-02-03 08:01:46
EDT ---
- use build root consistently - rm -rf $RPM_BUILD_ROOT -> rm -rf ${buildroot}
- license matches COPYING but not ihtc.cpp (LGPLv2 is mentioned in header,
should be GPLv2), ask upstream to correct it
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483728] Review Request: kde-plasma-ihatethecashew - Gets rid of the cashew on KDE Workspace
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483728
--- Comment #4 from Jaroslav Reznik 2009-02-03 09:40:47
EDT ---
Ops, sorry, I missed ${buildroot} - it should be 'rm -rf %{buildroot}'.
rpmlint output:
kde-plasma-ihatethecashew.x86_64: W: summary-ended-with-dot Removes the KDE
Plasma Cashew From the Corner of the Display.
- remove dot
PS: check your SPEC, SRPM and RPM by rpmlint before uploading :)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477750] Review Request: Ogmtools - Tools for Ogg media streams
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477750 Bastien Nocera changed: What|Removed |Added CC||bnoc...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483628] Review Request: perl-Geo-IPfree - Look up country of IP Address
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483628 Allisson Azevedo changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Allisson Azevedo 2009-02-03 05:40:15 EDT --- New Package CVS Request === Package Name: perl-Geo-IPfree Short Description: Look up country of IP Address Owners: allisson Branches: F-9 F-10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483727] New: Review Request: touchcal - Calibration utility for touch screens
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: touchcal - Calibration utility for touch screens https://bugzilla.redhat.com/show_bug.cgi?id=483727 Summary: Review Request: touchcal - Calibration utility for touch screens Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: d...@danny.cz QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://fedora.danny.cz/touchcal.spec SRPM URL: http://fedora.danny.cz/touchcal-0.31-1.fc11.src.rpm Description: touchcal is a tool to calibrate touch screens with serial controllers from the manufacturers EloGraphics (IntelliTouch E281-2310) and MicroTouch (SMT3 serial) for use under Xorg. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483205] Review Request: eclipse-SystemTapGui - GUI interface for SystemTap
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483205 --- Comment #9 from Anithra 2009-02-03 11:27:16 EDT --- (In reply to comment #8) > (In reply to comment #5) > > (In reply to comment #2) > > > Is the camel casing necessary in the name? Just curious ... > > > > Its not really necessary, but is there just for the sake of uniformity as > > SystemTap also has camel casing. > > $ rpm -q systemtap > systemtap-0.8-1.fc10.x86_64 Point taken. Should i be changing it to systemtapgui?. We have been using the camel casing in the sourceforge rcp packages and ive just continued it here. I can change it if needed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483676] Review Request: perl-App-Asciio - Draw ascii art quickly and easily!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483676 --- Comment #4 from Chris Weyl 2009-02-03 12:19:36 EDT --- All three are well taken; I'll make those changes. Would you like to see them pre-approval, or can I make the changes before importing? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483728] Review Request: kde-plasma-ihatethecashew - Gets rid of the cashew on KDE Workspace
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483728 --- Comment #5 from Eli Wapniarski 2009-02-03 12:22:33 EDT --- Spec URL: http://orbsky.homelinux.org/packages/kde-plasma-ihatethecashew.spec Spec URL: ftp://orbsky.homelinux.org/pub/packages/kde-plasma-ihatethecashew.spec SRPM URL: http://orbsky.homelinux.org/packages/kde-plasma-ihatethecashew-0.2b-3.fc10.src.rpm SRPM URL: ftp://orbsky.homelinux.org/pub/packages/kde-plasma-ihatethecashew-0.2b-3.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483728] Review Request: kde-plasma-ihatethecashew - Gets rid of the cashew on KDE Workspace
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483728 Eli Wapniarski changed: What|Removed |Added Blocks||177841 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483187] Review Request: kde-plasma-weather - Plasma applet for weather forecasts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483187 --- Comment #18 from Shawn Starr 2009-02-03 12:46:39 EDT --- The spec file will be changed today. I am getting an official extragear tarball instead of pulling from SVN. We will use this for 4.2.x series, 4.3 will be using kdeplasma-addons. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477542] Review Request: mpdscribble - A mpd client which submits information about tracks being played to Last.fm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477542 --- Comment #3 from Jaroslaw Gorny 2009-02-03 12:53:22 EDT --- * I've updated to latest version (0.16) - 0.13 was latest when I packaged it. * %changelog fixed So rpmlint is quiet - at least here. Results are here: SRPM URL: http://strony.aster.pl/muranow/fedora/mpdscribble-0.16-1.fc10.src.rpm SPEC URL: http://strony.aster.pl/muranow/fedora/mpdscribble.spec OK, I'll consider to package libmpdclient too ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478749] Review Request: dinotrace - X11 waveform viewer for electronics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478749 --- Comment #8 from Chitlesh GOORAH 2009-02-03 12:53:22 EDT --- I'll update it next week. This weekend will be FOSDEM and I've to get my presentation ready and meet the fedora ambassadors. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483641] Review Request: perl-Date-Tiny - Date object with as little code as possible
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483641
manuel wolfshant changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #1 from manuel wolfshant 2009-02-03
05:54:39 EDT ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines including the Perl specific items
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on: devel/x86_64
[x] Rpmlint output:
source RPM: empty
binary RPM:empty
[x] Package is not relocatable.
[x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type: GPL+ or Artistic (same as perl)
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
SHA1SUM of package: f16f5274a90d3002f944762de53439914c1bb51a
Date-Tiny-1.03.tar.gz
[x] Package is not known to require ExcludeArch
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package has a %clean section, which contains rm $RPM_BUILD_ROOT.
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[x] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
[x] Package does not include license text files separate from upstream.
[-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: devel/x86_64
[x] Package should compile and build into binary rpms on all supported
architectures.
Tested on: devel/x86_64
[?] Package functions as described.
[-] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files is correct.
[-] File based requires are sane.
[x] %check is present and the tests pass.
*** APPROVED ***
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483726] New: Review Request: smp_utils - Utilities for SAS management protocol (SMP)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: smp_utils - Utilities for SAS management protocol (SMP) https://bugzilla.redhat.com/show_bug.cgi?id=483726 Summary: Review Request: smp_utils - Utilities for SAS management protocol (SMP) Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: d...@danny.cz QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://fedora.danny.cz/smp_utils.spec SRPM URL: http://fedora.danny.cz/smp_utils-0.94-1.fc11.src.rpm Description: This is a package of utilities. Each utility sends a Serial Attached SCSI (SAS) Management Protocol (SMP) request to a SMP target. If the request fails then the error is decoded. If the request succeeds then the response is either decoded, printed out in hexadecimal or output in binary. This package supports multiple interfaces since SMP passthroughs are not mature. This package supports the linux 2.4 and 2.6 series and should be easy to port to other operating systems. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483459] Review Request: perl-MooseX-Iterator - Iterate over collections
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483459 Allisson Azevedo changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483461] Review Request: perl-MooseX-Param - Simple role to provide a standard param method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483461 Allisson Azevedo changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483649] Review Request: perl-MooseX-Workers - Provides a simple sub-process management for asynchronous tasks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483649 Allisson Azevedo changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Allisson Azevedo 2009-02-03 05:38:02 EDT --- New Package CVS Request === Package Name: perl-MooseX-Workers Short Description: Provides a simple sub-process management for asynchronous tasks Owners: allisson Branches: F-9 F-10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483718] Review Request: hyphen-ca - Catalan hyphenation rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483718 Caolan McNamara changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Caolan McNamara 2009-02-03 05:40:59 EDT --- New Package CVS Request === Package Name: hyphen-ca Short Description: Catalan hyphenation rules Owners: caolanm Branches: devel InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483723] Review Request: mythes-bg - Bulgarian thesaurus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483723 Parag AN(पराग) changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #1 from Parag AN(पराग) 2009-02-03 09:01:18 EDT --- Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1101536 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 57bc773ce540b2bc681795d005ba7e80 OOo-thes-bg-4.1.zip + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. Suggestions: 1) Use Source URL as http://downloads.sourceforge.net/sourceforge/bgoffice/OOo-thes-bg-4.1.zip 2) License is GPLv2+ APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483557] Review Request: perl-MooseX-SimpleConfig - Moose role for setting attributes from a simple configfile
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483557 Allisson Azevedo changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483723] Review Request: mythes-bg - Bulgarian thesaurus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483723 Caolan McNamara changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Caolan McNamara 2009-02-03 09:13:57 EDT --- New Package CVS Request === Package Name: mythes-bg Short Description: Bulgarian thesaurus Owners: caolanm Branches: devel InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483730] Review Request: kde-plasma-translatoid - A Google Translation Plasmoid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483730 --- Comment #2 from Eli Wapniarski 2009-02-03 14:53:59 EDT --- OK.. I believe that I should withdraw this because of the flag issue. Any thoughts. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225630] Merge Review: buildsys-macros
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225630 Dennis Gregorovic changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution||CURRENTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 472269] Review Request: python-rope - Python Code Refactoring Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472269 Toshio Ernie Kuratomi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Toshio Ernie Kuratomi 2009-02-03 15:00:22 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483838] New: Review Request: vmware-view-open-client - Client for Windows desktops managed by VMware View
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: vmware-view-open-client - Client for Windows desktops managed by VMware View https://bugzilla.redhat.com/show_bug.cgi?id=483838 Summary: Review Request: vmware-view-open-client - Client for Windows desktops managed by VMware View Product: Fedora Version: 10 Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: lkund...@v3.sk QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora SPEC: http://v3.sk/~lkundrak/SPECS/vmware-view-open-client.spec SRPM: http://v3.sk/~lkundrak/SRPMS/vmware-view-open-client-2.1.1-1.fc11.src.rpm Description: VMware View Open Client lets you connect from a Linux desktop to remote Windows desktops managed by VMware View. It supports two factor authentication with RSA SecurID and is able to create a secure tunnel using SSL. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483838] Review Request: vmware-view-open-client - Client for Windows desktops managed by VMware View
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483838 --- Comment #1 from Lubomir Rintel 2009-02-03 15:51:26 EDT --- Please note that creation of the package was optimized for speed: http://marek.mahut.sk/blog/2009/02/03/vmware-announces-open-source-vmware-viewer If you need to prove you can find actual errors in package in order to get sponsorship or whatever, this might be a good chance :o) Also, if you're interested in maintaining this more than me, please let me know ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 428568] Review Request: synfig - Synfig is a vector based 2D animation package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=428568 --- Comment #23 from Nicolas Chauvet (kwizart) 2009-02-03 15:47:24 EDT --- this package defines rpath on x86_64 Fedora 10 system : -- ERROR 0001: file '/usr/lib64/synfig/modules/libmod_gradient.so' contains a ... ERROR 0001: file '/usr/lib64/synfig/modules/libmod_ppm.so' contains a standard rpath '/usr/lib64' in [/usr/lib64] ERROR 0001: file '/usr/lib64/synfig/modules/liblyr_freetype.so' contains a standard rpath '/usr/lib64' in [/usr/lib64] ERROR 0001: file '/usr/bin/synfig' contains a standard rpath '/usr/lib64' in [/usr/lib64] -- This is because of the generated configure script. This can be avoided with autoreconf -f -i or patching the internal libtool between configure and make with: --- # remove rpath from libtool sed -i.rpath 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' libtool sed -i.rpath 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool --- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 472269] Review Request: python-rope - Python Code Refactoring Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472269 Toshio Ernie Kuratomi changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #4 from Toshio Ernie Kuratomi 2009-02-03 15:56:08 EDT --- Imported and built. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 472303] Review Request: python-ropevim - Python module to add rope refactoring to vim
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472303 Bug 472303 depends on bug 472269, which changed state. Bug 472269 Summary: Review Request: python-rope - Python Code Refactoring Library https://bugzilla.redhat.com/show_bug.cgi?id=472269 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483205] Review Request: eclipse-SystemTapGui - GUI interface for SystemTap
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483205 --- Comment #10 from Andrew Overholt 2009-02-03 14:02:55 EDT --- I like systemtapgui 'cause it's consistent with the rest of the Eclipse packages to have all lower case but I won't raise a stink since it's not in the guidelines :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 428568] Review Request: synfig - Synfig is a vector based 2D animation package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=428568 --- Comment #24 from Nicolas Chauvet (kwizart) 2009-02-03 16:30:03 EDT --- while compiling synfigstudio, it failed at this step: synfig -q synfig_icon.sif -o 128x128/synfig_icon.png --time 0 -w 128 -h 128 synfig(10044) [22:26:57] info: target name not specified - using png Segmentation error It seems that synfig failed at runtime for some reasons. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483846] New: Review Request: gsim85 - An 8085 microprocessor simulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: gsim85 - An 8085 microprocessor simulator https://bugzilla.redhat.com/show_bug.cgi?id=483846 Summary: Review Request: gsim85 - An 8085 microprocessor simulator Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: fab...@bernewireless.net QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://fab.fedorapeople.org/packages/SRPMS/gsim85.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/gsim85-0.2-1.fc10.src.rpm Project URL: http://gsim85.sourceforge.net/ Description: It is an 8085 simulator. it is having very user friendly graphical user interface. It can be used to test 8085 programs before actualy implementing them on target board. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1102409 rpmlint output: [...@laptop24 i386]$ rpmlint gsim85* 2 packages and 0 specfiles checked; 0 errors, 0 warnings. [...@laptop24 SRPMS]$ rpmlint gsim85-0.2-1.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477870] Review Request: eclipse-emf - Eclipse Modeling Framework (EMF) Eclipse plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477870 --- Comment #16 from Mat Booth 2009-02-03 16:27:23 EDT --- (In reply to comment #15) > (In reply to comment #13) > > I'll take this review. > > > > Everything looks good to me. I have a few questions: > > > > - does this comment mean we have reduced functionality? > > > > "... these files aren't needed for source plugins; they are only needed > > "so the example-installer plugins can create full projects in your > > workspace)" > > > > No, nothing is lost. I will change that comment to be clearer. The files are > still included such that they are present when you create the sample plugin > projects in your workspace. (They are merely omitted from the associated > source > plugins of the sample plugins in the same way they are omitted from the > associated source plugins of all other regular plugins.) > > If that makes any sense. > > To see what I mean just try creating some of the EMF sample plugins projects > through the new example wizard and making sure the .project/.classpath files > get created. > Oh my gods, there's a reason I'm not a technical writer. What I mean is, the patch (rightly) excludes those hidden files from the build process that creates source plugins. They are still present however, when the sample plugins are bundled to become the sample workspace projects available from the new->examples wizard within eclipse. I think that's marginally clearer... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 428567] Review Request: ETL - Extended Template Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=428567 --- Comment #69 from Nicolas Chauvet (kwizart) 2009-02-03 16:27:38 EDT --- (In reply to comment #68) > (In reply to comment #66) > likely anyways), the be renamed and a header that would include one depending > on __WORD_SIZE will be in their original place. This is a common practice. It would be an accurate solution, indeed. > When someone says "devel package", what comes to my mind is "useful for > development" Actually the package name is already ETL which only produce an ETL-devel. So I think we are good. I'm looking synfig/synfig studio to have usability tests of the ETL package... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483847] Review Request: gstreamer-rtsp - GStreamer RTSP server library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483847 Bastien Nocera changed: What|Removed |Added CC||mcla...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483847] New: Review Request: gstreamer-rtsp - GStreamer RTSP server library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: gstreamer-rtsp - GStreamer RTSP server library https://bugzilla.redhat.com/show_bug.cgi?id=483847 Summary: Review Request: gstreamer-rtsp - GStreamer RTSP server library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: bnoc...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://people.fedoraproject.org/~hadess/gstreamer-rtsp/gstreamer-rtsp.spec SRPM URL: http://people.fedoraproject.org/~hadess/gstreamer-rtsp/gstreamer-rtsp-0.10.1.0-1.fc10.src.rpm Description: A GStreamer-based RTSP server library, with Python and Vala bindings. Required to package gnome-dvb-daemon -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477870] Review Request: eclipse-emf - Eclipse Modeling Framework (EMF) Eclipse plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477870 Andrew Overholt changed: What|Removed |Added Flag||fedora-review+ --- Comment #17 from Andrew Overholt 2009-02-03 16:38:47 EDT --- Hi Mat, :) I understand now about removing the . files - I generally like to match the qualifier of upstream as sometimes plugins have hard-coded full major.minor.micro.qualifier numbers of their dependencies. Ignore my silly multilib statement :) - as for the dropins structure, if you think you can keep the %dir and various sub-directories/files straight in the %files sections, feel free to keep it as it is. I just personally find it easier to deal with single lines in each %files section. Since you get one zip from the build, what you have is fine. - I think you're right about the Provides as well. I genuinely wasn't sure. This package is APPROVED. Thanks very much, Mat! This package is incredibly popular and will enable us to get many other packages in. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483730] Review Request: kde-plasma-translatoid - A Google Translation Plasmoid
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483730
Milos Jakubicek changed:
What|Removed |Added
CC||xja...@fi.muni.cz
--- Comment #3 from Milos Jakubicek 2009-02-03 16:43:31
EDT ---
No no, that's not necessary at all, just remove the flags, e.g. by inserting:
sed -i -e 's/-fno-exceptions -fno-check-new -fno-common//' \
-e 's/-fno-threadsafe-statics -fvisibility=hidden
-fvisibility-inlines-hidden//' \
-e 's/-ansi//' %{_target_platform}/CMakeFiles/translatoid.dir/flags.make
before
make %{?_smp_mflags} -C %{_target_platform}
PS: Jaroslav, speaking about cflags, you should do the same in your
kde-plasma-quickaccess:)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 428567] Review Request: ETL - Extended Template Library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=428567
--- Comment #68 from Lubomir Rintel 2009-02-03 14:56:02 EDT
---
(In reply to comment #66)
> Look at
> https://bugzilla.redhat.com/show_bug.cgi?id=428567#c17
> The current package miss the etl_profile.h move into %{_libdir}/ETL and the
> related adds in ETL.pc (Cflags: -I${includedir} -I${libdir}/ETL)
> If ever the current ETL_HAS_ are the same with both arches on multilibs
> system,
> I would still prefer this solution since it will still be valid if others
> ETL_HAVE need to be introduced later.
etl_profile.h can not be moved there, apart from it not being a good idea, FHS
forbids that. In case the include files become arch-dependent (which is not
likely anyways), the be renamed and a header that would include one depending
on __WORD_SIZE will be in their original place. This is a common practice.
> About the package name. One could say this is not a -devel but a -headers
> subpackage only, since it doesn't contain the symlink to a shared object.
> But -devel and -headers only exist when there is a "main" package also.
> (kernel-headers and kernel-devel exist because they are for a different usage
> than the kernel package itself.)
> Since there is no such "main" package, I think the current package is the
> main.
>
> In other words:
> From one side, I don't see anything to override the Fedora guideline which
> tell
> to use the upstream source archive name as the "source" package name.
> https://fedoraproject.org/wiki/Packaging/NamingGuidelines#General_Naming
> See also https://bugzilla.redhat.com/show_bug.cgi?id=428567#c31
>
> On the other side, it remains possible for the ETL source package to only
> build
> an ETL-devel or ETL-headers package. (or to have only the
> ETL-%{version}-%{release}.src.rpm just build a plain
> ETL-%{version}-%{release}.%{_target_cpu}.rpm)
>
> (either using ETL-devel or ETL, the pkgconfig(ETL) provides will be properly
> extracted).
When someone says "devel package", what comes to my mind is "useful for
development", not "having a symlink to shared object" and I'd like to leave it
that way. I think you see that this might be a matter of personal taste and
doesn't violate guidelines, so I'm not going to change it unless there's a
really serious objection.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 428568] Review Request: synfig - Synfig is a vector based 2D animation package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=428568 --- Comment #25 from Muayyad Alsadi 2009-02-03 17:21:20 EDT --- same problem, please see my traceback the files are rendered perfectly but the segfault happens while unloading things or something like that I stepped in the program line by line, and it reached the end } of main without any problem selinux was disabled on my machine but I got it in the backtrace -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483857] New: Review Request: Eina - A classic player for a modern era
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: Eina - A classic player for a modern era https://bugzilla.redhat.com/show_bug.cgi?id=483857 Summary: Review Request: Eina - A classic player for a modern era Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: allis...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://allisson.fedorapeople.org/packages/eina/eina.spec SRPM URL: http://allisson.fedorapeople.org/packages/eina/eina-0.7.3-1.fc10.src.rpm Description: Eina works like a common portable music player. Just plays what you want to listen. Apart from simplicity, today users expect more from a player than just reading files. Artwork, lyrics, network support, artist data and other music information find their right place in Eina. Plugins can take care of all the extra functionality, since Eina exposes everything from its internals. It's fairly easy to extend the player capabilities and change the way it works inside. Feel free to request new features and make things the way you like. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483846] Review Request: gsim85 - An 8085 microprocessor simulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483846 manuel wolfshant changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|wo...@nobugconsulting.ro Flag||fedora-review? --- Comment #1 from manuel wolfshant 2009-02-03 18:41:28 EDT --- There is a small cosmetic issue with the desktop file: the icon should either contain the full path to the file or just the name (without extension). Your desktop file contains name.extension. As a minor non-blocking issue, you have a duplicate BR, gtk2-devel is brought in by libglade2-devel. It would be awesome if you also convince the installer to preserve the timestamps of the pixmaps. Given the build log, I'd say that adding INSTALL="install -p" to "make install "should do it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477870] Review Request: eclipse-emf - Eclipse Modeling Framework (EMF) Eclipse plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477870 --- Comment #18 from Mat Booth 2009-02-03 18:45:18 EDT --- Thanks Andrew. I will change the qualifier, but I don't think I will change the %files section at this time since I know it works right now and is unlikely to have to change before the next coordinated release. I will revisit it then. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477870] Review Request: eclipse-emf - Eclipse Modeling Framework (EMF) Eclipse plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477870 Mat Booth changed: What|Removed |Added Flag||fedora-cvs? --- Comment #19 from Mat Booth 2009-02-03 18:50:35 EDT --- Package Change Request == Package Name: eclipse-emf New Branches: F-10 Updated Summary: Eclipse Modeling Framework (EMF) Eclipse plugin Updated Description: The Eclipse Modeling Framework (EMF) allows developers to build tools and other applications based on a structured data model. From a model specification described in XMI, EMF provides tools and runtime support to produce a set of Java classes for the model, along with a set of adapter classes that enable viewing and command-based editing of the model, and a basic editor. This package was previously dead, so please could you also check that the devel branch is set up correctly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483863] Review Request: g3dviewer - A 3D file/object viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483863 Fabian Affolter changed: What|Removed |Added Depends on||483859 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483859] Review Request: libg3d - Library for 3D file/object viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483859 Fabian Affolter changed: What|Removed |Added Blocks||483863 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483863] New: Review Request: g3dviewer - A 3D file/object viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: g3dviewer - A 3D file/object viewer https://bugzilla.redhat.com/show_bug.cgi?id=483863 Summary: Review Request: g3dviewer - A 3D file/object viewer Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: fab...@bernewireless.net QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://fab.fedorapeople.org/packages/SRPMS/g3dviewer.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/g3dviewer-0.2.99.4-1.fc10.src.rpm Project URL: http://automagically.de/g3dviewer/ Description: G3DViewer is a 3D file viewer for GTK+ supporting a variety of file types: * 3D Studio (.3ds, .prj) * LightWave (.lw, .lwb, .lwo) * Alias Wavefront (.obj) * Impulse TurboSilver / Imagine (.iob) * AutoCAD (.dxf) * Quake II Models (.md2) * Quake III Models (.md3) * Neutral File Format (.nff) * 3D Metafile (.3dmf, .3mf, .b3d) * Caligari TrueSpace Objects (.cob) * Quick3D Objects & Scenes (.q3o, q3s) * VRML 1.0 files (.wrl, .vrml) * AC3D objects (.ac, .acc) * LeoCAD Models (.lcd) * Racer car models (.ar, .dof) * Ultimate Stunts car models (.glb) * VDrift car models (.joe, .car) * COLLADA & G**gle Earth (.dae, .kmz) * LDraw (.dat, .mpd) * ASCII Scene Exporter (.ase) Koji scratch build: depends on libg3d rpmlint output: [...@laptop24 i386]$ rpmlint g3dviewer* 2 packages and 0 specfiles checked; 0 errors, 0 warnings. [...@laptop24 SRPMS]$ rpmlint g3dviewer-0.2.99.4-1.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483543] Review Request: SystemTapGuiServer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483543 William Cohen changed: What|Removed |Added CC||wco...@redhat.com --- Comment #1 from William Cohen 2009-02-03 17:45:14 EDT --- This RPM will build on different architectures. Remove the following from the spec file: BuildArch: i386 Make the rpm file name agree with the one in: https://bugzilla.redhat.com/show_bug.cgi?id=483205 Allow someone to do: yum install "*stapgui*" -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 472269] Review Request: python-rope - Python Code Refactoring Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472269 Toshio Ernie Kuratomi changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Toshio Ernie Kuratomi 2009-02-03 14:50:54 EDT --- New Package CVS Request === Package Name: python-rope Short Description: Python Code Refactoring Library Owners: toshio Branches: F-10 devel InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479750] Review Request: libcelt - low-latency compressed audio format for voice and music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479750 Bug 479750 depends on bug 478941, which changed state. Bug 478941 Summary: Review Request: celt - An audio codec for use in low-delay speech and audio communication https://bugzilla.redhat.com/show_bug.cgi?id=478941 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467421] Review Request: mingw32-gtk-vnc - MinGW Windows port of VNC client GTK widget
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=467421
Michel Alexandre Salim changed:
What|Removed |Added
Flag||needinfo?(rjo...@redhat.com
||)
--- Comment #3 from Michel Alexandre Salim
2009-02-03 19:02:42 EDT ---
Note: SRPM URL no longer valid, and the Source0 field does not provide a URL;
I'm reviewing the slightly modified spec, using the newest gtk-vnc release.
It looks like all patches can be dropped; I only have several things to
clarify. Most of them are listed below, but also this:
Documentation: the guideline specifies that man and info pages can be left out
if they duplicate the pages in the main Fedora package. But how about license
texts, README, ChangeLog, etc. -- the files that normally go under %doc ?
Updated spec attached.
MUST:
+ rpmlint: clean (but no documentation)
+ package name
+ spec file name
+ package guideline-compliant
+ license complies with guidelines
+ license field accurate
- license file not deleted
+ spec in US English
+ spec legible
- source matches upstream
+ builds under >= 1 archs, others excluded
+ build dependencies complete
N/A locales handled using %find_lang, no %{_datadir}/locale
? library -> ldconfig (this is not needed for MinGW, I suppose?)
N/A relocatable: give reason
+ own all directories
+ no dupes in %files
+ permission
+ %clean RPM_BUILD_ROOT
+ macros used consistently
+ Package contains code
N/A large docs => -doc
N/A doc not runtime dependent
? headers in -devel: presumably all mingw32- packages are meant for
cross-compiling, so this is irrelevant?
N/A static in -static
+ if contains *.pc, req pkgconfig
? if libfiles are suffixed, the non-suffixed goes to devel
? devel requires versioned base package
N/A desktop file uses desktop-file-install
N/A clean buildroot before install
+ filenames UTF-8
SHOULD
N/A if license text missing, ask upstream to include it
- desc and summary contain translations if available
? package build in mock on all architectures
Not tested -- not all dependencies in Fedora yet, thus no Koji
+ package functioned as described
+ scriplets are sane
N/A other subpackages should require versioned base
+ if main pkg is development-wise, pkgconfig can go in main package
+ require package not files
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467421] Review Request: mingw32-gtk-vnc - MinGW Windows port of VNC client GTK widget
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467421 --- Comment #4 from Michel Alexandre Salim 2009-02-03 19:10:58 EDT --- Created an attachment (id=330802) --> (https://bugzilla.redhat.com/attachment.cgi?id=330802) Updated patch for gtk-vnc-0.3.8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483846] Review Request: gsim85 - An 8085 microprocessor simulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483846 --- Comment #2 from Fabian Affolter 2009-02-03 19:15:23 EDT --- Thanks for your inputs (In reply to comment #1) > There is a small cosmetic issue with the desktop file: the icon should either > contain the full path to the file or just the name (without extension). Your > desktop file contains name.extension. Added a small patch > As a minor non-blocking issue, you have a duplicate BR, gtk2-devel is brought > in by libglade2-devel. fixed > It would be awesome if you also convince the installer to preserve the > timestamps of the pixmaps. Given the build log, I'd say that adding > INSTALL="install -p" to "make install "should do it. fixed Here are the updated files Spec URL: http://fab.fedorapeople.org/packages/SRPMS/gsim85.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/gsim85-0.2-2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225958] Merge Review: kbd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225958 manuel wolfshant changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|wo...@nobugconsulting.ro Flag||fedora-review? --- Comment #1 from manuel wolfshant 2009-02-03 19:13:13 EDT --- rpmlint is not really happy at all: rpmlint of source RPM: kbd.src:20: W: unversioned-explicit-obsoletes console-tools kbd.src:20: W: unversioned-explicit-obsoletes open kbd.src:21: W: unversioned-explicit-provides console-tools kbd.src:21: W: unversioned-explicit-provides open kbd.src:23: E: prereq-use initscripts >= 5.86-1 kbd.src:73: E: hardcoded-library-path in $RPM_BUILD_ROOT/lib/kbd/keymaps/i386/qwerty/ro_win.map.gz kbd.src:76: E: hardcoded-library-path in $RPM_BUILD_ROOT/lib/kbd/keymaps/i386/qwerty/sr-latin.map.gz kbd.src:80: E: hardcoded-library-path in $RPM_BUILD_ROOT/lib/kbd/keymaps/i386/qwerty/ko.map.gz kbd.src:109: E: hardcoded-library-path in /lib/kbd kbd.src: W: no-url-tag rpmlint of kbd: kbd.x86_64: W: file-not-utf8 /usr/share/doc/kbd-1.15/ChangeLog kbd.x86_64: W: no-url-tag I think that --localedir=/usr/share/locale should be replaced with --localedir=%_datadir/locale At least the COPYING file from the root dir should be included as %doc. I suggest to also add doc/dvorak -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225958] Merge Review: kbd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225958 manuel wolfshant changed: What|Removed |Added CC||vcrho...@redhat.com --- Comment #2 from manuel wolfshant 2009-02-03 19:14:27 EDT --- Seems like the real maintainer is not mitr any more... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483553] Review Request: mingw32-libltdl - Runtime libraries for GNU Libtool Dynamic Module Loader
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483553 Hans Ulrich Niedermann changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #11 from Hans Ulrich Niedermann 2009-02-03 16:23:03 EDT --- Built package for rawhide (CVS tag mingw32-libltdl-1.5.26-12.fc11). Built package for F-10 (CVS tag mingw32-libltdl-1.5.26-12.fc10) and submitted for updates-testing. Closing review request bug accordingly. Thanks for all the help. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481022] Review Request: SPE - Stani's Python Editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481022 --- Comment #8 from MERCIER 2009-02-03 14:23:24 EDT --- pygame and python-quixote is optionnal package i use spe without this package and spe works perfectly -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476460] Review Request: pymilter - Python interface to sendmail milter API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476460 --- Comment #20 from Stuart D Gathman 2009-02-03 17:07:28 EDT --- While testing install on EL5 with SELinux enabled, I found that this is required: # chcon -t textrel_shlib_t '/usr/lib/python2.4/site-packages/milter.so' Should I go ahead and add that to %post processing? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483853] New: Review Request: tcl-trf - Tcl extension providing "transformer" commands
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: tcl-trf - Tcl extension providing "transformer" commands https://bugzilla.redhat.com/show_bug.cgi?id=483853 Summary: Review Request: tcl-trf - Tcl extension providing "transformer" commands Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: tcall...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://www.auroralinux.org/people/spot/review/new/tcl-trf.spec SRPM URL: http://www.auroralinux.org/people/spot/review/new/tcl-trf-2.1.3-1.fc11.src.rpm Description: Trf is an extension library to the script language tcl. It provides transformer procedures which change the flow of bytes through a channel in arbitrary ways. The underlying functionality in the core is that of stacked channels which allows code outside of the core to intercept all actions (read/write) on a channel. Among the applications of the above provided here are compression, charset recording, error correction, and hash generation. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478767] Review Request: spring - Realtime strategy game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478767 Aurelien Bompard changed: What|Removed |Added Flag||needinfo?(ianwel...@gmail.c ||om) --- Comment #27 from Aurelien Bompard 2009-02-03 17:56:06 EDT --- OK, I've asked upstream about that[1], and they advised me to use the CMake buildsystem, so I switched the build to that. [1] http://spring.clan-sy.com/phpbb/viewtopic.php?p=330802#p330802 I've checked that it still works, that rpmlint is still silent, and that it builds in koji on dist-f11, so hopefully everything is still OK. New package: http://gauret.free.fr/fichiers/rpms/fedora/spring/spring-0.78.2.1-6.fc10.src.rpm Oh, and I've checked that users of this package can still play online, which was upstream's concern. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467421] Review Request: mingw32-gtk-vnc - MinGW Windows port of VNC client GTK widget
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467421 Michel Alexandre Salim changed: What|Removed |Added Status|NEW |ASSIGNED CC||michel.syl...@gmail.com AssignedTo|nob...@fedoraproject.org|michel.syl...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483859] New: Review Request: libg3d - Library for 3D file/object viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: libg3d - Library for 3D file/object viewer https://bugzilla.redhat.com/show_bug.cgi?id=483859 Summary: Review Request: libg3d - Library for 3D file/object viewer Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: fab...@bernewireless.net QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://fab.fedorapeople.org/packages/SRPMS/libg3d.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/libg3d-0.0.8-1.fc10.src.rpm Project URL: http://automagically.de/g3dviewer/ Description: This library loads 3D models from various file formats. Its aim is to support basic import functionality for as much formats as possible. More complete support is better, of course, and the long time goal. To help developing plugins and for general use, too, there are a lot of basic 3d manipulation function, including vector and matrix math, common file reading stuff, transformations and 3d primitive support. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1102543 rpmlint output: [...@laptop24 i386]$ rpmlint libg3d* 3 packages and 0 specfiles checked; 0 errors, 0 warnings. [...@laptop24 SRPMS]$ rpmlint libg3d-0.0.8-1.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478770] Review Request: springlobby - A lobby client for the spring RTS game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478770 Aurelien Bompard changed: What|Removed |Added Flag||needinfo?(ianwel...@gmail.c ||om) --- Comment #2 from Aurelien Bompard 2009-02-03 18:02:30 EDT --- * Tue Feb 03 2009 Aurelien Bompard 0.0.1.10393-1 - version 10393 - add patch to detect libunitsync.so properly - drop workaround for bug 478589 http://gauret.free.fr/fichiers/rpms/fedora/spring/springlobby-0.0.1.10393-1.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477870] Review Request: eclipse-emf - Eclipse Modeling Framework (EMF) Eclipse plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477870 Mat Booth changed: What|Removed |Added Flag|needinfo?(fed...@matbooth.c | |o.uk) | --- Comment #15 from Mat Booth 2009-02-03 16:12:31 EDT --- Hi Andrew, thanks for taking the time. (In reply to comment #13) > I'll take this review. > > Everything looks good to me. I have a few questions: > > - does this comment mean we have reduced functionality? > > "... these files aren't needed for source plugins; they are only needed > "so the example-installer plugins can create full projects in your > workspace)" > No, nothing is lost. I will change that comment to be clearer. The files are still included such that they are present when you create the sample plugin projects in your workspace. (They are merely omitted from the associated source plugins of the sample plugins in the same way they are omitted from the associated source plugins of all other regular plugins.) If that makes any sense. To see what I mean just try creating some of the EMF sample plugins projects through the new example wizard and making sure the .project/.classpath files get created. > - could we match upstream's qualifier instead of that of the build? I worry > this will give multilib conflicts since the builds on x86_64 and x86 will > happen on different machines without the same hour and minute. If we can't > match upstream's qualifier (in the case they're all different), just set it to > something sane so all arches end up the same. I'm not sure I understand the multilib concern; this is a noarch package. It's no bother to change the qualifier though. Does it have any significance above being just the time it was built? > - why not use separate dropins directories for the sub-packages? This gives a > much cleaner %files section > No real reason beyond keeping the directory structure the build process gave me. (The resulting zip expands neatly into a single dropin directory during %install.) I can change it if you'd prefer. (In reply to comment #14) > As for the > > FIX rpmlint shows no warnings > > The only one is this: > > eclipse-emf.noarch: W: obsolete-not-provided eclipse-emf-standalone > > I think we need a Provide there as well (see > http://fedoraproject.org/wiki/PackagingDrafts/ProvidesObsoletes) > Erm, yeah. It was after reading that link that I decided that we *don't* need a Provides there because we no longer provide the files that the obsoleted package provided in a compatible way. From that article: "if a package supersedes/replaces an existing package without being a compatible enough replacement as defined in above, use only the Obsoletes". That way of using EMF is genuinely obsolete and no longer supported upstream (and I don't believe there are any packages in Fedora that depend on it anyway). Is it really necessary to Provides it? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
